[wp-trac] [WordPress Trac] #58563: Undefined variable $checkout in class-wp-automatic-updater.php line 175

[WordPress Trac]

#58563: Undefined variable $checkout in class-wp-automatic-updater.php line 175
-------------------------------------------------+-------------------------
 Reporter:  jqz                                  |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.3
Component:  Upgrade/Install                      |     Version:  6.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests reporter-   |     Focuses:
  feedback needs-testing-info needs-testing      |
-------------------------------------------------+-------------------------
Changes (by costdev):

 * keywords:  has-patch has-unit-tests =>
     has-patch has-unit-tests reporter-feedback needs-testing-info needs-
     testing
 * focuses:  coding-standards =>
 * version:  6.2.2 => 6.2
 * milestone:  Awaiting Review => 6.3


Comment:

 Hi @jqz, thanks for opening this ticket!

 Looks like there's two issues to resolve here:
 1. That the `$checkout` variable isn't initialized and, as the loop's
 early exit can prevent assignment to `$checkout`, this can be undefined by
 the time it reaches the `return` statement.
   - [https://github.com/WordPress/wordpress-develop/pull/4630 PR 4630]
 should handle this one.
 2. That `WP_Automatic_Updater::is_allowed_dir()` can return `false` for
 all directories on Windows, including `ABSPATH`.
   - This needs testing and some testing info.

 @jqz Can you provide your `open_basedir` directive (anonymized if
 necessary), and the value of the `ABSPATH` constant? Thanks!

 -----

 - This was introduced in [55425], setting `Version` to `6.2`.
 - Milestoning for `6.3` for visibility.

 @audrasjb @SergeyBiryukov Should this be milestoned for 6.2.3, or are we
 unlikely to land that before 6.3 is released?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58563#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform