[wp-trac] [WordPress Trac] #57839: Coding Standards fixes for WP 6.3

WordPress Trac noreply at wordpress.org
Thu Jun 15 21:25:19 UTC 2023


#57839: Coding Standards fixes for WP 6.3
--------------------------------------+-------------------------------
 Reporter:  hellofromTonya            |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  6.3
Component:  General                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  coding-standards
--------------------------------------+-------------------------------

Comment (by jeremyfelt):

 Just a heads up: The [https://github.com/WordPress/wordpress-
 develop/blob/9fe8cdf1264c1ab87ef234219aa3633cd5e7d3b2/src/wp-includes
 /class-wp-list-util.php#L124 strict comparison] added to
 `WP_List_Util::filter` via [55908] broke a test on a project I maintain.

 {{{
 // $created contains objects with maybe property disabled === '0'
 $active = wp_filter_object_list( $created, [ 'disabled' => 0 ] );
 }}}

 I like the change to strict comparison, so no complaint here. But, I'm not
 sure how much 3rd party code there may be that accidentally relies on this
 being loose. :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57839#comment:63>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list