[wp-trac] [WordPress Trac] #58317: Refactor determine_locale() for performance

WordPress Trac noreply at wordpress.org
Tue Jun 13 12:23:44 UTC 2023


#58317: Refactor determine_locale() for performance
--------------------------------------+--------------------------
 Reporter:  Cybr                      |       Owner:  swissspidy
     Type:  enhancement               |      Status:  reopened
 Priority:  normal                    |   Milestone:  6.3
Component:  I18N                      |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+--------------------------

Comment (by swissspidy):

 I see your points regarding the syntax and coding standards. They would be
 really good arguments for a proposal post on the make/core blog to revisit
 the topic. After a positive outcome we can tackle all these areas that you
 mention. I'd be happy to help write/review such a post.

 In the meantime I'll look into fixing the other things that I missed in
 the previous commit.

 > It appears that this standard isn't consistently applied in WordPress.
 As of writing, 109 instances of else if are present in WordPress
 /wordpress-develop's first-party code.

 Let's fix that then :) At first glance, only third-party libs and JS code
 uses `else if`, which is fine. But if there are valid cases, let's address
 them in a new ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58317#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list