[wp-trac] [WordPress Trac] #56577: Add short-circuit filter to `wp_setup_nav_menu_item`

[WordPress Trac]

#56577: Add short-circuit filter to `wp_setup_nav_menu_item`
-------------------------------------------------+-------------------------
 Reporter:  david.binda                          |       Owner:  azaozz
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.3
Component:  Menus                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing-info needs-patch 2nd-  |     Focuses:
  opinion                                        |  performance
-------------------------------------------------+-------------------------
Changes (by azaozz):

 * keywords:  has-patch needs-testing-info => needs-testing-info needs-patch
     2nd-opinion
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:10 SergeyBiryukov]:

 Thanks for adding the `@since` tag.

 Not sure why the description was reverted though. It's not a big deal but
 generally using the same word (Returning) in different contexts in the
 same sentence is considered poor usage of the English language. Imho the
 edited description is better and clearer.

 > using the `MockAction` class to confirm that the filter runs.

 Not sure why the unit test was refactored. Also not sure what is being
 tested now. The original test was testing the output of the
 `wp_setup_nav_menu_item()` function after the filter was used. The current
 test doesn't seem to be testing anything?

 Think the unit test should be fixed to test the output of
 `wp_setup_nav_menu_item()` after the filter was used.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56577#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform