[wp-trac] [WordPress Trac] #35517: Work around PHP7 php-ssh2 breakage

WordPress Trac noreply at wordpress.org
Mon Jun 12 01:20:14 UTC 2023


#35517: Work around PHP7 php-ssh2 breakage
------------------------------------+------------------------------
 Reporter:  dougal                  |       Owner:  (none)
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Filesystem API          |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  administration
------------------------------------+------------------------------

Comment (by dd32):

 Replying to [comment:30 costdev]:
 > dd32 Do you have any thoughts on this given that @ralphm's
 [https://core.trac.wordpress.org/ticket/35517#comment:23 proposed patch]
 has several reports of success?

 I don't have any recent experience with this module, I'm still supportive
 of removing the handler from Core however (Given <5% of sites have the
 extension, and less than that likely use it)

 That being said, using `intval()` seems ridiculous, this seems to be a PHP
 bug IMHO, but one that's existed for long enough that this should've been
 merged 5+ years ago. It's documented as needing intval in this example:
 https://www.php.net/manual/en/function.ssh2-sftp.php and
 https://www.php.net/manual/en/ref.ssh2.php#121929 shows why it's needed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/35517#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list