[wp-trac] [WordPress Trac] #58394: Performance of wp_maybe_inline_styles

[WordPress Trac]

#58394: Performance of wp_maybe_inline_styles
---------------------------+---------------------------
 Reporter:  spacedmonkey   |       Owner:  spacedmonkey
     Type:  enhancement    |      Status:  closed
 Priority:  normal         |   Milestone:  6.3
Component:  Script Loader  |     Version:
 Severity:  normal         |  Resolution:  fixed
 Keywords:  has-patch      |     Focuses:  performance
---------------------------+---------------------------
Changes (by spacedmonkey):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55888" 55888]:
 {{{
 #!CommitTicketReference repository="" revision="55888"
 Script Loader: Improve performance of wp_maybe_inline_styles function.

 The `wp_maybe_inline_styles` function is called twice on the average page
 load. On it's second run however, it did not check to see if the style had
 already been processed on the first run. This resulted in calling
 `filesize` and `get_file_contents` unnecessarily, which was bad for
 performance. Now, the loop around the queued styles, checks to see if the
 source is set to false, meaning it has already been processed. This change
 also replaces calls to `filesize` with the core function `wp_filesize`,
 which improves extensibility.

 Props spacedmonkey, flixos90, peterwilsoncc, joemcgill.
 Fixes #58394.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58394#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform