[wp-trac] [WordPress Trac] #58943: Replace `is_a` calls in core with `instanceof`

WordPress Trac noreply at wordpress.org
Mon Jul 31 13:09:03 UTC 2023


#58943: Replace `is_a` calls in core with `instanceof`
-------------------------+--------------------------------------------
 Reporter:  ayeshrajans  |       Owner:  SergeyBiryukov
     Type:  enhancement  |      Status:  accepted
 Priority:  normal       |   Milestone:  6.4
Component:  General      |     Version:  trunk
 Severity:  trivial      |  Resolution:
 Keywords:  has-patch    |     Focuses:  performance, coding-standards
-------------------------+--------------------------------------------

Comment (by costdev):

 > Re: use in tests - it should be considered if any such uses should be
 replaced with an `assertInstanceof()` assertion instead ? (not saying they
 should, just putting this out there as something to think about)

 I agree that we should consider this. Using descriptive assertions makes
 reading tests and failure messages much clearer.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58943#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list