[wp-trac] [WordPress Trac] #58576: locate_template does not check to see site has parent theme.

WordPress Trac noreply at wordpress.org
Fri Jul 21 15:52:19 UTC 2023


#58576: locate_template does not check to see site has parent theme.
--------------------------------------+--------------------------
 Reporter:  spacedmonkey              |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  6.4
Component:  Themes                    |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  performance
--------------------------------------+--------------------------

Comment (by nihar007):

 Replying to [comment:5 flixos90]:
 > @nihar007 The patch looks good, one recommendation though: Instead of
 manually checking the condition, I think we should use the
 `is_child_theme()` function instead which already contains that logic.
 >
 > An additional small benefit from using that will be that if we implement
 #58866 we would not need to update this logic here, but only the used
 function internally.


 Hi @flixos90,
 Thanks for your feedback. I am working on it

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58576#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list