[wp-trac] [WordPress Trac] #58555: Backport: Duotone changes, refactor, enhancements and fixes

[WordPress Trac]

#58555: Backport: Duotone changes, refactor, enhancements and fixes
-------------------------------------------------+-------------------------
 Reporter:  onemaggie                            |       Owner:
                                                 |  isabel_brison
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.3
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests gutenberg-merge has-  |     Focuses:
  patch                                          |
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 > TL;DR Many of the static methods are private to hide implementation
 details, and we have a couple static properties for caching some
 computation. Doing it this way was simpler than the alternatives when the
 public methods are intended to ''only'' be used with the hooks.

 I am not sure why these need to be static to do this. You can have private
 method that are not static.

 I have put together a PR for removing static. https://github.com/WordPress
 /wordpress-develop/pull/4860

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58555#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform