[wp-trac] [WordPress Trac] #56971: Add context to send_auth_cookies

WordPress Trac noreply at wordpress.org
Tue Jan 31 12:31:37 UTC 2023


#56971: Add context to send_auth_cookies
------------------------------+-----------------------
 Reporter:  dd32              |       Owner:  audrasjb
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  6.2
Component:  Users             |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Thanks for the commit!

 Just thinking, should the order of these new parameters be consistent with
 that of the `set_auth_cookie` and `set_logged_in_cookie` actions above?
 Like this:
 {{{
 if ( ! apply_filters( 'send_auth_cookies', true, $expire, $expiration,
 $user_id, $scheme, $token ) ) {
 }}}
 instead of this:
 {{{
 if ( ! apply_filters( 'send_auth_cookies', true, $user_id, $expire,
 $expiration, $token ) ) {
 }}}

 Or is the current order more preferable?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56971#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list