[wp-trac] [WordPress Trac] #56487: Bundled themes: opt-in to appearance tools

WordPress Trac noreply at wordpress.org
Tue Jan 24 16:47:48 UTC 2023


#56487: Bundled themes: opt-in to appearance tools
---------------------------+---------------------
 Reporter:  jffng          |       Owner:  (none)
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  6.2
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+---------------------

Comment (by poena):

 == Block Gap Testing Instructions
 Enable the appearance-tools theme support in your test theme.
 In the block editor, add a group block with three paragraphs.
 In the Dimensions panel in the block settings sidebar, set block spacing
 to seven.
 Take note if the space between the paragraphs changes.
 Save and view the space on the front.


 == Testing results:
 In emptytheme (block theme), the block gap correctly increases the
 spacing.

 CSS applied to paragraph one:
 {{{
 .wp-block-group.wp-container-1 > * {
         margin-block-start: 0;
         margin-block-end: 0;
 }
 }}}

 CSS applied to paragraph two:
 {{{
 .wp-block-group.wp-container-1.wp-block-group.wp-container-1 > * + * {
         margin-block-start: var(--wp--preset--spacing--80);
         margin-block-end: 0;
 }
 }}}

 CSS applied to paragraph three:

 {{{
 .wp-block-group.wp-container-1.wp-block-group.wp-container-1 > * + * {
         margin-block-start: var(--wp--preset--spacing--80);
         margin-block-end: 0;
 }

 }}}

 Twenty Twenty: The block gap does not work on the default group.
 CSS applied to the inner container:
 {{{
 wp-block-group.wp-container-2 > * {
         margin-block-start: 0;
         margin-block-end: 0;
 }
 }}}

 Paragraph one, Paragraph two, Paragraph three:
 No wp-container-2 CSS is applied.


 Twenty Twenty-One: The block gap does not work on the default group.
 CSS applied to the inner container:
 {{{
 wp-block-group.wp-container-2 > * {
         margin-block-start: 0;
         margin-block-end: 0;
 }
 }}}

 Paragraph one, Paragraph two, Paragraph three:
 No wp-container-2 CSS is applied.


 Twenty Sixteen ( tested for comparison )
 CSS applied to the inner container:
 {{{
 wp-block-group.wp-container-1 > * {
         margin-block-start: 0;
         margin-block-end: 0;
 }
 }}}

 Paragraph one, Paragraph two, Paragraph three:
 No wp-container-2 CSS is applied.

 Hello Elementor ( tested for comparison ): The block gap does not work on
 the default group.
 CSS applied to the inner container:

 {{{
 wp-block-group.wp-container-1 > * {
         margin-block-start: 0;
         margin-block-end: 0;
 }
 }}}

 Paragraph one, Paragraph two, Paragraph three:
 No wp-container-2 CSS is applied.



 == Conclusion
 The broken block gap for the default group block is not a problem with the
 themes, but with the block gap not supporting the old format of the group
 block which has the inner container.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56487#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list