[wp-trac] [WordPress Trac] #56830: jQuery Migrate deprecation in wpdialog

WordPress Trac noreply at wordpress.org
Tue Jan 24 09:19:39 UTC 2023


#56830: jQuery Migrate deprecation in wpdialog
----------------------------+-------------------------
 Reporter:  TobiasBg        |       Owner:  audrasjb
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  6.2
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  good-first-bug  |     Focuses:  javascript
----------------------------+-------------------------

Comment (by TobiasBg):

 Replying to [comment:7 shubham1gupta]:
 > Tried to reproduce the issue but couldn't.

 Can you clarify what part? The original deprecation notice or the (new) JS
 error?

 > Also note that /src/js/_enqueues/lib/dialog.js's
 [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/js/_enqueues/lib/dialog.js#L20 link] already
 contains the
 > {{{
 > this.element._trigger('focus');
 > }}}

 Yes, that's since [55052]. I'm suggesting to change `_trigger` to
 `trigger` now (no underscore).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56830#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list