[wp-trac] [WordPress Trac] #56604: Dark blue closing cross over the black background in plugins page

WordPress Trac noreply at wordpress.org
Fri Jan 20 16:53:40 UTC 2023


#56604: Dark blue closing cross over the black background in plugins page
-------------------------------------+-------------------------------------
 Reporter:  dperonne                 |       Owner:  joedolson
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  6.2
Component:  Plugins                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  ui, accessibility,
  patch needs-testing commit         |  css, administration
-------------------------------------+-------------------------------------
Changes (by joedolson):

 * keywords:  good-first-bug has-patch changes-requested needs-testing =>
     good-first-bug has-patch needs-testing commit


Comment:

 Updated patch to add a focus state indicator that's not purely dependent
 on color. Patch adds a 2px white outline on focus/hover.

 This was missing from the PR by @jeawhanlee, and improves on the 1px
 border added in the patch by @viralsampat. Using outline avoids a shift of
 position.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56604#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list