[wp-trac] [WordPress Trac] #56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a public function

WordPress Trac noreply at wordpress.org
Thu Jan 19 14:14:11 UTC 2023


#56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a
public function
-------------------------------------------------+-------------------------
 Reporter:  oandregal                            |       Owner:
                                                 |  hellofromTonya
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.2
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback gutenberg-merge has-    |     Focuses:
  patch has-unit-tests has-testing-info          |  performance
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:
     dev-feedback needs-testing-info gutenberg-merge has-patch has-unit-
     tests
     => dev-feedback gutenberg-merge has-patch has-unit-tests has-testing-
     info


Comment:

 There are 2 different solutions (detailed in [#comment:51 comment 51
 above]. Each has a PR to implement.

 Which solution should be implemented?

 I think Option 2 (stubbing in noob) is the better option for the long
 term.

 @azaozz @flixos90 Which option do you prefer?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56975#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list