[wp-trac] [WordPress Trac] #28407: You are unable to override the attachment name in wp_mail() when adding attachments

WordPress Trac noreply at wordpress.org
Wed Jan 18 12:58:21 UTC 2023


#28407: You are unable to override the attachment name in wp_mail() when adding
attachments
-------------------------------------------------+-------------------------
 Reporter:  syntaxart                            |       Owner:
                                                 |  johnjamesjacoby
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  6.2
Component:  Mail                                 |     Version:  3.9.1
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 In [changeset:"55087" 55087]:
 {{{
 #!CommitTicketReference repository="" revision="55087"
 Tests: Add unique messages to assertions for attachment filenames in
 `wp_mail()`.

 This makes the assertions more helpful, as per the
 [https://make.wordpress.org/core/handbook/testing/automated-testing
 /writing-phpunit-tests/#using-assertions Writing PHP Tests] guidelines:
 > All PHPUnit assertions, as well as all WordPress custom assertions,
 allow for a `$message` parameter to be passed. This message will be
 displayed when the assertion fails and can help immensely when debugging a
 test. This parameter should always be used if more than one assertion is
 used in a test method.

 Follow-up to [55030], [55032].

 Props mukesh27, costdev.
 See #28407.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/28407#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list