[wp-trac] [WordPress Trac] #3534: Hide password in setup-config.php

[WordPress Trac]

#3534: Hide password in setup-config.php
-------------------------------------------------+-------------------------
 Reporter:  xmarcos                              |       Owner:  rob1n
     Type:  enhancement                          |      Status:  reopened
 Priority:  low                                  |   Milestone:  6.2
Component:  Upgrade/Install                      |     Version:  2.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info has-screenshots dev-feedback      |  accessibility
-------------------------------------------------+-------------------------
Changes (by bgoewert):

 * keywords:  has-patch needs-testing has-testing-info has-screenshots =>
     has-patch needs-testing has-testing-info has-screenshots dev-feedback


Comment:

 Also meant to note on [https://github.com/WordPress/wordpress-
 develop/pull/3827 pr:3827] that `password-toggle.js` does not currently
 add/remove the dashicon. This was because the icon was left out of this
 text variation for `setup-config.php`. At an attempt to keep the button
 inline, my initial concern was that the icon would take space away from
 the input.

 As I noted already though, the icon can easily be re-added to remain
 consistent with the other password toggles. However, if `password-
 toggle.js` is to be used commonly, either the icons would need to be
 removed from the other areas or we re-add the icon here and the password
 input is consequently smaller.

 Awaiting feedback for which direction to go.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/3534#comment:60>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform