[wp-trac] [WordPress Trac] #57426: Coding Standards: mark warnings that trigger CI failures as errors.

[WordPress Trac]

#57426: Coding Standards: mark warnings that trigger CI failures as errors.
--------------------------------------------+------------------------------
 Reporter:  peterwilsoncc                   |       Owner:  (none)
     Type:  enhancement                     |      Status:  new
 Priority:  normal                          |   Milestone:  Awaiting Review
Component:  Build/Test Tools                |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch has-unit-tests close  |     Focuses:  coding-
                                            |  standards
--------------------------------------------+------------------------------
Changes (by GaryJ):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests close


Comment:

 PHPCS Errors and Warnings have different semantics. As well as Warnings
 being a strong suggestion, they can also be used when it's not possible to
 confidently determine if a bit of code is a violation or not i.e. it needs
 a human to verify (who can then either fix or add an ignore comment).

 Nullifying those semantics by treating all violations as Errors, just
 because your editor setup doesn't show Warnings sufficiently well, doesn't
 seem beneficial for everyone else.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57426#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform