[wp-trac] [WordPress Trac] #57426: Coding Standards: mark warnings that trigger CI failures as errors.

WordPress Trac noreply at wordpress.org
Thu Jan 5 21:46:55 UTC 2023


#57426: Coding Standards: mark warnings that trigger CI failures as errors.
------------------------------+-----------------------------
 Reporter:  peterwilsoncc     |      Owner:  (none)
     Type:  enhancement       |     Status:  new
 Priority:  normal            |  Milestone:  Awaiting Review
Component:  Build/Test Tools  |    Version:
 Severity:  normal            |   Keywords:
  Focuses:  coding-standards  |
------------------------------+-----------------------------
 The GitHub workflow for linting PHP currently fails for both warnings and
 errors, see this [https://github.com/WordPress/wordpress-
 develop/actions/runs/3526768168/jobs/5915073412 example run in which
 warnings error out].

 As warnings trigger CI errors, I think it would be beneficial to set the
 phpcs.xml.dist file to bump the severity of all warnings to errors.

 For developers using linting tools that default to showing errors only,
 this will ensure their editor/pre-merge script highlight anything that
 will cause the CI to fail.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57426>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list