[wp-trac] [WordPress Trac] #3534: Hide password in setup-config.php

[WordPress Trac]

#3534: Hide password in setup-config.php
-------------------------------------------------+-------------------------
 Reporter:  xmarcos                              |       Owner:  rob1n
     Type:  enhancement                          |      Status:  reopened
 Priority:  low                                  |   Milestone:  6.2
Component:  Upgrade/Install                      |     Version:  2.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info has-screenshots                   |  accessibility
-------------------------------------------------+-------------------------
Changes (by ironprogrammer):

 * keywords:  has-patch needs-testing has-testing-info => has-patch needs-
     testing has-testing-info has-screenshots


Comment:

 Thanks @bgoewert! I think this is almost there.

 == Test Report
 Patch tested: https://github.com/WordPress/wordpress-
 develop/pull/3725.diff (applied to `trunk`, testing based on instructions
 from comment:40)

 === Environment
 - Hardware: MacBook Pro Apple M1 Pro
 - OS: macOS 12.6.1
 - Browser: Safari 16.1, Google Chrome 108.0.5359.124, Mozilla Firefox
 107.0.1
 - Server: nginx/1.23.2
 - PHP: 7.4.33
 - WordPress: 6.2-alpha-54642-src
 - Password Manager: 1Password 7 v7.9.8

 === Actual Results
 - ✅ Password field shows "password" placeholder, defaults to `input
 type="password"`, and "open eye" icon is displayed.
 - ✅ "Eye" icon is not covered by 1Password 7 suggestion toggle icon in
 either the hidden or visible state.
 - ✅ Toggle functions as expected, hiding or showing the password.
 - ⚠️ In Chrome and Firefox on macOS, the toggle button's `:focus` outline
 is activated when clicked, which is visually different from Safari. ''See
 Figure 4.''
 - ⚠️ In RTL languages, the "eye" toggle shifts to the left of the field,
 separate from the 1Password toggle (compare this to RTL results in
 https://core.trac.wordpress.org/ticket/9883#comment:44 where the toggles
 remain grouped). ''See Figure 5.''

 === Supplemental Artifacts

 [[Image(https://cldup.com/ki9Fy_Dpfg.png, 80%)]]
 ''Figure 1: Default Password field state.''

 [[Image(https://cldup.com/1_eLv8G6lh.png, 80%)]]
 ''Figure 2: Field focused with password text entered.''

 [[Image(https://cldup.com/j-Iv1XKM40.png, 80%)]]
 ''Figure 3: Field focused with password visibility toggled on (Safari).''

 [[Image(https://cldup.com/qclOblawBW.png, 30%)]]
 ''Figure 4: Toggle's `:focus` is activated when clicked (macOS Chrome and
 Firefox).''

 [[Image(https://cldup.com/g-rnFLDQU7.png, 80%)]]
 ''Figure 5: RTL toggle placement separated from password app icon.''

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/3534#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform