[wp-trac] [WordPress Trac] #57716: Remove server-side redirection in site editor

[WordPress Trac]

#57716: Remove server-side redirection in site editor
-----------------------------------------+-----------------------------
 Reporter:  ntsekouras                   |       Owner:  hellofromTonya
     Type:  task (blessed)               |      Status:  reopened
 Priority:  normal                       |   Milestone:  6.2
Component:  Editor                       |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  gutenberg-merge needs-patch  |     Focuses:
-----------------------------------------+-----------------------------
Changes (by hellofromTonya):

 * keywords:  gutenberg-merge has-patch commit => gutenberg-merge needs-
               patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:9 johnbillion]:
 > @hellofromTonya @ntsekouras Can and should the
 `_resolve_home_block_template()` function be removed or deprecated? It's
 no longer used since [55338].

 Good catch @johnbillion! The code in this ticket was added in [53093]
 including `_resolve_home_block_template()`.

 Can it be removed or deprecated?
 Yes, I think so.

 * No longer used in Core or Gutenberg.
 * No instances in wordpress.org's
 [https://wpdirectory.net/search/01GTA3NZAHHCQY5HPQ1R3PJG3X plugin
 directory].
 * No instances in wordpress.org's
 [https://wpdirectory.net/search/01GTA3VEH6QTD4A72CCQZVBYCP theme
 directory].
 * It's marked private (internal Core usage).

 Here's its doc page
 https://developer.wordpress.org/reference/functions/_resolve_home_block_template/.

 Deprecate or remove?
 I'd like to remove it as it's not used (see above), likely low BC risk
 given its specific use case, and not wired as a callback. But "likely low
 BC risk" concerns me. Leaning towards deprecating.

 What do you think @johnbillion?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57716#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform