[wp-trac] [WordPress Trac] #53566: Pass the asset path to the `_doing_it_wrong()` notice in `register_block_script_handle()`

WordPress Trac noreply at wordpress.org
Mon Feb 20 21:48:47 UTC 2023


#53566: Pass the asset path to the `_doing_it_wrong()` notice in
`register_block_script_handle()`
----------------------------------------------------+---------------------
 Reporter:  desrosj                                 |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  6.2
Component:  Script Loader                           |     Version:
 Severity:  normal                                  |  Resolution:
 Keywords:  good-first-bug has-patch needs-testing  |     Focuses:
----------------------------------------------------+---------------------
Changes (by hellofromTonya):

 * keywords:  good-first-bug has-patch needs-testing changes-requested =>
     good-first-bug has-patch needs-testing


Comment:

 Patch: https://github.com/WordPress/wordpress-develop/pull/2313

 The patch has been updated with @desrosj feedback including using
 `empty()` to resolve the fatal error @robinwpdeveloper and @mahbubshovan
 caught (thank you!).

 @robinwpdeveloper @ironprogrammer this is ready for another round of
 testing, if you have time.

 @desrosj your feedback has been updated in the PR. If you have time,
 please re-review.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53566#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list