[wp-trac] [WordPress Trac] #57561: Update conditional logic for editor_styles

[WordPress Trac]

#57561: Update conditional logic for editor_styles
-------------------------------------------------+-------------------------
 Reporter:  mikachan                             |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  6.2
Component:  Script Loader                        |     Version:  6.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch gutenberg-merge has-       |     Focuses:
  testing-info                                   |
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 = Test Report

 Patch: https://github.com/WordPress/wordpress-develop/pull/3916

 Env:
 * OS: macOS
 * Browser: Firefox, Edge, and Chrome
 * Plugins: none
 * Theme: switched between TT2 and TT3

 Twenty Twenty-Two (TT2) is setting theme support for `'wp-block-styles'`
 whereas Twenty Twenty-Three (TT3) is not. Tested using both themes to
 validate the patch fixes TT3 without impacting TT2.

 == Results

 === TT3

 ==== Before applying the patch
 I am able to reproduce the issue ❌.

 As shown in [attachment:"tt3-before.png"], notice:
 * the `hr` visually looks the different between the post editor and front-
 end.
 * in the post editor, the `/wp-includes/css/dist/block-library/theme.css`
 stylesheet is loaded.

 ==== After applying the patch
 The issue is resolved ✅

 As shown in [attachment:"tt3-after.png"], notice:
 * the `hr` visually looks the same in the post editor and front-end ✅.
 * `/wp-includes/css/dist/block-library/theme.css` is no longer loaded into
 the post editor ✅ .

 === TT2

 ==== Before applying the patch

 As shown in [attachment:"tt2-before.png"], notice:
 * the `hr` visually looks the same in the post editor and front-end.
 * in the post editor, the `/wp-includes/css/dist/block-library/theme.css`
 stylesheet is loaded.

 ==== After applying the patch
 There's no difference ✅

 As shown in [attachment:"tt2-after.png"], notice:
 * the `hr` visually looks the same in the post editor and front-end.
 * `/wp-includes/css/dist/block-library/theme.css` is no longer loaded into
 the post editor.

 == Summary

 The patch:
 * fixes TT3 (a theme does not add `'wp-block-styles'` theme support) ✅
 * does not impact TT2 (a theme that does add `'wp-block-styles'` theme
 support) ✅

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57561#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform