[wp-trac] [WordPress Trac] #57150: Implement wp_cache_get_multiple() in wp_queue_posts_for_term_meta_lazyload()

[WordPress Trac]

#57150: Implement wp_cache_get_multiple() in
wp_queue_posts_for_term_meta_lazyload()
-------------------------------------------------+-------------------------
 Reporter:  ocean90                              |       Owner:
                                                 |  spacedmonkey
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.2
Component:  Taxonomy                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback has-unit-     |     Focuses:
  tests                                          |  performance
-------------------------------------------------+-------------------------
Changes (by skithund):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 My guess is that [55252] broke multilingual sites with translated posts
 using Polylang Pro plugin. [https://wordpress.org/plugins/polylang/
 Regular non-Pro Polylang] has 700+k installations.

 {{{
 Fatal error: Uncaught Error: Illegal offset type in isset or empty
 in /app/wordpress/wp-includes/class-wp-metadata-lazyloader.php on line 95
 }}}

 `var_dump()` of `$object_ids` in that function call looks like this.

 {{{
 array(3) {
   [0]=>
   object(WP_Term)#12582 (10) {
     ["term_id"]=>
     int(7)
     ["name"]=>
     string(17) "pll_611b764508d29"
     ["slug"]=>
     string(17) "pll_611b764508d29"
     ["term_group"]=>
     int(0)
     ["term_taxonomy_id"]=>
     int(7)
     ["taxonomy"]=>
     string(17) "post_translations"
     ["description"]=>
     string(48) "a:3:{s:2:"fi";i:12;s:2:"sv";i:14;s:2:"en";i:25;}"
     ["parent"]=>
     int(0)
     ["count"]=>
     int(3)
     ["filter"]=>
     string(3) "raw"
   }
   [1]=>
   int(2)
   [2]=>
   int(7)
 }
 }}}

 I'll try to get some extra bandwidth for later in the week to create
 reproduction steps and if it's reproducible with non-Pro version of
 Polylang. Error came from a production site pulled for development and
 core upgraded to nightly.

 Downgrading back to 6.1.1 fixes the problem in the same (development)
 environment.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57150#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform