[wp-trac] [WordPress Trac] #57583: Add support for editing block style variations in the global styles

WordPress Trac noreply at wordpress.org
Mon Feb 13 17:56:37 UTC 2023


#57583: Add support for editing block style variations in the global styles
-------------------------------------------------+-------------------------
 Reporter:  isabel_brison                        |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  closed
 Priority:  normal                               |   Milestone:  6.2
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch gutenberg-merge has-       |     Focuses:
  testing-info has-unit-tests commit             |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch gutenberg-merge has-testing-info has-unit-tests =>
     has-patch gutenberg-merge has-testing-info has-unit-tests commit
 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 As I noted above, the root cause is not this ticket or commit, but rather
 an invalid data type being registered in a different test. The PHP Warning
 being thrown is good as it alerts to an incompatibility / doing it wrong
 problem.

 I've opened a Trac ticket to fix the test that is throwing the PHP Warning
 #57706.

 The more I think about this, adding an `is_array()` check
 https://github.com/WordPress/wordpress-develop/pull/4014 will mask the
 problem, making it harder for developers to debug their code.

 I'm reclosing this ticket. The test fix will happen in #57706.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57583#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list