[wp-trac] [WordPress Trac] #57700: Incorrect $order_by parameter name in personal data exporter and eraser

[WordPress Trac]

#57700: Incorrect $order_by parameter name in personal data exporter and eraser
----------------------------+----------------------------------------
 Reporter:  SergeyBiryukov  |      Owner:  (none)
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  6.3
Component:  Comments        |    Version:  4.9.6
 Severity:  normal          |   Keywords:  needs-patch good-first-bug
  Focuses:  privacy         |
----------------------------+----------------------------------------
 [42888] / #43440 and [42994] / #43442 introduced these two functions:
 * `wp_comments_personal_data_exporter()`
 * `wp_comments_personal_data_eraser()`

 Both functions call `get_comments()` with `'order_by' => 'comment_ID'` as
 part of the arguments. However, the actual parameter name is `orderby`.

 This does not seem to affect anything in practice, as the incorrect
 parameter name is just ignored, and the `orderby` parameter defaults to
 `comment_date_gmt` instead, which should result in the same order on a
 typical installation.

 So the `order_by` parameter here can either be removed or corrected to
 `orderby`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57700>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform