[wp-trac] [WordPress Trac] #12821: Merge get_posts() and get_pages()

WordPress Trac noreply at wordpress.org
Tue Feb 7 13:35:27 UTC 2023


#12821: Merge get_posts() and get_pages()
-------------------------------------------------+-------------------------
 Reporter:  mikeschinkel                         |       Owner:
                                                 |  spacedmonkey
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.2
Component:  Posts, Post Types                    |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  needs-dev-note has-patch has-unit-   |     Focuses:
  tests needs-testing dev-feedback commit        |  performance
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 Replying to [comment:68 peterwilsoncc]:
 > #56689 also changed a function from using an SQL query to a wrapper for
 `WP_Query`. It was since reverted as it could cause an infinite loop if
 the function was called on a hook fired in `WP_Query`.
 >
 > A similar risk exists for converting this function to a `WP_Query`
 wrapper, so my inclination is to wait until early in the 6.3 cycle before
 making this change. It seems these changes are riskier than first thought,
 so the `early` tag is appropriate.
 >

 I feel like pushing this doesn't really do anything than delay this
 discussion. Bug found in #56689 BECAUSE it was in core and tested. At any
 point, we going to have commit and handle the issues as they come up.

 My votes is that we commit and if we do find issues, then can revert.
 Wonder the thoughts on @joemcgill @flixos90 @peterwilsoncc on this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/12821#comment:69>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list