[wp-trac] [WordPress Trac] #57376: Fix Mixcloud Embed url

WordPress Trac noreply at wordpress.org
Mon Feb 6 18:28:19 UTC 2023


#57376: Fix Mixcloud Embed url
--------------------------------------+-----------------------
 Reporter:  matclayton                |       Owner:  audrasjb
     Type:  defect (bug)              |      Status:  reopened
 Priority:  normal                    |   Milestone:  6.2
Component:  Embeds                    |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch needs-dev-note  |     Focuses:
--------------------------------------+-----------------------
Changes (by jeherve):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Coming back to this, I believe there may be an issue with the embed. This
 may be what caused the problems @audrasjb ran into when he tested the
 change.

 When querying
 `https://www.mixcloud.com/oembed?maxwidth=600&maxheight=750&url=https%3A%2F%2Fwww.mixcloud.com%2FTheBlessedMadonna
 %2Fwe-still-believe-episode-085-new-release-wall-
 special%2F&dnt=1&format=json`, you get the proper embed response in the
 body, after being redirected to
 `https://app.mixcloud.com/oembed/?maxwidth=600&maxheight=750&url=https%3A%2F%2Fwww.mixcloud.com%2FTheBlessedMadonna
 %2Fwe-still-believe-episode-085-new-release-wall-
 special%2F&dnt=1&format=json`
 -> This was the query you would have made with the old format (currently
 in Core).

 However, when querying
 `https://app.mixcloud.com/oembed?maxwidth=500&maxheight=750&url=https%3A%2F%2Fwww.mixcloud.com%2FTheBlessedMadonna
 %2Fwe-still-believe-episode-085-new-release-wall-
 special%2F&dnt=1&format=json` directly, you get an empty body. Notice the
 missing trailing `/` before the query parameters in the URL that fails.
 -> This is the new embed format introduced with this changeset.

 Should we update Core to have that trailing slash, or revert that change
 in Core to use the old format (that still works with the redirect) until
 Mixcloud can support URLs both with and without trailing slashes?

 Thank you!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57376#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list