[wp-trac] [WordPress Trac] #56689: Use WP_Query in get_page_by_path

[WordPress Trac]

#56689: Use WP_Query in get_page_by_path
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:
                                                 |  spacedmonkey
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:
Component:  Query                                |     Version:  trunk
 Severity:  normal                               |  Resolution:  wontfix
 Keywords:  needs-testing has-patch has-unit-    |     Focuses:
  tests has-testing-info 2nd-opinion             |  performance
-------------------------------------------------+-------------------------

Comment (by joemcgill):

 I'm totally fine with the resolution here, but wanted to comment a bit on
 the process to make sure that when folks like @spacedmonkey are working on
 performance enhancements in some of our core APIs during the alpha period
 of a WP Core release cycle that we have time to adequately identify and
 address issues like this that are discovered early in the cycle.

 We noticed during the bug scrub earlier week that this enhancement ticket
 had been [https://core.trac.wordpress.org/ticket/56689#comment:10
 reopened] by @iandunn due to the discovery of the `pre_get_posts` bug.

 When an enhancement is merged during the alpha period of a release cycle,
 my assumption is that the beta period of that cycle should be used to
 investigate and fix any bugs that are reported. If the bug can't be
 adequately addressed and the breakage is large enough that it warrants a
 revert, then the revert should be made as the final decision (at least for
 that release cycle) as it has been done here.

 Additionally, I strongly disagree with @Otto42's opinion stated here:

 > This has been in place, and broken, for three days now. It should have
 been reverted three days ago.

 The ability to collect feedback and fix bugs introduced during a release
 cycle is exactly what the alpha/beta periods are for, and it's an
 unrealistic expectation that people will be able to investigate and
 address feedback immediately. Anyone with systems that are dependent on
 running alpha software in production are assuming some risk in doing so.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56689#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform