[wp-trac] [WordPress Trac] #56228: Add main H1 heading in the site-editor page

WordPress Trac noreply at wordpress.org
Fri Feb 3 16:12:06 UTC 2023


#56228: Add main H1 heading in the site-editor page
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  joedolson
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.2
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch            |     Focuses:
  coordinate-with-gutenberg needs-refresh        |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch coordinate-with-gutenberg => has-
     screenshots has-patch coordinate-with-gutenberg needs-refresh


Comment:

 The patch needs some refresh. Some CSS changed on the Gutenberg side after
 the introduction of the Site editor 'Browse mode'.

 Also, it appears that Gutenberg overrides some core styles to change some
 general layout. It does that by targeting directly some elements, even
 when JS is off. Not sure that's ideal. for example:

 {{{
 html.wp-toolbar {
         background: $white;
         padding-top: 0;
 }
 }}}

 At the very least, this rule should be applied only when JS is on. Same
 for other CSS rules in Gutenberg. Unfortunately, right now there's no CSS
 class set on the `html` element to target whether JS is on or off.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56228#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list