[wp-trac] [WordPress Trac] #57557: Switch copy_dir() with move_dir() in WP_Upgrader::install_package

[WordPress Trac]

#57557: Switch copy_dir() with move_dir() in WP_Upgrader::install_package
-----------------------------+-----------------------------
 Reporter:  afragen          |       Owner:  SergeyBiryukov
     Type:  enhancement      |      Status:  accepted
 Priority:  high             |   Milestone:  6.2
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  performance
-----------------------------+-----------------------------

Comment (by azaozz):

 Replying to [comment:10 SergeyBiryukov]:

 > `WP_Upgrader::install_package()` only runs for plugin and theme updates.

 Right, called through `$this->run()` from `Plugin_Upgrader` and
 `Theme_Upgrader`. The same is also used for language packs, see
 `Language_Pack_Upgrader::bulk_upgrade()`. As this runs automatically,
 wondering if this case should be excluded for now, just to be on the safe
 side.

 Also wondering if it should be easier to make a "hotfix" plugin in case
 there are problems. Such plugin would help while preparing a .1 release
 (if needed).

 > Core updates use `Core_Upgrader::upgrade()` instead, which in turn calls
 `update_core()`.

 Yes, this seems to be the case for both manual and automatic core updates,
 full and partial.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57557#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform