[wp-trac] [WordPress Trac] #57557: Switch copy_dir() with move_dir() in WP_Upgrader::install_package

WordPress Trac noreply at wordpress.org
Wed Feb 1 16:34:53 UTC 2023


#57557: Switch copy_dir() with move_dir() in WP_Upgrader::install_package
-----------------------------+-----------------------------
 Reporter:  afragen          |       Owner:  SergeyBiryukov
     Type:  enhancement      |      Status:  accepted
 Priority:  high             |   Milestone:  6.2
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  performance
-----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch changes-requested => has-patch


Comment:

 Replying to [comment:4 peterwilsoncc]:
 > Discussing this with @azaozz, for 6.2 we'd like to limit the use of
 `move_dir()` to plugins and themes only. The Core updater ought to retain
 its current behavior.

 It appears that the current PR does exactly that, as
 `WP_Upgrader::install_package()` only runs for plugin and theme updates.
 Core updates use `Core_Upgrader::upgrade()` instead, which in turn calls
 `update_core()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57557#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list