[wp-trac] [WordPress Trac] #57582: Introduce dimensions.minHeight block support

[WordPress Trac]

#57582: Introduce dimensions.minHeight block support
-------------------------------------------------+-------------------------
 Reporter:  andrewserong                         |       Owner:
                                                 |  hellofromTonya
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  6.2
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests gutenberg-  |     Focuses:
  merge commit                                   |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55175" 55175]:
 {{{
 #!CommitTicketReference repository="" revision="55175"
 Editor: Introduce minimum height dimensions block support.

 This changeset adds the new dimension feature's PHP code for supporting
 minimum height in the block editor inspector and in global styles. Minimum
 height is quite useful for defining the minimum vertical dimensions of a
 block, while allowing it to expand beyond that size.

 In this changeset:

 * Adds support in `theme.json`.
 * Adds support in the style engine.
 * Adds support in `wp_apply_dimensions_support()`.
 * Renames the setting from `'__experimentalDimensions'` to `dimensions` in
 `wp_register_dimensions_support()`.
 * Adds PHPUnit tests.

 Is renaming `'__experimentalDimensions'` a backwards-compatibility (BC)
 break?

 Though the setting has been in the code since 5.9.0, it was never wired to
 anything, ie it did not expose any controls or styles. Notice in
 `wp_register_dimensions_support()` and `wp_apply_dimensions_support()`
 prior to this changeset, there are inline comments as placeholders for
 height and width support, but no code.

 If a developer opted in to use it, it had no effect.

 A search in wp.org's plugin and themes repo showed no instances of this
 experimental setting.

 Given there was no functionality attached to it (until this changeset), no
 change in behavior or effect from removing it, and no usage found in the
 plugins and themes repository, it does appear to be a BC break.

 References:
 * [https://github.com/WordPress/gutenberg/pull/45300 Gutenberg PR 45300]
 * [https://github.com/WordPress/gutenberg/pull/45334 Gutenberg PR 45334]

 Follow-up to [53076], [52069].

 Props andrewserong, aaronrobertshaw , costdev, hellofromTonya,
 isabel_brison, joen, paaljoachim, mukesh27, ntsekouras, oandregal,
 ramonopoly.
 Fixes #57582.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57582#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform