[wp-trac] [WordPress Trac] #60032: $body_id global variable return value int not string.

[WordPress Trac]

#60032: $body_id global variable return value int not string.
-----------------------------------------+-------------------------------
 Reporter:  upadalavipul                 |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  6.5
Component:  General                      |     Version:  4.3
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch changes-requested  |     Focuses:  coding-standards
-----------------------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch commit => has-patch changes-requested
 * version:  5.3 => 4.3


Comment:

 Hi there, thanks for the patch!

 * The suggested change does not look correct to me. `$body_id` is actually
 a string here, see where it's defined in [source:tags/6.4.2/src/wp-admin
 /media-upload.php?marks=81#L80 media-upload.php] or [source:tags/6.4.2/src
 /wp-admin/plugin-install.php?marks=59#L58 plugins-install.php].
 * `$body_id` is incorrectly documented as `int` in `wp_iframe()`. That
 should be updated to `string` instead.
 * This was not introduced in [45602] / #47632, but rather in [32643] /
 #32444.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60032#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform