[wp-trac] [WordPress Trac] #59198: Bulk actions "Update" ignores Minimum PHP Version Requirement

[WordPress Trac]

#59198: Bulk actions "Update" ignores Minimum PHP Version Requirement
-----------------------------+------------------------------
 Reporter:  salcode          |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------------------

Comment (by salcode):

 @afragen Thanks for looking at this and for the feedback.

 I suspect you are seeing that screen because you were already on `spatie-
 ray` version `1.7.4` ''before'' changing your PHP version to `7.4.30`.

 So the version of the plugin you already have installed (`1.7.4`) already
 requires PHP `8.0`, which your install does not meet, which causes

 1. The first message "This plugin does not work with your version of PHP."
 and
 2. disables the checkbox you called out in [https://github.com/WordPress
 /wordpress-develop/blob/7f38f687c4e45a2a28b214024c50cf145edeae0e/src/wp-
 admin/includes/class-wp-plugins-list-table.php#L992 src/wp-admin/includes
 /class-wp-plugins-list-table.php] on line 992*

 If you run the following commands to delete the plugin and re-install it
 at a version that is compatible with PHP `7.4`, you should be able to
 recreate the original issue for this ticket.

 {{{
 npm run env:cli -- wp plugin delete spatie-ray

 npm run env:cli -- wp plugin install spatie-ray --version=1.4.0
 }}}


 ^^*Note: It seems strange that the checkbox is disabled for updating the
 plugin based on the PHP version of the currently installed plugin (not the
 version available to update to). I suspect this may need its own ticket.

 -----

 > it would seem a similar patch is required for `class-theme-upgrader.php`
 too.

 My vote would be to handle the fix in `class-theme-upgrader.php` as a
 separate ticket with a separate set of testing steps as validating this
 fix is tricky enough 😀.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59198#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform