[wp-trac] [WordPress Trac] #59173: Improve optimizations of get_site_url by not using switch_to_blog

WordPress Trac noreply at wordpress.org
Wed Aug 23 15:00:09 UTC 2023


#59173: Improve optimizations of get_site_url by not using switch_to_blog
-------------------------------------+-------------------------------------
 Reporter:  PerS                     |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Networks and Sites       |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  multisite, performance
-------------------------------------+-------------------------------------
Changes (by johnbillion):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 Thanks for the ticket and PR @PerS. Some questions that will need
 answering before this change can be made:

 * Does `get_site_url()` have sufficient test coverage to make this change
 safe?
 * This change means the filters in `get_option()` will no longer fire when
 fetching the site URL, is that a concern? For example domain mapping
 plugins might break.
 * What sort of performance improvement does this result in?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59173#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list