[wp-trac] [WordPress Trac] #37719: Pre/Post Unzip Hooks

[WordPress Trac]

#37719: Pre/Post Unzip Hooks
---------------------------------------------+---------------------
 Reporter:  dfavor                           |       Owner:  (none)
     Type:  feature request                  |      Status:  new
 Priority:  normal                           |   Milestone:  6.4
Component:  Filesystem API                   |     Version:  3.0
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+---------------------
Changes (by costdev):

 * keywords:  2nd-opinion has-patch => has-patch has-unit-tests commit


Comment:

 > @azaozz Probably missing something but why not unset `$needed_dirs`
 after `do_action( 'post_unzip_file', ...`?

 Good point! I've updated [https://github.com/WordPress/wordpress-
 develop/pull/4220 PR 4220] to add this.

 > @oglekler I also wonder if `post_unzip_file` can be called
 `after_unzip_file` because otherwise it looks confusing.

 Agreed! I've updated [https://github.com/WordPress/wordpress-
 develop/pull/4220 PR 4220] to change the hook names to `before_unzip_file`
 and `after_unzip_file` for clarity. Tests are also included now to ensure
 these actions are fired.

 > Can we proceed with this patch?

 Yep I think this is ready for final review. 🙂

 -----
 - Removing `2nd-opinion` as we've had several opinions now.
 - Adding to the `commit` queue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37719#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform