[wp-trac] [WordPress Trac] #56431: Fatal Error on Update Page When a Plugin's Icon is Not Set

[WordPress Trac]

#56431: Fatal Error on Update Page When a Plugin's Icon is Not Set
-------------------------------------------------+-------------------------
 Reporter:  scott.deluzio                        |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-patch needs-testing dev-       |     Focuses:
  feedback reporter-feedback                     |
-------------------------------------------------+-------------------------

Comment (by costdev):

 @hellofromTonya
 > The difference matters as the first question is the developer doing it
 wrong but the second question may be an issue in Core itself.
 >
 > Before implementing a change, I think an understanding of how `icons`
 property can be an instance of `stdClass` is needed.

 I 100% agree.

 > - Should the update fail?
 This isn't so much about an update in progress, but rather when a plugin
 has an update available. AFAIK, the `icons` is from an API response. When
 `update-core.php` tries to output this information in the table, the fatal
 occurs, blocking all later output.

 > - How should the user and developer be alerted to the "doing it wrong"
 issue? Feedback is still needed to inform of the problem.
 ''If'' the `icons` value isn't set to `stdClass` by Core, we could be to
 put feedback behind `WP_DEBUG`, and use a default icon for the plugin that
 would otherwise trigger a fatal. The logic being that an icon issue
 shouldn't prevent a user from being able to see available updates, bulk
 select them, and run them.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56431#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform