[wp-trac] [WordPress Trac] #54827: Elemtentor, pagina

[WordPress Trac]

#54827: Elemtentor, pagina
-------------------------------------------------+-------------------------
 Reporter:  flashprice2020                       |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Formatting                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests php80       |     Focuses:
  changes-requested close reporter-feedback      |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch has-unit-tests php80 =>
     has-patch has-unit-tests php80 changes-requested close reporter-
     feedback


Comment:

 >More than anything, this needs a backtrace of what is causing the error
 and fixing in the actual problem code, not here.

 I agree.

 After evaluating, I am not adding the `php-compatibility` focus. Why? This
 ticket seems to be something outside of Core doing it wrong, rather than
 an incompatibility with PHP 8.0. The code expects and is documented as
 expected an `array`. Passing it anything else is doing it wrong.

 I agree with @jrf about adding defensive code to protect Core's source
 code. However, I think the topic of input (parameter/property) validation
 is more of an architectural consideration, one that should be discussed
 and considered for application across all of Core, rather than in
 individual functions.

 I'm inclined to close this ticket. Why?

 * The root cause does not appear to be Core. Thus it needs to be fixed in
 the code that is passing something other than an `array`.
 * Input (parameter/property) validation is more of an architectural
 consideration. Rather than adding a guard in this one function for
 something that should not happen, I think the discussion of input
 validation should move to a more broad architectural discussion. Once
 there's consensus, then functions like this one could receive the same
 defensive protection that will be applied to all others.

 I'm marking this ticket as `close` candidate and `reporter-feedback` to
 hopefully learn if the backtrace happened to identify which plugin, theme,
 or script caused it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54827#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform