[wp-trac] [WordPress Trac] #58896: Fix WP_List_Table magic methods for PHP 8.2 dynamic properties

WordPress Trac noreply at wordpress.org
Thu Aug 3 19:50:34 UTC 2023


#58896: Fix WP_List_Table magic methods for PHP 8.2 dynamic properties
-------------------------------------------------+-------------------------
 Reporter:  antonvlasenko                        |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.4
Component:  Administration                       |     Version:  4.0
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  php82 has-unit-tests commit has-     |     Focuses:  php-
  patch                                          |  compatibility
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56356" 56356]:
 {{{
 #!CommitTicketReference repository="" revision="56356"
 Code Modernization: Use "declare" in WP_List_Table magic methods
 deprecation message

 Changes "define" to "declare" in the deprecation message in
 `WP_List_Table` magic methods.

 Why is "declare" better?
 It aligns well to:

 * the topic of and published information about dynamic properties.
 * the act of explicitly listing the variable as a property on the class.

 The goal of this message is guide developers to change their code.
 Changing the term to "declare" hopefully will aid in the understanding of
 what is being asked of developers when this deprecation is thrown.

 Follow-up [56349].

 Props hellofromTonya, antonvlasenko.
 Fixes #58896.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58896#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list