[wp-trac] [WordPress Trac] #46550: Uncaught TypeError: setcookie() expects parameter 5 to be string, bool given in...

[WordPress Trac]

#46550: Uncaught TypeError: setcookie() expects parameter 5 to be string, bool
given in...
-------------------------+-------------------------------------------------
 Reporter:  kmvan        |       Owner:  (none)
     Type:  defect       |      Status:  new
  (bug)                  |
 Priority:  normal       |   Milestone:  6.4
Component:  Networks     |     Version:  5.2
  and Sites              |
 Severity:  minor        |  Resolution:
 Keywords:  has-patch    |     Focuses:  coding-standards, php-
  needs-testing          |  compatibility
-------------------------+-------------------------------------------------
Changes (by jrf):

 * keywords:  reporter-feedback has-patch => has-patch needs-testing
 * severity:  major => minor
 * milestone:  Awaiting Review => 6.4


Comment:

 > It causes no warnings nor errors in PHP unless strict typing is
 declared: https://3v4l.org/dEQk2.

 Agreed and using `strict_types = 1` in the context of WP is generally not
 the greatest idea as WP is as loosely as possible, so this would easily
 cause a mountain of errors.

 Having said that, the proposed fix looks like a good improvement, though
 for reasons of synchronicity with PHP core, not for compatibility reasons.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46550#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform