[wp-trac] [WordPress Trac] #58215: Does not defined global variable in the function.

[WordPress Trac]

#58215: Does not defined global variable in the function.
--------------------------+------------------------------
 Reporter:  upadalavipul  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  close         |     Focuses:
--------------------------+------------------------------
Changes (by mukesh27):

 * keywords:   => close


Comment:

 Hi there! thanks for ticket and patch!

 As per https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 admin/includes/update-core.php#L1109-L1115 we don't need to add those
 global variables.

 {{{
         /*
          * Import $wp_version, $required_php_version, and
 $required_mysql_version from the new version.
          * DO NOT globalize any variables imported from `version-
 current.php` in this function.
          *
          * BC Note: $wp_filesystem->wp_content_dir() returned unslashed
 pre-2.8.
          */
         $versions_file = trailingslashit( $wp_filesystem->wp_content_dir()
 ) . 'upgrade/version-current.php';
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58215#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform