[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.3
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-testing-info has-patch needs-    |     Focuses:
  dev-note commit                                |
-------------------------------------------------+-------------------------
Changes (by costdev):

 * keywords:  has-testing-info has-patch needs-dev-note needs-testing =>
     has-testing-info has-patch needs-dev-note commit
 * milestone:  Future Release => 6.3


Comment:

 Following
 [https://wordpress.slack.com/archives/CULBN711P/p1682532159750479 further
 discussions in Slack]:

 > For now it seems a good option would be to provide means for the users
 to retry a plugin or theme update without first creating a rollback
 backup. This could be achieved by not making backups when the users update
 by uploading a .zip file. This workaround will let anybody to fall back to
 the previous update code relatively easily.

 Manual uploads of .zip files via `Plugins > Add New > Upload Plugin`
 counts as an install rather than an upgrade and will not trigger the
 backup/restore logic of Rollback, so this workaround is already available.

 > It will also need a good explanation about what to do and how if plugins
 and themes updating keeps failing. Seems a suitable place would be at the
 top of the update screen.

 #58199 was created to address this and it was determined not to be a
 blocker for Rollback.

 > In both cases this is a long time without visual feedback
 >> Thinking this probably needs some user help/explanations too. At least
 a warning that updates may take several minutes would be nice. Another
 option would be to "fake it" with some JS although not sure if that's good
 enough :)

 As this was determined to be a pre-existing issue in Core, and that
 Rollback's use of `move_dir()` reduces the time without visual feedback,
 it was agreed that this isn't a blocker for Rollback. We should definitely
 address this issue in a separate ticket that documents reproduction steps.
 It appears that the lack of visual feedback only happens in some
 circumstances, which are unknown to me as yet.

 -----

 In addition, once we get #51928 committed to Core, we'll have some data
 for plugin/theme update failures to help determine pain points during the
 upgrade process as a whole.

 -----

 - Given extensive testing and positive test reports above, I'm removing
 `needs-testing`.
 - Given that there are no blockers for Rollback and that @azaozz and
 @peterwilsoncc have both said they're happy for it to go forward to final
 commit consideration, I'm adding `commit` and milestoning for 6.3.
 @SergeyBiryukov, do you have time to do this?
 - For the upgrade process as a whole, we should definitely get #58199 and
 #51928 landed in 6.3.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:306>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform