[wp-trac] [WordPress Trac] #56982: Empty ELSE statement in dbDelta()

WordPress Trac noreply at wordpress.org
Wed Apr 26 15:08:52 UTC 2023


#56982: Empty ELSE statement in dbDelta()
-----------------------------+-------------------------------
 Reporter:  krunal265        |       Owner:  SergeyBiryukov
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  6.3
Component:  Upgrade/Install  |     Version:  1.5
 Severity:  trivial          |  Resolution:  fixed
 Keywords:  dev-feedback     |     Focuses:  coding-standards
-----------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55688" 55688]:
 {{{
 #!CommitTicketReference repository="" revision="55688"
 Coding Standards: Remove an empty `else` statement in `dbDelta()`.

 Use `continue` to help separate each case for better readability, instead
 of having a wall of `if`/`elseif`.

 Includes simplifying a similar fragment in
 `make_site_theme_from_default()`.

 Follow-up to [1575], [2037], [2040], [2044], [2346], [7999], [14080],
 [14485].

 Props costdev, krunal265, hellofromTonya, brookedot, SergeyBiryukov.
 Fixes #56982.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56982#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list