[wp-trac] [WordPress Trac] #58181: wp_create_nonce() should not pass $action to wp_get_session_token()

WordPress Trac noreply at wordpress.org
Tue Apr 25 10:08:58 UTC 2023


#58181: wp_create_nonce() should not pass $action to wp_get_session_token()
----------------------------------------+---------------------
 Reporter:  dd32                        |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  6.3
Component:  General                     |     Version:
 Severity:  trivial                     |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:
----------------------------------------+---------------------

Comment (by hztyfoon):

 Good Catch, Thanks for reporting it.

 Thanks @malavvasita for the patch. I've checked your
 [https://core.trac.wordpress.org/attachment/ticket/58181/58181.patch
 58181.patch] and looks like the php comment `This function does not catch
 any $action` after the `wp_get_session_token` function call is
 unnecessary.

 I'm creating a PR so that we can move forward from there.
 PR incoming.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58181#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list