[wp-trac] [WordPress Trac] #58129: Rename the $myHTML parameter in htmlentities2()

WordPress Trac noreply at wordpress.org
Fri Apr 14 01:25:51 UTC 2023


#58129: Rename the $myHTML parameter in htmlentities2()
--------------------------------------+-------------------------------
 Reporter:  SergeyBiryukov            |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  6.3
Component:  Formatting                |     Version:
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  good-first-bug has-patch  |     Focuses:  coding-standards
--------------------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55651" 55651]:
 {{{
 #!CommitTicketReference repository="" revision="55651"
 Coding Standards: Rename the `$myHTML` parameter to `$text` in
 `htmlentities2()`.

 This resolves a WPCS warning:
 {{{
 Variable "$myHTML" is not in valid snake_case format, try "$my_h_t_m_l"
 }}}

 It also matches other formatting functions with the `$text` parameter,
 e.g. `esc_html()`, `ent2ncr()`, etc.

 Follow-up to [1727], [3717], [8662], [8743], [54927].

 Props victoranto, audrasjb, jrf.
 Fixes #58129.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58129#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list