[wp-trac] [WordPress Trac] #58102: Check PHPcs Coding standard into the wp-includes folder

WordPress Trac noreply at wordpress.org
Tue Apr 11 16:49:55 UTC 2023


#58102: Check PHPcs Coding standard into the wp-includes folder
--------------------------+-------------------------------
 Reporter:  viralsampat   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  coding-standards
--------------------------+-------------------------------

Comment (by NekoJonez):

 Replying to [comment:4 krupalpanchal]:
 > Shouldn't all the changes be in one diff file instead of multiple, like
 58102.diff, 58102.2.diff etc. Or is that okay to have multiple diff files?
 >
 > Because in the 58102.diff, there is a change in the option.php file. In
 58102.2.diff, there is a change in admin-bar.php and so on.

 I think it's best practice to set them all in one file. Otherwise it looks
 like we have 4 different versions of one patch...

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58102#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list