[wp-trac] [WordPress Trac] #58039: Fix non-strict checking issue on options-writing.php file

[WordPress Trac]

#58039: Fix non-strict checking issue on options-writing.php file
---------------------------+-------------------------------
 Reporter:  faisalahammad  |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  General        |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  coding-standards
---------------------------+-------------------------------
Changes (by audrasjb):

 * version:  trunk =>


Comment:

 Hello and thanks for the ticket and patch @faisalahammad,

 On a default and fresh WordPress installation, `get_option( 'blog_public'
 )` returns a string, not an integer or a boolean, so actually, the
 proposed patch will probably break the condition.

 Also, the above PR contains a lot of unrelated changes, and these changes
 contain [https://github.com/WordPress/wordpress-
 develop/actions/runs/4582918785/jobs/8093440578?pr=4274 some coding
 standards issues].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58039#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform