[wp-trac] [WordPress Trac] #58048: Fix non-strict checking issue in /wp-admin/includes/class-ftp.php

WordPress Trac noreply at wordpress.org
Sun Apr 2 13:52:08 UTC 2023


#58048: Fix non-strict checking issue in /wp-admin/includes/class-ftp.php
--------------------------+-------------------------------
 Reporter:  sharif200     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  coding-standards
--------------------------+-------------------------------

Comment (by kebbet):

 This file is part of the PemFTP-package. So not really sure if fixes
 should be applied directly in WordPress core, or upstream. There are
 changes applied to it in WordPress core (and not upstream). And there are
 multiple more issues in the file than the simple fix added in the linked
 PR, such as whitespaced, Yoda conditions and so forth.

 Is the package adobted by core?

 https://www.phpclasses.org/package/1743-PHP-FTP-client-in-pure-PHP.html

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58048#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list