From noreply at wordpress.org Sat Oct 1 00:38:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 00:38:26 -0000 Subject: [wp-trac] [WordPress Trac] #56705: I want fix Links are not crawlable Message-ID: <054.ac7c32f35ca398a4d62cedd514320a62@wordpress.org> #56705: I want fix Links are not crawlable --------------------------+----------------------------- Reporter: ahm3dsamir | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I want Links that are not crawlable on my website [as-educate]https://as- educate.com/ Uncrawlable Link {{{ }}} [[Image(https://ibb.co/rb5Ctw6)]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 00:38:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 00:38:49 -0000 Subject: [wp-trac] [WordPress Trac] #56705: I want fix Links are not crawlable In-Reply-To: <054.ac7c32f35ca398a4d62cedd514320a62@wordpress.org> References: <054.ac7c32f35ca398a4d62cedd514320a62@wordpress.org> Message-ID: <069.26dc912105ada7e19468f459cc1db050@wordpress.org> #56705: I want fix Links are not crawlable --------------------------+------------------------------ Reporter: ahm3dsamir | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by ahm3dsamir): * Attachment "Links are not crawlable.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 02:17:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 02:17:25 -0000 Subject: [wp-trac] [WordPress Trac] #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. Message-ID: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. ------------------------------+--------------------------------------- Reporter: costdev | Owner: costdev Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Keywords: has-screenshots has-patch Focuses: | ------------------------------+--------------------------------------- == How was this discovered? While adding new tests for `wp_list_pluck()`, I noticed that the coverage report included coverage that should not have been possible. == Steps to reproduce 1. Add the following to your PHPUnit configuration file (either `phpunit.xml.dist`, or copy this to `phpunit.xml`. {{{#!xml src/wp-includes/class-wp-list- util.php }}} 2. Add the following test method to `tests/phpunit/tests/functions/wpListPluck.php`. {{{#!php assertTrue( true ); } }}} 3. Run: {{{ XDEBUG_MODE=coverage phpunit --filter test_set_up_causes_wp_list_util_pluck_coverage_bug }}} 4. Navigate to: {{{ http://localhost/wordpress-develop/tests/phpunit/build/logs/coverage-html /class-wp-list-util.php.html }}} 5. Click `pluck`. 6. 🐞 Observe that `$newlist[ $key ] = $value->$field;` (Line 168) is unexpectedly covered. == What's happening? Huge thanks to @jrf for research on this! - `WP_UnitTestCase_Base::set_up()` calls `WP_UnitTestCase_Base::reset_post_statuses()`. - Which calls `get_post_stati()`. - Which calls `wp_filter_object_list()`. - Which calls `WP_List_Util::pluck()`. 💥 Since code called in `WP_UnitTestCase_Base::set_up()` is included in coverage reports, this presents an inaccurate coverage report for `wp_list_pluck()/WP_List_Util::pluck()`. == Solutions The real solution involves ensuring that the code under test is not called in `WP_UnitTestCase_Base::set_up()`. However, this is best done after a wider discussion on improving the test suite. For now, removing `parent::set_up()` from `Tests_Functions_wpListPluck::set_up()` will prevent inaccurate coverage and confusion for contributors. To allow for testing deprecation and incorrect usage notices, `$this->expectDeprecated()` should be added instead. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 02:18:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 02:18:09 -0000 Subject: [wp-trac] [WordPress Trac] #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. In-Reply-To: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> References: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> Message-ID: <066.dd2c3d5426eb341de7090baff28a7e62@wordpress.org> #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. ---------------------------------------+----------------------- Reporter: costdev | Owner: costdev Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+----------------------- Changes (by costdev): * Attachment "WP_List_Util.pluck.inaccurate.coverage.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 02:18:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 02:18:22 -0000 Subject: [wp-trac] [WordPress Trac] #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. In-Reply-To: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> References: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> Message-ID: <066.b14ee18136d59485ea3012f186b4955b@wordpress.org> #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. ---------------------------------------+----------------------- Reporter: costdev | Owner: costdev Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+----------------------- Changes (by costdev): * Attachment "56706.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 02:19:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 02:19:04 -0000 Subject: [wp-trac] [WordPress Trac] #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. In-Reply-To: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> References: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> Message-ID: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. ---------------------------------------+----------------------- Reporter: costdev | Owner: costdev Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+----------------------- Changes (by costdev): * Attachment "56706.diff" removed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 02:19:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 02:19:04 -0000 Subject: [wp-trac] [WordPress Trac] #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. In-Reply-To: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> References: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> Message-ID: <066.c2bfd6ed1bd87313604b77368c00e0fa@wordpress.org> #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. ---------------------------------------+----------------------- Reporter: costdev | Owner: costdev Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+----------------------- Changes (by costdev): * Attachment "56706.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 02:22:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 02:22:45 -0000 Subject: [wp-trac] [WordPress Trac] #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. In-Reply-To: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> References: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> Message-ID: <066.0f59b448aefa9bf627cf06f0dac257b3@wordpress.org> #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. ---------------------------------------+----------------------- Reporter: costdev | Owner: costdev Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+----------------------- Description changed by costdev: Old description: > == How was this discovered? > > While adding new tests for `wp_list_pluck()`, I noticed that the coverage > report included coverage that should not have been possible. > > == Steps to reproduce > > 1. Add the following to your PHPUnit configuration file (either > `phpunit.xml.dist`, or copy this to `phpunit.xml`. > > {{{#!xml > pathCoverage="true" cacheDirectory="./tests/phpunit/build/logs/phpunit- > cache"> > > src/wp-includes/class-wp-list- > util.php > > > > > > > }}} > > 2. Add the following test method to > `tests/phpunit/tests/functions/wpListPluck.php`. > > {{{#!php > > /** > * @covers WP_List_Util::pluck > */ > public function test_set_up_causes_wp_list_util_pluck_coverage_bug() { > $this->assertTrue( true ); > } > }}} > > 3. Run: > {{{ > XDEBUG_MODE=coverage phpunit --filter > test_set_up_causes_wp_list_util_pluck_coverage_bug > }}} > > 4. Navigate to: > {{{ > http://localhost/wordpress-develop/tests/phpunit/build/logs/coverage-html > /class-wp-list-util.php.html > }}} > > 5. Click `pluck`. > 6. 🐞 Observe that `$newlist[ $key ] = $value->$field;` (Line 168) is > unexpectedly covered. > > == What's happening? > > Huge thanks to @jrf for research on this! > > - `WP_UnitTestCase_Base::set_up()` calls > `WP_UnitTestCase_Base::reset_post_statuses()`. > - Which calls `get_post_stati()`. > - Which calls `wp_filter_object_list()`. > - Which calls `WP_List_Util::pluck()`. 💥 > > Since code called in `WP_UnitTestCase_Base::set_up()` is included in > coverage reports, this presents an inaccurate coverage report for > `wp_list_pluck()/WP_List_Util::pluck()`. > > == Solutions > > The real solution involves ensuring that the code under test is not > called in `WP_UnitTestCase_Base::set_up()`. However, this is best done > after a wider discussion on improving the test suite. > > For now, removing `parent::set_up()` from > `Tests_Functions_wpListPluck::set_up()` will prevent inaccurate coverage > and confusion for contributors. To allow for testing deprecation and > incorrect usage notices, `$this->expectDeprecated()` should be added > instead. New description: == How was this discovered? While adding new tests for `WP_List_Util::pluck()`, I noticed that the coverage report included coverage that should not have been possible. == Steps to reproduce 1. Add the following to your PHPUnit configuration file, either `phpunit.xml.dist`, or copy this to `phpunit.xml`. {{{#!xml src/wp-includes/class-wp-list- util.php }}} 2. Add the following test method to `tests/phpunit/tests/functions/wpListPluck.php`. {{{#!php assertTrue( true ); } }}} 3. Run: {{{ XDEBUG_MODE=coverage phpunit --filter test_set_up_causes_wp_list_util_pluck_coverage_bug }}} 4. Navigate to: {{{ http://localhost/wordpress-develop/tests/phpunit/build/logs/coverage-html /class-wp-list-util.php.html }}} 5. Click `pluck`. 6. 🐞 Observe that parts of this method are unexpectedly covered. == What's happening? Huge thanks to @jrf for research on this! - `WP_UnitTestCase_Base::set_up()` calls `WP_UnitTestCase_Base::reset_post_statuses()`. - Which calls `get_post_stati()`. - Which calls `wp_filter_object_list()`. - Which calls `WP_List_Util::pluck()`. 💥 Since code called in `WP_UnitTestCase_Base::set_up()` is included in coverage reports, this presents an inaccurate coverage report for `WP_List_Util::pluck()`. == Solutions The real solution involves ensuring that the code under test is not called in `WP_UnitTestCase_Base::set_up()`. However, this is best done after a wider discussion on improving the test suite. For now, removing `parent::set_up()` from `Tests_Functions_wpListPluck::set_up()` will prevent inaccurate coverage and confusion for contributors. To allow for testing deprecation and incorrect usage notices, `$this->expectDeprecated()` should be added instead. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 02:37:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 02:37:16 -0000 Subject: [wp-trac] [WordPress Trac] #56494: REST API: Fix and test rest_default_additional_properties_to_false In-Reply-To: <057.48c8ae0bf5c5a7c7da513fdfdcb5ee78@wordpress.org> References: <057.48c8ae0bf5c5a7c7da513fdfdcb5ee78@wordpress.org> Message-ID: <072.6a1d3a6225ab69a1d6ef192d9cba954a@wordpress.org> #56494: REST API: Fix and test rest_default_additional_properties_to_false --------------------------------------+------------------------------ Reporter: anna.bansaghi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 6.0.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by anna.bansaghi): # Solution 1.5 I have just realized, that we have a third solution too :) https://github.com/WordPress/wordpress-develop/pull/3386 It is that version which you have already seen @TimothyBlynJacobs, a variant of the Solution 1. The difference is that Solution 1.5 does not throw a notice if the `type` is missing on the schema, it just silently discards it from further traversal. Everything else is the same as for Solution 1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 03:23:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 03:23:56 -0000 Subject: [wp-trac] [WordPress Trac] #55656: PHP 8.x: various compatibility fixes for WordPress 6.1 In-Reply-To: <058.0421e8d94a3ec9d48c1d4d4bd54cce37@wordpress.org> References: <058.0421e8d94a3ec9d48c1d4d4bd54cce37@wordpress.org> Message-ID: <073.ad628976808dbc7156923ac05f33914d@wordpress.org> #55656: PHP 8.x: various compatibility fixes for WordPress 6.1 -------------------------------------------------+------------------------- Reporter: hellofromTonya | Owner: | SergeyBiryukov Type: task (blessed) | Status: accepted Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: php8 php81 has-patch has-unit-tests | Focuses: coding- | standards -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54364" 54364]: {{{ #!CommitTicketReference repository="" revision="54364" Code Modernization: Check the return type of `parse_url()` in `url_to_postid()`. As per the PHP manual: > If the `component` parameter is omitted, an associative array is returned. > If the `component` parameter is specified, `parse_url()` returns a string (or an int, in the case of `PHP_URL_PORT`) instead of an array. If the requested component doesn't exist within the given URL, `null` will be returned. Reference: [https://www.php.net/manual/en/function.parse- url.php#refsect1-function.parse-url-returnvalues PHP Manual: parse_url(): Return Values] In this case, `parse_url()` is called with `PHP_URL_HOST` as `$component`, which returns `null` if the URL only has a path. The return value of `parse_url()` was then passed to `str_replace()`, leading to a notice on PHP 8.1: {{{ str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated }}} Adding validation for the return type value of `parse_url()` prevents that. This commit addresses a few errors in the test suite along the lines of: {{{ 5) Tests_Rewrite::test_url_to_postid_home_has_path str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated /var/www/src/wp-includes/rewrite.php:503 /var/www/tests/phpunit/tests/rewrite.php:271 /var/www/vendor/bin/phpunit:123 }}} Includes adding a dedicated unit test for a URL that only has a path. Follow-up to [41786], [51606], [51622], [51626], [51629], [51630], [52799]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55656. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 04:26:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 04:26:41 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. Message-ID: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. --------------------------+----------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I had multiple handles for editor_script and passed the handles to editor_script as an array. It works fine in WP6.0 but fails in WP61 and the block becomes unusable. I know that `editor_script` was deprecated in WP6.1 and changed to `editor_script_handles`, but please fix it because it is not backward compatible that `editor_script` cannot be passed as an array. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 09:16:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 09:16:39 -0000 Subject: [wp-trac] [WordPress Trac] #56708: Fatal Error but no email Message-ID: <050.f0fab3536dfe401f873baf110c59c181@wordpress.org> #56708: Fatal Error but no email --------------------------+----------------------------- Reporter: e96707 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I can't log in and it said "Fatal Error" but I don't receive email telling me "recovery mode". Please send me the email. I can't access my website. My website is https://annadamsart.com Thank you. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 10:57:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 10:57:59 -0000 Subject: [wp-trac] [WordPress Trac] #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. In-Reply-To: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> References: <051.76369c65a397378c0fdd652725b2d378@wordpress.org> Message-ID: <066.3ca3ee23283a7bc03f75800180693c51@wordpress.org> #56706: Tests: `parent::set_up()` calls `wp_list_pluck()`, causing inaccurate coverage. ----------------------------------------------+----------------------- Reporter: costdev | Owner: costdev Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch commit | Focuses: ----------------------------------------------+----------------------- Changes (by jrf): * keywords: has-screenshots has-patch => has-screenshots has-patch commit Comment: Note: the above reproduction scenario needs PHPUnit 9.3+ to run (due to the use of the `` element in the configuration). Other than that, I can confirm what @costdev described and would recommend for this patch to be committed. Loosely related to #53011, #53746, #39265 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 11:21:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 11:21:46 -0000 Subject: [wp-trac] [WordPress Trac] #56709: Encountered a problem that no one has ever met Please help me Message-ID: <056.44c9d5c5519c633305cb7f75a0021f4a@wordpress.org> #56709: Encountered a problem that no one has ever met Please help me -------------------------------------------------+------------------------- Reporter: qq2094629698 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Bootstrap/Load | Version: 6.0.2 Severity: major | Keywords: Focuses: ui, accessibility, javascript, | coding-standards | -------------------------------------------------+------------------------- As usual, I used the element to update the page. After clicking the update button, I clicked the update button for a few more times, and this problem occurred. The contents of my page were all gone, leaving only one line of errors, (Warning: count(): Parameter must be an array or an object that implements Countable in/www/wwwroot/www.xxxx.com/wp-includes/formatting php on line 3415 ）And the same is true for publishing new pages. Please help me, thank you! I used to update the page several times every month. It used to be normal, but the problem didn't appear until today -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 11:45:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 11:45:34 -0000 Subject: [wp-trac] [WordPress Trac] #56710: Fotos do not render at all on the webpage due to a file error created by wp_optimize Message-ID: <055.852327e1d21120046603e7ddabf1b67d@wordpress.org> #56710: Fotos do not render at all on the webpage due to a file error created by wp_optimize --------------------------------------------+----------------------------- Reporter: heyitsmay20 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: major | Keywords: Focuses: ui, accessibility, performance | --------------------------------------------+----------------------------- Good afternoon, My hosting and I found a quite important bug caused by the wp-optimize plugin, this results in the media on the webpage not to render at all. This error is caused by a form of a route error. Each time that the image is converted to .webp format to improve the performance, wordpress can not find the route referenced by the plugin PHP Warning: file_exists(): open_basedir restriction in effect. File(.webp) is not within the allowed path(s): (/usr/home/hostname.com/:/home/hostname.com/:/usr/home/services/:/usr/share/php74/) in /usr/home/hostname.com/web/wp-content/plugins/wp-optimize/webp/class- wpo-webp-alter-html.php on line 211 Line 211 from the folder class-wpo-webp-alter-html.php makes reference to the variable which defines the route, and this appears to be incorrect: file_exists($filename ​ We would like some help in fixing this error, we can also provide a copy of the file in question -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 13:05:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 13:05:00 -0000 Subject: [wp-trac] [WordPress Trac] #56709: Encountered a problem that no one has ever met Please help me In-Reply-To: <056.44c9d5c5519c633305cb7f75a0021f4a@wordpress.org> References: <056.44c9d5c5519c633305cb7f75a0021f4a@wordpress.org> Message-ID: <071.cd174204b3b01852950555ea79fe6956@wordpress.org> #56709: Encountered a problem that no one has ever met Please help me --------------------------+------------------------------ Reporter: qq2094629698 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Changes (by davidbaumwald): * focuses: ui, accessibility, javascript, coding-standards => * component: Bootstrap/Load => Formatting * version: 6.0.2 => * keywords: => dev-feedback * severity: major => normal Old description: > As usual, I used the element to update the page. After clicking the > update button, I clicked the update button for a few more times, and this > problem occurred. The contents of my page were all gone, leaving only one > line of errors, (Warning: count(): Parameter must be an array or an > object that implements Countable in/www/wwwroot/www.xxxx.com/wp- > includes/formatting php on line 3415 > > ）And the same is true for publishing new pages. Please help me, thank > you! > > I used to update the page several times every month. It used to be > normal, but the problem didn't appear until today New description: As usual, I used the element to update the page. After clicking the update button, I clicked the update button for a few more times, and this problem occurred. The contents of my page were all gone, leaving only one line of errors, (`Warning: count(): Parameter must be an array or an object that implements Countable in/www/wwwroot/www.xxxx.com/wp- includes/formatting.php on line 3415`）And the same is true for publishing new pages. Please help me, thank you! I used to update the page several times every month. It used to be normal, but the problem didn't appear until today -- Comment: Hi @qq2094629698 and welcome to WordPress Trac! I did a search for this specific report, and I cannot find one that matches up exactly. So, thank you for reporting this! I am updating the ticket details for better discoverability for other contributors and users who may experience the same issue. Tracing this in the 6.0 branch, this seems to point to https://core.trac.wordpress.org/browser/branches/6.0/src/wp- includes/formatting.php#L3415 which does implement `count` on a variable that could indeed be `false`. Paging @jrf to see if this should be treated any differently than other type validation fixes(e.g. #54827) or attempt to track down at the source of where `convert_smilies` is being called. If this requires a similar solution to #54827, we can also tag this with `good-first-bug` and `needs-patch`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 13:08:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 13:08:53 -0000 Subject: [wp-trac] [WordPress Trac] #56710: Fotos do not render at all on the webpage due to a file error created by wp_optimize In-Reply-To: <055.852327e1d21120046603e7ddabf1b67d@wordpress.org> References: <055.852327e1d21120046603e7ddabf1b67d@wordpress.org> Message-ID: <070.9811b5a406691eb86ae12975f4671899@wordpress.org> #56710: Fotos do not render at all on the webpage due to a file error created by wp_optimize --------------------------+---------------------- Reporter: heyitsmay20 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Media | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by davidbaumwald): * status: new => closed * focuses: ui, accessibility, performance => * resolution: => invalid * severity: major => normal * milestone: Awaiting Review => Comment: Hi @heyitsmay20 and welcome to WordPress Core Trac! This system is used to track bugs in WordPress Core, not plugins. Try asking for help in the [https://wordpress.org/support/plugin/wp- optimize/ WP Optimize support forum]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 14:59:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 14:59:04 -0000 Subject: [wp-trac] [WordPress Trac] #56696: Twenty Eleven: Correctly escape stylesheet URL In-Reply-To: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> References: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> Message-ID: <073.f1c0f827882a6f88d0945b7c705ac708@wordpress.org> #56696: Twenty Eleven: Correctly escape stylesheet URL -----------------------------------------+------------------------------ Reporter: Alberuni Azad. | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 3.2 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: -----------------------------------------+------------------------------ Comment (by Alberuni Azad.): Hi @sabernhardt 1. Since {{{get_bloginfo( 'stylesheet_url' )}}} function using the {{{get_stylesheet_uri()}}} we can directly call that function instead of the bloginfo function. 2. I'm unsure which version this patch will be added, so I think once the ticket is confirmed, we can update the version date. 3 & 4. Yes, I've checked those files and noticed that the function is unescaped. Should I upload another patch for those themes too? Anyway, Thank you so much for reviewing this ticket. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 15:47:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 15:47:26 -0000 Subject: [wp-trac] [WordPress Trac] #55656: PHP 8.x: various compatibility fixes for WordPress 6.1 In-Reply-To: <058.0421e8d94a3ec9d48c1d4d4bd54cce37@wordpress.org> References: <058.0421e8d94a3ec9d48c1d4d4bd54cce37@wordpress.org> Message-ID: <073.b430a3fe13f6742721225416ab7b9332@wordpress.org> #55656: PHP 8.x: various compatibility fixes for WordPress 6.1 -------------------------------------------------+------------------------- Reporter: hellofromTonya | Owner: | SergeyBiryukov Type: task (blessed) | Status: accepted Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: php8 php81 has-patch has-unit-tests | Focuses: coding- | standards -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54365" 54365]: {{{ #!CommitTicketReference repository="" revision="54365" Tests: Ensure prerequisites are met for draft length tests in `Tests_L10n`. These three tests for `wp_dashboard_recent_drafts()` would run into a PHP 8.1 "passing null to non-nullable" deprecation for the call to `ltrim()` when the result of `get_edit_post_link()` is passed to `esc_url()`. Setting a deprecation expectation would not solve this as the returned value would still not match the expected value(s). The recent drafts list is only displayed on the Dashboard screen for users with the `edit_posts` capability. By setting the current user to Editor, the prerequisites for `wp_dashboard_recent_drafts()` are met, which means the deprecation notice is avoided and the assertions will succeed. This commit addresses a few errors in the test suite along the lines of: {{{ 1) Tests_L10n::test_length_of_draft_should_be_counted_by_words ltrim(): Passing null to parameter #1 ($string) of type string is deprecated /var/www/src/wp-includes/formatting.php:4376 /var/www/src/wp-admin/includes/dashboard.php:657 /var/www/tests/phpunit/tests/l10n.php:449 /var/www/vendor/bin/phpunit:123 }}} Follow-up to [45505], [52253], [52259]. Props jrf, desrosj, SergeyBiryukov. See #56681, #55652, #55656. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 15:47:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 15:47:27 -0000 Subject: [wp-trac] [WordPress Trac] #56681: Failing unit tests on PHP 8.1 and 8.2 In-Reply-To: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> References: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> Message-ID: <066.e6e8bed007717cb73f729d1377a36e5e@wordpress.org> #56681: Failing unit tests on PHP 8.1 and 8.2 -------------------------------------------------+------------------------- Reporter: desrosj | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54365" 54365]: {{{ #!CommitTicketReference repository="" revision="54365" Tests: Ensure prerequisites are met for draft length tests in `Tests_L10n`. These three tests for `wp_dashboard_recent_drafts()` would run into a PHP 8.1 "passing null to non-nullable" deprecation for the call to `ltrim()` when the result of `get_edit_post_link()` is passed to `esc_url()`. Setting a deprecation expectation would not solve this as the returned value would still not match the expected value(s). The recent drafts list is only displayed on the Dashboard screen for users with the `edit_posts` capability. By setting the current user to Editor, the prerequisites for `wp_dashboard_recent_drafts()` are met, which means the deprecation notice is avoided and the assertions will succeed. This commit addresses a few errors in the test suite along the lines of: {{{ 1) Tests_L10n::test_length_of_draft_should_be_counted_by_words ltrim(): Passing null to parameter #1 ($string) of type string is deprecated /var/www/src/wp-includes/formatting.php:4376 /var/www/src/wp-admin/includes/dashboard.php:657 /var/www/tests/phpunit/tests/l10n.php:449 /var/www/vendor/bin/phpunit:123 }}} Follow-up to [45505], [52253], [52259]. Props jrf, desrosj, SergeyBiryukov. See #56681, #55652, #55656. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 15:47:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 15:47:27 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.b4ef1d23047d109891cbc42a53465ca8@wordpress.org> #55652: Test tool and unit test improvements for 6.1 --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54365" 54365]: {{{ #!CommitTicketReference repository="" revision="54365" Tests: Ensure prerequisites are met for draft length tests in `Tests_L10n`. These three tests for `wp_dashboard_recent_drafts()` would run into a PHP 8.1 "passing null to non-nullable" deprecation for the call to `ltrim()` when the result of `get_edit_post_link()` is passed to `esc_url()`. Setting a deprecation expectation would not solve this as the returned value would still not match the expected value(s). The recent drafts list is only displayed on the Dashboard screen for users with the `edit_posts` capability. By setting the current user to Editor, the prerequisites for `wp_dashboard_recent_drafts()` are met, which means the deprecation notice is avoided and the assertions will succeed. This commit addresses a few errors in the test suite along the lines of: {{{ 1) Tests_L10n::test_length_of_draft_should_be_counted_by_words ltrim(): Passing null to parameter #1 ($string) of type string is deprecated /var/www/src/wp-includes/formatting.php:4376 /var/www/src/wp-admin/includes/dashboard.php:657 /var/www/tests/phpunit/tests/l10n.php:449 /var/www/vendor/bin/phpunit:123 }}} Follow-up to [45505], [52253], [52259]. Props jrf, desrosj, SergeyBiryukov. See #56681, #55652, #55656. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 18:22:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 18:22:21 -0000 Subject: [wp-trac] [WordPress Trac] #54221: _transient_dirsize_cache is set to autoload=yes and kills db performance if it grows (20MB in our case) In-Reply-To: <053.d27a46c8406cf993ec31d81b89154480@wordpress.org> References: <053.d27a46c8406cf993ec31d81b89154480@wordpress.org> Message-ID: <068.d45c63d81c561b603733da2ee8b6ee3b@wordpress.org> #54221: _transient_dirsize_cache is set to autoload=yes and kills db performance if it grows (20MB in our case) --------------------------+------------------------------------------ Reporter: archon810 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Database | Version: 2.8 Severity: major | Resolution: Keywords: needs-patch | Focuses: administration, performance --------------------------+------------------------------------------ Comment (by separatereality): Same problem here. Is there a plan to fix it? There simply should not be an entry that grows potentially indefinitely. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 19:52:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 19:52:19 -0000 Subject: [wp-trac] [WordPress Trac] #56711: Twenty Twenty-Three expects the `post-author-name` block, which is not in core Message-ID: <053.444e9607f5e6b664bf39d8450110c60a@wordpress.org> #56711: Twenty Twenty-Three expects the `post-author-name` block, which is not in core ---------------------------+----------------------------- Reporter: janboddez | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- Not sure if this is the place for it, but Twenty Twenty-Three expects the `post-author-name` block. (Solved by installing Gutenberg [14.2.0].) Couldn't readily find another ticket, although the block came up here: https://core.trac.wordpress.org/ticket/56179 > 7. Confirm experimental blocks like `post-author-name` were excluded from both lists Guessing it will be ported over in the very near future, or removed from TT3 templates? Seeing this on 6.1-beta2. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 20:53:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 20:53:34 -0000 Subject: [wp-trac] [WordPress Trac] #56711: Twenty Twenty-Three expects the `post-author-name` block, which is not in core In-Reply-To: <053.444e9607f5e6b664bf39d8450110c60a@wordpress.org> References: <053.444e9607f5e6b664bf39d8450110c60a@wordpress.org> Message-ID: <068.2cd9a45141300ea948fc14abc1655fe5@wordpress.org> #56711: Twenty Twenty-Three expects the `post-author-name` block, which is not in core ---------------------------+--------------------- Reporter: janboddez | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+--------------------- Changes (by sabernhardt): * version: => trunk * milestone: Awaiting Review => 6.1 Old description: > Not sure if this is the place for it, but Twenty Twenty-Three expects the > `post-author-name` block. (Solved by installing Gutenberg [14.2.0].) > > Couldn't readily find another ticket, although the block came up here: > https://core.trac.wordpress.org/ticket/56179 > > > 7. Confirm experimental blocks like `post-author-name` were excluded > from both lists > > Guessing it will be ported over in the very near future, or removed from > TT3 templates? > > Seeing this on 6.1-beta2. New description: Not sure if this is the place for it, but Twenty Twenty-Three expects the `post-author-name` block. (Solved by installing Gutenberg [14.2.0].) Couldn't readily find another ticket, although the block came up here: #56179 > 7. Confirm experimental blocks like `post-author-name` were excluded from both lists Guessing it will be ported over in the very near future, or removed from TT3 templates? Seeing this on 6.1-beta2. -- Comment: Also reported on Gutenberg repository: https://github.com/WordPress/gutenberg/issues/44618 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 22:28:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 22:28:57 -0000 Subject: [wp-trac] [WordPress Trac] #56075: Twenty Twenty-One: Link color issue coming in front-end and backend side In-Reply-To: <054.53fa473c74a470ba6fb5d811c435d626@wordpress.org> References: <054.53fa473c74a470ba6fb5d811c435d626@wordpress.org> Message-ID: <069.0df7dff71ca81d3aaa632191ca278491@wordpress.org> #56075: Twenty Twenty-One: Link color issue coming in front-end and backend side ---------------------------+----------------------------- Reporter: aezazshekh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: css ---------------------------+----------------------------- Changes (by sabernhardt): * milestone: 6.1 => Future Release -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 23:50:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 23:50:36 -0000 Subject: [wp-trac] [WordPress Trac] #56712: Correct default values in wp_handle_comment_submission() Message-ID: <058.8ce19e1d44fec25459ecfabfb5844955@wordpress.org> #56712: Correct default values in wp_handle_comment_submission() ----------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Comments | Version: 5.9 Severity: normal | Keywords: has-patch php81 Focuses: | ----------------------------+----------------------------- Background: #34059, #56681. This came up when looking into the last remaining test failure on PHP 8.1: {{{ 1) WP_Test_REST_Posts_Controller::test_get_post_draft_edit_context Failed asserting that ' ' does not contain "Hello World!". /var/www/tests/phpunit/tests/rest-api/rest-posts-controller.php:1980 /var/www/vendor/bin/phpunit:123 }}} The test was added in [50717] and has to do with allowing authenticated users to read the contents of password protected posts if they have the `edit_post` meta capability for the post. While the test could use some improvement, as noted in comment:3:ticket:56681, it fails when running the full test suite on PHP 8.1 but passes when run in isolation, which indicates that it could be affected by some other test. After some investigation, the culprit was found: [source:tags/6.0.2/tests/phpunit/tests/comment-submission.php#L202 test_submitting_comment_to_password_protected_post_succeeds()], which temporarily assigns the `$_COOKIE[ 'wp-postpass_' . COOKIEHASH ]` value. Due to how WordPress handles password protected posts, once that value is set, it affects all posts protected with the same password, see #16483. Both tests in question happen to use `password` as the password value. While the latter test unsets the `$_COOKIE[ 'wp-postpass_' . COOKIEHASH ]` value afterwards, the problem is that the test itself also triggers a PHP 8.1 "null to non-nullable" deprecation notice that was temporarily silenced in [51968]. After some debugging it became apparent that once that notice is triggered, the test stops any further execution, unintentionally leaving the `$_COOKIE[ 'wp-postpass_' . COOKIEHASH ]` in place, which then affects the other test. Looking into the source of that deprecation notice, it is caused by the defaults in `wp_handle_comment_submission()`: {{{ $comment_author = null; $comment_author_email = null; $comment_author_url = null; $comment_content = null; }}} These values are all documented to be a string in various related filters, and core also expects them to be a string, so there is no reason for these defaults to be set to `null`. Setting them to an empty string instead resolves the issues: * The latter test can proceed as expected and unset the cookie value so that it does not affect the former test. * It allows us to remove six stopgap conditionals added in [51968] to silence the deprecation notices. The patch includes: * Setting the defaults in `wp_handle_comment_submission()` to an empty string. * Adding a dedicated unit test to verify the type of these default values. * Removing the deprecation notice silencing as no longer needed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 1 23:51:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Oct 2022 23:51:57 -0000 Subject: [wp-trac] [WordPress Trac] #56712: Correct default values in wp_handle_comment_submission() In-Reply-To: <058.8ce19e1d44fec25459ecfabfb5844955@wordpress.org> References: <058.8ce19e1d44fec25459ecfabfb5844955@wordpress.org> Message-ID: <073.8614f547792bed50ade647405ae3d483@wordpress.org> #56712: Correct default values in wp_handle_comment_submission() -----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Comments | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch php81 | Focuses: -----------------------------+--------------------- Changes (by SergeyBiryukov): * Attachment "56712.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 00:31:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 00:31:31 -0000 Subject: [wp-trac] [WordPress Trac] #56681: Failing unit tests on PHP 8.1 and 8.2 In-Reply-To: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> References: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> Message-ID: <066.a27842527a3286434799f8284d46f132@wordpress.org> #56681: Failing unit tests on PHP 8.1 and 8.2 -------------------------------------------------+------------------------- Reporter: desrosj | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): @jrf I've investigated the last remaining test failure. The test was added in [50717] and has to do with allowing authenticated users to read the contents of password protected posts if they have the `edit_post` meta capability for the post. As you've noted, the test could indeed be improved to check specifically for the expected result, which in this case appears to be `'This content is password protected.'` string, as the test creates a password protected post as an Editor and then tries to view it as a Contributor, which is (correctly) not allowed. However, I found that this is not the reason why it fails, the problem actually lies elsewhere. See #56712 for details and [https://github.com/WordPress/wordpress-develop/pull/3387 PR 3387] for a passing build. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 02:09:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 02:09:14 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.8454901635daacca4156800886b096b3@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. --------------------------+------------------------------ Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by nendeb55): * version: => trunk -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 04:50:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 04:50:35 -0000 Subject: [wp-trac] [WordPress Trac] #56694: Uncached database read for logged in users when Privacy Policy Page is deleted In-Reply-To: <059.106d6b1a41744ecc5ef86c9648259268@wordpress.org> References: <059.106d6b1a41744ecc5ef86c9648259268@wordpress.org> Message-ID: <074.42ff92c8a8ee3e0fd92a6cdab3220551@wordpress.org> #56694: Uncached database read for logged in users when Privacy Policy Page is deleted -------------------------------------+------------------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Privacy | Version: 5.7 Severity: normal | Resolution: Keywords: needs-patch needs-unit- | Focuses: administration, tests | performance -------------------------------------+------------------------------------- Changes (by johnjamesjacoby): * Attachment "jjj-on-2022-10-01-at-23-44-45 at 2x.png" added. Default themes call the_privacy_policy_link() in footer.php, triggering 2 uncachable database reads -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 08:22:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 08:22:03 -0000 Subject: [wp-trac] [WordPress Trac] #56713: Check ACL permission before upgrading Message-ID: <053.974eade6a1ddb239976f0890e1e14f6c@wordpress.org> #56713: Check ACL permission before upgrading --------------------------+----------------------------- Reporter: Cartman34 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I am using ACL to define permissions of files and folder of my wordpress installation, but when I upgrade my wordpress installation using web ui tool, I am getting the following error: {{{ Warning: chmod(): Operation not permitted in /home/my-website/wp- admin/includes/class-wp-filesystem-direct.php on line 173 }}} Then the upgrade is stuck in an invalid state and I have to upgrade it manually. Wordpress upgrade program should check all its abilities before trying to upgrade and it should handle the case of using ACL for permissions. All permissions are good, it's just using ACL instead of MOD. The is the third upgrade I am experiencing this issue. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 08:23:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 08:23:13 -0000 Subject: [wp-trac] [WordPress Trac] #56713: Check ACL permission before upgrading In-Reply-To: <053.974eade6a1ddb239976f0890e1e14f6c@wordpress.org> References: <053.974eade6a1ddb239976f0890e1e14f6c@wordpress.org> Message-ID: <068.8f6e51417304d285c489651703355323@wordpress.org> #56713: Check ACL permission before upgrading --------------------------+------------------------------ Reporter: Cartman34 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by Cartman34): I forgot to tell this is related to topic https://wordpress.org/support/topic/issue-updating-wordpress-using-acl- permissions/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 09:13:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 09:13:32 -0000 Subject: [wp-trac] [WordPress Trac] #56712: Correct default values in wp_handle_comment_submission() In-Reply-To: <058.8ce19e1d44fec25459ecfabfb5844955@wordpress.org> References: <058.8ce19e1d44fec25459ecfabfb5844955@wordpress.org> Message-ID: <073.df51bdf472bb82884010035fed577afa@wordpress.org> #56712: Correct default values in wp_handle_comment_submission() --------------------------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Comments | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch php81 has-unit-tests | Focuses: --------------------------------------------+--------------------- Comment (by mukesh27): Thanks @SergeyBiryukov [https://github.com/WordPress/wordpress-develop/pull/3387 PR #3387] look good. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 09:22:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 09:22:22 -0000 Subject: [wp-trac] [WordPress Trac] #56702: Twenty Seventeen: Update jQuery scrollTo to the latest version In-Reply-To: <051.a41f0e14980bde81051a9c2f3260a852@wordpress.org> References: <051.a41f0e14980bde81051a9c2f3260a852@wordpress.org> Message-ID: <066.21003228909e5559f2c3c33ff3d15e28@wordpress.org> #56702: Twenty Seventeen: Update jQuery scrollTo to the latest version -------------------------------------------------+------------------------- Reporter: desrosj | Owner: | sarahricker Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch needs- | Focuses: testing | -------------------------------------------------+------------------------- Comment (by mukesh27): Thanks @sarahricker [https://github.com/WordPress/wordpress-develop/pull/3381 PR #3381] looks good. Need final review from @desrosj -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 09:36:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 09:36:21 -0000 Subject: [wp-trac] [WordPress Trac] #53362: Invalid paginated requests not treated as such In-Reply-To: <056.b742327f0bad7abc0012e476097ede49@wordpress.org> References: <056.b742327f0bad7abc0012e476097ede49@wordpress.org> Message-ID: <071.f8ba27d42b89f8a0d0e19230807205c5@wordpress.org> #53362: Invalid paginated requests not treated as such --------------------------+----------------------------- Reporter: daleharrison | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Canonical | Version: 5.7.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+----------------------------- Comment (by mukesh27): @SergeyBiryukov Is this ticket is in your radar for 6.1? As we change `test_redirect_canonical_with_nextpage_pagination` test is it good to use ticket number for the this test? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 09:50:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 09:50:06 -0000 Subject: [wp-trac] [WordPress Trac] #55753: PHP deprecated notice from parse_url() in url_to_postid() In-Reply-To: <053.1d7d63ee1753b60ffa81fae0451d6cec@wordpress.org> References: <053.1d7d63ee1753b60ffa81fae0451d6cec@wordpress.org> Message-ID: <068.4099268b888aac813c7d0f833e643b49@wordpress.org> #55753: PHP deprecated notice from parse_url() in url_to_postid() -----------------------------------------+----------------------------- Reporter: lagios.di | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Permalinks | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: -----------------------------------------+----------------------------- Changes (by mukesh27): * keywords: has-patch => has-patch changes-requested Comment: @lopo Thanks for the PR. I left one suggestion. @SergeyBiryukov Is this ticket on your radar for 6.1? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 10:42:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 10:42:46 -0000 Subject: [wp-trac] [WordPress Trac] #56714: php warning after updating to php 8 Message-ID: <051.095e5cd3b0f78d0a268597619078b101@wordpress.org> #56714: php warning after updating to php 8 --------------------------+----------------------------- Reporter: nouarah | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Query | Version: 6.0.2 Severity: normal | Keywords: Focuses: multisite | --------------------------+----------------------------- [02-Oct-2022 10:40:18 UTC] PHP Warning: Attempt to read property "post_type" on null in /home/newls/public_html/wp-includes/class-wp- query.php on line 4338 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 10:43:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 10:43:34 -0000 Subject: [wp-trac] [WordPress Trac] #56715: New Feature for the WordPress Core Message-ID: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> #56715: New Feature for the WordPress Core -------------------------------------+------------------------------------- Reporter: lucifer37666 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: major | Keywords: reporter-feedback 2nd- Focuses: ui, accessibility, | opinion needs-design-feedback administration, template, | performance, privacy, coding- | standards | -------------------------------------+------------------------------------- Hi, My name is Joseph M. (Lucifer37666) I'm working with WordPress long time now. But I decided to join to the community recently. So, in all this year, I saw a lot of improvement, but what I do not see, and I thought someone will come up with this, but after long time of development of WordPress no one come I decided to do it myself. Not know if this Ticket will go to the right team of WordPress or not, but at least I give a try. Yah. Why not! Most of the time, I do some basics website for the clients. The problem, is if I use a Theme when Theme update, the code I modify (Google Analytics, Custom codes in Head or Footer or any other I have to insert) will go away. So I have to go and do again the job, after every update. This is on the theme side. Now loads of other will say why not go with child theme. Yah. there are some problem as well. Some child theme are so basic they do not have place where to insert the customs code if need. My suggestions are if WordPress have in Settings a special section, where you can add this customs codes, Like Google Tag Manager, Google AdSense Code, Or Google Analytics and a section to add your own custom code. (Preferable to be able to chose to be added in Body section, Head Section, Footer Section) If core of WordPress will update, that info will still be available to the user, and is on site, not deepening on themes if switch themes and so on or Plugins. Hope someone capable will take into consideration my Feedback and hope we will see this future soon in the WordPress core. Best regards Iosif M. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 11:02:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 11:02:17 -0000 Subject: [wp-trac] [WordPress Trac] #56715: New Feature for the WordPress Core In-Reply-To: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> References: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> Message-ID: <071.9269060c904f5a89cf1fea2779bd8169@wordpress.org> #56715: New Feature for the WordPress Core -------------------------------------+------------------------------------- Reporter: lucifer37666 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: reporter-feedback 2nd- | Focuses: ui, administration, opinion needs-design-feedback | template -------------------------------------+------------------------------------- Changes (by knutsp): * focuses: ui, accessibility, administration, template, performance, privacy, coding-standards => ui, administration, template * component: General => Themes * severity: major => normal * version: trunk => Comment: Hello, welcome to Trac. Thank you for this suggestion. I strongly felt this issue many years ago, when working with customizing themes. Later the concept of a child theme was introduced. Have you tried using a child theme? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 13:03:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 13:03:58 -0000 Subject: [wp-trac] [WordPress Trac] #55753: PHP deprecated notice from parse_url() in url_to_postid() In-Reply-To: <053.1d7d63ee1753b60ffa81fae0451d6cec@wordpress.org> References: <053.1d7d63ee1753b60ffa81fae0451d6cec@wordpress.org> Message-ID: <068.3e7111fb6066633e947a517c007a692e@wordpress.org> #55753: PHP deprecated notice from parse_url() in url_to_postid() -----------------------------------------+----------------------------- Reporter: lagios.di | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Permalinks | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: -----------------------------------------+----------------------------- Changes (by SergeyBiryukov): * Attachment "54364-props.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 13:05:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 13:05:27 -0000 Subject: [wp-trac] [WordPress Trac] #55753: PHP deprecated notice from parse_url() in url_to_postid() In-Reply-To: <053.1d7d63ee1753b60ffa81fae0451d6cec@wordpress.org> References: <053.1d7d63ee1753b60ffa81fae0451d6cec@wordpress.org> Message-ID: <068.903a3ba5987a254ccd2b8fe2061aebf1@wordpress.org> #55753: PHP deprecated notice from parse_url() in url_to_postid() --------------------------+----------------------------- Reporter: lagios.di | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Permalinks | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------+----------------------------- Changes (by SergeyBiryukov): * keywords: has-patch changes-requested => has-patch * status: accepted => closed * resolution: => fixed Comment: This appears to be resolved in [54364] / #55656 while working on #56681, but I forgot that there was an existing ticket for this issue. Sorry for that! I have updated the props list for that commit in the Core Props tool on make/core to include the props from this ticket: [attachment:"54364-props.png"]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 13:56:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 13:56:17 -0000 Subject: [wp-trac] [WordPress Trac] #53362: Invalid paginated requests not treated as such In-Reply-To: <056.b742327f0bad7abc0012e476097ede49@wordpress.org> References: <056.b742327f0bad7abc0012e476097ede49@wordpress.org> Message-ID: <071.1725de56f5723be0df8d53047c8aae62@wordpress.org> #53362: Invalid paginated requests not treated as such --------------------------------------+----------------------------- Reporter: daleharrison | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Canonical | Version: 5.7.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Changes (by SergeyBiryukov): * milestone: 6.1 => 6.2 Comment: Replying to [comment:5 mukesh27]: > As we change `test_redirect_canonical_with_nextpage_pagination` test is it good to use ticket number for the this test? Thanks! As these tests cover multiple tickets, the ticket number is included in the data provider and passed to `assertCanonical()` as the third parameter. It looks like this needs some more work, as the new test cases pass with this patch, but [https://github.com/WordPress/wordpress- develop/actions/runs/3168786102/jobs/5160233095#step:17:246 some older rewrite tests fail]. Moving to 6.2 for now. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 15:11:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 15:11:38 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.b574a6da7cae636b410aea697b9f3a50@wordpress.org> #55652: Test tool and unit test improvements for 6.1 --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54366" 54366]: {{{ #!CommitTicketReference repository="" revision="54366" Build/Test Tools: Call `wpTearDownAfterClass()` before deleting all data, instead of after. As of [35186] and [51568], there are two sets of methods used for setup/teardown in the test suite before and after a test class is run: * `set_up_before_class()` / `tear_down_after_class()` * `wpSetUpBeforeClass()` / `wpTearDownAfterClass()`. (Note the `wp` prefix, these are WordPress' own methods and are not the same as the native PHPUnit `setUpBeforeClass()` / `tearDownAfterClass()` methods.) The main difference is that `wpSetUpBeforeClass()` receives the `$factory` argument for ease of use, and both `wpSetUpBeforeClass()` and `wpTearDownAfterClass()` don't need to call `self::commit_transaction()`. Many tests use the `wpTearDownAfterClass()` method to clean up posts, users, roles, etc. created via `wpSetUpBeforeClass()`. However, due to [source:tags/6.0/tests/phpunit/includes/abstract- testcase.php?marks=88-95#L82 how the method was previously called], this cleanup happened after all data is **already deleted** from the database. This could cause some confusion when refactoring tests. For example: {{{ public static function wpTearDownAfterClass() { $GLOBALS['_wp_additional_image_sizes'] = self::$_sizes; } public static function tear_down_after_class() { wp_delete_attachment( self::$large_id, true ); parent::tear_down_after_class(); } }}} At a glance, it seems like these two methods can be combined: {{{ public static function wpTearDownAfterClass() { wp_delete_attachment( self::$large_id, true ); $GLOBALS['_wp_additional_image_sizes'] = self::$_sizes; } }}} However, that would not work as expected: by the time `wp_delete_attachment()` runs, the attachment ID is no longer in the database, so it returns early, leaving some files in the `uploads` directory. By calling `wpTearDownAfterClass()` in `WP_UnitTestCase_Base::tear_down_after_class()` before deleting all data, instead of after, we ensure that both of these methods have access to the same data and can be used interchangeably to perform cleanup as necessary. Additionally, this commit moves the calls to parent methods in `WP_UnitTestCase_Base`: * `parent::set_up_before_class()` to be the first thing called in `::set_up_before_class()` * `parent::tear_down_after_class()` to be the last thing called in `::tear_down_after_class()` This does not have any effect in practice, but brings consistency with how these methods are called in the test suite. Follow-up to [35186], [35225], [35242], [38398], [39626], [49001], [51568]. Props ironprogrammer, SergeyBiryukov. Fixes #55918. See #55652. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 15:11:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 15:11:39 -0000 Subject: [wp-trac] [WordPress Trac] #55918: Call wpTearDownAfterClass() before deleting all data, instead of after In-Reply-To: <058.4a736979753c39a5adac0b2d6dcbf25b@wordpress.org> References: <058.4a736979753c39a5adac0b2d6dcbf25b@wordpress.org> Message-ID: <073.49ce7dd6725d4f9b713c2b69104a1459@wordpress.org> #55918: Call wpTearDownAfterClass() before deleting all data, instead of after --------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"54366" 54366]: {{{ #!CommitTicketReference repository="" revision="54366" Build/Test Tools: Call `wpTearDownAfterClass()` before deleting all data, instead of after. As of [35186] and [51568], there are two sets of methods used for setup/teardown in the test suite before and after a test class is run: * `set_up_before_class()` / `tear_down_after_class()` * `wpSetUpBeforeClass()` / `wpTearDownAfterClass()`. (Note the `wp` prefix, these are WordPress' own methods and are not the same as the native PHPUnit `setUpBeforeClass()` / `tearDownAfterClass()` methods.) The main difference is that `wpSetUpBeforeClass()` receives the `$factory` argument for ease of use, and both `wpSetUpBeforeClass()` and `wpTearDownAfterClass()` don't need to call `self::commit_transaction()`. Many tests use the `wpTearDownAfterClass()` method to clean up posts, users, roles, etc. created via `wpSetUpBeforeClass()`. However, due to [source:tags/6.0/tests/phpunit/includes/abstract- testcase.php?marks=88-95#L82 how the method was previously called], this cleanup happened after all data is **already deleted** from the database. This could cause some confusion when refactoring tests. For example: {{{ public static function wpTearDownAfterClass() { $GLOBALS['_wp_additional_image_sizes'] = self::$_sizes; } public static function tear_down_after_class() { wp_delete_attachment( self::$large_id, true ); parent::tear_down_after_class(); } }}} At a glance, it seems like these two methods can be combined: {{{ public static function wpTearDownAfterClass() { wp_delete_attachment( self::$large_id, true ); $GLOBALS['_wp_additional_image_sizes'] = self::$_sizes; } }}} However, that would not work as expected: by the time `wp_delete_attachment()` runs, the attachment ID is no longer in the database, so it returns early, leaving some files in the `uploads` directory. By calling `wpTearDownAfterClass()` in `WP_UnitTestCase_Base::tear_down_after_class()` before deleting all data, instead of after, we ensure that both of these methods have access to the same data and can be used interchangeably to perform cleanup as necessary. Additionally, this commit moves the calls to parent methods in `WP_UnitTestCase_Base`: * `parent::set_up_before_class()` to be the first thing called in `::set_up_before_class()` * `parent::tear_down_after_class()` to be the last thing called in `::tear_down_after_class()` This does not have any effect in practice, but brings consistency with how these methods are called in the test suite. Follow-up to [35186], [35225], [35242], [38398], [39626], [49001], [51568]. Props ironprogrammer, SergeyBiryukov. Fixes #55918. See #55652. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 16:19:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 16:19:40 -0000 Subject: [wp-trac] [WordPress Trac] #56716: Spotify block don't work on fresh install of 6.0.2 Message-ID: <054.108f9dc7f90b1705d78ba1a20f436f56@wordpress.org> #56716: Spotify block don't work on fresh install of 6.0.2 --------------------------+----------------------------- Reporter: kgmservizi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: 6.0.2 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hi, I've tried on a fresh install of WP 6.0.2, Spotify block fail to embed link. Regards -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 16:24:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 16:24:12 -0000 Subject: [wp-trac] [WordPress Trac] #56715: New Feature for the WordPress Core In-Reply-To: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> References: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> Message-ID: <071.474ee4e869e077864598edb6aad1ad90@wordpress.org> #56715: New Feature for the WordPress Core -------------------------------------------------+------------------------- Reporter: lucifer37666 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting | Review Component: General | Version: Severity: normal | Resolution: Keywords: reporter-feedback 2nd-opinion | Focuses: ui, needs-design-feedback | administration -------------------------------------------------+------------------------- Changes (by joyously): * focuses: ui, administration, template => ui, administration * component: Themes => General Comment: The sort of code you are adding belongs in a plugin, not a theme, so that it is independent (of updates and switching themes). There are already plugins for interfacing with Google, but also plugins that allow you to put whatever code you want into the page. Especially for some code that is needed all the time, you can make it a mu-plugin, so your client can't accidentally deactivate it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 16:55:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 16:55:47 -0000 Subject: [wp-trac] [WordPress Trac] #56696: Twenty Eleven: Correctly escape stylesheet URL In-Reply-To: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> References: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> Message-ID: <073.f56868830724353c30eafa6f91776dcb@wordpress.org> #56696: Twenty Eleven: Correctly escape stylesheet URL -----------------------------------------+------------------------------ Reporter: Alberuni Azad. | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 3.2 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: -----------------------------------------+------------------------------ Changes (by Alberuni Azad.): * Attachment "56696.4.diff" added. Created another patch for Twenty Eleven -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 16:57:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 16:57:03 -0000 Subject: [wp-trac] [WordPress Trac] #56696: Twenty Eleven: Correctly escape stylesheet URL In-Reply-To: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> References: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> Message-ID: <073.c33c75c1013bf0b8c3bd7b5d7c55dd2c@wordpress.org> #56696: Twenty Eleven: Correctly escape stylesheet URL -----------------------------------------+------------------------------ Reporter: Alberuni Azad. | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 3.2 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: -----------------------------------------+------------------------------ Changes (by Alberuni Azad.): * Attachment "56696.5.diff" added. Created a separated patch for Twenty twelve, thirteen and fourteen -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 17:00:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 17:00:04 -0000 Subject: [wp-trac] [WordPress Trac] #56696: Twenty Eleven: Correctly escape stylesheet URL In-Reply-To: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> References: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> Message-ID: <073.c3e5b4b83a36909c13a6d9ee58308826@wordpress.org> #56696: Twenty Eleven: Correctly escape stylesheet URL -----------------------------------------+------------------------------ Reporter: Alberuni Azad. | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 3.2 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: -----------------------------------------+------------------------------ Comment (by Alberuni Azad.): @sabernhardt I've uploaded 2 different patches. No 4 for the Twenty eleven and 5 no for the Twenty twelve, thirteen, and fourteen themes. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 17:36:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 17:36:11 -0000 Subject: [wp-trac] [WordPress Trac] #56717: Twenty Eleven: Correctly escape template directory uri Message-ID: <058.d5e17afb904b19a7ec5ac51e629ec7f3@wordpress.org> #56717: Twenty Eleven: Correctly escape template directory uri ----------------------------+----------------------------- Reporter: Alberuni Azad. | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.8 Severity: normal | Keywords: Focuses: | ----------------------------+----------------------------- In wp-content/themes/twentyeleven/inc/block-patterns.php file, I've found that the {{{get_template_directory_uri()}}} is called without escaping which I think should be escaped. I've checked other latest themes where the escaping is used. Link mentioned below https://github.com/WordPress/wordpress- develop/blob/389a78ecc453036f144b6d510cc2423f41bc9dd1/src/wp- content/themes/twentytwentytwo/inc/patterns/general-divider-dark.php#L10 https://github.com/WordPress/wordpress- develop/blob/389a78ecc453036f144b6d510cc2423f41bc9dd1/src/wp- content/themes/twentytwentyone/inc/block-patterns.php#L76 https://github.com/WordPress/wordpress- develop/blob/389a78ecc453036f144b6d510cc2423f41bc9dd1/src/wp- content/themes/twentytwenty/inc/block-patterns.php#L151 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 17:40:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 17:40:42 -0000 Subject: [wp-trac] [WordPress Trac] #56717: Twenty Eleven: Correctly escape template directory uri In-Reply-To: <058.d5e17afb904b19a7ec5ac51e629ec7f3@wordpress.org> References: <058.d5e17afb904b19a7ec5ac51e629ec7f3@wordpress.org> Message-ID: <073.5a2acba558feed4285da1a390880c191@wordpress.org> #56717: Twenty Eleven: Correctly escape template directory uri ----------------------------+------------------------------ Reporter: Alberuni Azad. | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.8 Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+------------------------------ Changes (by Alberuni Azad.): * Attachment "56717.diff" added. Created patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 18:30:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 18:30:37 -0000 Subject: [wp-trac] [WordPress Trac] #56715: New Feature for the WordPress Core In-Reply-To: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> References: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> Message-ID: <071.7be95a9e4ddb2761f8d2916caf23fd63@wordpress.org> #56715: New Feature for the WordPress Core -------------------------------------------------+------------------------- Reporter: lucifer37666 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting | Review Component: General | Version: Severity: normal | Resolution: Keywords: reporter-feedback 2nd-opinion close | Focuses: ui, | administration -------------------------------------------------+------------------------- Changes (by jrf): * keywords: reporter-feedback 2nd-opinion needs-design-feedback => reporter-feedback 2nd-opinion close Comment: I agree with both the above replies. The desired functionality can already be achieved by either using a [https://developer.wordpress.org/themes /advanced-topics/child-themes/ child theme], by using a (combination of [https://wordpress.org/plugins/ existing plugin(s)] or by creating a [https://developer.wordpress.org/plugins/ custom plugin]. I'd suggest closing this issue as this is a feature request for a feature which effectively already exists. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 18:53:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 18:53:04 -0000 Subject: [wp-trac] [WordPress Trac] #56677: Allow hyphens in post tags In-Reply-To: <062.ec1ba55c97c2336a0f983594a83079fa@wordpress.org> References: <062.ec1ba55c97c2336a0f983594a83079fa@wordpress.org> Message-ID: <077.dbca475bf100b6bd4e2727e4b87d2025@wordpress.org> #56677: Allow hyphens in post tags --------------------------------+------------------------------ Reporter: cewebdesignmunchen | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: Severity: normal | Resolution: invalid Keywords: close | Focuses: --------------------------------+------------------------------ Changes (by sajjad67): * keywords: => close * status: new => closed * resolution: => invalid Comment: The purpose of soft hyphen (SHY) is understood, but the name of a tag, how could it be break at? like what is the expected thing you are looking for? You want to go the `keywoooooooooord` at new line? It is not preserve / filtered cause SHY is an HTML! If you look at `wp_insert_term()` function which calls `sanitize_term()` and eventually lands on `sanitize_term_field()`, it needs to be escaped! A Term name should not be formatted!! It has to be only valid names... a soft hyphen doesn't seem to be a valid name for a Term! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 18:58:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 18:58:23 -0000 Subject: [wp-trac] [WordPress Trac] #56709: Encountered a problem that no one has ever met Please help me In-Reply-To: <056.44c9d5c5519c633305cb7f75a0021f4a@wordpress.org> References: <056.44c9d5c5519c633305cb7f75a0021f4a@wordpress.org> Message-ID: <071.d6217a1fa85cead677fd282e6f7f249c@wordpress.org> #56709: Encountered a problem that no one has ever met Please help me -------------------------------+------------------------------ Reporter: qq2094629698 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: Severity: normal | Resolution: Keywords: dev-feedback php8 | Focuses: -------------------------------+------------------------------ Changes (by jrf): * keywords: dev-feedback => dev-feedback php8 Comment: Thanks for looping me in @davidbaumwald. I have seen numerous similar issues, including with the `convert_smilies()` function, and they are 100% of the time caused by an incorrect call to this function, so this needs a backtrace to figure out where this is coming from. > Tracing this in the 6.0 branch, this seems to point to https://core.trac.wordpress.org/browser/branches/6.0/src/wp- includes/formatting.php#L3415 which does implement count on a variable that could indeed be false. The thing is, it will actually be pretty hard to get this error, even when passing invalid input. The `preg_split()` doesn't easily return `false`. AFAIK, this will only happen when the regex is faulty (which it isn't) and would then be accompanied by a warning about the error in the regex, see: https://3v4l.org/N3t8W @qq2094629698 Aside from the backtrace, could you please also mention in your reply: * The version of WordPress you are using (to confirm we're actually looking at the right call to `count()`. * The version of PHP your site is running on. * Test whether you can still reproduce the error with a WP native theme and all plugins turned off ? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 19:03:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 19:03:16 -0000 Subject: [wp-trac] [WordPress Trac] #56716: Spotify block don't work on fresh install of 6.0.2 In-Reply-To: <054.108f9dc7f90b1705d78ba1a20f436f56@wordpress.org> References: <054.108f9dc7f90b1705d78ba1a20f436f56@wordpress.org> Message-ID: <069.05d7b68b6f31e8327c1da37e6a896777@wordpress.org> #56716: Spotify block don't work on fresh install of 6.0.2 --------------------------+------------------------------ Reporter: kgmservizi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by sajjad67): Hello @kgmservizi You are more than welcome to the Core Trac! Would you be able to provide any instructions for us to reproduce the issue you are having? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 22:41:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 22:41:21 -0000 Subject: [wp-trac] [WordPress Trac] #55937: Salting functions: translate the phrase `put your unique phrase here`. In-Reply-To: <057.f77dd14a7299d5b52d7c0f910faeb01b@wordpress.org> References: <057.f77dd14a7299d5b52d7c0f910faeb01b@wordpress.org> Message-ID: <072.97559c16487ae3b2d4832392b8b96c9a@wordpress.org> #55937: Salting functions: translate the phrase `put your unique phrase here`. ---------------------------+----------------------- Reporter: peterwilsoncc | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Security | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+----------------------- Comment (by peterwilsoncc): I've created an [https://github.com/WordPress/wordpress-develop/pull/3389 alternative follow up pull request] that builds on @audrasjb's. In each location both the default English and default translated strings are considered duplicates, this matches the code in `wp_salt()`. This allows for site owners who download the English package and then switch language. I do wonder if the code should `switch_to_locale( $site_locale );` beforehand but I am not sure how much processing work that is. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 23:26:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 23:26:22 -0000 Subject: [wp-trac] [WordPress Trac] #55189: Automatic removal of "Zero-width non-joiner" in URL In-Reply-To: <053.3e9eb622a7f5219df8181821b4d758f9@wordpress.org> References: <053.3e9eb622a7f5219df8181821b4d758f9@wordpress.org> Message-ID: <068.563bbee4ccb9883085bbf43b60114963@wordpress.org> #55189: Automatic removal of "Zero-width non-joiner" in URL -----------------------------------+--------------------- Reporter: man4toman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Permalinks | Version: 5.9 Severity: critical | Resolution: Keywords: 2nd-opinion has-patch | Focuses: -----------------------------------+--------------------- Comment (by peterwilsoncc): I suggest making use of the `old-save` context to avoid this issue. See [https://core.trac.wordpress.org/browser/tags/6.0/src/wp- includes/post.php?marks=4175-4182#L4175 source code reference]. However, I think this is probably too late for the 6.1 release now that it is in beta. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 2 23:43:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Oct 2022 23:43:52 -0000 Subject: [wp-trac] [WordPress Trac] #56718: register_post_meta not being initialized default value right away Message-ID: <054.d88ee8de0d30d4b939f35bdf97cc151f@wordpress.org> #56718: register_post_meta not being initialized default value right away --------------------------+----------------------------- Reporter: kaimaniiii | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.2 Severity: critical | Keywords: Focuses: | --------------------------+----------------------------- I am trying to utilize a custom post meta which I called isVisibleFeatureImage and then using ToggleControl WP Gutenberg Component to toggle by showing whether the feature image is on or not. The issue is that the default value isVisibleFeatureImage doesn't get the initialized value as true on my page.php file. I just get an empty string instead. What I had to do is going to the Gutenberg Block editor, use the ToggleControl to toggle the feature image that is not visible, update the page, and then ToggleControl to be visible again and update. Then it will work. Here is the code snippet below for using register_post_meta() function to register the feature image is visible or not: {{{#!php true, '_builtin' => false ]; $output = 'names'; // 'names' or 'objects' (default: 'names') $operator = 'and'; // 'and' or 'or' (default: 'and') $post_types = get_post_types( $args, $output, $operator ); array_push($post_types, 'post', 'page'); $meta_args = array( 'type' => 'boolean', 'description' => 'Meta key to ensure value is toggled or not for featureImage', 'auth_callback' => function() { // ! Need to return true, otherwise we get status 403 forbidden error to update the meta key. return true; }, 'single' => true, 'default' => true, // set the ToggleControl WP Component default value to false 'show_in_rest' => true, ); foreach ($post_types as $post_type) { register_post_meta( $post_type, 'isVisibleFeatureImage', $meta_args ); } } }}} This is a simple code snippet for trying to check if the my custom post meta feature image is toggled or not: {{{#!php ID; $is_visible_feature_image = get_post_meta($postId, 'isVisibleFeatureImage', true); var_dump(get_post_meta($is_visible_feature_image)); }}} Is this some sort of bug??? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 04:35:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 04:35:17 -0000 Subject: [wp-trac] [WordPress Trac] #56717: Twenty Eleven: Correctly escape template directory uri In-Reply-To: <058.d5e17afb904b19a7ec5ac51e629ec7f3@wordpress.org> References: <058.d5e17afb904b19a7ec5ac51e629ec7f3@wordpress.org> Message-ID: <073.e12afd03ac68598e222c3ba62fca982e@wordpress.org> #56717: Twenty Eleven: Correctly escape template directory uri ----------------------------+------------------------------ Reporter: Alberuni Azad. | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+------------------------------ Changes (by bhrugesh12): * keywords: => has-patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 06:24:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 06:24:43 -0000 Subject: [wp-trac] [WordPress Trac] #50568: Improve WP_Term's sanitization calls In-Reply-To: <048.5ec7d9a597697c453e141d16284f7678@wordpress.org> References: <048.5ec7d9a597697c453e141d16284f7678@wordpress.org> Message-ID: <063.0d48d3bc2cf4ce694765c72f4b130dd5@wordpress.org> #50568: Improve WP_Term's sanitization calls ----------------------------------------------+---------------------------- Reporter: Cybr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future | Release Component: Taxonomy | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests early | Focuses: performance ----------------------------------------------+---------------------------- Comment (by mukesh27): @Cybr would you mind creating a PR on github.com/wordpress/wordpress- develop? #50567 is already merge so we can target this for next milestone? cc. @peterwilsoncc -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 06:29:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 06:29:00 -0000 Subject: [wp-trac] [WordPress Trac] #56719: In Twenty Nineteen Theme: Tag cloud block alignment issue in editor as well as front end side #43016 Message-ID: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> #56719: In Twenty Nineteen Theme: Tag cloud block alignment issue in editor as well as front end side #43016 ---------------------------+----------------------------- Reporter: multidots1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.2 Severity: normal | Keywords: has-patch Focuses: | ---------------------------+----------------------------- 1)Activate the Twenty Nineteen theme. 2)Add the tag cloud block and select taxonomies from list 3)Now set the center alignment. You can see it will not be in center alignment. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 06:29:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 06:29:37 -0000 Subject: [wp-trac] [WordPress Trac] #56719: In Twenty Nineteen Theme: Tag cloud block alignment issue in editor as well as front end side #43016 In-Reply-To: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> References: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> Message-ID: <072.f29d3399901b151bc29f2f382db29f53@wordpress.org> #56719: In Twenty Nineteen Theme: Tag cloud block alignment issue in editor as well as front end side #43016 ---------------------------+------------------------------ Reporter: multidots1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+------------------------------ Changes (by multidots1896): * Attachment "56719.patch" added. added patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 07:22:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 07:22:04 -0000 Subject: [wp-trac] [WordPress Trac] #56026: Twenty Twenty Two: Pullquote block: Font change not properly displayed In-Reply-To: <053.8c547488987bd361734007417d1fb117@wordpress.org> References: <053.8c547488987bd361734007417d1fb117@wordpress.org> Message-ID: <068.b779dc00152b22ef0ca549dab9348350@wordpress.org> #56026: Twenty Twenty Two: Pullquote block: Font change not properly displayed ---------------------------+--------------------- Reporter: nithins53 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: 6.0 Severity: normal | Resolution: Keywords: has-patch | Focuses: css ---------------------------+--------------------- Changes (by sabernhardt): * focuses: => css Comment: Related: GB42246, possibly fixed by GB43195 The paragraph font size of 1.75em (or 1.25em when aligned left or right) is removed from the Pullquote block styles now. I tried each font preset (Small, Medium, Large and Extra Large) plus some custom font sizes in WordPress 6.1 beta 2. The editor font size matched the front. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 07:49:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 07:49:13 -0000 Subject: [wp-trac] [WordPress Trac] #48116: Proposal: Tracking PHP Extension Usage In-Reply-To: <048.0c9bc69fdc01bc4193fe8197408e65e2@wordpress.org> References: <048.0c9bc69fdc01bc4193fe8197408e65e2@wordpress.org> Message-ID: <063.99570a71e13d415cc050df9d13cdadfb@wordpress.org> #48116: Proposal: Tracking PHP Extension Usage -------------------------------------------------+------------------------- Reporter: dd32 | Owner: | adamsilverstein Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Upgrade/Install | Version: Severity: normal | Resolution: fixed Keywords: dev-feedback has-patch commit add- | Focuses: to-field-guide | -------------------------------------------------+------------------------- Comment (by aristath): Would it be possible to add `sqlite` in the list of extensions to track? We'll need to make more educated decisions about supporting it in the future, so this data would be invaluable for Core. (Proposal on Make/core: https://make.wordpress.org/core/2022/09/12/lets- make-wordpress-officially-support-sqlite/ was submitted about a month ago) I'm attaching a patch on https://github.com/WordPress/wordpress- develop/pull/3393. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 08:02:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 08:02:06 -0000 Subject: [wp-trac] [WordPress Trac] #56716: Spotify block don't work on fresh install of 6.0.2 In-Reply-To: <054.108f9dc7f90b1705d78ba1a20f436f56@wordpress.org> References: <054.108f9dc7f90b1705d78ba1a20f436f56@wordpress.org> Message-ID: <069.b0025e4c1524b4066a2eb18559536a81@wordpress.org> #56716: Spotify block don't work on fresh install of 6.0.2 --------------------------+------------------------------ Reporter: kgmservizi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by kgmservizi): Replying to [comment:1 sajjad67]: > Hello @kgmservizi You are more than welcome to the Core Trac! Would you be able to provide any instructions for us to reproduce the issue you are having? Hello @sajjad67, thanks for your reply. You need only to install a fresh WP 6.0.2, add new post, paste a link from Spotify (ex. https://open.spotify.com/episode/3kO0Z5JARajMJ0qMwIuhKj?si=317212703f5646df) and you can see that can't embed it. If you have also Spotify Block in old posts, when you edit them you can see the same error. Regards -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 08:09:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 08:09:43 -0000 Subject: [wp-trac] [WordPress Trac] #56008: Twenty Sixteen: Pullquote Block: Color not reflected in editor and front end In-Reply-To: <053.b42d40a84e90402b636d1cdaf0482fda@wordpress.org> References: <053.b42d40a84e90402b636d1cdaf0482fda@wordpress.org> Message-ID: <068.47b02637bfb8d78d45d60d66923ae180@wordpress.org> #56008: Twenty Sixteen: Pullquote Block: Color not reflected in editor and front end ---------------------------------------+---------------------- Reporter: nithins53 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: 6.0 Severity: normal | Resolution: Keywords: has-patch has-screenshots | Focuses: ui, css ---------------------------------------+---------------------- Comment (by nithins53): The patch 56008.1 works perfectly fine on WP 6.1 beta 2. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 08:13:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 08:13:09 -0000 Subject: [wp-trac] [WordPress Trac] #56720: Twenty Twenty-Two: Remove color reference from pattern names Message-ID: <049.1d32029475bf303467f0dbd1b97cae81@wordpress.org> #56720: Twenty Twenty-Two: Remove color reference from pattern names ---------------------------+---------------------------- Reporter: poena | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Keywords: Focuses: | ---------------------------+---------------------------- This ticket is copied to core trac from Gutenberg:[https://github.com/WordPress/gutenberg/issues/40033 40033] There are a few block patterns in the theme that includes color names, but when the user changes the colors, the names no longer match. The suggested fix in the discussion on GitHub is to remove the color names and instead of "with salmon background", the name would be "with background". -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 08:23:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 08:23:16 -0000 Subject: [wp-trac] [WordPress Trac] #56719: Twenty Nineteen: Tag cloud block not centering (was: In Twenty Nineteen Theme: Tag cloud block alignment issue in editor as well as front end side #43016) In-Reply-To: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> References: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> Message-ID: <072.f4b4c27426e5dc2c75a3bc4d85cd23a2@wordpress.org> #56719: Twenty Nineteen: Tag cloud block not centering ---------------------------+------------------------------ Reporter: multidots1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+------------------------------ Changes (by sabernhardt): * keywords: has-patch => * focuses: => css * component: General => Bundled Theme Comment: Related: GB43016 With GB43017 merged, the block styles already include `justify-content: center` in WordPress 6.1 beta 2. I did not notice a problem on the front, but the Post editor still does not center the Tag Cloud block with its Outline style (Default worked fine). The Widget editor centered both Default and Outline styles. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 08:23:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 08:23:20 -0000 Subject: [wp-trac] [WordPress Trac] #56720: Twenty Twenty-Two: Remove color reference from pattern names In-Reply-To: <049.1d32029475bf303467f0dbd1b97cae81@wordpress.org> References: <049.1d32029475bf303467f0dbd1b97cae81@wordpress.org> Message-ID: <064.d60e1fb1cf72e715b433d0f22fa4b54c@wordpress.org> #56720: Twenty Twenty-Two: Remove color reference from pattern names ---------------------------+----------------------------- Reporter: poena | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+----------------------------- Changes (by poena): * Attachment "56720.diff" added. Update block pattern names -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 08:30:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 08:30:31 -0000 Subject: [wp-trac] [WordPress Trac] #56719: Twenty Nineteen: Tag cloud block not centering In-Reply-To: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> References: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> Message-ID: <072.4dbdf6766392e0b7ae6d52160a8c4ef0@wordpress.org> #56719: Twenty Nineteen: Tag cloud block not centering ---------------------------+------------------------------ Reporter: multidots1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+------------------------------ Changes (by sabernhardt): * Attachment "widget-editor-tag-cloud.png" added. Tag Cloud block centered in the Widget editor with WordPress 6.1 beta 2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 08:31:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 08:31:23 -0000 Subject: [wp-trac] [WordPress Trac] #56719: Twenty Nineteen: Tag cloud block not centering In-Reply-To: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> References: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> Message-ID: <072.f340258d7483e27cfa87a890c8a77baf@wordpress.org> #56719: Twenty Nineteen: Tag cloud block not centering ---------------------------+------------------------------ Reporter: multidots1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+------------------------------ Changes (by sabernhardt): * Attachment "post-editor-tag-cloud.png" added. in the post editor, the block does not have the `aligncenter` class -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 08:34:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 08:34:07 -0000 Subject: [wp-trac] [WordPress Trac] #56719: Twenty Nineteen: Tag cloud block not centering In-Reply-To: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> References: <057.0baa3dccecfc5014380141760ed5f426@wordpress.org> Message-ID: <072.3ee2ecd297086761fb6167f4d1680e1c@wordpress.org> #56719: Twenty Nineteen: Tag cloud block not centering ---------------------------+------------------------------ Reporter: multidots1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+------------------------------ Comment (by sabernhardt): I think this would need to be fixed in the plugin (and merged into Core) instead of editing individual themes. The block has `aligncenter` and `wp-block` classes in the Widget context, but not in the Post editor. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 09:55:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 09:55:22 -0000 Subject: [wp-trac] [WordPress Trac] #32747: WP Admin Menus/SubMenus Overlap in small screen In-Reply-To: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> References: <053.19f81590b59ff77c2a9b31983b4caf91@wordpress.org> Message-ID: <068.9463b6e055e0e6c67958d17732d025ad@wordpress.org> #32747: WP Admin Menus/SubMenus Overlap in small screen -------------------------------------+------------------------------------- Reporter: turtlepod | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Administration | Version: 4.2.2 Severity: normal | Resolution: Keywords: has-patch has-testing- | Focuses: ui, accessibility, info | javascript -------------------------------------+------------------------------------- Comment (by ugyensupport): @chaion07 Great thanks I could also reproduce the issue on 5.9.2. Environment: Hardware: MacBook Air Apple M1 Pro OS: macOS 11.6.7 Browser: Safari 16.0, Google Chrome 105.0.5195.125, Mozilla Firefox 105.0.1 Server: Nginx/1.23.1 PHP: 8 WordPress: 6.1-beta2-54337-src It looks good on my end. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 10:08:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 10:08:29 -0000 Subject: [wp-trac] [WordPress Trac] #56718: register_post_meta not being initialized default value right away In-Reply-To: <054.d88ee8de0d30d4b939f35bdf97cc151f@wordpress.org> References: <054.d88ee8de0d30d4b939f35bdf97cc151f@wordpress.org> Message-ID: <069.bb496728ff3d5c7e53fdd91cbed1f509@wordpress.org> #56718: register_post_meta not being initialized default value right away --------------------------------+------------------------------ Reporter: kaimaniiii | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: 5.5 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------------+------------------------------ Changes (by spacedmonkey): * keywords: => dev-feedback * version: 6.0.2 => 5.5 * component: General => Options, Meta APIs * severity: critical => normal Comment: Thanks for your ticket @kaimaniiii. However, I think the issue here is a very simply one. Consider this line. {{{#!php add_action( 'rest_api_init', 'autoload_register_meta_post_core_feature_image', 9999 ); }}} This only registers the meta on the rest api init. If you try to load meta in another context like on the front end or in a rss, this meta would be registered. If you can it to simple be the following, it should fix the issue. {{{#!php add_action( 'init', 'autoload_register_meta_post_core_feature_image', 9999 ); }}} I will await your response, but otherwise I believe there is no issue here. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 10:10:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 10:10:20 -0000 Subject: [wp-trac] [WordPress Trac] #56566: Fatal error when WP_REST_Server::dispatch() returns WP_Error In-Reply-To: <050.081ef4d3475412c0b7ad07bcb3c14270@wordpress.org> References: <050.081ef4d3475412c0b7ad07bcb3c14270@wordpress.org> Message-ID: <065.102136a4fd2cc4b8517ae2f894593dda@wordpress.org> #56566: Fatal error when WP_REST_Server::dispatch() returns WP_Error --------------------------------------+-------------------------------- Reporter: DaveFX | Owner: TimothyBlynJacobs Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: REST API | Version: 4.4 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: rest-api --------------------------------------+-------------------------------- Comment (by spacedmonkey): @TimothyBlynJacobs Any movement on this ticket? Otherwise, I believe we are getting close to the stage where we need to punt this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 10:19:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 10:19:22 -0000 Subject: [wp-trac] [WordPress Trac] #47280: SQL_CALC_FOUND_ROWS is deprecated as of MySQL 8.0.17 In-Reply-To: <053.464f3453501834c73527d32600b297e3@wordpress.org> References: <053.464f3453501834c73527d32600b297e3@wordpress.org> Message-ID: <068.c86409769e9c7ec3441f4f99ccc418cf@wordpress.org> #47280: SQL_CALC_FOUND_ROWS is deprecated as of MySQL 8.0.17 --------------------------------------------+----------------------------- Reporter: javorszky | Owner: johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: Future Release Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests early | Focuses: performance --------------------------------------------+----------------------------- Comment (by spacedmonkey): Now that #22176 is committed in [54111], this patch will need to be refactored. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 10:44:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 10:44:48 -0000 Subject: [wp-trac] [WordPress Trac] #55773: FSE navigation menu - styling problem In-Reply-To: <051.b1ee901fc2d55cef4378d4ac64396dd4@wordpress.org> References: <051.b1ee901fc2d55cef4378d4ac64396dd4@wordpress.org> Message-ID: <066.8c4e016ea04bcb132d442da1dbdb68d8@wordpress.org> #55773: FSE navigation menu - styling problem --------------------------+------------------------------ Reporter: jim5471 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Menus | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by mrfoxtalbot): I came to report this. The CSS class is there, `current-menu-item`, but Twenty Twenty-Two does not seem to be providing any styles to differentiate this type of menu item in any way. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 11:23:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 11:23:01 -0000 Subject: [wp-trac] [WordPress Trac] #56721: get_page_by_title: duplicate SQL query Message-ID: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> #56721: get_page_by_title: duplicate SQL query -------------------------------+----------------------------- Reporter: david.binda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: trunk Severity: normal | Keywords: Focuses: performance | -------------------------------+----------------------------- The r54234 has introduced a duplicate SQL query triggered for the `get_page_by_title` function, as it's executing the SQL query by passing the arguments for a WP_Query directly to the constructor of the class, and then triggering the `WP_Query::get_posts()` directly, instead of accessing the `WP_Query::posts` property. See https://core.trac.wordpress.org/browser/trunk/src/wp- includes/post.php?rev=54320#L5790 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 11:23:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 11:23:26 -0000 Subject: [wp-trac] [WordPress Trac] #56721: get_page_by_title: duplicate SQL query In-Reply-To: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> References: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> Message-ID: <070.72e622df462ac03d2f0337daf02ad37a@wordpress.org> #56721: get_page_by_title: duplicate SQL query -------------------------------+------------------------------ Reporter: david.binda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: performance -------------------------------+------------------------------ Changes (by david.binda): * Attachment "56721.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 11:53:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 11:53:34 -0000 Subject: [wp-trac] [WordPress Trac] #56721: get_page_by_title: duplicate SQL query In-Reply-To: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> References: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> Message-ID: <070.3ead0e59b4d46639c1eee3e9554d907b@wordpress.org> #56721: get_page_by_title: duplicate SQL query -------------------------------+-------------------------- Reporter: david.binda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Posts, Post Types | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -------------------------------+-------------------------- Changes (by mukesh27): * keywords: => has-patch * milestone: Awaiting Review => 6.1 Comment: Thanks @davidbinda. good cache. r54234 is merge before some days in 6.1 milestone. Let's move to 6.1 for consideration. feel free to update milestone. cc. @spacedmonkey @SergeyBiryukov -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 11:55:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 11:55:27 -0000 Subject: [wp-trac] [WordPress Trac] #56721: get_page_by_title: duplicate SQL query In-Reply-To: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> References: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> Message-ID: <070.a77ddc93dca4e39978a72c775c6ba10a@wordpress.org> #56721: get_page_by_title: duplicate SQL query -------------------------------+-------------------------- Reporter: david.binda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Posts, Post Types | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -------------------------------+-------------------------- Comment (by spacedmonkey): This patch was meant to be in WordPress 6.1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 11:58:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 11:58:06 -0000 Subject: [wp-trac] [WordPress Trac] #56721: get_page_by_title: duplicate SQL query In-Reply-To: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> References: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> Message-ID: <070.97400c85f9b647c57fdf483d2a1455dc@wordpress.org> #56721: get_page_by_title: duplicate SQL query -------------------------------+-------------------------- Reporter: david.binda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Posts, Post Types | Version: trunk Severity: normal | Resolution: Keywords: has-patch commit | Focuses: performance -------------------------------+-------------------------- Changes (by mukesh27): * keywords: has-patch => has-patch commit Comment: @spacedmonkey thanks for the confirmation. [attachment:"56721.diff"] LGTM. `commit` added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 11:58:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 11:58:34 -0000 Subject: [wp-trac] [WordPress Trac] #56721: get_page_by_title: duplicate SQL query In-Reply-To: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> References: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> Message-ID: <070.556d463bf167efa07011a6576b97294f@wordpress.org> #56721: get_page_by_title: duplicate SQL query -------------------------------+-------------------------- Reporter: david.binda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Posts, Post Types | Version: trunk Severity: normal | Resolution: Keywords: has-patch commit | Focuses: performance -------------------------------+-------------------------- Comment (by spacedmonkey): +1 to commit. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 12:33:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 12:33:58 -0000 Subject: [wp-trac] [WordPress Trac] #56715: New Feature for the WordPress Core In-Reply-To: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> References: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> Message-ID: <071.c05f456355e2493d9f696f6137964db7@wordpress.org> #56715: New Feature for the WordPress Core -------------------------------------------------+------------------------- Reporter: lucifer37666 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting | Review Component: General | Version: Severity: normal | Resolution: Keywords: reporter-feedback 2nd-opinion close | Focuses: ui, | administration -------------------------------------------------+------------------------- Comment (by lucifer37666): Hi, Thanks for the fast reply. Do not get me wrong or take as an offence. But if I put in the theme child.. and switch? Code will be on site? Why I can put some code into WP core, and I know is there and no waist more time to go grab the code and paste again. Why need plugin for everything? this is the issues. Why not make WordPress a better CMS if is possible? I did ask the impossible? Is irritated to see how everyone … "yah... just add another plugin" and later you guy come and say, "do not install to many as make site slow". yah... Thanks. I'm 100% sure, I'm not the only one having this feeling, for everything we need plugin .. this is what WordPress begin to be … long time ago apparently. Best regards. Replying to [comment:3 jrf]: > I agree with both the above replies. The desired functionality can already be achieved by either using a [https://developer.wordpress.org/themes/advanced-topics/child-themes/ child theme], by using a (combination of [https://wordpress.org/plugins/ existing plugin(s)] or by creating a [https://developer.wordpress.org/plugins/ custom plugin]. > > I'd suggest closing this issue as this is a feature request for a feature which effectively already exists. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 12:39:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 12:39:54 -0000 Subject: [wp-trac] [WordPress Trac] #56715: New Feature for the WordPress Core In-Reply-To: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> References: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> Message-ID: <071.43ae4bd5ecdf7c9920b9aafeeced7b94@wordpress.org> #56715: New Feature for the WordPress Core -------------------------------------------------+------------------------- Reporter: lucifer37666 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting | Review Component: General | Version: Severity: normal | Resolution: Keywords: reporter-feedback 2nd-opinion close | Focuses: ui, | administration -------------------------------------------------+------------------------- Comment (by lucifer37666): Hi, Yes I know is working. But if the customer want to change theme, will not be anymore in the code. And is not as tech … as we are. My suggestion was to make this into WordPress Core. In the last years the concept go from … "we need plugin for everything" and later … "but in the same time" … "ooo keep site simple, keep site at minimum plugin and remove unused themes, and website to run smooth". This is not good practice. And I'm not a programmer, I'm a advance user. And you all know and feel. Just because Programmers have ability to create a plugin, (Ok, I can do a simple plugin as well); not mean everyone MUST DO like you. And on top of that, use Plugins for everything. Naaaaa Bro. Thanks. Replying to [comment:1 knutsp]: > Hello, welcome to Trac. > > Thank you for this suggestion. I strongly felt this issue many years ago, when working with customizing themes. Later the concept of a child theme was introduced. Have you tried using a child theme? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 13:17:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 13:17:21 -0000 Subject: [wp-trac] [WordPress Trac] #56677: Allow hyphens in post tags In-Reply-To: <062.ec1ba55c97c2336a0f983594a83079fa@wordpress.org> References: <062.ec1ba55c97c2336a0f983594a83079fa@wordpress.org> Message-ID: <077.e3ea6c556719397e8776894b5e53fa69@wordpress.org> #56677: Allow hyphens in post tags --------------------------------+------------------------------ Reporter: cewebdesignmunchen | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: Severity: normal | Resolution: invalid Keywords: close | Focuses: --------------------------------+------------------------------ Comment (by cewebdesignmunchen): Yes, I want keywoooooooooord to go at new line. loooooooooong­keywoooooooooord should break exactly at the soft hyphen when it is too long for responsive webdesign. loooooooooongkeywoooooooooord for desktop. loooooooooong- keywoooooooooord for mobil. Please allow HTML 'SHY' for Posts->Tags like it is allowed for Posts->Titles and Pages->Titles. A Tag name does not have to be a TERM name, does it? Best regards, Chris -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 13:28:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 13:28:54 -0000 Subject: [wp-trac] [WordPress Trac] #56716: Spotify block don't work on fresh install of 6.0.2 In-Reply-To: <054.108f9dc7f90b1705d78ba1a20f436f56@wordpress.org> References: <054.108f9dc7f90b1705d78ba1a20f436f56@wordpress.org> Message-ID: <069.2ad37ac0e1fa47ce6dd97d901ec33de2@wordpress.org> #56716: Spotify block don't work on fresh install of 6.0.2 --------------------------+------------------------------ Reporter: kgmservizi | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: 6.0.2 Severity: normal | Resolution: worksforme Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Changes (by sajjad67): * keywords: => dev-feedback * status: new => closed * resolution: => worksforme Comment: @kgmservizi https://prnt.sc/7MmW4-i0UOgx check out this. FYI `https://open.spotify.com/episode/3kO0Z5JARajMJ0qMwIuhKj` this url doesn't exists! Open your url in a tab, it shows 404, not found! Which means, it doesn't exists! And for your testing, i am providing a url `https://open.spotify.com/playlist/37i9dQZF1DX5Ejj0EkURtP` try this! Or check out `https://open.spotify.com/` to get any playlist or episode or song, and embed it in your site!! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 13:30:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 13:30:11 -0000 Subject: [wp-trac] [WordPress Trac] #56639: Avoid excessive `notoptions` lookups In-Reply-To: <054.64b20a228b6da8a24089fe5effb77fd5@wordpress.org> References: <054.64b20a228b6da8a24089fe5effb77fd5@wordpress.org> Message-ID: <069.2c4d471b873f4d1bd23174b7938eb6f6@wordpress.org> #56639: Avoid excessive `notoptions` lookups ------------------------------------------+----------------------------- Reporter: tillkruess | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Cache API | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch add-to-field-guide | Focuses: performance ------------------------------------------+----------------------------- Changes (by milana_cap): * keywords: has-patch => has-patch add-to-field-guide -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 13:34:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 13:34:09 -0000 Subject: [wp-trac] [WordPress Trac] #56319: Update mediaelement.js to version 4.2.17 In-Reply-To: <051.cc56d52815caf6ae2a0ba9d533a71d2e@wordpress.org> References: <051.cc56d52815caf6ae2a0ba9d533a71d2e@wordpress.org> Message-ID: <066.8bcb7da56d2cb42fc315ead1ca442787@wordpress.org> #56319: Update mediaelement.js to version 4.2.17 -------------------------------------------------+------------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: External Libraries | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug changes-requested | Focuses: has-patch add-to-field-guide | -------------------------------------------------+------------------------- Changes (by milana_cap): * keywords: good-first-bug changes-requested has-patch => good-first-bug changes-requested has-patch add-to-field-guide -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 13:55:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 13:55:30 -0000 Subject: [wp-trac] [WordPress Trac] #56715: New Feature for the WordPress Core In-Reply-To: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> References: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> Message-ID: <071.46329c1f9134b5d27ca0813953d44632@wordpress.org> #56715: New Feature for the WordPress Core -----------------------------+--------------------------------- Reporter: lucifer37666 | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: worksforme Keywords: | Focuses: ui, administration -----------------------------+--------------------------------- Changes (by knutsp): * keywords: reporter-feedback 2nd-opinion close => * status: new => closed * resolution: => worksforme Comment: Either a child theme or a plugin. Your enhancement is already supported, just do things the right way. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 14:04:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 14:04:53 -0000 Subject: [wp-trac] [WordPress Trac] #56715: New Feature for the WordPress Core In-Reply-To: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> References: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> Message-ID: <071.b03f779c571c8a4aba5154a7c28cf466@wordpress.org> #56715: New Feature for the WordPress Core -----------------------------+--------------------------------- Reporter: lucifer37666 | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: worksforme Keywords: | Focuses: ui, administration -----------------------------+--------------------------------- Comment (by jrf): > Why I can put some code into WP core, and I know is there and no waist more time to go grab the code and paste again. Why need plugin for everything? > My suggestions are if WordPress have in Settings a special section, where you can add this customs codes, Like Google Tag Manager, Google AdSense Code, Or Google Analytics and a section to add your own custom code. (Preferable to be able to chose to be added in Body section, Head Section, Footer Section) Just to clarify why this request is not a good candidate for Core. Have a look at your own suggestion. You are asking for three specific fields to be added, each of which is related to an external vendor. There are hundreds of external vendors out there. If WordPress Core would add these three fields, within a day, the next vendor will be saying - ''"vendor A (Google) now has an unfair advantage, so I want a field for my custom codes to be added to WordPress Core as well"''. In the end, there will be hundreds of fields for codes in every single site, users will not be able to find the field they want anymore and most users will only use one or two of the fields anyway (if at all). Also think about this - adding a field like this for one vendor could even lead to the WordPress Foundation (a non-profit) being sued in court and stock market regulators getting involved about WordPress unfairly influencing the market by giving one vendor an unfair advantage over another. So, this is why this is plugin territory. Users can install the plugins which are relevant for their integrations. This is something WP Core should stay far away from. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 14:16:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 14:16:24 -0000 Subject: [wp-trac] [WordPress Trac] #56611: Expand unit tests for `theme.json` In-Reply-To: <051.e24e8bdce8473dfc570cac78e77d5c56@wordpress.org> References: <051.e24e8bdce8473dfc570cac78e77d5c56@wordpress.org> Message-ID: <066.223d3fb98985aee129b7e61e8f58cc83@wordpress.org> #56611: Expand unit tests for `theme.json` ------------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+--------------------- Changes (by johnregan3): * Attachment "56611.diff" added. New theme.json Unit Tests -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 14:23:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 14:23:39 -0000 Subject: [wp-trac] [WordPress Trac] #56611: Expand unit tests for `theme.json` In-Reply-To: <051.e24e8bdce8473dfc570cac78e77d5c56@wordpress.org> References: <051.e24e8bdce8473dfc570cac78e77d5c56@wordpress.org> Message-ID: <066.e7b5e462b3c1a8bf965c99e1feaec5a4@wordpress.org> #56611: Expand unit tests for `theme.json` ------------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+--------------------- Comment (by johnregan3): @desrosj Added new unit tests for: - Gradients - `filter` (Duotones) - `blockGap` - `shadow` - `useRootPaddingAwareAlignments` - `appearanceTools` This is based off of the current version of the [https://developer.wordpress.org/block-editor/reference-guides/theme-json- reference/theme-json-living/ living reference] mentioned above. Please update the Workflow Keywords as you deem appropriate. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 14:39:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 14:39:20 -0000 Subject: [wp-trac] [WordPress Trac] #56408: Blocks: Allow registering multiple items for all supported asset types In-Reply-To: <050.08ce1f395d3b14de8e384c93d05accca@wordpress.org> References: <050.08ce1f395d3b14de8e384c93d05accca@wordpress.org> Message-ID: <065.10964461794434a338dc36aaea0ec506@wordpress.org> #56408: Blocks: Allow registering multiple items for all supported asset types -----------------------------------------------------+--------------------- Reporter: gziolo | Owner: gziolo Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev-note | Focuses: -----------------------------------------------------+--------------------- Comment (by davidbaumwald): In [changeset:"54367" 54367]: {{{ #!CommitTicketReference repository="" revision="54367" Editor: Ensure block script is enqueued, regardless of `ronder_callback`. Follow-up to [54155]. Props aristath, cbravobernal. See #56408. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 15:04:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 15:04:07 -0000 Subject: [wp-trac] [WordPress Trac] #54356: Determine and apply best default quality settings for WebP images In-Reply-To: <059.160a1570e24152f1f8fd5791ebe4a16c@wordpress.org> References: <059.160a1570e24152f1f8fd5791ebe4a16c@wordpress.org> Message-ID: <074.9b84a4aab2abb4dba9d025fc68498cfe@wordpress.org> #54356: Determine and apply best default quality settings for WebP images -------------------------------------------------+------------------------- Reporter: adamsilverstein | Owner: | adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch dev-feedback has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Comment (by mikeschroder): Hi @adamsilverstein! As far as this ticket is concerned, I'm currently (with WebP as it exists in core) most comfortable with either leaving the current value, or changing to 84. I can imagine this being different if/when we're only converting certain sizes, at which point I'd be more comfortable with 82. At this point in the cycle, I'm thinking it would make sense to leave it the same, and commit a change after the branch for 6.2. Is there a reason you think this should be categorized as a bug rather than an enhancement / otherwise get committed during beta? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 15:21:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 15:21:03 -0000 Subject: [wp-trac] [WordPress Trac] #56712: Correct default values in wp_handle_comment_submission() In-Reply-To: <058.8ce19e1d44fec25459ecfabfb5844955@wordpress.org> References: <058.8ce19e1d44fec25459ecfabfb5844955@wordpress.org> Message-ID: <073.dc401aa72b92dc703eba73a92044e70e@wordpress.org> #56712: Correct default values in wp_handle_comment_submission() --------------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Comments | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch php81 has-unit-tests | Focuses: --------------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"54368" 54368]: {{{ #!CommitTicketReference repository="" revision="54368" Code Modernization: Correct default values in `wp_handle_comment_submission()`. This affects the following parameters subsequently passed to `wp_new_comment()`: * `comment_author` * `comment_author_email` * `comment_author_url` * `comment_content` The default values for these parameters were previously set to `null`, causing PHP 8.1 "null to non-nullable" deprecation notices when running sanitization filters on them via `wp_filter_comment()`. While the deprecation notices were temporarily silenced in the unit test suite, that caused an unexpected issue in a test for [source:tags/6.0.2/tests/phpunit/tests/comment-submission.php#L202 submitting a comment to a password protected post], where the `$_COOKIE[ 'wp-postpass_' . COOKIEHASH ]` value was no longer unset, as the test stopped any further execution once the deprecation notice was triggered. Due to how WordPress handles password protected posts, once that value is set, it affects all posts protected with the same password, so this resulted in unintentionally affecting [source:tags/6.0.2/tests/phpunit/tests/rest-api/rest-posts- controller.php#L1866 another test] which happened to use the same password. These values are all documented to be a string in various related filters, and core also expects them to be a string, so there is no reason for these defaults to be set to `null`. Setting them to an empty string instead resolves the issues. This commit includes: * Setting the defaults in `wp_handle_comment_submission()` to an empty string. * Adding a dedicated unit test to verify the type of these default values. * Removing the deprecation notice silencing as no longer needed. Follow-up to [34799], [34801], [51968]. Props jrf, desrosj, mukesh27, SergeyBiryukov. Fixes #56712. See #56681, #55656. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 15:21:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 15:21:03 -0000 Subject: [wp-trac] [WordPress Trac] #56681: Failing unit tests on PHP 8.1 and 8.2 In-Reply-To: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> References: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> Message-ID: <066.97613ce70dc4c4e4dfb51b129169587c@wordpress.org> #56681: Failing unit tests on PHP 8.1 and 8.2 -------------------------------------------------+------------------------- Reporter: desrosj | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54368" 54368]: {{{ #!CommitTicketReference repository="" revision="54368" Code Modernization: Correct default values in `wp_handle_comment_submission()`. This affects the following parameters subsequently passed to `wp_new_comment()`: * `comment_author` * `comment_author_email` * `comment_author_url` * `comment_content` The default values for these parameters were previously set to `null`, causing PHP 8.1 "null to non-nullable" deprecation notices when running sanitization filters on them via `wp_filter_comment()`. While the deprecation notices were temporarily silenced in the unit test suite, that caused an unexpected issue in a test for [source:tags/6.0.2/tests/phpunit/tests/comment-submission.php#L202 submitting a comment to a password protected post], where the `$_COOKIE[ 'wp-postpass_' . COOKIEHASH ]` value was no longer unset, as the test stopped any further execution once the deprecation notice was triggered. Due to how WordPress handles password protected posts, once that value is set, it affects all posts protected with the same password, so this resulted in unintentionally affecting [source:tags/6.0.2/tests/phpunit/tests/rest-api/rest-posts- controller.php#L1866 another test] which happened to use the same password. These values are all documented to be a string in various related filters, and core also expects them to be a string, so there is no reason for these defaults to be set to `null`. Setting them to an empty string instead resolves the issues. This commit includes: * Setting the defaults in `wp_handle_comment_submission()` to an empty string. * Adding a dedicated unit test to verify the type of these default values. * Removing the deprecation notice silencing as no longer needed. Follow-up to [34799], [34801], [51968]. Props jrf, desrosj, mukesh27, SergeyBiryukov. Fixes #56712. See #56681, #55656. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 15:21:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 15:21:04 -0000 Subject: [wp-trac] [WordPress Trac] #55656: PHP 8.x: various compatibility fixes for WordPress 6.1 In-Reply-To: <058.0421e8d94a3ec9d48c1d4d4bd54cce37@wordpress.org> References: <058.0421e8d94a3ec9d48c1d4d4bd54cce37@wordpress.org> Message-ID: <073.64280d3541b51da8740ed1b3df7f56f5@wordpress.org> #55656: PHP 8.x: various compatibility fixes for WordPress 6.1 -------------------------------------------------+------------------------- Reporter: hellofromTonya | Owner: | SergeyBiryukov Type: task (blessed) | Status: accepted Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: php8 php81 has-patch has-unit-tests | Focuses: coding- | standards -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54368" 54368]: {{{ #!CommitTicketReference repository="" revision="54368" Code Modernization: Correct default values in `wp_handle_comment_submission()`. This affects the following parameters subsequently passed to `wp_new_comment()`: * `comment_author` * `comment_author_email` * `comment_author_url` * `comment_content` The default values for these parameters were previously set to `null`, causing PHP 8.1 "null to non-nullable" deprecation notices when running sanitization filters on them via `wp_filter_comment()`. While the deprecation notices were temporarily silenced in the unit test suite, that caused an unexpected issue in a test for [source:tags/6.0.2/tests/phpunit/tests/comment-submission.php#L202 submitting a comment to a password protected post], where the `$_COOKIE[ 'wp-postpass_' . COOKIEHASH ]` value was no longer unset, as the test stopped any further execution once the deprecation notice was triggered. Due to how WordPress handles password protected posts, once that value is set, it affects all posts protected with the same password, so this resulted in unintentionally affecting [source:tags/6.0.2/tests/phpunit/tests/rest-api/rest-posts- controller.php#L1866 another test] which happened to use the same password. These values are all documented to be a string in various related filters, and core also expects them to be a string, so there is no reason for these defaults to be set to `null`. Setting them to an empty string instead resolves the issues. This commit includes: * Setting the defaults in `wp_handle_comment_submission()` to an empty string. * Adding a dedicated unit test to verify the type of these default values. * Removing the deprecation notice silencing as no longer needed. Follow-up to [34799], [34801], [51968]. Props jrf, desrosj, mukesh27, SergeyBiryukov. Fixes #56712. See #56681, #55656. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 15:30:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 15:30:41 -0000 Subject: [wp-trac] [WordPress Trac] #48689: PHP warnings after updating to WP 5.3: ftp_nlist() and ftp_pwd() expect missing parameters In-Reply-To: <053.fb41245b7fec7171e9a13596141bcb59@wordpress.org> References: <053.fb41245b7fec7171e9a13596141bcb59@wordpress.org> Message-ID: <068.85d00c4d5e16102b14bb8ed9ba567226@wordpress.org> #48689: PHP warnings after updating to WP 5.3: ftp_nlist() and ftp_pwd() expect missing parameters -------------------------------------------------+------------------------- Reporter: Hinjiriyo | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future | Release Component: Filesystem API | Version: 5.3 Severity: minor | Resolution: Keywords: php8 needs-unit-tests has-patch | Focuses: needs-testing 2nd-opinion | -------------------------------------------------+------------------------- Comment (by ThemeZee): This issue also seems to happen by using the WPTT/webfont-loader packing in some server environments: https://make.wordpress.org/themes/2020/09/25/new-package-to-allow-locally- hosting-webfonts/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 15:51:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 15:51:45 -0000 Subject: [wp-trac] [WordPress Trac] #56716: Spotify block don't work on fresh install of 6.0.2 In-Reply-To: <054.108f9dc7f90b1705d78ba1a20f436f56@wordpress.org> References: <054.108f9dc7f90b1705d78ba1a20f436f56@wordpress.org> Message-ID: <069.6a928909e25a8e78a50ef91d2123f27f@wordpress.org> #56716: Spotify block don't work on fresh install of 6.0.2 --------------------------+------------------------------ Reporter: kgmservizi | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: 6.0.2 Severity: normal | Resolution: worksforme Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Comment (by kgmservizi): Replying to [comment:3 sajjad67]: > @kgmservizi https://prnt.sc/7MmW4-i0UOgx check out this. FYI `https://open.spotify.com/episode/3kO0Z5JARajMJ0qMwIuhKj` this url doesn't exists! Open your url in a tab, it shows 404, not found! Which means, it doesn't exists! And for your testing, i am providing a url `https://open.spotify.com/playlist/37i9dQZF1DX5Ejj0EkURtP` try this! Or check out `https://open.spotify.com/` to get any playlist or episode or song, and embed it in your site!! @sajjad67 in Italy my link work it is a podcast -> https://prnt.sc/_MaiZYyx8adb I think the problem is only with podcasts because I've tried with another one and don't work (before was good because I used for more than one year and now also old block are broken). Try Ted Podcast (maybe my podcast don't work worldwide) https://open.spotify.com/episode/3QsveAl8G8vjSV8w8QVe16 Best regards -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 15:56:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 15:56:09 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.99b001894fb558c88031bbf927c0913c@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-copy | Focuses: ui, accessibility, docs, needs-design | administration, ui-copy -------------------------+------------------------------------------------- Comment (by sabernhardt): Ticket #6479 needs a user note somewhere, and I think it could fit in the About page **when** the users can manage their site's options. For consideration, I drafted a [https://docs.google.com/document/d/19HCkDpwg722Q9nkpf7mUp8QhW1mkNC7Vw3XFnQg8ZP0/edit?usp=sharing paragraph about the Site Tagline]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:02:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:02:12 -0000 Subject: [wp-trac] [WordPress Trac] #55656: PHP 8.x: various compatibility fixes for WordPress 6.1 In-Reply-To: <058.0421e8d94a3ec9d48c1d4d4bd54cce37@wordpress.org> References: <058.0421e8d94a3ec9d48c1d4d4bd54cce37@wordpress.org> Message-ID: <073.c0a39db126c0fb137934d8922705edda@wordpress.org> #55656: PHP 8.x: various compatibility fixes for WordPress 6.1 -------------------------------------------------+------------------------- Reporter: hellofromTonya | Owner: | SergeyBiryukov Type: task (blessed) | Status: accepted Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: php8 php81 has-patch has-unit-tests | Focuses: coding- | standards -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54369" 54369]: {{{ #!CommitTicketReference repository="" revision="54369" Build/Test Tools: Remove PHP 8.1 and 8.2 from allowed failures. With all known unit test failures now addressed, WordPress 6.1 aims to support PHP 8.1 and 8.2 as much as possible. While full compatibility with PHP 8.1 and 8.2 is still a work in progress, this commit aims to actively prevent new PHP issues from being introduced in WordPress core. All remaining known issues are deprecation notices. Please note, a deprecation notice is not an error, but rather an indicator of where additional work is needed for compatibility before PHP 9 (i.e. when the notices become fatal errors). With a deprecation notice, the PHP code will continue to work and nothing is broken. Follow-up to [49077], [49162], [50299], [51588], [51604], [53922], [54072]. Props jrf, desrosj. See #55652, #55656, #56009, #56681. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:02:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:02:12 -0000 Subject: [wp-trac] [WordPress Trac] #56009: Prepare for PHP 8.2 In-Reply-To: <047.756894109b00e1ebdbed660623a56112@wordpress.org> References: <047.756894109b00e1ebdbed660623a56112@wordpress.org> Message-ID: <062.cc71c6e6608f10c68fc0d1465d3acb0c@wordpress.org> #56009: Prepare for PHP 8.2 -----------------------------+--------------------- Reporter: jrf | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: Keywords: php82 has-patch | Focuses: -----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54369" 54369]: {{{ #!CommitTicketReference repository="" revision="54369" Build/Test Tools: Remove PHP 8.1 and 8.2 from allowed failures. With all known unit test failures now addressed, WordPress 6.1 aims to support PHP 8.1 and 8.2 as much as possible. While full compatibility with PHP 8.1 and 8.2 is still a work in progress, this commit aims to actively prevent new PHP issues from being introduced in WordPress core. All remaining known issues are deprecation notices. Please note, a deprecation notice is not an error, but rather an indicator of where additional work is needed for compatibility before PHP 9 (i.e. when the notices become fatal errors). With a deprecation notice, the PHP code will continue to work and nothing is broken. Follow-up to [49077], [49162], [50299], [51588], [51604], [53922], [54072]. Props jrf, desrosj. See #55652, #55656, #56009, #56681. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:02:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:02:12 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.c3ce3638b0aac765d749a43e852462f1@wordpress.org> #55652: Test tool and unit test improvements for 6.1 --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54369" 54369]: {{{ #!CommitTicketReference repository="" revision="54369" Build/Test Tools: Remove PHP 8.1 and 8.2 from allowed failures. With all known unit test failures now addressed, WordPress 6.1 aims to support PHP 8.1 and 8.2 as much as possible. While full compatibility with PHP 8.1 and 8.2 is still a work in progress, this commit aims to actively prevent new PHP issues from being introduced in WordPress core. All remaining known issues are deprecation notices. Please note, a deprecation notice is not an error, but rather an indicator of where additional work is needed for compatibility before PHP 9 (i.e. when the notices become fatal errors). With a deprecation notice, the PHP code will continue to work and nothing is broken. Follow-up to [49077], [49162], [50299], [51588], [51604], [53922], [54072]. Props jrf, desrosj. See #55652, #55656, #56009, #56681. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:02:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:02:13 -0000 Subject: [wp-trac] [WordPress Trac] #56681: Failing unit tests on PHP 8.1 and 8.2 In-Reply-To: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> References: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> Message-ID: <066.d8680081221945fa7ab11aa5b322620b@wordpress.org> #56681: Failing unit tests on PHP 8.1 and 8.2 -------------------------------------------------+------------------------- Reporter: desrosj | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54369" 54369]: {{{ #!CommitTicketReference repository="" revision="54369" Build/Test Tools: Remove PHP 8.1 and 8.2 from allowed failures. With all known unit test failures now addressed, WordPress 6.1 aims to support PHP 8.1 and 8.2 as much as possible. While full compatibility with PHP 8.1 and 8.2 is still a work in progress, this commit aims to actively prevent new PHP issues from being introduced in WordPress core. All remaining known issues are deprecation notices. Please note, a deprecation notice is not an error, but rather an indicator of where additional work is needed for compatibility before PHP 9 (i.e. when the notices become fatal errors). With a deprecation notice, the PHP code will continue to work and nothing is broken. Follow-up to [49077], [49162], [50299], [51588], [51604], [53922], [54072]. Props jrf, desrosj. See #55652, #55656, #56009, #56681. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:08:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:08:06 -0000 Subject: [wp-trac] [WordPress Trac] #54476: Improve image engine detection when output format adjusted with filter (example: WebP output) In-Reply-To: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> References: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> Message-ID: <074.5ce44751ee86e6bb5b0cd99e5e985602@wordpress.org> #54476: Improve image engine detection when output format adjusted with filter (example: WebP output) --------------------------------------------+------------------------------ Reporter: adamsilverstein | Owner: adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch needs-testing commit | Focuses: --------------------------------------------+------------------------------ Comment (by mikeschroder): @adamsilverstein Thanks! I still don't have an environment I can test this on, but I can do a code review tomorrow. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:08:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:08:57 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.2981902b14269aea5fec57143c18d863@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-copy | Focuses: ui, accessibility, docs, needs-design | administration, ui-copy -------------------------+------------------------------------------------- Comment (by webcommsat): I agree this would be a good location for it. Thanks for sharing it and drafting the google doc. I have made some small suggestions to the google doc @sabernhardt . Is there a dev note that will cover Ticket #6479? The change is quite significant and it would be good for it to be highlighted in other places too including docs and support. I will highlight it to colleagues I'm working alongside in the release docs team. I will raise it in Training too as from memory some items on Learn WordPress.org relate to the site tagline. Thanks. Replying to [comment:18 sabernhardt]: > Ticket #6479 needs a user note somewhere, and I think it could fit in the About page **when** the users can manage their site's options. For consideration, I drafted a [https://docs.google.com/document/d/19HCkDpwg722Q9nkpf7mUp8QhW1mkNC7Vw3XFnQg8ZP0/edit?usp=sharing paragraph about the Site Tagline]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:09:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:09:52 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.094755cb8dc0c6c8f28dbd182b6d42f3@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-copy | Focuses: ui, accessibility, docs, needs-design | administration, ui-copy -------------------------+------------------------------------------------- Comment (by webcommsat): I will share a draft list with Accessibility. Thanks Dan. Replying to [comment:13 dansoschin]: > I think that would be reasonable... can you identify the items that should be included? Thanks! > > Replying to [comment:12 webcommsat]: > > Thanks @dansoschin . Could the About Page have a section on accessibility improvements as there are so many with 6.1? So build on the examples that are already listed in the draft. A few of the changes could then be pulled out further to show WP's commitment to accessibility in this release. > > > > In release docs, a separate post is being considered for end users on the accessibility updates. The Accessibility team in a few of the previous releases have worked on a post which gives more in-depth information about these changes. These could be potential links from the About Page. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:35:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:35:12 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.8a8e186b70d65e15e968be99b5b929ce@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+------------------------------ Reporter: Bernhard Reiter | Owner: Bernhard Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by davidbaumwald): In [changeset:"54370" 54370]: {{{ #!CommitTicketReference repository="" revision="54370" Editor: Make template names and descriptions dynamic, again. In the lead up to 6.1 Beta 2, dynamic titles and descriptions for site editor templates was deemed "feature incomplete" and [54280] was reverted. After further consideration, this code is being re-merged in preparation for Beta 3, reverting the revert in [54333]. Follow-up to [54280] and [54333]. Props bernie, ntsekouras, jorgefilipecosta, jameskoster, cbravobernal. See #56467. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:36:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:36:00 -0000 Subject: [wp-trac] [WordPress Trac] #56681: Failing unit tests on PHP 8.1 and 8.2 In-Reply-To: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> References: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> Message-ID: <066.10d6439a8344c7ef291f4c67e3d5b872@wordpress.org> #56681: Failing unit tests on PHP 8.1 and 8.2 -------------------------------------------------+------------------------- Reporter: desrosj | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * Attachment "56681.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:36:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:36:21 -0000 Subject: [wp-trac] [WordPress Trac] #56681: Failing unit tests on PHP 8.1 and 8.2 In-Reply-To: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> References: <051.55c17d6d2609f6512611a4a72b947d1f@wordpress.org> Message-ID: <066.a03ad24207b0fb2f6eb5f2a999d5ad92@wordpress.org> #56681: Failing unit tests on PHP 8.1 and 8.2 -------------------------------------------------+------------------------- Reporter: desrosj | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): Replying to [comment:10 SergeyBiryukov]: > The test was added in [50717] and has to do with allowing authenticated users to read the contents of password protected posts if they have the `edit_post` meta capability for the post. As you've noted, the test could indeed be improved to check specifically for the expected result, which in this case appears to be `'This content is password protected.'` string, as the test creates a password protected post as an Editor and then tries to view it as a Contributor, which is (correctly) not allowed. Thinking about this some more, the test actually looks correct, as it specifically checks that the content of a password protected post created by an Editor is not viewable by a Contributor. While we could check for the `'This content is password protected.'` string instead, the test would fail if that string is ever updated. I think we can just add a comment here to clarify the assertion, see [attachment:"56681.diff"]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:58:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:58:30 -0000 Subject: [wp-trac] [WordPress Trac] #56442: Ensure `wp_editor_set_quality` filter consistently passes output mime type In-Reply-To: <059.1dc42a2a01ecdd998fb808fb5bce18be@wordpress.org> References: <059.1dc42a2a01ecdd998fb808fb5bce18be@wordpress.org> Message-ID: <074.21f06aa1fd93bf81c4c06e3e505e19a8@wordpress.org> #56442: Ensure `wp_editor_set_quality` filter consistently passes output mime type -------------------------------------------------+------------------------- Reporter: adamsilverstein | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "56442.6.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 16:59:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 16:59:18 -0000 Subject: [wp-trac] [WordPress Trac] #56442: Ensure `wp_editor_set_quality` filter consistently passes output mime type In-Reply-To: <059.1dc42a2a01ecdd998fb808fb5bce18be@wordpress.org> References: <059.1dc42a2a01ecdd998fb808fb5bce18be@wordpress.org> Message-ID: <074.b4855e5fde4068f2d1dc84e9a1e70d7f@wordpress.org> #56442: Ensure `wp_editor_set_quality` filter consistently passes output mime type -------------------------------------------------+------------------------- Reporter: adamsilverstein | Owner: | adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: feedback commit | -------------------------------------------------+------------------------- Changes (by adamsilverstein): * keywords: has-patch has-unit-tests dev-feedback => has-patch has-unit- tests dev-feedback commit Comment: [attachment:"56442.6.diff"] addresses the latest feedback on the ticket and is ready for commit -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 17:49:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 17:49:59 -0000 Subject: [wp-trac] [WordPress Trac] #6479: Encourage people to change default tagline In-Reply-To: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> References: <055.e530d469b6d3d46c70a1707e6bd1ead0@wordpress.org> Message-ID: <070.fd7ab156716a1861737cd1178d805e0b@wordpress.org> #6479: Encourage people to change default tagline -------------------------------------------------+------------------------- Reporter: markjaquith | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Administration | Version: 2.5 Severity: normal | Resolution: fixed Keywords: has-patch needs-user-docs has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Changes (by sabernhardt): * keywords: has-patch needs-user-docs has-unit-tests commit => has-patch needs-user-docs has-unit-tests Comment: I suggested adding a paragraph about the site tagline on the About page (ticket:56357#comment:19). @webcommsat asked about other documentation: > Is there a dev note that will cover Ticket #6479? The change is quite significant and it would be good for it to be highlighted in other places too including docs and support. I will highlight it to colleagues I'm working alongside in the release docs team. I will raise it in Training too as from memory some items on Learn WordPress.org relate to the site tagline. Thanks. I had not planned to write a special dev note about this change, though mentioning it in the Field Guide may help. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 17:51:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 17:51:53 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.cc29a6c8a10fe3a4aa3e27feb6ad3149@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-copy | Focuses: ui, accessibility, docs, needs-design | administration, ui-copy -------------------------+------------------------------------------------- Comment (by sabernhardt): (Discussion about documenting the Site Tagline change in ''other'' places can continue on #6479.) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 18:15:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 18:15:28 -0000 Subject: [wp-trac] [WordPress Trac] #56722: Using SkipLink on my site Message-ID: <052.a0cd174a6e548bef756acdc4477fe483@wordpress.org> #56722: Using SkipLink on my site ---------------------------+----------------------------- Reporter: jthomas2 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.2 Severity: major | Keywords: Focuses: accessibility | ---------------------------+----------------------------- I'm trying to make my site 508 accessible by adding skiplinks to go to main content. I've created a child them and was trying to use the code WordPress Community provided: {{{
Skip to content

Site title

}}} I'm getting a syntax error"syntax error, unexpected token "<", expecting end of file". Can I get help to make this work? Really don't want to have to pay for a plugin. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 20:33:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 20:33:29 -0000 Subject: [wp-trac] [WordPress Trac] #56723: 6.1 Dev Notes Tracking Issue Message-ID: <054.346f9a2f110c221b2751681e2e30cbb9@wordpress.org> #56723: 6.1 Dev Notes Tracking Issue --------------------------+----------------------------- Reporter: milana_cap | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- = 6.1 Dev Notes Tracking Issue To avoid tracking Dev Note authors in private conversations and have the transparency over process, this ticket will be used to list all needed Dev Notes and their authors. Any discussion regarding Dev Notes, asking for reviews, submitting drafts etc, can be done here. == Administration ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #17851 Wrapping Sections with add_settings_section || || @audrasjb || || || || #34564 WP_List_Table::get_column_info() inefficient || performance || @peterwilsoncc || || || || #42066 List tables: consider a new method to generate the views links markup || || @costdev || || || == Bootstrap/Load ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #56068 Send HTTP headers after querying posts in WP::main() || performance || @SergeyBiryukov || @joostdevalk || [https://docs.google.com/document/d/1c0R9ehtw7trNuacPcuGhUG8F1MT0X6sxBfatqDrD6P8/edit draft] || == Cache API ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #4476 Delete Cache by Group || || @spacedmonkey || || grouped? || || #56198 Check cache key type || performance || @SergeyBiryukov || || miscellaneous|grouped || || #56386 Remove `@access private` from cache priming functions. || performance || @peterwilsoncc || || miscellaneous || == Database ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #52506 Add escaping method for table names in SQL queries || performance || @davidbaumwald || || || || #56268 Rename wp-db.php to class-wpdb.php || coding-standards || @SergeyBiryukov || || miscellaneous || == Editor ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #53148 Blocks: Add new `render` property in `block.json` for block types || || @gziolo || || || || #55005 Improve PHP performance for block.json files || performance || @hellofromTonya || || || || #56067 Hide query loop pagination link arrows from assistive technology || accessibility || @audrasjb || @milana_cap || grouped || || #56408 Blocks: Allow registering multiple items for all supported asset types || || @gziolo || || || == Embeds ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #55860 Add Pocket Casts as an oEmbed provider || || @peterwilsoncc || || || == Feeds ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #55904 Add a set of fine-grained filters to disable the different types of feed links separately || || @audrasjb || || || == General ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #35188 Pass nonce action from "nonce_life" filter || || @audrasjb || || || || #53392 add a filter for the arguments of `the_posts_pagination()` || docs || @davidbaumwald || || || || #54394 Add functions for required fields indicator and message || accessibility || @audrasjb || || || || #55194 wp_rand( 0, 0) result in random integer || docs || @audrasjb || || || || #56389 Make wp_required_field_indicator and wp_required_field_message filterable || || @audrasjb || || || == I18N ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #39210 switch_to_locale() unloads all plugin and theme translations || || @ocean90 || || || == Login and Registration ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #40361 Improvements for wp-signup.php and wp-activate.php markup and CSS || accessibility, multisite || @joedolson || || miscellaneous|grouped || || #55388 Lost Password URL filtration || || @davidbaumwald || || miscellaneous|grouped || == Media ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #53232 Add async decoding attribute as default to the HTML image tags generated by WordPress || performance || @adamsilverstein || || || || #54788 Mute a video on WP with [video] || || @antpb || || miscellaneous|grouped || || #55227 Attachments: add caching to wp_count_attachments || performance || @audrasjb || || miscellaneous|grouped || || #55828 Add filter in `wp_read_audio_metadata` function || || @audrasjb || || miscellaneous|grouped || || #56036 Call update_post_parent_caches in WP_Media_List_Table || performance || @antpb || || grouped || || #56037 Call update_post_parent_caches in wp_ajax_query_attachments function || performance || @peterwilsoncc || || grouped || == Networks and Sites ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #21734 Completely remove global terms || multisite || @desrosj || || || == Options, Meta APIs ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #37930 Introduce a general `pre_option` filter in `get_option()` || || @spacedmonkey || || miscellaneous|grouped || == Plugins ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #35357 Introduce did_filter() || || @chriscct7 || || || == Posts, Post Types ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #36723 Add caching to wp_old_slug_redirect || performance || @spacedmonkey || || miscellaneous|grouped || || #36905 Add caching to get_page_by_title || performance || @spacedmonkey || @spacedmonkey || [https://docs.google.com/document/d /1_D3_J1BwWQ8_zpc7TWWypR-29dHC6l7HZ7eNX0eeMZs/edit?usp=sharing draft] || || #37114 Allow short-circuiting `get_post_class` for performance || template, performance || @davidbaumwald || || miscellaneous|grouped || || #45329 get_post_permalink tries is_wp_error on get_post which it will never be || || @SergeyBiryukov || || miscellaneous|grouped || || #56100 Call update_post_author_caches in WP_Posts_List_Table class || || @spacedmonkey || || miscellaneous|grouped || == Query ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #17025 wp_list_authors() is not filterable || || @audrasjb || || || || #22176 Cache the results of the posts_request_ids query || performance || @peterwilsoncc || @spacedmonkey || [https://docs.google.com/document/d /1_D3_J1BwWQ8_zpc7TWWypR-29dHC6l7HZ7eNX0eeMZs/edit?usp=sharing draft] || || #55716 Prime users in cache in WP_Query || performance || @spacedmonkey || @spacedmonkey || [https://docs.google.com/document/d /1_D3_J1BwWQ8_zpc7TWWypR-29dHC6l7HZ7eNX0eeMZs/edit?usp=sharing draft] || == REST API ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #41998 REST API: Add debug mode || || @TimothyBlynJacobs || || || || #52992 REST API: Avoid unnecessarily preparing item links || performance || @spacedmonkey || || || || #55592 Prime caches for featured images in post rest api controller || performance || @spacedmonkey || @spacedmonkey || [https://docs.google.com/document/d/1leEkWUxvcoHd52-lxglz3lX- pS9Fc4nVRGRrH4m9GKk/edit?usp=sharing draft] || || #55593 Prime caches for post parents in post rest api controller || performance || @spacedmonkey || || miscellaneous|grouped || || #55620 Prime caches linked objects in menu item REST API || performance || @spacedmonkey || @spacedmonkey || [https://docs.google.com/document/d/1leEkWUxvcoHd52-lxglz3lX- pS9Fc4nVRGRrH4m9GKk/edit?usp=sharing draft] || || #55674 Improve performance Search REST API || performance || @spacedmonkey || @spacedmonkey || [https://docs.google.com/document/d/1leEkWUxvcoHd52-lxglz3lX- pS9Fc4nVRGRrH4m9GKk/edit?usp=sharing draft] || || #56272 REST API: Prime post caches in comments in endpoint. || performance || @peterwilsoncc || @spacedmonkey || [https://docs.google.com/document/d/1leEkWUxvcoHd52-lxglz3lX- pS9Fc4nVRGRrH4m9GKk/edit?usp=sharing draft] || || #56546 Permit queries by ID in /search REST endpoint || || @kadamwhite || || || == Script Loader ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #42438 Add support for preload links (similar to resource hints) || performance || @swissspidy || || || == Site Health ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #56040 Port Persistent Object Cache Health Check from performance plugin to core || performance || @furi3r || @spacedmonkey || [https://docs.google.com/document/d/11ekflhRTZjxwuXBBDBcvvrRNDL0Gy2NobsuKrHSXdb8/edit?usp=sharing draft] || || #56041 Port Audit Full Page Cache from performance plugin to core || performance || @furi3r || @spacedmonkey || [https://docs.google.com/document/d/11ekflhRTZjxwuXBBDBcvvrRNDL0Gy2NobsuKrHSXdb8/edit?usp=sharing draft] || == Taxonomy ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #54472 Taxonomy: Unregistering taxonomy with default term endlessly regenerates options || performance || @peterwilsoncc || || || || #55606 Add 'ajax_term_search_results' filter || || @audrasjb || || || || #56215 Introduce `is_term_publicly_viewable()` function || || @johnbillion || || || == Themes ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #54541 Add actions to template loading to assist with collecting debug info || performance || @johnbillion || || || || #56180 get_header_image(): may consider adding filter in 'get_header_image()' || administration || @audrasjb || || || || #56283 Add "Block Theme" filter under "Add themes" || accessibility, administration || @audrasjb || || || == Upgrade/Install ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #14179 Theme asking to update (theme with same name on WordPress.org) || || @audrasjb || || || == Users ||= Ticket =||= Focus =||= Owner =||= Note Author =||= Draft =|| || #54874 [New User Notification] Allow conditional mail supression || || @johnbillion || || || || #55594 Prime user meta in WP_User_Query || || @spacedmonkey || || miscellaneous|grouped || -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 20:48:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 20:48:41 -0000 Subject: [wp-trac] [WordPress Trac] #54476: Improve image engine detection when output format adjusted with filter (example: WebP output) In-Reply-To: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> References: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> Message-ID: <074.aa8a8ca0345d979013a29afb177327fa@wordpress.org> #54476: Improve image engine detection when output format adjusted with filter (example: WebP output) --------------------------------------------+------------------------------ Reporter: adamsilverstein | Owner: adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch needs-testing commit | Focuses: --------------------------------------------+------------------------------ Comment (by adamsilverstein): @ironprogrammer - fantastic, thanks for reproducing the testing! > I still don't have an environment I can test this on, but I can do a code review tomorrow. @mikeschroder I couldn't reproduce either, hence the shim [attachment :"shim-for-testing.diff"] which takes a platform with imagick and GD both supporting WebP and hacks away support for WebP in Imagick only. You can use this to simulate the failing environment. > Is it 54476.4.diff​ that should be reviewed, or the most recent revision of the PR? Those should be the same, my preference is for you to review in GitHub - that way you can leave comments inline directly on the code. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 20:50:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 20:50:43 -0000 Subject: [wp-trac] [WordPress Trac] #56715: New Feature for the WordPress Core In-Reply-To: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> References: <056.2677a668384c1b66e0a258e4c524936b@wordpress.org> Message-ID: <071.b022e0d0f6a64c891e49f438695f16f3@wordpress.org> #56715: New Feature for the WordPress Core -----------------------------+--------------------------------- Reporter: lucifer37666 | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: worksforme Keywords: | Focuses: ui, administration -----------------------------+--------------------------------- Comment (by lucifer37666): Yah. Make sense now. After this explanation. Thanks. Replying to [comment:7 jrf]: > > Why I can put some code into WP core, and I know is there and no waist more time to go grab the code and paste again. Why need plugin for everything? > > > My suggestions are if WordPress have in Settings a special section, where you can add this customs codes, Like Google Tag Manager, Google AdSense Code, Or Google Analytics and a section to add your own custom code. (Preferable to be able to chose to be added in Body section, Head Section, Footer Section) > > > Just to clarify why this request is not a good candidate for Core. > > Have a look at your own suggestion. You are asking for three specific fields to be added, each of which is related to an external vendor. There are hundreds of external vendors out there. > > If WordPress Core would add these three fields, within a day, the next vendor will be saying - ''"vendor A (Google) now has an unfair advantage, so I want a field for my custom codes to be added to WordPress Core as well"''. > > In the end, there will be hundreds of fields for codes in every single site, users will not be able to find the field they want anymore and most users will only use one or two of the fields anyway (if at all). > > Also think about this - adding a field like this for one vendor could even lead to the WordPress Foundation (a non-profit) being sued in court and stock market regulators getting involved about WordPress unfairly influencing the market by giving one vendor an unfair advantage over another. > > So, this is why this is plugin territory. Users can install the plugins which are relevant for their integrations. This is something WP Core should stay far away from. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 21:25:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 21:25:11 -0000 Subject: [wp-trac] [WordPress Trac] #53392: add a filter for the arguments of `the_posts_pagination()` In-Reply-To: <050.98c819705718e68c2c14279f9a2fca49@wordpress.org> References: <050.98c819705718e68c2c14279f9a2fca49@wordpress.org> Message-ID: <065.07047bcfeed67e6ab2470491b574c744@wordpress.org> #53392: add a filter for the arguments of `the_posts_pagination()` ---------------------------------------------+---------------------------- Reporter: pbiron | Owner: davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit needs-dev-note | Focuses: docs ---------------------------------------------+---------------------------- Comment (by pbiron): I'll draft some text for #53392 for the `Misc Dev Note`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 22:16:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 22:16:20 -0000 Subject: [wp-trac] [WordPress Trac] #56470: viewScript setting does not set front end scripts for dynamic blocks In-Reply-To: <049.ab43d6c623b919a2bd8fcc7c280490d7@wordpress.org> References: <049.ab43d6c623b919a2bd8fcc7c280490d7@wordpress.org> Message-ID: <064.8eb0d0a29c93825a1aa4d28ba949a3b9@wordpress.org> #56470: viewScript setting does not set front end scripts for dynamic blocks -----------------------------+--------------------------------------------- Reporter: lovor | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Script Loader | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, javascript, administration needs-testing | -----------------------------+--------------------------------------------- Comment (by gziolo): @davidbaumwald, I'm reporting that [54367] effectively resolves this issue. It will have to be included in the dev note for Block API changes in WordPress 6.1. We should also update the following section in the documentation: https://github.com/WordPress/gutenberg/blob/trunk/docs/reference-guides /block-api/block-metadata.md#frontend-enqueueing In particular, the following section must be updated to reflect the changes applied: > viewScript (when the block defines render_callback during registration in PHP or a render field in its block.json, then the script is registered but the block author is responsible for enqueuing it) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 22:26:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 22:26:58 -0000 Subject: [wp-trac] [WordPress Trac] #56723: 6.1 Dev Notes Tracking Issue In-Reply-To: <054.346f9a2f110c221b2751681e2e30cbb9@wordpress.org> References: <054.346f9a2f110c221b2751681e2e30cbb9@wordpress.org> Message-ID: <069.e744877317112c2b3d72a0f076805e05@wordpress.org> #56723: 6.1 Dev Notes Tracking Issue --------------------------+------------------------------ Reporter: milana_cap | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by pbiron): I'll draft some text for #53392 for the `Misc Dev Note`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 22:49:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 22:49:19 -0000 Subject: [wp-trac] [WordPress Trac] #54356: Determine and apply best default quality settings for WebP images In-Reply-To: <059.160a1570e24152f1f8fd5791ebe4a16c@wordpress.org> References: <059.160a1570e24152f1f8fd5791ebe4a16c@wordpress.org> Message-ID: <074.e217093d22a8fa694c677db0700277d5@wordpress.org> #54356: Determine and apply best default quality settings for WebP images -------------------------------------------------+------------------------- Reporter: adamsilverstein | Owner: | adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: 6.2 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch dev-feedback has-unit- | Focuses: tests early | performance -------------------------------------------------+------------------------- Changes (by adamsilverstein): * keywords: has-patch dev-feedback has-unit-tests => has-patch dev- feedback has-unit-tests early * milestone: Future Release => 6.2 Comment: > Is there a reason you think this should be categorized as a bug rather than an enhancement / otherwise get committed during beta? Mostly because I think the current value is a bit (subjectively) "wrong" so it feels like a bug. I'm fine punting to 6.2 and a settling value of 84; I'll plan to commit this when the branch opens. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 23:22:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 23:22:05 -0000 Subject: [wp-trac] [WordPress Trac] #42670: Symlinked plugin makes plugin_basename function return wrong basename In-Reply-To: <054.8b98487897eeff90b80da83c7eb41a32@wordpress.org> References: <054.8b98487897eeff90b80da83c7eb41a32@wordpress.org> Message-ID: <069.ce31b573df6c1cc55b6810a8e238ab29@wordpress.org> #42670: Symlinked plugin makes plugin_basename function return wrong basename ----------------------------------------------------+--------------------- Reporter: sergiienko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Plugins | Version: 4.9 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-testing | Focuses: ----------------------------------------------------+--------------------- Changes (by ironprogrammer): * Attachment "42670.2.diff" added. Refresh of 42670.diff -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 23:30:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 23:30:57 -0000 Subject: [wp-trac] [WordPress Trac] #42670: Symlinked plugin makes plugin_basename function return wrong basename In-Reply-To: <054.8b98487897eeff90b80da83c7eb41a32@wordpress.org> References: <054.8b98487897eeff90b80da83c7eb41a32@wordpress.org> Message-ID: <069.c891baccc3a18f3d9b399dea0011ae11@wordpress.org> #42670: Symlinked plugin makes plugin_basename function return wrong basename ----------------------------------------------------+--------------------- Reporter: sergiienko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Plugins | Version: 4.9 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-testing | Focuses: ----------------------------------------------------+--------------------- Comment (by ironprogrammer): In [https://core.trac.wordpress.org/attachment/ticket/42670/42670.2.diff 42670.2.diff], refreshes patch from @brianhenryie: - Adjust spacing for WPCS standards in `plugin.php`. - Use `assertSame()` in unit test. - Add assertion failure message. - Update test for readability. Thank you, @brianhenryie! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 23:31:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 23:31:46 -0000 Subject: [wp-trac] [WordPress Trac] #56718: register_post_meta not being initialized default value right away In-Reply-To: <054.d88ee8de0d30d4b939f35bdf97cc151f@wordpress.org> References: <054.d88ee8de0d30d4b939f35bdf97cc151f@wordpress.org> Message-ID: <069.cc5a718ea3c2ebff82a52d18148cf2ff@wordpress.org> #56718: register_post_meta not being initialized default value right away --------------------------------+------------------------------ Reporter: kaimaniiii | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: 5.5 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------------+------------------------------ Comment (by kaimaniiii): Replying to [comment:1 spacedmonkey]: > Thanks for your ticket @kaimaniiii. > > However, I think the issue here is a very simply one. > > Consider this line. > {{{#!php > add_action( 'rest_api_init', 'autoload_register_meta_post_core_feature_image', 9999 ); > }}} > > This only registers the meta on the rest api init. If you try to load meta in another context like on the front end or in a rss, this meta would be registered. If you can it to simple be the following, it should fix the issue. > > {{{#!php > add_action( 'init', 'autoload_register_meta_post_core_feature_image', 9999 ); > }}} > > I will await your response, but otherwise I believe there is no issue here. Oh wow! You are right! It seems like I didn't use the correct hook name! Another question! How come is that the default value is returning as "true", but when I am toggling off and back on again, then I get the value "1" instead? Is there some sort of way I can make it always return "true" instead of "1"? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 3 23:55:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Oct 2022 23:55:12 -0000 Subject: [wp-trac] [WordPress Trac] #56724: unexpected sudden change in the site without any intervention from my side Message-ID: <054.ae282d097c73ae909b53dfdca5ad83c7@wordpress.org> #56724: unexpected sudden change in the site without any intervention from my side --------------------------+----------------------------- Reporter: mainoffice | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: blocker | Keywords: Focuses: | --------------------------+----------------------------- suddenly i found the website has changed but i did not do any change , i found 18 pages has been published since 2015, i did not add any of them and i just opened my website from a month the homepage itself it's completely changed i am still using the same theme but my change does not appear on the website after publishing it . how can i return my website as it was? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 00:23:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 00:23:06 -0000 Subject: [wp-trac] [WordPress Trac] #56470: viewScript setting does not set front end scripts for dynamic blocks In-Reply-To: <049.ab43d6c623b919a2bd8fcc7c280490d7@wordpress.org> References: <049.ab43d6c623b919a2bd8fcc7c280490d7@wordpress.org> Message-ID: <064.e156fbd32ea6e3d8ff8a18ffaad1f6f5@wordpress.org> #56470: viewScript setting does not set front end scripts for dynamic blocks -------------------------------------+------------------------------------- Reporter: lovor | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Script Loader | Version: trunk Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: ui, javascript, needs-dev-note | administration -------------------------------------+------------------------------------- Changes (by davidbaumwald): * keywords: has-patch needs-testing => has-patch needs-testing needs-dev- note * milestone: Awaiting Review => 6.1 Comment: @gziolo Thanks for the report! I'm tagging for a Dev Note to ensure this is picked up by the Docs leads for 6.1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 00:43:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 00:43:44 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.4b577e6de033beb87d4e0787820c05f5@wordpress.org> #55652: Test tool and unit test improvements for 6.1 --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by desrosj): In [changeset:"54371" 54371]: {{{ #!CommitTicketReference repository="" revision="54371" Build/Test Tools: Display PHPCS results in the GitHub Action logs. When running PHPCS scans (both for checking coding standards and PHP version compatibility), the results are currently only returned silently in a format that GitHub can consume for contextually annotating any code being flagged. This changes workflows using PHPCS to also display the results of each scan in the GitHub Action log, making it easier to find and understand what is causing failures. Props jrf. See #55652. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 01:10:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 01:10:26 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.0f3f894e0c7d5e941572a3b98d519f8e@wordpress.org> #56383: Import Twenty Twenty-Three --------------------------------------+----------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Comment (by desrosj): In [changeset:"54372" 54372]: {{{ #!CommitTicketReference repository="" revision="54372" Twenty Twenty-Three: Bug fixes and improvements for beta 3. This brings over the latest bug fixes and improvements ahead of WordPress 6.1 beta 3. For a full list of changes being included, see the `twentytwentythree` repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/ac96e8d545a69fc6515312d548b036f267ec7104...ca662828b7e3ae12e03f35903a83cf2cfaa4ce4f. Props mikachan, poena, madhudollu, beafialho, colorful-tones, scruffian, tahmidulkarim, joen, taskotr, zoonini, mayuge, ndiego, collet. See #56383. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 01:25:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 01:25:56 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.6f59c042a3652ae91ca2805c3c6144b2@wordpress.org> #55652: Test tool and unit test improvements for 6.1 --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by desrosj): In [changeset:"54373" 54373]: {{{ #!CommitTicketReference repository="" revision="54373" Build/Test Tools: Update `github-script` action to the latest version. The latest version of the `actions/github-script` action fixes an issue where passing options to the action would remove any default values not passed (see https://github.com/actions/github-script/pull/293). This also includes updates to other third-party actions, bringing all third-party versions in Core workflows to their latest versions: - `actions/cache` - `actions/setup-node` - `codecov/codecov-action` See #55652. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 01:41:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 01:41:28 -0000 Subject: [wp-trac] [WordPress Trac] #56702: Twenty Seventeen: Update jQuery scrollTo to the latest version In-Reply-To: <051.a41f0e14980bde81051a9c2f3260a852@wordpress.org> References: <051.a41f0e14980bde81051a9c2f3260a852@wordpress.org> Message-ID: <066.c003d6d37d4ffcb34615ba0396cfa417@wordpress.org> #56702: Twenty Seventeen: Update jQuery scrollTo to the latest version ---------------------------------------------+-------------------------- Reporter: desrosj | Owner: sarahricker Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: ---------------------------------------------+-------------------------- Changes (by desrosj): * keywords: good-first-bug has-patch needs-testing => good-first-bug has- patch commit -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 01:42:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 01:42:15 -0000 Subject: [wp-trac] [WordPress Trac] #56702: Twenty Seventeen: Update jQuery scrollTo to the latest version In-Reply-To: <051.a41f0e14980bde81051a9c2f3260a852@wordpress.org> References: <051.a41f0e14980bde81051a9c2f3260a852@wordpress.org> Message-ID: <066.a5a31ce6ed9731becaf55d975827ebee@wordpress.org> #56702: Twenty Seventeen: Update jQuery scrollTo to the latest version ---------------------------------------------+-------------------------- Reporter: desrosj | Owner: sarahricker Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: ---------------------------------------------+-------------------------- Changes (by desrosj): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"54374" 54374]: {{{ #!CommitTicketReference repository="" revision="54374" Twenty Seventeen: Update the `scrollTo` jQuery plugin. This updates the `scrollTo` jQuery plugin included in Twenty Seventeen to the latest version, `2.1.3`. For a full list of changes in this update, see GitHub: https://github.com/flesler/jquery.scrollTo/compare/2.1.2...v2.1.3. Props sarahricker, mukesh27, desrosj. Fixes #56702. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 01:45:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 01:45:29 -0000 Subject: [wp-trac] [WordPress Trac] #55903: Update readme with the right nodejs version commands In-Reply-To: <063.4e41d1777f0361db73454270a91e8741@wordpress.org> References: <063.4e41d1777f0361db73454270a91e8741@wordpress.org> Message-ID: <078.bdd5a39da749bc059c33677692823ffb@wordpress.org> #55903: Update readme with the right nodejs version commands ---------------------------------------------+------------------------ Reporter: elpanda13@… | Owner: desrosj Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch commit | Focuses: ---------------------------------------------+------------------------ Changes (by desrosj): * keywords: good-first-bug has-patch changes-requested => good-first-bug has-patch commit Comment: Going to make some slight adjustments pre-commit. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 01:50:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 01:50:47 -0000 Subject: [wp-trac] [WordPress Trac] #55903: Update readme with the right nodejs version commands In-Reply-To: <063.4e41d1777f0361db73454270a91e8741@wordpress.org> References: <063.4e41d1777f0361db73454270a91e8741@wordpress.org> Message-ID: <078.6fe7116ff4d3bf5ef614b7722f661005@wordpress.org> #55903: Update readme with the right nodejs version commands ---------------------------------------------+---------------------- Reporter: elpanda13@… | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: ---------------------------------------------+---------------------- Changes (by desrosj): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"54375" 54375]: {{{ #!CommitTicketReference repository="" revision="54375" Build/Test Tools: Note the versions of NodeJS and npm supported. This adds a note to the Getting Started section of the `README.md` file mentioning that NodeJS `14.x` and npm `6.x` is currently required to spin up a development environment. Props elpanda13gmailcom, robinwpwebdeveloper, jakariaistauk, hztyfoon, seakashdiu, rudlinkon, fuadragib. Fixes #55903. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 01:53:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 01:53:55 -0000 Subject: [wp-trac] [WordPress Trac] #55903: Update readme with the right nodejs version commands In-Reply-To: <063.4e41d1777f0361db73454270a91e8741@wordpress.org> References: <063.4e41d1777f0361db73454270a91e8741@wordpress.org> Message-ID: <078.ccf4421b7b9fda447427a87e52570fbf@wordpress.org> #55903: Update readme with the right nodejs version commands ---------------------------------------------+---------------------- Reporter: elpanda13@… | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: ---------------------------------------------+---------------------- Comment (by desrosj): I missed @mukesh27 in the props and miscredited @robinwpdeveloper, but I've gone and corrected this manually and props are now showing on your .org profiles correctly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 01:58:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 01:58:58 -0000 Subject: [wp-trac] [WordPress Trac] #56611: Expand unit tests for `theme.json` In-Reply-To: <051.e24e8bdce8473dfc570cac78e77d5c56@wordpress.org> References: <051.e24e8bdce8473dfc570cac78e77d5c56@wordpress.org> Message-ID: <066.b022d44a9a7566e91f7a88e003c6563d@wordpress.org> #56611: Expand unit tests for `theme.json` --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by desrosj): * keywords: needs-patch needs-unit-tests => has-patch has-unit-tests Comment: Thanks @johnregan3! I'm going to create a GitHub pull request just to confirm the tests are passing correctly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:01:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:01:47 -0000 Subject: [wp-trac] [WordPress Trac] #56692: Update GetID3 to version 1.9.22 In-Reply-To: <047.914635d664b52ee4c14db9cf9a43cf70@wordpress.org> References: <047.914635d664b52ee4c14db9cf9a43cf70@wordpress.org> Message-ID: <062.0889b05e792015579a6ff86c99cf0ea0@wordpress.org> #56692: Update GetID3 to version 1.9.22 ------------------------------------+------------------------ Reporter: jrf | Owner: desrosj Type: task (blessed) | Status: reviewing Priority: normal | Milestone: 6.1 Component: External Libraries | Version: trunk Severity: normal | Resolution: Keywords: php81 has-patch commit | Focuses: ------------------------------------+------------------------ Changes (by desrosj): * keywords: php81 has-patch => php81 has-patch commit Comment: I'd like to get this in before beta 3, so going to commit after just looking through it once more. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:06:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:06:43 -0000 Subject: [wp-trac] [WordPress Trac] #56692: Update GetID3 to version 1.9.22 In-Reply-To: <047.914635d664b52ee4c14db9cf9a43cf70@wordpress.org> References: <047.914635d664b52ee4c14db9cf9a43cf70@wordpress.org> Message-ID: <062.e5124d478511679eea686f3773a28e27@wordpress.org> #56692: Update GetID3 to version 1.9.22 ------------------------------------+---------------------- Reporter: jrf | Owner: desrosj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: php81 has-patch commit | Focuses: ------------------------------------+---------------------- Changes (by desrosj): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"54376" 54376]: {{{ #!CommitTicketReference repository="" revision="54376" External Libraries: Update getID3 to version `1.9.22`. This updates the getID3 library from version `1.9.21` to `1.9.22`, which contains a number of bug fixes and improvements to PHP 8.1 support. A full list of changes can be found on GitHub: https://github.com/JamesHeinrich/getID3/compare/v1.9.21...v1.9.22. Props jrf, desrosj. Fixes #56692. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:08:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:08:31 -0000 Subject: [wp-trac] [WordPress Trac] #56692: Update GetID3 to version 1.9.22 In-Reply-To: <047.914635d664b52ee4c14db9cf9a43cf70@wordpress.org> References: <047.914635d664b52ee4c14db9cf9a43cf70@wordpress.org> Message-ID: <062.7f3813aef3f1006ed1353e0b105d874b@wordpress.org> #56692: Update GetID3 to version 1.9.22 ------------------------------------+---------------------- Reporter: jrf | Owner: desrosj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: php81 has-patch commit | Focuses: ------------------------------------+---------------------- Comment (by jrf): @desrosj Sorry, I didn't manage to get to this PR today. If you like, I'll have a look tomorrow early to confirm all is okay. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:11:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:11:47 -0000 Subject: [wp-trac] [WordPress Trac] #56692: Update GetID3 to version 1.9.22 In-Reply-To: <047.914635d664b52ee4c14db9cf9a43cf70@wordpress.org> References: <047.914635d664b52ee4c14db9cf9a43cf70@wordpress.org> Message-ID: <062.11a48965e2721b4cb0dc881a131c8b48@wordpress.org> #56692: Update GetID3 to version 1.9.22 ------------------------------------+---------------------- Reporter: jrf | Owner: desrosj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: External Libraries | Version: trunk Severity: normal | Resolution: fixed Keywords: php81 has-patch commit | Focuses: ------------------------------------+---------------------- Comment (by desrosj): No worries! I wanted to have it included in beta 3 so that it could benefit from some wider testing and reverted if need be prior to RC1 next week. Another review at any time would be great just to confirm I didn't miss something. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:14:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:14:32 -0000 Subject: [wp-trac] [WordPress Trac] #56713: Check ACL permission before upgrading In-Reply-To: <053.974eade6a1ddb239976f0890e1e14f6c@wordpress.org> References: <053.974eade6a1ddb239976f0890e1e14f6c@wordpress.org> Message-ID: <068.acef714e9c71101544423ca6462d59c0@wordpress.org> #56713: Check ACL permission before upgrading -----------------------------+------------------------------ Reporter: Cartman34 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Changes (by desrosj): * component: General => Upgrade/Install -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:17:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:17:22 -0000 Subject: [wp-trac] [WordPress Trac] #56696: Twenty Eleven: Correctly escape stylesheet URL In-Reply-To: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> References: <058.c0497b62eb27b95056eda69a89db7fbb@wordpress.org> Message-ID: <073.23b41c1df753c7dd7968e17700dece33@wordpress.org> #56696: Twenty Eleven: Correctly escape stylesheet URL ----------------------------+------------------------ Reporter: Alberuni Azad. | Owner: desrosj Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: 3.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+------------------------ Changes (by desrosj): * keywords: has-patch changes-requested => has-patch * owner: (none) => desrosj * status: new => reviewing * milestone: Awaiting Review => 6.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:17:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:17:43 -0000 Subject: [wp-trac] [WordPress Trac] #56717: Twenty Eleven: Correctly escape template directory uri In-Reply-To: <058.d5e17afb904b19a7ec5ac51e629ec7f3@wordpress.org> References: <058.d5e17afb904b19a7ec5ac51e629ec7f3@wordpress.org> Message-ID: <073.8aada2725f2132ab4cb274cddca26843@wordpress.org> #56717: Twenty Eleven: Correctly escape template directory uri ----------------------------+------------------------ Reporter: Alberuni Azad. | Owner: desrosj Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+------------------------ Changes (by desrosj): * owner: (none) => desrosj * status: new => reviewing * milestone: Awaiting Review => 6.1 Comment: Related: #56696. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:26:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:26:09 -0000 Subject: [wp-trac] [WordPress Trac] #45943: Twenty Nineteen: Consider adding additional social media icons In-Reply-To: <050.5ee16cba928aa906e95dd136b1e54f5b@wordpress.org> References: <050.5ee16cba928aa906e95dd136b1e54f5b@wordpress.org> Message-ID: <065.010b44271832bdc2c58573cc579fcf17@wordpress.org> #45943: Twenty Nineteen: Consider adding additional social media icons ---------------------------+------------------------------ Reporter: kjellr | Owner: (none) Type: enhancement | Status: new Priority: low | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.0 Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+------------------------------ Changes (by desrosj): * version: 5.0.3 => 5.0 Comment: It was announced that requests for new icons in Twenty Twenty were no longer going to be considered as of WordPress 5.5 (see the [https://make.wordpress.org/core/2020/07/30/themes-field-guide- wordpress-5-5/ Theme Field Guide]). I think that we should confirm the ability to fully add custom icons through filters (similar to #48713) and then take the same policy in Twenty Nineteen. The block editor has a number of social and website icons available to any site on any theme through blocks. Any new icon requests should probably flow through the [https://github.com/wordpress/gutenberg Gutenberg repository]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:27:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:27:53 -0000 Subject: [wp-trac] [WordPress Trac] #39598: Twenty Seventeen: Can't scroll on iPhone 4 In-Reply-To: <057.eebcf2590a16b3f0341fb612524ec819@wordpress.org> References: <057.eebcf2590a16b3f0341fb612524ec819@wordpress.org> Message-ID: <072.800e5d68fc8cc91e9ed75e0e2d3a43db@wordpress.org> #39598: Twenty Seventeen: Can't scroll on iPhone 4 -------------------------------------------------+------------------------- Reporter: superpoincare | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: 4.7.1 Severity: normal | Resolution: wontfix Keywords: has-patch needs-testing needs- | Focuses: css screenshots needs-refresh | -------------------------------------------------+------------------------- Changes (by desrosj): * status: new => closed * resolution: => wontfix * milestone: Future Release => Comment: Since this report is targeted at a now fully unsupported version of iOS/iPhone, going to close this out. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:35:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:35:44 -0000 Subject: [wp-trac] [WordPress Trac] #56496: Twenty Twenty-Two: Update comment block markup In-Reply-To: <052.0de4b38c507c5e0ca5f9b4c24e1b9b2b@wordpress.org> References: <052.0de4b38c507c5e0ca5f9b4c24e1b9b2b@wordpress.org> Message-ID: <067.2af4286488d79fbe5352240efc5c5b9e@wordpress.org> #56496: Twenty Twenty-Two: Update comment block markup ---------------------------+----------------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+----------------------------- Comment (by desrosj): To be clear, I was not moving this to `Future Release` because of the type of issue, but rather the problem is more complicated than just updating the syntax. I personally don't think that conditionally loading a different syntax based on the version of WordPress being used is a good solution. Where does that end? In my opinion, the block editor should be more defensive about handling older syntax and mapping them into newer, more compatible versions. @poena Could you expand on why this is an accessibility bug just so I correctly understand that aspect? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:39:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:39:37 -0000 Subject: [wp-trac] [WordPress Trac] #30439: Twenty Fourteen: Social Menu In-Reply-To: <052.513e78d4deaf51c8b5a9da4621307a22@wordpress.org> References: <052.513e78d4deaf51c8b5a9da4621307a22@wordpress.org> Message-ID: <067.8e36e73308b974e2c52ad2717885fb66@wordpress.org> #30439: Twenty Fourteen: Social Menu -------------------------------------------------+------------------------- Reporter: wilflare | Owner: | janhenckens Type: feature request | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: 4.0.1 Severity: normal | Resolution: wontfix Keywords: good-first-bug has-patch needs- | Focuses: refresh | -------------------------------------------------+------------------------- Changes (by desrosj): * status: assigned => closed * resolution: => wontfix * milestone: Future Release => Comment: I'm going to close this one out as a `wontfix`. We've started to take a stance of "no new social icon requests" in other themes (see the [https://make.wordpress.org/core/2020/07/30/themes-field- guide-wordpress-5-5/ WordPress 5.5 Theme Field Guide for Twenty Twenty]). I think that should extend here to this request. Additionally, the block editor has a growing number of social icons supported that work on any theme. Those blocks should be used instead. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:40:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:40:30 -0000 Subject: [wp-trac] [WordPress Trac] #45950: Twenty Nineteen: Fix social media icons to use the correct height & width attribute In-Reply-To: <053.bfbadd916c879f336f373ff6ac86b36c@wordpress.org> References: <053.bfbadd916c879f336f373ff6ac86b36c@wordpress.org> Message-ID: <068.b2d4b3c776cd205722e1e2c6cb89f690@wordpress.org> #45950: Twenty Nineteen: Fix social media icons to use the correct height & width attribute -------------------------------------------------+------------------------- Reporter: crunnells | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future | Release Component: Bundled Theme | Version: 5.0.3 Severity: normal | Resolution: Keywords: has-screenshots needs-patch good- | Focuses: first-bug | -------------------------------------------------+------------------------- Changes (by desrosj): * keywords: has-screenshots needs-patch => has-screenshots needs-patch good-first-bug -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:42:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:42:34 -0000 Subject: [wp-trac] [WordPress Trac] #54397: e2e timeout errors: waiting for selection `.components-snackbar` In-Reply-To: <058.9f9ccf86eb9ae419d1e6878832ee6a09@wordpress.org> References: <058.9f9ccf86eb9ae419d1e6878832ee6a09@wordpress.org> Message-ID: <073.e53f0fc6d1dbde931e1912617b334c29@wordpress.org> #54397: e2e timeout errors: waiting for selection `.components-snackbar` ------------------------------+------------------------------ Reporter: hellofromTonya | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------+------------------------------ Changes (by desrosj): * type: task (blessed) => defect (bug) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:44:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:44:44 -0000 Subject: [wp-trac] [WordPress Trac] #45614: Build Tools: grunt build fails if mu-plugins and uploads directories has many files In-Reply-To: <054.a2b55190fd68eec782d7a9e60279ca52@wordpress.org> References: <054.a2b55190fd68eec782d7a9e60279ca52@wordpress.org> Message-ID: <069.d6a16601732d3fd44ddb49f12d6b7040@wordpress.org> #45614: Build Tools: grunt build fails if mu-plugins and uploads directories has many files -------------------------------+------------------------- Reporter: Nikschavan | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Build/Test Tools | Version: 5.0 Severity: normal | Resolution: worksforme Keywords: reporter-feedback | Focuses: -------------------------------+------------------------- Changes (by desrosj): * status: new => closed * resolution: => worksforme * milestone: Awaiting Review => Comment: Going to close this one out due to a lack of reporter feedback. If someone else is able to reproduce and provide more details, please feel free to reopen! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:47:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:47:24 -0000 Subject: [wp-trac] [WordPress Trac] #50482: Uncaught Exception: Serialization of 'Closure' is not allowed when run PHPUnit in plugin development In-Reply-To: <052.a1af77c59069e7846fffb4510870d0f3@wordpress.org> References: <052.a1af77c59069e7846fffb4510870d0f3@wordpress.org> Message-ID: <067.e4b87e8f0317ae05abf07a7ff9625670@wordpress.org> #50482: Uncaught Exception: Serialization of 'Closure' is not allowed when run PHPUnit in plugin development ------------------------------+---------------------- Reporter: yshinoda | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Build/Test Tools | Version: 5.5 Severity: critical | Resolution: invalid Keywords: | Focuses: ------------------------------+---------------------- Changes (by desrosj): * keywords: close => * status: reopened => closed * resolution: => invalid * milestone: Awaiting Review => Comment: It's been 14 months without any further activity. I'm going to close this one out again. If anyone feels this is incorrect, please provide some more details. Discussion can always continue on closed tickets. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:50:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:50:59 -0000 Subject: [wp-trac] [WordPress Trac] #52302: Emoji detection not working in the latest Chrome on Windows 7 In-Reply-To: <058.cc5db857ec6e5cddb69dc65c597d5e4d@wordpress.org> References: <058.cc5db857ec6e5cddb69dc65c597d5e4d@wordpress.org> Message-ID: <073.c858fdac0457574ec802325d3cf6a679@wordpress.org> #52302: Emoji detection not working in the latest Chrome on Windows 7 -----------------------------------+------------------------------ Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Emoji | Version: 5.5 Severity: normal | Resolution: Keywords: has-screenshots close | Focuses: -----------------------------------+------------------------------ Changes (by desrosj): * keywords: has-screenshots => has-screenshots close Comment: Since Windows 7 has now been unsupported for almost 3 years, thinking this can probably be closed out. @SergeyBiryukov are you able to reproduce this today in a way that makes you feel this should remain open for further investigation? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 02:56:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 02:56:52 -0000 Subject: [wp-trac] [WordPress Trac] #18909: Bundled jQuery UI should have CSS In-Reply-To: <049.6318b4a78c6f909fedd52090f9fd61bc@wordpress.org> References: <049.6318b4a78c6f909fedd52090f9fd61bc@wordpress.org> Message-ID: <064.28007432abde2b15bdc070c4056db2af@wordpress.org> #18909: Bundled jQuery UI should have CSS --------------------------------+----------------------------- Reporter: helen | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: External Libraries | Version: 3.3 Severity: normal | Resolution: Keywords: needs-patch close | Focuses: ui --------------------------------+----------------------------- Changes (by desrosj): * keywords: needs-patch => needs-patch close Comment: I'm not convinced that this is something that would benefit the majority of users in 2022, or that its in demand enough (8+ years without any contributors feeling strongly enough to work on it). I think this ship has sailed, and most plugins or themes needing jQuery UI are likely just loading their own. Marking with a `close` suggestion, but leaving open for a bit to allow for anyone that strongly disagrees to weigh in. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 03:03:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 03:03:19 -0000 Subject: [wp-trac] [WordPress Trac] #36374: Audio playback fails on iOS 9.x In-Reply-To: <051.1f2508aaa816e9b02e62f1144ac52d80@wordpress.org> References: <051.1f2508aaa816e9b02e62f1144ac52d80@wordpress.org> Message-ID: <066.e9e24f5a332d0dd340ea044dfed184f7@wordpress.org> #36374: Audio playback fails on iOS 9.x --------------------------------+----------------------------- Reporter: Clorith | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: External Libraries | Version: 4.4.2 Severity: normal | Resolution: Keywords: close | Focuses: javascript --------------------------------+----------------------------- Changes (by desrosj): * keywords: => close Comment: I'm marking this as a `close` candidate and will return in a few months unless someone disagrees (please add details why). It's been 7+ years since the issue occurred, and no further reports. While it's still possible someone has a device running iOS 9.x, that version has been discontinued and unsupported (last release was July 2019, 3+ years ago). @pauljacobson if you are still able to reproduce this problem, could you open a new Trac ticket with any updated steps to reproduce? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 03:15:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 03:15:01 -0000 Subject: [wp-trac] [WordPress Trac] #56721: get_page_by_title: duplicate SQL query In-Reply-To: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> References: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> Message-ID: <070.0732e5100698441dfc6eeaccc86dda2e@wordpress.org> #56721: get_page_by_title: duplicate SQL query -------------------------------+---------------------------- Reporter: david.binda | Owner: peterwilsoncc Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Posts, Post Types | Version: trunk Severity: normal | Resolution: Keywords: has-patch commit | Focuses: performance -------------------------------+---------------------------- Changes (by peterwilsoncc): * keywords: has-patch commit has-unit-tests => has-patch commit * owner: (none) => peterwilsoncc * status: new => assigned Comment: Thanks for the patch @davidbinda. I've added a test in the [https://github.com/WordPress/wordpress- develop/pull/3400 linked pull request] and will commit once the checks start passing. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 03:23:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 03:23:52 -0000 Subject: [wp-trac] [WordPress Trac] #56685: Remove LiveJournal from importer recommendations In-Reply-To: <048.c77a2480717176c8f00cce631d798ce2@wordpress.org> References: <048.c77a2480717176c8f00cce631d798ce2@wordpress.org> Message-ID: <063.8956ac44420a525a4f06fd297ccf77a1@wordpress.org> #56685: Remove LiveJournal from importer recommendations --------------------------+------------------------------ Reporter: dd32 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Import | Version: Severity: normal | Resolution: Keywords: 2nd-opinion | Focuses: administration --------------------------+------------------------------ Comment (by dd32): Replying to [comment:1 costdev]: > > After reviewing some data, including the support threads and plugin directory install metrics, I recommend that we retire the LiveJournal plugin from being recommended on the Importer screen. > > What did the plugin directory install metrics show? The metrics I looked at included: - Active install growth: Declining - Number of "new installs" (an internal wordpress.org number, counting the number of 'new' sites it's seen it be used on), which suggests there's been no new sites installing it in the last year - Support Forum activity: Last thread 5 years ago > Were there any (other) significant and verified bugs that you came across? I didn't test the importer myself, I deferred to @vishnugopal for that. Looking at some private notes, it appears that I may have misread - The importer isn't entirely broken, it just doesn't migrate comments. However, It's usage on WordPress.com appears to be negligible, combined with seemingly no WordPress.org usage, suggests it's not the most important importer to suggest be used / for the limited hours people have for importers to dedicate to. > there's a bigger question of maintenance - and this component doesn't have any maintainers. This might be raised in the next devchat to see if anyone wants to take on maintenance of this plugin. #meta5550 covers some of that, tl;dr I've imported a bunch of seemingly active plugins to GitHub and some of the WordPress.com Importer team are going to donate some time to cleanup and collate any fixes/bugs/etc needed on those repo's. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 03:31:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 03:31:20 -0000 Subject: [wp-trac] [WordPress Trac] #56721: get_page_by_title: duplicate SQL query In-Reply-To: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> References: <055.60427054f6a06508f64a4ee8f128ce98@wordpress.org> Message-ID: <070.b1e31042699d6718c89a5ec9f9bef094@wordpress.org> #56721: get_page_by_title: duplicate SQL query -------------------------------+---------------------------- Reporter: david.binda | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Posts, Post Types | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: performance -------------------------------+---------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"54377" 54377]: {{{ #!CommitTicketReference repository="" revision="54377" Posts, Post types: Prevent `get_page_by_title()` parsing query twice. In `get_page_by_title()` access the populated `WP_Query::posts` property directly rather than via the `WP_Query::get_posts()` method. This removes unnecessary reprocessing of the query. Follow up to [54234]. Props david.binda, mukesh27, spacedmonkey. Fixes #56721. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 03:45:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 03:45:53 -0000 Subject: [wp-trac] [WordPress Trac] #18449: List Table Factory Needs to be Pluggable In-Reply-To: <055.76bb085c058347152dec82cf796fbed1@wordpress.org> References: <055.76bb085c058347152dec82cf796fbed1@wordpress.org> Message-ID: <070.f1974ad9d7f7fc3e511b95aacbf203f6@wordpress.org> #18449: List Table Factory Needs to be Pluggable -------------------------------------------------+------------------------- Reporter: miqrogroove | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Administration | Version: 3.1 Severity: normal | Resolution: fixed Keywords: has-patch needs-dev-note add-to- | Focuses: field-guide | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"54378" 54378]: {{{ #!CommitTicketReference repository="" revision="54378" Administration: Remove private delegation from list tables. Remove the private delegation from the following classes and function: * `WP_List_Table` * `WP_Application_Passwords_List_Table` * `WP_Comments_List_Table` * `WP_Links_List_Table` * `WP_Media_List_Table` * `WP_MS_Sites_List_Table` * `WP_MS_Themes_List_Table` * `WP_MS_Users_List_Table` * `WP_Plugin_Install_List_Table` * `WP_Plugins_List_Table` * `WP_Post_Comments_List_Table` * `WP_Posts_List_Table` * `WP_Terms_List_Table` * `WP_Theme_Install_List_Table` * `WP_Themes_List_Table` * `WP_Users_List_Table` * `_get_list_table()` This change is to reflect the reality that list tables are very, very, very widely used by extenders and backward compatibility therefore needs to be maintained. Introduces the filter `wp_list_table_class_name` within `_get_list_table()` to allow extenders to modify the list table returned for custom screens. Props audrasjb, birgire, costdev, desrosj, faison, johnbillion, jrbeilke, kurtpayne, milana_cap, miqrogroove, nacin, peterwilsoncc, scribu, sergeybiryukov, sirzooro, westonruter, wonderboymusic. Fixes #18449. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 03:53:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 03:53:18 -0000 Subject: [wp-trac] [WordPress Trac] #56496: Twenty Twenty-Two: Update comment block markup In-Reply-To: <052.0de4b38c507c5e0ca5f9b4c24e1b9b2b@wordpress.org> References: <052.0de4b38c507c5e0ca5f9b4c24e1b9b2b@wordpress.org> Message-ID: <067.cb6aef0b7326ff48391f735990ea744e@wordpress.org> #56496: Twenty Twenty-Two: Update comment block markup ---------------------------+----------------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+----------------------------- Comment (by poena): With the old comments block, the heading order on single posts is incorrect. tTis makes it more difficult to navigate using headings and to determine which content on the page that is most important, and to determine the context of the comments area. This is a minor issue. With the new comments block, that heading level can be adjusted in the block settings, which resolves the heading order. ---- I would prefer that too. I am concerned that this type of workaround in the theme sets a precedence for how other themes should handle upgrades. But I don't understand how it would work when a user updates the theme, but does not update WordPress. Unless the suggested solution is to update the block in minor releases of older WordPress versions. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 03:57:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 03:57:45 -0000 Subject: [wp-trac] [WordPress Trac] #55937: Salting functions: translate the phrase `put your unique phrase here`. In-Reply-To: <057.f77dd14a7299d5b52d7c0f910faeb01b@wordpress.org> References: <057.f77dd14a7299d5b52d7c0f910faeb01b@wordpress.org> Message-ID: <072.a3e4a5bb5a716f7a1217b5eca36c0bda@wordpress.org> #55937: Salting functions: translate the phrase `put your unique phrase here`. ---------------------------+----------------------- Reporter: peterwilsoncc | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Security | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ---------------------------+----------------------- Changes (by peterwilsoncc): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54379" 54379]: {{{ #!CommitTicketReference repository="" revision="54379" Security: Additional translations of salt default phrase. Translate the default salt value "put your unique phrase here" in additional locations in which it is used. This further ensures that the default phrase is considered an error in non-english translations of `wp- config.php`. Follow-up to [54249]. Props peterwilsoncc, audrasjb, JeffPaul. Fixes #55937. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 03:58:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 03:58:47 -0000 Subject: [wp-trac] [WordPress Trac] #56496: Twenty Twenty-Two: Update comment block markup In-Reply-To: <052.0de4b38c507c5e0ca5f9b4c24e1b9b2b@wordpress.org> References: <052.0de4b38c507c5e0ca5f9b4c24e1b9b2b@wordpress.org> Message-ID: <067.aec29b4adc18bf1ad4cad200e92f3244@wordpress.org> #56496: Twenty Twenty-Two: Update comment block markup ---------------------------+----------------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+----------------------------- Comment (by poena): More context and pull request can be found here https://core.trac.wordpress.org/ticket/55172 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 04:27:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 04:27:50 -0000 Subject: [wp-trac] [WordPress Trac] #55929: `get_block_file_template()` incorrectly documented In-Reply-To: <057.9a4c2aa9999019443fbfccf334522894@wordpress.org> References: <057.9a4c2aa9999019443fbfccf334522894@wordpress.org> Message-ID: <072.8f75e083aa78557c6a453a2541fd0f44@wordpress.org> #55929: `get_block_file_template()` incorrectly documented ------------------------------+---------------------------- Reporter: peterwilsoncc | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: docs ------------------------------+---------------------------- Changes (by peterwilsoncc): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"54380" 54380]: {{{ #!CommitTicketReference repository="" revision="54380" Docs: Correct docblocks for `get_block_file_template()`. This corrects the docblock for `get_block_file_template()` and the filters it contains: `pre_get_block_file_template` and `get_block_file_template`. Prior to this change they were incorrectly documented with the docblocks for `get_block_template()` and its associated filters. Props felipeelia. Fixes #55929. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 05:28:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 05:28:50 -0000 Subject: [wp-trac] [WordPress Trac] #56725: WordPress setup on local - "npm run env:install" not working on windows Message-ID: <055.1f526c3f556e03779b42bfa00f46b5e3@wordpress.org> #56725: WordPress setup on local - "npm run env:install" not working on windows ------------------------------+----------------------------- Reporter: ashokrd2013 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: trunk Severity: normal | Keywords: Focuses: | ------------------------------+----------------------------- **Platform** - Windows 10 OS - Docker - Node & NPM **Steps to reproduce:** 1. Cloned WP develop repo using git clone https://github.com/WordPress /wordpress-develop.git & followed README 2. Navigate to the cloned directory - {{{cd wp-develop}}} 3. Installed npm dependencies for the project - {{{npm install}}} 4. Executed other commands - {{{npm run build:dev}}} & {{{npm run env:start}}} 5. While running the - {{{npm run env:install}}} gives me an error that WP_CLI can't create a config file at the root. I looked out for a solution - finding one reply regarding the permission issue seems to be convincing, however, doesn't give any solution/steps to fix it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 05:39:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 05:39:41 -0000 Subject: [wp-trac] [WordPress Trac] #56725: WordPress setup on local - "npm run env:install" not working on windows In-Reply-To: <055.1f526c3f556e03779b42bfa00f46b5e3@wordpress.org> References: <055.1f526c3f556e03779b42bfa00f46b5e3@wordpress.org> Message-ID: <070.ecc9147c518ea355ad605329d2416974@wordpress.org> #56725: WordPress setup on local - "npm run env:install" not working on windows ------------------------------+------------------------------ Reporter: ashokrd2013 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: trunk Severity: major | Resolution: Keywords: | Focuses: ------------------------------+------------------------------ Changes (by ashokrd2013): * severity: normal => major -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 05:55:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 05:55:54 -0000 Subject: [wp-trac] [WordPress Trac] #56725: WordPress setup on local - "npm run env:install" not working on windows In-Reply-To: <055.1f526c3f556e03779b42bfa00f46b5e3@wordpress.org> References: <055.1f526c3f556e03779b42bfa00f46b5e3@wordpress.org> Message-ID: <070.d5c9064605968827c2147a59560e08f7@wordpress.org> #56725: WordPress setup on local - "npm run env:install" not working on windows ------------------------------+------------------------------ Reporter: ashokrd2013 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------+------------------------------ Changes (by mukesh27): * version: trunk => * severity: major => normal -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 06:37:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 06:37:42 -0000 Subject: [wp-trac] [WordPress Trac] #18909: Bundled jQuery UI should have CSS In-Reply-To: <049.6318b4a78c6f909fedd52090f9fd61bc@wordpress.org> References: <049.6318b4a78c6f909fedd52090f9fd61bc@wordpress.org> Message-ID: <064.a3c7561d0ee0dfbf227ec38143dfb633@wordpress.org> #18909: Bundled jQuery UI should have CSS --------------------------------+----------------------------- Reporter: helen | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: External Libraries | Version: 3.3 Severity: normal | Resolution: Keywords: needs-patch close | Focuses: ui --------------------------------+----------------------------- Comment (by ttodua): Of course, leaving the issue open for 11 years, the ship would have sailed and would have eventually sunk already. it was needed years ago, when it was time for it. (however, if WP still retains the same jQuery bundles, then it will be still needed as much as people use jQuery) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 06:42:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 06:42:23 -0000 Subject: [wp-trac] [WordPress Trac] #54308: Customizer: Can't crop header images In-Reply-To: <053.93135bef82988faf10055b55bf8aa4e7@wordpress.org> References: <053.93135bef82988faf10055b55bf8aa4e7@wordpress.org> Message-ID: <068.de7f6b9283679c7dd11eab6711cafa95@wordpress.org> #54308: Customizer: Can't crop header images -------------------------------------------------+------------------------- Reporter: alshakero | Owner: alshakero Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch changes-requested dev- | Focuses: ui, feedback 2nd-opinion | javascript -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch needs-testing => has-patch changes-requested dev- feedback 2nd-opinion Comment: Hello, It looks like this PR fixes the issue directly on [https://plugins.jquery.com/imgareaselect/ imgareaselect] which is a third party library. That's why unit tests are failing there. The patch should either be reported to be fixed upstream, or, if possible, we could patch the issue on WordPress own files, with a dedicated JS file that override `imgareaselect`'s settings. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 06:57:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 06:57:28 -0000 Subject: [wp-trac] [WordPress Trac] #56725: WordPress setup on local - "npm run env:install" not working on windows In-Reply-To: <055.1f526c3f556e03779b42bfa00f46b5e3@wordpress.org> References: <055.1f526c3f556e03779b42bfa00f46b5e3@wordpress.org> Message-ID: <070.11eb0ebf06222176b82825c1b66a1c7f@wordpress.org> #56725: WordPress setup on local - "npm run env:install" not working on windows ------------------------------+------------------------------ Reporter: ashokrd2013 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------+------------------------------ Comment (by ashokrd2013): More details of the error: **Execution of the command** > **npm run env:install** > WordPress at 6.1.0 env:install D:\wamp64\www\wordpress-develop > node ./tools/local-env/scripts/install.js Creating wordpress-develop_cli_run ... done Success: Generated 'wp-config.php' file. Creating wordpress-develop_cli_run ... done Success: Updated the constant 'WP_DEBUG' in the 'wp-config.php' file with the raw value 'true'. Creating wordpress-develop_cli_run ... done Success: Added the constant 'WP_DEBUG_LOG' to the 'wp-config.php' file with the raw value 'true'. Creating wordpress-develop_cli_run ... done Success: Added the constant 'WP_DEBUG_DISPLAY' to the 'wp-config.php' file with the raw value 'true'. Creating wordpress-develop_cli_run ... done Success: Added the constant 'SCRIPT_DEBUG' to the 'wp-config.php' file with the raw value 'true'. Creating wordpress-develop_cli_run ... done Success: Added the constant 'WP_ENVIRONMENT_TYPE' to the 'wp-config.php' file with the value 'local'. Cloning into 'tests/phpunit/data/plugins/wordpress-importer'... Creating wordpress-develop_cli_run ... done Warning: file_get_contents(/var/www/src/wp-config.php): failed to open stream: No such file or directory in phar:///usr/local/bin/wp/vendor/wp- cli/wp-cli/php/WP_CLI/Runner.php on line 654 Error: Strange wp-config.php file: wp-settings.php is not loaded directly. ERROR: 1 (node:10148) UnhandledPromiseRejectionWarning: Error: Command failed: docker-compose run --rm cli db reset --yes at checkExecSyncError (child_process.js:790:11) at execSync (child_process.js:863:15) at wp_cli (D:\wamp64\www\wordpress-develop\tools\local- env\scripts\install.js:48:2) at D:\wamp64\www\wordpress-develop\tools\local- env\scripts\install.js:38:3 at processTicksAndRejections (internal/process/task_queues.js:95:5) (Use `node --trace-warnings ...` to show where the warning was created) (node:10148) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) (node:10148) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 06:58:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 06:58:10 -0000 Subject: [wp-trac] [WordPress Trac] #56725: WordPress setup on local - "npm run env:install" not working on windows In-Reply-To: <055.1f526c3f556e03779b42bfa00f46b5e3@wordpress.org> References: <055.1f526c3f556e03779b42bfa00f46b5e3@wordpress.org> Message-ID: <070.ce3d7f85142b2c4985519b73c361b3a0@wordpress.org> #56725: WordPress setup on local - "npm run env:install" not working on windows ------------------------------+------------------------------ Reporter: ashokrd2013 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------+------------------------------ Changes (by ashokrd2013): * Attachment "Screenshot_21.png" added. Error description -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 4 07:00:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Oct 2022 07:00:09 -0000 Subject: [wp-trac] [WordPress Trac] #56726: Editor can't save }}} You'd expect this to output as-is in the page, but since it's run through `wptexturize()` by both `render_block_core_post_content()` and `get_the_block_template_html()`, the `&&` ends up encoded as `&&` and the Javascript fails. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 17:39:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 17:39:34 -0000 Subject: [wp-trac] [WordPress Trac] #56496: Twenty Twenty-Two: Update comment block markup In-Reply-To: <052.0de4b38c507c5e0ca5f9b4c24e1b9b2b@wordpress.org> References: <052.0de4b38c507c5e0ca5f9b4c24e1b9b2b@wordpress.org> Message-ID: <067.a1b12b2875a08782a13579d847f8b7f3@wordpress.org> #56496: Twenty Twenty-Two: Update comment block markup -------------------------------------+---------------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: accessibility -------------------------------------+---------------------------- Changes (by ryokuhi): * keywords: has-patch => has-patch needs-refresh * focuses: => accessibility * milestone: Future Release => 6.1.1 Comment: From #56798: > From [https://github.com/WordPress/wordpress-develop/pull/3136 wordpress-develop pull request 3136]: > > The Post Comments block uses an h3 heading on it, this causes a11y issues, ''as discussed in [https://github.com/WordPress/gutenberg/issues/43203 Gutenberg issue 43203] (and previously in #55172)'', on the templates where it's inserted, since there are no existing h2 in them. The new Comments block doesn't have the same problem because it allows you to change the heading as you need, but it's only available with Gutenberg or WP >= 6.1. To solve this issue, we are doing the following: > > * We are creating a hidden block pattern that inserts either of the blocks depending on if the new block is registered and the WP version is >= 6.1 > > * For users that will get the deprecated version of the block, we are using the `render_block` hook to swap the h3 with an h2, and solve the a11y for them > > * Users that will get the newer version of the block, will have the h2 instead. > > To test this: > > * Run this branch, check a page with comments on it, you should be seeing the headings using h2. On the editor, you should be seeing the new Comments block (there is no deprecation message present). You may need to tweak this line in `hidden-comments.php`, since this branch is still not a 6.1 version of WP: > > {{{ > > if ( > > WP_Block_Type_Registry::get_instance()->is_registered( 'core/comments' ) && > > version_compare( $GLOBALS['wp_version'], '6.1', '>=' ) > > ) { > > }}} > > * Run the code from this branch on a 6.0 environment, you should be seeing the old block, with the deprecation notice in the editor. In the frontend, you should still see the headings on the comments block using h2, instead of h3. > > Aside from a11y, note that this PR also improves User Experience of the TT2 theme: Users with WP >= 6.1 will get the Comments block in editable mode automatically, rather than seeing the legacy mode and the upgrade notice. > This was raised in #55172, but deemed not a blocker to adding the Accessibility Ready tag. Props to @poena when merged for raising this issue. After discussing ticket #56798 during the accessibility team's weekly bug scrub, as suggested by @poena, we decided to close that ticket in favor of this one. Props to @desrosj for reporting this discussion from the wordpress-develop Pull Request to Trac. We also decided to move this ticket to the 6.1.1 milestone, to add the accessibility focus (as this is actually an accessibility issue), and to ask for a patch refresh that takes into consideration the above. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 17:41:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 17:41:04 -0000 Subject: [wp-trac] [WordPress Trac] #56819: inline-edit-post.js looks up page author name incorrectly when author no longer has edit capabilities In-Reply-To: <054.98c61a8262d32d84bad9c140d5d79615@wordpress.org> References: <054.98c61a8262d32d84bad9c140d5d79615@wordpress.org> Message-ID: <069.49551e56400145cae37d5a9c46a6762e@wordpress.org> #56819: inline-edit-post.js looks up page author name incorrectly when author no longer has edit capabilities -----------------------------+--------------------------------------------- Reporter: OllieJones | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, javascript, administration needs-testing | -----------------------------+--------------------------------------------- Changes (by azaozz): * keywords: has-patch => has-patch needs-testing * milestone: Future Release => 6.2 Comment: Patch makes sense but needs testing with custom post types. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 17:42:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 17:42:35 -0000 Subject: [wp-trac] [WordPress Trac] #56816: Correct references to npm and Node.js In-Reply-To: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> References: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> Message-ID: <066.a1296e6edc1bd6ea3c5a1c5a38125271@wordpress.org> #56816: Correct references to npm and Node.js --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: docs --------------------------------------+--------------------- Comment (by aleksganev): Heyo, I replaced all the wrong references of npm and Node.js with the correct ones. Hope all is good. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 17:45:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 17:45:39 -0000 Subject: [wp-trac] [WordPress Trac] #56798: Twenty Twenty-Two: Post comments block accessibility fixes In-Reply-To: <051.8518aba3a4d41d63647553e8b3309b73@wordpress.org> References: <051.8518aba3a4d41d63647553e8b3309b73@wordpress.org> Message-ID: <066.ea93ab2a0c0e74892b0ec79ae1288e90@wordpress.org> #56798: Twenty Twenty-Two: Post comments block accessibility fixes ---------------------------+---------------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: accessibility ---------------------------+---------------------------- Changes (by ryokuhi): * status: new => closed * resolution: => duplicate * milestone: 6.1.1 => Comment: This ticket was discussed today during the accessibility team's weekly bug scrub. As suggested by @poena, we decided to close this ticket in favor of #56496. The comment reported by @desrosj in this ticket description from the wordpress-develop Pull Request was also moved to ticket #56496, to keep all the discussion in a single place. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 18:05:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 18:05:57 -0000 Subject: [wp-trac] [WordPress Trac] #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page Message-ID: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page --------------------------+----------------------------- Reporter: nlpro | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: I18N | Version: 6.0.2 Severity: normal | Keywords: Focuses: ui | --------------------------+----------------------------- Prerequisites: - The initial language used is “English (United States)”. - Make sure to have other language(s) pre installed (like Nederlands (=Dutch)). To reproduce the issue follow the steps below (**first scenario**): 1. Navigate to the site admin login page (wp-login.php or wp-admin). 2. Click on the “Lost your password?” link. 3. Enter an existing username or it’s associated email address and click on the “Get New Password” button. 4. Now log into the email account of that user, open the “Password Reset” email received and click on the confirmation link. 5. Notice the “Generate Password” and “Save Password” buttons which are correctly aligned horizontally. 6. Select a different language, like “Nederlands” at the bottom of the page and click on the Change button. 7. Notice the 2 earlier mentioned buttons are now stacked or aligned vertically. Yuk, makes me want to puke! (This ticket is not finished yet. Wait for the **2nd scenario**…) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 18:11:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 18:11:33 -0000 Subject: [wp-trac] [WordPress Trac] #56699: Remove IE specific checks from default themes In-Reply-To: <051.07ba5d3a1dfd8da569706e87c9bef7e3@wordpress.org> References: <051.07ba5d3a1dfd8da569706e87c9bef7e3@wordpress.org> Message-ID: <066.8e9f91761f075107da19c1b80b899a13@wordpress.org> #56699: Remove IE specific checks from default themes ---------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+--------------------- Comment (by neychok): Hey guys, I checked the TwentyEleven theme and we don't actually enqueue any IE-related assets (or at least I didn't see such) rather we directly add it with a script tag in the header. I wasn't sure what to do in this case so completely removed all IE-related code from the theme in the PR I just submitted. I am willing to work on this task but I am not entirely sure how to proceed. Should I: - Completely remove all IE code - Just change `enqueue_` to `register_` where possible and leave the rest, like in the case with TwentyEleven - Remove all IE code except where we have `enqueue_` that's going to be changed to `register_` instead. The PR is just an example. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 18:37:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 18:37:48 -0000 Subject: [wp-trac] [WordPress Trac] #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page In-Reply-To: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> References: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> Message-ID: <064.c654274f5d6d560483f77dac3d37ec08@wordpress.org> #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page --------------------------+------------------------------ Reporter: nlpro | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: I18N | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: ui --------------------------+------------------------------ Changes (by nlpro): * Attachment "706036C8-6147-4798-A36D-588406BB5906.jpeg" added. Default Reset Password page in English (United States) language. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 18:42:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 18:42:15 -0000 Subject: [wp-trac] [WordPress Trac] #31914: Remove static variable for global_terms_enable to allow for unit tests In-Reply-To: <054.6f25c68de4b92f8e46670f709a3964d4@wordpress.org> References: <054.6f25c68de4b92f8e46670f709a3964d4@wordpress.org> Message-ID: <069.abe3b78c34822f00f76e9a6116f3e749@wordpress.org> #31914: Remove static variable for global_terms_enable to allow for unit tests --------------------------+------------------------- Reporter: jeremyfelt | Owner: jeremyfelt Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Taxonomy | Version: 3.0 Severity: normal | Resolution: wontfix Keywords: has-patch | Focuses: multisite --------------------------+------------------------- Changes (by desrosj): * keywords: has-patch dev-feedback => has-patch * status: assigned => closed * resolution: => wontfix Comment: Global terms has officially been deprecated and no-opped in [54240]. As I understand it, this is a [https://core.trac.wordpress.org/browser/tags/6.0/src/wp- includes/functions.php#L6226 suggestion to modify the contents] of `global_terms_enabled()`, so I'm closing this as a won't fix. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 18:43:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 18:43:26 -0000 Subject: [wp-trac] [WordPress Trac] #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page In-Reply-To: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> References: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> Message-ID: <064.67daf1c78ad92304a74f30bf93a85032@wordpress.org> #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page --------------------------+------------------------------ Reporter: nlpro | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: I18N | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: ui --------------------------+------------------------------ Changes (by nlpro): * Attachment "50D254EA-45B8-43BB-830E-3F126E993496.jpeg" added. After selecting language “Nederlands”. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 18:45:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 18:45:00 -0000 Subject: [wp-trac] [WordPress Trac] #55979: wp_sitecategories does not account for different taxonomy In-Reply-To: <052.4a5934045f8291a231f7af541409483e@wordpress.org> References: <052.4a5934045f8291a231f7af541409483e@wordpress.org> Message-ID: <067.374babe626c85243ad57b9ab1b7f9d1c@wordpress.org> #55979: wp_sitecategories does not account for different taxonomy --------------------------------+------------------------ Reporter: axelseaa | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Networks and Sites | Version: 4.2 Severity: major | Resolution: wontfix Keywords: reporter-feedback | Focuses: multisite --------------------------------+------------------------ Changes (by desrosj): * keywords: reporter-feedback close => reporter-feedback * status: new => closed * resolution: => wontfix * milestone: Awaiting Review => Comment: Global terms is now officially deprecated and the functions have been no- opped as of [54240]. Closing this as a `wontfix`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 18:46:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 18:46:55 -0000 Subject: [wp-trac] [WordPress Trac] #46297: Unable to edit specific terms : rest_cannot_assign_term OR 403 In-Reply-To: <049.2c16ca488f09279f482af9c6a35d7dfb@wordpress.org> References: <049.2c16ca488f09279f482af9c6a35d7dfb@wordpress.org> Message-ID: <064.286a36caa30c455fbd2a5b92a5adb1cd@wordpress.org> #46297: Unable to edit specific terms : rest_cannot_assign_term OR 403 --------------------------+---------------------------------- Reporter: enps5 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Taxonomy | Version: 4.1 Severity: normal | Resolution: wontfix Keywords: | Focuses: multisite, rest-api --------------------------+---------------------------------- Changes (by desrosj): * keywords: close => * status: new => closed * resolution: => wontfix * milestone: Awaiting Review => Comment: Global terms is officially deprecated and no-opped in [54240]. Closing this as `wontfix`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 18:47:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 18:47:54 -0000 Subject: [wp-trac] [WordPress Trac] #12756: WPMU does not handle files with two or more dots in the filename In-Reply-To: <050.5eb44172748c255a74dbdd6337384940@wordpress.org> References: <050.5eb44172748c255a74dbdd6337384940@wordpress.org> Message-ID: <065.6cdf191f68ba1dbca4f56c6ae6e6ad5c@wordpress.org> #12756: WPMU does not handle files with two or more dots in the filename ------------------------------------------+----------------------------- Reporter: Namely | Owner: wpmuguru Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future Release Component: Upload | Version: 2.9.2 Severity: minor | Resolution: Keywords: has-patch dev-feedback close | Focuses: multisite ------------------------------------------+----------------------------- Changes (by desrosj): * keywords: has-patch dev-feedback => has-patch dev-feedback close Comment: Adding a `close` suggestion. Will circle back to close unless someone is able to document the current state of this report. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 18:50:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 18:50:01 -0000 Subject: [wp-trac] [WordPress Trac] #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page In-Reply-To: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> References: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> Message-ID: <064.3c476e0b9895a6915f6412c238d5976d@wordpress.org> #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page --------------------------+------------------------------ Reporter: nlpro | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: I18N | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: ui --------------------------+------------------------------ Comment (by nlpro): 2nd scenario: Simply choosing a smaller or bigger font size in the browser will very quickly result in the same vertically aligned buttons. This reproduces even in language “English (United States)”. End of description for this ticket. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 19:05:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 19:05:05 -0000 Subject: [wp-trac] [WordPress Trac] #49143: Deprecated constructor warning in Blogger Importer In-Reply-To: <050.466f0d39ed15b5d5c3a1e9f39fdcea95@wordpress.org> References: <050.466f0d39ed15b5d5c3a1e9f39fdcea95@wordpress.org> Message-ID: <065.69a757218caaabfa15baa056b02c950c@wordpress.org> #49143: Deprecated constructor warning in Blogger Importer -------------------------------------------------+------------------------- Reporter: leemon | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: | WordPress.org Component: Import | Version: 5.3.2 Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info | -------------------------------------------------+------------------------- Changes (by ironprogrammer): * keywords: => has-patch needs-testing has-testing-info Comment: I've submitted [https://github.com/WordPress/blogger-importer/pull/3 blogger-importer PR #3] to resolve this PHP 7 deprecation. (This repo is separate from `wordpress-develop` so does not appear in [#section-pr] above.) === Background - PHP 5 [https://www.php.net/manual/en/language.oop5.decon.php introduced the `__construct()` method], but continued to allow "old style" PHP 4 constructors. - PHP 7 [https://wiki.php.net/rfc/remove_php4_constructors began to emit `E_DEPRECATED` whenever a PHP 4 constructor was defined]. - PHP 8 stops emitting `E_DEPRECATED`, and the same named methods will not be recognized as constructors. == Testing Instructions === Steps to Test 1. Ensure site is running PHP 7, where this deprecation applies. 2. In `wp-config.php`, make sure that debugging is enabled (e.g. `define( 'WP_DEBUG', true );` and `define( 'WP_DEBUG_LOG', true );`). 3. Install and activate the [https://wordpress.org/plugins/blogger- importer/ Blogger Importer] plugin. 4. 🐞 After activation, note the deprecation logged to `wp- content/debug.log`. 5. Deactivate the plugin. 6. 🩹 Apply [https://github.com/WordPress/blogger-importer/pull/3.diff the patch]. Or as an alternative, you can replace the plugin's `blogger- importer.php` file with the one from the following zip: [https://github.com/ironprogrammer/blogger-importer/archive/refs/heads /same-name-class-constructor.zip same-name-class-constructor.zip] (this is the working branch for [https://github.com/WordPress/blogger- importer/pull/3 PR #3]). 7. Activate the updated plugin. 8. ✅ Note that the deprecation notice is no longer logged. === Expected Results - ✅ The deprecation notice is not logged after patching. ''(I'd like to give a hat tip to @SergeyBiryukov, @dd32, and @vishnugopal for [https://meta.trac.wordpress.org/ticket/5550#comment:4 moving the current importers into GitHub], which should help ease future maintenance efforts like this 🙌🏻)'' -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 19:18:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 19:18:01 -0000 Subject: [wp-trac] [WordPress Trac] #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page In-Reply-To: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> References: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> Message-ID: <064.8f90c738cdbe4c5e44e1b7d761aa43c5@wordpress.org> #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page --------------------------+------------------------------ Reporter: nlpro | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: I18N | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: ui --------------------------+------------------------------ Comment (by nlpro): IMHO the simplest solution is to change the long “Generate Password” label into a shorter “Generate”. We know we are on the “Reset Password” page, so why repeat the “Password” word ? The same applies for the “Save Password” button. Just using a “Generate” and “Save” button will probably go a long way in solving this issue. One complication. I noticed the “Generate Password” string is also used in the “Add New User” page. For the same reason we can also use the shorter “Generate” label there. This way the number of WordPress translatable strings remains unchanged. Interested in any other thoughts;-) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 19:48:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 19:48:41 -0000 Subject: [wp-trac] [WordPress Trac] #56828: Setting comment cookies for users without opt-in Message-ID: <059.8f740e93a47a9c56f5716dda44511a04@wordpress.org> #56828: Setting comment cookies for users without opt-in -----------------------------+----------------------------- Reporter: davidmsalisbury | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Comments | Version: 6.0.2 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- Wordpress is setting 3 cookies on users' browsers whenever they post a comment, whether they have opted in or not. This occurs whether the opt-in box (Save my name, email, and website in this browser for the next time I comment) is visible to the commenter and the commenter chooses not to check it, or even if the opt-in box has been disabled by the site admin (by removing the tick in the "Show comments cookies opt-in checkbox, allowing comment author cookies to be set" in the Discussion Settings). Upon clicking "Post Comment" the three cookies set are comment_author_xxxxxx, comment_author_email_xxxxxxx, and comment_author_url_xxxxxxx. This is an issue affecting GDPR compliance. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 19:56:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 19:56:56 -0000 Subject: [wp-trac] [WordPress Trac] #56828: Setting comment cookies for users without opt-in In-Reply-To: <059.8f740e93a47a9c56f5716dda44511a04@wordpress.org> References: <059.8f740e93a47a9c56f5716dda44511a04@wordpress.org> Message-ID: <074.7a575856471ae62ee80c6708f3b23e75@wordpress.org> #56828: Setting comment cookies for users without opt-in -----------------------------+------------------------ Reporter: davidmsalisbury | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: Privacy | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Changes (by jorbin): * status: new => closed * type: defect (bug) => feature request * component: Comments => Privacy * version: 6.0.2 => * milestone: Awaiting Review => * resolution: => duplicate Comment: Welcome to trac @davidmsalisbury. Cookie Consent management is being discussed in #52903. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 20:40:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 20:40:11 -0000 Subject: [wp-trac] [WordPress Trac] #56824: Accessibility image alt text empty & SVG missing title and description on wordpress dashboard In-Reply-To: <055.74ee180519091325d8907050de21947b@wordpress.org> References: <055.74ee180519091325d8907050de21947b@wordpress.org> Message-ID: <070.64b12187f74487e479ac04b7415477af@wordpress.org> #56824: Accessibility image alt text empty & SVG missing title and description on wordpress dashboard -------------------------------------+------------------------------ Reporter: viralsampat | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: close reporter-feedback | Focuses: accessibility -------------------------------------+------------------------------ Changes (by audrasjb): * keywords: => close reporter-feedback * version: 6.0.2 => * type: enhancement => defect (bug) Comment: Hello and thanks for the ticket :) Concerning the three images: 1. 6.0 illustration image doesn't need any alt text. It is hidden from assistive technologies using `aria-hidden`. 2. Same goes for the site health score circle. 3. Activity widget (comments): alt is empty, which is fine since it doesn't contain any relevant info. Adding an alt with info about the commenter would be redundant with the text displayed near the image. Everything look good to me at a glance :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 22:12:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 22:12:21 -0000 Subject: [wp-trac] [WordPress Trac] #56763: Disable spellcheck for all password fields for better privacy In-Reply-To: <051.9f9990e0309de952f0aea42841b5a744@wordpress.org> References: <051.9f9990e0309de952f0aea42841b5a744@wordpress.org> Message-ID: <066.27c94c34544a08698cc0bafee43503a6@wordpress.org> #56763: Disable spellcheck for all password fields for better privacy ------------------------------------+---------------------- Reporter: dziudek | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: privacy ------------------------------------+---------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 22:48:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 22:48:23 -0000 Subject: [wp-trac] [WordPress Trac] #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." In-Reply-To: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> References: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> Message-ID: <069.0558a123ef43c82fe8b659a936fc2c21@wordpress.org> #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." --------------------------+------------------------ Reporter: webtechIMT | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Taxonomy | Version: 5.6 Severity: critical | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Changes (by sabernhardt): * status: reopened => closed * resolution: => duplicate Comment: Duplicate of #46297. Re-closing as a duplicate. If you still have trouble with this, please use the support forum. https://wordpress.org/support/forum/wp-advanced/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 23:34:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 23:34:21 -0000 Subject: [wp-trac] [WordPress Trac] #56813: Heading Block Margin Issue In-Reply-To: <058.e4cdfd1b9a9f249021b1eba0644255ae@wordpress.org> References: <058.e4cdfd1b9a9f249021b1eba0644255ae@wordpress.org> Message-ID: <073.3ef9ae93265d4529bee01060a0004247@wordpress.org> #56813: Heading Block Margin Issue -------------------------------+------------------------------ Reporter: piyushpatel123 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.2 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Changes (by ironprogrammer): * keywords: => reporter-feedback Comment: Adding `reporter-feedback` per @poena's question, comment:2. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 23:42:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 23:42:46 -0000 Subject: [wp-trac] [WordPress Trac] #56781: Missing "Deactivated" filter at top of "All Sites" on multisite installation. In-Reply-To: <056.d7bebe0777adbe48fce4183630ab5edb@wordpress.org> References: <056.d7bebe0777adbe48fce4183630ab5edb@wordpress.org> Message-ID: <071.e610eeb99cdac7cfd7fc473f2879bc2d@wordpress.org> #56781: Missing "Deactivated" filter at top of "All Sites" on multisite installation. ----------------------------+-------------------------------------------- Reporter: richardkrone | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, administration, multisite ----------------------------+-------------------------------------------- Changes (by ironprogrammer): * type: defect (bug) => enhancement * component: Networks and Sites => Administration Comment: Thank you for this request, @richardkrone! Marking as `enhancement` to receive the correct attention. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 14 23:50:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 14 Oct 2022 23:50:14 -0000 Subject: [wp-trac] [WordPress Trac] #56773: WP-ADMIN CAN'T LOAD AFTER UPGRADE TO WP6 In-Reply-To: <049.037e4eb0ba6edd511eabaadac6d244d2@wordpress.org> References: <049.037e4eb0ba6edd511eabaadac6d244d2@wordpress.org> Message-ID: <064.068628a369736b59f7bd2aa84c4ec6d8@wordpress.org> #56773: WP-ADMIN CAN'T LOAD AFTER UPGRADE TO WP6 ----------------------------+------------------------------ Reporter: xr00t | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 6.0.2 Severity: critical | Resolution: invalid Keywords: | Focuses: ----------------------------+------------------------------ Changes (by ironprogrammer): * status: new => closed * focuses: administration => * resolution: => invalid Comment: Hi, @xr00t, welcome to WordPress Trac! I'm sorry you're having issues updating your website. Please note that Core Trac is used for enhancements and bug reports for the WordPress core software, not individual support issues or questions. Please check out the dedicated support forums for help with your site: https://wordpress.org/support/forums/. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 00:20:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 00:20:30 -0000 Subject: [wp-trac] [WordPress Trac] #56775: Can't copy table to Gutenberg WordPress table In-Reply-To: <054.a53d4dcfa87cb758ebc9587301412821@wordpress.org> References: <054.a53d4dcfa87cb758ebc9587301412821@wordpress.org> Message-ID: <069.594c5b54cf7603910a5694ac41a939d3@wordpress.org> #56775: Can't copy table to Gutenberg WordPress table -------------------------------+------------------------------ Reporter: programmin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.2 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by ironprogrammer): * keywords: => reporter-feedback * focuses: javascript => Comment: Hi, @programmin, welcome to Trac, and thank you for the report! To get eyes on this sooner, would you please file this report over in the Gutenberg editor issues tracker? It's located at https://github.com/WordPress/gutenberg/issues/new/choose. The form over there will ask for additional information regarding steps to reproduce this issue. This is really helpful as other contributors review this editor-related issue 🙌🏻. You can paste a link of this ticket URL into the description over in GitHub so everyone knows it's being tracked. ---- FWIW, I don't have LibreOffice, but using macOS Numbers I can paste a table into the editor (into an empty block insertion point). If LibreOffice Calc copies HTML to the pasteboard, then it would seem a valid use case to support LibreOffice as well. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 00:57:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 00:57:02 -0000 Subject: [wp-trac] [WordPress Trac] #56807: Delete existing attachment subsizes after WP_Customize_Manager tests In-Reply-To: <058.65c9d41e16f8e2c672b0eb679bdd0dbb@wordpress.org> References: <058.65c9d41e16f8e2c672b0eb679bdd0dbb@wordpress.org> Message-ID: <073.e725fd53e91d4e6f63e1e698d11b1d37@wordpress.org> #56807: Delete existing attachment subsizes after WP_Customize_Manager tests --------------------------------------+----------------------------- Reporter: ironprogrammer | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Comment (by SergeyBiryukov): I was curious why I didn't see the leftover files when running the tests on Windows. It looks like this has to do with one of the test failures mentioned in #50664: {{{ 1) Tests_WP_Customize_Manager::test_import_theme_starter_content Expected reuse of non-auto-draft attachment. Failed asserting that an array contains 949. S:\home\wordpress.test\develop\tests\phpunit\tests\customize\manager.php:691 }}} Upon some investigation, the file is saved with an incorrect path on Windows: {{{ S:\home\wordpress.test\develop-dynamic-properties/src/wp- content/uploads/S:homewordpress.testdevelop-dynamic- propertiestestsphpunitincludes/../data/images/canola.jpg }}} so it's not detected as an existing attachment. The path probably needs to be normalized at some point. This should be further explored in #50664. I was able to reproduce the leftover files when running the tests under WSL. The PR works as expected. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 01:06:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 01:06:57 -0000 Subject: [wp-trac] [WordPress Trac] #56807: Delete existing attachment subsizes after WP_Customize_Manager tests In-Reply-To: <058.65c9d41e16f8e2c672b0eb679bdd0dbb@wordpress.org> References: <058.65c9d41e16f8e2c672b0eb679bdd0dbb@wordpress.org> Message-ID: <073.c5beddd8d50addd470c047177666532e@wordpress.org> #56807: Delete existing attachment subsizes after WP_Customize_Manager tests --------------------------------------+----------------------------- Reporter: ironprogrammer | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Comment (by SergeyBiryukov): Replying to [comment:10 SergeyBiryukov]: > I was curious why I didn't see the leftover files when running the tests on Windows. > > It looks like this has to do with one of the test failures mentioned in #50664: > {{{ > 1) Tests_WP_Customize_Manager::test_import_theme_starter_content > Expected reuse of non-auto-draft attachment. > Failed asserting that an array contains 949. > > S:\home\wordpress.test\develop\tests\phpunit\tests\customize\manager.php:691 It appears that the PR actually resolves this test failure too. If the existing attachment is under `wp-content/uploads/` (as it should be), the file path is correct, and the attachment is detected and reused as expected. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 01:08:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 01:08:47 -0000 Subject: [wp-trac] [WordPress Trac] #56807: Delete existing attachment subsizes after WP_Customize_Manager tests In-Reply-To: <058.65c9d41e16f8e2c672b0eb679bdd0dbb@wordpress.org> References: <058.65c9d41e16f8e2c672b0eb679bdd0dbb@wordpress.org> Message-ID: <073.757c6d503075374feb6dc192e2d27b17@wordpress.org> #56807: Delete existing attachment subsizes after WP_Customize_Manager tests --------------------------------------+----------------------------- Reporter: ironprogrammer | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Changes (by SergeyBiryukov): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"54519" 54519]: {{{ #!CommitTicketReference repository="" revision="54519" Tests: Delete leftover image sub-sizes after `WP_Customize_Manager` tests. After running `phpunit --filter test_import_theme_starter_content`, the following files were generated and left in place in the version-controlled `DIR_TESTDATA` directory, resulting in a dirty working copy of the project: {{{ tests/phpunit/data/images/canola-150x150.jpg tests/phpunit/data/images/canola-300x225.jpg }}} In the test, `canola.jpg` is mocked as an **existing attachment**. When the test invokes `WP_Customize_Manager::import_theme_starter_content()`, existing attachments are passed directly to `wp_generate_attachment_metadata()`, which does not make a copy of the file, and `wp_create_image_subsizes()` creates the above referenced files in the original image's location. By contrast, `waffles.jpg`, also used in the test, is **not** set as an existing attachment, and in `import_theme_starter_content()` is passed to `media_handle_sideload()`, which makes a **copy** of the file in the `wp- content/uploads/` directory, and then calls `wp_create_image_subsizes()` against the new file. The resulting sub-sizes are generated in that location, and are cleaned up during `tear_down()`. The test's `tear_down()` uses `remove_added_uploads()`, which only clears items created in `wp-content/uploads/` (i.e. `waffles*.jpg`), but not the files in the `DIR_TESTDATA` directory (`canola-*.jpg`). This commit addresses the issue by creating a copy of the file in uploads. This better matches the intention of the test, as existing attachments will most likely be located in uploads and not in an arbitrary path like the test data directory. Follow-up to [39276], [39346], [39411], [40142], [54424], [54425]. Props ironprogrammer, audrasjb, boniu91, dariak, SergeyBiryukov. Fixes #56807. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 01:13:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 01:13:03 -0000 Subject: [wp-trac] [WordPress Trac] #50664: Theme test failures on Windows In-Reply-To: <058.7f9eab860b1691fd3b2c3597b9c4bb71@wordpress.org> References: <058.7f9eab860b1691fd3b2c3597b9c4bb71@wordpress.org> Message-ID: <073.214fa35e750f770388c9a181d7d4639d@wordpress.org> #50664: Theme test failures on Windows ----------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Themes | Version: Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+----------------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => Future Release Comment: Replying to [ticket:50664 SergeyBiryukov]: > {{{ > 1) Tests_WP_Customize_Manager::test_import_theme_starter_content > Expected reuse of non-auto-draft attachment. > Failed asserting that an array contains 949. > > S:\home\wordpress.test\develop\tests\phpunit\tests\customize\manager.php:691 > }}} This appears to be resolved in [54519] / #56807, see comment:11:ticket:56807. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 02:12:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 02:12:01 -0000 Subject: [wp-trac] [WordPress Trac] #56775: Can't copy table to Gutenberg WordPress table In-Reply-To: <054.a53d4dcfa87cb758ebc9587301412821@wordpress.org> References: <054.a53d4dcfa87cb758ebc9587301412821@wordpress.org> Message-ID: <069.64b14776fb757b1d696114fc8f2f4a09@wordpress.org> #56775: Can't copy table to Gutenberg WordPress table -------------------------------+------------------------------ Reporter: programmin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.2 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by programmin): I can also paste in a table that way - if I don't insert a table block and then try to paste in it. I initially thought that would be how one would do it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 08:58:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 08:58:52 -0000 Subject: [wp-trac] [WordPress Trac] #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page In-Reply-To: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> References: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> Message-ID: <064.1d89fd58a4fe44d84923c253993287b2@wordpress.org> #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page --------------------------+------------------------------ Reporter: nlpro | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: I18N | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: ui --------------------------+------------------------------ Comment (by nlpro): Correction 2nd scenario: Simply making use of the browser zoom in/out functionality will very quickly result in the same vertically aligned buttons. This reproduces even in language “English (United States)”. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 10:51:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 10:51:14 -0000 Subject: [wp-trac] [WordPress Trac] #55996: the get_the_block_template_html call all the same functions as the the_conent filter so they are run twice In-Reply-To: <051.cff16e4a6bc25786c59a0e8062043f85@wordpress.org> References: <051.cff16e4a6bc25786c59a0e8062043f85@wordpress.org> Message-ID: <066.14ddf10ba0c87bcc87f975a655e68498@wordpress.org> #55996: the get_the_block_template_html call all the same functions as the the_conent filter so they are run twice ------------------------------------------+------------------------------ Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: performance ------------------------------------------+------------------------------ Comment (by manfcarlo): A patch for this is available at https://github.com/WordPress/gutenberg/pull/44995 @ocean90 If you have time to test, I would be interested to know if the patch fixes #56295. @needle I tested your example and it appears that `&&` is produced even when `wptexturize` is only applied once. While I agree that it is unwanted, it looks to be outside the scope of this ticket. Perhaps you should open another ticket and/or search to see if it's already been reported in another ticket. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 12:05:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 12:05:42 -0000 Subject: [wp-trac] [WordPress Trac] #56819: inline-edit-post.js looks up page author name incorrectly when author no longer has edit capabilities In-Reply-To: <054.98c61a8262d32d84bad9c140d5d79615@wordpress.org> References: <054.98c61a8262d32d84bad9c140d5d79615@wordpress.org> Message-ID: <069.1752603aee846a59552acee7fe13d954@wordpress.org> #56819: inline-edit-post.js looks up page author name incorrectly when author no longer has edit capabilities -----------------------------+--------------------------------------------- Reporter: OllieJones | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, javascript, administration needs-testing | -----------------------------+--------------------------------------------- Comment (by OllieJones): I just checked the WooCommerce All Products panel in devtools. It has the same HTML structure, in this respect, as the All Posts and All Pages panels. The posts (whether they are user-visible posts, pages, or in this case products) are shown like this. {{{ WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 12:45:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 12:45:43 -0000 Subject: [wp-trac] [WordPress Trac] #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp-includes/blocks/avatar.php' Message-ID: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp- includes/blocks/avatar.php' ------------------------------+----------------------------- Reporter: hztyfoon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: coding-standards | ------------------------------+----------------------------- In 'src/wp-includes/blocks/avatar.php' file line number `103` the 'get_author_posts_url' method should be escaped. related ticket: #56674 / [54344] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 12:54:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 12:54:54 -0000 Subject: [wp-trac] [WordPress Trac] #56830: jQuery Migrate deprecation in wpdialog Message-ID: <052.2061878c33cf1c15a5b4c3114b65bc0c@wordpress.org> #56830: jQuery Migrate deprecation in wpdialog ----------------------------+---------------------------------------- Reporter: TobiasBg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Administration | Version: Severity: normal | Keywords: needs-patch good-first-bug Focuses: javascript | ----------------------------+---------------------------------------- (Follow up to #51812.) WP Core's customized jQuery UI widget `wpdialog` produces a jQuery Migrate deprecation notice in the browser's console, about the `focus()` shorthand being decprecated. `/src/js/_enqueues/lib/dialog.js`'s [https://github.com/WordPress /wordpress-develop/blob/trunk/src/js/_enqueues/lib/dialog.js#L20 line] {{{#!js this.element.focus(); }}} should be changed to {{{#!js this.element._trigger('focus'); }}} from what I can see. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 13:34:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 13:34:49 -0000 Subject: [wp-trac] [WordPress Trac] #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp-includes/blocks/avatar.php' In-Reply-To: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> References: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> Message-ID: <067.d8e3860354207a305a9d4c23c7daec3f@wordpress.org> #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp- includes/blocks/avatar.php' --------------------------+------------------------------- Reporter: hztyfoon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards --------------------------+------------------------------- Comment (by robinwpdeveloper): Excited to share that we have arranged a local meetup (Dhaka WordPress Meetup) on **''How to Get Started with Core Contribution''** and created this ticket with PR in a live session 😊🎉 🇧🇩 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 16:06:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 16:06:37 -0000 Subject: [wp-trac] [WordPress Trac] #55996: the get_the_block_template_html call all the same functions as the the_conent filter so they are run twice In-Reply-To: <051.cff16e4a6bc25786c59a0e8062043f85@wordpress.org> References: <051.cff16e4a6bc25786c59a0e8062043f85@wordpress.org> Message-ID: <066.1480f4246b62f66ce4032e66da061d58@wordpress.org> #55996: the get_the_block_template_html call all the same functions as the the_conent filter so they are run twice ------------------------------------------+------------------------------ Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: performance ------------------------------------------+------------------------------ Comment (by needle): Replying to [comment:8 manfcarlo]: > A patch for this is available at https://github.com/WordPress/gutenberg/pull/44995 @manfcarlo Unfortunately your patch doesn't solve the first issue I mentioned, so let me restate the problem... Say you want to add something to the rendered post content that ''must not'' be run through the core default filters. In a plugin, this is traditionally done by hooking in to `the_content` with a priority greater than `20` (IOW after the final default filter `convert_smilies` has run). However, because `get_the_block_template_html()` applies `wptexturize()` (plus the other functions mentioned in this ticket) directly to the complete rendered markup of the page template, this mean that whatever you've added via `the_content` still gets run through those functions. Your patch removes those function callbacks from `the_content` filter in `render_block_core_post_content()`, but plugin and child theme authors would actually ''expect'' those filters to be applied to post content unless they had already explicitly removed them. In my view, the issue here lies not in `render_block_core_post_content()` but in `get_the_block_template_html()` which, in principle, should do little (if anything) beyond running the template through `do_blocks()`. (I assume that `render_block_core_template_part()` should also delegate rendering to the blocks nested inside it and that it, too, should not call `wptexturize()` etc etc either.) Any renderable content in a block theme template should presumably be wrapped in the appropriate block identifier code and its parsing should therefore be handled by the block itself. As it stands, `get_the_block_template_html()` breaks that contract. > The solution I propose is to move certain functions (`wptexturize`, `do_shortcode` and possibly others) out of `the_content` filter and into the block callback of certain blocks (paragraph block, classic block, heading block etc.) This will prevent them from ever being run twice on the same content. This is (kind of) why I raised the example of the HTML block. My point was about encapsulation of rendering responsibilities within blocks themselves and the apparent conflict with `get_the_block_template_html()` applying those functions outside the scope of the blocks themselves. Excluding the content of an HTML block from ''any rendering at all'' (as would be expected by the name of the block) seems problematic as long as `get_the_block_template_html()` applies the functions that it does. The larger issue here is whether `the_content` filter is actually an appropriate filter to invoke in a block theme context at all. > I tested your example and it appears that `&&` is produced even when `wptexturize` is only applied once. While I agree that it is unwanted, it looks to be outside the scope of this ticket. Thanks - yes, on review this does seem to be a bug in `wptexturize()` itself. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 19:13:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 19:13:11 -0000 Subject: [wp-trac] [WordPress Trac] #56831: remover strong tag in wc_get_star_rating_html() Message-ID: <053.7532a26245ea1f58b3006cf234a3238f@wordpress.org> #56831: remover strong tag in wc_get_star_rating_html() --------------------------+----------------------------- Reporter: bananamix | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Please remove the tag of the star rating in /woocommerce/includes /wc-template-functions.php wc_get_star_rating_html() Background: - In case I have many reviews with 5 stars, I have many strong tags for the same word "5". That could lead to SEO down ranking. Common mistakes with strong tags according Seobility.com: - You should avoid excessive use, as search engines will penalize over- optimization and -- page layout that appears unnatural. - Bold or strong tags are used repeatedly for the same words Compared to the total text length, too many bold or strong tags are used -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 19:45:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 19:45:25 -0000 Subject: [wp-trac] [WordPress Trac] #56773: WP-ADMIN CAN'T LOAD AFTER UPGRADE TO WP6 In-Reply-To: <049.037e4eb0ba6edd511eabaadac6d244d2@wordpress.org> References: <049.037e4eb0ba6edd511eabaadac6d244d2@wordpress.org> Message-ID: <064.7bda1c75c48816315f13b2cda3db0f62@wordpress.org> #56773: WP-ADMIN CAN'T LOAD AFTER UPGRADE TO WP6 ----------------------------+---------------------- Reporter: xr00t | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Administration | Version: 6.0.2 Severity: critical | Resolution: invalid Keywords: | Focuses: ----------------------------+---------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 20:49:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 20:49:57 -0000 Subject: [wp-trac] [WordPress Trac] #56832: update_post_meta / get_post_meta data corruption in serialization Message-ID: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> #56832: update_post_meta / get_post_meta data corruption in serialization --------------------------------+----------------------------- Reporter: loopy255 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: Severity: normal | Keywords: Focuses: | --------------------------------+----------------------------- when storing meta data thrtough update_post_meta and probably others, the data gets serialized incorrectly, because of call to wp_unslash. Similarly, the deserialization seems to be calling builtin deserialiation when it should not. Expected behavior is that storing and restoring the state should always return the same value. If I save a string I expect the same string to be returned. The api supports arbitrary types, so storing any scalar value should return the same value. Here is a simple test script: {{{#!php '[ &] \'', ) Equals: false Custom-serialization ------------------------- Stored: "[\\ \\ \\ \\&] \\'" Retrieved: '(failed to deserialize)' Equals: false }}} If you need to keep backwards compatiblity for some reason, please at least provide a fixed api that can be used to store data reliably. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 21:01:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 21:01:56 -0000 Subject: [wp-trac] [WordPress Trac] #56832: update_post_meta / get_post_meta data corruption in serialization In-Reply-To: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> References: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> Message-ID: <067.2aba10192aa8a10f6177e4eea9777151@wordpress.org> #56832: update_post_meta / get_post_meta data corruption in serialization --------------------------------+------------------------ Reporter: loopy255 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Options, Meta APIs | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------------+------------------------ Changes (by TimothyBlynJacobs): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Hi @loopy255, Welcome to trac and thanks for the ticket! Unfortunately, the metadata APIs are one of the APIs that expect slashed data. If you're manually constructing a value passed to the metadata APIs from unslashed data, then you must call `wp_slash` before passing the value to the metadata APIs. This is documented inline to the function, but isn't explicitly mentioned in the function's PHP docs. See #41593. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 21:06:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 21:06:30 -0000 Subject: [wp-trac] [WordPress Trac] #56832: update_post_meta / get_post_meta data corruption in serialization In-Reply-To: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> References: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> Message-ID: <067.79c4d7385b3bfc07b6eea9d7b5996f4c@wordpress.org> #56832: update_post_meta / get_post_meta data corruption in serialization --------------------------------+------------------------ Reporter: loopy255 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Options, Meta APIs | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------------+------------------------ Comment (by loopy255): The documentation would be fine, but it still doesn't fix the issue. For example if you use a string like "[]" (wtthiout quotes), what you retrieve is an array, which is an error. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 21:14:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 21:14:49 -0000 Subject: [wp-trac] [WordPress Trac] #56831: remover strong tag in wc_get_star_rating_html() In-Reply-To: <053.7532a26245ea1f58b3006cf234a3238f@wordpress.org> References: <053.7532a26245ea1f58b3006cf234a3238f@wordpress.org> Message-ID: <068.0c9892bf10f767c4b2e01c8917cf1ae8@wordpress.org> #56831: remover strong tag in wc_get_star_rating_html() -----------------------------+------------------------------ Reporter: bananamix | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: -----------------------------+------------------------------ Changes (by joyously): * status: new => closed * type: defect (bug) => feature request * resolution: => invalid Comment: Hello! Welcome to Trac for WordPress. Your comment is about some code that is not part of WordPress. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 21:18:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 21:18:35 -0000 Subject: [wp-trac] [WordPress Trac] #56832: update_post_meta / get_post_meta data corruption in serialization In-Reply-To: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> References: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> Message-ID: <067.13f4411970784956b026e7a0c1d5900c@wordpress.org> #56832: update_post_meta / get_post_meta data corruption in serialization --------------------------------+------------------------ Reporter: loopy255 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Options, Meta APIs | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------------+------------------------ Comment (by loopy255): Here's updated example that uses properly wp_slash before storing it: {{{#!php '[\\ \\ \\ \\&] \\\'', ) Equals: false Custom-serialization ------------------------- Stored: \"[\\\\\\\\ \\\\\\\\ \\\\\\\\ \\\\\\\\&] \\\\\\\\\\\\\'\" Retrieved: array ( 0 => '"[\\\\\\\\ \\\\\\\\ \\\\\\\\ \\\\\\\\&] \\\\\\\\\\\\\'"', ) Deserialized: '(failed to deserialize)' Equals: false }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 21:39:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 21:39:39 -0000 Subject: [wp-trac] [WordPress Trac] #56832: update_post_meta / get_post_meta data corruption in serialization In-Reply-To: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> References: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> Message-ID: <067.3b0b863dd9555bf6cd3b9d4ab5d36ba9@wordpress.org> #56832: update_post_meta / get_post_meta data corruption in serialization --------------------------------+------------------------ Reporter: loopy255 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Options, Meta APIs | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------------+------------------------ Comment (by TimothyBlynJacobs): In your example code you are calling `get_post_meta` without the third `$single` parameter set to `true`. When that parameter is omitted, the metadata APIs return a list of all meta values for that post with the given key. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 21:44:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 21:44:51 -0000 Subject: [wp-trac] [WordPress Trac] #56832: update_post_meta / get_post_meta data corruption in serialization In-Reply-To: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> References: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> Message-ID: <067.2678e73c162cfd151c5496ab68be1681@wordpress.org> #56832: update_post_meta / get_post_meta data corruption in serialization --------------------------------+------------------------ Reporter: loopy255 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Options, Meta APIs | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------------+------------------------ Comment (by loopy255): True, forgot about that, definitely was using it in production code, everything seems to work now. Thanks again for the wp_slash hint. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 21:46:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 21:46:56 -0000 Subject: [wp-trac] [WordPress Trac] #56832: update_post_meta / get_post_meta data corruption in serialization In-Reply-To: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> References: <052.6d112be213d2e69f8c6304d102909d34@wordpress.org> Message-ID: <067.59d437f35ae8b9a76aedbea78210a5c8@wordpress.org> #56832: update_post_meta / get_post_meta data corruption in serialization --------------------------------+------------------------ Reporter: loopy255 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Options, Meta APIs | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------------+------------------------ Comment (by TimothyBlynJacobs): No problem, happy to help! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 15 23:06:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 15 Oct 2022 23:06:53 -0000 Subject: [wp-trac] [WordPress Trac] #56831: remover strong tag in wc_get_star_rating_html() In-Reply-To: <053.7532a26245ea1f58b3006cf234a3238f@wordpress.org> References: <053.7532a26245ea1f58b3006cf234a3238f@wordpress.org> Message-ID: <068.cf989c2af869a2ae59066118b9621327@wordpress.org> #56831: remover strong tag in wc_get_star_rating_html() -----------------------------+------------------------------ Reporter: bananamix | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: -----------------------------+------------------------------ Comment (by audrasjb): Hello and welcome to WordPress Core Trac! To clarify: you should use [https://wordpress.org/support/plugin/woocommerce/ WooCommerce support forum] as this website is only meant to address issues found in WordPress Core. The code you pointed out comes from a plugin, WooCommerce. Regards -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 00:08:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 00:08:48 -0000 Subject: [wp-trac] [WordPress Trac] #56596: Docs: Default parameter not mentioned on strip_core_block_namespace In-Reply-To: <058.1e45a8f668bf355bdd7562362909016e@wordpress.org> References: <058.1e45a8f668bf355bdd7562362909016e@wordpress.org> Message-ID: <073.310048680641d1823394ae9f5dacab0e@wordpress.org> #56596: Docs: Default parameter not mentioned on strip_core_block_namespace -----------------------------------------+------------------------------ Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.1 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: docs -----------------------------------------+------------------------------ Changes (by sabernhardt): * focuses: => docs * component: Text Changes => Editor Old description: > In blocks.php function inline document $block_name by default is null and > this is not mentioned on this function strip_core_block_namespace New description: In blocks.php function inline document `$block_name` by default is null and this is not mentioned on this function `strip_core_block_namespace` -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 01:34:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 01:34:32 -0000 Subject: [wp-trac] [WordPress Trac] #39781: Automatic updater does not work with VSFTPd server In-Reply-To: <052.10efcfef8bc99af4e62445b7d796dc1b@wordpress.org> References: <052.10efcfef8bc99af4e62445b7d796dc1b@wordpress.org> Message-ID: <067.c2633887d6bc83b9a38bceb425425db9@wordpress.org> #39781: Automatic updater does not work with VSFTPd server -------------------------------------------------+------------------------- Reporter: a1cypher | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Upgrade/Install | Version: 4.7.2 Severity: normal | Resolution: Keywords: reporter-feedback close dev- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: => reporter-feedback close dev-feedback Comment: Commits in #51170 change: - `WP_Filesystem_ftpsockets::exists()` to use file size to determine existence. - `WP_Filesystem_FTPext::exists()` to use [https://www.php.net/manual/en/function.ftp-rawlist.php ftp_rawlist()], which uses the `LIST` command rather than `NLIST`. I believe this should resolve the issue in this ticket. I'm adding the `close`, `reporter-feedback` and `dev-feedback` keywords for a confidence check. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 01:41:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 01:41:32 -0000 Subject: [wp-trac] [WordPress Trac] #55996: the get_the_block_template_html call all the same functions as the the_conent filter so they are run twice In-Reply-To: <051.cff16e4a6bc25786c59a0e8062043f85@wordpress.org> References: <051.cff16e4a6bc25786c59a0e8062043f85@wordpress.org> Message-ID: <066.bc748a35ca93ebd303429a0e10707e4c@wordpress.org> #55996: the get_the_block_template_html call all the same functions as the the_conent filter so they are run twice ------------------------------------------+------------------------------ Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: performance ------------------------------------------+------------------------------ Comment (by manfcarlo): Replying to [comment:9 needle]: > Replying to [comment:8 manfcarlo]: > > A patch for this is available at https://github.com/WordPress/gutenberg/pull/44995 > > @manfcarlo Unfortunately your patch doesn't solve the first issue I mentioned, so let me restate the problem... > > Say you want to add something to the rendered post content that ''must not'' be run through the core default filters. In a plugin, this is traditionally done by hooking in to `the_content` with a priority greater than `20` (IOW after the final default filter `convert_smilies` has run). > > However, because `get_the_block_template_html()` applies `wptexturize()` (plus the other functions mentioned in this ticket) directly to the complete rendered markup of the page template, this mean that whatever you've added via `the_content` still gets run through those functions. The problem you describe is not mentioned in the ticket description at all. The ticket description only identifies the problem of the filters being run twice on the same content, which, to my knowledge, the patch solves. In other words, with the patch, none of the filters identified in the ticket description should ever run more than once on the same content. Unwanted effects such as #54614 and #56295 are believed to be directly caused by the double filters, so the patch should solve them. If the problem you describe still remains after eliminating the double filters, then it can be concluded that it's not caused by the double filters and is therefore outside the scope of this ticket. Plenty of independent bugs will still remain after applying the patch, and they can be worked on later, but it should not delay #54614 and #56295 from being solved if there is a patch to solve them. > This is (kind of) why I raised the example of the HTML block. My point was about encapsulation of rendering responsibilities within blocks themselves and the apparent conflict with `get_the_block_template_html()` applying those functions outside the scope of the blocks themselves. > > Excluding the content of an HTML block from ''any rendering at all'' (as would be expected by the name of the block) seems problematic as long as `get_the_block_template_html()` applies the functions that it does. The argument here is rather fallacious and reminds me of people complaining that free speech is threatened because someone spoke out to disagree with them. If you want "encapsulation of rendering responsibilities within blocks themselves" then you must concede that any wrapper block that contains inner blocks can run something like: {{{#!php The larger issue here is whether `the_content` filter is actually an appropriate filter to invoke in a block theme context at all. I'm not exactly sure of what you're hinting at here, but block themes have been available for 2–3 core release cycles now and I would not expect the core committers to agree to anything that breaks the pre-existing behaviour. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 01:50:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 01:50:32 -0000 Subject: [wp-trac] [WordPress Trac] #46040: Broken symlinks prevent updates In-Reply-To: <051.ee5eb33f94a1f1734289e657e7e53ff7@wordpress.org> References: <051.ee5eb33f94a1f1734289e657e7e53ff7@wordpress.org> Message-ID: <066.2e268c52c6df62bf326189a4da6e0a15@wordpress.org> #46040: Broken symlinks prevent updates -------------------------------------+------------------------------ Reporter: joemoto | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.0.3 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+------------------------------ Comment (by costdev): Hi @Palijn, if you can you test the changes in [https://core.trac.wordpress.org/attachment/ticket/46040/46040.diff 46040.diff] and confirm whether the issue is resolved for you, that would be great to help this ticket move forward. 🙂 Thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 02:56:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 02:56:33 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.aef8538dc3a488c4e5f74ceb8210f136@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-testing-info dev- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by nendeb55): @gziolo Thanks for the tip. How about sending them only when the array comes in? [https://github.com/WordPress/wordpress- develop/blob/70dedb086602287f4e0ee97fbf477adda8310963/src/wp-includes /class-wp-block-type.php#L340-L352] {{{#!php deprecated_properties ) ) { $this->{$name} = $value; return; } $new_name = $name . '_handles'; if ( ! is_string( $value ) ) { $this->{$new_name} = $value; }else{ $this->{$new_name}[0] = $value; } } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 03:05:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 03:05:33 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.37f86c8a55c5a7aa335afc108e2db031@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-testing-info dev- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by nendeb55): Maybe is_array is better than is_string for judging. {{{#!php deprecated_properties ) ) { $this->{$name} = $value; return; } $new_name = $name . '_handles'; if ( is_array( $value ) ) { $this->{$new_name} = $value; }else{ if ( ! is_string( $value ) ) { return; } $this->{$new_name}[0] = $value; } } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 03:19:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 03:19:45 -0000 Subject: [wp-trac] [WordPress Trac] #9883: Password shows under Settings / Writing In-Reply-To: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> References: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> Message-ID: <066.e289c7b9610acf49cdbf987e6be7eb19@wordpress.org> #9883: Password shows under Settings / Writing -------------------------------------------------+------------------------- Reporter: mastrup | Owner: (none) Type: enhancement | Status: assigned Priority: low | Milestone: Future | Release Component: Administration | Version: 2.7.1 Severity: trivial | Resolution: Keywords: has-patch needs-testing has- | Focuses: ui, testing-info dev-feedback | accessibility -------------------------------------------------+------------------------- Comment (by costdev): Thanks for the test report @ironprogrammer! I've now updated the PR with a fix for the auto-focus and for password managers. When you have time, could you run a quick test to confirm whether this fixes both issues? (Remember to rebuild and hard refresh! 😅) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 03:28:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 03:28:18 -0000 Subject: [wp-trac] [WordPress Trac] #43761: CS: Fix violations for wp-admin/install-helper.php In-Reply-To: <052.4be6df608b6b299277021dd5715168f5@wordpress.org> References: <052.4be6df608b6b299277021dd5715168f5@wordpress.org> Message-ID: <067.85e01363bf57e4d132ca59a13ac41230@wordpress.org> #43761: CS: Fix violations for wp-admin/install-helper.php ------------------------------------+------------------------------- Reporter: jipmoors | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch dev-feedback | Focuses: coding-standards ------------------------------------+------------------------------- Changes (by costdev): * keywords: has-patch => has-patch dev-feedback Comment: [https://github.com/WordPress/wordpress-develop/pull/3478 PR 3478] refreshes [https://core.trac.wordpress.org/attachment/ticket/43761/43761 -fix-coding-standards.patch 43761-fix-coding-standards.patch] against `trunk` with some changes to update sniff names and change the last batch to a temporarily disable/re-enable. Pinging @jrf for feedback on whether these changes are appropriate. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 04:01:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 04:01:03 -0000 Subject: [wp-trac] [WordPress Trac] #56713: Check ACL permission before upgrading In-Reply-To: <053.974eade6a1ddb239976f0890e1e14f6c@wordpress.org> References: <053.974eade6a1ddb239976f0890e1e14f6c@wordpress.org> Message-ID: <068.172e0fe32fd295b2a4e9bc7e0c06aa68@wordpress.org> #56713: Check ACL permission before upgrading -------------------------------+------------------------------ Reporter: Cartman34 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by costdev): * keywords: => reporter-feedback Comment: Hi @Cartman34, thanks for opening this ticket! Can you please clarify what "web ui tool" refers to? Is this through the WordPress `Dashboard > Updates` page? If not, what happens when you visit that page and click the `Update` button? Regarding your ACL, I assume that you used `setfacl --recursive -m u:www- data:rwx website`, is that correct? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 04:21:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 04:21:28 -0000 Subject: [wp-trac] [WordPress Trac] #53298: Checking if wp-config-sample.php file exists before checking if wp-config.php exists In-Reply-To: <057.621eea2594a05d9f770f5224ddff5331@wordpress.org> References: <057.621eea2594a05d9f770f5224ddff5331@wordpress.org> Message-ID: <072.28cc098365581f814433380e8fcb88e0@wordpress.org> #53298: Checking if wp-config-sample.php file exists before checking if wp- config.php exists -------------------------------------+------------------------------------- Reporter: machineitsvcs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.7.2 Severity: trivial | Resolution: Keywords: needs-patch dev- | Focuses: administration, feedback | privacy, coding-standards -------------------------------------+------------------------------------- Changes (by costdev): * keywords: needs-patch => needs-patch dev-feedback Comment: Hi @machineitsvcs, welcome to Trac and thanks for opening this ticket, and providing some potential solutions! As you said, if we reverse the conditions, then if `wp-config.php` and `wp-config-sample.php` don't exist in `ABSPATH`, the second `wp-config- sample.php` check will try to go up one level, and the warning is still shown. For that reason, I don't think swapping the order is the solution here. @SergeyBiryukov The `@` operator seems the most appropriate solution here as it's already there for [https://github.com/wordpress/wordpress- develop/blob/c39a45cd3f84cb1bb0d7a6dba8660bac45c99447/src/wp-admin/setup- config.php#L72 the wp-config.php and wp-settings.php checks]. However, I know that we're trying to reduce the number of `@` operators in Core, and adding a new one seems counter-productive to that effort. That said, [https://www.php.net/manual/en/function.file-exists.php file_exists()] emits an `E_WARNING`, not a fatal error, and when considering consistency with other checks in this file, it may be acceptable to add a new `@` operator here. I'd appreciate your thoughts on how this might proceed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 05:53:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 05:53:33 -0000 Subject: [wp-trac] [WordPress Trac] #49286: Function get_core_updates() in update-core.php can return an empty array In-Reply-To: <065.4345306872982d46cba49eb295bc25bc@wordpress.org> References: <065.4345306872982d46cba49eb295bc25bc@wordpress.org> Message-ID: <080.553f5919801aa6b0146ac6c0def490de@wordpress.org> #49286: Function get_core_updates() in update-core.php can return an empty array ---------------------------------------+------------------------------ Reporter: citizenrepresentative | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: needs-testing needs-patch | Focuses: ---------------------------------------+------------------------------ Changes (by costdev): * Attachment "49286.diff" added. Check `$updates` before outputting list of Core updates. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 05:56:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 05:56:58 -0000 Subject: [wp-trac] [WordPress Trac] #49286: Function get_core_updates() in update-core.php can return an empty array In-Reply-To: <065.4345306872982d46cba49eb295bc25bc@wordpress.org> References: <065.4345306872982d46cba49eb295bc25bc@wordpress.org> Message-ID: <080.d77f36fb51e96e43d0efe81308bfafeb@wordpress.org> #49286: Function get_core_updates() in update-core.php can return an empty array -------------------------------------+----------------------------- Reporter: citizenrepresentative | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: needs-testing has-patch | Focuses: -------------------------------------+----------------------------- Changes (by costdev): * keywords: needs-testing needs-patch => needs-testing has-patch * milestone: Awaiting Review => Future Release Comment: I have attached a patch that returns early from `list_core_update()` if `$update` is not an object. For good measure, I've also wrapped the list output in `core_upgrade_preamble` in a `if ( $updates )` check so that an empty list is not output when `get_core_updates()` returns either `false` or `array()`. Unfortunately, I can't add PHPUnit tests for these changes without moving `list_core_update()` and `core_upgrade_preamble()` to a separate file due to headers being sent. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 06:18:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 06:18:41 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.78d47545a444ccceb709b660b0900793@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-testing-info dev- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by costdev): @nendeb55 Slight modification to minimize nesting: {{{#!php deprecated_properties ) ) { $this->{$name} = $value; return; } $new_name = $name . '_handles'; if ( is_array( $value ) ) { $this->{$new_name} = $value; return; } if ( ! is_string( $value ) ) { return; } $this->{$new_name}[0] = $value; } }}} @zieladam, as Greg is on leave, you're up! 😆 (If someone else should be pinged, please do so!) Is there any chance that `$this->{$new_name}` will already have some entries that ''must'' stay there? In other words, is `$this->{$new_name} = $value` safe to use, or should we be **prepending** `$value` to `$this->{$new_name}` instead? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 09:15:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 09:15:37 -0000 Subject: [wp-trac] [WordPress Trac] #56833: Untranslatable variable Message-ID: <049.413943264f8d071d272c09ce63421a89@wordpress.org> #56833: Untranslatable variable ------------------------------------+----------------------------- Reporter: jdy68 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: trunk Severity: normal | Keywords: Focuses: | ------------------------------------+----------------------------- Hi, In this string: https://translate.wordpress.org/projects/wp/6.0.x/fr/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=14632529&filters%5Btranslation_id%5D=98156944 the variable %s is an URL to an article of documentation. This article exists in French, but we cannot redirect users to it. Is it possible to correct this? This issue concern also the versions 5.9, 5.8, 5.7,... Thanks -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 09:24:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 09:24:56 -0000 Subject: [wp-trac] [WordPress Trac] #56834: Correctly escape `$comment->comment_author_url` URL Message-ID: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> #56834: Correctly escape `$comment->comment_author_url` URL ------------------------------+----------------------------- Reporter: zenaulislam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: coding-standards | ------------------------------+----------------------------- IN 'wp-includes/blocks/avatar.php' on line `130` I've found that `$comment->comment_author_url` was used without escaping. I think we can improve it by escaping the URL for more consistency. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 09:25:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 09:25:36 -0000 Subject: [wp-trac] [WordPress Trac] #56834: Correctly escape `$comment->comment_author_url` URL In-Reply-To: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> References: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> Message-ID: <070.112cfa5e2420bcd6d3206d617c035447@wordpress.org> #56834: Correctly escape `$comment->comment_author_url` URL --------------------------+------------------------------- Reporter: zenaulislam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: coding-standards --------------------------+------------------------------- Changes (by zenaulislam): * Attachment "56834.diff" added. Created Patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 09:26:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 09:26:09 -0000 Subject: [wp-trac] [WordPress Trac] #56834: Correctly escape `$comment->comment_author_url` URL In-Reply-To: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> References: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> Message-ID: <070.de98c10a738b9e48cf406b86cae7a835@wordpress.org> #56834: Correctly escape `$comment->comment_author_url` URL --------------------------+------------------------------- Reporter: zenaulislam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards --------------------------+------------------------------- Changes (by zenaulislam): * keywords: => has-patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 11:00:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 11:00:32 -0000 Subject: [wp-trac] [WordPress Trac] #56833: Untranslatable variable In-Reply-To: <049.413943264f8d071d272c09ce63421a89@wordpress.org> References: <049.413943264f8d071d272c09ce63421a89@wordpress.org> Message-ID: <064.e9fb9500481b75d0f456ab6ccda5e0f1@wordpress.org> #56833: Untranslatable variable ------------------------------------+------------------------------ Reporter: jdy68 | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: trunk Severity: normal | Resolution: invalid Keywords: close | Focuses: ------------------------------------+------------------------------ Changes (by kebbet): * keywords: => close * status: new => closed * resolution: => invalid Comment: The string is translatable, see https://translate.wordpress.org/projects/wp/6.0.x/fr/default/?filters%5Bterm%5D=https%3A%2F%2Fwordpress.org%2Fsupport%2Farticle %2Fresetting-your- password%2F&filters%5Bterm_scope%5D=scope_any&filters%5Bstatus%5D=either&filters%5Buser_login%5D=&filter=Apply+Filters&sort%5Bby%5D=references&sort%5Bhow%5D=desc -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 14:17:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 14:17:11 -0000 Subject: [wp-trac] [WordPress Trac] #56834: Correctly escape `$comment->comment_author_url` URL In-Reply-To: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> References: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> Message-ID: <070.e0bc089e3ae9c7780fb1ceb6aa0ae287@wordpress.org> #56834: Correctly escape `$comment->comment_author_url` URL --------------------------+------------------------------- Reporter: zenaulislam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards --------------------------+------------------------------- Comment (by cbravobernal): Thanks for the fix! Could you please apply it to the Gutenberg plugin? That way, in future releases of WP, this change won't be overridden during the automatic synchronization between the block library package and WordPress Core. https://github.com/WordPress/gutenberg/pulls -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 14:35:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 14:35:07 -0000 Subject: [wp-trac] [WordPress Trac] #56833: Untranslatable variable In-Reply-To: <049.413943264f8d071d272c09ce63421a89@wordpress.org> References: <049.413943264f8d071d272c09ce63421a89@wordpress.org> Message-ID: <064.fcc5188ffdec80d869edea6e971e84f7@wordpress.org> #56833: Untranslatable variable ------------------------------------+---------------------- Reporter: jdy68 | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Login and Registration | Version: trunk Severity: normal | Resolution: invalid Keywords: close | Focuses: ------------------------------------+---------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 14:38:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 14:38:03 -0000 Subject: [wp-trac] [WordPress Trac] #56831: remover strong tag in wc_get_star_rating_html() In-Reply-To: <053.7532a26245ea1f58b3006cf234a3238f@wordpress.org> References: <053.7532a26245ea1f58b3006cf234a3238f@wordpress.org> Message-ID: <068.4be57c90ade6aaf7469d3ace918790d7@wordpress.org> #56831: remover strong tag in wc_get_star_rating_html() -----------------------------+---------------------- Reporter: bananamix | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: -----------------------------+---------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 14:48:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 14:48:19 -0000 Subject: [wp-trac] [WordPress Trac] #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp-includes/blocks/avatar.php' In-Reply-To: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> References: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> Message-ID: <067.9bce2ba55e7f284ec9a2bd50d03e67e6@wordpress.org> #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp- includes/blocks/avatar.php' --------------------------+------------------------------- Reporter: hztyfoon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards --------------------------+------------------------------- Changes (by SergeyBiryukov): * component: General => Editor Comment: Hi there, welcome back to WordPress Trac! Thanks for the ticket and the PR. Please note that files in `wp-includes/blocks/` should not be patched directly here in this repository. Instead, it would need to be fixed in the [https://github.com/WordPress/gutenberg/tree/trunk/packages/block- library block-library package upstream], specifically in the [https://github.com/WordPress/gutenberg/blob/735f8387546f32ffeaf12dbfc64e09e0cf8d0b48/packages /block-library/src/avatar/index.php#L103 avatar block], and then it will be merged into core as part of package updates. Could you create an issue or PR at https://github.com/WordPress/gutenberg? Thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 14:49:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 14:49:39 -0000 Subject: [wp-trac] [WordPress Trac] #56835: Increase test coverage to WP_Theme_JSON_Resolver Message-ID: <056.fbe9a1e097ac44bb8eb9c0fa0770c9cb@wordpress.org> #56835: Increase test coverage to WP_Theme_JSON_Resolver --------------------------+----------------------------- Reporter: cbravobernal | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Adding a test to cover WP_Theme_JSON_Resolver->get_theme_data() We only test the add_theme_support overriding feature and that the functions return a WP_Theme_JSON object, as the part of the code that merges the child theme into the parent theme has been already tested in test_merges_child_theme_json_into_parent_theme_json on tickets 56611, 54336 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 14:49:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 14:49:47 -0000 Subject: [wp-trac] [WordPress Trac] #56834: Correctly escape `$comment->comment_author_url` URL In-Reply-To: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> References: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> Message-ID: <070.75cfe0128278d0fec3fef9d582c3f7f0@wordpress.org> #56834: Correctly escape `$comment->comment_author_url` URL --------------------------+------------------------------- Reporter: zenaulislam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards --------------------------+------------------------------- Changes (by SergeyBiryukov): * component: General => Editor Comment: Hi there, welcome to WordPress Trac! Thanks for the ticket and the patch. As noted above, files in `wp-includes/blocks/` should not be patched directly here in this repository. Instead, it would need to be fixed in the [https://github.com/WordPress/gutenberg/tree/trunk/packages/block- library block-library package upstream], specifically in the [https://github.com/WordPress/gutenberg/blob/735f8387546f32ffeaf12dbfc64e09e0cf8d0b48/packages /block-library/src/avatar/index.php#L130 avatar block], and then it will be merged into core as part of package updates. Could you create an issue or PR at https://github.com/WordPress/gutenberg? Thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 15:28:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 15:28:00 -0000 Subject: [wp-trac] [WordPress Trac] #56834: Correctly escape `$comment->comment_author_url` URL In-Reply-To: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> References: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> Message-ID: <070.605ada2e7449f6c266cb4cf91dfeda75@wordpress.org> #56834: Correctly escape `$comment->comment_author_url` URL --------------------------+------------------------------- Reporter: zenaulislam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards --------------------------+------------------------------- Comment (by zenaulislam): Hi @SergeyBiryukov, @cbravobernal Thank you so much for the direction. I have created a PR in this https://github.com/WordPress/gutenberg/ repository. PR https://github.com/WordPress/gutenberg/pull/44999 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 15:43:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 15:43:51 -0000 Subject: [wp-trac] [WordPress Trac] #56596: Docs: Default parameter not mentioned on strip_core_block_namespace In-Reply-To: <058.1e45a8f668bf355bdd7562362909016e@wordpress.org> References: <058.1e45a8f668bf355bdd7562362909016e@wordpress.org> Message-ID: <073.ef3c783d00345175d4115af326db2669@wordpress.org> #56596: Docs: Default parameter not mentioned on strip_core_block_namespace -----------------------------------------+--------------------- Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.0.1 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: docs -----------------------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 15:44:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 15:44:32 -0000 Subject: [wp-trac] [WordPress Trac] #56596: Docs: Default parameter not mentioned on strip_core_block_namespace In-Reply-To: <058.1e45a8f668bf355bdd7562362909016e@wordpress.org> References: <058.1e45a8f668bf355bdd7562362909016e@wordpress.org> Message-ID: <073.57839a5dadaed11edac57cd47f486882@wordpress.org> #56596: Docs: Default parameter not mentioned on strip_core_block_namespace -----------------------------------------+----------------------------- Reporter: rakibwordpress | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.0.1 Severity: normal | Resolution: fixed Keywords: has-patch changes-requested | Focuses: docs -----------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"54520" 54520]: {{{ #!CommitTicketReference repository="" revision="54520" Docs: Clarify default values for a few block function parameters. This applies to: * `$block_name` in `strip_core_block_namespace()` * `$allowed_html` in `filter_block_content()` * `$pagination_type` in `get_comments_pagination_arrow()` Follow-up to [46896], [48794], [53138], [54181]. Props rakibwordpress, ironprogrammer, sabernhardt, SergeyBiryukov. Fixes #56596. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 15:48:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 15:48:23 -0000 Subject: [wp-trac] [WordPress Trac] #56834: Correctly escape `$comment->comment_author_url` URL In-Reply-To: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> References: <055.254bc70b17fe79f4e8dfac727422a951@wordpress.org> Message-ID: <070.6f035c76c48bb5d9082e42034dbeae09@wordpress.org> #56834: Correctly escape `$comment->comment_author_url` URL --------------------------+-------------------------------- Reporter: zenaulislam | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: Severity: normal | Resolution: reported-upstream Keywords: has-patch | Focuses: coding-standards --------------------------+-------------------------------- Changes (by SergeyBiryukov): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: Great, thanks for the follow-up! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 15:54:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 15:54:02 -0000 Subject: [wp-trac] [WordPress Trac] #56835: Increase test coverage to WP_Theme_JSON_Resolver In-Reply-To: <056.fbe9a1e097ac44bb8eb9c0fa0770c9cb@wordpress.org> References: <056.fbe9a1e097ac44bb8eb9c0fa0770c9cb@wordpress.org> Message-ID: <071.b29cdbb0c9acd841f6aa3b3ed78b6f4e@wordpress.org> #56835: Increase test coverage to WP_Theme_JSON_Resolver --------------------------------------+--------------------- Reporter: cbravobernal | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.1 Old description: > Adding a test to cover WP_Theme_JSON_Resolver->get_theme_data() > > We only test the add_theme_support overriding feature and that the > functions return a WP_Theme_JSON object, as the part of the code that > merges the child theme into the parent theme has been already tested in > test_merges_child_theme_json_into_parent_theme_json on tickets 56611, > 54336 New description: Adding a test to cover WP_Theme_JSON_Resolver->get_theme_data() We only test the add_theme_support overriding feature and that the functions return a WP_Theme_JSON object, as the part of the code that merges the child theme into the parent theme has been already tested in test_merges_child_theme_json_into_parent_theme_json on tickets #56611, #54336. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 15:54:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 15:54:12 -0000 Subject: [wp-trac] [WordPress Trac] #56835: Increase test coverage to WP_Theme_JSON_Resolver In-Reply-To: <056.fbe9a1e097ac44bb8eb9c0fa0770c9cb@wordpress.org> References: <056.fbe9a1e097ac44bb8eb9c0fa0770c9cb@wordpress.org> Message-ID: <071.815dcb47312d6abf4cc03987ff49cc83@wordpress.org> #56835: Increase test coverage to WP_Theme_JSON_Resolver --------------------------------------+--------------------- Reporter: cbravobernal | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.1 Component: Themes | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by SergeyBiryukov): * component: General => Themes -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 17:35:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 17:35:15 -0000 Subject: [wp-trac] [WordPress Trac] #56510: Verify permissions before update failed In-Reply-To: <053.e87962fa33580b4c140fc558274b1060@wordpress.org> References: <053.e87962fa33580b4c140fc558274b1060@wordpress.org> Message-ID: <068.5acffa6bbbf813c327758820b2952d2e@wordpress.org> #56510: Verify permissions before update failed -----------------------------+----------------------------- Reporter: Cartman34 | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Upgrade/Install | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: administration -----------------------------+----------------------------- Changes (by costdev): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Duplicate of #56713. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 17:59:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 17:59:55 -0000 Subject: [wp-trac] [WordPress Trac] #55996: the get_the_block_template_html call all the same functions as the the_conent filter so they are run twice In-Reply-To: <051.cff16e4a6bc25786c59a0e8062043f85@wordpress.org> References: <051.cff16e4a6bc25786c59a0e8062043f85@wordpress.org> Message-ID: <066.1ee43057dbd676f2164d7c5b1ddc7c83@wordpress.org> #55996: the get_the_block_template_html call all the same functions as the the_conent filter so they are run twice ------------------------------------------+------------------------------ Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: performance ------------------------------------------+------------------------------ Comment (by needle): Replying to [comment:10 manfcarlo]: > The problem you describe is not mentioned in the ticket description at all. The ticket description only identifies the problem of the filters being run twice on the same content, which, to my knowledge, the patch solves. The ticket doesn't actually mention a problem at all; it simply notes that there is duplication. I'm filling in the gaps, which are twofold: 1. Some functions (e.g. `wptexturize`) that are usually applied via `the_content` filter are applied twice to the content. 2. In non-block themes, it is possible to bypass these functions when they are applied via `the_content` filter. In block themes, as things stand, this is not possible. Your patch removes the core callbacks from `the_content` filter, which addresses (1) but does not address (2). > In other words, with the patch, none of the filters identified in the ticket description should ever run more than once on the same content. Unwanted effects such as #54614 and #56295 are believed to be directly caused by the double filters, so the patch should solve them. I agree with you on this but disagree with your choice of which calls to remove. In my opinion, it is the direct calls in `get_the_block_template_html()` that should be removed (because they break the existing functionality that some plugins rely on) rather than removing the ''expected'' callbacks in `render_block_core_post_content()`. The result would be the same in terms of solving (1), but would also offer a path to solving (2). My knowledge of the knock-on effects of removing those function calls from `get_the_block_template_html()` is limited, but if they really do need to be called there, then I favour [https://github.com/WordPress/gutenberg/pull/17626#discussion_r329168610 Weston Ruter's original suggestion] that they should be called via a separate hook rather than directly. They could then be unhooked or overridden if need be, which is not the case at present. > The argument here is rather fallacious and reminds me of people complaining that free speech is threatened because someone spoke out to disagree with them. Please don't be offensive. This is a technical discussion not a political one. > The only way to stop blocks like Custom HTML from being filtered by a core wrapper block is to delegate the filters to micro-level blocks such as Paragraph, which I would imagine is inefficient and not how the filters were originally intended to be used. Yes, this is indeed a condundrum. The reason why I used the example of the HTML block is that it neatly illustrates this conundrum. > I would not expect the core committers to agree to anything that breaks the pre-existing behaviour. I can't anticipate what core committers will do, but what I do know is that the direct function calls in `get_the_block_template_html()` are already breaking the pre-existing behaviour, so the question is how best to address that breakage. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 21:54:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 21:54:51 -0000 Subject: [wp-trac] [WordPress Trac] #54334: E2E tests for Uploading New Version of Themes & Plugins In-Reply-To: <050.02f5a862b223614d9e43274c6499a29a@wordpress.org> References: <050.02f5a862b223614d9e43274c6499a29a@wordpress.org> Message-ID: <065.32218d842cf8a1700f85036fd1e8d0a2@wordpress.org> #54334: E2E tests for Uploading New Version of Themes & Plugins -------------------------------------------------+------------------------- Reporter: juhise | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: Future | Release Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | -------------------------------------------------+------------------------- Comment (by costdev): Looks like [https://github.com/WordPress/wordpress-develop/pull/1786 the PR] needs to be changed from comparing to `WordPress:master` to `WordPress:trunk`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 22:27:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 22:27:04 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.a6ef994763655799ccef8133c94f6fd7@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Query | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Comment (by peterwilsoncc): Although it's not major, it would be good to get [https://github.com/WordPress/wordpress-develop/pull/3462 PR#3462] in to 6.1. This will avoid filling persistent caches with unreachable keys & potentially having reachable keys dropped as a result. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 16 23:25:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 16 Oct 2022 23:25:25 -0000 Subject: [wp-trac] [WordPress Trac] #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect Message-ID: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect ------------------------------+----------------------------- Reporter: nickchomey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Database | Version: 6.0.2 Severity: normal | Keywords: Focuses: coding-standards | ------------------------------+----------------------------- I'm getting these deprecation warnings in the debug.log {{{ [16-Oct-2022 23:14:52 UTC] PHP Deprecated: mysqli_real_connect(): Passing null to parameter #5 ($database) of type ?string is deprecated in /home/seeingtheforest.net/public_html/wp-includes/wp-db.php on line 1753 [16-Oct-2022 23:14:52 UTC] PHP Deprecated: mysqli_real_connect(): Passing null to parameter #6 ($port) of type ?int is deprecated in /home/seeingtheforest.net/public_html/wp-includes/wp-db.php on line 1753 [16-Oct-2022 23:14:52 UTC] PHP Deprecated: mysqli_real_connect(): Passing null to parameter #7 ($socket) of type ?string is deprecated in /home/seeingtheforest.net/public_html/wp-includes/wp-db.php on line 1753 }}} I'm using PHP 8.1, so assume it is due to that. It probably happens in 8.0 as well. If I trace the error with Xdebug, I can see that the problem is a) null is simply hardcoded for param 5 b) port and socket are set to null if they aren't included in wp- config.php e.g. {{{define('DB_HOST', "localhost");}}} If I manually change param 5 to {{{""}}} and {{{ $port = ""; $socket = ""; }}} in {{{wp-includes/wp-db.php -> parse_db_host()}}} then the problem goes away. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 00:31:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 00:31:01 -0000 Subject: [wp-trac] [WordPress Trac] #56713: Check ACL permission before upgrading In-Reply-To: <053.974eade6a1ddb239976f0890e1e14f6c@wordpress.org> References: <053.974eade6a1ddb239976f0890e1e14f6c@wordpress.org> Message-ID: <068.fc06dc06ca9f27172a7aca12db50bc73@wordpress.org> #56713: Check ACL permission before upgrading --------------------------------------------+------------------------------ Reporter: Cartman34 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: reporter-feedback dev-feedback | Focuses: --------------------------------------------+------------------------------ Changes (by costdev): * keywords: reporter-feedback => reporter-feedback dev-feedback Comment: == Notes - [https://github.com/wordpress/wordpress- develop/blob/49da4afcf03f6eea5aba20b42abc0130fc9e2749/src/wp- admin/includes/class-core-upgrader.php#L162 This is the chmod() call] that leads to the first warning. There are others later in the trace. - In `WP_Filesystem_Direct::chmod()`, [https://github.com/wordpress /wordpress-develop/blob/49da4afcf03f6eea5aba20b42abc0130fc9e2749/src/wp- admin/includes/class-wp-filesystem-direct.php#L173 this is the line] that actually triggers the first warning. - `Site Health > Info > Filesystem Permissions` shows all directories as writable. - Changing file ownership via `chown -R www-data:www-data ` does resolve the issue, but defeats the purpose of adding `u:www-data:rwx` to the (F)ACL. - `chmod()` can only be used by the file owner, or `root`. ----- == When Testing For my tests, I used the following commands: {{{ # Set the owner to root. sudo chown root:root # Give www-data permissions via (F)ACL. setfacl -Rm u:www-data:rwx }}} When trying to update through `Dashboard > Updates`, `Plugins > Installed Plugins > Update now`, or `Themes > Update now`, the "Connection Information" dialog to enter FTP credentials may be displayed. This is caused by a mismatch in file ownership vs temp file ownership in [https://github.com/wordpress/wordpress- develop/blob/49da4afcf03f6eea5aba20b42abc0130fc9e2749/src/wp- admin/includes/file.php#L2091 this condition]. `define( 'FS_METHOD', 'direct' );` in `wp-config.php` resolves this. ----- == Findings This seems to be an issue with calling `$wp_filesystem->chmod()` when the file is not owned by `www-data`. The files are writable, but `chmod()` can only be used by the actual file owner. Unfortunately, I don't believe we can rely on `fileowner()` or `$wp_filesystem->owner()` checks, as `www-data` is a default username and will be different based on environment or customizations. Therefore, wrapping each of these calls to `$wp_filesystem->chmod()` with an `! $wp_filesystem->is_writable()` check should make sure that `chmod()` is only run when the path is not writable. This is done in most other places in Core, but not all. Wrapping various `chmod()` calls with `if ( $wp_filesystem->is_writable() ) {}` and defining `FS_METHOD` as `direct` seems to update just fine for me. The `chmod()` calls I found to be relevant to this issue are: - [https://github.com/wordpress/wordpress- develop/blob/49da4afcf03f6eea5aba20b42abc0130fc9e2749/src/wp- admin/includes/class-core-upgrader.php#L162 wp-admin/includes/class-core- upgrader.php]. - [https://github.com/wordpress/wordpress- develop/blob/49da4afcf03f6eea5aba20b42abc0130fc9e2749/src/wp- admin/includes/class-wp-filesystem-direct.php#L312 wp-admin/includes /class-wp-filesystem-direct.php] - Problem 1. - [https://github.com/wordpress/wordpress- develop/blob/49da4afcf03f6eea5aba20b42abc0130fc9e2749/src/wp- admin/includes/update-core.php#L1213 wp-admin/includes/update-core.php] - Problem 2. **Problem 1** This change may (read: ''will'') have unintended consequences. **Problem 2** This file is loaded from ''the files of the WordPress version being installed'', not the files of the current WordPress version. This means any patch will not be fully functional unless: 1. We backport the `is_writable()` checks to older branches (not desirable), OR 2. Users with such a setup continue to manually install until upgrading to the version ''after'' the one that patches this issue (a minor hassle, but not asking anything extra of users). That is, if WordPress 6.2 patches this issue, the patch won't be fully functional until WordPress 6.3 is released. ----- == Conclusion This may be resolvable in Core, but needs feedback and discussion on the above before it can move forward. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 00:34:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 00:34:30 -0000 Subject: [wp-trac] [WordPress Trac] #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections In-Reply-To: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> References: <059.4bd105290cba4379e18b2351fd2a3304@wordpress.org> Message-ID: <074.c9f7515487adcb56e9e72d3bf9a1b4dc@wordpress.org> #54877: Occasional PHP exception being thrown on WPDB/MySQLi connections -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 1.5 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing early | Focuses: commit | -------------------------------------------------+------------------------- Comment (by nickchomey): I hate to re-open a discussion that was closed by a bunch of considerably more competent people than I. But, I'm getting various deprecation warnings - multiple times per page load - related to this issue when using PHP 8.1 on my site. I know that @jrf pointed to the php source code to say that the parameters should be nullable, but it doesn't seem to be the case in practice. It could be because I'm using lsphp rather than normal php. Anyway, as I described in this issue that I just opened and closed (https://core.trac.wordpress.org/ticket/56836), if you simply pass an empty string {{{""}}} rather than null, the problem goes away. Is that not an acceptable solution here? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 00:35:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 00:35:01 -0000 Subject: [wp-trac] [WordPress Trac] #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect In-Reply-To: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> References: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> Message-ID: <069.f7fddcb2dc5a7c4ff86916c1d7c21514@wordpress.org> #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect --------------------------+------------------------------- Reporter: nickchomey | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Database | Version: 6.0.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: coding-standards --------------------------+------------------------------- Changes (by nickchomey): * status: new => closed * resolution: => duplicate Comment: Duplicate of #54877. Closing this as it is already an issue here https://core.trac.wordpress.org/ticket/54877#comment:42 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 00:50:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 00:50:58 -0000 Subject: [wp-trac] [WordPress Trac] #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect In-Reply-To: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> References: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> Message-ID: <069.301760d900156530c5706d8fbf6a56ce@wordpress.org> #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect --------------------------+------------------------------- Reporter: nickchomey | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Database | Version: 6.0.2 Severity: normal | Resolution: duplicate Keywords: php81 | Focuses: coding-standards --------------------------+------------------------------- Changes (by SergeyBiryukov): * keywords: => php81 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 01:01:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 01:01:36 -0000 Subject: [wp-trac] [WordPress Trac] #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect In-Reply-To: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> References: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> Message-ID: <069.d52fe04d34a117bf6f784b977202eff1@wordpress.org> #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect --------------------------+------------------------------- Reporter: nickchomey | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Database | Version: 6.0.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: coding-standards --------------------------+------------------------------- Changes (by nickchomey): * keywords: php81 => Comment: I've decided to close this as well as remove my comment from #54877 as it seems like there's a bug in Litespeed's lsphp81 that isn't treating {{{mysqli_real_connect}}}'s parameters as nullable. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 01:02:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 01:02:58 -0000 Subject: [wp-trac] [WordPress Trac] #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect In-Reply-To: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> References: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> Message-ID: <069.7fa054273ef7a6fcaa03d60ba2bacc43@wordpress.org> #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect --------------------------+------------------------------ Reporter: nickchomey | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Database | Version: 6.0.2 Severity: normal | Resolution: duplicate Keywords: php81 | Focuses: --------------------------+------------------------------ Changes (by nickchomey): * keywords: => php81 * focuses: coding-standards => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 01:04:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 01:04:18 -0000 Subject: [wp-trac] [WordPress Trac] #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect In-Reply-To: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> References: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> Message-ID: <069.d3b4f8f8f2aead39654cea56071a89a8@wordpress.org> #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect --------------------------+------------------------------ Reporter: nickchomey | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Database | Version: 6.0.2 Severity: normal | Resolution: duplicate Keywords: php81 | Focuses: --------------------------+------------------------------ Comment (by SergeyBiryukov): Hi there, welcome back to WordPress Trac! Just adding some context from #54877: * The `$database`, `$port`, and `$socket` parameters of `mysqli_real_connect()` should actually be nullable, as they are `null` by default in [https://github.com/php/php- src/blob/c68591fa1681dd63b34a429a3378c37f4a657d8d/ext/mysqli/mysqli.stub.php#L294-L306 PHP source], per comment:15:ticket:54877. * The issue might have to do with using [https://www.php.net/manual/en/install.unix.litespeed.php LiteSpeed PHP], per comment:42:ticket:54877. P.S. Ah, it looks like this is already noted above. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 04:25:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 04:25:54 -0000 Subject: [wp-trac] [WordPress Trac] #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar In-Reply-To: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> References: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> Message-ID: <072.eef4b77fa2311d7f85bdf17c1630c6c9@wordpress.org> #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar -----------------------------+--------------------------------------- Reporter: severinepozzo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots | Focuses: administration, template -----------------------------+--------------------------------------- Changes (by krupalpanchal): * keywords: => has-screenshots -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 04:57:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 04:57:31 -0000 Subject: [wp-trac] [WordPress Trac] #56837: Disable automatic embed Message-ID: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> #56837: Disable automatic embed -------------------------+----------------------------- Reporter: da_dj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- I’m pasting a link, but the block editor is converting it to an embed. I’d prefer not having to mess with themes or plugins. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 05:08:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 05:08:01 -0000 Subject: [wp-trac] [WordPress Trac] #56837: Disable automatic embed In-Reply-To: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> References: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> Message-ID: <064.21c472080ccba6f5baa936e29588dc96@wordpress.org> #56837: Disable automatic embed -------------------------------+------------------------------ Reporter: da_dj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by costdev): * keywords: => reporter-feedback Comment: Hi @da_dj, welcome to Trac! You can paste the link, then click the icon at the left of the toolbar (e.g. the YouTube icon), then "Paragraph" to change the embed back to a link. Are you happy with this, or would you like to keep your ticket open to see what others think of disabling automatic embed by default? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 05:08:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 05:08:09 -0000 Subject: [wp-trac] [WordPress Trac] #56837: Disable automatic embed In-Reply-To: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> References: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> Message-ID: <064.61e54250039f02cef5e26c31261f2194@wordpress.org> #56837: Disable automatic embed -------------------------------+------------------------------ Reporter: da_dj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by costdev): * component: General => Editor -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 05:16:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 05:16:34 -0000 Subject: [wp-trac] [WordPress Trac] #56837: Disable automatic embed In-Reply-To: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> References: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> Message-ID: <064.fd903b2889a295a8e930b4127fc9bc5d@wordpress.org> #56837: Disable automatic embed -------------------------------+------------------------------ Reporter: da_dj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by costdev): For others reading this ticket, @da_dj previously opened [https://wordpress.org/support/topic/feature-request-disable-automatic- embed/ a ticket on the forums] and was directed here if they would like to request a change in Core. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 06:48:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 06:48:49 -0000 Subject: [wp-trac] [WordPress Trac] #56838: Fix deprecated uasort callback in wp_generate_tag_cloud() Message-ID: <052.1a962fd2b76413fc73208f39aaac119e@wordpress.org> #56838: Fix deprecated uasort callback in wp_generate_tag_cloud() --------------------------+----------------------------- Reporter: skithund | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Keywords: php8 Focuses: | --------------------------+----------------------------- Sorting by `count` in tag cloud generates deprecation error in PHP 8.0. `uasort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 06:51:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 06:51:15 -0000 Subject: [wp-trac] [WordPress Trac] #56838: Deprecated uasort callback in wp_generate_tag_cloud() (was: Fix deprecated uasort callback in wp_generate_tag_cloud()) In-Reply-To: <052.1a962fd2b76413fc73208f39aaac119e@wordpress.org> References: <052.1a962fd2b76413fc73208f39aaac119e@wordpress.org> Message-ID: <067.4ef2824bd077d1785edbc57f636b21fb@wordpress.org> #56838: Deprecated uasort callback in wp_generate_tag_cloud() ----------------------------+------------------------------ Reporter: skithund | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: php8 has-patch | Focuses: ----------------------------+------------------------------ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 07:19:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 07:19:27 -0000 Subject: [wp-trac] [WordPress Trac] #56837: Disable automatic embed In-Reply-To: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> References: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> Message-ID: <064.4f42826fe29d0e667d8ec5f4e2882bd7@wordpress.org> #56837: Disable automatic embed -------------------------------+------------------------------ Reporter: da_dj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by sabernhardt): GB21789 is closely related, if you would like to continue the discussion there. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 08:22:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 08:22:31 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.87d4bf6900d95d595a30314cdddcee5f@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------+------------------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect | Status: reopened (bug) | Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: | Focuses: ui, accessibility, css, | administration -------------------------+------------------------------------------------- Changes (by sabernhardt): * keywords: commit => * status: closed => reopened * resolution: fixed => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 08:23:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 08:23:59 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.67906529e8661b712d810124b84cb8ac@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------+------------------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect | Status: reopened (bug) | Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: | Focuses: ui, accessibility, css, | administration -------------------------+------------------------------------------------- Changes (by sabernhardt): * Attachment "forum-link-100-percent.png" added. support forum link popup at 100% -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 08:24:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 08:24:40 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.85f6476b379340d5c3e3961d4a194bff@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------+------------------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect | Status: reopened (bug) | Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: | Focuses: ui, accessibility, css, | administration -------------------------+------------------------------------------------- Changes (by sabernhardt): * Attachment "forum-link-125-percent.png" added. support forum link popup at 125% -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 08:26:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 08:26:13 -0000 Subject: [wp-trac] [WordPress Trac] #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar In-Reply-To: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> References: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> Message-ID: <072.fad4d22250931c2931d2c0aba651f895@wordpress.org> #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar -----------------------------+--------------------------------------- Reporter: severinepozzo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots | Focuses: administration, template -----------------------------+--------------------------------------- Comment (by mikachan): Thanks for reporting! I can't replicate this. I'm using WP 6.1 RC1 and Chrome, and I see this: [[Image(https://cldup.com/9CGSiLscte.png, 200px)]] It looks like you're using a slightly older version of WP 6.1, as I can see that you're missing the Aubergine style variation that was included from Beta 2 onwards. Are you able to update to the latest version of 6.1 (RC1) and let us know what you can see then? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 08:26:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 08:26:14 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.1da3caa891924862c621531efd93fced@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------+------------------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect | Status: reopened (bug) | Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: | Focuses: ui, accessibility, css, | administration -------------------------+------------------------------------------------- Changes (by sabernhardt): * Attachment "53174.6.diff" added. edit negative margin and height breakpoint for taller popup -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 08:28:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 08:28:19 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.717eec91d300145ca8af4cd5a0de01ef@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------+------------------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect | Status: reopened (bug) | Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: has-patch | Focuses: ui, accessibility, css, needs-testing | administration -------------------------+------------------------------------------------- Changes (by sabernhardt): * keywords: => has-patch needs-testing Comment: Increasing the modal height required a few more changes. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 08:56:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 08:56:25 -0000 Subject: [wp-trac] [WordPress Trac] #56812: `wp_get_global_settings` returns default color.palette.theme colors with style variation applied in Version 6.1-RC1-54506 In-Reply-To: <058.d6dcab60a0c2fc38bba015339ee26b2a@wordpress.org> References: <058.d6dcab60a0c2fc38bba015339ee26b2a@wordpress.org> Message-ID: <073.c5e3e5d37e51621b001eb2454ee23543@wordpress.org> #56812: `wp_get_global_settings` returns default color.palette.theme colors with style variation applied in Version 6.1-RC1-54506 ----------------------------+---------------------- Reporter: dufresnesteven | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: trunk Severity: normal | Resolution: invalid Keywords: | Focuses: ----------------------------+---------------------- Changes (by Bernhard Reiter): * status: new => closed * resolution: => invalid Comment: To close the loop, Gutenberg has now been updated to use the new names: https://github.com/WordPress/gutenberg/pull/44940 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 09:14:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 09:14:17 -0000 Subject: [wp-trac] [WordPress Trac] #56838: Deprecated uasort callback in wp_generate_tag_cloud() In-Reply-To: <052.1a962fd2b76413fc73208f39aaac119e@wordpress.org> References: <052.1a962fd2b76413fc73208f39aaac119e@wordpress.org> Message-ID: <067.ecc602c2142cd016ce67f959c8a8cb2c@wordpress.org> #56838: Deprecated uasort callback in wp_generate_tag_cloud() ----------------------------+--------------------- Reporter: skithund | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: php8 has-patch | Focuses: ----------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 09:22:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 09:22:30 -0000 Subject: [wp-trac] [WordPress Trac] #56825: Customiser colour picker and popups broken in 6.1 RC1 In-Reply-To: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> References: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> Message-ID: <070.316ee543dabfde135ca880a995107f04@wordpress.org> #56825: Customiser colour picker and popups broken in 6.1 RC1 -------------------------------+------------------------------ Reporter: tecazwebdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Customize | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Comment (by tecazwebdev): Replying to [comment:1 pbiron]: > Hi @tecazwebdev thanx for the ticket and welcome to trac!!! > > What theme is used on the site in your screenshots? The reason I ask is that it appears that theme uses their own color picker (since those pickers are **very** different from those in WP core).# This is using the Kadence theme. I have sent them a report too. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 10:23:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 10:23:56 -0000 Subject: [wp-trac] [WordPress Trac] #54334: E2E tests for Uploading New Version of Themes & Plugins In-Reply-To: <050.02f5a862b223614d9e43274c6499a29a@wordpress.org> References: <050.02f5a862b223614d9e43274c6499a29a@wordpress.org> Message-ID: <065.e3d747b5a76dae82b0e09fc97df9d256@wordpress.org> #54334: E2E tests for Uploading New Version of Themes & Plugins -------------------------------------------------+------------------------- Reporter: juhise | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: Future | Release Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: refresh | -------------------------------------------------+------------------------- Comment (by juhise): @costdev I made the change, hope it's fine now. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 11:08:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 11:08:19 -0000 Subject: [wp-trac] [WordPress Trac] #56837: Disable automatic embed In-Reply-To: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> References: <049.32077e15f59e7eb29e78d04941c65404@wordpress.org> Message-ID: <064.12c9722f4e413b4dc0deaaff217aa2e9@wordpress.org> #56837: Disable automatic embed -------------------------------+------------------------------ Reporter: da_dj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by da_dj): Replying to [comment:1 costdev]: > Hi @da_dj, welcome to Trac! > > You can paste the link, then click the icon at the left of the toolbar (e.g. the YouTube icon), then "Paragraph" to change the embed back to a link. > > Are you happy with this, or would you like to keep your ticket open to see what others think of disabling automatic embed by default? Hi, thanks for this! I'm happy to keep the ticket open to see if anyone else wants embed disabled by default. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 11:55:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 11:55:22 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.d3135c61a12bd55c216e841b40b0ce32@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Query | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): @peterwilsoncc @desrosj Are you happy for me to commit then? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 12:20:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 12:20:48 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.4f43287c0c90cdf148f5876ba23ffc9c@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch commit dev- | Focuses: ui, accessibility, feedback | docs, administration, ui-copy -------------------------------------+------------------------------------- Comment (by andraganescu): Hey there! I want to signal an inconsistency in the copy. Where it says: > New fallback options in the navigation block mean you can edit the menu that’s open; no searching needed. It should say something like: > New fallback options mean that navigation on your site just works when you try or switch to different themes. Updates in the navigation block enable you to edit the menu that’s open; no searching needed. Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 12:55:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 12:55:41 -0000 Subject: [wp-trac] [WordPress Trac] #53644: WPeditor not fully initialized in a classic metabox In-Reply-To: <048.fde6b34c2abdfb4d2c5a68641c2fcf79@wordpress.org> References: <048.fde6b34c2abdfb4d2c5a68641c2fcf79@wordpress.org> Message-ID: <063.e28e59225054e115262727015d9f2468@wordpress.org> #53644: WPeditor not fully initialized in a classic metabox ---------------------------+------------------------- Reporter: dway | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: TinyMCE | Version: 5.6 Severity: normal | Resolution: worksforme Keywords: needs-testing | Focuses: javascript ---------------------------+------------------------- Comment (by zaantar): I believe this is not fixed at all. It definitely isn't for me. After a very long time, I have a working solution. This function needs to be called after the Gutenberg editor has been fully loaded (which is a task in itself). Sharing here in the hopes it will help someone. Or that someone finds an actual fix to this. Original idea: https://stackoverflow.com/a/34764607 {{{ // An alternative (but awful) workaround is forcing TinyMCE to the HTML mode on every load: // add_filter( 'wp_default_editor', function() { return 'html'; } ); const reinitializeAllWysiwygFields = () => { tinymce.EditorManager.editors.forEach( function( editor ) { // Apparently, TinyMCE does some parts of the reinitialization asynchronously. // // When there is more than one instance, this creates a race condition on its own. Incorrect // settings are loaded for the second and following editors, and the reinitialization breaks. // // That forces us to make an arbitrary pause between reinitialization so that TinyMCE can // execute all its hooks and asynchronous calls in the meantime. setTimeout( () => { const oldGlobalSettings = tinymce.settings; tinymce.settings = editor.settings; tinymce.EditorManager.execCommand( 'mceRemoveEditor', false, editor.id ); tinymce.EditorManager.execCommand( 'mceAddEditor', false, editor.id ); tinymce.settings = oldGlobalSettings; }, 1000 ); } ); }; }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 13:43:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 13:43:02 -0000 Subject: [wp-trac] [WordPress Trac] #56839: Class function details need to improvement in class-wp-media-list-table.php file. Message-ID: <056.1859d2da56be16f6bf074e9e164b071c@wordpress.org> #56839: Class function details need to improvement in class-wp-media-list-table.php file. --------------------------+----------------------------- Reporter: upadalavipul | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: docs | --------------------------+----------------------------- I am checking for all function commenting details for good documentation and well comment and in which I have found one file that needs improvement. please check the below details. file path: wp-admin/includes/class-wp-media-list-table.php function name: display_rows() -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 13:44:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 13:44:29 -0000 Subject: [wp-trac] [WordPress Trac] #56839: Class function details need to improvement in class-wp-media-list-table.php file. In-Reply-To: <056.1859d2da56be16f6bf074e9e164b071c@wordpress.org> References: <056.1859d2da56be16f6bf074e9e164b071c@wordpress.org> Message-ID: <071.f30e14886c3cc2c6402e74479bdf7501@wordpress.org> #56839: Class function details need to improvement in class-wp-media-list-table.php file. --------------------------+------------------------------ Reporter: upadalavipul | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: docs --------------------------+------------------------------ Changes (by upadalavipul): * Attachment "56839.patch" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 14:18:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 14:18:20 -0000 Subject: [wp-trac] [WordPress Trac] #47137: Insufficient form semantics In-Reply-To: <051.617cc3aa26eab7f46d187b484fe308b6@wordpress.org> References: <051.617cc3aa26eab7f46d187b484fe308b6@wordpress.org> Message-ID: <066.074d70851098075ef20e1017c1ca7024@wordpress.org> #47137: Insufficient form semantics -------------------------------------------------+------------------------- Reporter: anevins | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Media | Version: Severity: minor | Resolution: Keywords: needs-patch has-screenshots | Focuses: ui, wpcampus-report form-controls | accessibility -------------------------------------------------+------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted * milestone: Future Release => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 14:19:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 14:19:09 -0000 Subject: [wp-trac] [WordPress Trac] #47148: Insufficient labelling and inappropriate nesting of form controls In-Reply-To: <051.361d9673e949551e89c6288c420e1194@wordpress.org> References: <051.361d9673e949551e89c6288c420e1194@wordpress.org> Message-ID: <066.6758be4cab7e65d70f99f19e4873cf5e@wordpress.org> #47148: Insufficient labelling and inappropriate nesting of form controls -------------------------------------------------+------------------------- Reporter: anevins | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Media | Version: Severity: minor | Resolution: Keywords: has-screenshots needs-patch | Focuses: wpcampus-report form-controls | accessibility -------------------------------------------------+------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted * milestone: Future Release => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 14:25:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 14:25:00 -0000 Subject: [wp-trac] [WordPress Trac] #40909: Focus in attachment custom fields is lost when updating the value. In-Reply-To: <051.3b254ebda8685adebc54442dbc7e7bd9@wordpress.org> References: <051.3b254ebda8685adebc54442dbc7e7bd9@wordpress.org> Message-ID: <066.bb22d647d6d021238e71e3bcb03442f9@wordpress.org> #40909: Focus in attachment custom fields is lost when updating the value. ----------------------------------+---------------------------------------- Reporter: lucymtc | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Media | Version: 4.7.5 Severity: normal | Resolution: Keywords: dev-feedback has- | Focuses: accessibility, javascript patch | ----------------------------------+---------------------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted * focuses: => accessibility, javascript * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 14:29:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 14:29:04 -0000 Subject: [wp-trac] [WordPress Trac] #42874: mediaelement-and-player.min.js javascript errors on Add New Post In-Reply-To: <055.dfb6e18ac76321502eb53f846b01700f@wordpress.org> References: <055.dfb6e18ac76321502eb53f846b01700f@wordpress.org> Message-ID: <070.03b33ebcac481ab984d5372c27c6274b@wordpress.org> #42874: mediaelement-and-player.min.js javascript errors on Add New Post --------------------------+--------------------- Reporter: bluesaphyer | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 4.9.1 Severity: normal | Resolution: fixed Keywords: | Focuses: --------------------------+--------------------- Changes (by joedolson): * status: reopened => closed * resolution: => fixed * milestone: Awaiting Review => 6.1 Comment: Option to mute mediaelement videos added in r54128, against #54788. That update effectively resolves this issue, which is a autoplay policy. We can't force the autoplay to work if it's against browser policies, but you can now set the muted property, so that the video will play. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 14:45:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 14:45:29 -0000 Subject: [wp-trac] [WordPress Trac] #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar In-Reply-To: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> References: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> Message-ID: <072.443ffe0e2fc4ee134a21140466bdc50a@wordpress.org> #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar -----------------------------+--------------------------------------- Reporter: severinepozzo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots | Focuses: administration, template -----------------------------+--------------------------------------- Comment (by Ankit K Gupta): Welcome to the Core Trac @severinepozzo :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 15:06:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 15:06:41 -0000 Subject: [wp-trac] [WordPress Trac] #56840: [WP 6.1 RC1] The permalink format is "plain" by default Message-ID: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> #56840: [WP 6.1 RC1] The permalink format is "plain" by default --------------------------+----------------------------- Reporter: strategio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- In the previous WP versions, the permalink format was set to "Day and name" by default. ### Steps to reproduce - Start from scratch - Complete the WP install wizard - Go to Settings > Permalinks => With WP 6.0.2, it's set to "Day and name" => With WP 6.1 RC1, it's set to "Plain" ### Notes It's not really causing issue to us, but we have an end-to-end test that assumes the permalinks are set to "Day and name" and it started failing as soon as we ran it with WP 6.1 RC1. So this might be a hint that something is wrong in WP 6.1 RC1 (or maybe it's on purpose). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 16:16:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 16:16:09 -0000 Subject: [wp-trac] [WordPress Trac] #56841: WordPress pagination broken after updating to 6.0 Message-ID: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> #56841: WordPress pagination broken after updating to 6.0 -------------------------------+----------------------------- Reporter: wpfed | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 6.0 Severity: normal | Keywords: Focuses: | -------------------------------+----------------------------- The pagination is broken in the admin and front-end. In the admin it's returning incorrect amount of items (E.g., 10 posts are visible in the admin table but pagination is missing and shows there is 4 results only(4 items) but I have over 300 posts. The buttons/input to navigate are missing. This only appears to happen with posts, pages and other list items are displaying correct results with pagination present. I tried switching themes, deactivating all plugins, resetting permalinks, repaired the DB with WP auto repair but still no pagination was present. Rolling back to core 5.9.4 restored pagination. Updating to latest version 6.0.2 also did not help. **Server setup:** nginx/1.19.10 mysqli 5.7.18-15-57-log PHP version 7.4.23 (Supports 64bit values) I'm waiting for my host to update mysql, but it may be a while. I'm in the process of updating PHP to a higher version to see if that could help. Also I took a deeper dive into the DB, saw that it's using latin1 charset(it's a older site), ENGINE=InnoDB and SET sql_mode='NO_AUTO_VALUE_ON_ZERO'; but nothing else of significance. Also checked the error debug log and found this but not sure if that would have a impact. [05-Oct-2022 17:38:12 UTC] WordPress database error Incorrect string value: '\xEF\xBB\xBF WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 16:17:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 16:17:13 -0000 Subject: [wp-trac] [WordPress Trac] #56840: [WP 6.1 RC1] The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.1dc48d95d45b949a4286cfcd7f1f5ecf@wordpress.org> #56840: [WP 6.1 RC1] The permalink format is "plain" by default --------------------------+--------------------- Reporter: strategio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by sabernhardt): * version: => trunk * component: General => Permalinks * milestone: Awaiting Review => 6.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 16:54:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 16:54:09 -0000 Subject: [wp-trac] [WordPress Trac] #54984: wp_update_user doesn't work properly with current user instance In-Reply-To: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> References: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> Message-ID: <066.531e6f52d31a51c3a677305364ba1c43@wordpress.org> #54984: wp_update_user doesn't work properly with current user instance --------------------------+---------------------------- Reporter: oztaser | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Users | Version: 5.8 Severity: normal | Resolution: fixed Keywords: | Focuses: --------------------------+---------------------------- Comment (by SergeyBiryukov): In [changeset:"54544" 54544]: {{{ #!CommitTicketReference repository="" revision="54544" Users: Revert use of shared objects for current user. Reverts [50790]. Props oztaser, ravipatel, dd32, costdev, SergeyBiryukov, tykoted, cu121, xknown. Merges [54397] to the 6.0 branch. Fixes #54984. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 18:07:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 18:07:04 -0000 Subject: [wp-trac] [WordPress Trac] #56841: WordPress pagination broken after updating to 6.0 In-Reply-To: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> References: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> Message-ID: <064.ea0d7386d649598badd4fc56ab99b4e0@wordpress.org> #56841: WordPress pagination broken after updating to 6.0 -------------------------------+------------------------------ Reporter: wpfed | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 6.0 Severity: normal | Resolution: Keywords: | Focuses: -------------------------------+------------------------------ Changes (by wpfed): * Attachment "pagination-broken.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 18:10:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 18:10:19 -0000 Subject: [wp-trac] [WordPress Trac] #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar In-Reply-To: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> References: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> Message-ID: <072.8eca9b7cb0a6647a907b7cb2d48e7648@wordpress.org> #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar -----------------------------+--------------------------------------- Reporter: severinepozzo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-screenshots | Focuses: administration, template -----------------------------+--------------------------------------- Comment (by severinepozzo): Thank you all for your answers. Indeed I was using a platform with 6.1 Beta 1 version. I was able to access 6.1 RC1 and I no longer see the issue. The Aubergine style is indeed present in this new version. This issue can be closed -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 18:39:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 18:39:53 -0000 Subject: [wp-trac] [WordPress Trac] #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar In-Reply-To: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> References: <057.a1592a4d8c74e43334d218c5de02357c@wordpress.org> Message-ID: <072.ed8304576a863c0c6a35fccf94d1f84c@wordpress.org> #56826: Twenty Twenty Three 6.1 beta: Site editor Whisper style displays with scroll bar -----------------------------+--------------------------------------- Reporter: severinepozzo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: trunk Severity: normal | Resolution: invalid Keywords: has-screenshots | Focuses: administration, template -----------------------------+--------------------------------------- Changes (by JeffPaul): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 19:38:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 19:38:22 -0000 Subject: [wp-trac] [WordPress Trac] #56825: Customiser colour picker and popups broken in 6.1 RC1 In-Reply-To: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> References: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> Message-ID: <070.0c41568e208e4430e4bd138032caddcb@wordpress.org> #56825: Customiser colour picker and popups broken in 6.1 RC1 -------------------------------+------------------------------ Reporter: tecazwebdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Customize | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Comment (by pbiron): Replying to [comment:2 tecazwebdev]: > This is using the Kadence theme. I have sent them a report too. I installed Kadence (free) v1.1.30 and can replicate the overlap you are reporting (and also confirmed that the pickers in question are specific to that theme). It's possible that some change in the customizer CSS in 6.1 has caused this problem, so I'm keeping this ticket open for now. @westonruter are you aware of any such CSS changes? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 19:44:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 19:44:01 -0000 Subject: [wp-trac] [WordPress Trac] #56840: [WP 6.1 RC1] The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.35968d0d388251c738861b458b34d90c@wordpress.org> #56840: [WP 6.1 RC1] The permalink format is "plain" by default --------------------------+--------------------- Reporter: strategio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by sabernhardt): The Permalink Settings page had several changes for the upcoming release, but I was able to get the same results ''without'' visiting that page. The default [https://core.trac.wordpress.org/browser/trunk/src/wp- admin/includes/schema.php?rev=54256#L442 schema.php setting] has been blank for years, so the installation process set "Day and Name" pretty permalinks somewhere else in earlier sites (and now that doesn't work). Steps I took for 6.0.2 and 6.1-RC1: 1. Download WordPress .zip packages. 2. Unzip files, add them in local server directory, create a database, and create a wp-config.php file. 3. Complete the WordPress install process for a single site (not network). 4. Visit the Posts listing page, and check the URL on the "Hello World" post's View link. 6.0.2 URL: `http://localhost/wp60a/2022/10/17/hello-world/` 6.1-RC1 URL: `http://localhost/wp61a/?p=1` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 19:47:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 19:47:28 -0000 Subject: [wp-trac] [WordPress Trac] #56840: [WP 6.1 RC1] The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.7057c7810f11a505a1dcbef9e5274560@wordpress.org> #56840: [WP 6.1 RC1] The permalink format is "plain" by default --------------------------+--------------------- Reporter: strategio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Description changed by sabernhardt: Old description: > In the previous WP versions, the permalink format was set to "Day and > name" by default. > > ### Steps to reproduce > - Start from scratch > - Complete the WP install wizard > - Go to Settings > Permalinks > => With WP 6.0.2, it's set to "Day and name" > => With WP 6.1 RC1, it's set to "Plain" > > ### Notes > > It's not really causing issue to us, but we have an end-to-end test that > assumes the permalinks are set to "Day and name" and it started failing > as soon as we ran it with WP 6.1 RC1. > > So this might be a hint that something is wrong in WP 6.1 RC1 (or maybe > it's on purpose). New description: In the previous WP versions, the permalink format was set to "Day and name" by default. ==== Steps to reproduce - Start from scratch - Complete the WP install wizard - Go to Settings > Permalinks => With WP 6.0.2, it's set to "Day and name" => With WP 6.1 RC1, it's set to "Plain" ==== Notes It's not really causing issue to us, but we have an end-to-end test that assumes the permalinks are set to "Day and name" and it started failing as soon as we ran it with WP 6.1 RC1. So this might be a hint that something is wrong in WP 6.1 RC1 (or maybe it's on purpose). -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 20:50:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 20:50:14 -0000 Subject: [wp-trac] [WordPress Trac] #56825: Customiser colour picker and popups broken in 6.1 RC1 In-Reply-To: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> References: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> Message-ID: <070.fb6df1c21a52a85883c407efee2db18d@wordpress.org> #56825: Customiser colour picker and popups broken in 6.1 RC1 -------------------------------+------------------------------ Reporter: tecazwebdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Customize | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Comment (by westonruter): I am not aware, but I haven't been following such changes explicitly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 21:04:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 21:04:03 -0000 Subject: [wp-trac] [WordPress Trac] #56789: Toolbar: screen-reader-shortcut does not have background color until focused In-Reply-To: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> References: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> Message-ID: <070.9e9c9ac9b32bf44f1312ed5ae322ce45@wordpress.org> #56789: Toolbar: screen-reader-shortcut does not have background color until focused --------------------------+--------------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Toolbar | Version: Severity: minor | Resolution: Keywords: | Focuses: accessibility, css --------------------------+--------------------------------- Changes (by sabernhardt): * Attachment "56789.1.patch" added. including common.css for the other admin shortcut links -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 21:11:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 21:11:14 -0000 Subject: [wp-trac] [WordPress Trac] #56825: Customiser colour picker and popups broken in 6.1 RC1 In-Reply-To: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> References: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> Message-ID: <070.5c0a740592e6e52378530b172974fbcf@wordpress.org> #56825: Customiser colour picker and popups broken in 6.1 RC1 -------------------------------+------------------------------ Reporter: tecazwebdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Customize | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Comment (by pbiron): Replying to [comment:4 westonruter]: > I am not aware, but I haven't been following such changes explicitly. My apologies...I thought you were a component maintainer. Pinging David, who is a maintainer :-) @dlh, see comment [comment:3] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 21:47:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 21:47:23 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.86e8cd730d8d1a376558d1ef61891ce4@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ---------------------------------------------+--------------------- Reporter: ryelle | Owner: (none) Type: task (blessed) | Status: new Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs-design-feedback | Focuses: ---------------------------------------------+--------------------- Changes (by ryelle): * keywords: needs-design has-patch => has-patch needs-design-feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 23:30:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 23:30:23 -0000 Subject: [wp-trac] [WordPress Trac] #9883: Password shows under Settings / Writing In-Reply-To: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> References: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> Message-ID: <066.f7ab25979efca256914a4d9b2866daf3@wordpress.org> #9883: Password shows under Settings / Writing -------------------------------------------------+------------------------- Reporter: mastrup | Owner: (none) Type: enhancement | Status: assigned Priority: low | Milestone: Future | Release Component: Administration | Version: 2.7.1 Severity: trivial | Resolution: Keywords: has-patch needs-testing has- | Focuses: ui, testing-info dev-feedback | accessibility -------------------------------------------------+------------------------- Comment (by ironprogrammer): @costdev, the patch addresses the previous items. However, testing further, when the password field is set to visible, the 1Password icon still covers the "crossed-out eye". == Test Report Patch tested: https://github.com/WordPress/wordpress- develop/pull/2070.diff (after update via comment:41) === Environment - Hardware: MacBook Pro Apple M1 Pro - OS: macOS 12.6 - Browser: Safari 16.0 - Server: nginx/1.23.1 - PHP: 7.4.32 - WordPress: 6.1-RC1-54503-src - Password Manager: 1Password 7 v7.9.6 === Actual Results - ✅ Password is hidden on page load, and clicking "eye" icon toggles visibility. - ✅ "Eye" icon is not covered by 1Password 7 suggestion toggle icon. - ✅ Password field is not focused on page load. - ❌ "Eye (crossed-out)" icon is covered by 1Password 7 suggestion toggle icon ''when password is toggled visible''. === Supplemental Artifacts ''Figure 1: Results after patch update; includes password visible toggle'' [[Image(https://cldup.com/b0lZJKe_0m.gif)]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 23:34:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 23:34:57 -0000 Subject: [wp-trac] [WordPress Trac] #56840: [WP 6.1 RC1] The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.4110080c7c674ede10ee24adce30a5cd@wordpress.org> #56840: [WP 6.1 RC1] The permalink format is "plain" by default --------------------------+--------------------- Reporter: strategio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by SergeyBiryukov): Replying to [comment:2 sabernhardt]: > The Permalink Settings page had several changes for the upcoming release, but I was able to get the same results ''without'' visiting that page. The default [https://core.trac.wordpress.org/browser/trunk/src/wp- admin/includes/schema.php?rev=54256#L442 schema.php setting] has been blank for years, so the installation process set "Day and Name" pretty permalinks somewhere else in earlier sites (and now that doesn't work). Right, pretty permalinks are conditionally enabled in `wp_install_maybe_enable_pretty_permalinks()` if the server supports that. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 17 23:42:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 17 Oct 2022 23:42:45 -0000 Subject: [wp-trac] [WordPress Trac] #56775: Can't copy table to Gutenberg WordPress table In-Reply-To: <054.a53d4dcfa87cb758ebc9587301412821@wordpress.org> References: <054.a53d4dcfa87cb758ebc9587301412821@wordpress.org> Message-ID: <069.ad19bdec85381b93d739e1ea0f634d13@wordpress.org> #56775: Can't copy table to Gutenberg WordPress table --------------------------+---------------------- Reporter: programmin | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 6.0.2 Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by ironprogrammer): * keywords: reporter-feedback => * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Gotcha -- glad it's working, and thank you for the follow-up! Yes, the Table block is for building the table directly in the editor, whereas the blank inserter is pretty smart and can accept HTML. Based on your response, LibreOffice Calc tables could be considered as supported in the editor already, so there is no need to report upstream at this time. Closing ticket for now. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 00:06:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 00:06:08 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.dc05db78c96e8b68c62326b906a4ca6e@wordpress.org> #56383: Import Twenty Twenty-Three --------------------------------------+----------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Changes (by desrosj): * status: closed => reopened * resolution: fixed => Comment: Reopening to review the RC2 sync. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 00:07:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 00:07:32 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.590d278b7fa24f4fd9a00cd5d036401c@wordpress.org> #56383: Import Twenty Twenty-Three -------------------------------------------------+------------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback | -------------------------------------------------+------------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests => has-patch has-unit-tests commit dev-feedback Comment: PR looks good. Flagging for a second committer review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 00:09:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 00:09:52 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.ff1607f4c7931731eac21064c7450cf7@wordpress.org> #56383: Import Twenty Twenty-Three -------------------------------------------------+------------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests commit dev-feedback => has-patch has- unit-tests commit dev-reviewed Comment: PR LGTM based on a read through of the code. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 00:11:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 00:11:10 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.8a0ac30ab41777a738eff8fb0d3b9bb9@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Query | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing commit dev-feedback | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests needs-testing => has-patch has-unit- tests needs-testing commit dev-feedback Comment: Marking for commit pending sign-off by a second committer. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 00:11:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 00:11:26 -0000 Subject: [wp-trac] [WordPress Trac] #56840: The permalink format is "plain" by default (was: [WP 6.1 RC1] The permalink format is "plain" by default) In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.8e3ddd65e9d570e68b6e6068dec4bb8b@wordpress.org> #56840: The permalink format is "plain" by default --------------------------+--------------------- Reporter: strategio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 00:35:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 00:35:46 -0000 Subject: [wp-trac] [WordPress Trac] #56540: Twenty Sixteen: Pullquote block text color is not reflected at editor and front side both (was: Twenty Sixteen Pullquote block text color is not reflected at editor and front side both) In-Reply-To: <060.7b94cf1bbb28241e13b5e80c7daf8105@wordpress.org> References: <060.7b94cf1bbb28241e13b5e80c7daf8105@wordpress.org> Message-ID: <075.0dd46daf697ec6e7335e87bdddcb9259@wordpress.org> #56540: Twenty Sixteen: Pullquote block text color is not reflected at editor and front side both ------------------------------+------------------------ Reporter: nidhidhandhukiya | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: 6.0.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: ui, css ------------------------------+------------------------ Changes (by sabernhardt): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Duplicate of #56008. This is already done in r54381. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 00:36:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 00:36:09 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.6e1e2bb3dc4b8250e6d84a1d5939bd3e@wordpress.org> #56383: Import Twenty Twenty-Three -------------------------------------------------+------------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed | -------------------------------------------------+------------------------- Changes (by desrosj): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54629" 54629]: {{{ #!CommitTicketReference repository="" revision="54629" Twenty Twenty-Three: Sync the latest fixes for RC2. For a full list of changes included, see the `twentytwentythree` repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/4ea5d832ec9b684dcbf9ac5e67ff4e9ee5ae1e16...0f273d787481b391d428de671659533642b3aa3c. Props mikachan, beafialho, kafleg, richtabor, poena, annezazu. Fixes #56383. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 01:38:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 01:38:51 -0000 Subject: [wp-trac] [WordPress Trac] #56825: Customiser colour picker and popups broken in 6.1 RC1 In-Reply-To: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> References: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> Message-ID: <070.af28226dc58fb6897347a3e39397d9af@wordpress.org> #56825: Customiser colour picker and popups broken in 6.1 RC1 -------------------------------+------------------------------ Reporter: tecazwebdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Customize | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Comment (by dlh): I'm not aware of any relevant changes, either. The only recent change to the Customize-specific CSS files that I can see is [54188], which seems unlikely to have caused the issue. I also looked through the Kadence theme and noticed that the color picker is using the `` component, among others, from `@wordpress/components` (cool!). My guess would be that a change in the component library is having this side effect, but that's just a guess. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 03:09:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 03:09:25 -0000 Subject: [wp-trac] [WordPress Trac] #56840: The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.e1f60d2b897d7d75dcfdc4c98cc08dac@wordpress.org> #56840: The permalink format is "plain" by default --------------------------+--------------------- Reporter: strategio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by dlh): `wp_install_maybe_enable_pretty_permalinks()` [https://github.com/WordPress/wordpress- develop/blob/4ef9c315c5b7625ca87399f5b91bd229c42ef1cc/src/wp- admin/includes/upgrade.php#L507-L520 looks for the `X-Pingback` header] to determine whether a post is accessible at a "pretty" URL. In [54250], the logic for sending the `X-Pingback` header was moved to `WP::send_headers()`, but that logic relies on `$wp_query`, which isn't globalized in `send_headers()` (unlike in `WP::handle_404()`, where the logic used to be). A `global $wp_query` looks like it'd be enough to address the issue. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 03:28:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 03:28:58 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.f3e4bc500c23a009a873c1a30abb409d@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-testing-info dev- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by nendeb55): @costdev Thanks for the improvement. I have tested it with NULL or empty value inside $value and it seems to work fine. If you are concerned I can add this code. {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 03:42:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 03:42:52 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.2129c04374be6396442c70764fee9f9a@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-testing-info dev- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by costdev): @nendeb55 I may be mistaken on this, so I defer to others more experienced with this feature, but I would assume that `$value` should either be a string, or a string array. The documentation says `$value` is `mixed`, but for deprecated properties, only strings are currently supported. Therefore, if we are going to add back support for arrays, I assume that these should only be string arrays. If that's the case, and we want to remove any incorrect data, then we could do this: {{{#!php {$new_name} = array_filter( $value, 'is_string' ); } }}} or: {{{#!php $value' ), 'x.x.x', ); } $this->{$new_name} = $filtered; } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 03:52:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 03:52:01 -0000 Subject: [wp-trac] [WordPress Trac] #9883: Password shows under Settings / Writing In-Reply-To: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> References: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> Message-ID: <066.292cf589c970e43b7af36c02c4493a56@wordpress.org> #9883: Password shows under Settings / Writing -------------------------------------------------+------------------------- Reporter: mastrup | Owner: (none) Type: enhancement | Status: assigned Priority: low | Milestone: Future | Release Component: Administration | Version: 2.7.1 Severity: trivial | Resolution: Keywords: has-patch needs-testing has- | Focuses: ui, testing-info dev-feedback | accessibility -------------------------------------------------+------------------------- Comment (by costdev): Nicely spotted @ironprogrammer! I've pushed an update to the PR which should handle this. Another test to verify this would be much appreciated! If you have time, could you also test with an RTL language to make sure the alignment of the text and icons is the same? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 08:28:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 08:28:22 -0000 Subject: [wp-trac] [WordPress Trac] #47976: HTML attributes in uppercase show error in widgets In-Reply-To: <053.b0aded5becfb7ed7ffd6e27962c8133d@wordpress.org> References: <053.b0aded5becfb7ed7ffd6e27962c8133d@wordpress.org> Message-ID: <068.c711d28219d47b5422732c9d8f5587fa@wordpress.org> #47976: HTML attributes in uppercase show error in widgets -------------------------------------------------+------------------------- Reporter: sudhir600 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting | Review Component: Widgets | Version: 4.9 Severity: normal | Resolution: invalid Keywords: has-screenshots dev-feedback has- | Focuses: patch | administration -------------------------------------------------+------------------------- Changes (by simkog): * status: new => closed * resolution: => invalid Comment: This is issue is still there when you use the **Classic Widgets** (https://wordpress.org/plugins/classic-widgets/) plugin. \\ [[Image(https://i.imgur.com/l2QMs6t.png)]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 08:29:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 08:29:01 -0000 Subject: [wp-trac] [WordPress Trac] #47976: HTML attributes in uppercase show error in widgets In-Reply-To: <053.b0aded5becfb7ed7ffd6e27962c8133d@wordpress.org> References: <053.b0aded5becfb7ed7ffd6e27962c8133d@wordpress.org> Message-ID: <068.262a7c024fdf0758c8c664de66420e9b@wordpress.org> #47976: HTML attributes in uppercase show error in widgets -------------------------------------------------+------------------------- Reporter: sudhir600 | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting | Review Component: Widgets | Version: 4.9 Severity: normal | Resolution: Keywords: has-screenshots dev-feedback has- | Focuses: patch | administration -------------------------------------------------+------------------------- Changes (by simkog): * status: closed => reopened * resolution: invalid => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 08:35:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 08:35:55 -0000 Subject: [wp-trac] [WordPress Trac] #56825: Customiser colour picker and popups broken in 6.1 RC1 In-Reply-To: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> References: <055.e6f0bc90e32e2bb507662dc59024cc3e@wordpress.org> Message-ID: <070.f7bd6f1aa7b531a7830c2435c1073fb5@wordpress.org> #56825: Customiser colour picker and popups broken in 6.1 RC1 -------------------------------+------------------------------ Reporter: tecazwebdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Customize | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Comment (by tecazwebdev): I have occasionally been testing out the Gutenberg updates, for the last few months, and this glitch presents itself on 6.0 / 6.0.3 with the current Gutenberg installed, so the break has occurred when Gutenberg was merged with 6.1 RC1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 09:49:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 09:49:54 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg Message-ID: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg ------------------------------+----------------------------- Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Keywords: needs-refresh Focuses: performance | ------------------------------+----------------------------- Using Siege benchmark tool to stress WordPress with transaction per second as KPI After upgrading WordPress from v5.9.3 to v6.0, we found that the performance dropped. After experiment on ` git cherry -v 5.9-branch 6.0-branch |cat -n > ~/commits_on_6.0_branch.txt` totally 707 commits, root cause addressed due to commit id ab8a964858e7eba50c2caed21cc9415282f89d14 | NO | Commit ID | Commit Message | Transaction/sec | |-----|------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------|-----------------| | 1 | 5fc6f2a4889ed61149dfcb7adfd5312bb7edd8c1 | Trunk is now 6.0-alpha. Built from https://develop.svn.wordpress.org/trunk at 52448 | 217.25 | | 354 | 7b96116f3fb6938a33f157d53e69cdcdec242694 | Twenty Twenty: Fix aria-expanded handling in search toggle. | 209.71 | | 443 | 476e73194d2e98e477f691e44b9a8e7284c9c175 | Users: Improve wording of the "New Admin Email Address" email. | 212.07 | | 454 | bc0f1865991b856b35b996759837062b84ecb08e | Administration: Clarify some sentences after [53131]. | 207.59 | | 455 | ab8a964858e7eba50c2caed21cc9415282f89d14 | Editor: Update WordPress packages based based on Gutenberg v13.0 RC3 | 186.43 | | 456 | bb723f99206bd1256a10134cd9a74984c33103b4 | Widgets: Avoid 27 duplicate translations in Media Widgets constructor. | 182.69 | | 457 | 4dd4aec2d1b8c17027d38ddca7c6cfd3a961c561 | Administration: Add unit test for term supplementary notice. | 185.76 | | 459 | 1d29cb663289795c6aca5cf8c624db6ac2475b49 | Media: Enable edits to custom image sizes. | 184.88 | | 465 | e1a2ae351a82521d12ef873f614adb42825c6de4 | Post WordPress 6.0 Beta 1 version bump. Built from https://develop.svn.wordpress.org/trunk at 53167 | 184.04 | | 487 | 407e802048a7cf8c1dab6575fc9b828572e24af2 | Docs: Use third- person singular verbs for function descriptions in `author- template.php`, as per documentation standards. | 188.67 | | 531 | 943e956379dd935ad6b401669a4c76526172f594 | Feeds: Use latest comment date for the `Last-Modified` header of comments feed. | 182.66 | | 707 | a9c0050f9475857e80e813d8841052e0dde36efc | Post WordPress 6.0.2 version bump. | 181.87 | -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 09:53:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 09:53:29 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.3d22df539b872fe1c82f89847889797d@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg ------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: needs-refresh | Focuses: performance ------------------------------+------------------------------ Comment (by dylan2intel): git clone https://github.com/dylan2intel/wordpress-performance-issue Follow the README.md file to reproduce the issue. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 10:04:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 10:04:57 -0000 Subject: [wp-trac] [WordPress Trac] #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding In-Reply-To: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> References: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> Message-ID: <063.9bffa9f52125422bf61bff063ac3ae06@wordpress.org> #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding ---------------------------+--------------------- Reporter: vtad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+--------------------- Comment (by mikachan): Thanks for reporting, @vtad! Could you please provide the block markup that you were using? You can copy this by clicking on the three-dot menu for the table block, and then clicking 'Copy block'. I am able to see the padding I've set both in the editor and on the front end, like this: Editor: [[Image(https://cldup.com/UlVQhocrSS.png)]] Front end: [[Image(https://cldup.com/m4yqNxlD_y.png)]] However, I'm not seeing the cell borders. It looks like these are only set within the editor, and not on the front end. I've opened an upstream issue for this: https://github.com/WordPress/gutenberg/issues/45065 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 10:30:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 10:30:03 -0000 Subject: [wp-trac] [WordPress Trac] #56843: Comments in wp-login.php start with an "*" too few. Message-ID: <053.f8d1861b222585819d8466ca519ff1db@wordpress.org> #56843: Comments in wp-login.php start with an "*" too few. --------------------------+----------------------------- Reporter: NekoJonez | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Comments | Version: Severity: minor | Keywords: Focuses: | --------------------------+----------------------------- On line 98, 427, 537 the comment block starts with "/*" while all others start with "/**". -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 11:09:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 11:09:48 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.ce16449961101e9ae0fe7fcbc18239a9@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg --------------------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: has-testing-info needs-testing | Focuses: performance --------------------------------------------+------------------------------ Changes (by costdev): * keywords: needs-refresh => has-testing-info needs-testing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 11:21:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 11:21:35 -0000 Subject: [wp-trac] [WordPress Trac] #56843: Comments in wp-login.php start with an "*" too few. In-Reply-To: <053.f8d1861b222585819d8466ca519ff1db@wordpress.org> References: <053.f8d1861b222585819d8466ca519ff1db@wordpress.org> Message-ID: <068.f3cd0cec65847cc2a722e757013b4a90@wordpress.org> #56843: Comments in wp-login.php start with an "*" too few. --------------------------+------------------------------ Reporter: NekoJonez | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Comments | Version: Severity: minor | Resolution: Keywords: has-patch | Focuses: --------------------------+------------------------------ Comment (by SergeyBiryukov): Hi there, thanks for the ticket! I believe the current format is correct here as per the [https://developer.wordpress.org/coding-standards/inline-documentation- standards/php/ PHP Documentation Standards]: * `/**` is reserved for DocBlocks, for example: {{{ /** * Summary. * * @since x.x.x * @var type $var Description. */ }}} * `/*` is for regular [https://developer.wordpress.org/coding-standards /inline-documentation-standards/php/#5-2-multi-line-comments multi-line comments]: {{{ /* * This is a comment that is long enough to warrant being stretched over * the span of multiple lines. You'll notice this follows basically * the same format as the PHPDoc wrapping and comment block style. */ }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 11:26:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 11:26:43 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.6a1b0bf03311701ab5c7b4ac74523d8f@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg --------------------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: has-testing-info needs-testing | Focuses: performance --------------------------------------------+------------------------------ Description changed by costdev: Old description: > Using Siege benchmark tool to stress WordPress with transaction per > second as KPI > > After upgrading WordPress from v5.9.3 to v6.0, we found that the > performance dropped. > > After experiment on ` git cherry -v 5.9-branch 6.0-branch |cat -n > > ~/commits_on_6.0_branch.txt` totally 707 commits, root cause addressed > due > to commit id ab8a964858e7eba50c2caed21cc9415282f89d14 > > | NO | Commit ID | Commit Message > | Transaction/sec | > |-----|------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------|-----------------| > | 1 | 5fc6f2a4889ed61149dfcb7adfd5312bb7edd8c1 | Trunk is now > 6.0-alpha. Built from https://develop.svn.wordpress.org/trunk at 52448 > | 217.25 | > | 354 | 7b96116f3fb6938a33f157d53e69cdcdec242694 | Twenty Twenty: Fix > aria-expanded handling in search toggle. > | 209.71 | > | 443 | 476e73194d2e98e477f691e44b9a8e7284c9c175 | Users: Improve > wording of the "New Admin Email Address" email. > | 212.07 | > | 454 | bc0f1865991b856b35b996759837062b84ecb08e | Administration: > Clarify some sentences after [53131]. > | 207.59 | > | 455 | ab8a964858e7eba50c2caed21cc9415282f89d14 | Editor: Update > WordPress packages based based on Gutenberg v13.0 RC3 > | 186.43 | > | 456 | bb723f99206bd1256a10134cd9a74984c33103b4 | Widgets: Avoid 27 > duplicate translations in Media Widgets constructor. > | 182.69 | > | 457 | 4dd4aec2d1b8c17027d38ddca7c6cfd3a961c561 | Administration: Add > unit test for term supplementary notice. > | 185.76 | > | 459 | 1d29cb663289795c6aca5cf8c624db6ac2475b49 | Media: Enable edits > to custom image sizes. > | 184.88 | > | 465 | e1a2ae351a82521d12ef873f614adb42825c6de4 | Post WordPress 6.0 > Beta 1 version bump. Built from > https://develop.svn.wordpress.org/trunk at 53167 | > 184.04 | > | 487 | 407e802048a7cf8c1dab6575fc9b828572e24af2 | Docs: Use third- > person singular verbs for function descriptions in `author- > template.php`, as per documentation standards. | 188.67 | > | 531 | 943e956379dd935ad6b401669a4c76526172f594 | Feeds: Use latest > comment date for the `Last-Modified` header of comments feed. > | 182.66 | > | 707 | a9c0050f9475857e80e813d8841052e0dde36efc | Post WordPress 6.0.2 > version bump. > | 181.87 | New description: Using Siege benchmark tool to stress WordPress with transaction per second as KPI After upgrading WordPress from v5.9.3 to v6.0, we found that the performance dropped. After experiment on ` git cherry -v 5.9-branch 6.0-branch |cat -n > ~/commits_on_6.0_branch.txt` totally 707 commits, root cause addressed due to [https://github.com/WordPress/wordpress- develop/commit/bab610091d59f6dd21c7db84ba3e1ca0bab6a211 this commit]. ||= NO =||= Commit ID =||= Commit Message =||= Transaction/sec =|| || 1 || 5fc6f2a || Trunk is now 6.0-alpha. Built from [https://develop.svn.wordpress.org/trunk at 52448 52448] || 217.25 || || 354 || 7b96116 || Twenty Twenty: Fix aria-expanded handling in search toggle. || 209.71 || || 443 || 476e731 || Users: Improve wording of the "New Admin Email Address" email. || 212.07 || || 454 || bc0f186 || Administration: Clarify some sentences after [53131]. || 207.59 || || 455 || ab8a964 || Editor: Update WordPress packages based based on Gutenberg v13.0 RC3 || 186.43 || || 456 || bb723f9 || Widgets: Avoid 27 duplicate translations in Media Widgets constructor. || 182.69 || || 457 || 4dd4aec || Administration: Add unit test for term supplementary notice. || 185.76 || || 459 || 1d29cb6 || Media: Enable edits to custom image sizes. || 184.88 || || 465 || e1a2ae3 || Post WordPress 6.0 Beta 1 version bump. Built from [https://develop.svn.wordpress.org/trunk at 53167 53167] || 184.04 || || 487 || 407e802 || Docs: Use third-person singular verbs for function descriptions in `author-template.php`... || 188.67 || || 531 || 943e956 || Feeds: Use latest comment date for the `Last- Modified` header of comments feed. || 182.66 || || 707 || a9c0050 || Post WordPress 6.0.2 version bump. || 181.87 || -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 11:50:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 11:50:57 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.f770767fe162a6722f9131b3a5192b91@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg --------------------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: has-testing-info needs-testing | Focuses: performance --------------------------------------------+------------------------------ Comment (by mukesh27): @dylan2intel Can you please share clear steps so we can reproduce the issue? Can you please improve this steps https://github.com/dylan2intel /wordpress-performance-issue#how-to-reproduce-the-issue? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:00:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:00:31 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.1f6d12abc83f6c908f88c450b15899fa@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-testing-info dev- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by nendeb55): @costdev Thank you for the improvement. I hope this is the kind of code you're looking for to organize it. {{{#!php deprecated_properties ) ) { $this->{$name} = $value; return; } $new_name = $name . '_handles'; if ( is_array( $value ) ) { $filtered = array_filter( $value, 'is_string' ); if ( count( $filtered ) !== count( $value ) ) { _doing_it_wrong( __METHOD__, sprintf( /* translators: %s: The '$value' argument. */ __( 'The %s argument must be a string or a string array.' ), '$value' ), '6.1.0', ); } $this->{$new_name} = $filtered; return; } if ( ! is_string( $value ) ) { return; } $this->{$new_name}[0] = $value; } }}} Tested. It worked correctly. Will this be reflected in WordPress 6.1? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:07:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:07:38 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.474d4fd26d1235a077da0048f7c146f9@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: needs-testing has-testing-info dev- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by costdev): Thanks @nendeb55! > Will this be reflected in WordPress 6.1? As this is a regression introduced in 6.1, I hope so. We'll need some feedback from others who worked on this feature and I believe it will need to be patched in the Gutenberg GitHub repository. I'll highlight this ticket with the 6.1 release squad to help move this forward. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:19:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:19:54 -0000 Subject: [wp-trac] [WordPress Trac] #56835: Increase test coverage to WP_Theme_JSON_Resolver In-Reply-To: <056.fbe9a1e097ac44bb8eb9c0fa0770c9cb@wordpress.org> References: <056.fbe9a1e097ac44bb8eb9c0fa0770c9cb@wordpress.org> Message-ID: <071.e3faf647c9992635b150a84b0b6bb053@wordpress.org> #56835: Increase test coverage to WP_Theme_JSON_Resolver --------------------------------------+----------------------------- Reporter: cbravobernal | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Themes | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"54630" 54630]: {{{ #!CommitTicketReference repository="" revision="54630" Tests: Increase test coverage for `WP_Theme_JSON_Resolver`. This commit adds a unit test to check that `WP_Theme_JSON_Resolver::get_theme_data()` returns a `WP_Theme_JSON` object, and that an `add_theme_support()` call overrides the settings from `theme.json`. Follow-up to [54443], [54493]. Props cbravobernal. Fixes #56835. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:29:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:29:17 -0000 Subject: [wp-trac] [WordPress Trac] #56835: Increase test coverage to WP_Theme_JSON_Resolver In-Reply-To: <056.fbe9a1e097ac44bb8eb9c0fa0770c9cb@wordpress.org> References: <056.fbe9a1e097ac44bb8eb9c0fa0770c9cb@wordpress.org> Message-ID: <071.b30603eabcde56054ed71d805b0fbfd2@wordpress.org> #56835: Increase test coverage to WP_Theme_JSON_Resolver --------------------------------------+----------------------------- Reporter: cbravobernal | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Themes | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Comment (by SergeyBiryukov): In [changeset:"54631" 54631]: {{{ #!CommitTicketReference repository="" revision="54631" Tests: Correct the `wp_theme_json_data_default` filter name in assertion messages. The `theme_json_default` filter was previously renamed to `wp_theme_json_data_default`. This commit updates the messages in `WP_Theme_JSON_Resolver` tests to match the new name. Follow-up to [54501], [54630]. See #56796, #56835. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:29:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:29:18 -0000 Subject: [wp-trac] [WordPress Trac] #56796: Naming of filters in `class-wp-theme-json-resolver.php` (`theme_json_*`) In-Reply-To: <050.d944d7581aeed87e5660fc83b6187d9a@wordpress.org> References: <050.d944d7581aeed87e5660fc83b6187d9a@wordpress.org> Message-ID: <065.5f8f4e9ea2037d31033d26ffca8f27b6@wordpress.org> #56796: Naming of filters in `class-wp-theme-json-resolver.php` (`theme_json_*`) ------------------------------+----------------------------- Reporter: kebbet | Owner: hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: ------------------------------+----------------------------- Comment (by SergeyBiryukov): In [changeset:"54631" 54631]: {{{ #!CommitTicketReference repository="" revision="54631" Tests: Correct the `wp_theme_json_data_default` filter name in assertion messages. The `theme_json_default` filter was previously renamed to `wp_theme_json_data_default`. This commit updates the messages in `WP_Theme_JSON_Resolver` tests to match the new name. Follow-up to [54501], [54630]. See #56796, #56835. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:32:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:32:32 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.2e43266f08c5eb190568cf614ad72aef@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg --------------------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: has-testing-info needs-testing | Focuses: performance --------------------------------------------+------------------------------ Comment (by dylan2intel): 1. Install docker & kubernetes, pls. refer to https://www.cloudsigma.com /how-to-install-and-use-kubernetes-on-ubuntu-20-04/ 2. git clone https://github.com/dylan2intel/wordpress-performance- issue.git wp-perf-drop 3. cd wp-perf-drop; ./deploy apply # This step will deploy WordPress on kubernetes 4. cd wp-perf-drop; docker build -t siege . 5. cd wp-perf-drop; docker build -t siege . -f Dockerfile.siege 6. docker run -it siege -c 100 -t 60S http://10.166.30.137:30080 > output-5.9.3.log # This step will simulate 100 concurrent users stressing on wordpress with 60 seconds duration. 7. cd cd wp-perf-drop; sed -i 's/wordpress:5.9.3-php7.4/wordpress:6.0-php7.4/' wordpress-deployment.yaml 8. cd cd wp-perf-drop; ./deploy destory # This step will destory WordPress on kubernetes 9. Re-run step 3 # This step will re-deploy wordpress with version 6.0 10. docker run -it siege -c 100 -t 60S http://10.166.30.137:30080 > output-6.0.log 11. cat output-5.9.3.log |grep 'trans/sec' && cat output-6.0.log |grep 'trans/sec' -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:40:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:40:25 -0000 Subject: [wp-trac] [WordPress Trac] #56762: PHP file being ignored in block theme hierarchy In-Reply-To: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> References: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> Message-ID: <072.851e1b730490cc7fdd9e55e3ded2c827@wordpress.org> #56762: PHP file being ignored in block theme hierarchy ---------------------------+------------------------------ Reporter: ryanpluckrose | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.0.2 Severity: major | Resolution: Keywords: needs-patch | Focuses: template ---------------------------+------------------------------ Comment (by ryanpluckrose): This seems to be a problem everywhere I turn, I'm having the same issue with template-parts If I have a custom template part that is a html file, it works fine but if I change it to php, I get `Template part has been deleted or is unavailable` Is no one else experiencing this? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:42:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:42:25 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.fc9163fbd468c4d722330b39acb335e7@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg --------------------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: has-testing-info needs-testing | Focuses: performance --------------------------------------------+------------------------------ Comment (by dylan2intel): Actually directly install WordPress on your host machine is also acceptable, deploy on docker or kubernetes is another deployment. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:50:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:50:59 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.f273dddd232f58d855b6c32cee5fb85b@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Query | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing commit dev-reviewed | performance -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-unit-tests needs-testing commit dev-feedback => has-patch has-unit-tests needs-testing commit dev-reviewed Comment: Looks good to me! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:54:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:54:19 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.fdbfc0c05970636ad981277601c1d9d2@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: feedback commit | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54632" 54632]: {{{ #!CommitTicketReference repository="" revision="54632" Editor: Update packages for 6.1 Release Candidate 2. Package updates for bug and regression fixes: - `@wordpress/block-directory: 3.15.8` - `@wordpress/block-editor: 10.0.7` - `@wordpress/block-library: 7.14.8` - `@wordpress/components: 21.0.6` - `@wordpress/customize-widgets: 3.14.8` - `@wordpress/edit-post: 6.14.8` - `@wordpress/edit-site: 4.14.10` - `@wordpress/edit-widgets: 4.14.8` - `@wordpress/editor: 12.16.7` - `@wordpress/format-library: 3.15.7` - `@wordpress/interface: 4.16.6` - `@wordpress/list-reusable-blocks: 3.15.6` - `@wordpress/nux: 5.15.6` - `@wordpress/preferences: 2.9.6` - `@wordpress/reusable-blocks: 3.15.7` - `@wordpress/server-side-render: 3.15.6` - `@wordpress/widgets: 2.15.7` Original PRs from Gutenberg repository: - [https://github.com/WordPress/gutenberg/pull/45041 #45041 Font Size Picker Hint: Fallback to font size `slug` if `name` is undefined] - [https://github.com/WordPress/gutenberg/pull/45045 #45045 Add: Missing output escaping on some blocks] - [https://github.com/WordPress/gutenberg/pull/44999 #44999 Escape comment author URL] - [https://github.com/WordPress/gutenberg/pull/44972 #44972 Navigator: restore focus only once per location] - [https://github.com/WordPress/gutenberg/pull/44858 #44858 Spacing Sizes Control: Try improving layout spacing] - [https://github.com/WordPress/gutenberg/pull/44878 #44878 Fix: Inspector is usable on the top level block even if it is content locked] - [https://github.com/WordPress/gutenberg/pull/44809 #44809 Fix list outdents on Enter in quote block] - [https://github.com/WordPress/gutenberg/pull/44864 #44864 List v2: fix selection when creating paragraph from empty list item] - [https://github.com/WordPress/gutenberg/pull/44853 #44853 Fix overflowing patterns] - [https://github.com/WordPress/gutenberg/pull/45050 #45050 Fix visibility of nested Group block appender] - [https://github.com/WordPress/gutenberg/pull/44887 #44887 wp-env: Use case insensitive regex when checking WP version string] Follow-up to [54257], [54335], [54383], [54483], [54486], [54490]. Props bernhard-reiter, audrasjb. See #56467. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:59:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:59:10 -0000 Subject: [wp-trac] [WordPress Trac] #56840: The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.26e987c812c3a8bd43ae749953f1c100@wordpress.org> #56840: The permalink format is "plain" by default --------------------------+--------------------- Reporter: strategio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * Attachment "56840.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 13:59:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 13:59:25 -0000 Subject: [wp-trac] [WordPress Trac] #56815: Massive (potential) performance issues within get_default_block_editor_settings In-Reply-To: <052.3bdf31ee353471060ca1147ccd596b93@wordpress.org> References: <052.3bdf31ee353471060ca1147ccd596b93@wordpress.org> Message-ID: <067.5318dff368b18930f66d88634b11c202@wordpress.org> #56815: Massive (potential) performance issues within get_default_block_editor_settings -------------------------------------+------------------------------------- Reporter: janthiel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Editor | Version: 6.0 Severity: major | Resolution: Keywords: needs-patch 2nd-opinion | Focuses: multisite, performance -------------------------------------+------------------------------------- Changes (by desrosj): * version: trunk => 6.0 * milestone: 6.1 => 6.1.1 Comment: The `Version` field is for the first version of WordPress affected by a problem. While it does exist in `trunk`, the important piece of information is where it was introduced. I've updated the field to `6.0` as that's the version you've described above. While it is unfortunate, this is being raised too late in the release cycle to be addressed in 6.1. The Release Candidate phase is only for addressing regressions introduced during the current release cycle. But, investigating this is important. So I am moving the ticket to 6.1.1 for continued visibility. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:00:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:00:30 -0000 Subject: [wp-trac] [WordPress Trac] #56840: The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.f6235c51c7df9eb4e15533336bf5cdc0@wordpress.org> #56840: The permalink format is "plain" by default ----------------------------------------+----------------------------- Reporter: strategio | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: ----------------------------------------+----------------------------- Changes (by SergeyBiryukov): * keywords: => has-patch needs-unit-tests * owner: (none) => SergeyBiryukov * status: new => accepted Comment: Replying to [comment:6 dlh]: > In [54250], the logic for sending the `X-Pingback` header was moved to `WP::send_headers()`, but that logic relies on `$wp_query`, which isn't globalized in `send_headers()` (unlike in `WP::handle_404()`, where the logic used to be). A `global $wp_query` looks like it'd be enough to address the issue. Great catch, thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:04:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:04:10 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.c5002f8e9d18abdded0ef412802399ee@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+------------------------------ Reporter: Bernhard Reiter | Owner: Bernhard Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Changes (by desrosj): * keywords: has-patch has-unit-tests dev-feedback commit => has-patch has- unit-tests Comment: Resetting the action-based keywords so the status is accurately depicted in ticket reports. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:10:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:10:03 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.501bbafff8605fae4bded486d7db6713@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: reviewed | -------------------------------------------------+------------------------- Changes (by Bernhard Reiter): * keywords: has-patch has-unit-tests => has-patch has-unit-tests dev- reviewed Comment: Noting that I've reviewed and [https://github.com/WordPress/wordpress- develop/pull/3430#pullrequestreview-1145886503 approved] https://github.com/WordPress/wordpress-develop/pull/3430. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:16:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:16:15 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.63188d4e8de1a9aca9580496254303db@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg --------------------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: has-testing-info needs-testing | Focuses: performance --------------------------------------------+------------------------------ Comment (by TimothyBlynJacobs): Have you tested on 6.1 RC1? There have been performance improvements committed for Gutenberg specifically that may improve the situation. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:24:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:24:50 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.084dcc54d68d997eed07cb84769497a2@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch commit dev- | Focuses: ui, accessibility, reviewed | docs, administration, ui-copy -------------------------------------+------------------------------------- Changes (by audrasjb): * keywords: has-patch commit dev-feedback => has-patch commit dev-reviewed Comment: [double committer sign off] PR 3461 looks good to me @ryelle 👍 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:31:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:31:17 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.4341bc2e33341102acc1644f89babf88@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg --------------------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: has-testing-info needs-testing | Focuses: performance --------------------------------------------+------------------------------ Comment (by dylan2intel): Indeed, I tried, the performance also dropped on 6.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:35:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:35:27 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.5c7c9855068f59d5c627f6e776a25d37@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 -------------------------------------------+--------------------- Reporter: ryelle | Owner: (none) Type: task (blessed) | Status: new Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch commit dev-feedback | Focuses: -------------------------------------------+--------------------- Changes (by ryelle): * keywords: has-patch needs-design-feedback => has-patch commit dev- feedback Comment: design approved, now it just needs 2nd committer sign off. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:36:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:36:06 -0000 Subject: [wp-trac] [WordPress Trac] #56844: WordPress Autoupdate Email Showing Incorrect Site Name with URL Message-ID: <053.3d25a60e800071e7e6c21ef671f62cd3@wordpress.org> #56844: WordPress Autoupdate Email Showing Incorrect Site Name with URL -----------------------------+----------------------------- Reporter: rhyswynne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 6.0.3 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- I develop websites for clients, and they're hosted on a staging site (staging.domain.com). After logging onto one of the sites today to work on a client's website, I got an email pinged to me, where it's title and URL didn't match. To give you an example, the email is in this format. {{{ Title: [Client 1] Your site has updated to WordPress 6.0.3 Body: Howdy! Your site at https://staging.domain.com/client2 has been updated automatically to WordPress 6.0.3. No further action is needed on your part. For more on version 6.0.3, see the About WordPress screen: https://staging.domain.com/client2/wp-admin/about.php If you experience any issues or need support, the volunteers in the WordPress.org support forums may be able to help. https://wordpress.org/support/forums/ You also have some plugins or themes with updates available. Update them now: https://staging.domain.com/client2/wp-admin/ }}} When it should be {{{ Title: **[Client 2]** Your site has updated to WordPress 6.0.3 Body: Howdy! Your site at https://staging.domain.com/client2 has been updated automatically to WordPress 6.0.3. No further action is needed on your part. For more on version 6.0.3, see the About WordPress screen: https://staging.domain.com/client2/wp-admin/about.php If you experience any issues or need support, the volunteers in the WordPress.org support forums may be able to help. https://wordpress.org/support/forums/ You also have some plugins or themes with updates available. Update them now: https://staging.domain.com/client2/wp-admin/ }}} Going to other clients gets the URL correct upon upgrading, but the title is incorrect. I've checked the database(s) to see if Client 1's name appeared in Client 2's database, but it doesn't. I've also cleared caching (it's hosted with Siteground), but it seems to not be the case. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:36:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:36:54 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options Message-ID: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options --------------------------------+----------------------------- Reporter: pavelschoffer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: trunk Severity: critical | Keywords: Focuses: | --------------------------------+----------------------------- This change (https://core.trac.wordpress.org/ticket/37181) changed the way multisite options are retrieved and cached in trunk (to be released in 6.1.). The old code used to put to cache each requested site meta (=network option) separately under a key: `:` so for example `1:site_name`. The new code fetches all the options for the given network_id (not just the one you are asking for) and saves the whole set of them under one key `:site_meta:` so `:site_meta:1`. Where the value in the cache would be: ``` { "site_name": '...', "option2", '...', ... } ``` The outcome of this change is that if the cumulative size of ALL site options is bigger than 1MB (default limit of memcached per object) NONE of the options will be cached. Would it be possible to revert the change and/or make the cache key per- site versus per-site-and-option-key optional? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:42:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:42:27 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options In-Reply-To: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> References: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> Message-ID: <072.2a5babb66b02e0ad0a7e2fe8e80ba580@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options --------------------------------+------------------------------ Reporter: pavelschoffer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: trunk Severity: critical | Resolution: Keywords: | Focuses: --------------------------------+------------------------------ Description changed by desrosj: Old description: > This change (https://core.trac.wordpress.org/ticket/37181) changed the > way multisite options are retrieved and cached in trunk (to be released > in 6.1.). > > The old code used to put to cache each requested site meta (=network > option) separately under a key: `:` so for > example `1:site_name`. > > The new code fetches all the options for the given network_id (not just > the one you are asking for) and saves the whole set of them under one key > `:site_meta:` so `:site_meta:1`. Where the value in the cache > would be: > > ``` > { > "site_name": '...', > "option2", '...', > ... > } > ``` > > The outcome of this change is that if the cumulative size of ALL site > options is bigger than 1MB (default limit of memcached per object) NONE > of the options will be cached. > > Would it be possible to revert the change and/or make the cache key per- > site versus per-site-and-option-key optional? New description: This change (https://core.trac.wordpress.org/ticket/37181) changed the way multisite options are retrieved and cached in trunk (to be released in 6.1.). The old code used to put to cache each requested site meta (=network option) separately under a key: `:` so for example `1:site_name`. The new code fetches all the options for the given network_id (not just the one you are asking for) and saves the whole set of them under one key `:site_meta:` so `:site_meta:1`. Where the value in the cache would be: {{{ { "site_name": '...', "option2", '...', ... } }}} The outcome of this change is that if the cumulative size of ALL site options is bigger than 1MB (default limit of memcached per object) NONE of the options will be cached. Would it be possible to revert the change and/or make the cache key per- site versus per-site-and-option-key optional? -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:42:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:42:43 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options In-Reply-To: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> References: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> Message-ID: <072.dde5d6e07b2ae708fc99d799995216cb@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options --------------------------------+--------------------- Reporter: pavelschoffer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Options, Meta APIs | Version: trunk Severity: critical | Resolution: Keywords: | Focuses: --------------------------------+--------------------- Changes (by desrosj): * milestone: Awaiting Review => 6.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:45:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:45:42 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.8289e847d4d7d1127f489246f153f628@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: reviewed | -------------------------------------------------+------------------------- Comment (by davidbaumwald): In [changeset:"54633" 54633]: {{{ #!CommitTicketReference repository="" revision="54633" Editor: Fix legacy group inner block wrappers in constrained layouts. Reviewed by bernhard-reiter. Props isabel_brison, noisysocks, andrewserong, poena, bernhard-reiter. See #56467. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:46:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:46:16 -0000 Subject: [wp-trac] [WordPress Trac] #56844: WordPress Autoupdate Email Showing Incorrect Site Name with URL In-Reply-To: <053.3d25a60e800071e7e6c21ef671f62cd3@wordpress.org> References: <053.3d25a60e800071e7e6c21ef671f62cd3@wordpress.org> Message-ID: <068.8b5890cc94a16096fe1e6157838c28af@wordpress.org> #56844: WordPress Autoupdate Email Showing Incorrect Site Name with URL -------------------------------+------------------------------ Reporter: rhyswynne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 6.0.3 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by desrosj): * keywords: => reporter-feedback Comment: Hi @rhyswynne, It appears like it may be, but could you confirm whether this is a multisite install? That would help debug this issue, I think. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:46:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:46:24 -0000 Subject: [wp-trac] [WordPress Trac] #56843: Comments in wp-login.php start with an "*" too few. In-Reply-To: <053.f8d1861b222585819d8466ca519ff1db@wordpress.org> References: <053.f8d1861b222585819d8466ca519ff1db@wordpress.org> Message-ID: <068.8e14b6039ef7a4f0c3b6ded0288c2640@wordpress.org> #56843: Comments in wp-login.php start with an "*" too few. --------------------------+------------------------------ Reporter: NekoJonez | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Comments | Version: Severity: minor | Resolution: Keywords: has-patch | Focuses: --------------------------+------------------------------ Comment (by NekoJonez): @SergeyBiryukov Am I then correct in understanding that my changes aren't needed? Personally, I find it strange to have a difference between them. But that might be just me. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:48:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:48:40 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options In-Reply-To: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> References: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> Message-ID: <072.09af1513fa440402add4322dd6ec34ee@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options --------------------------------+--------------------- Reporter: pavelschoffer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Options, Meta APIs | Version: trunk Severity: critical | Resolution: Keywords: | Focuses: --------------------------------+--------------------- Comment (by rebasaurus): > The outcome of this change is that if the cumulative size of ALL site options is bigger than 1MB (default limit of memcached per object) NONE of the options will be cached. If none of the options end up being cached, it will attempt to add them to the cache on each request (e.g. if it never succeeds, it will continue to do so over and over). A sample stacktrace would be: `get_network_option()` -> `get_metadata_raw()` -> `update_meta_cache()` -> `wp_cache_add_multiple()` -> `wp_cache_add()` -> `MemcachePool->add()` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:51:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:51:55 -0000 Subject: [wp-trac] [WordPress Trac] #56844: WordPress Autoupdate Email Showing Incorrect Site Name with URL In-Reply-To: <053.3d25a60e800071e7e6c21ef671f62cd3@wordpress.org> References: <053.3d25a60e800071e7e6c21ef671f62cd3@wordpress.org> Message-ID: <068.44604ad45b8b5781ded52d4ea1585f56@wordpress.org> #56844: WordPress Autoupdate Email Showing Incorrect Site Name with URL -------------------------------+------------------------------ Reporter: rhyswynne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 6.0.3 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by rhyswynne): They are all separate installations @desrosj . -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 14:52:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 14:52:56 -0000 Subject: [wp-trac] [WordPress Trac] #56844: WordPress Autoupdate Email Showing Incorrect Site Name with URL In-Reply-To: <053.3d25a60e800071e7e6c21ef671f62cd3@wordpress.org> References: <053.3d25a60e800071e7e6c21ef671f62cd3@wordpress.org> Message-ID: <068.a759a0d823f79e569d9a8cf3666665b6@wordpress.org> #56844: WordPress Autoupdate Email Showing Incorrect Site Name with URL -----------------------------+------------------------------ Reporter: rhyswynne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 6.0.3 Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Changes (by rhyswynne): * keywords: reporter-feedback => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:05:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:05:43 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options In-Reply-To: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> References: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> Message-ID: <072.8eff1e2a1296a35b0ca27f42987f8188@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options --------------------------------+------------------------------------- Reporter: pavelschoffer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Options, Meta APIs | Version: trunk Severity: critical | Resolution: Keywords: | Focuses: multisite, performance --------------------------------+------------------------------------- Changes (by johnbillion): * focuses: => multisite, performance -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:07:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:07:03 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.3464174e5db81cc51c1a3b6e7baa61ee@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | spacedmonkey Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Query | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs- | Focuses: testing commit dev-reviewed | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * owner: (none) => spacedmonkey * status: new => closed * resolution: => fixed Comment: In [changeset:"54634" 54634]: {{{ #!CommitTicketReference repository="" revision="54634" Query: Remove placeholder from query cache key. Remove escape placeholder from query cache key, as placeholders are a based on a unique id on every request. This means that it is impossible for a cache to be reused, making queries that use escape placeholders such as `LIKE` searches, unable to be cached. Props dhl, spacedmonkey, peterwilsoncc, desrosj, chaion07, davidbaumwald, mukesh27. Fixes #56802. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:08:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:08:52 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.cad2e57b500726d6c1c263d6cfb1b1a9@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch commit dev- | Focuses: ui, accessibility, reviewed | docs, administration, ui-copy -------------------------------------+------------------------------------- Comment (by ryelle): In [changeset:"54635" 54635]: {{{ #!CommitTicketReference repository="" revision="54635" Help/About: Update copy & style for About page and subpages. Add in missing links and fix incorrect copy. Remove the "header & footer patterns" section. Fix the icons in the feature grid. Add images using temporary links for now. Update the header artwork for About, Credits, Freedoms, and Privacy. See #56357. Reviewed by audrasjb. Props courane01, bph, webcommsat, audrasjb, dansoschin, richtabor. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:15:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:15:07 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.3d4bb7b12dd28902f394ea886f2cf1bd@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+------------------------------ Reporter: Bernhard Reiter | Owner: Bernhard Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Changes (by davidbaumwald): * keywords: has-patch has-unit-tests dev-reviewed => has-patch has-unit- tests Old description: > * Update `@wordpress` packages with packages published from Gutenberg. > * Backport PHP changes from Gutenberg's `lib/compat/wordpress-6.1/` > files. New description: ***** Update `@wordpress` packages with packages published from Gutenberg. * Backport PHP changes from Gutenberg's `lib/compat/wordpress-6.1/` files. -- Comment: Resetting the keywords after r54633. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:16:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:16:37 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.4b84d7d65e57abf7124b19f7eb7a5ad9@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, accessibility, docs, | administration, ui-copy -------------------------+------------------------------------------------- Changes (by ryelle): * keywords: has-patch commit dev-reviewed => Comment: There are two (known) issues remaining: - Updating the link for the **release video** (in two places, can find `"#"` and `'#'`). @annezazu Last release you had this info, are you the point of contact again? - Moving the images to the s.w.org CDN and updating the URLs. @richtabor I'm waiting on an OK from design that these are the final images. And the Welcome panel is going to look awkward until the PR at #56703 is merged. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:17:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:17:51 -0000 Subject: [wp-trac] [WordPress Trac] #56840: The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.1e4b364a47675744a1f2c3c5857ad9e2@wordpress.org> #56840: The permalink format is "plain" by default ----------------------------------------+----------------------------- Reporter: strategio | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: ----------------------------------------+----------------------------- Changes (by SergeyBiryukov): * Attachment "56840.2.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:18:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:18:19 -0000 Subject: [wp-trac] [WordPress Trac] #56840: The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.7e4676772e169138aa66f9cd521a3be3@wordpress.org> #56840: The permalink format is "plain" by default -------------------------------------------------+------------------------- Reporter: strategio | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-patch needs-unit-tests => has-patch has-unit-tests commit dev-feedback Comment: [attachment:"56840.2.diff"] includes a unit test. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:25:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:25:42 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.845f2c0d5f3f8284088fc0384285af57@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: | davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note dev-feedback | -------------------------------------------------+------------------------- Comment (by chaion07): Thanks @maksimkuzmin for reporting this. We reviewed this ticket during a recent bug-scrub session. Based on the feedback received we are happy to sit this one out a bit more considering the following: 01. @davidbaumwald is awaiting a feedback from @SergeyBiryukov for a better naming. 02. @peterwilsoncc had some interest on this as well. 03. Stating that there are no objections yet. Cheers! Props to @desrosj @davidbaumwald for the discussion. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:32:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:32:56 -0000 Subject: [wp-trac] [WordPress Trac] #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding In-Reply-To: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> References: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> Message-ID: <063.9dcb0c7b37bae6598a9c52627401aec2@wordpress.org> #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding -------------------------------+--------------------- Reporter: vtad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: trunk Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+--------------------- Changes (by desrosj): * keywords: => reporter-feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:41:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:41:50 -0000 Subject: [wp-trac] [WordPress Trac] #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding In-Reply-To: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> References: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> Message-ID: <063.3ac14c95bd4ef105c90ee9180133c650@wordpress.org> #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding -------------------------------+--------------------- Reporter: vtad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: trunk Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+--------------------- Comment (by mikachan): I think I've tracked this padding issue down to the changes in https://github.com/WordPress/gutenberg/pull/44640, where we removed the theme.css from loading in the editor if the theme does not opt into block styles. I believe this is the correct behaviour for now. To improve this specifically for the table block, perhaps we could always include that default padding value on both the front end and in the editor since it's not currently editable via Global Styles? I've tried this in a PR here: https://github.com/WordPress/gutenberg/pull/45069 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 15:57:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 15:57:17 -0000 Subject: [wp-trac] [WordPress Trac] #56840: The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.1f09440c3708839a921b03b2839e230d@wordpress.org> #56840: The permalink format is "plain" by default -------------------------------------------------+------------------------- Reporter: strategio | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-unit-tests commit dev-feedback => has-patch has- unit-tests commit dev-reviewed Comment: LGTM. Thanks for working on this Sergey! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:00:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:00:31 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options In-Reply-To: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> References: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> Message-ID: <072.07fad70daa5260cb9dd3fffc5ef2b9d2@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options --------------------------------+------------------------------------- Reporter: pavelschoffer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Options, Meta APIs | Version: trunk Severity: critical | Resolution: Keywords: | Focuses: multisite, performance --------------------------------+------------------------------------- Comment (by johnbillion): Another concern is that upon updating to 6.1, all existing network option caches will be invalidated because the cache key has changed. That might cause a stampede on sites that are caching a lot of data in network options. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:00:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:00:50 -0000 Subject: [wp-trac] [WordPress Trac] #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding within the celss (was: Twenty Twenty-Three: 6.1 RC1 ignores padding) In-Reply-To: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> References: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> Message-ID: <063.6d1eda219620c39c9e69d815c4ab5c8f@wordpress.org> #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding within the celss -------------------------------+--------------------- Reporter: vtad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: trunk Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+--------------------- Comment (by vtad): The table block {{{
123
DAX – Tageschart Ichimoku-AnalyseGeorg 13. Okt 2022
DAX – ein irritierendes Interview und ein intakter AbwärtstrendKarin Roller15. Sep 2022
456
}}} Front Page : https://proto.vtad.de/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:01:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:01:15 -0000 Subject: [wp-trac] [WordPress Trac] #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding within the cells (was: Twenty Twenty-Three: 6.1 RC1 ignores padding within the celss) In-Reply-To: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> References: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> Message-ID: <063.64fe60445ebca0151213bb2cbfd390ee@wordpress.org> #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding within the cells -------------------------------+--------------------- Reporter: vtad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: trunk Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+--------------------- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:10:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:10:06 -0000 Subject: [wp-trac] [WordPress Trac] #56840: The permalink format is "plain" by default In-Reply-To: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> References: <053.f2d53727aef20113ceeca0bc8115dcf5@wordpress.org> Message-ID: <068.ffd66c05dbf6a52e3abed264064665ce@wordpress.org> #56840: The permalink format is "plain" by default -------------------------------------------------+------------------------- Reporter: strategio | Owner: | SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Permalinks | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"54636" 54636]: {{{ #!CommitTicketReference repository="" revision="54636" Bootstrap/Load: Correct sending the `X-Pingback` header in `WP::send_headers()`. The logic for sending the `X-Pingback` header for single posts that allow pings was recently moved from `WP::handle_404()`​ to a more appropriate place in `WP::send_headers()`. To check whether pings are open for a particular post, that logic relies on the `$wp_query` global, which is declared in `WP::handle_404()`, but not in `WP::send_headers()` This commit ensures that `$wp_query` is globalized in `WP::send_headers()` too, so that the check works as expected. Follow-up to [54250]. Props strategio, sabernhardt, dlh, davidbaumwald, SergeyBiryukov. Fixes #56840. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:16:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:16:12 -0000 Subject: [wp-trac] [WordPress Trac] #56789: Toolbar: screen-reader-shortcut does not have background color until focused In-Reply-To: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> References: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> Message-ID: <070.173cb07b434de1f1ddacc83c3b42cfaf@wordpress.org> #56789: Toolbar: screen-reader-shortcut does not have background color until focused -------------------------------------+--------------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Toolbar | Version: Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: accessibility, css -------------------------------------+--------------------------------- Changes (by cu121): * keywords: => has-patch needs-testing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:17:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:17:31 -0000 Subject: [wp-trac] [WordPress Trac] #56789: Toolbar: screen-reader-shortcut does not have background color until focused In-Reply-To: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> References: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> Message-ID: <070.06fc0ae8fa97a660c8c35ba7a2884ee3@wordpress.org> #56789: Toolbar: screen-reader-shortcut does not have background color until focused -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Toolbar | Version: Severity: minor | Resolution: Keywords: has-patch needs-testing has- | Focuses: screenshots | accessibility, css -------------------------------------------------+------------------------- Changes (by cu121): * keywords: has-patch needs-testing => has-patch needs-testing has- screenshots -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:21:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:21:38 -0000 Subject: [wp-trac] [WordPress Trac] #56789: Toolbar: screen-reader-shortcut does not have background color until focused In-Reply-To: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> References: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> Message-ID: <070.f890d2910280d5f3bdf6176ae998fbfa@wordpress.org> #56789: Toolbar: screen-reader-shortcut does not have background color until focused -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Toolbar | Version: Severity: minor | Resolution: Keywords: has-patch needs-testing has- | Focuses: screenshots needs-testing-info | accessibility, css -------------------------------------------------+------------------------- Changes (by cu121): * keywords: has-patch needs-testing has-screenshots => has-patch needs- testing has-screenshots needs-testing-info -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:30:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:30:53 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.4f283f487d454b5a182694528e738f8c@wordpress.org> #37181: Use metadata api in *_network_options --------------------------------+------------------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: ms-roadmap | Focuses: multisite, performance --------------------------------+------------------------------------- Changes (by johnbillion): * keywords: has-patch ms-roadmap dev-feedback has-unit-tests commit has- dev-note => ms-roadmap * status: closed => reopened * resolution: fixed => Comment: Reopening based on #56845. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:33:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:33:44 -0000 Subject: [wp-trac] [WordPress Trac] #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page In-Reply-To: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> References: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> Message-ID: <064.6b83bdddc4a0871a9d254193f09457e7@wordpress.org> #56827: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page -------------------------------------------------+------------------------- Reporter: nlpro | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: I18N | Version: 6.0.2 Severity: normal | Resolution: Keywords: has-testing-info has-screenshots | Focuses: ui needs-testing | -------------------------------------------------+------------------------- Changes (by cu121): * keywords: => has-testing-info has-screenshots needs-testing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:50:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:50:55 -0000 Subject: [wp-trac] [WordPress Trac] #56841: WordPress pagination broken after updating to 6.0 In-Reply-To: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> References: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> Message-ID: <064.e5ba569b3fcd6640825f56678cb54998@wordpress.org> #56841: WordPress pagination broken after updating to 6.0 ------------------------------------------------+-------------------------- Reporter: wpfed | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Posts, Post Types | Version: 6.0 Severity: normal | Resolution: Keywords: has-screenshots needs-testing-info | Focuses: ------------------------------------------------+-------------------------- Changes (by cu121): * keywords: => has-screenshots needs-testing-info -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 16:51:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 16:51:42 -0000 Subject: [wp-trac] [WordPress Trac] #56841: WordPress pagination broken after updating to 6.0 In-Reply-To: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> References: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> Message-ID: <064.831b3f290ccc6708d07ddcea57360286@wordpress.org> #56841: WordPress pagination broken after updating to 6.0 ------------------------------------------------+-------------------------- Reporter: wpfed | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Posts, Post Types | Version: 6.0 Severity: normal | Resolution: Keywords: has-screenshots needs-testing-info | Focuses: ------------------------------------------------+-------------------------- Comment (by cu121): Thank you @wpfed, for the report! I’m applying some keywords to help ensure this ticket can move forward. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 17:11:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 17:11:48 -0000 Subject: [wp-trac] [WordPress Trac] #56841: WordPress pagination broken after updating to 6.0 In-Reply-To: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> References: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> Message-ID: <064.6dcd5428a3c4a9ef9f4465f0bc078cab@wordpress.org> #56841: WordPress pagination broken after updating to 6.0 -------------------------------------------------+------------------------- Reporter: wpfed | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Posts, Post Types | Version: 6.0 Severity: normal | Resolution: Keywords: has-screenshots needs-testing-info | Focuses: reporter-feedback | -------------------------------------------------+------------------------- Changes (by ironprogrammer): * keywords: has-screenshots needs-testing-info => has-screenshots needs- testing-info reporter-feedback Comment: Hi, @wpfed -- Would you please provide reproduction information for this issue? The screenshot supplied suggests you may have reproduced this locally, but to be sure, sharing those steps with other reviewers will help this get more attention 🙌🏻 Please see the following link for guidance on Reproduction Testing instructions: https://make.wordpress.org/test/handbook/test-reports/#bug- defect-testing-instructions-template. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 17:19:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 17:19:21 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.6bea1fa1b0b1e4e5d26e4dac9707f0a1@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg --------------------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: has-testing-info needs-testing | Focuses: performance --------------------------------------------+------------------------------ Comment (by desrosj): Replying to [comment:8 dylan2intel]: > Indeed, I tried, the performance also dropped on 6.1 Could you clarify? Did the performance in 6.1 drop when compared to 5.9? When compared to 6.0? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 17:20:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 17:20:46 -0000 Subject: [wp-trac] [WordPress Trac] #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect In-Reply-To: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> References: <054.169d7caf95d1f7b3b1cd9fec3478f419@wordpress.org> Message-ID: <069.438776aa15811d94124c548372b81a82@wordpress.org> #56836: PHP 8.1 Deprecation Warning for mysqli_real_connect --------------------------+------------------------ Reporter: nickchomey | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Database | Version: 6.0.2 Severity: normal | Resolution: duplicate Keywords: php81 | Focuses: --------------------------+------------------------ Changes (by desrosj): * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 17:27:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 17:27:33 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options In-Reply-To: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> References: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> Message-ID: <072.6ce1cfaf99ae525236c3c4aba2e79a65@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options --------------------------------+------------------------------------- Reporter: pavelschoffer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Options, Meta APIs | Version: trunk Severity: critical | Resolution: Keywords: | Focuses: multisite, performance --------------------------------+------------------------------------- Changes (by davidbaumwald): * Attachment "56845.diff" added. Revert patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 17:44:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 17:44:36 -0000 Subject: [wp-trac] [WordPress Trac] #56841: WordPress pagination broken after updating to 6.0 In-Reply-To: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> References: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> Message-ID: <064.cab7240a3c8e08060c0e3ea79c71c14b@wordpress.org> #56841: WordPress pagination broken after updating to 6.0 -------------------------------------------------+------------------------- Reporter: wpfed | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Posts, Post Types | Version: 6.0 Severity: normal | Resolution: Keywords: has-screenshots needs-testing-info | Focuses: reporter-feedback | -------------------------------------------------+------------------------- Comment (by wpfed): Thank you all for getting back! I wanted to add some more information in the meantime. As mentioned by @cu121 this is very much looking like hosting environment issue since it's working on my localhost but not on my hosted server. Another factor that is pointing to my hosting environment, I checked on another DEV site that is updated to 6.0.2 and the pagination is also missing! but once again, it's present on my localhost. If I rollback to 5.9.4 the pagination returns. Something is not agreeing with WP 6.0+ and my hosting. I have ticket open with my hosting company, I will post the solution once they figure it out. Thank you for your time, this can be closed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 17:59:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 17:59:10 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.67db9cb230f706e77d4e92dca927d631@wordpress.org> #37181: Use metadata api in *_network_options --------------------------------+------------------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: ms-roadmap revert | Focuses: multisite, performance --------------------------------+------------------------------------- Changes (by davidbaumwald): * keywords: ms-roadmap => ms-roadmap revert Comment: After some discussion, prepping a full revert for now. For the full discussion in Slack, see https://wordpress.slack.com/archives/C03LZ88NX6G/p1666104060129079 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:03:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:03:11 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.1124509bef7de489f4a8564833e55f7d@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 -------------------------------------------+--------------------- Reporter: ryelle | Owner: (none) Type: task (blessed) | Status: new Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch commit dev-reviewed | Focuses: -------------------------------------------+--------------------- Changes (by davidbaumwald): * keywords: has-patch commit dev-feedback => has-patch commit dev-reviewed Comment: LGTM! @ryelle If you want to get this in before RC2, go for it! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:12:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:12:50 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options In-Reply-To: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> References: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> Message-ID: <072.a14b5467015d768964ed5b6fe0bfd462@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options ---------------------------------+------------------------------------- Reporter: pavelschoffer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Options, Meta APIs | Version: trunk Severity: critical | Resolution: Keywords: commit dev-feedback | Focuses: multisite, performance ---------------------------------+------------------------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests => commit dev-feedback Comment: Marking as first commit review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:14:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:14:17 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options In-Reply-To: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> References: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> Message-ID: <072.de040c4648b6ebb12d7948ccfab45b71@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options ---------------------------------+------------------------------------- Reporter: pavelschoffer | Owner: davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Options, Meta APIs | Version: trunk Severity: critical | Resolution: fixed Keywords: commit dev-feedback | Focuses: multisite, performance ---------------------------------+------------------------------------- Changes (by davidbaumwald): * owner: (none) => davidbaumwald * status: new => closed * resolution: => fixed Comment: In [changeset:"54637" 54637]: {{{ #!CommitTicketReference repository="" revision="54637" Networks and Sites: Revert the use of the metadata API for `*_network_options` functions. [54080] refactored the logic in `get_network_option()`, `update_network_option()` and `delete_network_option()` to use the metadata API. However, this change resulted in issues with large multisite installs that utilize memcached having network options > 1MB in size. This change reverts [54080] and all related follow-up changes. Reverts [54080], [54081], and [54082]. Partially reverts [54267] and [54402]. Props pavelschoffer, rebasaurus, johnbillion, spacedmonkey, desrosj, rinatkhaziev. Fixes #56845. See #37181. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:14:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:14:18 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.6b52b89ae33d19fbeb9c2117852bf199@wordpress.org> #37181: Use metadata api in *_network_options --------------------------------+------------------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: ms-roadmap revert | Focuses: multisite, performance --------------------------------+------------------------------------- Comment (by davidbaumwald): In [changeset:"54637" 54637]: {{{ #!CommitTicketReference repository="" revision="54637" Networks and Sites: Revert the use of the metadata API for `*_network_options` functions. [54080] refactored the logic in `get_network_option()`, `update_network_option()` and `delete_network_option()` to use the metadata API. However, this change resulted in issues with large multisite installs that utilize memcached having network options > 1MB in size. This change reverts [54080] and all related follow-up changes. Reverts [54080], [54081], and [54082]. Partially reverts [54267] and [54402]. Props pavelschoffer, rebasaurus, johnbillion, spacedmonkey, desrosj, rinatkhaziev. Fixes #56845. See #37181. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:21:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:21:57 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.f3db5cba29ed6254d9edc214b6d98604@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, accessibility, docs, | administration, ui-copy -------------------------+------------------------------------------------- Comment (by laurlittle): > Updating the link for the release video (in two places, can find "#" and '#'). @ryelle I'll be able to help with the video link this time around. Hoping to have it available early next week. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:25:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:25:20 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.e3da290a7833e17084d172789b041696@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------+------------------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect | Status: reopened (bug) | Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: has-patch | Focuses: ui, accessibility, css, needs-testing | administration -------------------------+------------------------------------------------- Comment (by joedolson): Can you give a text description of the problem and solution? I'm not clear what this is solving from the screenshots. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:27:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:27:56 -0000 Subject: [wp-trac] [WordPress Trac] #56733: oEmbed: Add support for Tumblr reader URLs In-Reply-To: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> References: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> Message-ID: <064.452ea8213566d7c00897afb6d160ae2f@wordpress.org> #56733: oEmbed: Add support for Tumblr reader URLs -------------------------------------------------+------------------------- Reporter: pento | Owner: pento Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Embeds | Version: trunk Severity: normal | Resolution: Keywords: has-patch needs-review needs- | Focuses: testing reporter-feedback | -------------------------------------------------+------------------------- Changes (by chaion07): * keywords: has-patch needs-review => has-patch needs-review needs-testing reporter-feedback Comment: Thanks @pento for reporting this. We reviewed this during a recent bug- scrub session. Here's the summary of the feedback received from the team: 01. Adding keyword ''needs-testing'' as we feel that the ticket could benefit from some testing. Since this is a bug introduced during 6.1, it should probably be fixed. We are not as concerned with the GB PR not being merged yet. 02. Added keyword ''reporter-feedback'' since @desrosj added the feedback 03. We may just punt it and if that is the case then there is a chance that [https://core.trac.wordpress.org/changeset/54393 54393] may also be reverted. 04. [https://github.com/WordPress/gutenberg/pull/44854 This Github Issue] is also necessary. So folks from the Editor team should also weigh in. 05. There is an [https://core.trac.wordpress.org/attachment/ticket/56733/56733.2.diff updated patch] available for testing. 06. The Team finally decided to leave the ticket as is and possibly address after RC2 because it seems like a bug in the current implementation added in 6.1 Cheers! Props to @desrosj @davidbaumwald @jorbin @jeffpaul @bernhard-reiter -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:33:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:33:41 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.d0708a34c6c5868e5647fc3bcd07aeb8@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 -------------------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: closed Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit dev-reviewed | Focuses: -------------------------------------------+---------------------------- Changes (by davidbaumwald): * owner: (none) => davidbaumwald * status: new => closed * resolution: => fixed Comment: In [changeset:"54638" 54638]: {{{ #!CommitTicketReference repository="" revision="54638" Administration: Update the Dashboard welcome banner for 6.1. Reviewed by ryelle and davidbaumwald. Props ryelle, adampickering, mikeschroder, richtabor. Fixes #56703. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:34:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:34:48 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.2b81e0b9e3e5db955b13ee326926192a@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: closed Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: ------------------------------+---------------------------- Changes (by davidbaumwald): * keywords: has-patch commit dev-reviewed => has-patch commit Comment: Cleaning up the keywords after the merge. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:42:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:42:18 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency Message-ID: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ------------------------------+----------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: minor | Keywords: Focuses: coding-standards | ------------------------------+----------------------------- About 170 PHP test classes use lowercase `w` and only 34 test classes use capital `W` in the `wp` prefix. Examples: `wp` : `Tests_Formatting_wpParseStr` `Wp` : `Tests_Category_WpListCategories` According to [https://make.wordpress.org/core/handbook/testing/automated- testing/writing-phpunit-tests/#test-classes| this document], the correct spelling is `Wp`. So, all test classes that use the `wp` prefix should be renamed for consistency. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:43:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:43:36 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency In-Reply-To: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> References: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> Message-ID: <072.2c3c93c1eebe8c34eb168db2f894f114@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ---------------------------+------------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: minor | Resolution: Keywords: | Focuses: coding-standards ---------------------------+------------------------------- Comment (by costdev): Fully agreed @antonvlasenko! Been hoping to address this for a while, thanks for opening the ticket! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:43:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:43:41 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.f5296487aedad673b7a6137ea348b002@wordpress.org> #37181: Use metadata api in *_network_options --------------------------------+------------------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: ms-roadmap revert | Focuses: multisite, performance --------------------------------+------------------------------------- Comment (by pbiron): Replying to [comment:76 milana_cap]: > Dev note: https://make.wordpress.org/core/2022/10/10/multisite- improvements-in-wordpress-6-1/ I think the Dev note should be updated to mention the revert. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 18:57:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 18:57:18 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency In-Reply-To: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> References: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> Message-ID: <072.c81743831f1fb795c066eeb95469e2c4@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ---------------------------+------------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: minor | Resolution: Keywords: | Focuses: coding-standards ---------------------------+------------------------------- Comment (by antonvlasenko): Thanks, @costdev. I'm glad to hear I'm not the only one concerned about it. 😉 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 19:25:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 19:25:29 -0000 Subject: [wp-trac] [WordPress Trac] #56847: Our mission is to inspire moments of optimism and hapiness Message-ID: <058.f5b1f179f99d4d093690ee7542529ebd@wordpress.org> #56847: Our mission is to inspire moments of optimism and hapiness ----------------------------+----------------------------- Reporter: fueggoevents22 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | ----------------------------+----------------------------- Happier clients, less stress.We bring the community together -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 19:36:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 19:36:18 -0000 Subject: [wp-trac] [WordPress Trac] #56820: Remove use of save-state and set-output in GitHub Actions In-Reply-To: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> References: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> Message-ID: <066.95f1f22e055e6d592d5dc54a5ae14ef1@wordpress.org> #56820: Remove use of save-state and set-output in GitHub Actions ------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+----------------------- Comment (by chaion07): Thanks @desrosj for reporting this. We discussed this ticket during a recent bug-scrub session. Here's the summary of the feedback received from the team. 01. This is just a tooling item to address the deprecated items upstream. 02. @desrosj graciously volunteered to take care sometime in the near future with a new patch to commit. 03. The team decided to leave the ticket as is and in the milestone. Props to @desrosj for all the hard work! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 19:38:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 19:38:02 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency In-Reply-To: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> References: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> Message-ID: <072.74dd98f1c8a876454281f1c6b38e158d@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ---------------------------+------------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: minor | Resolution: Keywords: | Focuses: coding-standards ---------------------------+------------------------------- Comment (by SergeyBiryukov): Replying to [ticket:56846 antonvlasenko]: > Examples: > `wp` : `Tests_Formatting_wpParseStr` > `Wp` : `Tests_Category_WpListCategories` > According to [https://make.wordpress.org/core/handbook/testing /automated-testing/writing-phpunit-tests/#test-classes| this document], the correct spelling is `Wp`. > So, all test classes that use the `wp` prefix should be renamed for consistency. I was hoping to do it the other way around and standardize on `wp` :) It's probably my personal preference, but `WpListCategories` reminds me of `capital_P_dangit()`, and I find `wpListCategories` easier to read. That said, I guess I can get used to `Wp` if that's the consensus here :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 20:17:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 20:17:39 -0000 Subject: [wp-trac] [WordPress Trac] #9883: Password shows under Settings / Writing In-Reply-To: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> References: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> Message-ID: <066.0cf90cda578faaf2e53f26487906a1d7@wordpress.org> #9883: Password shows under Settings / Writing -------------------------------------------------+------------------------- Reporter: mastrup | Owner: (none) Type: enhancement | Status: assigned Priority: low | Milestone: Future | Release Component: Administration | Version: 2.7.1 Severity: trivial | Resolution: Keywords: has-patch needs-testing has- | Focuses: ui, testing-info dev-feedback | accessibility -------------------------------------------------+------------------------- Comment (by ironprogrammer): The last PR update appears to have resolved the display issues, @costdev 👍🏻 == Test Report Patch tested: https://github.com/WordPress/wordpress- develop/pull/2070.diff (after update via comment:43) === Environment - Hardware: MacBook Pro Apple M1 Pro - OS: macOS 12.6 - Browser: Safari 16.0 - Server: nginx/1.23.1 - PHP: 7.4.32 - WordPress: 6.1-RC2-54640-src - Password Manager: 1Password 7 v7.9.6 === Actual Results - ✅ Password is hidden on page load, and clicking "eye" icon toggles visibility. - ✅ "Eye" icon is not covered by 1Password 7 suggestion toggle icon. - ✅ Password field is not focused on page load. - ✅ "Eye (crossed-out)" icon is not covered by 1Password 7 suggestion toggle icon when password is toggled visible. - ✅ For RTL, the eye icons are not covered by the 1Password 7 toggle icon. === Additional Information For the RTL language tested, 1Password 7 misinterpreted the password field as a login name, rather than a password field, despite no change to the markup except for the `ltr`<->`rtl` field class difference. === Supplemental Artifacts ''Figure 1: After patch, icons remain separate when password is visible'' [[Image(https://cldup.com/0lmZTaMJuN.png, 50%)]] ''Figure 2: Behavior is consistent when site configured with RTL language'' [[Image(https://cldup.com/sKJQD8Xxx9.png, 80%)]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 20:25:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 20:25:32 -0000 Subject: [wp-trac] [WordPress Trac] #56841: WordPress pagination broken after updating to 6.0 In-Reply-To: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> References: <049.552bfa8f7a0a1dbe5113653e3b31e6a1@wordpress.org> Message-ID: <064.2e0a4c2685e8ed6f85f06780777825aa@wordpress.org> #56841: WordPress pagination broken after updating to 6.0 -------------------------------------------------+------------------------- Reporter: wpfed | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Posts, Post Types | Version: 6.0 Severity: normal | Resolution: invalid Keywords: has-screenshots needs-testing-info | Focuses: reporter-feedback | -------------------------------------------------+------------------------- Changes (by ironprogrammer): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Thank you for the update, @wpfed -- we'll close this for now. You might also try checking out the dedicated support forums at https://wordpress.org/support/forums/. Good luck! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 20:37:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 20:37:49 -0000 Subject: [wp-trac] [WordPress Trac] #56057: Add conditional to WP_Upgrader::install_package() for Rollback testing In-Reply-To: <051.6352cd38409ad9e49f74c02ba48a1fdf@wordpress.org> References: <051.6352cd38409ad9e49f74c02ba48a1fdf@wordpress.org> Message-ID: <066.a04a8c7906454b4f598f6b6b0dca9278@wordpress.org> #56057: Add conditional to WP_Upgrader::install_package() for Rollback testing -----------------------------+----------------------------- Reporter: afragen | Owner: SergeyBiryukov Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.2 Component: Upgrade/Install | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: -----------------------------+----------------------------- Comment (by SergeyBiryukov): In [changeset:"54643" 54643]: {{{ #!CommitTicketReference repository="" revision="54643" Upgrade/Install: Add a conditional to facilitate testing of the Rollbacks feature project. The [https://make.wordpress.org/core/2021/02/19/feature-plugin-rollback- update-failure/ Rollback Update Failure feature project] creates a temporary backup of plugins and themes before updating. This aims to make the update process more reliable and ensure that if a plugin or theme update fails, the previous version can be safely restored. If the [https://wordpress.org/plugins/rollback-update-failure/ Rollback Update Failure plugin] is installed, `WP_Upgrader::install_package()` will use the `move_dir()` function from there for better performance. Instead of copying a directory from one location to another, it uses the `rename()` PHP function to speed up the process, which is instrumental in creating a temporary backup without a delay. If the renaming failed, it falls back to `copy_dir()` WP function. This conditional aims to facilitate broader testing of the feature. It is temporary, until the plugin is merged into core. Follow-up to [53578], [54484]. Props afragen, pbiron, costdev, davidbaumwald, audrasjb, jrf, SergeyBiryukov. See #56057. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 21:13:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 21:13:38 -0000 Subject: [wp-trac] [WordPress Trac] #56847: Template parts and patterns Message-ID: <061.93ef1c917e442c676f8f040029e1eafb@wordpress.org> #56847: Template parts and patterns -------------------------------+----------------------------- Reporter: matteomarchiori97 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.0.3 Severity: normal | Keywords: Focuses: template | -------------------------------+----------------------------- Good day, I am developing a WordPress theme (published, but still work in progress, W3CSSPress). While I was trying to get a value from a function (in functions.php) into a component of the theme I noticed a strage behavior. If I try to develop a normal template part in HTML and include in it a pattern which contains a dynamic content, then I move away the templates and reload the website (classic version of the theme) and then I move back the templates (block version of the theme) I find that the dynamic generated part got cached and is not generated again anymore. Istead, if I avoid to use a template part and I put its content inside a pattern and I call it from the templates of the pages (like, front- page.html) the content gets dynamically regenerated correctly. This could be a good behavior from a caching and performance point of view, but if a template part has got some dynamic content it should be regenerated. Is it fixable in some way? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 21:23:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 21:23:43 -0000 Subject: [wp-trac] [WordPress Trac] #54582: Problem with deleting old files at the end of a core update when the filesystem is case-insensitive In-Reply-To: <050.439148f3204025f20e2acf004716f3ed@wordpress.org> References: <050.439148f3204025f20e2acf004716f3ed@wordpress.org> Message-ID: <065.a352d39bc9287da35eb8428767266ff3@wordpress.org> #54582: Problem with deleting old files at the end of a core update when the filesystem is case-insensitive -------------------------------------------------+------------------------- Reporter: pbiron | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.2 Component: Upgrade/Install | Version: Severity: major | Resolution: Keywords: needs-testing early early-like- | Focuses: actually-early has-patch changes-requested | has-testing-info | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * milestone: Future Release => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 21:24:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 21:24:05 -0000 Subject: [wp-trac] [WordPress Trac] #54582: Problem with deleting old files at the end of a core update when the filesystem is case-insensitive In-Reply-To: <050.439148f3204025f20e2acf004716f3ed@wordpress.org> References: <050.439148f3204025f20e2acf004716f3ed@wordpress.org> Message-ID: <065.4134cb2e8e0ff71c4321e9f8ee5aee4b@wordpress.org> #54582: Problem with deleting old files at the end of a core update when the filesystem is case-insensitive -------------------------------------------------+------------------------- Reporter: pbiron | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: high | Milestone: 6.2 Component: Upgrade/Install | Version: Severity: major | Resolution: Keywords: needs-testing early early-like- | Focuses: actually-early has-patch changes-requested | has-testing-info | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => accepted -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 21:33:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 21:33:20 -0000 Subject: [wp-trac] [WordPress Trac] #56848: Avoid initializing WP_Recovery_Mode when fatal error handler is disabled Message-ID: <052.9bbc6bc09a2c4920d2f2ac89a95782ac@wordpress.org> #56848: Avoid initializing WP_Recovery_Mode when fatal error handler is disabled -------------------------+------------------------------------------ Reporter: flixos90 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Site Health | Version: Severity: normal | Keywords: needs-patch needs-unit-tests Focuses: | -------------------------+------------------------------------------ #44458 and #46130 introduced the fatal error handler that sends an email to the admin to enter a recovery mode. Since the initial implementation, there have been a constant `WP_DISABLE_FATAL_ERROR_HANDLER` and a filter `wp_fatal_error_handler_enabled` which can be used to disable the fatal error handler. However, as of today the recovery mode logic in the `WP_Recovery_Mode` is still being initialized even when the fatal error handler is disabled. This does not raise any functional concerns, but it should not be necessary given the fatal error handler that can trigger recovery mode is disabled. By removing it, we avoid running unnecessary logic and an early lookup of the "cron" database option. We should amend the clause in `wp-settings.php` around the call that initializes the `WP_Recovery_Mode` class with an extra condition for `wp_is_fatal_error_handler_enabled()`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 21:52:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 21:52:32 -0000 Subject: [wp-trac] [WordPress Trac] #56849: Modify `_config_wp_home()` and `_config_wp_siteurl()` to become pre_option filters Message-ID: <052.8483980982176fc13c9b68fe91a064f5@wordpress.org> #56849: Modify `_config_wp_home()` and `_config_wp_siteurl()` to become pre_option filters --------------------------------+------------------------- Reporter: flixos90 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Options, Meta APIs | Version: Severity: normal | Keywords: 2nd-opinion Focuses: | --------------------------------+------------------------- The functions `_config_wp_home()` and `_config_wp_siteurl()` are currently used to enforce values for the "home" and "siteurl" options, if the respective `WP_HOME` / `WP_SITEURL` constant is set. However, the way this currently happens is by hooking into the `option_home` and `option_siteurl` filters. This is a bit wasteful since it means all the logic to still look up the option is still run unnecessarily. We should change the approach so that the two callbacks become filter callbacks for `pre_option_home` and `pre_option_siteurl` instead. This way, if the constants are defined, the logic in `get_option()` can bail early. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 21:53:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 21:53:53 -0000 Subject: [wp-trac] [WordPress Trac] #56845: Multisite option caching breaks for sites with bigger options In-Reply-To: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> References: <057.3e3b02a93a744e931855f3cf7d1a1957@wordpress.org> Message-ID: <072.c8f537dcfab6cb0bbcff99c69a3c0770@wordpress.org> #56845: Multisite option caching breaks for sites with bigger options ------------------------------------------------+-------------------------- Reporter: pavelschoffer | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Options, Meta APIs | Version: 6.1 Severity: critical | Resolution: fixed Keywords: commit dev-feedback needs-dev-note | Focuses: multisite, | performance ------------------------------------------------+-------------------------- Changes (by peterwilsoncc): * keywords: commit dev-feedback => commit dev-feedback needs-dev-note Comment: This change was mentioned in the [https://make.wordpress.org/core/2022/10/10/multisite-improvements-in- wordpress-6-1/ multisite dev note] that ought to be followed up: * a brief dev-note (one or two paragraph) to note it's been reverted * update the original dev note -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 18 22:13:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 18 Oct 2022 22:13:04 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.40e1728c8410d03eaad5f4daaa3fbbd7@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------+------------------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect | Status: reopened (bug) | Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: has-patch | Focuses: ui, accessibility, css, needs-testing | administration -------------------------+------------------------------------------------- Comment (by sabernhardt): @joedolson The "Cancel" and "Add link" buttons can be hidden behind the bottom of the browser window because the Link Options modal is 100 pixels taller now. 1. If the zoom level is at 100%, resize the browser window to a height between 521 and 600 pixels and any width. 2. Activate Classic Editor. 3. Create a new post in the post editor. 4. Insert a link, and open the Link Options. 5. Look for the "Add link" button at the bottom. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 00:24:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 00:24:13 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.7aec1d28e461cd9af84114ef2c15f987@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, accessibility, docs, | administration, ui-copy -------------------------+------------------------------------------------- Comment (by annezazu): @laurlittle is going to be the point person for the video this time around! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 00:27:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 00:27:28 -0000 Subject: [wp-trac] [WordPress Trac] #56842: WordPress performance drop due to introduce Gutenberg In-Reply-To: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> References: <055.f666767bd02f62f551a6883d5e08914b@wordpress.org> Message-ID: <070.6e53678039343a32956b2b2c84b73121@wordpress.org> #56842: WordPress performance drop due to introduce Gutenberg --------------------------------------------+------------------------------ Reporter: dylan2intel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: 6.0 Severity: major | Resolution: Keywords: has-testing-info needs-testing | Focuses: performance --------------------------------------------+------------------------------ Comment (by dylan2intel): Actually you can try it by yourself with steps provided on comment#5 BTW, I also tried on version 5.9.3, installing Gutenberg plugin, active/deactive this plugin can also reproduce the issue. Replying to [comment:9 desrosj]: > Replying to [comment:8 dylan2intel]: > > Indeed, I tried, the performance also dropped on 6.1 > > Could you clarify? Did the performance in 6.1 drop when compared to 5.9? When compared to 6.0? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 01:58:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 01:58:05 -0000 Subject: [wp-trac] [WordPress Trac] #56816: Correct references to npm and Node.js In-Reply-To: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> References: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> Message-ID: <066.ab4d9782f9d3aea3e3c2d656133fa1fe@wordpress.org> #56816: Correct references to npm and Node.js --------------------------------------+------------------------ Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: docs --------------------------------------+------------------------ Changes (by desrosj): * owner: (none) => desrosj * status: new => reviewing Comment: Thanks @aleksganev! Now that 6.1 has been branched, this can be committed any time. I'll review this at some point in the coming days. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 02:13:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 02:13:33 -0000 Subject: [wp-trac] [WordPress Trac] #51812: Update jQuery step three In-Reply-To: <050.43509dc37aaf8ffb3e6788e46500216b@wordpress.org> References: <050.43509dc37aaf8ffb3e6788e46500216b@wordpress.org> Message-ID: <065.de4de6a5430c47e11dc22cbf72bb7288@wordpress.org> #51812: Update jQuery step three -------------------------------------------------+------------------------- Reporter: azaozz | Owner: | SergeyBiryukov Type: task (blessed) | Status: reviewing Priority: normal | Milestone: Future | Release Component: External Libraries | Version: Severity: normal | Resolution: Keywords: early needs-testing needs-dev-note | Focuses: javascript has-patch | -------------------------------------------------+------------------------- Comment (by a4jp.com): Any chance of getting 3.4.0 as it's just a link change on your side and as jQuery Migrate is still in WordPress? Or a warning removal: {{{ /*Remove JQuery Migrate warning*/ function remove_jquery_migrate_notice() { $m= $GLOBALS['wp_scripts']->registered['jquery-migrate']; $m->extra['before'][]='temp_jm_logconsole = window.console.log; window.console.log=null;'; $m->extra['after'][]='window.console.log=temp_jm_logconsole;'; } add_action( 'init', 'remove_jquery_migrate_notice', 5 ); }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 05:08:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 05:08:05 -0000 Subject: [wp-trac] [WordPress Trac] #56813: Heading Block Margin Issue In-Reply-To: <058.e4cdfd1b9a9f249021b1eba0644255ae@wordpress.org> References: <058.e4cdfd1b9a9f249021b1eba0644255ae@wordpress.org> Message-ID: <073.4b75537c1b96ecf172c3759cc86c514d@wordpress.org> #56813: Heading Block Margin Issue -------------------------------+------------------------------ Reporter: piyushpatel123 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.2 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Comment (by piyushpatel123): Hello, # Twenty Twenty-Two Theme: - Back-end screenshot: https://prnt.sc/SK_uDx4xI3pV - Front-end screenshot: https://prnt.sc/8XDkCht4iiPj - For that theme margins left & right is not working. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 06:42:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 06:42:16 -0000 Subject: [wp-trac] [WordPress Trac] #43761: CS: Fix violations for wp-admin/install-helper.php In-Reply-To: <052.4be6df608b6b299277021dd5715168f5@wordpress.org> References: <052.4be6df608b6b299277021dd5715168f5@wordpress.org> Message-ID: <067.de7f74209af2f670286e60e973b42b01@wordpress.org> #43761: CS: Fix violations for wp-admin/install-helper.php ------------------------------------+------------------------------- Reporter: jipmoors | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch dev-feedback | Focuses: coding-standards ------------------------------------+------------------------------- Comment (by jrf): FYI: I reviewed the PR and @costdev and me discussed my feedback in a call. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 07:47:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 07:47:17 -0000 Subject: [wp-trac] [WordPress Trac] #43761: CS: Fix violations for wp-admin/install-helper.php In-Reply-To: <052.4be6df608b6b299277021dd5715168f5@wordpress.org> References: <052.4be6df608b6b299277021dd5715168f5@wordpress.org> Message-ID: <067.c9c55f5511447564a571e8633bba8534@wordpress.org> #43761: CS: Fix violations for wp-admin/install-helper.php ------------------------------+------------------------------- Reporter: jipmoors | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: coding-standards ------------------------------+------------------------------- Changes (by costdev): * keywords: has-patch dev-feedback => has-patch commit * milestone: Awaiting Review => 6.2 Comment: I have updated [https://github.com/WordPress/wordpress-develop/pull/3478 the PR] with changes after feedback from @jrf. Thanks Juliette! Adding for `commit` consideration. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 08:39:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 08:39:07 -0000 Subject: [wp-trac] [WordPress Trac] #37287: wp_print_admin_notice_templates() does not use _n*() for plural forms In-Reply-To: <049.27feaaa7c170a3328c41aab451c2d1c1@wordpress.org> References: <049.27feaaa7c170a3328c41aab451c2d1c1@wordpress.org> Message-ID: <064.9291d92ec2407cd04ee436de18747e0e@wordpress.org> #37287: wp_print_admin_notice_templates() does not use _n*() for plural forms --------------------------+----------------------------------------- Reporter: ideag | Owner: audrasjb Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future Release Component: I18N | Version: 4.6 Severity: normal | Resolution: Keywords: has-patch | Focuses: javascript, administration --------------------------+----------------------------------------- Comment (by daledupreez): Thanks for flagging that gap, @ocean90! This was one of my original concerns with my PR. Do you know if we have an issue for adding that support to our translation tools? I'd like to make sure we flag this issue as blocked by that support (or possibly a motivator for adding it!). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 08:55:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 08:55:29 -0000 Subject: [wp-trac] [WordPress Trac] #37287: wp_print_admin_notice_templates() does not use _n*() for plural forms In-Reply-To: <049.27feaaa7c170a3328c41aab451c2d1c1@wordpress.org> References: <049.27feaaa7c170a3328c41aab451c2d1c1@wordpress.org> Message-ID: <064.d76e6fcf6b362f69fe8238172a7a1d5d@wordpress.org> #37287: wp_print_admin_notice_templates() does not use _n*() for plural forms --------------------------+----------------------------------------- Reporter: ideag | Owner: audrasjb Type: defect (bug) | Status: reopened Priority: normal | Milestone: Future Release Component: I18N | Version: 4.6 Severity: normal | Resolution: Keywords: needs-patch | Focuses: javascript, administration --------------------------+----------------------------------------- Changes (by ocean90): * keywords: has-patch => needs-patch Comment: @daledupreez I think the proper solution would be to move this somehow into [https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/wp/updates.js the existing JavaScript file] instead of having this template in PHP. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 09:42:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 09:42:37 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.548fafe20111b116b6a2e6b166b38d5b@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: closed Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: ------------------------------+---------------------------- Comment (by kebbet): In the latest commit the 6.0 header image was added, was this by intension? Running trunk now displays 6.0 in the welcome banner background, and in the header of about.php … -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 10:10:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 10:10:05 -0000 Subject: [wp-trac] [WordPress Trac] #56850: pluggable.php - Deprecated errors on PHP 8.1 Message-ID: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> #56850: pluggable.php - Deprecated errors on PHP 8.1 ------------------------------------+----------------------------- Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 6.1 Severity: normal | Keywords: has-patch Focuses: | ------------------------------------+----------------------------- This fixes a PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in wp-includes\pluggable.php on line 598 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 10:11:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 10:11:40 -0000 Subject: [wp-trac] [WordPress Trac] #56850: pluggable.php - Deprecated errors on PHP 8.1 In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.290e395385da626efe5f7285f31b05ae@wordpress.org> #56850: pluggable.php - Deprecated errors on PHP 8.1 ------------------------------------+------------------------------ Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by lenasterg): Replying to [ticket:56850 lenasterg]: > This fixes a > PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in wp-includes\pluggable.php on line 598 Pull request with the fix is the https://github.com/WordPress/wordpress-develop/pull/3491 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 10:28:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 10:28:04 -0000 Subject: [wp-trac] [WordPress Trac] #56762: PHP file being ignored in block theme hierarchy In-Reply-To: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> References: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> Message-ID: <072.ed0a29e7cf07e5ceac55b2905a950354@wordpress.org> #56762: PHP file being ignored in block theme hierarchy ---------------------------+------------------------------ Reporter: ryanpluckrose | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.0.2 Severity: major | Resolution: Keywords: needs-patch | Focuses: template ---------------------------+------------------------------ Comment (by willecs): I found that putting the php template into the root of the theme directory, it then works, however this does not work for php template parts. I added a filter to 'theme_file_path' to make this work. {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 10:50:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 10:50:18 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.101281834b5a59d43b18108a9a027707@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 --------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: commit needs-patch | Focuses: --------------------------------+---------------------------- Changes (by kebbet): * keywords: has-patch commit => commit needs-patch * status: closed => reopened * resolution: fixed => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 11:08:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 11:08:51 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.adfa35030da96e45f545acea24626a67@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: commit has-patch | Focuses: ------------------------------+---------------------------- Comment (by kebbet): It's incorrect in 6.1 branch too. -> https://core.trac.wordpress.org/browser/branches/6.1/src/wp- admin/images/about-header-about.svg -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 11:09:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 11:09:53 -0000 Subject: [wp-trac] [WordPress Trac] #56850: pluggable.php - Deprecated errors on PHP 8.1 In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.18870e8ff4c585fba9f7852585272377@wordpress.org> #56850: pluggable.php - Deprecated errors on PHP 8.1 ------------------------------------+------------------------------ Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Comment (by TobiasBg): Hi @lenasterg, thanks for looking into this! When getting this deprecation warning, can you see where that `null` value is coming from? A password should only ever be a string, so it might make more sense to add a fix to the calling function. With the suggested `is_string()` check, the issue is essentially just shifted further down, when the next operation on the still-`null` `$password` happens -- but then this check might just make debugging and finding the origin a bit harder. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 11:16:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 11:16:12 -0000 Subject: [wp-trac] [WordPress Trac] #56851: Nivito.lt Message-ID: <057.e045d55e5951cec9830e137efc7bc5b9@wordpress.org> #56851: Nivito.lt ---------------------------+----------------------------- Reporter: naveedakram12 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- Norite tobulai užbaigti savo modernią virtuvę? Tada atidžiau pažvelkite į „[Nivito“][https://www.nivito.lt/] virtuvės maišytuvą. Šis maišytuvas yra tikras meno kūrinys, jo elegantiškas ir stilingas dizainas tikrai atrodys bet kuriuose namuose. Aukštos kokybės konstrukcija ir dėmesys detalėms taip pat akivaizdus šiame kūrinyje, todėl tai yra protinga investicija į jūsų namus. „Nivito“ virtuvės maišytuvas, pasižymintis paprastomis naudojimo funkcijomis ir gražia apdaila, tikrai bus laukiamas jūsų namų papildymas. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 11:22:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 11:22:19 -0000 Subject: [wp-trac] [WordPress Trac] #56733: oEmbed: Add support for Tumblr reader URLs In-Reply-To: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> References: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> Message-ID: <064.230322d6c0b12b1b5dcf16b9635b9cf0@wordpress.org> #56733: oEmbed: Add support for Tumblr reader URLs --------------------------------------------------+----------------------- Reporter: pento | Owner: pento Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Embeds | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch needs-review needs-testing | Focuses: --------------------------------------------------+----------------------- Comment (by cbravobernal): The editor part PR is working fine when applying this patch. https://github.com/WordPress/gutenberg/pull/44854#issuecomment-1283827792 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 11:27:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 11:27:24 -0000 Subject: [wp-trac] [WordPress Trac] #56850: pluggable.php - Deprecated errors on PHP 8.1 In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.1f6fe772953bcce88440cf282b0c6bf7@wordpress.org> #56850: pluggable.php - Deprecated errors on PHP 8.1 ------------------------------------+------------------------------ Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch php81 | Focuses: ------------------------------------+------------------------------ Changes (by SergeyBiryukov): * keywords: has-patch => has-patch php81 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 11:38:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 11:38:30 -0000 Subject: [wp-trac] [WordPress Trac] #56850: pluggable.php - Deprecated errors on PHP 8.1 In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.0f47c0a6bf20df091ea686fa48878caf@wordpress.org> #56850: pluggable.php - Deprecated errors on PHP 8.1 ------------------------------------+------------------------------ Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------------+------------------------------ Changes (by lenasterg): * keywords: has-patch php81 => has-patch Comment: Hi @TobiasBg The {{{null}}} comes from https://core.trac.wordpress.org/browser/trunk/src/wp-includes/user.php#L95 from inside the {{{function wp_signon}}}. The line 95 {{{#!php $user = wp_authenticate( $credentials['user_login'], $credentials['user_password'] ); }}} where both {{{$credentials['user_login'], &$credentials['user_password']}}} are {{{NULL}}} when a user access the wp-login.php page for first time. The {{{wp_signon function}}} is called in https://core.trac.wordpress.org/browser/trunk/src/wp-login.php#L1231 with an empty array as $credentials argument. Line 1231 is: {{{$user = wp_signon( array(), $secure_cookie );}}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 11:42:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 11:42:38 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.faa1851f2bef965a8088855e2a63955a@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: commit has-patch | Focuses: ------------------------------+---------------------------- Comment (by SergeyBiryukov): In [changeset:"54645" 54645]: {{{ #!CommitTicketReference repository="" revision="54645" Help/About: Restore the correct header image for WordPress 6.1. The new About header image appears to have been accidentally reverted to the older one in a previous commit. Follow-up to [54635], [54638]. Props kebbet. See #56703. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 11:45:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 11:45:32 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.cd9c9efe76d8e73fcfc7aa1b10095a61@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 -------------------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: commit has-patch dev-feedback | Focuses: -------------------------------------------+---------------------------- Changes (by SergeyBiryukov): * keywords: commit has-patch => commit has-patch dev-feedback Comment: Marking [54645] for backporting to the 6.1 branch after a second committer's review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 11:56:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 11:56:24 -0000 Subject: [wp-trac] [WordPress Trac] #56850: pluggable.php - Deprecated errors on PHP 8.1 In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.adca3a328bce336da2acd09696aa22e0@wordpress.org> #56850: pluggable.php - Deprecated errors on PHP 8.1 ------------------------------------+------------------------------ Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch php81 | Focuses: ------------------------------------+------------------------------ Changes (by SergeyBiryukov): * keywords: has-patch => has-patch php81 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 12:25:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 12:25:35 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.f648e98de14aa23df0b217806b0ceb9b@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+------------------------------ Reporter: Bernhard Reiter | Owner: Bernhard Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by SergeyBiryukov): In [changeset:"54646" 54646]: {{{ #!CommitTicketReference repository="" revision="54646" Editor: Add font size constraints for fluid typography. This commit: * Adds default minimum font size limits so that min font size, where provided, does not become smaller than `14px`/`0.875rem`/`0.875em`. * For font sizes of `< 14px` that have no defined minimum sizes, uses the font size to set the floor of the `clamp()` value. This bugfix prevents converting existing small font sizes to clamp values that will reduce their font size even further in narrow widths. It therefore improves backward compatibility and accessibility. Original PR from Gutenberg repository: * [https://github.com/WordPress/gutenberg/pull/44993 #44993 Fluid typography: add font size constraints] Follow-up to [54260], [54360], [54497], [54500]. Props ramonopoly, andrewserong, isabel_brison, Joen, bernhard-reiter. See #56467. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 12:28:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 12:28:20 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.fd1ef034dbee29b0607fd7976951984c@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+------------------------------ Reporter: Bernhard Reiter | Owner: Bernhard Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by SergeyBiryukov): In [changeset:"54647" 54647]: {{{ #!CommitTicketReference repository="" revision="54647" Editor: Add font size constraints for fluid typography. This commit: * Adds default minimum font size limits so that min font size, where provided, does not become smaller than `14px`/`0.875rem`/`0.875em`. * For font sizes of `< 14px` that have no defined minimum sizes, uses the font size to set the floor of the `clamp()` value. This bugfix prevents converting existing small font sizes to clamp values that will reduce their font size even further in narrow widths. It therefore improves backward compatibility and accessibility. Original PR from Gutenberg repository: * [https://github.com/WordPress/gutenberg/pull/44993 #44993 Fluid typography: add font size constraints] Follow-up to [54260], [54360], [54497], [54500]. Props ramonopoly, andrewserong, isabel_brison, Joen, bernhard-reiter. Reviewed by bernhard-reiter, SergeyBiryukov. Merges [54646] to the 6.1 branch. See #56467. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 12:55:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 12:55:04 -0000 Subject: [wp-trac] [WordPress Trac] #56851: link_updated not recording a timestamp Message-ID: <053.46d089337f169c10cdeef5a921f72a31@wordpress.org> #56851: link_updated not recording a timestamp ----------------------------+----------------------------- Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: trunk Severity: normal | Keywords: has-patch Focuses: | ----------------------------+----------------------------- Suggested patch fix for the issued described in https://wordpress.org/support/topic/link_updated-not- recording-a-timestamp/ by @publicradio {{{ I have noticed that when I add or update a link, and then print_r get_bookmarks, every link object in the array has [link_updated] => 0000-00-00 00:00:00 and this will never update, even if I update the link. Is there a way I can get the links manager to actually record when the link was updated? }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 13:10:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 13:10:22 -0000 Subject: [wp-trac] [WordPress Trac] #56852: Support IDs in block wrapper attributes Message-ID: <049.0f97ad94a1c1d4753b96a1a895df9735@wordpress.org> #56852: Support IDs in block wrapper attributes -------------------------+----------------------------- Reporter: Soean | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- At the moment dynamic rendered blocks don't support [[https://developer.wordpress.org/block-editor/reference-guides/block-api /block-supports/#anchor|anchors]]. To enable this support, we need to add this feature to the Editor and add the ''id'' in ''get_block_wrapper_attributes()'' to the block. I already created a PR to add this support to the editor: https://github.com/WordPress/gutenberg/pull/44771 This ticket is for adding it to the renderd block HTML. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 13:36:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 13:36:55 -0000 Subject: [wp-trac] [WordPress Trac] #56853: In Twenty Two Theme: Latest Post block alignment issue occur on front end side. Message-ID: <057.f1731f6231d4762bea4200aa38031a0e@wordpress.org> #56853: In Twenty Two Theme: Latest Post block alignment issue occur on front end side. ---------------------------+----------------------------- Reporter: multidots1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Keywords: has-screenshots Focuses: | ---------------------------+----------------------------- 1)Activate Twenty Twenty Two theme 2)In page editor add Latest post block and align it as right. 3)Add Calendar block and checking the page on front end side. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 13:38:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 13:38:00 -0000 Subject: [wp-trac] [WordPress Trac] #56853: In Twenty Two Theme: Latest Post block alignment issue occur on front end side. In-Reply-To: <057.f1731f6231d4762bea4200aa38031a0e@wordpress.org> References: <057.f1731f6231d4762bea4200aa38031a0e@wordpress.org> Message-ID: <072.82dd7f8be38fe35166dce7e1b2d1e91f@wordpress.org> #56853: In Twenty Two Theme: Latest Post block alignment issue occur on front end side. -----------------------------+------------------------------ Reporter: multidots1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: -----------------------------+------------------------------ Changes (by multidots1896): * Attachment "CleanShot 2022-10-19 at 19.02.16.mp4" added. Added screen recording clip -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 14:51:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 14:51:56 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.38ba912157cc6a477d1d176088390463@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 -------------------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: commit has-patch dev-reviewed | Focuses: -------------------------------------------+---------------------------- Changes (by ryelle): * keywords: commit has-patch dev-feedback => commit has-patch dev-reviewed Comment: Looks good, I can do the backport commit. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 14:58:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 14:58:29 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.255b7e8a8b4d658c308e3c6b966af0a4@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 -------------------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: closed Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: commit has-patch dev-reviewed | Focuses: -------------------------------------------+---------------------------- Changes (by ryelle): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54648" 54648]: {{{ #!CommitTicketReference repository="" revision="54648" Help/About: Restore the correct header image for WordPress 6.1. The new About header image appears to have been accidentally reverted to the older one in a previous commit. Follow-up to [54635], [54638]. Props kebbet. Reviewed by SergeyBiryukov, ryelle. Merges [54645] to the 6.1 branch. Fixes #56703. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 15:20:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 15:20:01 -0000 Subject: [wp-trac] [WordPress Trac] #50396: Can't regenerate "-scaled.jpg" images In-Reply-To: <052.58f085a68e4f9827b229e5cdf6bfc71d@wordpress.org> References: <052.58f085a68e4f9827b229e5cdf6bfc71d@wordpress.org> Message-ID: <067.66dba3f2887547d8e8d89e8b45aa7ea8@wordpress.org> #50396: Can't regenerate "-scaled.jpg" images -------------------------------+------------------------------ Reporter: mattiasf | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.4.2 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by antpb): * keywords: => reporter-feedback Comment: Hi @mattiasf ! I wanted to check in on this and see if this was still an issue for you. I noticed in another ticket that you opened the image did exist and the wpcli command to regenerate was not finding the original image? Did that result in a WPCLI ticket to investigate? Would appreciate a link to that if so! Do you think you could provide a sample image that is causing the issue with some reproduction steps to outline how to see this behavior. As far as I see taking happy paths it seems to be holding the original. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 15:26:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 15:26:52 -0000 Subject: [wp-trac] [WordPress Trac] #50419: Bug on image processing In-Reply-To: <051.92e79c15b3986dcb553c5d3647a56736@wordpress.org> References: <051.92e79c15b3986dcb553c5d3647a56736@wordpress.org> Message-ID: <066.1c98ec3d49a737c49e6255dc1ca72f31@wordpress.org> #50419: Bug on image processing -------------------------------+------------------------------ Reporter: fotisps | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.4.2 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Changes (by antpb): * keywords: => reporter-feedback Comment: Hi @fotisps ! During a recent bug scrub in the Media component we reviewed this ticket and found it similar to one that was fixed roughly the same time as this one. Can you confirm that this is still happening? And if so, could you provide a sample image that causes the error and some information about your server configuration? PHP version and any other information would be most helpful. If this is fixed now, we'll close this out. Awaiting your confirmation :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 15:29:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 15:29:46 -0000 Subject: [wp-trac] [WordPress Trac] #50518: Lost track of media files if having different media galleries in Gutenberg Editor In-Reply-To: <053.951f28533d97c4430dd3ec219e91aa7d@wordpress.org> References: <053.951f28533d97c4430dd3ec219e91aa7d@wordpress.org> Message-ID: <068.ae2ae3020053090f4f0a1f130b91bfbc@wordpress.org> #50518: Lost track of media files if having different media galleries in Gutenberg Editor ---------------------------------------------+----------------------------- Reporter: ninjateam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 5.4.2 Severity: normal | Resolution: Keywords: needs-testing reporter-feedback | Focuses: javascript ---------------------------------------------+----------------------------- Changes (by joedolson): * keywords: needs-testing dev-feedback => needs-testing reporter-feedback Comment: I just tested this against the current 6.1 release candidate, and could not reproduce the issue. Can you confirm whether this is still an issue? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 15:44:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 15:44:52 -0000 Subject: [wp-trac] [WordPress Trac] #50705: Uncaught TypeError: attrs.ids.split is not a function at media-editor.js:385 In-Reply-To: <052.8356257a3b64a9486bccdad5f7f41170@wordpress.org> References: <052.8356257a3b64a9486bccdad5f7f41170@wordpress.org> Message-ID: <067.d614171080c5b84cf69544c620599803@wordpress.org> #50705: Uncaught TypeError: attrs.ids.split is not a function at media- editor.js:385 --------------------------+----------------------------- Reporter: dxwnh157 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Media | Version: 5.4.2 Severity: normal | Resolution: worksforme Keywords: | Focuses: ui, javascript --------------------------+----------------------------- Changes (by antpb): * status: new => closed * resolution: => worksforme * milestone: Awaiting Review => Comment: Thank you for this report @dxwnh157 ! This seems to have been fixed with some changes to how the data is handled. Single image galleries seem to be allowing the edit now. I am going to close this but if it is still happening for you on WordPress 6.2 RC 1 please let us know! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 15:51:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 15:51:55 -0000 Subject: [wp-trac] [WordPress Trac] #50893: wp_send_json_success is nothing, no error for any inf/nan In-Reply-To: <054.1a1273c90fd5528233aeb9ef5d9e8d5d@wordpress.org> References: <054.1a1273c90fd5528233aeb9ef5d9e8d5d@wordpress.org> Message-ID: <069.aec67901b0d91b82b278ccd275f6e376@wordpress.org> #50893: wp_send_json_success is nothing, no error for any inf/nan --------------------------+------------------------------ Reporter: programmin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.2.5 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by antpb): * component: Media => General Comment: Moving this to General as it does not seem to have a dependency on the Media component logic. This seems more related to any json returned from any case using this function. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 16:00:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 16:00:41 -0000 Subject: [wp-trac] [WordPress Trac] #51780: Add ability to easily get path to sized images (such as parameter to get_attached_file() or wp_get_attachment_thumb_file()) In-Reply-To: <057.e3e0b54d56998ce62fc4b4d15d4aa2e3@wordpress.org> References: <057.e3e0b54d56998ce62fc4b4d15d4aa2e3@wordpress.org> Message-ID: <072.34056d0c6e3626aac6153b26442a45f8@wordpress.org> #51780: Add ability to easily get path to sized images (such as parameter to get_attached_file() or wp_get_attachment_thumb_file()) ---------------------------+--------------------- Reporter: paulschreiber | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Media | Version: 5.5.3 Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+--------------------- Changes (by antpb): * milestone: Awaiting Review => 6.2 Comment: Moving this to 6.2 so we can investigate a new function for paths that meets the intent of the suggestions of this ticket. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 16:16:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 16:16:24 -0000 Subject: [wp-trac] [WordPress Trac] #56813: Heading Block Margin Issue In-Reply-To: <058.e4cdfd1b9a9f249021b1eba0644255ae@wordpress.org> References: <058.e4cdfd1b9a9f249021b1eba0644255ae@wordpress.org> Message-ID: <073.24d619462af275be26c4bd25055d4d9c@wordpress.org> #56813: Heading Block Margin Issue ----------------------------+------------------------------ Reporter: piyushpatel123 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+------------------------------ Changes (by ironprogrammer): * keywords: reporter-feedback => * focuses: ui => * component: General => Editor Comment: Here are some screenshots that show the workaround described by @poena in comment:2. [[Image(https://cldup.com/UV2xf64BRh.png)]] ''Figure 1: Editor - Heading with 70px left margin, nested within a Group block with "Inner blocks use content width" **disabled**.'' [[Image(https://cldup.com/kwOMOwm3N6.png)]] ''Figure 2: Frontend - Nested Heading's 70px left margin is observed.'' As stated earlier, this isn't a bug, but does leave room for improvement in how the editor can convey the end result of applied margins. At this time it's pretty subtle, temporarily displaying a blue margin gap, as shown here: [[Image(https://cldup.com/YDEwyY5HsF.gif)]] ''Figure 3: Editor - Interface feedback when margin is adjusted.'' I'll remove `reporter-feedback` for now, and suggest this be closed with follow-up over in [https://github.com/WordPress/gutenberg/issues/new/choose Gutenberg Issues] as an enhancement to improve the UI feedback. What do you think, @poena? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 18:10:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 18:10:59 -0000 Subject: [wp-trac] [WordPress Trac] #56820: Remove use of save-state and set-output in GitHub Actions In-Reply-To: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> References: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> Message-ID: <066.4dca11f40907471507914823e0d9cb86@wordpress.org> #56820: Remove use of save-state and set-output in GitHub Actions ------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+----------------------- Comment (by desrosj): In [changeset:"54649" 54649]: {{{ #!CommitTicketReference repository="" revision="54649" Build/Test Tools: Remove use of `set-output` in Action workflows. The `save-state` and `set-output` commands have been deprecated in GitHub Actions. This removes all occurrences of the command within workflow steps. This will not remove all deprecated notices from workflow summaries (some third-party actions still contain instances of these commands and need to be fixed upstream), but it will fix the notices caused by custom workflow code. See #56820. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 18:15:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 18:15:37 -0000 Subject: [wp-trac] [WordPress Trac] #56854: I cannot edit comments thru admin menu Message-ID: <063.ad885703a551910670e5a493fa5b0a5d@wordpress.org> #56854: I cannot edit comments thru admin menu ---------------------------------+----------------------------- Reporter: strongwomancrushing | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Database | Version: Severity: normal | Keywords: needs-patch Focuses: | ---------------------------------+----------------------------- After the the last update i cannot open the https://www.[mysite].com/wp- admin/edit-comments.php I received an error 502. After I enabled the debug I saw this error: SELECT COUNT(*) FROM wp_comments LEFT JOIN wp_posts AS wp_posts_to_exclude_reviews ON comment_post_ID = wp_posts_to_exclude_reviews.ID WHERE ( ( comment_approved = '0' OR comment_approved = '1' ) ) AND user_id = 2 AND comment_type != 'order_note' AND comment_type != 'webhook_delivery' AND wp_posts_to_exclude_reviews.post_type NOT IN ('product') AND wp_posts.post_type <> 'wc_user_membership' ORDER BY wp_comments.comment_date_gmt DESC How I can address this problem? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 18:15:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 18:15:57 -0000 Subject: [wp-trac] [WordPress Trac] #56854: I cannot edit comments thru admin menu In-Reply-To: <063.ad885703a551910670e5a493fa5b0a5d@wordpress.org> References: <063.ad885703a551910670e5a493fa5b0a5d@wordpress.org> Message-ID: <078.d928fdacf101f3a44eb19e7c04cb9d36@wordpress.org> #56854: I cannot edit comments thru admin menu ---------------------------------+------------------------------ Reporter: strongwomancrushing | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Database | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: ---------------------------------+------------------------------ Changes (by strongwomancrushing): * Attachment "website-info.txt" added. Website info -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 18:19:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 18:19:00 -0000 Subject: [wp-trac] [WordPress Trac] #56816: Correct references to npm and Node.js In-Reply-To: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> References: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> Message-ID: <066.cfa4213637b5fe1eb7db27e1b2a0b649@wordpress.org> #56816: Correct references to npm and Node.js --------------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch | Focuses: docs --------------------------------------+---------------------- Changes (by desrosj): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"54650" 54650]: {{{ #!CommitTicketReference repository="" revision="54650" General: Correctly refer to “npm” and “Node.js”. This update all references to npm and Node.js to their correct spelling. Fixes #56816. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 18:22:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 18:22:09 -0000 Subject: [wp-trac] [WordPress Trac] #56854: I cannot edit comments thru admin menu In-Reply-To: <063.ad885703a551910670e5a493fa5b0a5d@wordpress.org> References: <063.ad885703a551910670e5a493fa5b0a5d@wordpress.org> Message-ID: <078.1bcbf48d5c8e44edf919411b4913f334@wordpress.org> #56854: I cannot edit comments thru admin menu ---------------------------------+------------------------------ Reporter: strongwomancrushing | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: ---------------------------------+------------------------------ Changes (by joyously): * component: Database => General Comment: It looks like you have a plugin that is modifying the SQL. You can deactivate the plugin that creates the `wc_user_membership` post type and see if it works. (and ask at the plugin's support forum for help) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 18:26:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 18:26:43 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.737423e586b9b9d5e683ff6418377308@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------+--------------------- Comment (by desrosj): In [changeset:"54651" 54651]: {{{ #!CommitTicketReference repository="" revision="54651" Build/Test Tools: Update third-party `welcome` Action. This updates the third-party action used to post a welcome message to pull requests opened by first time contributors. This release updates the action to use Node.js version 16 instead of 12, the latter of which support has been deprecated for in GitHub Action runners. The action has also changed from `bukboo/welcome-action` to `wow- action/welcome`. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 18:30:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 18:30:10 -0000 Subject: [wp-trac] [WordPress Trac] #56850: pluggable.php - Deprecated errors on PHP 8.1 In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.044e587a92706a52f79a874e22764280@wordpress.org> #56850: pluggable.php - Deprecated errors on PHP 8.1 ------------------------------------+------------------------------ Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch php81 | Focuses: ------------------------------------+------------------------------ Comment (by TobiasBg): Thanks for the background on this, @lenasterg! I'm not sure why the login form, needs to pass empty arguments here, but I assume that it would be "too late" to change this anyways, for backwards compatibility reasons (as the filter hooks that run during the request) might be overriding the calls to perform some custom authentication. Your proposed changes do make sense, therefore. It might be worth updating the function's docblock then as well, to clarify that `null` is a possible parameter value/type. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 18:48:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 18:48:43 -0000 Subject: [wp-trac] [WordPress Trac] #44230: Export Personal Data Flaw In-Reply-To: <052.0c1a53aed61fe4ea2ce191eb8f09cb4b@wordpress.org> References: <052.0c1a53aed61fe4ea2ce191eb8f09cb4b@wordpress.org> Message-ID: <067.21c71b177dede49e700763d2bacbeebf@wordpress.org> #44230: Export Personal Data Flaw --------------------------+---------------------- Reporter: psycleuk | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Privacy | Version: 4.9.6 Severity: major | Resolution: wontfix Keywords: | Focuses: --------------------------+---------------------- Changes (by iandunn): * status: new => closed * resolution: => wontfix * milestone: Awaiting Review => Comment: Calling the brute-force-resistant file names security-through-obscurity seems analogous to saying that HTTPS traffic on a WiFi network is open to anyone. It's true that ''technically'' anybody can read it, but ''in practice'' the encryption makes it secure enough for common use. Mitigations have to adapt to fit the circumstances, and a formal ACL would add extra complexity and degrade UX without adding any tangible benefit. WP is [https://wordpress.org/about/philosophy/ designed for the majority], but the beauty of the plugin system is that anybody can write something to add additional security here for environments that require it. If you feel like this affects the majority, then I'd challenge you to produce a PoC that demonstrates it in the wild. If you can, then we could definitely consider adding stronger measures! If you are able to, please share it privately on https://hackerone.com/wordpress, so we can add those measures before the PoC becomes public. The file-deletion vulnerability you mentioned was fixed in `4.9.7`. The `index.html` file was renamed to `index.php` in #52299 to protect against the configurations you mentioned. I'm going to close this since it seems like there's a consensus among component maintainers and committers. That just means there isn't anything actionable right now, though. We can continue discussing it, and could reopen this if a compelling argument is made or new information is presented. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 19:32:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 19:32:06 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 Message-ID: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> #56855: Featured Image bug in 6.0.3 --------------------------+----------------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.0.3 Severity: minor | Keywords: Focuses: | --------------------------+----------------------------- Hi, after the 6.0.3 update, the Featured Image block shows some bugs in respect to image sizing. regardless of your choice of a “Scale” option, it will always behave as if the selected option is “Fill”. AFAIK this only happens in blocks inserted in the page, not default blocks, built in the themes. It also seems to happen in hooks. This also happens on clean fresh installs. To replicate: create a new post, insert a Featured Image in it, set the height at 100px and the scale as “Cover”. provided the image is taller than 100px, it will be stretched in the preview and the live post. To fix: reverting to 6.0.2 seems to have fixed it. i suppose inserting some object-fit CSS should work as well, did not try it. thanks, R PS i also created a forum topic before actually reading the "read this" sticky :| https://wordpress.org/support/topic/featured-image-bug-in-6-0-3/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 19:41:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 19:41:56 -0000 Subject: [wp-trac] [WordPress Trac] #56856: Blogger Importer: File class-feed.php is deprecated Message-ID: <058.f9bd6fa12938400438634f17d220f85c@wordpress.org> #56856: Blogger Importer: File class-feed.php is deprecated ----------------------------+--------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: WordPress.org Component: Import | Version: 4.7 Severity: normal | Keywords: needs-patch Focuses: | ----------------------------+--------------------------- The Blogger Importer plugin (tested v0.9) causes the following deprecation notice: PHP Deprecated: File class-feed.php is deprecated since version 4.7.0! Use fetch_feed() instead. in ../wp- includes/functions.php on line 5577 `class-feed.php` was deprecated in [39449]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 20:24:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 20:24:34 -0000 Subject: [wp-trac] [WordPress Trac] #50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug In-Reply-To: <049.c655f2733387fd73b8a4dac9c524df1d@wordpress.org> References: <049.c655f2733387fd73b8a4dac9c524df1d@wordpress.org> Message-ID: <064.c2fea57632caea49a59c9f59cce393ee@wordpress.org> #50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug --------------------------+------------------------------ Reporter: arena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Feeds | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+------------------------------ Comment (by ironprogrammer): As pointed out in comment:30, SimplePie in core was updated to v1.5.6 in [49176], outdating the original intent of this ticket. Propose closing with `wontfix`. Related: As of this writing, #55604 has already been planned to update core to v1.6.0, and the library has just released [https://github.com/simplepie/simplepie/releases/tag/1.7.0 v1.7.0]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 20:26:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 20:26:21 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.deba459b464a89d9e16ea23f86eb18aa@wordpress.org> #56855: Featured Image bug in 6.0.3 --------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0.4 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by audrasjb): * milestone: Awaiting Review => 6.0.4 Comment: Hello, welcome to WordPress Core Trac and thank you for reporting this. As per today's devchat, it appears your issue was reproduced at least by @pbiron. Moving to the next minor release milestone. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 20:28:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 20:28:23 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.e3de2a0adb77924b13cab7289d0b33ff@wordpress.org> #56855: Featured Image bug in 6.0.3 --------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by audrasjb): * milestone: 6.0.4 => 6.1 Comment: Moving to 6.1 as this might come first :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 20:37:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 20:37:30 -0000 Subject: [wp-trac] [WordPress Trac] #50667: New attachment size is created even the source is smaller In-Reply-To: <055.e5d8dff51dae2848d28e1e691c489969@wordpress.org> References: <055.e5d8dff51dae2848d28e1e691c489969@wordpress.org> Message-ID: <070.cc5fc0d9c3fdf239f8c3e7b91838fd35@wordpress.org> #50667: New attachment size is created even the source is smaller --------------------------+------------------------------ Reporter: adam.radocz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.4.2 Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance --------------------------+------------------------------ Comment (by adamsilverstein): Hi @adamradocz - thanks for opening the ticket and providing the sample image. > When you upload a very optimized image sometimes the created attachment size's file size is larger than the source image Can you clarify which image (size) you are referring to? When uploading, core typically creates numerous sizes (the default core size + any custom sizes added by your theme or plugins). Are you inserting/using the "full" sized image? Can you please provide exact steps to reproduce? Where are you seeing the larger created image (on the server only, or is it used on the website frontend)? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 20:45:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 20:45:55 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.25afddfbeda76b9d5a08757e39bdc744@wordpress.org> #56855: Featured Image bug in 6.0.3 --------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by pbiron): * Attachment "56855.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 20:50:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 20:50:13 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.c52dd2ee560745c98ee9988aabc016ee@wordpress.org> #56855: Featured Image bug in 6.0.3 --------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by pbiron): The problem reported here seems to be that the security fixes in 6.0.3 added a call to [https://developer.wordpress.org/reference/functions/safecss_filter_attr/ safecss_filter_attr()] in the render callback for the featured image block and that the `object-fit` CSS is stripped out by `safecss_filter_attr()`. [attachment:"56855.diff"] adds `object-fit` to the list of allowed CSS properties, so that `safecss_filter_attr()` no longer strips it out. As the the addition of the call to `safecss_filter_attr()` was added for security reasons, the WP security team should double check the patch to make sure it doesn't open any vulnerabilities. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 20:58:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 20:58:18 -0000 Subject: [wp-trac] [WordPress Trac] #56816: Correct references to npm and Node.js In-Reply-To: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> References: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> Message-ID: <066.0c05210a1d4aaf33a899d227f3906b8d@wordpress.org> #56816: Correct references to npm and Node.js --------------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch | Focuses: docs --------------------------------------+---------------------- Comment (by SergeyBiryukov): It looks like props were missed in the commit, I have corrected that manually in the Core Props tool on make/core. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 20:58:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 20:58:34 -0000 Subject: [wp-trac] [WordPress Trac] #56857: Blogger Importer: File class-wp-feed-cache.php is deprecated Message-ID: <058.3d43f2453b7857a98619d91b603e01a4@wordpress.org> #56857: Blogger Importer: File class-wp-feed-cache.php is deprecated ----------------------------+--------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: WordPress.org Component: Import | Version: 5.6 Severity: normal | Keywords: needs-patch Focuses: | ----------------------------+--------------------------- The Blogger Importer plugin (tested v0.9) causes the following deprecation notice: PHP Deprecated: File class-wp-feed-cache.php is deprecated since version 5.6.0 with no alternative available. This file is only loaded for backward compatibility with SimplePie 1.2.x. Please consider switching to a recent SimplePie version. in ../wp-includes/functions.php on line 5587 `class-wp-feed-cache.php` was deprecated in [49565]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 21:09:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 21:09:48 -0000 Subject: [wp-trac] [WordPress Trac] #56816: Correct references to npm and Node.js In-Reply-To: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> References: <051.862ffe181d9f46ebab8c6f7922ab37fa@wordpress.org> Message-ID: <066.19b51880ace4578514109cfc0cca38fc@wordpress.org> #56816: Correct references to npm and Node.js --------------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch | Focuses: docs --------------------------------------+---------------------- Comment (by desrosj): Thank you @SergeyBiryukov! I thought I had added them, but I guess not! That was definitely an accident. Thanks for the patch @aleksganev! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 21:12:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 21:12:11 -0000 Subject: [wp-trac] [WordPress Trac] #56733: oEmbed: Add support for Tumblr reader URLs In-Reply-To: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> References: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> Message-ID: <064.e8b2916c1a93b215c9238b18c51bd494@wordpress.org> #56733: oEmbed: Add support for Tumblr reader URLs ------------------------------------+----------------------- Reporter: pento | Owner: pento Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Embeds | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch dev-reviewed | Focuses: ------------------------------------+----------------------- Changes (by Bernhard Reiter): * keywords: has-patch needs-review needs-testing => has-patch dev-reviewed Comment: I've tested the [https://core.trac.wordpress.org/attachment/ticket/56733/56733.2.diff updated patch]. Note that WordPress caches oEmbeds (in the corresponding post’s post meta), so we’re taking that into account in the following instructions. On `trunk`: - Create a new post. - Switch to the Code Editor (this is to prevent oEmbed expansion in the Visual Editor, which is handled separately but might prime the cache). - Insert two Tumblr URLs in separate formats, e.g. - https://photomatt.tumblr.com/post/696629352701493248/why-go-nuts-show- nuts-doesnt-work-in-2022 and - https://www.tumblr.com/photomatt/696629352701493248/why-go-nuts-show- nuts-doesnt-work-in-2022 - Do ''not'' switch back to the Visual Editor. Instead, publish the post directly from the Code Editor. - View the post. You should see the first URL properly expanded into the tumblr post’s oEmbed, but the second one un-expanded (just the URL). - Write down the post ID. We’ll refer to it as YOUR_POST_ID in the following. - In your terminal, verify that the post has oEmbed data cached in its post meta: {{{ npm run env:cli post meta list YOUR_POST_ID }}} - You should see a post meta table with a few entries starting with `_oembed_`. Something like {{{ +---------+-----------------------------------------------+------------------------------------------------------------------------------------------+ | post_id | meta_key | meta_value | +---------+-----------------------------------------------+------------------------------------------------------------------------------------------+ | 45 | _edit_lock | 1666213351:1 | | 45 | _oembed_1c805202e7bc7384a18e9127ac66fc0a |
https://photomatt.tumblr.com/post/696629352701493248/why-go- nuts-show-nuts-doe | | | | snt-work- in-2022
| | 45 | _oembed_time_1c805202e7bc7384a18e9127ac66fc0a | 1666213194 | | 45 | _oembed_897442790bd8799408ee0d764e295748 | {{unknown}} | +---------+-----------------------------------------------+------------------------------------------------------------------------------------------+ }}} - Now delete that post meta: {{{ npm run env:cli "post meta delete YOUR_POST_ID --all". }}} - Apply the [https://core.trac.wordpress.org/attachment/ticket/56733/56733.2.diff patch]. - Reload the post on the frontend. Verify that this time around, ''both'' URLs expand into their corresponding oEmbeds. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 21:16:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 21:16:25 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.2ef76af14280d887abc27e0d6502e79b@wordpress.org> #56855: Featured Image bug in 6.0.3 --------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by pbiron): * Attachment "56855.1.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 21:17:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 21:17:23 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.929088f12194fd3a5d6f7aff2e458c1a@wordpress.org> #56855: Featured Image bug in 6.0.3 --------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by pbiron): [attachment:"56855.1.diff"] adds a test case for `object-fit` to the dataProvider for the `test_safecss_filter_attr()` unit test. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 21:24:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 21:24:34 -0000 Subject: [wp-trac] [WordPress Trac] #56858: Blogger Importer: Undefined (dynamic) properties Message-ID: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> #56858: Blogger Importer: Undefined (dynamic) properties ----------------------------+------------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: WordPress.org Component: Import | Version: Severity: normal | Keywords: needs-patch php82 Focuses: | ----------------------------+------------------------------- Under PHP 7.4, the Blogger Importer plugin causes notices like the following: ''If new posts are imported:'' Undefined property: Blogger_Importer::$posts_done in ../blogger-importer /blogger-importer.php on line 408 == Background [https://github.com/WordPress/blogger- importer/commit/f1c9d6a7fe42fe4b88b475c9a92a96bd7cee8dba f1c9d6a7] introduced several dynamic properties to the `Blogger_Importer` class, such as counters for skipped and imported posts. In PHP 8.0 dynamic properties log as warnings, [https://php.watch/versions/8.2/dynamic-properties-deprecated in 8.2 as deprecations], and in 9.0 result in fatal errors. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 21:25:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 21:25:57 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.44949261f4d331f9bda669ee3a98b4ff@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Changes (by pbiron): * keywords: => has-patch needs-testing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 22:18:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 22:18:06 -0000 Subject: [wp-trac] [WordPress Trac] #22316: Plugin Dependencies (Yet Another Plugin Dependencies Ticket) In-Reply-To: <056.dd52dedca2457b5bc3a0cb986370b731@wordpress.org> References: <056.dd52dedca2457b5bc3a0cb986370b731@wordpress.org> Message-ID: <071.87766a62e8bac8735eeb8cb8cfc22b48@wordpress.org> #22316: Plugin Dependencies (Yet Another Plugin Dependencies Ticket) -------------------------------------------------+------------------------- Reporter: Viper007Bond | Owner: afragen Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Upgrade/Install | Version: 3.4.2 Severity: normal | Resolution: Keywords: dev-feedback has-patch early needs- | Focuses: design-feedback needs-dev-note has-unit-tests | -------------------------------------------------+------------------------- Comment (by matt): It's complicated, but a major unlock. What would be a way for us to test this out in core before fully committing to supporting it forever? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 22:35:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 22:35:42 -0000 Subject: [wp-trac] [WordPress Trac] #56723: 6.1 Dev Notes Tracking Issue In-Reply-To: <054.346f9a2f110c221b2751681e2e30cbb9@wordpress.org> References: <054.346f9a2f110c221b2751681e2e30cbb9@wordpress.org> Message-ID: <069.ceb52460ecdc63317f272d32801bb057@wordpress.org> #56723: 6.1 Dev Notes Tracking Issue ----------------------------+------------------------- Reporter: milana_cap | Owner: milana_cap Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: fixed Keywords: | Focuses: ----------------------------+------------------------- Comment (by webcommsat): Replying to [comment:40 sabernhardt]: Great dev note. Peer reviews done by @ironprogrammer and @webcommsat. Post ready to publish. > The [https://make.wordpress.org/core/?p=99777&preview=1&_ppp=5ab4f1e288 multisite registration note] could be complete, and I would appreciate help editing it. (If it's easier for you, you could comment on the [https://docs.google.com/document/d/1MMcxyj6RP1_9NJTbQlqYjEse39JvXu_4N6C3I6rozbo/edit# Google doc draft].) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 22:44:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 22:44:04 -0000 Subject: [wp-trac] [WordPress Trac] #22316: Plugin Dependencies (Yet Another Plugin Dependencies Ticket) In-Reply-To: <056.dd52dedca2457b5bc3a0cb986370b731@wordpress.org> References: <056.dd52dedca2457b5bc3a0cb986370b731@wordpress.org> Message-ID: <071.82493815c89be0c8a9700120de2beb0c@wordpress.org> #22316: Plugin Dependencies (Yet Another Plugin Dependencies Ticket) -------------------------------------------------+------------------------- Reporter: Viper007Bond | Owner: afragen Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Upgrade/Install | Version: 3.4.2 Severity: normal | Resolution: Keywords: dev-feedback has-patch early needs- | Focuses: design-feedback needs-dev-note has-unit-tests | -------------------------------------------------+------------------------- Comment (by afragen): Matt, We have a feature plugin [https://wordpress.org/plugins/wp-plugin- dependencies Plugin Dependencies] that allows for users to do a nearly complete test of the feature. I say nearly complete as we have also supplied examples for how to use this with premium plugins too. I will also refer to the 2 Make posts. [https://make.wordpress.org/core/2022/02/24/feature-project-plugin- dependencies/ Plugin Dependencies Feature Project] and [https://make.wordpress.org/core/2022/10/12/call-for-testing-plugin- dependencies/ Call for Testing: Plugin Dependencies]. Ping me anywhere. The team working on this is happy to answer any questions that you or anyone else may have. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 22:45:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 22:45:42 -0000 Subject: [wp-trac] [WordPress Trac] #56850: pluggable.php - Deprecated errors on PHP 8.1 In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.7a4f1783aa2011a348cd95a3802658e4@wordpress.org> #56850: pluggable.php - Deprecated errors on PHP 8.1 ------------------------------------+------------------------------ Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch php81 | Focuses: ------------------------------------+------------------------------ Changes (by SergeyBiryukov): * Attachment "56850.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 22:45:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 22:45:49 -0000 Subject: [wp-trac] [WordPress Trac] #56723: 6.1 Dev Notes Tracking Issue In-Reply-To: <054.346f9a2f110c221b2751681e2e30cbb9@wordpress.org> References: <054.346f9a2f110c221b2751681e2e30cbb9@wordpress.org> Message-ID: <069.666d049486b6111e41a273f1264fa163@wordpress.org> #56723: 6.1 Dev Notes Tracking Issue ----------------------------+------------------------- Reporter: milana_cap | Owner: milana_cap Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: General | Version: Severity: normal | Resolution: fixed Keywords: | Focuses: ----------------------------+------------------------- Comment (by audrasjb): @webcommsat the dev note looks good to me. I only added a few missing `` styles, directly by editing the post on Make/Core. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 22:50:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 22:50:35 -0000 Subject: [wp-trac] [WordPress Trac] #56850: PHP 8.1 deprecation notices from wp_signon() with default parameters (was: pluggable.php - Deprecated errors on PHP 8.1) In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.c7bb9c9955ac0067a4e27ed9b35cd7d5@wordpress.org> #56850: PHP 8.1 deprecation notices from wp_signon() with default parameters ------------------------------------+--------------------- Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Login and Registration | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch php81 | Focuses: ------------------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 Comment: Thanks for the ticket! I was able to reproduce the issue. * It looks like there are actually two deprecation notices here: * One from `preg_replace()` in `wp_strip_all_tags()` via `sanitize_user()` in `wp_authenticate()`: {{{ Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated }}} * One from `trim()` in `wp_authenticate()` itself: {{{ Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated }}} * The `$credentials['user_login']` and `$credentials['user_password']` parameters are passed by reference to the `wp_authenticate` action, and this is where the are [https://www.php.net/manual/en/language.references.pass.php#124383 created as `null` if they don't exist]. * Since the parameters are documented as strings in various places (`wp_authenticate` action, `secure_signon_cookie` filter, `wp_authenticate()` function, `authenticate` filter, etc.) is seems like a bug that they are created as `null` instead of an empty string. Documenting `null` as a possible value does not seem ideal, as it forces plugins to deal with the issue on their own instead of fixing it at the source. I believe the correct solution would be to create these parameters as an empty string instead, along the lines of similar fixes in [54351] and [54368]. See [attachment:"56850.diff"], which also includes a unit test. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 22:53:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 22:53:00 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.f12c695745148f355320f5aab848301e@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------------------+------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: ui, accessibility, commit | css, administration -------------------------------------+------------------------------------- Changes (by joedolson): * keywords: has-patch needs-testing => has-patch needs-testing commit Comment: Tested; looks good. Marking for commit. Good catch! I didn't check the max height issues carefully enough. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 22:57:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 22:57:44 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.817fcc6724a0c9d71e3996ca23c85ad6@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------------------+------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: ui, accessibility, commit dev-feedback | css, administration -------------------------------------+------------------------------------- Changes (by joedolson): * keywords: has-patch needs-testing commit => has-patch needs-testing commit dev-feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 19 23:59:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 19 Oct 2022 23:59:00 -0000 Subject: [wp-trac] [WordPress Trac] #56733: oEmbed: Add support for Tumblr reader URLs In-Reply-To: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> References: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> Message-ID: <064.93620397f5bbda818437f0be1dd3e211@wordpress.org> #56733: oEmbed: Add support for Tumblr reader URLs ------------------------------------+--------------------- Reporter: pento | Owner: pento Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Embeds | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch dev-reviewed | Focuses: ------------------------------------+--------------------- Changes (by pento): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54652" 54652]: {{{ #!CommitTicketReference repository="" revision="54652" Embeds: Broaden the Tumblr oEmbed matcher to include all Tumblr URL structures. Tumblr's oEmbed API correctly rejects invalid URLs, we can rely on that for the handful of cases that aren't embeddable URLs. Props cbravobernal, bernhard-reiter. Fixes #56733. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 00:03:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 00:03:11 -0000 Subject: [wp-trac] [WordPress Trac] #56733: oEmbed: Add support for Tumblr reader URLs In-Reply-To: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> References: <049.6fd0106ea10585a3e4ffc4511da9c2fd@wordpress.org> Message-ID: <064.6fafc4f28fc2ad9f1ca4b7ecf64f3afa@wordpress.org> #56733: oEmbed: Add support for Tumblr reader URLs ------------------------------------+--------------------- Reporter: pento | Owner: pento Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Embeds | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch dev-reviewed | Focuses: ------------------------------------+--------------------- Comment (by pento): In [changeset:"54653" 54653]: {{{ #!CommitTicketReference repository="" revision="54653" Embeds: Broaden the Tumblr oEmbed matcher to include all Tumblr URL structures. Tumblr's oEmbed API correctly rejects invalid URLs, we can rely on that for the handful of cases that aren't embeddable URLs. Props cbravobernal, bernhard-reiter. Merges [54652] to the 6.1 branch. Fixes #56733. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 00:05:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 00:05:07 -0000 Subject: [wp-trac] [WordPress Trac] #56859: Blocks: register_block_script_handle() does not account for symlinks Message-ID: <051.b1d12fcb4a2c316d2fb7cdc80e65a965@wordpress.org> #56859: Blocks: register_block_script_handle() does not account for symlinks --------------------------+----------------------------- Reporter: cr0ybot | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I love the fix added by #55513 and #54647 to detect if a block is being registered from a theme and to alter the enqueued URI appropriately. However, the way that a theme block is detected does not take symlinks into account. I have all of my custom themes/plugins in one location in my file system, and I symlink the folders I'm working on into a local WP install. I imagine there are other scenarios where a symlink might be used for theme folders as well. The output of `wp_normalize_path( get_theme_file_path() )` is the location of my local WP install: /Users/coryhughart/Dev/web/local/website/app/public/wp-content/themes /website-theme The output of `wp_normalize_path( realpath( dirname( $metadata['file'] ) . '/' . $script_path ) )` is the original path to the theme outside of the WP install: /Users/coryhughart/Dev/Blackbird/Client/website.com/website- theme/dist/blocks/hero/script.js Obviously symlink resolution is part of what `realpath` does. Is there a similar function/solution that could expand the path without resolving symlinks? Or is symlinking outside the scope of what is expected in a WordPress environment? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 00:20:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 00:20:55 -0000 Subject: [wp-trac] [WordPress Trac] #50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug In-Reply-To: <049.c655f2733387fd73b8a4dac9c524df1d@wordpress.org> References: <049.c655f2733387fd73b8a4dac9c524df1d@wordpress.org> Message-ID: <064.e92be6cf90dc554d243a549573a56523@wordpress.org> #50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug --------------------------+------------------------------ Reporter: arena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Feeds | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+------------------------------ Comment (by SergeyBiryukov): Related: [49565] / #29204. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 00:24:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 00:24:27 -0000 Subject: [wp-trac] [WordPress Trac] #56859: Blocks: register_block_script_handle() does not account for symlinks In-Reply-To: <051.b1d12fcb4a2c316d2fb7cdc80e65a965@wordpress.org> References: <051.b1d12fcb4a2c316d2fb7cdc80e65a965@wordpress.org> Message-ID: <066.be9121b11fa3a12b40779af56b8b7fab@wordpress.org> #56859: Blocks: register_block_script_handle() does not account for symlinks --------------------------+------------------------------ Reporter: cr0ybot | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by cr0ybot): Prior to the update that allows block registration in themes, I had been filtering `plugins_url` but also checking for symlinks with `is_link()` and `readlink()`. This doesn't really solve for expanding the path though. Here's that filter for reference. It's a bit of a blunt instrument, but it works. {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 00:48:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 00:48:17 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.42ae96277e0cd55165f646c56da108c6@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by flixos90): * status: closed => reopened * resolution: fixed => Comment: Unfortunately, it appears that this change has introduced a major performance regression. A few days ago I conducted a performance analysis comparing 6.1-RC1 (and yesterday RC2) to the latest 6.0 release, finding a regression of ~10% slower WordPress execution on average. Myself and several other folks have since looked at possible causes for the regression, and earlier today @spacedmonkey messaged me, suggesting that the changes for loading the textdomain from here are a major part of the problem. I looked into it further and they indeed are: * When using the en_US locale, `load_textdomain()` is (unnecessarily) called a ton of times (107 times in WP 6.1-RC2 vs 3 times in WP 6.0.3). * The regression makes a en_US site with WP 6.1-RC2 load **~9.4% slower** than with WP 6.0.3 (151.3ms vs 138.2ms). This makes it likely the only notable cause for the regression. * Using a hacked version of WP 6.1-RC2 with the relevant code bits replaced with the 6.0.3 code, performance for an en_US site is back to the levels from 6.0.3. * The regression is only present on en_US sites. For sites that use a locale that typically has translation files present, performance remains basically as before. * The problem is caused by the changes to `_load_textdomain_just_in_time()`, which uses the new `WP_Textdomain_Registry` class. Due to this notable regression, I propose to revert [53874] for now and resolve the underlying problem for WordPress 6.2. Since the problem only occurs for en_US sites, there's a good chance this issue should not present a major complexity to address. Of course, if there is a simple fix, we could try to get it into RC3 - the main point is that we either need to fix this right away or revert before the 6.1 stable launch. I will also upload a screenshot of the spreadsheet where I collected the data that led to this conclusion. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 00:50:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 00:50:31 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.a253763df51d47bd00ddfda3875f2221@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by flixos90): * Attachment "39210-wp61-regression.png" added. Data showing how the 6.1 implementation for this ticket causes a performance regression -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 01:20:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 01:20:43 -0000 Subject: [wp-trac] [WordPress Trac] #56860: Sodium Compat library is improperly loaded Message-ID: <061.ce1ea329f90fc6cae8ea633ce3c0f267@wordpress.org> #56860: Sodium Compat library is improperly loaded -------------------------------+----------------------------- Reporter: TimothyBlynJacobs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: 5.2 Severity: normal | Keywords: Focuses: | -------------------------------+----------------------------- In #45806 the sodium compat library was added to WordPress. The library is only [https://github.com/WordPress/wordpress- develop/blob/a7a9e7602c51785de5261c15d8a720c535e829bf/src/wp- includes/compat.php#L340 loaded] if the `sodium_crypto_box` function is not defined. This accounts for scenarios where a user doesn't have Sodium available at all in their PHP installation. However, it doesn't accomodate for users on PHP 7.2+ that have a Sodium available, but compiled against an older libsodium version. For example, one of our users has the latest version of the Sodium extension available, but v1.0.11 of libsodium. This means that the `sodium_crypto_aead_xchacha20poly1305_ietf_encrypt` function is not available, since libsodium didn't add support for it until v1.0.12 The sodium compat library provides a polyfill for this function, but since the user's installation has `sodium_crypto_box` defined, WordPress does not load the polyfill library at all. Based on my reading of the sodium compat library, there would be no harm in us ''always'' loading the library. The autoloader is dynamic based on the features available, and each polyfill function is wrapped in a `function_exists` check. However, if we still wanted to conditionally load the polyfill we could use a more specific function like `sodium_crypto_stream_xchacha20_xor`. Related: https://github.com/WordPress/two-factor/pull/389 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 01:22:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 01:22:24 -0000 Subject: [wp-trac] [WordPress Trac] #56023: Twenty Twenty-One: Default quote block style overrides citation color on the front. In-Reply-To: <049.e1f981c0e4c7077aed09eb6a5da6e98c@wordpress.org> References: <049.e1f981c0e4c7077aed09eb6a5da6e98c@wordpress.org> Message-ID: <064.9716933fe1a07d73d58113e8834ce39a@wordpress.org> #56023: Twenty Twenty-One: Default quote block style overrides citation color on the front. ----------------------------------------+---------------------------------- Reporter: poena | Owner: (none) Type: defect (bug) | Status: new Priority: low | Milestone: 6.2 Component: Bundled Theme | Version: Severity: minor | Resolution: Keywords: needs-patch good-first-bug | Focuses: ui, accessibility, | css ----------------------------------------+---------------------------------- Comment (by abubakar89): I am working on this @joedolson -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 01:31:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 01:31:13 -0000 Subject: [wp-trac] [WordPress Trac] #56743: Update jquery-migrate to version 3.4.0 In-Reply-To: <051.049995bd545e4599dea7c354a7c0c832@wordpress.org> References: <051.049995bd545e4599dea7c354a7c0c832@wordpress.org> Message-ID: <066.53208289862f57faf0849479390b58d5@wordpress.org> #56743: Update jquery-migrate to version 3.4.0 ----------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: External Libraries | Version: Severity: normal | Resolution: Keywords: good-first-bug needs-patch | Focuses: ----------------------------------------+--------------------- Comment (by abubakar89): @desrosj do I just update the version and create a pull request? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 02:39:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 02:39:22 -0000 Subject: [wp-trac] [WordPress Trac] #56858: Blogger Importer: Undefined (dynamic) properties In-Reply-To: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> References: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> Message-ID: <073.382b6830413d0cfd4ca08bc0c7874553@wordpress.org> #56858: Blogger Importer: Undefined (dynamic) properties -------------------------------+---------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: WordPress.org Component: Import | Version: Severity: normal | Resolution: Keywords: needs-patch php82 | Focuses: -------------------------------+---------------------------- Comment (by jrf): Sounds like something which should be reported in https://github.com/WordPress/blogger-importer instead ? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 05:40:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 05:40:29 -0000 Subject: [wp-trac] [WordPress Trac] #50823: Miss button add new post on page edit post (editor guttenberg) In-Reply-To: <058.87d0eabe4a8f82efd3af2af176e3eb76@wordpress.org> References: <058.87d0eabe4a8f82efd3af2af176e3eb76@wordpress.org> Message-ID: <073.40c5748596464e09e6e13d3c95ff133e@wordpress.org> #50823: Miss button add new post on page edit post (editor guttenberg) --------------------------+------------------------------------------------ Reporter: | Owner: audrasjb welitonmartins | Type: feature | Status: accepted request | Priority: normal | Milestone: Future Release Component: Editor | Version: 5.4.2 Severity: major | Resolution: Keywords: 2nd-opinion | Focuses: ui, accessibility, administration --------------------------+------------------------------------------------ Comment (by sabernhardt): The Gutenberg repository has a few related issues: - GB32099 added a button at the end of the Pre-Publish Check panel. - GB25368 requested guidance to add a button on the opposite side. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 05:47:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 05:47:51 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency In-Reply-To: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> References: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> Message-ID: <072.098ea6d47dc73c6503e59abc1a06b00a@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ---------------------------+------------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: minor | Resolution: Keywords: | Focuses: coding-standards ---------------------------+------------------------------- Comment (by costdev): `Tests_Folder_WpListCategories` is compliant with PSR-1, although we do have numerous `WP_Something` classes in Core that aren't. As the Handbook states the correct naming is `WpListCategories`, I think we should use this and address this topic when we begin work on reorganising the test suite as a whole. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 06:11:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 06:11:39 -0000 Subject: [wp-trac] [WordPress Trac] #56862: Docs: Default parameter value is missing for themes_api function Message-ID: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> #56862: Docs: Default parameter value is missing for themes_api function --------------------------+----------------------------- Reporter: rezakhan995 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: normal | Keywords: needs-patch Focuses: docs | --------------------------+----------------------------- In wp-admin/includes/theme.php file, themes_api() function inline document does not mention default `@param value. $args @param should have the default` value mentioned. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 06:13:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 06:13:24 -0000 Subject: [wp-trac] [WordPress Trac] #56862: Docs: Default parameter value is missing for themes_api function In-Reply-To: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> References: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> Message-ID: <070.03958ffaf2d3332f30022e701133f86c@wordpress.org> #56862: Docs: Default parameter value is missing for themes_api function --------------------------+------------------------------ Reporter: rezakhan995 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 2.8 Severity: normal | Resolution: Keywords: needs-patch | Focuses: docs --------------------------+------------------------------ Changes (by costdev): * version: 6.1 => 2.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 06:21:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 06:21:29 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page Message-ID: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> #56863: Issue on media page -------------------------------------+----------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Keywords: has-screenshots Focuses: ui, css, administration | -------------------------------------+----------------------------- Hi , when i am allowing to upload SVG image then image is not showing on media listing page. You can see mentioned SS and solution code with added **width: 60px;** in class table.media .column-title .media-icon img { max-width: 60px; height: auto; vertical-align: top; **width: 60px;** } -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 06:22:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 06:22:22 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.4ef3707c181a53d0a89a40cac23d1cbd@wordpress.org> #56863: Issue on media page -----------------------------+-------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Changes (by sumitsingh): * Attachment "Media-Library-‹-wpextended-—-WordPress.png" added. SVG issue on Media listing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 06:22:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 06:22:34 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.5c7a2012d9e621725f1f7133b0b390b4@wordpress.org> #56863: Issue on media page -----------------------------+-------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Description changed by costdev: Old description: > Hi , > > when i am allowing to upload SVG image then image is not showing on media > listing page. > > You can see mentioned SS and solution code with added **width: 60px;** in > class > > table.media .column-title .media-icon img { > max-width: 60px; > height: auto; > vertical-align: top; > **width: 60px;** > } New description: Hi , when i am allowing to upload SVG image then image is not showing on media listing page. You can see mentioned SS and solution code with added **width: 60px;** in class {{{#!css table.media .column-title .media-icon img { max-width: 60px; height: auto; vertical-align: top; width: 60px; // Proposed solution } }}} -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 06:22:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 06:22:43 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.dcd77950fba2d39bc0f5fbd74474be6e@wordpress.org> #56863: Issue on media page -----------------------------+-------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Changes (by sumitsingh): * Attachment "Media-Library-‹-wpextended-—-WordPress (1).png" added. Adter added width 60px issue fixed -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 06:26:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 06:26:59 -0000 Subject: [wp-trac] [WordPress Trac] #56862: Docs: Default parameter value is missing for themes_api function In-Reply-To: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> References: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> Message-ID: <070.46e44254e07a0f4532b5f683127c789e@wordpress.org> #56862: Docs: Default parameter value is missing for themes_api function ------------------------------+--------------------- Reporter: rezakhan995 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: 2.8 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: docs ------------------------------+--------------------- Changes (by costdev): * keywords: has-patch => has-patch commit -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 06:29:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 06:29:41 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.ff6434c7beb81a649a2f9499a60ca9b3@wordpress.org> #56863: Issue on media page -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, reporter-feedback | administration -------------------------------------+------------------------------------- Changes (by costdev): * keywords: has-screenshots => has-screenshots reporter-feedback Comment: > @sumitsingh when i am allowing to upload SVG image Can you confirm how you're doing this so that reproduction steps are accurate? Thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 06:59:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 06:59:48 -0000 Subject: [wp-trac] [WordPress Trac] #56864: I want to put comments in theme.json. Message-ID: <052.94346eff98504ccade1d5f3a28f269c3@wordpress.org> #56864: I want to put comments in theme.json. -----------------------------+----------------------------- Reporter: nendeb55 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- theme.json is getting complicated. It would be helpful to have a comment box to comment out the code or to review it later or have others review the code.Currently theme.json has an error when a comment is entered. So I would like to be able to put comments in theme.json and expect it to load correctly. [https://github.com/WordPress/wordpress- develop/blob/70dedb086602287f4e0ee97fbf477adda8310963/src/wp- includes/functions.php#L4545] Simple method with no consideration of security, null, etc. {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 07:00:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 07:00:20 -0000 Subject: [wp-trac] [WordPress Trac] #56865: $args taking effect too late in register_block_type_from_metadata Message-ID: <052.69a14ba6d6ca56e8f20d1f0b8a054148@wordpress.org> #56865: $args taking effect too late in register_block_type_from_metadata --------------------------+----------------------------- Reporter: aristath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- The `register_block_type_from_metadata` function accepts 2 arguments: * `$file_or_folder` * `$args` The `$file_or_folder` is a path the the `block.json` file, or the folder containing it. `$args` is an array of arguments that can be passed to the function in order to provide complimentary data. The problem right now is that `$args` are parsed too late: They get parsed after the scripts/styles have been registered, after all other calculations have been completed, right before we call `WP_Block_Type_Registry::get_instance()->register();`. The problem with the current approach is that `$args` are unable to register script/styles, or even be used to take part in all the processing that the `register_block_type_from_metadata` function does. As a side-effect, it's impossible to register a block by passing an array of arguments, without the presence of a `block.json` file. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 07:13:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 07:13:39 -0000 Subject: [wp-trac] [WordPress Trac] #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php Message-ID: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php ------------------------------+----------------------------- Reporter: rezakhan995 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: normal | Keywords: has-patch Focuses: coding-standards | ------------------------------+----------------------------- Updated comparison to strict comparison in conditions in wp-admin/update- core.php -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 07:15:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 07:15:56 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.bc8d31671567a7a5ebdd2246233bc227@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by ocean90): Replying to [comment:66 flixos90]: > * When using the en_US locale, `load_textdomain()` is (unnecessarily) called a ton of times (107 times in WP 6.1-RC2 vs 3 times in WP 6.0.3). Assuming you have no other plugins active, could you explain what calls these are? And why there are unnecessary? > * The regression is only present on en_US sites. For sites that use a locale that typically has translation files present, performance remains basically as before. That's actually a good point since the changes here will significantly improve the translation handling [https://wordpress.org/about/stats/#locales for the majority of our user base]. ''If'' there's some tradeoff this should also be taken into consideration. I think for the moment we should identify what the problem actually is and if it's not something that can be fixed before the release and/or in a follow-up release. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 07:21:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 07:21:38 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.33a476c2c133a416c8a469510d4fca70@wordpress.org> #56863: Issue on media page -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, reporter-feedback | administration -------------------------------------+------------------------------------- Comment (by sumitsingh): Hi @costdev, lot's of plugin availabel but i have used https://wordpress.org/plugins/wpextended/ plugin and enbale "SVG File Upload" Module. I am sharing Steps here. 1) Installed plugin - https://wordpress.org/plugins/wpextended/ 2) Go to WP Extended menu and enbale "SVG File Upload" Module. 3) Go to media page and upload SVG image 4) issue happning with list view. look like this(abc.com/wp- admin/upload.php?mode=list) I hope helpful above things Thank you -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 07:49:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 07:49:43 -0000 Subject: [wp-trac] [WordPress Trac] #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php In-Reply-To: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> References: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> Message-ID: <070.0c29eda650db4f2c0f0fe6898c676f81@wordpress.org> #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php --------------------------+------------------------------- Reporter: rezakhan995 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 4.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards --------------------------+------------------------------- Changes (by kebbet): * version: 6.1 => 4.5 Comment: Introduced in [36349] during 4.5 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 07:54:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 07:54:27 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.5719ca8c0f5030a823c6041630e7465f@wordpress.org> #56863: Issue on media page -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: invalid Keywords: has-screenshots | Focuses: ui, css, reporter-feedback | administration -------------------------------------+------------------------------------- Changes (by kebbet): * status: new => closed * resolution: => invalid Comment: This should be handled by the provider of the feature IMHO, in the example that is ”WP Extended”. So suggestion: close as `wontfix`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:12:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:12:38 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.b706c93ea92c5d5547729635a57b5b1c@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-10-20 at 08.56.52.png" added. Trace of the path -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:12:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:12:59 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.0861533c202541cdd4e98aa9f17565cb@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-10-19 at 23.51.11.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:13:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:13:25 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.cbb750673d26c96edc3a76762a64cdb9@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-10-19 at 23.48.49.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:13:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:13:58 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.2316c3579610138fa687af2bce9ec4bb@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-10-19 at 23.48.42.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:19:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:19:27 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.763be0aa4217046796293b9121d7210a@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by spacedmonkey): I have provided some screenshots of useful data. As you can see, removing this commit from code, as a massive performance boost and fixes the issues. My test site, using 2016 theme with a full home page, no translations, plugins or other config and single site. The issue, is every time a translated string is loaded, it does a call to `is_readable`. In this theme with lots of data, it is 900+ times on a single page load. If you had more posts per page, then more the page slows down. Unless this is an extremely simple fix, this commit should be reverted and put into another release. That could be 6.1.1 but it might have to wait until 6.2. I don't think the performance trade off is worth the translations benefits here. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:24:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:24:32 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.0350103fe82f7fd5d1a92af487b22c4d@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by kebbet): I can not reproduce this issue in trunk, follow instructions in ticket description. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:28:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:28:37 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.d6c51feb4cdc7a137c654d1d5f467519@wordpress.org> #56863: Issue on media page -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, reporter-feedback | administration -------------------------------------+------------------------------------- Changes (by sumitsingh): * status: closed => reopened * resolution: invalid => Comment: Hi @kebbet , Even issue when i am doing with filter. {{{#!php $filetype['ext'], 'type' => $filetype['type'], 'proper_filename' => $data['proper_filename'] ]; }, 10, 4 ); function cc_mime_types( $mimes ){ $mimes['svg'] = 'image/svg+xml'; return $mimes; } add_filter( 'upload_mimes', 'cc_mime_types' ); }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:30:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:30:51 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.18d8b1ab06d219793af8b787e83ec729@wordpress.org> #56863: Issue on media page -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, reporter-feedback | administration -------------------------------------+------------------------------------- Comment (by kebbet): When allowing SVG's, then also add CSS in your theme/plugin that targets your modifications. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:39:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:39:58 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.1a72cf6f09f718e726b628ba8da0ac9b@wordpress.org> #56863: Issue on media page -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, reporter-feedback | administration -------------------------------------+------------------------------------- Comment (by sumitsingh): Hey @kebbet , i am agree with you. but we need to check image width attribute things. why coming 1px width & height on svg image? You can see mentioned SS. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 08:40:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 08:40:21 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.9422bb7e9a42a1e9f8e73eafdd8cfa2e@wordpress.org> #56863: Issue on media page -------------------------------------+------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, reporter-feedback | administration -------------------------------------+------------------------------------- Changes (by sumitsingh): * Attachment "Screenshot-from-2022-10-20-14-07-40.png" added. check image width attribute things. why coming 1px width & height on svg image? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:01:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:01:55 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.d40858d918163d92efe9a5df75851a0a@wordpress.org> #56863: Issue on media page -----------------------------+-------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Changes (by costdev): * keywords: has-screenshots reporter-feedback => has-screenshots Comment: Thanks for the instructions @sumitsingh and for clarifying that this also occurs even without a plugin and just filters. For a couple of references to this in the tutorial space: - See the `fix_svg()` callback [https://wpengine.co.uk/resources/enable- svg-wordpress/#Step_2_Add_a_Code_Snippet here]. - See [https://css-tricks.com/snippets/wordpress/allow-svg-through- wordpress-media-uploader/ this article], and in particular: "Before WordPress 4.0, you also make them display properly in the Media grid. But that’s broken now. If anyone knows how to fix, let me know!" -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:20:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:20:48 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.ff5d7ea1f3b949542b432062ea124f63@wordpress.org> #56863: Issue on media page -----------------------------+-------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Comment (by kebbet): Duplicate of #24251 ? `wp_getimagesize` uses native PHP `getimagesize` and that does not support SVG's. Thats why `1px` I guess. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:27:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:27:01 -0000 Subject: [wp-trac] [WordPress Trac] #56867: Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php Message-ID: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> #56867: Docs: Default parameter not mentioned on trackback_response function on wp- trackback.php ----------------------------+----------------------------- Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.1 Severity: normal | Keywords: has-patch Focuses: docs | ----------------------------+----------------------------- This function (trackback_response) takes $error_message parameter and by default it is null and this is not mentioned on the inline doc. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:31:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:31:28 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.d6bd853ce0bd09ed2ee9853bd15f090a@wordpress.org> #56863: Issue on media page -----------------------------+-------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Comment (by sumitsingh): Hey @costdev , Thank you for above references tutorial We can do with below css. {{{ table.media .column-title .media-icon img[src$=".svg"] { width: 60px !important; } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:44:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:44:02 -0000 Subject: [wp-trac] [WordPress Trac] #51812: Update jQuery step three In-Reply-To: <050.43509dc37aaf8ffb3e6788e46500216b@wordpress.org> References: <050.43509dc37aaf8ffb3e6788e46500216b@wordpress.org> Message-ID: <065.e2231eacf7be3efd1846e1c0743b4fa7@wordpress.org> #51812: Update jQuery step three -------------------------------------------------+------------------------- Reporter: azaozz | Owner: | SergeyBiryukov Type: task (blessed) | Status: reviewing Priority: normal | Milestone: Future | Release Component: External Libraries | Version: Severity: normal | Resolution: Keywords: early needs-testing needs-dev-note | Focuses: javascript has-patch | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): Replying to [comment:132 a4jp.com]: > Any chance of getting 3.4.0 as it's just a link change on your side and as jQuery Migrate is still in WordPress? Thanks for flagging that! Updating jQuery Migrate to version 3.4.0 is being tracked in #56743. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:47:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:47:22 -0000 Subject: [wp-trac] [WordPress Trac] #56867: Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php In-Reply-To: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> References: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> Message-ID: <073.4124d445d085e11581b3d9ff0038f927@wordpress.org> #56867: Docs: Default parameter not mentioned on trackback_response function on wp- trackback.php ------------------------------+--------------------- Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Pings/Trackbacks | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ------------------------------+--------------------- Changes (by SergeyBiryukov): * component: Editor => Pings/Trackbacks * milestone: Awaiting Review => 6.2 Comment: Hi there, welcome back to WordPress Trac! Thanks for the ticket. It looks like it should be `Default empty string` though, rather than `null`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:50:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:50:31 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.9ad1bb0a88146c28b9b8cf8518bbc3bd@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by mukesh27): I checked the regression for a while. After checking, I discovered that the `_load_textdomain_just_in_time` method, which repeatedly calls `load_textdomain`, is the problem. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:58:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:58:55 -0000 Subject: [wp-trac] [WordPress Trac] #56865: $args taking effect too late in register_block_type_from_metadata In-Reply-To: <052.69a14ba6d6ca56e8f20d1f0b8a054148@wordpress.org> References: <052.69a14ba6d6ca56e8f20d1f0b8a054148@wordpress.org> Message-ID: <067.ac608080e63d32c7db342bb962c9a279@wordpress.org> #56865: $args taking effect too late in register_block_type_from_metadata --------------------------+--------------------- Reporter: aristath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:59:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:59:36 -0000 Subject: [wp-trac] [WordPress Trac] #56868: Add test coverage for _truncate_post_slug Message-ID: <050.475dc509f2e4d54267e798ba7f46d8eb@wordpress.org> #56868: Add test coverage for _truncate_post_slug -------------------------------+----------------------------- Reporter: xknown | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: Severity: normal | Keywords: Focuses: | -------------------------------+----------------------------- [52457] should have some unit tests for `_truncate_post_slug()` to confirm that post slugs are properly truncated when they contain URL encoded characters. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 09:59:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 09:59:46 -0000 Subject: [wp-trac] [WordPress Trac] #56867: Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php In-Reply-To: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> References: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> Message-ID: <073.19fec8a8c347a7832b4cbb1a4bb43f5b@wordpress.org> #56867: Docs: Default parameter not mentioned on trackback_response function on wp- trackback.php ------------------------------+--------------------- Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Pings/Trackbacks | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ------------------------------+--------------------- Comment (by rakibwordpress): Yes. Empty string is more correct. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 10:17:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 10:17:38 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.a1af76525d60aefffce685754d2ee198@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: | davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note dev-feedback | -------------------------------------------------+------------------------- Comment (by maksimkuzmin): Thank you @chaion07! I and some other interested parties are looking forward to seeing this improvement in production at last. As the old saying teaches, measure seven times, cut once. I hope that all the objections and propositions will be tackled comprehensively and successfully. My gratitude to all who devoted their time to this ticket! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 10:22:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 10:22:14 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.3e5c99f6ed84c3470a2f28ea0a0c2698@wordpress.org> #56863: Issue on media page -----------------------------+-------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Comment (by costdev): > @kebbet wp_getimagesize uses native PHP getimagesize and that does not support SVG's. Thats why 1px I guess. Nice catch! Getting the right size for SVGs may involve parsing XML and for proportional SVGs, this could get messy quite quickly. Fixing the display via CSS is only part of the issue, as the image `width` and `height` attributes would need to be fixed too. After reading about it previously working in WordPress < 4.0, I checked WordPress 3.9, and got the same result: `width="1" height="1"`. Since they didn't work in 3.9, and SVG uploads aren't natively supported by Core, I don't think we should be add code to ''partially'' facilitate them. Extenders have already found a way to make this work. It's not a fix in Core, but rather part of what's required to provide SVG support. IMO, ''if'' we were going to support SVG uploads in Core at all, I'd prefer to go all-in and support them entirely. > @kebbet Duplicate of #24251 ? For the above reasons, I agree that it's appropriate to consider this at least a partial duplicate of the above ticket and to continue discussion there. @sumitsingh Do you agree? P.S. After searching "svg" on the `Plugins > Add New` screen, I installed the first plugin result and it had the CSS fix already in the plugin. 😉 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 10:39:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 10:39:56 -0000 Subject: [wp-trac] [WordPress Trac] #56762: PHP file being ignored in block theme hierarchy In-Reply-To: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> References: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> Message-ID: <072.1f59e980fd01d6b53269e3a207a0e054@wordpress.org> #56762: PHP file being ignored in block theme hierarchy ---------------------------+------------------------------ Reporter: ryanpluckrose | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.0.2 Severity: major | Resolution: Keywords: needs-patch | Focuses: template ---------------------------+------------------------------ Comment (by poena): It is correct that the PHP (page-)template needs to be in the root directory, @ryanpluckrose did you try moving it out of the templates folder? I don't believe that block template parts as PHP files are supported by Gutenberg or core, I have not heard of it before, and I would like to learn what the use case is? I suggest opening a new issue for this specifically, but in the Gutenberg GitHub repository. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:04:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:04:24 -0000 Subject: [wp-trac] [WordPress Trac] #56869: Add "Style variations" theme tag Message-ID: <049.adea3b96a0fe502d69a28790a0345be7@wordpress.org> #56869: Add "Style variations" theme tag -----------------------------+----------------------------- Reporter: poena | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- Add a new theme tag called "Style variations" to help users find themes with style variations, a block theme feature where the theme developer includes an alternative .json configuration file for block settings and styles. - Theme developers can add the tag 'style-variations' to the file header in style.css. - Users can sort themes with style variations using the theme filter on the theme selection screen. Companion ticket to https://meta.trac.wordpress.org/ticket/6545. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:06:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:06:06 -0000 Subject: [wp-trac] [WordPress Trac] #56869: Add "Style variations" theme tag In-Reply-To: <049.adea3b96a0fe502d69a28790a0345be7@wordpress.org> References: <049.adea3b96a0fe502d69a28790a0345be7@wordpress.org> Message-ID: <064.986dea00ae6dd8db6470f9a70e52a4b9@wordpress.org> #56869: Add "Style variations" theme tag -----------------------------+------------------------------ Reporter: poena | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Changes (by poena): * Attachment "56869.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:24:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:24:44 -0000 Subject: [wp-trac] [WordPress Trac] #56762: PHP file being ignored in block theme hierarchy In-Reply-To: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> References: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> Message-ID: <072.0accf373392977973c55df6b499c9efe@wordpress.org> #56762: PHP file being ignored in block theme hierarchy ---------------------------+------------------------------ Reporter: ryanpluckrose | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.0.2 Severity: major | Resolution: Keywords: needs-patch | Focuses: template ---------------------------+------------------------------ Comment (by psykro): @ryanpluckrose hey there. Could I confirm something, does this ticket related to your question about adding a post meta field to a template? https://wordpress.org/support/topic/how-to-add-post_meta-to-a-block-theme- html-file/#post-16075706 As @poena has pointed out, PHP files will not work inside the templates or parts directories of a block theme. If you need PHP functionality, you might have to add that to a pattern, which is included in the template or template part. This theme developer handbook explains how to create and use patterns https://developer.wordpress.org/themes/advanced-topics/block-patterns/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:29:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:29:45 -0000 Subject: [wp-trac] [WordPress Trac] #56869: Add "Style variations" theme tag In-Reply-To: <049.adea3b96a0fe502d69a28790a0345be7@wordpress.org> References: <049.adea3b96a0fe502d69a28790a0345be7@wordpress.org> Message-ID: <064.9a9ed9f6f0a136d6ef29f560e5ae4f56@wordpress.org> #56869: Add "Style variations" theme tag -----------------------------+--------------------- Reporter: poena | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.2 Component: Themes | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:32:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:32:02 -0000 Subject: [wp-trac] [WordPress Trac] #56869: Add "Style variations" theme tag In-Reply-To: <049.adea3b96a0fe502d69a28790a0345be7@wordpress.org> References: <049.adea3b96a0fe502d69a28790a0345be7@wordpress.org> Message-ID: <064.3f84177bb22eaf10d2a0d36318793e39@wordpress.org> #56869: Add "Style variations" theme tag -------------------------------------+--------------------- Reporter: poena | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.2 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+--------------------- Changes (by mukesh27): * keywords: => has-patch needs-refresh Comment: @poena Small change can you align the arrow in the patch? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:36:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:36:32 -0000 Subject: [wp-trac] [WordPress Trac] #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php In-Reply-To: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> References: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> Message-ID: <070.b0a18d750516c0c00573f86b24105ad9@wordpress.org> #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php -----------------------------+------------------------------- Reporter: rezakhan995 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Upgrade/Install | Version: 4.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards -----------------------------+------------------------------- Changes (by mukesh27): * component: General => Upgrade/Install * milestone: Awaiting Review => 6.2 Comment: Hi there! Thanks for the ticket and PR. PR looks good to me and approved. Moving to `6.2` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:42:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:42:22 -0000 Subject: [wp-trac] [WordPress Trac] #56762: PHP file being ignored in block theme hierarchy In-Reply-To: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> References: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> Message-ID: <072.32cd2112b7278a81cefe851ad489e02c@wordpress.org> #56762: PHP file being ignored in block theme hierarchy ---------------------------+------------------------------ Reporter: ryanpluckrose | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.0.2 Severity: major | Resolution: Keywords: needs-patch | Focuses: template ---------------------------+------------------------------ Comment (by ryanpluckrose): Yeah I'm currently working with page.php in the root to solve the issue, I didn't realise at the time it was by design. I had assumed that template-parts would fallback in the same way templates do as above but if that's by design then I guess it's not a bug. https://fullsiteediting.com/ has been very helpful for getting me this far though, so thank you! Because page.php is used I now get a white page using Appearance > Site Editor, I know that it's not supposed to work with PHP files but is that the intended result? How should the user edit the nav menu in this context, do I need to enable appearance > menus? I thought this method was now legacy. For reference, this is my use case: - On pages, users will have the option to select a STYLE dropdown, this will update the frontend based on the styles json files e.g. styles/swiss.json or styles/blue.json - If one of these is selected, as well as the styles, the menu will change so i needed an IF statement around the nav, this is where I hit trouble with PHP template parts as Will mentions above. I've currently changed my implementation so that header.html will not be used but instead I'll call a smaller nav.html and put the rest of the header inside a php file called from page.php {{{#!php > >
}}} snippet of my header.php (further down I'll call my nav.html part) {{{#!php
' ) ?>
}}} Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:45:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:45:55 -0000 Subject: [wp-trac] [WordPress Trac] #56762: PHP file being ignored in block theme hierarchy In-Reply-To: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> References: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> Message-ID: <072.80ce561103d3d51fd4e343e42e07ac49@wordpress.org> #56762: PHP file being ignored in block theme hierarchy ---------------------------+------------------------------ Reporter: ryanpluckrose | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.0.2 Severity: major | Resolution: Keywords: needs-patch | Focuses: template ---------------------------+------------------------------ Comment (by ryanpluckrose): Ah yes it is! Mixed with that post and the explainer above hopefully you can see what I'm trying to achieve. I'll have a read of that handbook link, thanks! Replying to [comment:8 psykro]: > @ryanpluckrose hey there. Could I confirm something, does this ticket related to your question about adding a post meta field to a template? > > https://wordpress.org/support/topic/how-to-add-post_meta-to-a-block- theme-html-file/#post-16075706 > > As @poena has pointed out, PHP files will not work inside the templates or parts directories of a block theme. If you need PHP functionality, you might have to add that to a pattern, which is included in the template or template part. > > This theme developer handbook explains how to create and use patterns > > https://developer.wordpress.org/themes/advanced-topics/block-patterns/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:49:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:49:30 -0000 Subject: [wp-trac] [WordPress Trac] #56868: Add test coverage for _truncate_post_slug In-Reply-To: <050.475dc509f2e4d54267e798ba7f46d8eb@wordpress.org> References: <050.475dc509f2e4d54267e798ba7f46d8eb@wordpress.org> Message-ID: <065.86b8c846b09e909013886719bac8c6d3@wordpress.org> #56868: Add test coverage for _truncate_post_slug --------------------------------------+--------------------- Reporter: xknown | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:57:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:57:02 -0000 Subject: [wp-trac] [WordPress Trac] #56867: Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php In-Reply-To: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> References: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> Message-ID: <073.589ab4353b6544b9d7d9952168965c67@wordpress.org> #56867: Docs: Default parameter not mentioned on trackback_response function on wp- trackback.php -----------------------------------------+--------------------- Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Pings/Trackbacks | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: docs -----------------------------------------+--------------------- Changes (by audrasjb): * keywords: has-patch => has-patch changes-requested Comment: Hello, thanks for the patch. I requested some changes :) Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 11:58:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 11:58:18 -0000 Subject: [wp-trac] [WordPress Trac] #56869: Add "Style variations" theme tag In-Reply-To: <049.adea3b96a0fe502d69a28790a0345be7@wordpress.org> References: <049.adea3b96a0fe502d69a28790a0345be7@wordpress.org> Message-ID: <064.f7821c7cd246d344a06798c09a5fbb12@wordpress.org> #56869: Add "Style variations" theme tag -------------------------------------+--------------------- Reporter: poena | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.2 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+--------------------- Changes (by poena): * Attachment "56869-2.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 12:13:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 12:13:17 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.b815f1f28d47f38b04f88f6047ecb1a5@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by flixos90): Replying to [comment:67 ocean90]: > Replying to [comment:66 flixos90]: > > * When using the en_US locale, `load_textdomain()` is (unnecessarily) called a ton of times (107 times in WP 6.1-RC2 vs 3 times in WP 6.0.3). > > Assuming you have no other plugins active, could you explain what calls these are? And why there are unnecessary? I used a vanilla WordPress site with no plugins and Twenty Twenty-One, with just the initial Hello World post. Only the default and twentytwentyone text domains are used in this context, but the commit here results in load_textdomain() to be called 107 times in one page load, even though all the site is en_US (no locale switching happening at all). So this is clearly a bug that needs to be addressed. > > * The regression is only present on en_US sites. For sites that use a locale that typically has translation files present, performance remains basically as before. > > That's actually a good point since the changes here will significantly improve the translation handling [https://wordpress.org/about/stats/#locales for the majority of our user base]. ''If'' there's some tradeoff this should also be taken into consideration. It makes sense that this is a trade off. I would like to see some data though under which conditions the commit improves translation handling and how (much). > I think for the moment we should identify what the problem actually is and if it's not something that can be fixed before the release and/or in a follow-up release. As mentioned, I'm open to fixing this prior to release if feasible. But the data I shared proves the regression coming from the commit. Without having opposing data that would quantify any performance ''benefit'' for non-en_US sites, this either needs to be fixed or reverted prior to release. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 13:13:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 13:13:09 -0000 Subject: [wp-trac] [WordPress Trac] #56870: Introduce a general `pre_site_option` filter in `get_network_option()` Message-ID: <056.fcf4d1230749c607034a33cca88907de@wordpress.org> #56870: Introduce a general `pre_site_option` filter in `get_network_option()` --------------------------------+----------------------------- Reporter: Drivingralle | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Networks and Sites | Version: trunk Severity: normal | Keywords: Focuses: multisite | --------------------------------+----------------------------- Similar to the new filter from #37930 I suggest to also add a general `pre_site_option` filter. I attach a patch to add the filter. Don't know how to create the test for it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 13:13:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 13:13:16 -0000 Subject: [wp-trac] [WordPress Trac] #56867: Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php In-Reply-To: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> References: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> Message-ID: <073.2e8d2fad5f2c97429a30c47feb01c35c@wordpress.org> #56867: Docs: Default parameter not mentioned on trackback_response function on wp- trackback.php -----------------------------------------+--------------------- Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Pings/Trackbacks | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: docs -----------------------------------------+--------------------- Comment (by rakibwordpress): Hi, I have updated as per request. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 13:13:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 13:13:20 -0000 Subject: [wp-trac] [WordPress Trac] #56870: Introduce a general `pre_site_option` filter in `get_network_option()` In-Reply-To: <056.fcf4d1230749c607034a33cca88907de@wordpress.org> References: <056.fcf4d1230749c607034a33cca88907de@wordpress.org> Message-ID: <071.fdc241760ed7d29969d8e30981f3c743@wordpress.org> #56870: Introduce a general `pre_site_option` filter in `get_network_option()` --------------------------------+------------------------------ Reporter: Drivingralle | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Networks and Sites | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: multisite --------------------------------+------------------------------ Changes (by Drivingralle): * Attachment "Introduce_a_general_`pre_site_option`_filter_in_`get_network_option()`.patch" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 13:15:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 13:15:05 -0000 Subject: [wp-trac] [WordPress Trac] #37930: Introduce a general `pre_option` filter in `get_option()` In-Reply-To: <052.b3d2c2a40044ec197f7de25b9a1cf202@wordpress.org> References: <052.b3d2c2a40044ec197f7de25b9a1cf202@wordpress.org> Message-ID: <067.c2fc02c722faf2a689789857c618077b@wordpress.org> #37930: Introduce a general `pre_option` filter in `get_option()` -------------------------------------------------+------------------------- Reporter: flixos90 | Owner: | davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Options, Meta APIs | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: needs-dev-note | -------------------------------------------------+------------------------- Comment (by Drivingralle): Next step #56870? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 13:22:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 13:22:34 -0000 Subject: [wp-trac] [WordPress Trac] #56871: Twenty Twenty Pullquote block font size is not working properly. Message-ID: <060.09b707a8606259435bcc4ebfc33fd51b@wordpress.org> #56871: Twenty Twenty Pullquote block font size is not working properly. ------------------------------+----------------------------- Reporter: nidhidhandhukiya | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Keywords: Focuses: css | ------------------------------+----------------------------- Steps to reproduce:- 1. Choose Twenty Twenty theme. 2. Use Pullquote block. 3. Change font size. You can able to see that font size is not reflected by both front end and in the admin side also. I have attached video recording for better understanding. URL :- [https://share.cleanshot.com/xbaoob709icpK13Q4rKb] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 13:37:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 13:37:48 -0000 Subject: [wp-trac] [WordPress Trac] #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php In-Reply-To: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> References: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> Message-ID: <070.3ce800f7be6fce17629dcae990765f74@wordpress.org> #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php -----------------------------+------------------------------- Reporter: rezakhan995 | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Upgrade/Install | Version: 4.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards -----------------------------+------------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => accepted Comment: Hi there, welcome to WordPress Trac! Thanks for the ticket. [47808] aimed to address changes like this, but it looks like this instance was missed in that commit. The PR looks good. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 13:45:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 13:45:13 -0000 Subject: [wp-trac] [WordPress Trac] #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php In-Reply-To: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> References: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> Message-ID: <070.3f7db25b19d21a901badf1a5289bc7ee@wordpress.org> #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php -----------------------------+------------------------------- Reporter: rezakhan995 | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Upgrade/Install | Version: 4.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards -----------------------------+------------------------------- Comment (by kebbet): I was wrong with the introducing changest, I can not find the correct changeset with the GitHub-repo, can trace it back to [24976], but that's not the real source. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 13:53:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 13:53:14 -0000 Subject: [wp-trac] [WordPress Trac] #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php In-Reply-To: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> References: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> Message-ID: <070.2ac10d1a7d6bd0339d5f63ebde187fe9@wordpress.org> #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php -----------------------------+------------------------------- Reporter: rezakhan995 | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Upgrade/Install | Version: 2.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards -----------------------------+------------------------------- Changes (by kebbet): * version: 4.5 => 2.5 Comment: So, the source might be, [8595]. That means version `2.5`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 14:00:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 14:00:40 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.705f8745c310814a66a391d4c9e01936@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by SergeyBiryukov): Replying to [comment:8 kebbet]: > I can not reproduce this issue in trunk, following instructions in ticket description. It looks like the associated change for the Featured Image block has not been merged to trunk yet. I see six blocks updated for the 6.0 branch in [54543], but only five in the [https://github.com/WordPress/gutenberg/pull/45045/files PR for the Gutenberg plugin], which then was merged for 6.1 RC2 as part of other package updates in [54632]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 14:23:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 14:23:56 -0000 Subject: [wp-trac] [WordPress Trac] #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php In-Reply-To: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> References: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> Message-ID: <070.72427c8b7c19c796e7652b173997428a@wordpress.org> #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php -----------------------------+------------------------------- Reporter: rezakhan995 | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Upgrade/Install | Version: 2.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards -----------------------------+------------------------------- Comment (by SergeyBiryukov): Replying to [comment:6 kebbet]: > So, the source might be, [8595]. That means version `2.5`. That looks correct :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 14:28:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 14:28:40 -0000 Subject: [wp-trac] [WordPress Trac] #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php In-Reply-To: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> References: <055.e6e2bb97dfff176a3d954f57e7d84cb6@wordpress.org> Message-ID: <070.d187a075bcb211ac4e783320d407cb8b@wordpress.org> #56866: Coding Standards: Use strict comparison in wp-admin/update-core.php -----------------------------+------------------------------- Reporter: rezakhan995 | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: Upgrade/Install | Version: 2.5 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: coding-standards -----------------------------+------------------------------- Changes (by SergeyBiryukov): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"54654" 54654]: {{{ #!CommitTicketReference repository="" revision="54654" Coding Standards: Use strict comparison in `wp-admin/update-core.php`. This updates a conditional in `do_core_upgrade()` to use strict comparison for error codes that are static strings. Follow-up to [8595], [36349]. Props rezakhan995, kebbet, mukesh27, jrf, SergeyBiryukov. Fixes #56866. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 14:43:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 14:43:34 -0000 Subject: [wp-trac] [WordPress Trac] #56762: PHP file being ignored in block theme hierarchy In-Reply-To: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> References: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> Message-ID: <072.cde3eda938e198cdea5024c942e8aa6c@wordpress.org> #56762: PHP file being ignored in block theme hierarchy ---------------------------+------------------------------ Reporter: ryanpluckrose | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.0.2 Severity: major | Resolution: Keywords: needs-patch | Focuses: template ---------------------------+------------------------------ Comment (by ryanpluckrose): It seems block-patterns are the answer to all of my questions! I will change my code to use them instead. Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 14:43:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 14:43:35 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.89e94576c3f60313a4ff8ed4c29e7676@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by Bernhard Reiter): Replying to [comment:9 SergeyBiryukov]: > It looks like the associated change for the Featured Image block has not been merged to trunk yet. > > I see six blocks updated for the 6.0 branch in [54543], but only five in the [https://github.com/WordPress/gutenberg/pull/45045/files PR for the Gutenberg plugin], which then was merged for 6.1 RC2 as part of other package updates in [54632]. FWIW, I've now filed a [https://github.com/WordPress/gutenberg/pull/45163 PR] against Gutenberg to carry over that change. (We need it to escape that output; we'll then need to solve this issue here separately -- likely via the patches that folks have already provided.) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 15:05:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 15:05:54 -0000 Subject: [wp-trac] [WordPress Trac] #56762: PHP file being ignored in block theme hierarchy In-Reply-To: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> References: <057.7d935fc4a66f88287dced95aa33a7242@wordpress.org> Message-ID: <072.243a7312b7af1cec5f82e572878bd736@wordpress.org> #56762: PHP file being ignored in block theme hierarchy ---------------------------+------------------------------ Reporter: ryanpluckrose | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.0.2 Severity: major | Resolution: Keywords: needs-patch | Focuses: template ---------------------------+------------------------------ Comment (by ryanpluckrose): One further question on block patterns, how can I get the post? I want to be able to use get_post_meta() -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 15:51:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 15:51:29 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.36aa81763d8e2bf7930e1e1fbe562e80@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------------------+------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: ui, accessibility, commit dev-reviewed | css, administration -------------------------------------+------------------------------------- Changes (by audrasjb): * keywords: has-patch needs-testing commit dev-feedback => has-patch needs-testing commit dev-reviewed Comment: Thanks @sabernhardt for the detailed testing procedure :) Patch tested, works for me 👍 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 15:57:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 15:57:04 -0000 Subject: [wp-trac] [WordPress Trac] #56864: I want to put comments in theme.json. In-Reply-To: <052.94346eff98504ccade1d5f3a28f269c3@wordpress.org> References: <052.94346eff98504ccade1d5f3a28f269c3@wordpress.org> Message-ID: <067.a32d68e40cbfe6334d4c6afdef234147@wordpress.org> #56864: I want to put comments in theme.json. -----------------------------+------------------------------ Reporter: nendeb55 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: close | Focuses: -----------------------------+------------------------------ Changes (by jorbin): * keywords: => close Comment: JSON doesn't support comments. It's unfortunate, but if something like this were to be put in place, theme.json would not be interoperable JSON. When someone sees the `.json` extension they assume it is JSON that can be parsed and worked with as JSON. That isn't something I think we should break. As such, i think this should be closed as `wontfix`. If an individual or team is facing challenges here, I think it might be better for them to use something like [https://github.com/komkom/jsonc jsonc] and to have a build process convert it to json. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 16:19:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 16:19:23 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.48303e50234d224fb57311e000a53673@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by swissspidy): We have now already established that there's a bug here causing too many calls to `load_textdomain()`. Simple as that. No need for detailed performance analysis for other sites or anything. We have also already established that ideally we fix this or revert this if we can't fix it in the required time frame. Good news is that I have a [https://github.com/WordPress/wordpress- develop/pull/3506 draft PR] fixing this PR. It's like 99% complete. Feel free to to check it out. I will continue looking into it myself when my next workday commences. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 16:33:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 16:33:01 -0000 Subject: [wp-trac] [WordPress Trac] #56862: Docs: Default parameter value is missing for themes_api function In-Reply-To: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> References: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> Message-ID: <070.7d07609b2c6e942738d8951a48d1f5e0@wordpress.org> #56862: Docs: Default parameter value is missing for themes_api function ------------------------------+----------------------- Reporter: rezakhan995 | Owner: audrasjb Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: General | Version: 2.8 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: docs ------------------------------+----------------------- Changes (by audrasjb): * owner: (none) => audrasjb * status: new => accepted Comment: Self assigning for commit. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 16:36:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 16:36:33 -0000 Subject: [wp-trac] [WordPress Trac] #56792: Docblock improvements for 6.2 In-Reply-To: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> References: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> Message-ID: <066.71b91b2a156bb95a29877ed60cd87642@wordpress.org> #56792: Docblock improvements for 6.2 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs --------------------------------------+--------------------- Comment (by audrasjb): In [changeset:"54655" 54655]: {{{ #!CommitTicketReference repository="" revision="54655" Docs: Add missing default parameter value in `themes_api()` docblock. Props rezakhan995, costdev. Fixes #56862. See #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 16:36:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 16:36:34 -0000 Subject: [wp-trac] [WordPress Trac] #56862: Docs: Default parameter value is missing for themes_api function In-Reply-To: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> References: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> Message-ID: <070.0b49c5dd2265d902bea0b377a2ee9fce@wordpress.org> #56862: Docs: Default parameter value is missing for themes_api function ------------------------------+----------------------- Reporter: rezakhan995 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: General | Version: 2.8 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: docs ------------------------------+----------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"54655" 54655]: {{{ #!CommitTicketReference repository="" revision="54655" Docs: Add missing default parameter value in `themes_api()` docblock. Props rezakhan995, costdev. Fixes #56862. See #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 16:40:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 16:40:22 -0000 Subject: [wp-trac] [WordPress Trac] #56792: Docblock improvements for 6.2 In-Reply-To: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> References: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> Message-ID: <066.57db1a268a6f5fb5baacf167c04d99d4@wordpress.org> #56792: Docblock improvements for 6.2 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs --------------------------------------+--------------------- Comment (by audrasjb): In [changeset:"54656" 54656]: {{{ #!CommitTicketReference repository="" revision="54656" Docs: Add missing default parameter value in `trackback_response()` docblock. Props rakibwordpress, audrasjb, SergeyBiryukov. Fixes #56867. See #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 16:40:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 16:40:22 -0000 Subject: [wp-trac] [WordPress Trac] #56867: Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php In-Reply-To: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> References: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> Message-ID: <073.b8254bb8024590a639b1777800c9b0d1@wordpress.org> #56867: Docs: Default parameter not mentioned on trackback_response function on wp- trackback.php -----------------------------------------+----------------------- Reporter: rakibwordpress | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: Pings/Trackbacks | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch changes-requested | Focuses: docs -----------------------------------------+----------------------- Changes (by audrasjb): * owner: (none) => audrasjb * status: new => closed * resolution: => fixed Comment: In [changeset:"54656" 54656]: {{{ #!CommitTicketReference repository="" revision="54656" Docs: Add missing default parameter value in `trackback_response()` docblock. Props rakibwordpress, audrasjb, SergeyBiryukov. Fixes #56867. See #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 16:53:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 16:53:41 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency In-Reply-To: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> References: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> Message-ID: <072.9e0fceca26d072cb082c907220114ca2@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ---------------------------+------------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: minor | Resolution: Keywords: | Focuses: coding-standards ---------------------------+------------------------------- Comment (by antonvlasenko): From my point of view, it's not very important whether to use `wp` or `Wp`. But it is crucial that this be consistent across the project and reflected in the documentation. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 17:14:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 17:14:37 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.1155a39264be4a2851b745d8791ff82e@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by Bernhard Reiter): Replying to [comment:4 pbiron]: > As the the addition of the call to `safecss_filter_attr()` was added for security reasons, the WP security team should double check the patch to make sure it doesn't open any vulnerabilities. @xknown Would you mind giving this a look? :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 17:16:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 17:16:32 -0000 Subject: [wp-trac] [WordPress Trac] #56858: Blogger Importer: Undefined (dynamic) properties In-Reply-To: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> References: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> Message-ID: <073.c5391676bacd9ac5f3230fcfb210763a@wordpress.org> #56858: Blogger Importer: Undefined (dynamic) properties -------------------------------+---------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: WordPress.org Component: Import | Version: Severity: normal | Resolution: Keywords: needs-patch php82 | Focuses: -------------------------------+---------------------------- Comment (by ironprogrammer): Replying to [comment:1 jrf]: > Sounds like something which should be reported in https://github.com/WordPress/blogger-importer instead ? Per https://core.trac.wordpress.org/ticket/49143#comment:4, importers are still under the Core Trac umbrella, which seems confirmed with their WordPress GitHub org consolidation via https://meta.trac.wordpress.org/ticket/5550. But yes, addressing importer issues does feel like an upstream matter. However, given the near invisibility of those repos, and lack of attention they're likely to get on their own, it seems appropriate to continue to report and track these issues here (and [https://core.trac.wordpress.org/search?q=importer&noquickjump=1&ticket=on the community appears to feel the same]). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 17:45:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 17:45:22 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.8718a0848754e962fa1cbabb9d092b92@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by flixos90): Replying to [comment:71 swissspidy]: > We have now already established that there's a bug here causing too many calls to `load_textdomain()`. Simple as that. No need for detailed performance analysis for other sites or anything. I still think it would be interesting to see how the original commit here affects performance for the scenarios where it already works as expected, so I did a quick test similar to the previous ones where I compared 6.1-RC2 with 6.1-RC2 with the relevant code replaced with the 6.0.3 code, just with translation files present. The difference is small, but consistently visible: With de_DE for example, with the commit here WordPress took a median of 0.1915s to load, while without it it was 0.1956s, so roughly 4ms difference. While there is always fluctuation, this seems to indeed be consistent, so it's good to see a positive impact of the overall concept. > Good news is that I have a [https://github.com/WordPress/wordpress- develop/pull/3506 draft PR] fixing this PR. It's like 99% complete. > > Feel free to to check it out. I will continue looking into it myself when my next workday commences. I took a look at the PR. I am not too familiar with that code, but it seems to me that there is a much simpler solution to the problem than what the PR does: The real problem is in https://core.trac.wordpress.org/browser/trunk/src/wp- includes/l10n.php?rev=54654#L762, which I found out due to further testing: Different than my original assessment where I focused on the en_US locale, the problem goes actually beyond that: It occurs whenever translation files are not present locally, which is certainly possible for even locales that are not en_US (e.g. when a plugin or theme is not translated yet, or simply when the site has not downloaded the language packs yet). Simply adding a `$wp_textdomain_registry->set( $domain, $locale, false );` above the above line fixes the problem for me, by storing that there is no translation file in that situation, the same way it is already done when the translation file cannot be imported. Potentially this may introduce another problem that I'm unfamiliar with, but at least the above change is where I would have started. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 17:50:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 17:50:01 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.d0e0cf8185e92863ee88290e4afd0af0@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | spacedmonkey Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing commit dev-reviewed | performance -------------------------------------------------+------------------------- Changes (by jorbin): * status: closed => reopened * resolution: fixed => Comment: Reopening in order to encourage discussion of the filter added. See this long thread https://wordpress.slack.com/archives/C02KGN5K076/p1666106492041839 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 17:51:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 17:51:32 -0000 Subject: [wp-trac] [WordPress Trac] #56872: i have problems with featured image Message-ID: <055.161c0dd652dda33f8a2b4264b7afeb4f@wordpress.org> #56872: i have problems with featured image -----------------------------+----------------------------- Reporter: rafiqkhan17 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: trivial | Keywords: Focuses: | -----------------------------+----------------------------- I am using generate press theme and it don't show featured images.Few days later i added featured images and some of my posts have featured images but the option is not there in post section i have changed theme but does not work .Please help me to solve this problem Thanks -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 17:59:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 17:59:59 -0000 Subject: [wp-trac] [WordPress Trac] #56858: Blogger Importer: Undefined (dynamic) properties In-Reply-To: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> References: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> Message-ID: <073.3cab81251087a97724245a10941592d0@wordpress.org> #56858: Blogger Importer: Undefined (dynamic) properties -------------------------------+---------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: WordPress.org Component: Import | Version: Severity: normal | Resolution: Keywords: needs-patch php82 | Focuses: -------------------------------+---------------------------- Comment (by jrf): > Per https://core.trac.wordpress.org/ticket/49143#comment:4, importers are still under the Core Trac umbrella, which seems confirmed with their WordPress GitHub org consolidation via https://meta.trac.wordpress.org/ticket/5550. > > But yes, addressing importer issues does feel like an upstream matter. @ironprogrammer I see... It just feels like more noise while the issue cannot be solved in Core, but should be solved in the plugin repo. > However, given the near invisibility of those repos, and lack of attention they're likely to get on their own, it seems appropriate to continue to report and track these issues here (and the community appears to feel the same). Which actually highlights a much more pertinent problem, for which it may be a good idea to have a discussion on Make: **there are quite a few repos in the WP GitHub organisation which do not seem to have a dedicated maintainer(s) attached to it.** All Core committers do have commit rights to those repos AFAIK and occasionally some of them (us) use those rights to merge things, but it seems like, for the most part, these repos are unmaintained and even when something does get merged, there is often no CI/QA in place, there is no documented release process and nobody takes responsibility.... Considering the code of some of these packages ships with Core and/or is actively promoted by Core, like the Importer plugins, it is my opinion that this needs to change. In a lot of cases, the maintenance burden will be small, once the initial backlog (no CI, no CS, no tests) has been addressed and will mostly consist of keeping up with PHP changes, keeping the CI running and passing etc, but having someone take "ownership" for each of those projects would help and clarify communication lines as well. /cc @dd32 @ocean90 (as I seem to remember I've seen both of you active in some those repos on occasion) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 18:18:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 18:18:32 -0000 Subject: [wp-trac] [WordPress Trac] #38204: enhancement: custom pathname to wp-config.php In-Reply-To: <051.1ca3b26e115da9d3aeb460265bb50778@wordpress.org> References: <051.1ca3b26e115da9d3aeb460265bb50778@wordpress.org> Message-ID: <066.e72a17affaf0b4af6dee556df4450ea0@wordpress.org> #38204: enhancement: custom pathname to wp-config.php -------------------------------------------------+------------------------- Reporter: gdamjan | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Bootstrap/Load | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch needs-refresh 2nd-opinion | Focuses: -------------------------------------------------+------------------------- Comment (by iandunn): One drawback here might be that PHP's [https://www.php.net/manual/en/ini.core.php#ini.open-basedir open_basedir] would need to be configured to allow access outside the webroot, which should be done carefully (especially if the config is placed in `/etc`). IIRC, some plugins and WP-CLI would need to be updated as well. This doesn't address your desire for a standard mechanism, but another alternate approach would be keeping the non-sensitive values hardcoded (`WP_LANG`, `WP_DEBUG`, etc) in `wp-config`, and then using [https://roots.io/twelve-factor-03-config/ env vars for the sensitive values]. e.g., `define( 'DB_PASSWORD', getenv( 'WP_DB_PASSWORD' ) );` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 18:18:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 18:18:33 -0000 Subject: [wp-trac] [WordPress Trac] #56792: Docblock improvements for 6.2 In-Reply-To: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> References: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> Message-ID: <066.c6f35ab04dca4cf8f9f3a020d5b2cc51@wordpress.org> #56792: Docblock improvements for 6.2 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs --------------------------------------+--------------------- Comment (by jorbin): In [changeset:"54657" 54657]: {{{ #!CommitTicketReference repository="" revision="54657" Revert accidental 5.9 branch commits [54655] and [54656] Unprops audrasjb. See #56867, #56792, #56862, #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 18:18:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 18:18:34 -0000 Subject: [wp-trac] [WordPress Trac] #56867: Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php In-Reply-To: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> References: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> Message-ID: <073.e54f05f4cd47b27cd2a59bc5829431aa@wordpress.org> #56867: Docs: Default parameter not mentioned on trackback_response function on wp- trackback.php -----------------------------------------+----------------------- Reporter: rakibwordpress | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: Pings/Trackbacks | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch changes-requested | Focuses: docs -----------------------------------------+----------------------- Comment (by jorbin): In [changeset:"54657" 54657]: {{{ #!CommitTicketReference repository="" revision="54657" Revert accidental 5.9 branch commits [54655] and [54656] Unprops audrasjb. See #56867, #56792, #56862, #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 18:18:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 18:18:34 -0000 Subject: [wp-trac] [WordPress Trac] #56862: Docs: Default parameter value is missing for themes_api function In-Reply-To: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> References: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> Message-ID: <070.88bba0437f3bf923bc8cef1f016293f8@wordpress.org> #56862: Docs: Default parameter value is missing for themes_api function ------------------------------+----------------------- Reporter: rezakhan995 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: General | Version: 2.8 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: docs ------------------------------+----------------------- Comment (by jorbin): In [changeset:"54657" 54657]: {{{ #!CommitTicketReference repository="" revision="54657" Revert accidental 5.9 branch commits [54655] and [54656] Unprops audrasjb. See #56867, #56792, #56862, #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 18:21:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 18:21:16 -0000 Subject: [wp-trac] [WordPress Trac] #56792: Docblock improvements for 6.2 In-Reply-To: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> References: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> Message-ID: <066.f2bab229561d477c5d46adc5a078a17e@wordpress.org> #56792: Docblock improvements for 6.2 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs --------------------------------------+--------------------- Comment (by jorbin): In [changeset:"54658" 54658]: {{{ #!CommitTicketReference repository="" revision="54658" Docs: Add missing default parameter value in trackback_response() docblock. Previously: [54656] [54657] Props rakibwordpress, audrasjb, SergeyBiryukov. Fixes #56867. See #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 18:21:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 18:21:17 -0000 Subject: [wp-trac] [WordPress Trac] #56867: Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php In-Reply-To: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> References: <058.0e2cfdae9c3e408990ddf0f473eeb47e@wordpress.org> Message-ID: <073.43db40e86edf572601f45c4320aaec24@wordpress.org> #56867: Docs: Default parameter not mentioned on trackback_response function on wp- trackback.php -----------------------------------------+----------------------- Reporter: rakibwordpress | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: Pings/Trackbacks | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch changes-requested | Focuses: docs -----------------------------------------+----------------------- Comment (by jorbin): In [changeset:"54658" 54658]: {{{ #!CommitTicketReference repository="" revision="54658" Docs: Add missing default parameter value in trackback_response() docblock. Previously: [54656] [54657] Props rakibwordpress, audrasjb, SergeyBiryukov. Fixes #56867. See #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 18:22:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 18:22:49 -0000 Subject: [wp-trac] [WordPress Trac] #56792: Docblock improvements for 6.2 In-Reply-To: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> References: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> Message-ID: <066.8d5cbd7a67f76135c4a352d10dc73fcf@wordpress.org> #56792: Docblock improvements for 6.2 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs --------------------------------------+--------------------- Comment (by jorbin): In [changeset:"54659" 54659]: {{{ #!CommitTicketReference repository="" revision="54659" Docs: Add missing default parameter value in themes_api() docblock. Previously: [54655] [54657] Props rezakhan995, costdev. Fixes #56862. See #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 18:22:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 18:22:49 -0000 Subject: [wp-trac] [WordPress Trac] #56862: Docs: Default parameter value is missing for themes_api function In-Reply-To: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> References: <055.2d95aa6e8e245ca02cece64cb9378fd6@wordpress.org> Message-ID: <070.8e4a9057d3e6e3822d3e372a340df566@wordpress.org> #56862: Docs: Default parameter value is missing for themes_api function ------------------------------+----------------------- Reporter: rezakhan995 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: General | Version: 2.8 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: docs ------------------------------+----------------------- Comment (by jorbin): In [changeset:"54659" 54659]: {{{ #!CommitTicketReference repository="" revision="54659" Docs: Add missing default parameter value in themes_api() docblock. Previously: [54655] [54657] Props rezakhan995, costdev. Fixes #56862. See #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 18:26:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 18:26:41 -0000 Subject: [wp-trac] [WordPress Trac] #56872: i have problems with featured image In-Reply-To: <055.161c0dd652dda33f8a2b4264b7afeb4f@wordpress.org> References: <055.161c0dd652dda33f8a2b4264b7afeb4f@wordpress.org> Message-ID: <070.f087c197c3feac911822a259f64f0464@wordpress.org> #56872: i have problems with featured image -----------------------------+---------------------- Reporter: rafiqkhan17 | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: trivial | Resolution: invalid Keywords: | Focuses: -----------------------------+---------------------- Changes (by jorbin): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi @rafiqkhan17, Welcome to trac. I'm sorry to hear you're having trouble with your website. Unfortunately, Trac is for the development of WordPress Core, whereas what you have is a support issue with your website. If you head on over to the [https://wordpress.org/support/forum/how-to-and-troubleshooting/ support forums], the volunteers there can hopefully help you to find a solution. I'll close this ticket as invalid, but not because your issue is invalid. It's just the keyword we use when there's no further action we can take here on Trac. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 20:26:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 20:26:21 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.41a795c13f50df9d025e6bc28a6e7027@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by swissspidy): The original solution here was not implemented because of performance, but because it fixes a bug with locale switching. Your oroposed solution does not work as it breaks locale switching. Believe me, I have implemented this and am a component maintainer. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:08:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:08:19 -0000 Subject: [wp-trac] [WordPress Trac] #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding within the cells In-Reply-To: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> References: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> Message-ID: <063.1f501e0ce34bf6cf2464c9703a650462@wordpress.org> #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding within the cells -------------------------------+--------------------- Reporter: vtad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+--------------------- Comment (by audrasjb): This issue was reported upstream on Gutenberg repo, but since it’s not milestoned, I don’t think it’s going to be fixed in time for 6.1. Let’s give it one more day, then punt it to the next minor. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:17:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:17:37 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.0d5a26fab85f3f2ede9c78d7563d4425@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by Bernhard Reiter): Replying to [comment:10 Bernhard Reiter]: > FWIW, I've now filed a [https://github.com/WordPress/gutenberg/pull/45163 PR] against Gutenberg to carry over that change. (We need it to escape that output; we'll then need to solve this issue here separately -- likely via the patches that folks have already provided.) Note that that change will be part of WP 6.1 RC3 next Tuesday. To simulate the impact already, apply the following patch to `trunk`: {{{ diff --git a/src/wp-includes/blocks/post-featured-image.php b/src/wp- includes/blocks/post-featured-image.php index de5683b297..495c8ec534 100644 --- a/src/wp-includes/blocks/post-featured-image.php +++ b/src/wp-includes/blocks/post-featured-image.php @@ -64,7 +64,7 @@ function render_block_core_post_featured_image( $attributes, $content, $block ) if ( ! empty( $attributes['scale'] ) ) { $image_styles .= "object- fit:{$attributes['scale']};"; } - $featured_image = str_replace( 'src=', 'style="' . esc_attr( $image_styles ) . '" src=', $featured_image ); + $featured_image = str_replace( '{$featured_image}"; }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:20:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:20:29 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.fc17ee1aed3057771b473f5e814fdab2@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: | davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note dev-feedback | -------------------------------------------------+------------------------- Comment (by audrasjb): As per today's bugscrub: Adding `high` priority. Let's see if it can be reviewed in time for RC3. If not, this ticket should be punted to 6.1.1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:24:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:24:25 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.72e7841e51c001e9b70e56218e52675f@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: normal | Resolution: Keywords: needs-testing has-testing-info dev- | Focuses: feedback has-patch has-unit-tests | -------------------------------------------------+------------------------- Comment (by audrasjb): As per today's bug scrub: There's some coding standards issues to fix though. Other wise, it looks good to go. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:25:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:25:08 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.72f19c5887559b2504f511ef8bbcf03b@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------+--------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by pbiron): Replying to [comment:12 Bernhard Reiter]: > Note that that change will be part of WP 6.1 RC3 next Tuesday. To simulate the impact already, apply the following patch to `trunk`: After applying that patch, you should see the behavior reported in this ticket. If you then apply [attachment:"56855.1.diff"], you should see the corrected behavior. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:35:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:35:37 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.831359a21f438d45eb16f0156551f500@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | spacedmonkey Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing commit dev-reviewed | performance -------------------------------------------------+------------------------- Changes (by audrasjb): * priority: normal => high Comment: As per today's bugscrub, We have a patch but it still needs review and dev feedback. Adding `high` priority, given we're 3 days before RC3 :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:36:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:36:02 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.9b60f53c3ba5dc946409631c6dc30ffd@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ----------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ----------------------------+---------------------------- Changes (by sabernhardt): * keywords: commit has-patch dev-reviewed => has-patch * status: closed => reopened * focuses: => accessibility * resolution: fixed => Comment: The SVG still needs `aria-hidden`, as it has had in 6.0 (changeset:53383 / ticket:55532#comment:13). I'd also like to consider changing each `path` element to `circle` and removing the `clip-path` so the image can be much smaller. (I could convert the Freedoms image to circles, too, but the Credits and Privacy SVGs are more complicated.) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:39:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:39:22 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.5e0a1c9dec11750f3e76a996c486bc17@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ----------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ----------------------------+---------------------------- Changes (by sabernhardt): * Attachment "56703.diff" added. adding `aria-hidden`, `focusable` and `viewBox` attributes; removing `clip-path`; converting `path` elements to `circle` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:44:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:44:49 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.6e499b57ffb33514d3d3b626da4bc7fe@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------------------+------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: fixed Keywords: has-patch needs-testing | Focuses: ui, accessibility, commit dev-reviewed | css, administration -------------------------------------+------------------------------------- Changes (by joedolson): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54660" 54660]: {{{ #!CommitTicketReference repository="" revision="54660" Editor: Fix modal height responsiveness on link popup editor. Fix the responsive breakpoint styles for short vertical viewports on the link popup modal. Follow up to [54216]. Props sabernhardt. Fixes #53174. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:47:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:47:17 -0000 Subject: [wp-trac] [WordPress Trac] #56873: Core Blocks validation error from wordpress 6.0.3 Message-ID: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> #56873: Core Blocks validation error from wordpress 6.0.3 --------------------------+----------------------------- Reporter: gigito78 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: minor | Keywords: Focuses: javascript | --------------------------+----------------------------- Hello! There seem to be some validation errors of some core block patterns from version 6.0.3 (they seem to be inconsistencies of the style attribute). They can be viewed in the developer console. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:49:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:49:01 -0000 Subject: [wp-trac] [WordPress Trac] #56873: Core Blocks validation error from wordpress 6.0.3 In-Reply-To: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> References: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> Message-ID: <067.6de9f15f7af53c433321237ea54617ce@wordpress.org> #56873: Core Blocks validation error from wordpress 6.0.3 --------------------------+------------------------------ Reporter: gigito78 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------------ Changes (by gigito78): * Attachment "wordpressbug.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:55:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:55:26 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.030c4ff32a9d0cf378f1251a5da3c789@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): Replying to [comment:72 flixos90]: > Simply adding a `$wp_textdomain_registry->set( $domain, $locale, false );` above the above line fixes the problem for me, by storing that there is no translation file in that situation, the same way it is already done when the translation file cannot be imported. > > Potentially this may introduce another problem that I'm unfamiliar with, but at least the above change is where I would have started. I'm not super familiar with this code either, but it looks like this was previously tried in #51678. While that would restore the performance, it seems to break what this ticket aimed to achieve. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 21:55:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 21:55:30 -0000 Subject: [wp-trac] [WordPress Trac] #56873: Core Blocks validation error from wordpress 6.0.3 In-Reply-To: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> References: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> Message-ID: <067.7cb9821880b786a09d426fab2d09fcba@wordpress.org> #56873: Core Blocks validation error from wordpress 6.0.3 --------------------------+------------------------------ Reporter: gigito78 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------------ Comment (by Bernhard Reiter): Hello, and thank you for your bug report! This looks a bit similar to [https://github.com/WordPress/gutenberg/issues/45153 this issue] (missing block deprecations for `elements` class name). I'll ask folks there to have a look at this and confirm. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 22:14:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 22:14:44 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency In-Reply-To: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> References: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> Message-ID: <072.186a54dc97696be6cb94bc49bf373edf@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ---------------------------+------------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: minor | Resolution: Keywords: | Focuses: coding-standards ---------------------------+------------------------------- Comment (by SergeyBiryukov): `wp` appears to be more common currently: * `class [A-Za-z_]*_wp`: 175 matches in 174 files * `class [A-Za-z_]*_Wp`: 34 matches in 34 files -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 22:29:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 22:29:11 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.995318d4bf94a0cb43b2cfb4870fb745@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by spacedmonkey): Forgive me, but I put together a very simple patch, that caches, if the file exists or not. See [https://github.com/WordPress/wordpress- develop/pull/3508 #3508]. This seems to fix much of the problem, as I am seeing page speed improve. If this is not the solution, then I would love to understand why not. Because I don't see a reason not to cache is_readable, it seems it is not a value that is going to change in a page request. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 22:32:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 22:32:17 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.ec5f80f1d54d05d1f76f8ecc08b47c93@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by flixos90): Replying to [comment:73 swissspidy]: > Your oroposed solution does not work as it breaks locale switching. Believe me, I have implemented this and am a component maintainer. Makes sense. Like I said, I'm not very familiar with the code here. Given that your PR looks more complex than what I would anticipate for this late in the release cycle though, I think it would be crucial to get someone else with l10n experience to review it (looking at you @ocean90). Realistically, this probably needs to be committed by Monday or reverted so that we can have it in the final RC (Tuesday). Replying to [comment:77 spacedmonkey]: > Forgive me, but I put together a very simple patch, that caches, if the file exists or not. See #3508. This seems to fix much of the problem, as I am seeing page speed improve. > > If this is not the solution, then I would love to understand why not. Because I don't see a reason not to cache is_readable, it seems it is not a value that is going to change in a page request. This doesn't address the underlying bug, since even with this caching, `load_textdomain()` still is called >100 times within one page load - that is the root problem here. I trust @swissspidy is working into the right direction (although I'm too unfamiliar with the underlying code to make for a good reviewer on this). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 20 23:28:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 20 Oct 2022 23:28:21 -0000 Subject: [wp-trac] [WordPress Trac] #56871: Twenty Twenty: Pullquote block ignores custom font sizes (was: Twenty Twenty Pullquote block font size is not working properly.) In-Reply-To: <060.09b707a8606259435bcc4ebfc33fd51b@wordpress.org> References: <060.09b707a8606259435bcc4ebfc33fd51b@wordpress.org> Message-ID: <075.6374b9d18fc85f1a960ed75b59767539@wordpress.org> #56871: Twenty Twenty: Pullquote block ignores custom font sizes ------------------------------+------------------------------ Reporter: nidhidhandhukiya | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: css ------------------------------+------------------------------ Comment (by sabernhardt): In 6.1, the editor will honor the custom font size selection, but the pullquote continues to use the default size on the front end. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:08:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:08:29 -0000 Subject: [wp-trac] [WordPress Trac] #17851: Wrapping Sections with add_settings_section In-Reply-To: <053.ac36c57cc64378fd983a2bf637f0d159@wordpress.org> References: <053.ac36c57cc64378fd983a2bf637f0d159@wordpress.org> Message-ID: <068.48adc0d96a86a2e0d0014474b4acd239@wordpress.org> #17851: Wrapping Sections with add_settings_section -------------------------------------------------+------------------------- Reporter: griffinjt | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Administration | Version: 3.1.3 Severity: normal | Resolution: fixed Keywords: has-patch good-first-bug has-unit- | Focuses: tests needs-dev-note commit | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): @mukesh27 added to props via make/core per [comment:33 comment #33]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:09:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:09:59 -0000 Subject: [wp-trac] [WordPress Trac] #40426: Remove dns-prefetch of s.w.org domain In-Reply-To: <053.714aefcbbe3faae36e4c134adb30d2bd@wordpress.org> References: <053.714aefcbbe3faae36e4c134adb30d2bd@wordpress.org> Message-ID: <068.788524e51558b2ba1be93949da0e5427@wordpress.org> #40426: Remove dns-prefetch of s.w.org domain -------------------------------------------------+------------------------- Reporter: joelhardi | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Emoji | Version: 4.8 Severity: minor | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: privacy assigned-for-commit | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): @mukesh27 added to props via make/core per [comment:8 comment #8] via prbot. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:14:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:14:22 -0000 Subject: [wp-trac] [WordPress Trac] #42438: Add support for preload links (similar to resource hints) In-Reply-To: <050.0de6892de922598589d51123ece4cc8e@wordpress.org> References: <050.0de6892de922598589d51123ece4cc8e@wordpress.org> Message-ID: <065.2e0cb44e7ae4601a15f3091cdfbf417e@wordpress.org> #42438: Add support for preload links (similar to resource hints) -------------------------------------------------+------------------------- Reporter: nico23 | Owner: swissspidy Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Script Loader | Version: 4.9 Severity: normal | Resolution: fixed Keywords: has-unit-tests has-patch commit | Focuses: needs-dev-note | performance -------------------------------------------------+------------------------- Comment (by peterwilsoncc): @mukesh27 added to props via make/core per [comment:32 comment #32]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:14:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:14:35 -0000 Subject: [wp-trac] [WordPress Trac] #56858: Blogger Importer: Undefined (dynamic) properties In-Reply-To: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> References: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> Message-ID: <073.55c78e1c51b89f8c1ae6c9677320b087@wordpress.org> #56858: Blogger Importer: Undefined (dynamic) properties -------------------------------+---------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: WordPress.org Component: Import | Version: Severity: normal | Resolution: Keywords: needs-patch php82 | Focuses: -------------------------------+---------------------------- Comment (by dd32): Historically we tracked WordPress-Importer issues via Core Trac, mostly as there were no other places for it, and it's been treated as "part of WordPress". Other importers were tracked here, once again, as there was no better place for it. Now that GitHub repo's exist for them, I think it makes sense that we track issues for Importers in their individual repo's, but accepting bug reports for the Importers via core.trac.wordpress.org and migrating them seems reasonable to me (As not all reporters will have a GitHub account, or are aware of that as a location of tracking them). The other importers have been very hit-and-miss when it comes to maintenance, but still only active WordPress / WordPress.org contributors have worked on them. The migration of the plugins onto GitHub is a relatively recent thing, and has mostly been to ease the burden of how to manage maintaining the plugins that were only within `plugins.svn.wordpress.org` and which had limited committers, and limited visibility into how to propose changes to the importers. Core Committers did not have commit access on GitHub to all of the importers (only WordPress-Importer), but I've gone through and granted the team access now. In other words: I agree, this should be reported to and worked on in the GitHub repo, but if a report comes in from a WordPress contributor I would accept the report here and offer to migrate it over if need be. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:16:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:16:31 -0000 Subject: [wp-trac] [WordPress Trac] #51041: Incorrect message about the status of WP_AUTO_UPDATE_CORE In-Reply-To: <055.deae201daa75709d7c530d5483373dd1@wordpress.org> References: <055.deae201daa75709d7c530d5483373dd1@wordpress.org> Message-ID: <070.989fda4792a42ee74ea9500825bc5cd7@wordpress.org> #51041: Incorrect message about the status of WP_AUTO_UPDATE_CORE --------------------------------------+----------------------- Reporter: johnbillion | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Site Health | Version: 5.5 Severity: normal | Resolution: fixed Keywords: has-patch good-first-bug | Focuses: --------------------------------------+----------------------- Comment (by peterwilsoncc): mukesh27 added to props via make/core per comments [comment:2 #2] [comment:4 #4]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:18:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:18:53 -0000 Subject: [wp-trac] [WordPress Trac] #56697: File editor: extra padding on sides (was: Extra Padding on Sides of Editor.) In-Reply-To: <052.617bd8157b2de0d1750b0bc3c425a37a@wordpress.org> References: <052.617bd8157b2de0d1750b0bc3c425a37a@wordpress.org> Message-ID: <067.be9ed6369c582162e1456209766545a9@wordpress.org> #56697: File editor: extra padding on sides -------------------------------------+------------------------------------- Reporter: muneeb09 | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 6.0.2 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, accessibility, needs-patch | css, administration -------------------------------------+------------------------------------- Changes (by sabernhardt): * keywords: extra-padding => reporter-feedback needs-patch * focuses: ui => ui, accessibility, css, administration * component: Editor => Administration Comment: Hi and thanks for the report! Which browser(s) and operating system did not allow you to click the links? I did not have trouble clicking them in Firefox 105 or Chrome 106 (with Windows 10 Home). The `CodeMirror-scroll` element has a 30-pixel bottom padding, and it extends about the same distance to the right (in both LTR and RTL language directions). However, the `.CodeMirror` container hides its overflow, which ''should'' prevent covering part of the links. I would like to investigate switching sides so that the visual order matches the DOM order, though that could transfer any clicking problems faced in left-to-right languages to the right-to-left languages. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:19:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:19:02 -0000 Subject: [wp-trac] [WordPress Trac] #56285: export_preview_data() added wrongly In-Reply-To: <056.f56c99173c91bbf4488daca4eee16d90@wordpress.org> References: <056.f56c99173c91bbf4488daca4eee16d90@wordpress.org> Message-ID: <071.af020dc9570445cda9cc0548d0d757ed@wordpress.org> #56285: export_preview_data() added wrongly ------------------------------+----------------------------- Reporter: Drivingralle | Owner: sergeybiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Customize | Version: 4.5 Severity: trivial | Resolution: fixed Keywords: has-patch commit | Focuses: ------------------------------+----------------------------- Comment (by peterwilsoncc): @mukesh27 @SergeyBiryukov added to props via make/core per review comments above. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:20:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:20:15 -0000 Subject: [wp-trac] [WordPress Trac] #56416: Add a new block pattern category called Footers In-Reply-To: <049.1d58e206062933c361dc7b61963d669a@wordpress.org> References: <049.1d58e206062933c361dc7b61963d669a@wordpress.org> Message-ID: <064.e8ae4103bef2fec94b3187b0bd76577c@wordpress.org> #56416: Add a new block pattern category called Footers -------------------------------------------------+--------------------- Reporter: poena | Owner: mcsf Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit add-to-field-guide | Focuses: -------------------------------------------------+--------------------- Comment (by peterwilsoncc): @mukesh27 added to pros via make/core per review comment above. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:24:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:24:35 -0000 Subject: [wp-trac] [WordPress Trac] #56873: Core Blocks validation error from wordpress 6.0.3 In-Reply-To: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> References: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> Message-ID: <067.a0a13b7cb4b10725df0ef7042770af19@wordpress.org> #56873: Core Blocks validation error from wordpress 6.0.3 --------------------------+------------------------------ Reporter: gigito78 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------------ Comment (by wildworks): I have tried different patterns and so far have not been able to reproduce it. It would be helpful to have the original markup HTML for this error. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:49:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:49:33 -0000 Subject: [wp-trac] [WordPress Trac] #54221: _transient_dirsize_cache is set to autoload=yes and kills db performance if it grows (20MB in our case) In-Reply-To: <053.d27a46c8406cf993ec31d81b89154480@wordpress.org> References: <053.d27a46c8406cf993ec31d81b89154480@wordpress.org> Message-ID: <068.49bb3678de4c6bbd78de1ea442b6c394@wordpress.org> #54221: _transient_dirsize_cache is set to autoload=yes and kills db performance if it grows (20MB in our case) --------------------------+------------------------------------------ Reporter: archon810 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Database | Version: 2.8 Severity: major | Resolution: Keywords: needs-patch | Focuses: administration, performance --------------------------+------------------------------------------ Comment (by annemaciver): Question: (NOT using Multisite; YES using object cache) Is there a downside to disabling the _transient_dirsize_cache autoload? I'm getting a caution in Site Health that I have 1293 autoloaded options (size: 1 MB) in the options table, which could slow my site. The largest (though under 800KB) is _transient_dirsize_cache. I do have Redis/ object cache. What is the potential consequence of disabling that autoload? Any reason not to? Thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:57:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:57:22 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.88eb1088be2c933be8b56de8f2106a88@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info has-unit-tests | -------------------------------------------------+------------------------- Changes (by ironprogrammer): * keywords: has-patch needs-testing => has-patch needs-testing has- testing-info has-unit-tests Comment: == Test Report === Steps to Reproduce 1. SETUP: Apply setup patch from comment:12. This is required to apply the `safecss_filter_attr()` fix from 6.0.3. 2. Create a new post. 3. Insert a Post Featured Image block, add an image to the block (should be taller than 100px). 4. Set the height to 100px and scale to "Cover". 5. Publish post and view the new post. 6. 🐞 Observe that the image in the block is stretched in the frontend (and preview). === Expected Results - ✅ Block's image in frontend is set to 100x100px, instead of "object- fit: cover". (See Figure 1.) ---- Patch tested: attachment:56855.1.diff 👍🏻 === Environment - Hardware: MacBook Pro Apple M1 Pro - OS: macOS 12.6 - Browser: Safari 16.0 - Server: nginx/1.23.1 - PHP: 7.4.32 - WordPress: 6.2-alpha-54642-src - Theme: twentytwentythree v1.0 === Actual Results - ✅ Block's image in frontend is not stretched, and properly reflects "object-fit: cover". (See Figure 2.) === Supplemental Artifacts [[Image(https://cldup.com/l1HVtxKGjy.png, 75%)]] ''Figure 1: Reproducing error.'' [[Image(https://cldup.com/ACg2o2cs-o.png, 75%)]] ''Figure 2: After patch.'' -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:58:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:58:01 -0000 Subject: [wp-trac] [WordPress Trac] #56873: Core Blocks validation error from wordpress 6.0.3 In-Reply-To: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> References: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> Message-ID: <067.fdfe492f3a51a8978c99ea3c8618cb81@wordpress.org> #56873: Core Blocks validation error from wordpress 6.0.3 --------------------------+------------------------------ Reporter: gigito78 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------------ Comment (by noisysocks): Another report of this here: https://wordpress.org/support/topic/getting- alot-of-console-errors-on-fresh-wordpress-install/ It looks like validation warnings for `button` are very common ([https://core.trac.wordpress.org/ticket/56873 1], [https://github.com/WordPress/gutenberg/issues/45179 2], [https://wordpress.org/support/topic/getting-alot-of-console-errors-on- fresh-wordpress-install/ 3]). Are we certain that the button block is not missing a deprecation? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 00:58:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 00:58:28 -0000 Subject: [wp-trac] [WordPress Trac] #50314: Twenty Twenty: Making heading bold also makes base font to be bold (was: Twenty Twenty | Making heading bold also makes base font to be bold) In-Reply-To: <056.601ff7a29d4c99dfe967f73f3467c9b0@wordpress.org> References: <056.601ff7a29d4c99dfe967f73f3467c9b0@wordpress.org> Message-ID: <071.320a7871c438dc7f2c13e587698630a0@wordpress.org> #50314: Twenty Twenty: Making heading bold also makes base font to be bold -------------------------------+---------------------- Reporter: mriyazuddin1 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: Severity: normal | Resolution: invalid Keywords: reporter-feedback | Focuses: -------------------------------+---------------------- Changes (by sabernhardt): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: I could not find the Fonts section within the Customizer either, so it likely is part of a plugin. If you still experience this, with no plugins active, please reopen the ticket and give more details. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 01:29:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 01:29:57 -0000 Subject: [wp-trac] [WordPress Trac] #56858: Blogger Importer: Undefined (dynamic) properties In-Reply-To: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> References: <058.74855eb287ea9157847e592e9993bb48@wordpress.org> Message-ID: <073.256dc257cbafbb5a6ef7680639b32fbc@wordpress.org> #56858: Blogger Importer: Undefined (dynamic) properties -------------------------------+---------------------------- Reporter: ironprogrammer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: WordPress.org Component: Import | Version: Severity: normal | Resolution: Keywords: needs-patch php82 | Focuses: -------------------------------+---------------------------- Comment (by jrf): FYI: I've done a quick scan of all these repos now with bleeding edge PHPCompatibility and send in some PRs to fix the most obvious issues. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 01:46:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 01:46:23 -0000 Subject: [wp-trac] [WordPress Trac] #56873: Core Blocks validation error from wordpress 6.0.3 In-Reply-To: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> References: <052.48d9488b8ed458783e5115aba1b7e6b5@wordpress.org> Message-ID: <067.a6be3ec7772367e35290efb8ba93aefe@wordpress.org> #56873: Core Blocks validation error from wordpress 6.0.3 --------------------------+------------------------------ Reporter: gigito78 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: javascript --------------------------+------------------------------ Comment (by wildworks): I have listed here the causes I expect for this problem: https://github.com/WordPress/gutenberg/issues/45153#issuecomment-1286350765 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 02:11:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 02:11:47 -0000 Subject: [wp-trac] [WordPress Trac] #55721: Visually align important data on the add new plugins screen In-Reply-To: <054.0b2d325abc4e00c7a235761064be3315@wordpress.org> References: <054.0b2d325abc4e00c7a235761064be3315@wordpress.org> Message-ID: <069.3ae21f20431ff18cd2cd8e11a8dd9ae8@wordpress.org> #55721: Visually align important data on the add new plugins screen ----------------------------------------------+---------------------------- Reporter: jamesckemp | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Plugins | Version: Severity: minor | Resolution: fixed Keywords: has-patch has-screenshots commit | Focuses: ui, | accessibility, css ----------------------------------------------+---------------------------- Comment (by peterwilsoncc): @mukesh27 added to props list via make/core per review in [comment:2 comment #2] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 04:22:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 04:22:27 -0000 Subject: [wp-trac] [WordPress Trac] #56874: Change the constant EBML_ID_COLOURSPACE to EBML_ID_COLORSPACE on module.audio-video.matroska.php Message-ID: <058.40315baef0cdd21fa00bd0be1f65ddee@wordpress.org> #56874: Change the constant EBML_ID_COLOURSPACE to EBML_ID_COLORSPACE on module .audio-video.matroska.php ------------------------------+----------------------------- Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: normal | Keywords: Focuses: coding-standards | ------------------------------+----------------------------- As colour is used as color so changing the constant EBML_ID_COLOURSPACE is more relevant for the developers. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 04:36:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 04:36:07 -0000 Subject: [wp-trac] [WordPress Trac] #56874: Change the constant EBML_ID_COLOURSPACE to EBML_ID_COLORSPACE on module.audio-video.matroska.php In-Reply-To: <058.40315baef0cdd21fa00bd0be1f65ddee@wordpress.org> References: <058.40315baef0cdd21fa00bd0be1f65ddee@wordpress.org> Message-ID: <073.c2abac9e5341cd64a00ac16728d57559@wordpress.org> #56874: Change the constant EBML_ID_COLOURSPACE to EBML_ID_COLORSPACE on module .audio-video.matroska.php --------------------------------+------------------------------- Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: External Libraries | Version: Severity: normal | Resolution: Keywords: has-patch close | Focuses: coding-standards --------------------------------+------------------------------- Changes (by jrf): * keywords: has-patch => has-patch close * version: 6.1 => * component: General => External Libraries Comment: @rakibwordpress The file you are referring to is from an external dependency: [https://github.com/JamesHeinrich/getID3 GetID3], which is not maintained here. Additionally, changing the name of this constant would be a breaking change, which, depending on the PHP version, could cause fatal errors if any code, be it a plugin, theme or even WP Core itself, would refer to that constant. I'd recommend closing this ticket without action. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 05:19:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 05:19:29 -0000 Subject: [wp-trac] [WordPress Trac] #42559: Twenty Fifteen: Menu fails to render on IE 11.0.48; OK on 11.0.47 In-Reply-To: <058.a8fb97a00a0f0fdd58993e682b4563c2@wordpress.org> References: <058.a8fb97a00a0f0fdd58993e682b4563c2@wordpress.org> Message-ID: <073.7992ecd68c9d45661b7a6ca81006daa6@wordpress.org> #42559: Twenty Fifteen: Menu fails to render on IE 11.0.48; OK on 11.0.47 ----------------------------+------------------------- Reporter: petergreen5678 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: Severity: normal | Resolution: worksforme Keywords: | Focuses: ----------------------------+------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => worksforme * milestone: Awaiting Review => Comment: Sorry, the [https://wordpress.org/support/forums/ support forums] (or ''WordPress.com'' support) probably would have been more helpful. And now few people use Internet Explorer anymore. I can set the background color and use the menu at various widths with Twenty Fifteen and no plugins. So I'll close the ticket as "works for me." However, the problem (still) can occur on your site in IE 11 at smaller window widths. This seems to be related to a custom colors plugin, and maybe another. The custom background color does not work because a script is supposed to add a `small-screen` body class when under 955 pixels. The menu does not expand, but I do not have console errors to explain why. If you already have access to the "Additional CSS" feature under Appearance, you could try adding this for IE users: {{{ @media all and (max-width: 954px) and (-ms-high-contrast: none), (-ms- high-contrast: active) { .sidebar .site-header { background-color: #202020; } .sidebar .secondary { display: block; background-color: #202020; } } }}} Otherwise, you could try deactivating certain plugins and/or contacting support. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 05:51:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 05:51:43 -0000 Subject: [wp-trac] [WordPress Trac] #50314: Twenty Twenty: Making heading bold also makes base font to be bold In-Reply-To: <056.601ff7a29d4c99dfe967f73f3467c9b0@wordpress.org> References: <056.601ff7a29d4c99dfe967f73f3467c9b0@wordpress.org> Message-ID: <071.ff4f4672f009253787d3bcdef2cf93b9@wordpress.org> #50314: Twenty Twenty: Making heading bold also makes base font to be bold ---------------------------+------------------------- Reporter: mriyazuddin1 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: Severity: normal | Resolution: worksforme Keywords: | Focuses: ---------------------------+------------------------- Changes (by sabernhardt): * keywords: reporter-feedback => * resolution: invalid => worksforme Comment: I found the Fonts section in the Customizer for ''WordPress.com''. However, setting the headings to bold did not affect the body text for me. They probably fixed this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 05:52:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 05:52:26 -0000 Subject: [wp-trac] [WordPress Trac] #50314: Twenty Twenty: Making heading bold also makes base font to be bold In-Reply-To: <056.601ff7a29d4c99dfe967f73f3467c9b0@wordpress.org> References: <056.601ff7a29d4c99dfe967f73f3467c9b0@wordpress.org> Message-ID: <071.4575227fad8338f4dd87bfa4f638743e@wordpress.org> #50314: Twenty Twenty: Making heading bold also makes base font to be bold ---------------------------+------------------------- Reporter: mriyazuddin1 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: Severity: normal | Resolution: worksforme Keywords: | Focuses: ---------------------------+------------------------- Changes (by sabernhardt): * Attachment "wordpress.com-twentytwenty-bold.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 06:08:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 06:08:47 -0000 Subject: [wp-trac] [WordPress Trac] #41071: Twenty Seventeen: Font Creates a Single Point of Failure In-Reply-To: <051.8f235016897f8fc546bfce2978397f7b@wordpress.org> References: <051.8f235016897f8fc546bfce2978397f7b@wordpress.org> Message-ID: <066.eedc9b573a3e9ec8c7f073597a03cf35@wordpress.org> #41071: Twenty Seventeen: Font Creates a Single Point of Failure ---------------------------+------------------------------ Reporter: jhabdas | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: ui, performance ---------------------------+------------------------------ Changes (by sabernhardt): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Twenty Seventeen and other themes could bundle the fonts soon, for privacy reasons. That ticket is #55985. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 06:27:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 06:27:07 -0000 Subject: [wp-trac] [WordPress Trac] #43241: Twenty Seventeen: Menu stays expanded after clicking on links (was: Twenty Seventeen: Menu behaviour is not proper) In-Reply-To: <056.9a803c71067b0feb6894a7f60d95e09b@wordpress.org> References: <056.9a803c71067b0feb6894a7f60d95e09b@wordpress.org> Message-ID: <071.0d2584a0e0aef70a7731fd7c89e91748@wordpress.org> #43241: Twenty Seventeen: Menu stays expanded after clicking on links -----------------------------------------+------------------------------ Reporter: nilamacharya | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 4.7 Severity: normal | Resolution: Keywords: has-screenshots 2nd-opinion | Focuses: ui, javascript -----------------------------------------+------------------------------ Changes (by sabernhardt): * keywords: has-screenshots => has-screenshots 2nd-opinion * focuses: ui => ui, javascript Old description: > Menu Items are sticky once user will click on it > > Steps: > > 1. Installed WordPress 4.9.4 > 2. Imported file"themeunittestdata.wordpress.xml" > 3. Activate Menu > > Issue: Menu is shown sticky after clicking on it (where there is # link > and third party links) > > Expected Bahaviour: It should be disappear once user will click on it New description: Menu Items are sticky once user will click on it Steps: 1. Installed WordPress 4.9.4 2. Imported file "themeunittestdata.wordpress.xml" 3. Activated Menu Issue: Menu is shown sticky after clicking on it (where there is `#` link and third party links) Expected Behaviour: It should be disappear once user will click on it -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 06:31:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 06:31:21 -0000 Subject: [wp-trac] [WordPress Trac] #16502: Quick Edit contents should only be rendered if quick edit button in actions after filtering In-Reply-To: <050.8e1bed58f7d42efa607afa9787c54d66@wordpress.org> References: <050.8e1bed58f7d42efa607afa9787c54d66@wordpress.org> Message-ID: <065.475d54df1df927da39ce68691c5cc412@wordpress.org> #16502: Quick Edit contents should only be rendered if quick edit button in actions after filtering -------------------------------------------------+------------------------- Reporter: wyrfel | Owner: chriscct7 Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.2 Component: Quick/Bulk Edit | Version: 3.0.4 Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info | -------------------------------------------------+------------------------- Changes (by mukesh27): * milestone: Future Release => 6.2 Comment: Move to `6.2` consideration as PR is ready for final review and merge. cc. @costdev @peterwilsoncc -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 07:02:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 07:02:15 -0000 Subject: [wp-trac] [WordPress Trac] #56871: Twenty Twenty: Pullquote block ignores custom font sizes In-Reply-To: <060.09b707a8606259435bcc4ebfc33fd51b@wordpress.org> References: <060.09b707a8606259435bcc4ebfc33fd51b@wordpress.org> Message-ID: <075.be29e8166b01b524aa05e6bb0c93f8e2@wordpress.org> #56871: Twenty Twenty: Pullquote block ignores custom font sizes ------------------------------+------------------------------ Reporter: nidhidhandhukiya | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: css ------------------------------+------------------------------ Changes (by multidots1896): * Attachment "56871.patch" added. Applied patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 07:24:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 07:24:02 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.4ba73fd266e0ee207b5b0d7952324648@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info has-unit-tests | -------------------------------------------------+------------------------- Comment (by xknown): Replying to [comment:11 Bernhard Reiter]: > Replying to [comment:4 pbiron]: > > As the the addition of the call to `safecss_filter_attr()` was added for security reasons, the WP security team should double check the patch to make sure it doesn't open any vulnerabilities. > > @xknown Would you mind giving this a look? :) The change to `safecss_filter_attr` seems fine to me. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 07:53:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 07:53:49 -0000 Subject: [wp-trac] [WordPress Trac] #55981: Twenty Nineteen: Pullquote Block Text Color not reflected on frontend In-Reply-To: <053.f531ea2a2411e333bed45eed96689000@wordpress.org> References: <053.f531ea2a2411e333bed45eed96689000@wordpress.org> Message-ID: <068.b9c6cb1bb02640e9575140b14ef159b8@wordpress.org> #55981: Twenty Nineteen: Pullquote Block Text Color not reflected on frontend ---------------------------+----------------------- Reporter: nithins53 | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: css ---------------------------+----------------------- Changes (by sabernhardt): * keywords: has-patch commit => has-patch Comment: For the follow-up tickets, we can probably use #56455 and #56456. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 08:02:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 08:02:44 -0000 Subject: [wp-trac] [WordPress Trac] #56476: Twenty Twenty-One: Comment missing at the end of HTML tag in author-bio.php In-Reply-To: <056.d7f5a73ada011e56b0b824e2cfaca951@wordpress.org> References: <056.d7f5a73ada011e56b0b824e2cfaca951@wordpress.org> Message-ID: <071.bbf584a8fc7c1acfc0f42596346faace@wordpress.org> #56476: Twenty Twenty-One: Comment missing at the end of HTML tag in author-bio.php ---------------------------+------------------------------- Reporter: haritpanchal | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Bundled Theme | Version: 6.0.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ---------------------------+------------------------------- Changes (by sabernhardt): * milestone: Awaiting Review => 6.2 Comment: This would make the author title consistent with [https://core.trac.wordpress.org/browser/trunk/src/wp- content/themes/twentytwentyone/comments.php?rev=52149#L44 comments-title]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 08:43:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 08:43:40 -0000 Subject: [wp-trac] [WordPress Trac] #45950: Twenty Nineteen: Fix social media icons to use the correct height & width attribute In-Reply-To: <053.bfbadd916c879f336f373ff6ac86b36c@wordpress.org> References: <053.bfbadd916c879f336f373ff6ac86b36c@wordpress.org> Message-ID: <068.7ad727a26a7342bb9e54aca2e5fcdd14@wordpress.org> #45950: Twenty Nineteen: Fix social media icons to use the correct height & width attribute -------------------------------------------------+------------------------- Reporter: crunnells | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future | Release Component: Bundled Theme | Version: 5.0.3 Severity: normal | Resolution: Keywords: has-screenshots good-first-bug has- | Focuses: patch | -------------------------------------------------+------------------------- Changes (by tahmidulkarim): * keywords: has-screenshots needs-patch good-first-bug => has-screenshots good-first-bug has-patch Comment: I have changed it to 32. Patch attached. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 08:43:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 08:43:58 -0000 Subject: [wp-trac] [WordPress Trac] #45950: Twenty Nineteen: Fix social media icons to use the correct height & width attribute In-Reply-To: <053.bfbadd916c879f336f373ff6ac86b36c@wordpress.org> References: <053.bfbadd916c879f336f373ff6ac86b36c@wordpress.org> Message-ID: <068.108f3c1a1786579ee53faa4d14061058@wordpress.org> #45950: Twenty Nineteen: Fix social media icons to use the correct height & width attribute -------------------------------------------------+------------------------- Reporter: crunnells | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future | Release Component: Bundled Theme | Version: 5.0.3 Severity: normal | Resolution: Keywords: has-screenshots good-first-bug has- | Focuses: patch | -------------------------------------------------+------------------------- Changes (by tahmidulkarim): * Attachment "45950.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 09:52:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 09:52:16 -0000 Subject: [wp-trac] [WordPress Trac] #56875: Need help to fix a translation bug! Message-ID: <052.6e148b05768e5e4dc00024bd5ca25a3b@wordpress.org> #56875: Need help to fix a translation bug! --------------------------+----------------------------------- Reporter: tajul707 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Text Changes | Version: 6.0.3 Severity: critical | Keywords: needs-design-feedback Focuses: javascript | --------------------------+----------------------------------- Hi, I'm Tajul, a web designer for the website https://watchstore4you.com/en/shop/ There is a translation bug need to fix. In the website language, it's ok but in other language show an HTML bug. You can see the image or visit the website to understand better. [[Image(http://watchstore4you.com/wp- content/uploads/2022/10/watchstore4you.com-translate-issue.png)]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 10:29:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 10:29:12 -0000 Subject: [wp-trac] [WordPress Trac] #56868: Add test coverage for _truncate_post_slug In-Reply-To: <050.475dc509f2e4d54267e798ba7f46d8eb@wordpress.org> References: <050.475dc509f2e4d54267e798ba7f46d8eb@wordpress.org> Message-ID: <065.65527f818c9c683d6ce8ad33d429f7f0@wordpress.org> #56868: Add test coverage for _truncate_post_slug -------------------------------------------------+------------------------- Reporter: xknown | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests changes- | Focuses: requested | -------------------------------------------------+------------------------- Changes (by mukesh27): * keywords: has-patch has-unit-tests => has-patch has-unit-tests changes- requested Comment: @xknown left some review on PR. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 10:41:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 10:41:43 -0000 Subject: [wp-trac] [WordPress Trac] #47357: $allowedentitynames could be null In-Reply-To: <053.8143056b74fdda82c993f7def2a436f0@wordpress.org> References: <053.8143056b74fdda82c993f7def2a436f0@wordpress.org> Message-ID: <068.16bf40eb9acbb8ecffb57f8ea0d24f36@wordpress.org> #47357: $allowedentitynames could be null -------------------------------------+----------------------------- Reporter: doctorlai | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Formatting | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Comment (by mukesh27): @SergeyBiryukov The [attachment:"47357.2.diff"] looks good. Do we needs unit test to check this behavior? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 10:58:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 10:58:20 -0000 Subject: [wp-trac] [WordPress Trac] #53331: Twenty Twenty-One: Bug in primary-navigation.js In-Reply-To: <053.3148162428a154d0a773d5d1f519f452@wordpress.org> References: <053.3148162428a154d0a773d5d1f519f452@wordpress.org> Message-ID: <068.2868676e87cca415ef63c11b3b470bf6@wordpress.org> #53331: Twenty Twenty-One: Bug in primary-navigation.js -------------------------------------+------------------------- Reporter: andreaboe | Owner: poena Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.2 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: javascript -------------------------------------+------------------------- Comment (by mukesh27): @poena Thanks. PR looks good to me and approved. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 12:05:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 12:05:58 -0000 Subject: [wp-trac] [WordPress Trac] #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 Message-ID: <057.a18be0ce4742f66dcfcddb410d1d9456@wordpress.org> #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 ---------------------------+------------------------------------------ Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: needs-patch needs-unit-tests Focuses: | ---------------------------+------------------------------------------ Developers should get a notice when trying to get or set a dynamic property on `WP_List_Table`. The current implementation of the class correctly handles some dynamic properties. But, in addition to the allowed dynamic properties, it enables the use of arbitrary properties. This behavior is incompatible with PHP 8.2 and should be fixed. Props to @jrf for identifying the issue 👏. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 12:06:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 12:06:24 -0000 Subject: [wp-trac] [WordPress Trac] #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 In-Reply-To: <057.a18be0ce4742f66dcfcddb410d1d9456@wordpress.org> References: <057.a18be0ce4742f66dcfcddb410d1d9456@wordpress.org> Message-ID: <072.d466a16cf6122e43e4abcab38d65c65c@wordpress.org> #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 ------------------------------------------+------------------------------ Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+------------------------------ Comment (by antonvlasenko): I'm working on a patch for this issue. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 12:30:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 12:30:38 -0000 Subject: [wp-trac] [WordPress Trac] #56877: dbDelta regex matches the incorrect Table/Database name as IF when using CREATE TABLE IF NOT EXISTS in the query Message-ID: <055.685cd160fbf761e3108232e17c315118@wordpress.org> #56877: dbDelta regex matches the incorrect Table/Database name as IF when using CREATE TABLE IF NOT EXISTS in the query -----------------------------+----------------------------- Reporter: sathyapulse | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- The dbDelta function is used by plugins to create a custom table in the database. When the plugin uses the query that starts with `CREATE TABLE IF NOT EXISTS` or `CREATE DATABASE IF NOT EXISTS`, the regex matches the incorrect table or database name as `IF`. The function checks if the table exists using `DESCRIBE {$table};`. In this case, `DESCRIBE IF` produces a MySQL syntax error, but it's silently ignored, and the execution continues. It's not a major issue with the latest WordPress version and PHP 8.1 because the [https://core.trac.wordpress.org/ticket/52825 MySQLi error reporting has been turned off since 5.9]. It might produce a below fatal error with PHP 8.1 (because of [https://www.php.net/releases/8.1/en.php MySQLi error reporting change]) and WordPress versions older than 5.9. {{{ PHP Fatal error: Uncaught mysqli_sql_exception: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'IF }}} Regardless of MySQLi error reporting, it would be good to address the incorrect table/database name match. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 12:32:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 12:32:19 -0000 Subject: [wp-trac] [WordPress Trac] #56877: dbDelta regex matches the incorrect Table/Database name as IF when using CREATE TABLE IF NOT EXISTS in the query In-Reply-To: <055.685cd160fbf761e3108232e17c315118@wordpress.org> References: <055.685cd160fbf761e3108232e17c315118@wordpress.org> Message-ID: <070.271c66373dfcb011a2b0754fb17e7b52@wordpress.org> #56877: dbDelta regex matches the incorrect Table/Database name as IF when using CREATE TABLE IF NOT EXISTS in the query -----------------------------+------------------------------ Reporter: sathyapulse | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Changes (by sathyapulse): * Attachment "56877.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 12:43:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 12:43:00 -0000 Subject: [wp-trac] [WordPress Trac] #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 In-Reply-To: <057.a18be0ce4742f66dcfcddb410d1d9456@wordpress.org> References: <057.a18be0ce4742f66dcfcddb410d1d9456@wordpress.org> Message-ID: <072.30715ea9e010f69394efc579aca4285f@wordpress.org> #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 ------------------------------------------+------------------------------ Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: trunk Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+------------------------------ Changes (by SergeyBiryukov): * component: General => Administration -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 12:46:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 12:46:12 -0000 Subject: [wp-trac] [WordPress Trac] #56877: dbDelta regex matches the incorrect Table/Database name as IF when using CREATE TABLE IF NOT EXISTS in the query In-Reply-To: <055.685cd160fbf761e3108232e17c315118@wordpress.org> References: <055.685cd160fbf761e3108232e17c315118@wordpress.org> Message-ID: <070.881a9ef4130bdac5e89f1c7f88422c7f@wordpress.org> #56877: dbDelta regex matches the incorrect Table/Database name as IF when using CREATE TABLE IF NOT EXISTS in the query -----------------------------+------------------------ Reporter: sathyapulse | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Upgrade/Install | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! Thanks for the report, we're already tracking this in #41335. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 12:48:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 12:48:51 -0000 Subject: [wp-trac] [WordPress Trac] #56874: Change the constant EBML_ID_COLOURSPACE to EBML_ID_COLORSPACE on module.audio-video.matroska.php In-Reply-To: <058.40315baef0cdd21fa00bd0be1f65ddee@wordpress.org> References: <058.40315baef0cdd21fa00bd0be1f65ddee@wordpress.org> Message-ID: <073.96ce5b90b78278a7474feee5b3b5caf1@wordpress.org> #56874: Change the constant EBML_ID_COLOURSPACE to EBML_ID_COLORSPACE on module .audio-video.matroska.php --------------------------------+------------------------------- Reporter: rakibwordpress | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: External Libraries | Version: Severity: normal | Resolution: wontfix Keywords: has-patch | Focuses: coding-standards --------------------------------+------------------------------- Changes (by SergeyBiryukov): * keywords: has-patch close => has-patch * status: new => closed * resolution: => wontfix * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! As noted above, GetID3 is an external library and should not be patched here, any suggested changes to its files should be submitted upstream. It's worth noting that while the [https://make.wordpress.org/core/handbook /best-practices/spelling/ spelling guidelines] do indeed recommend American spelling, e.g. color instead of colour, these guidelines only apply to WordPress core and not to external libraries. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 12:51:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 12:51:37 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.e3482e8ee0f73c3cd2494f3eb7c614ae@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by swissspidy): > This doesn't address the underlying bug, since even with this caching, `load_textdomain()` still is called >100 times within one page load - that is the root problem here. Precisely. Please check out https://github.com/WordPress/wordpress-develop/pull/3506 for a proper fix. I know this is time-critical, which is why I have spent yesterday and today looking into it, including consulting with @ocean90. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 13:02:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 13:02:49 -0000 Subject: [wp-trac] [WordPress Trac] #47357: $allowedentitynames could be null In-Reply-To: <053.8143056b74fdda82c993f7def2a436f0@wordpress.org> References: <053.8143056b74fdda82c993f7def2a436f0@wordpress.org> Message-ID: <068.f66a06fe82e76c4db6988ef46fee41be@wordpress.org> #47357: $allowedentitynames could be null -------------------------------------+----------------------------- Reporter: doctorlai | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Formatting | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Comment (by SergeyBiryukov): Replying to [comment:16 mukesh27]: > The [attachment:"47357.2.diff"] looks good. Do we needs unit test to check this behavior? Thanks! I thought about that, but a unit test does not seem feasible here, as it would need to define the `CUSTOM_TAGS` constant, which cannot be unset and would then affect all the other KSES tests. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 13:05:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 13:05:34 -0000 Subject: [wp-trac] [WordPress Trac] #41335: dbDelta() does not recognize MySQL's IF NOT EXISTS statement In-Reply-To: <050.332a21d64c60d43e8fccdca17e522651@wordpress.org> References: <050.332a21d64c60d43e8fccdca17e522651@wordpress.org> Message-ID: <065.e330d5ca3c23d3ef115d98d37410a6a7@wordpress.org> #41335: dbDelta() does not recognize MySQL's IF NOT EXISTS statement -----------------------------------------+------------------------------ Reporter: kmaxim | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: has-patch reporter-feedback | Focuses: -----------------------------------------+------------------------------ Changes (by sathyapulse): * Attachment "41335.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 13:28:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 13:28:28 -0000 Subject: [wp-trac] [WordPress Trac] #56743: Update jquery-migrate to version 3.4.0 In-Reply-To: <051.049995bd545e4599dea7c354a7c0c832@wordpress.org> References: <051.049995bd545e4599dea7c354a7c0c832@wordpress.org> Message-ID: <066.c499e8490339a5e57348892b77d27d11@wordpress.org> #56743: Update jquery-migrate to version 3.4.0 ----------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: External Libraries | Version: Severity: normal | Resolution: Keywords: good-first-bug needs-patch | Focuses: ----------------------------------------+--------------------- Comment (by a4jp.com): Any chance of getting 3.4.0 in 6.1 as it's just a link change on your side and as jQuery Migrate is still in WordPress? Or a warning removal at least: {{{ /*Remove JQuery Migrate warning*/ function remove_jquery_migrate_notice() { $m= $GLOBALS['wp_scripts']->registered['jquery-migrate']; $m->extra['before'][]='temp_jm_logconsole = window.console.log; window.console.log=null;'; $m->extra['after'][]='window.console.log=temp_jm_logconsole;'; } add_action( 'init', 'remove_jquery_migrate_notice', 5 ); }}} [https://core.trac.wordpress.org/ticket/51812#comment:133] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 13:33:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 13:33:02 -0000 Subject: [wp-trac] [WordPress Trac] #56839: Document the $wp_query global in WP_Media_List_Table::display_rows() In-Reply-To: <056.1859d2da56be16f6bf074e9e164b071c@wordpress.org> References: <056.1859d2da56be16f6bf074e9e164b071c@wordpress.org> Message-ID: <071.0f05464e194011888419d3dd622d4f14@wordpress.org> #56839: Document the $wp_query global in WP_Media_List_Table::display_rows() --------------------------+----------------------------------- Reporter: upadalavipul | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Media | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: docs, administration --------------------------+----------------------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 13:34:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 13:34:10 -0000 Subject: [wp-trac] [WordPress Trac] #56839: Document the $wp_query global in WP_Media_List_Table::display_rows() In-Reply-To: <056.1859d2da56be16f6bf074e9e164b071c@wordpress.org> References: <056.1859d2da56be16f6bf074e9e164b071c@wordpress.org> Message-ID: <071.27fc930a1125d1fa7c290d2a0320f1fa@wordpress.org> #56839: Document the $wp_query global in WP_Media_List_Table::display_rows() --------------------------+----------------------------------- Reporter: upadalavipul | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: Media | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: docs, administration --------------------------+----------------------------------- Changes (by SergeyBiryukov): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"54661" 54661]: {{{ #!CommitTicketReference repository="" revision="54661" Docs: Document the usage of `$wp_query` global in `WP_Media_List_Table::display_rows()`. Follow-up to [34127]. Props upadalavipul, saumil1611. Fixes #56839. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 13:56:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 13:56:51 -0000 Subject: [wp-trac] [WordPress Trac] #54354: Open_basedir warnings on Classic Post edit screens with TinyMce plugins present, like TinyMce Advanced In-Reply-To: <050.6a5a289624d37a0e26a715062936f55d@wordpress.org> References: <050.6a5a289624d37a0e26a715062936f55d@wordpress.org> Message-ID: <065.e4048bbbf84fed96cc124dd76dea5c62@wordpress.org> #54354: Open_basedir warnings on Classic Post edit screens with TinyMce plugins present, like TinyMce Advanced --------------------------+------------------------------ Reporter: rembem | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.8.3 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by MadtownLems): * version: 5.8.1 => 5.8.3 Comment: I'm experiencing the same errors. For me, they don't even need the Classic Editor. I'm getting them on a brand new post with the Block Editor. It's caused by a very small custom plugin that enables rich text editing for Post Excerpts. Never saw the error before upgrading to PHP8. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 14:58:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 14:58:56 -0000 Subject: [wp-trac] [WordPress Trac] #56878: Remove Desktopserver from references Message-ID: <055.2ae5a1b5f47f7178487c157e3829f2fa@wordpress.org> #56878: Remove Desktopserver from references --------------------------+------------------------------- Reporter: mayankgupta | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: changes-requested Focuses: docs | --------------------------+------------------------------- ## Issue Description [https://serverpress.com/ DesktopServer] has shut down and isn't available anymore. ## URL of the Pages with the Issue - [https://make.wordpress.org/core/handbook/tutorials/installing-a-local- server/ Installing a local server] - [https://make.wordpress.org/core/handbook/tutorials/installing-a-local- server/desktopserver/ Installing DesktopServer] - [https://make.wordpress.org/core/handbook/tutorials/installing- wordpress-locally/from-zip Installing from Zip] - [https://make.wordpress.org/core/handbook/tutorials/installing-a-local- server/wampserver/ WampServer] - [https://make.wordpress.org/core/handbook/tutorials/installing- wordpress-locally/from-svn/ SVN] - [https://make.wordpress.org/core/handbook/tutorials/getting-started/ Getting Started] - [https://make.wordpress.org/core/handbook/contribute/ Contribute] **Section of Page with the issue** - [https://make.wordpress.org/core/handbook/tutorials/installing-a-local- server/#which-local-server-should-i-install Which local server should I install?] - Whole Document Page of [https://make.wordpress.org/core/handbook/tutorials/installing-a-local- server/desktopserver/ Installing DesktopServer] **Why is this a problem?** DesktopServer has already announced that they're shutting down. ## Suggested Fix Replace it with Open-source tool, DDEV. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 15:07:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 15:07:44 -0000 Subject: [wp-trac] [WordPress Trac] #56879: Add DDEV Page to Install Local Server Docs Message-ID: <055.cc77fa6e6c74d3a8847dfc8ba58f736e@wordpress.org> #56879: Add DDEV Page to Install Local Server Docs -----------------------------+----------------------------- Reporter: mayankgupta | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: needs-docs Focuses: docs | -----------------------------+----------------------------- **What is the new page you are requesting?** https://make.wordpress.org/core/handbook/tutorials/installing-a-local- server/ On this page, I'd request to add [https://ddev.com DDEV], an open-source command line tool that helps install multiple WordPress local installs and it works across multiple OSes (Windows, Linux, OSX, WSL2) **How will this new page help you?** It helps developers launch new local WordPress projects with ease and saves time and effort to do trivial local development tasks, like backing up databases, snapshots, local domain mapping, push to different hosts etc. **Is there a help document created?** Here are the [https://docs.google.com/document/d /1JGEoZtaVUv5LiPPvgd3Monf7jTlziTKc-2TSovyS0jY/edit#heading=h.fgqs9gmg2byr instructions to setup DDEV]. **Related Ticket** #56878 Remove DesktopServer from docs -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 15:11:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 15:11:56 -0000 Subject: [wp-trac] [WordPress Trac] #56878: Remove Desktopserver references from the docs (was: Remove Desktopserver from references) In-Reply-To: <055.2ae5a1b5f47f7178487c157e3829f2fa@wordpress.org> References: <055.2ae5a1b5f47f7178487c157e3829f2fa@wordpress.org> Message-ID: <070.5b3fc876b4d013feb0a2c189a4147c89@wordpress.org> #56878: Remove Desktopserver references from the docs -------------------------------+------------------------------ Reporter: mayankgupta | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: changes-requested | Focuses: docs -------------------------------+------------------------------ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 15:15:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 15:15:38 -0000 Subject: [wp-trac] [WordPress Trac] #56880: Allow to select which columns to use when doing a search query Message-ID: <052.dd01f6eb66f6be14d7589a2ef3404ef5@wordpress.org> #56880: Allow to select which columns to use when doing a search query -------------------------+----------------------------- Reporter: petitphp | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Query | Version: trunk Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- Currently, there is no way of specifying which columns will be searched by a `WP_Query` when using the search parameter (`s`). The query will look for the terms in `post_title`, `post_content` and `post_excerpt` columns. To restrict the search to specific columns, we can either manipulate the SQL clauses using the available hooks or write a custom SQL query. This is not practical, and it can lead to incorrect or unoptimized results. This ticket proposes to add a new parameter `search_columns` to the `WP_Query` where we can choose which columns will be searched : {{{#!php 'the quick brown fox', 'search_columns' => ['post_title'], ) ); // Searching on post title and excerpt $q = new WP_Query( array( 's' => 'the quick brown fox', 'search_columns' => ['post_title', 'post_excerpt'], ) ); }}} This new parameter takes an array of columns' names, with only the existing columns allowed as values (`post_title`, `post_content` and `post_excerpt`). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 15:21:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 15:21:43 -0000 Subject: [wp-trac] [WordPress Trac] #56880: Allow to select which columns to use when doing a search query In-Reply-To: <052.dd01f6eb66f6be14d7589a2ef3404ef5@wordpress.org> References: <052.dd01f6eb66f6be14d7589a2ef3404ef5@wordpress.org> Message-ID: <067.c7ec1ff63f203af31f142dd7380304ce@wordpress.org> #56880: Allow to select which columns to use when doing a search query --------------------------------------+------------------------------ Reporter: petitphp | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Query | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Changes (by johnbillion): * version: trunk => Comment: Related / dupliadte: #43867 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 15:30:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 15:30:02 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.0a31a13cf4eaa234fade3e27b3a15ac7@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ---------------------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch needs-design-feedback | Focuses: accessibility ---------------------------------------------+---------------------------- Changes (by ryokuhi): * keywords: has-patch => has-patch needs-design-feedback Comment: We reviewed this ticket today during the Accessibility Team's weekly bug scrub. The changes suggested by @sabernhardt regarding the `aria-hidded`, the `focusable`, and the `viewBox` attributes are needed. Regarding the use of `circle`s instead of `path`s, such a change would make the file sizes much smaller. It would probably be easier if someone from the Design Team with the source files could make these changes. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 15:58:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 15:58:25 -0000 Subject: [wp-trac] [WordPress Trac] #56789: Toolbar: screen-reader-shortcut does not have background color until focused In-Reply-To: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> References: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> Message-ID: <070.45853d2746d90ab01f529c425e129d8e@wordpress.org> #56789: Toolbar: screen-reader-shortcut does not have background color until focused -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Toolbar | Version: Severity: minor | Resolution: Keywords: has-patch needs-testing has- | Focuses: screenshots needs-testing-info | accessibility, css -------------------------------------------------+------------------------- Changes (by sabernhardt): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 16:41:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 16:41:52 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.9bb2c4ac3e5cb8f56ee5f8082a40b572@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: accessibility ------------------------------+---------------------------- Changes (by ryelle): * keywords: has-patch needs-design-feedback => has-patch commit Comment: Patch [attachment:"56703.diff"] looks good, I don't see any visual change from using `circle` and the file is notably smaller. I'm going to move the conversation about the other About images over to the About page ticket though. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 16:42:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 16:42:43 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.f76ea7510016f25863f36a8436c84124@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 ------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: accessibility ------------------------------+---------------------------- Comment (by ryelle): In [changeset:"54662" 54662]: {{{ #!CommitTicketReference repository="" revision="54662" Help/About: Update the About header image. When used inline, the SVG needs the `aria-hidden`, `focusable`, and `viewBox` properties for accessibility. Additionally, this optimizes the SVG by using `cirlce` elements in place of `path`, and removing `clipPath`. There is no visible change, but the file is now one-third the size. Props sabernhardt. See #56703, #56357. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 16:42:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 16:42:43 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.e4648985bfd9d284d569933a61a31933@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, accessibility, docs, | administration, ui-copy -------------------------+------------------------------------------------- Comment (by ryelle): In [changeset:"54662" 54662]: {{{ #!CommitTicketReference repository="" revision="54662" Help/About: Update the About header image. When used inline, the SVG needs the `aria-hidden`, `focusable`, and `viewBox` properties for accessibility. Additionally, this optimizes the SVG by using `cirlce` elements in place of `path`, and removing `clipPath`. There is no visible change, but the file is now one-third the size. Props sabernhardt. See #56703, #56357. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 16:43:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 16:43:34 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.d9938e7260d178ba0f873ee8d43f6dd5@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 -------------------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch commit dev-feedback | Focuses: accessibility -------------------------------------------+---------------------------- Changes (by ryelle): * keywords: has-patch commit => has-patch commit dev-feedback Comment: Marking [54662] for backport after a second committer review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 16:52:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 16:52:02 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.d33c6124fe32290a56abac810dde6b94@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs- | Focuses: ui, accessibility, docs, design-feedback | administration, ui-copy -------------------------+------------------------------------------------- Changes (by ryelle): * keywords: => needs-design-feedback Comment: Moving some discussion to here from the Dashboard Welcome panel ticket #56703 > @sabernhardt: I'd also like to consider changing each path element to circle and removing the clip-path so the image can be much smaller. (I could convert the Freedoms image to circles, too, but the Credits and Privacy SVGs are more complicated.) > @ryokuhi: Regarding the use of circles instead of paths, such a change would make the file sizes much smaller. > It would probably be easier if someone from the Design Team with the source files could make these changes. The change does make the files smaller — in [54662], the main About header image (the "6.1") was updated to use `circle` elements in the SVG, instead of the `path` that Figma generated, and it did shrink the SVG notably. The source files are in Figma. What would be the best way to update those so they export to `circle`? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 17:10:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 17:10:14 -0000 Subject: [wp-trac] [WordPress Trac] #52038: Issue in WooCommerce with wp_editor() after update to WP 5.6 In-Reply-To: <057.520f90cbea890d10bb45700f3195f877@wordpress.org> References: <057.520f90cbea890d10bb45700f3195f877@wordpress.org> Message-ID: <072.dc153bec081483e8ffabc649a14b6a34@wordpress.org> #52038: Issue in WooCommerce with wp_editor() after update to WP 5.6 -------------------------------------------------+--------------------- Reporter: rodrigosprimo | Owner: azaozz Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.6.1 Component: General | Version: 5.6.1 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing fixed-major | Focuses: -------------------------------------------------+--------------------- Comment (by busylizzycreations): This bug is NOT fixed with version: 6.0.3 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 17:21:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 17:21:25 -0000 Subject: [wp-trac] [WordPress Trac] #55942: Add a "type" field to the meta and options tables In-Reply-To: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> References: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> Message-ID: <065.80b1ca16bad25daf1e500115d702fca7@wordpress.org> #55942: Add a "type" field to the meta and options tables -------------------------------------------------+------------------------- Reporter: azaozz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Comment (by flixos90): I love the idea of this ticket, but I'm wary about how we can solve it in a backward compatible way while also not making the API super clunky. To me, the main concern here is that plugins today may to do something like `get_option( 'some_boolean_ish_option' ) === '1'`, which could break following this change. To be clear, I would discourage anyone from writing code like that, but it's probably out there :) Similarly, for integer and float comparison, while it's already encouraged to always type-cast `get_option()` results, there are probably some plugins today that use either loose comparison (discouraged) or explicitly compare with a string (also discouraged), like `get_option( 'some_number' ) === '42'`. @azaozz Is your idea that the new type column value would be set based on the data passed to `add_option()` / `update_option()`, or based on the registered type of only registered settings? I wonder whether something like the latter could be used to make this more of an opt-in thing. Or alternatively we can see about a slow rollout, where we post about this in advance, potentially even send something about it in an email to plugin developers, and/or build checks to catch problems like the above into WPCS. Some of this may be a stretch, but let's see :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 17:21:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 17:21:31 -0000 Subject: [wp-trac] [WordPress Trac] #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 In-Reply-To: <057.a18be0ce4742f66dcfcddb410d1d9456@wordpress.org> References: <057.a18be0ce4742f66dcfcddb410d1d9456@wordpress.org> Message-ID: <072.a31d1f9df7b8cb9dc825dfb222d8c059@wordpress.org> #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 ------------------------------------------+------------------------------ Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: trunk Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: ------------------------------------------+------------------------------ Comment (by antonvlasenko): Would it be possible to add the "php82" keyword to this ticket? Thanks. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 17:30:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 17:30:54 -0000 Subject: [wp-trac] [WordPress Trac] #56881: V6.0.3 Post Featured Image block - Scale feature always defaults to Fill even if Cover or Contain selected Message-ID: <056.a10b52b461bcbf6fcae3b06e5e4619c3@wordpress.org> #56881: V6.0.3 Post Featured Image block - Scale feature always defaults to Fill even if Cover or Contain selected --------------------------+----------------------------- Reporter: ckanderson22 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 6.0.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Using the Post Featured Image block inside Post Template block inside Query Loop block. I select Cover or Contain for the image scale, but it always defaults to Fill. V6.0.2 scales correctly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 18:07:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 18:07:19 -0000 Subject: [wp-trac] [WordPress Trac] #56882: Backport several GitHub Action compatibility fixes Message-ID: <051.1413d83f95ccdc44863f6897db74f869@wordpress.org> #56882: Backport several GitHub Action compatibility fixes ------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Keywords: Focuses: | ------------------------------+---------------------- There are several changes on the GitHub Action platform that need to be backported to older branches to ensure workflows continue to run. These changes address the following from upstream: - Node.js 12 has been deprecated on GHA runners and will be removed in 2023 (see [https://github.blog/changelog/2022-09-22-github-actions-all- actions-will-begin-running-on-node16-instead-of-node12/ upstream blog post]). - `set-output` and `save-state` have been deprecated. Starting 1st June 2023 workflows using these commands will fail (see [https://github.blog/changelog/2022-10-11-github-actions-deprecating-save- state-and-set-output-commands/ upstream blog post]). While in some cases, these are not in use in Core workflow YML files, third party actions utilize these and need to be updated. Related: #56820. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 18:21:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 18:21:54 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.287d428fa4c273b444a3403341936411@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs- | Focuses: ui, accessibility, docs, design-feedback | administration, ui-copy -------------------------+------------------------------------------------- Changes (by sabernhardt): * Attachment "about-header-freedoms.diff" added. Freedoms image with `circle` elements -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 18:24:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 18:24:30 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.3971bc29c5ced19b0e7fc7241dcc0e4b@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs- | Focuses: ui, accessibility, docs, design-feedback | administration, ui-copy -------------------------+------------------------------------------------- Comment (by sabernhardt): In case we decide to shrink the other three SVG images, I was able to determine a friendly equation to make the Freedoms image. (Credits and Privacy are not as easy.) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 18:33:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 18:33:33 -0000 Subject: [wp-trac] [WordPress Trac] #55942: Add a "type" field to the meta and options tables In-Reply-To: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> References: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> Message-ID: <065.0e12ee69fecb61397f9843a39d056267@wordpress.org> #55942: Add a "type" field to the meta and options tables -------------------------------------------------+------------------------- Reporter: azaozz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Comment (by azaozz): @petitphp thanks for the patch! Looks pretty good :) Thinking perhaps there are too many filters, like the one on the default types, but lets talk about that on GH. Replying to [comment:22 flixos90]: > Is your idea that the new type column value would be set based on the data passed to `add_option()` / `update_option()`, or based on the registered type of only registered settings? Yeah, been (slowly) testing this and thinking how to handle back-compat. Still exploring what would be best. You're right, back-compat is pretty hard here. > plugins today may to do something like `get_option( 'some_boolean_ish_option' ) === '1'`, which could break following this change. Right, and it is even more complicated. Currently if a plugin does `add_option( 'my_option', true )` and then a bit later during the same run does `get_option( 'my_option' )` the returned value will be `true` as new and updated options are cached. I.e. `get_option()` will return the proper type and value as passed to `add_option()`. However if it does `get_option( 'my_option' )` on the next run, the returned value will be a string `'1'` the way it comes out of the DB. At the same time the biggest win here is to stop using `is_serialized()` and `maybe_unserialize()` for arrays and objects. Thinking when an array or object is passed to add/update_option or add/update_meta WP should automatically set the type. Then on retrieving options and meta it should unserialize the values. There won't be any back-compat problems there as this is how it works now. However for boolean and numeric values it would most likely have to be opt-in. Even looking at the patch, the places where `'1'` was replaces with `1`, etc. may cause problems in plugins (as many just copy code from core). In any case, lets try to figure out the back-compat during 6.2 and add this. It would be a pretty good enhancement. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 18:45:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 18:45:42 -0000 Subject: [wp-trac] [WordPress Trac] #56881: V6.0.3 Post Featured Image block - Scale feature always defaults to Fill even if Cover or Contain selected In-Reply-To: <056.a10b52b461bcbf6fcae3b06e5e4619c3@wordpress.org> References: <056.a10b52b461bcbf6fcae3b06e5e4619c3@wordpress.org> Message-ID: <071.382c3516e5049eae1b3df3b1d4307329@wordpress.org> #56881: V6.0.3 Post Featured Image block - Scale feature always defaults to Fill even if Cover or Contain selected --------------------------+------------------------ Reporter: ckanderson22 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Media | Version: 6.0.3 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Changes (by pbiron): * status: new => closed * resolution: => duplicate * component: Formatting => Media * milestone: Awaiting Review => Comment: Hi @ckanderson22. Thanx for the ticket (and welcome to Trac!). This problem is already being tracked in #56855, so I'm closing this ticket. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 19:14:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 19:14:34 -0000 Subject: [wp-trac] [WordPress Trac] #55942: Add a "type" field to the meta and options tables In-Reply-To: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> References: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> Message-ID: <065.572b2cc349ca61785ea92562c1e6f378@wordpress.org> #55942: Add a "type" field to the meta and options tables -------------------------------------------------+------------------------- Reporter: azaozz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Comment (by azaozz): Another option here (which I'm not fond off, but is a possible solution) would be to only add a `TINYINT` field to these tables indicating whether the data in the value field is serialized or not. That perhaps can be `0` for default/unknown, `1` for serialized, and maybe `2` for JSON encoded. This will reduce complexity and won't have back-compat problems, but will also miss the chance to further improve the options and meta APIs. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 19:27:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 19:27:09 -0000 Subject: [wp-trac] [WordPress Trac] #56883: Feeds of non-existent tags and categories displays an empty feed instead of 404 Message-ID: <052.349cb2b08c0e85535503071145b185f1@wordpress.org> #56883: Feeds of non-existent tags and categories displays an empty feed instead of 404 -----------------------------------+----------------------------- Reporter: rafaucau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Feeds | Version: 6.0.3 Severity: normal | Keywords: Focuses: template, performance | -----------------------------------+----------------------------- I noticed in Google Search Console that Google often visits feeds of tags that no longer exist. It turns out that the RSS feeds still work instead of returning a 404. Recreating the issue is simple: Go to the page of the non-existent tag, e.g. `/tag/asdsdsad/` and append `feed/` to the end of the address, eg. `/tag/asdsdsad/feed/`. An empty feed will be displayed instead of a 404. This should return a 404 so that search engine bots can forget about it instead of fetching it every so often. I have thousands of such deleted tags on my site. It would be better for the environment if the bots didn't waste resources on this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 19:28:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 19:28:00 -0000 Subject: [wp-trac] [WordPress Trac] #56883: Feeds of non-existent tags and categories displays an empty feed instead of 404 In-Reply-To: <052.349cb2b08c0e85535503071145b185f1@wordpress.org> References: <052.349cb2b08c0e85535503071145b185f1@wordpress.org> Message-ID: <067.5c5d7e49d38b37436641fb035c321bb3@wordpress.org> #56883: Feeds of non-existent tags and categories displays an empty feed instead of 404 --------------------------+------------------------------------ Reporter: rafaucau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Feeds | Version: 6.0.3 Severity: normal | Resolution: Keywords: | Focuses: template, performance --------------------------+------------------------------------ Changes (by rafaucau): * Attachment "tag.png" added. Non-existent tag -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 19:28:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 19:28:46 -0000 Subject: [wp-trac] [WordPress Trac] #56883: Feeds of non-existent tags and categories displays an empty feed instead of 404 In-Reply-To: <052.349cb2b08c0e85535503071145b185f1@wordpress.org> References: <052.349cb2b08c0e85535503071145b185f1@wordpress.org> Message-ID: <067.1c1bfbc277d9abd2968eaae9b6b1885a@wordpress.org> #56883: Feeds of non-existent tags and categories displays an empty feed instead of 404 --------------------------+------------------------------------ Reporter: rafaucau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Feeds | Version: 6.0.3 Severity: normal | Resolution: Keywords: | Focuses: template, performance --------------------------+------------------------------------ Changes (by rafaucau): * Attachment "feed.png" added. Feed of this tag. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 19:38:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 19:38:09 -0000 Subject: [wp-trac] [WordPress Trac] #37651: Update autoprefixer supported browser matrix In-Reply-To: <050.1beae1cfc5aeb152019f3358cababce0@wordpress.org> References: <050.1beae1cfc5aeb152019f3358cababce0@wordpress.org> Message-ID: <065.0d1c7a7dab86fb5983001efcd9f46d36@wordpress.org> #37651: Update autoprefixer supported browser matrix -----------------------------------------+--------------------- Reporter: netweb | Owner: jorbin Type: enhancement | Status: closed Priority: normal | Milestone: 4.9 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: kingroot apk latest version | Focuses: -----------------------------------------+--------------------- Comment (by dramacoolk9): Watch Online The Good Detective 2 (2022) Episode 5 English Sub has been released. The Good Detective 2 (2022) Ep 5 Eng Sub only at Dramacool And Kissasian will always be the first to have all episodes of asian dramas The Good Detective 2 (2022) with eng subtitles. So please Bookmark and visit daily to watch all Asian Dramas for free in High Quality.

The Good Detective 2 Episode 5 English Sub Dramacool

Dont Miss any drama cool shows. Bookmark and visit daily for the latest updates!!! Enjoy a free download. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 19:39:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 19:39:54 -0000 Subject: [wp-trac] [WordPress Trac] #37651: Update autoprefixer supported browser matrix In-Reply-To: <050.1beae1cfc5aeb152019f3358cababce0@wordpress.org> References: <050.1beae1cfc5aeb152019f3358cababce0@wordpress.org> Message-ID: <065.1665640fb9ade3b09024ac69d7bfa54f@wordpress.org> #37651: Update autoprefixer supported browser matrix -----------------------------------------+--------------------- Reporter: netweb | Owner: jorbin Type: enhancement | Status: closed Priority: normal | Milestone: 4.9 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: kingroot apk latest version | Focuses: -----------------------------------------+--------------------- Comment (by dramacoolk9): Watch Online One Dollar Lawyer (2022) Episode 10 English Sub has been released. One Dollar Lawyer (2022) Ep 10 Eng Sub only at Dramacool And Kissasian will always be the first to have all episodes of asian dramas One Dollar Lawyer (2022) with eng subtitles. So please Bookmark and visit daily to watch all Asian Dramas for free in High Quality. https://dramacoolk.me/ https://dramacoolk.me/one-dollar-lawyer-2022-episode-10-english-sub/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 20:08:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 20:08:44 -0000 Subject: [wp-trac] [WordPress Trac] #56853: Latest Posts block alignment on front end (was: In Twenty Two Theme: Latest Post block alignment issue occur on front end side.) In-Reply-To: <057.f1731f6231d4762bea4200aa38031a0e@wordpress.org> References: <057.f1731f6231d4762bea4200aa38031a0e@wordpress.org> Message-ID: <072.e8943ab83988a7e3f66d0d8518e672e8@wordpress.org> #56853: Latest Posts block alignment on front end -----------------------------------------------+--------------------------- Reporter: multidots1896 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Themes | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots reporter-feedback | Focuses: -----------------------------------------------+--------------------------- Changes (by sabernhardt): * keywords: has-screenshots => has-screenshots reporter-feedback * component: General => Themes Old description: > 1)Activate Twenty Twenty Two theme > 2)In page editor add Latest post block and align it as right. > 3)Add Calendar block and checking the page on front end side. New description: 1. Activate Twenty Twenty-Two theme. 2. In page editor, add Latest Posts block and align it as right. 3. Add Calendar block and check the page on front end side. -- Comment: The block also floats in other block themes: "TT1 Blocks" and Twenty Twenty-Three. The styles come from [https://core.trac.wordpress.org/browser/trunk/src/wp- includes/theme.json?rev=54162#L237 theme.json]. How did you want the block to align? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 20:41:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 20:41:53 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.0a4cb524889af5fcb246616c3c261a51@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 -------------------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch commit dev-reviewed | Focuses: accessibility -------------------------------------------+---------------------------- Changes (by SergeyBiryukov): * keywords: has-patch commit dev-feedback => has-patch commit dev-reviewed Comment: [54662] looks good to backport. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 21:07:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 21:07:52 -0000 Subject: [wp-trac] [WordPress Trac] #56811: Improved spelling, align with American English In-Reply-To: <050.89fa782a95ec55a36a11451765249078@wordpress.org> References: <050.89fa782a95ec55a36a11451765249078@wordpress.org> Message-ID: <065.fb82d8426580ee8638585195695956f9@wordpress.org> #56811: Improved spelling, align with American English --------------------------------------+------------------------------------ Reporter: kebbet | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs, coding- | standards --------------------------------------+------------------------------------ Changes (by audrasjb): * owner: (none) => audrasjb * status: new => reviewing Comment: The "behaviour/behavior" PR looks good to me. Self assigning for `commit`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 21:10:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 21:10:43 -0000 Subject: [wp-trac] [WordPress Trac] #56792: Docblock improvements for 6.2 In-Reply-To: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> References: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> Message-ID: <066.e5a970c34ffb4ec813d25e46c6b25f70@wordpress.org> #56792: Docblock improvements for 6.2 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs --------------------------------------+--------------------- Comment (by audrasjb): In [changeset:"54663" 54663]: {{{ #!CommitTicketReference repository="" revision="54663" Docs: Align spelling with American English. This changeset replaces "behaviour" with "behavior" in various docblocks. Props kebbet, jrf. See #56811, #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 21:10:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 21:10:43 -0000 Subject: [wp-trac] [WordPress Trac] #56811: Improved spelling, align with American English In-Reply-To: <050.89fa782a95ec55a36a11451765249078@wordpress.org> References: <050.89fa782a95ec55a36a11451765249078@wordpress.org> Message-ID: <065.32d382d2bedceab300220ab461dbfa18@wordpress.org> #56811: Improved spelling, align with American English --------------------------------------+------------------------------------ Reporter: kebbet | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs, coding- | standards --------------------------------------+------------------------------------ Comment (by audrasjb): In [changeset:"54663" 54663]: {{{ #!CommitTicketReference repository="" revision="54663" Docs: Align spelling with American English. This changeset replaces "behaviour" with "behavior" in various docblocks. Props kebbet, jrf. See #56811, #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 21:50:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 21:50:03 -0000 Subject: [wp-trac] [WordPress Trac] #56792: Docblock improvements for 6.2 In-Reply-To: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> References: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> Message-ID: <066.8fc506de592a1220939979ac6f0822f1@wordpress.org> #56792: Docblock improvements for 6.2 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs --------------------------------------+--------------------- Comment (by audrasjb): In [changeset:"54664" 54664]: {{{ #!CommitTicketReference repository="" revision="54664" Docs: Align spelling with American English. This changeset replaces "cancelled" with "canceled" in various docblocks, per the [https://make.wordpress.org/core/handbook/best-practices/spelling/ Spelling Guidelines]. Props costdev. See #56811, #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 21:50:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 21:50:04 -0000 Subject: [wp-trac] [WordPress Trac] #56811: Improved spelling, align with American English In-Reply-To: <050.89fa782a95ec55a36a11451765249078@wordpress.org> References: <050.89fa782a95ec55a36a11451765249078@wordpress.org> Message-ID: <065.83e100cc4e6ce2230bf9d52a77331572@wordpress.org> #56811: Improved spelling, align with American English --------------------------------------+------------------------------------ Reporter: kebbet | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs, coding- | standards --------------------------------------+------------------------------------ Comment (by audrasjb): In [changeset:"54664" 54664]: {{{ #!CommitTicketReference repository="" revision="54664" Docs: Align spelling with American English. This changeset replaces "cancelled" with "canceled" in various docblocks, per the [https://make.wordpress.org/core/handbook/best-practices/spelling/ Spelling Guidelines]. Props costdev. See #56811, #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 22:11:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 22:11:03 -0000 Subject: [wp-trac] [WordPress Trac] #55942: Add a "type" field to the meta and options tables In-Reply-To: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> References: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> Message-ID: <065.421233eb065d78e899f4bccb53c9fb8c@wordpress.org> #55942: Add a "type" field to the meta and options tables -------------------------------------------------+------------------------- Reporter: azaozz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Comment (by barry.hughes): What do we think about the (optional) ability to specify the underlying type, on read as well as upon write? For instance, to maintain full backwards compatibility there are surely going to be cases where PHP serialization is still required. However, as a plugin author, if I can also specify (upon read) that I expect the value to be a simple boolean, or to have been written using JSON serialization, that would close off scenarios where third party code replaces an option with a value requiring PHP serialization (because what would be less desirable in such a case is if WP goes ahead and uses `unserialize()` when reading that data, contrary to my intentions). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 22:47:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 22:47:01 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.887f3c139126a11b58658a018b2e13d6@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Comment (by spacedmonkey): I spent some time testing the PR. It has a net posative result on performance. Tested on Single / Multisite, 2016, with and without object caching. Also tested with and without translation files present. Shaved around 200ms off the page load. Great work @swissspidy. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 21 22:48:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 21 Oct 2022 22:48:26 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.08a15ee9f6473a625a2bca1316261055@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note | -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-10-21 at 23.47.16.png" added. Results of testing patch in different environments. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 01:56:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 01:56:17 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency In-Reply-To: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> References: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> Message-ID: <072.141d197831afe9997fc5b6f3dd346b55@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ---------------------------+------------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: minor | Resolution: Keywords: | Focuses: coding-standards ---------------------------+------------------------------- Comment (by costdev): I don't have any strong feelings on the "right" decision on this, except that we achieve consistency. `wp` is more common, although that does show that people haven't been paying attention to the handbook - a problem in itself. I see two options for consistency: 1. Use `Wp` to be consistent with the handbook and other classes in the test suite. 2. Make `wp` consistent for test classes that start with those letters. Note: This would make these classes an exception, and therefore ''inconsistent'' with the handbook and other classes in the test suite. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 04:57:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 04:57:25 -0000 Subject: [wp-trac] [WordPress Trac] #56884: Typo in Dashboard Screen Options Message-ID: <055.5afd52a78b67655a950d29dfe208952c@wordpress.org> #56884: Typo in Dashboard Screen Options -------------------------------------+-------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Help/About | Version: 5.6 Severity: normal | Keywords: Focuses: administration, ui-copy | -------------------------------------+-------------------- The Screen Options text has included "by clickling on their headings" since r49179. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 04:58:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 04:58:45 -0000 Subject: [wp-trac] [WordPress Trac] #56884: Typo in Dashboard Screen Options In-Reply-To: <055.5afd52a78b67655a950d29dfe208952c@wordpress.org> References: <055.5afd52a78b67655a950d29dfe208952c@wordpress.org> Message-ID: <070.bb407839b97ec50ba45d807ff431afcc@wordpress.org> #56884: Typo in Dashboard Screen Options --------------------------+-------------------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Help/About | Version: 5.6 Severity: normal | Resolution: Keywords: | Focuses: administration, ui-copy --------------------------+-------------------------------------- Changes (by sabernhardt): * Attachment "56884.patch" added. fixes typo, changes from passive to active voice -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 04:59:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 04:59:04 -0000 Subject: [wp-trac] [WordPress Trac] #56884: Typo in Dashboard Screen Options In-Reply-To: <055.5afd52a78b67655a950d29dfe208952c@wordpress.org> References: <055.5afd52a78b67655a950d29dfe208952c@wordpress.org> Message-ID: <070.dd02ec566ff232aa30dc08cc4a0244b5@wordpress.org> #56884: Typo in Dashboard Screen Options --------------------------+-------------------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Help/About | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, ui-copy --------------------------+-------------------------------------- Changes (by sabernhardt): * keywords: => has-patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 06:33:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 06:33:51 -0000 Subject: [wp-trac] [WordPress Trac] #56221: Add download URL to plugins REST create (install) endpoint In-Reply-To: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> References: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> Message-ID: <071.f11e2af01a8fbbb5fc03d42598c4b270@wordpress.org> #56221: Add download URL to plugins REST create (install) endpoint -------------------------------------+------------------------------------- Reporter: brianhenryie | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.5 Severity: minor | Resolution: Keywords: needs-testing has-unit- | Focuses: administration, rest- tests has-patch dev-feedback | api -------------------------------------+------------------------------------- Changes (by brianhenryie): * keywords: has-patch has-unit-tests => needs-testing has-unit-tests has- patch dev-feedback * severity: normal => minor Comment: Tests are passing, so it's probably good to merge! But... 1. There seems to be no way to require one-of-two parameters. See [WP_REST_Request::has_valid_params()](https://github.com/WordPress /wordpress-develop/blob/f8daa24858d56ad1d2eb6a450ee4de543c638954/src/wp- includes/rest-api/class-wp-rest-request.php#L880) where `$arg['required']` is a `bool`. I looked at using `validate_callback` but it is invoked per parameter, i.e. if both are missing, it is never called, so it can't impose a "one of these must be present" requirement. The test case I rough-worked (not committed) did fail as it should, anyway. 2. I couldn't find a .tar plugin on .org to validate the non-zip scenario. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 06:39:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 06:39:48 -0000 Subject: [wp-trac] [WordPress Trac] #56221: Add download URL to plugins REST create (install) endpoint In-Reply-To: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> References: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> Message-ID: <071.16c6daaf9bfb2d18621ac39747d0f17a@wordpress.org> #56221: Add download URL to plugins REST create (install) endpoint -------------------------------------+------------------------------------- Reporter: brianhenryie | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.5 Severity: normal | Resolution: Keywords: needs-testing has-unit- | Focuses: administration, rest- tests has-patch dev-feedback | api -------------------------------------+------------------------------------- Changes (by brianhenryie): * severity: minor => normal -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 06:44:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 06:44:29 -0000 Subject: [wp-trac] [WordPress Trac] #56221: Add download URL to plugins REST create (install) endpoint In-Reply-To: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> References: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> Message-ID: <071.95e58982964e303857b6482fc74ea210@wordpress.org> #56221: Add download URL to plugins REST create (install) endpoint -------------------------------------+------------------------------------- Reporter: brianhenryie | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.5 Severity: normal | Resolution: Keywords: needs-testing has-unit- | Focuses: administration, rest- tests has-patch dev-feedback | api -------------------------------------+------------------------------------- Comment (by brianhenryie): Now I think more... in WP_REST_Plugins_Controller::create_item where I have `if ( isset( $request['url'] ) ) {` ... `else`, it should be an `elseif ( isset( $request['slug'] ) ) {` followed by something like `} else { $response = new WP_REST_Response( null, 400 );` I hadn't realised that was another avenue into the REST input validation. I'll have a think about it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 06:57:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 06:57:09 -0000 Subject: [wp-trac] [WordPress Trac] #56221: Add download URL to plugins REST create (install) endpoint In-Reply-To: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> References: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> Message-ID: <071.d2c1d9b6a672d323a3df0ae5027187fb@wordpress.org> #56221: Add download URL to plugins REST create (install) endpoint -------------------------------------+------------------------------------- Reporter: brianhenryie | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.5 Severity: normal | Resolution: Keywords: needs-testing has-unit- | Focuses: administration, rest- tests has-patch dev-feedback | api -------------------------------------+------------------------------------- Comment (by brianhenryie): Also, I created my own regex to validate a URL. https://www.phpliveregex.com/p/GAT Maybe there's a WordPress standard one that this should be closer to. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 06:58:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 06:58:29 -0000 Subject: [wp-trac] [WordPress Trac] #56884: Typo in Dashboard Screen Options In-Reply-To: <055.5afd52a78b67655a950d29dfe208952c@wordpress.org> References: <055.5afd52a78b67655a950d29dfe208952c@wordpress.org> Message-ID: <070.fa52bd381bbfeb18a44866ec20c986c0@wordpress.org> #56884: Typo in Dashboard Screen Options ------------------------------+-------------------------------------- Reporter: sabernhardt | Owner: audrasjb Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Help/About | Version: 5.6 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: administration, ui-copy ------------------------------+-------------------------------------- Changes (by audrasjb): * keywords: has-patch => has-patch commit * owner: (none) => audrasjb * status: new => accepted Comment: Good catch! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 07:04:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 07:04:08 -0000 Subject: [wp-trac] [WordPress Trac] #56884: Typo in Dashboard Screen Options In-Reply-To: <055.5afd52a78b67655a950d29dfe208952c@wordpress.org> References: <055.5afd52a78b67655a950d29dfe208952c@wordpress.org> Message-ID: <070.2074aa4b632d205172511cca3d5e7111@wordpress.org> #56884: Typo in Dashboard Screen Options ------------------------------+-------------------------------------- Reporter: sabernhardt | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: Help/About | Version: 5.6 Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: administration, ui-copy ------------------------------+-------------------------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"54665" 54665]: {{{ #!CommitTicketReference repository="" revision="54665" Help/About: Typo correction in Dashboard Screen Options. This changeset fixes a typo in meta boxes preferences. It also changes the related sentence from passive to active voice. Follow-up to [49179]. Props sabernhardt. Fixes #56884. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 07:12:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 07:12:27 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.14a4d353c63e7e03235a6fc16be9dbad@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: normal | Resolution: Keywords: needs-testing has-testing-info dev- | Focuses: feedback has-patch has-unit-tests | -------------------------------------------------+------------------------- Comment (by audrasjb): Coding standards issues were fixed in the PR 👍 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 07:17:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 07:17:35 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.41eab53a32000f30ca5dc757973f9926@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-feedback | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch needs-testing has-testing-info has-unit-tests => has-patch has-testing-info has-unit-tests dev-feedback Comment: ''[double committer signoff needed]'' I tested the patch and it works fine on my side (it adds `object-fit: cover` style attribute). Waiting for another committer review before `commit` and backport to branch 6.1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 07:33:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 07:33:04 -0000 Subject: [wp-trac] [WordPress Trac] #28407: You are unable to override the attachment name in wp_mail() when adding attachments In-Reply-To: <053.3b7b90f12b6fe2061744ad3683c799c1@wordpress.org> References: <053.3b7b90f12b6fe2061744ad3683c799c1@wordpress.org> Message-ID: <068.98b47a0c8a25a8a942876a141bff5539@wordpress.org> #28407: You are unable to override the attachment name in wp_mail() when adding attachments -------------------------------------------------+------------------------- Reporter: syntaxart | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Mail | Version: 3.9.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests 2nd- | Focuses: opinion needs-testing dev-feedback | -------------------------------------------------+------------------------- Comment (by jodamo5): Could this ticket get kicked off again? I suggest just going with the original simple suggestion of allowing attachments to be renamed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 10:05:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 10:05:54 -0000 Subject: [wp-trac] [WordPress Trac] #56885: `wp-signup.php` throws deprecated notices in Twenty Twenty-Two and Twenty Twenty-Three Message-ID: <049.8e4fbdab6d19f4ced5908455184be403@wordpress.org> #56885: `wp-signup.php` throws deprecated notices in Twenty Twenty-Two and Twenty Twenty-Three --------------------------+----------------------------- Reporter: imath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: trunk Severity: normal | Keywords: needs-patch Focuses: | --------------------------+----------------------------- I believe `wp-includes/theme-compat/header.php` && `/wp-includes/theme- compat/footer.php` should be improved to perform a check for themes supporting block templates to avoid display these notices and perform a block templates look up instead. It seems weird to get deprecated notices with latest WordPress themes... Screenshots below shows the deprecated notices in both default WordPress block templates themes. ==== 2023 ==== [[Image(https://cldup.com/EKd7JSI_rq.png)]] ==== 2022 ==== [[Image(https://cldup.com/Izu_lA6IXI.png)]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 10:51:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 10:51:08 -0000 Subject: [wp-trac] [WordPress Trac] #56885: `wp-signup.php` throws deprecated notices in Twenty Twenty-Two and Twenty Twenty-Three In-Reply-To: <049.8e4fbdab6d19f4ced5908455184be403@wordpress.org> References: <049.8e4fbdab6d19f4ced5908455184be403@wordpress.org> Message-ID: <064.05b021817cb1ae310fdb568884ec5b3d@wordpress.org> #56885: `wp-signup.php` throws deprecated notices in Twenty Twenty-Two and Twenty Twenty-Three -------------------------------------------+------------------------------ Reporter: imath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: trunk Severity: normal | Resolution: Keywords: needs-patch reporter-feedback | Focuses: -------------------------------------------+------------------------------ Changes (by poena): * keywords: needs-patch => needs-patch reporter-feedback Comment: Hi, can you add any more details on how to reproduce this? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 11:05:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 11:05:40 -0000 Subject: [wp-trac] [WordPress Trac] #56886: Although users can set a new site's visibility for search engines, the super admin can't :) Message-ID: <049.3e0f7b20f49ad177fec9d19e39fe158a@wordpress.org> #56886: Although users can set a new site's visibility for search engines, the super admin can't :) --------------------------------+----------------------------- Reporter: imath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Networks and Sites | Version: trunk Severity: normal | Keywords: has-patch Focuses: multisite | --------------------------------+----------------------------- When a user wants to add a new site on Multisite configs, they can use the site privacy radio buttons, see screenshot below: ==== /wp-signup.php ==== [[Image(https://cldup.com/0bMdIrVLRE.png)]] But when a super admin wants to add a new site, they have no way to choose this setting during site creation, they need to create a "public" site, then go into the Reading settings to eventually switch to hidden to search engines. In this particular case, a super admin has less power than a regular user :) ==== /wp-admin/network/site-new.php ==== [[Image(https://cldup.com/Tg7E2F-bwR.png)]] The attached patch is adding these missing site privacy radio buttons to let a super admin decide whether a new site should be "public" or not. ==== patched /wp-admin/network/site-new.php ==== [[Image(https://cldup.com/hiFEfNw3_V.png)]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 11:06:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 11:06:02 -0000 Subject: [wp-trac] [WordPress Trac] #56886: Although users can set a new site's visibility for search engines, the super admin can't :) In-Reply-To: <049.3e0f7b20f49ad177fec9d19e39fe158a@wordpress.org> References: <049.3e0f7b20f49ad177fec9d19e39fe158a@wordpress.org> Message-ID: <064.2419d2b387ffe38b770b9f791fa96a52@wordpress.org> #56886: Although users can set a new site's visibility for search engines, the super admin can't :) --------------------------------+------------------------------ Reporter: imath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Networks and Sites | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: multisite --------------------------------+------------------------------ Changes (by imath): * Attachment "56886.patch" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 11:15:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 11:15:04 -0000 Subject: [wp-trac] [WordPress Trac] #56885: `wp-signup.php` throws deprecated notices in Twenty Twenty-Two and Twenty Twenty-Three In-Reply-To: <049.8e4fbdab6d19f4ced5908455184be403@wordpress.org> References: <049.8e4fbdab6d19f4ced5908455184be403@wordpress.org> Message-ID: <064.3f7b97281d44803ab865eb08bf120eef@wordpress.org> #56885: `wp-signup.php` throws deprecated notices in Twenty Twenty-Two and Twenty Twenty-Three -------------------------------------------+------------------------------ Reporter: imath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: trunk Severity: normal | Resolution: Keywords: needs-patch reporter-feedback | Focuses: -------------------------------------------+------------------------------ Comment (by imath): Hi @poena :) Sure. - Log in as a Super Admin, Activate Twenty Twenty-Three or Twenty Twenty- Two, then go to Network settings - Make sure the "Allow new registrations" is set to "Logged in users may register new sites" - Log out and log in as a regular user, click on the WP Dashboard "My Sites" sub nav item - Click on the "Add new" button at the right of the `http://wordpress.network/imath/wp-admin/my-sites.php` page title. - You reach the `/wp-signup.php` page and you should see the theme's header & footer are not loaded and deprecated notices over and below the new site form. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 11:15:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 11:15:51 -0000 Subject: [wp-trac] [WordPress Trac] #56887: wp_exif_date2ts throws notice on slash formatted date Message-ID: <057.b926aa4a5dda8fe2bdae81ce5f8636d2@wordpress.org> #56887: wp_exif_date2ts throws notice on slash formatted date ---------------------------+----------------------------- Reporter: domainsupport | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Date/Time | Version: 5.2.3 Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- When an image has an exif date in the format ... > YYYY/MM/DD HH:MM:SS ... rather than ... > YYYY:MM:DD HH:MM:SS ... which is happening more and more I have noticed, the following PHP notices are thrown ... > PHP Notice: Undefined offset: 1 in /var/www/tourist.org.uk/html/wp- admin/includes/image.php on line 710 > PHP Notice: Undefined offset: 2 in /var/www/tourist.org.uk/html/wp- admin/includes/image.php on line 710 I think there are a lot of assumptions being made in wp_exif_date2ts() and I believe that a preg_match check like ... {{{#!php \d){4}[:|\/](?>\d){2}[:|\/](?>\d){2} (?>\d){2}:(?>\d){2}:(?>\d){2}$/', $str)) { // Process and return exif date } else { return false; } }}} ... should be done instead. This is related to ticket [ticket:48204] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 12:24:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 12:24:17 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.b14865995eb88438d8702f8719965a4a@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54666" 54666]: {{{ #!CommitTicketReference repository="" revision="54666" Tests: Move `padding-*` test data in KSES tests into its own test case. This creates separate test cases for `safecss_filter_attr()` with `margin-*` and `padding-*` logical properties for additional clarity. Follow-up to [54102]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 12:25:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 12:25:52 -0000 Subject: [wp-trac] [WordPress Trac] #56886: Although users can set a new site's visibility for search engines, the super admin can't :) In-Reply-To: <049.3e0f7b20f49ad177fec9d19e39fe158a@wordpress.org> References: <049.3e0f7b20f49ad177fec9d19e39fe158a@wordpress.org> Message-ID: <064.fffd4d3941efd0a194629dc984f18df1@wordpress.org> #56886: Although users can set a new site's visibility for search engines, the super admin can't :) --------------------------------+------------------------ Reporter: imath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Networks and Sites | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: multisite --------------------------------+------------------------ Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 12:56:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 12:56:13 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.0964dbc6ed370c9949a3d5ac611d3073@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54667" 54667]: {{{ #!CommitTicketReference repository="" revision="54667" Tests: Add a test case for `safecss_filter_attr()` with `object-position` property. Follow-up to [50634]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 13:01:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 13:01:47 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.24ade9ed33ebcda5b9e6427bd1fbc3a0@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-feedback | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * Attachment "56855.2.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 13:06:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 13:06:57 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.6dcd6df78832053e9792d4e76ef4226d@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-patch has-testing-info has-unit-tests dev-feedback => has- patch has-testing-info has-unit-tests dev-reviewed Comment: Looks good to commit and backport. [attachment:"56855.2.diff"] is a refresh after [54100], [54102], [54117], and [54667]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 13:15:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 13:15:19 -0000 Subject: [wp-trac] [WordPress Trac] #56888: Thumbnails images stretched after 6.0.3 update Message-ID: <056.e029e59d25a3215cc9a352d88b42195d@wordpress.org> #56888: Thumbnails images stretched after 6.0.3 update -----------------------------+----------------------------- Reporter: ivanjeronimo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Post Thumbnails | Version: 6.0.3 Severity: minor | Keywords: Focuses: | -----------------------------+----------------------------- I'm using a thumbnail loop block to show blog posts on the homepage of my blog. After the 6.0.3 update, the images got stretched (disproportionately scaled to fit the thumbnail dimensions instead of cropping). This only happens in publication mode. Images are normal when editing. Homepage at: https://ivanjeronimo.com.br/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 14:48:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 14:48:20 -0000 Subject: [wp-trac] [WordPress Trac] #56888: Thumbnails images stretched after 6.0.3 update In-Reply-To: <056.e029e59d25a3215cc9a352d88b42195d@wordpress.org> References: <056.e029e59d25a3215cc9a352d88b42195d@wordpress.org> Message-ID: <071.fd45ef9fd385955c586fe92c2f1ff4cd@wordpress.org> #56888: Thumbnails images stretched after 6.0.3 update -----------------------------+------------------------------ Reporter: ivanjeronimo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Post Thumbnails | Version: 6.0.3 Severity: minor | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Comment (by joyously): I think this problem is already being tracked in #56855. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 15:10:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 15:10:28 -0000 Subject: [wp-trac] [WordPress Trac] #56888: Thumbnails images stretched after 6.0.3 update In-Reply-To: <056.e029e59d25a3215cc9a352d88b42195d@wordpress.org> References: <056.e029e59d25a3215cc9a352d88b42195d@wordpress.org> Message-ID: <071.c7bec161ab9ab57c41c813631b059d55@wordpress.org> #56888: Thumbnails images stretched after 6.0.3 update -----------------------------+------------------------------ Reporter: ivanjeronimo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Post Thumbnails | Version: 6.0.3 Severity: minor | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------------ Changes (by ivanjeronimo): * status: new => closed * resolution: => duplicate Comment: Duplicate of #56855. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 15:40:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 15:40:10 -0000 Subject: [wp-trac] [WordPress Trac] #56889: Hand-Picked Products Block Encountered A Problem and Cannot Be Previewed Message-ID: <056.2197ebb81e650317f891409d292bd33c@wordpress.org> #56889: Hand-Picked Products Block Encountered A Problem and Cannot Be Previewed -----------------------------+----------------------------- Reporter: autumnamoore | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Quick/Bulk Edit | Version: 6.0.3 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- Hi I have 5 different hand-picked product blocks. 4 out of the 5 are fine. The largest one is now unable to edit or preview (although it is still visible on the front end). How do I recover this block? Is there a maximum amount of products (ei: 100) and if I went over that maximum, how do I recover the block to remove products to get it back under the 100 max threshold? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 17:53:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 17:53:28 -0000 Subject: [wp-trac] [WordPress Trac] #56830: jQuery Migrate deprecation in wpdialog In-Reply-To: <052.2061878c33cf1c15a5b4c3114b65bc0c@wordpress.org> References: <052.2061878c33cf1c15a5b4c3114b65bc0c@wordpress.org> Message-ID: <067.89f29a06564a973bd85dcff7474b8c2d@wordpress.org> #56830: jQuery Migrate deprecation in wpdialog ----------------------------------------+------------------------- Reporter: TobiasBg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Administration | Version: Severity: normal | Resolution: Keywords: needs-patch good-first-bug | Focuses: javascript ----------------------------------------+------------------------- Changes (by elifvish): * Attachment "56830.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 17:55:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 17:55:47 -0000 Subject: [wp-trac] [WordPress Trac] #56830: jQuery Migrate deprecation in wpdialog In-Reply-To: <052.2061878c33cf1c15a5b4c3114b65bc0c@wordpress.org> References: <052.2061878c33cf1c15a5b4c3114b65bc0c@wordpress.org> Message-ID: <067.b442fb3d154160493bbe644b8d5e35c3@wordpress.org> #56830: jQuery Migrate deprecation in wpdialog --------------------------------------+------------------------- Reporter: TobiasBg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Administration | Version: Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: javascript --------------------------------------+------------------------- Changes (by elifvish): * keywords: needs-patch good-first-bug => good-first-bug has-patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 18:24:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 18:24:49 -0000 Subject: [wp-trac] [WordPress Trac] #56221: Add download URL to plugins REST create (install) endpoint In-Reply-To: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> References: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> Message-ID: <071.308d1d98eba0196936889aca3aa5c173@wordpress.org> #56221: Add download URL to plugins REST create (install) endpoint -------------------------------------+------------------------------------- Reporter: brianhenryie | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.5 Severity: normal | Resolution: Keywords: needs-testing has-unit- | Focuses: administration, rest- tests has-patch dev-feedback | api -------------------------------------+------------------------------------- Comment (by TimothyBlynJacobs): Replying to [comment:4 brianhenryie]: > I looked at using `validate_callback` but it is invoked per parameter, i.e. if both are missing, it is never called, so it can't impose a "one of these must be present" requirement. You can set a `validate_callback` at the route-level now alongside `callback` and `args`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 18:28:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 18:28:42 -0000 Subject: [wp-trac] [WordPress Trac] #56890: Post Featured Image always using Fill scaling. Message-ID: <059.fa8b3d553cedd8effcaa8b80a5611c2f@wordpress.org> #56890: Post Featured Image always using Fill scaling. -----------------------------+----------------------------- Reporter: seriouslysenpai | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- Since being updated to 6.0.3, my Post Featured Image block is not using the correct Scale option. It is meant to be using Cover but it is displaying as Fill. Setting it to Cover or Contain makes no difference, it will always use Fill. The bug does **not** appear while editing the site with Gutenberg editor but does when viewing a site. It is not from CSS or plugins, I have disabled all of that. It also happens on all FSE themes that I have tried, not just Twenty-Twenty-Two. Firefox and Chrome on Windows Desktop tested. I installed two new fresh instances of WordPress for further trial. One 6.0.3 and one 5.9.5, which was the latest old version provided for me by my host. The 5.9.5 does not have this issue and given I had not noticed this until today and that my site was on 6.0.2 until a few days ago, I'm going to say this is something recent. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 18:55:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 18:55:30 -0000 Subject: [wp-trac] [WordPress Trac] #56890: Post Featured Image always using Fill scaling. In-Reply-To: <059.fa8b3d553cedd8effcaa8b80a5611c2f@wordpress.org> References: <059.fa8b3d553cedd8effcaa8b80a5611c2f@wordpress.org> Message-ID: <074.de3d91c0e362e825c0fdb7c533766002@wordpress.org> #56890: Post Featured Image always using Fill scaling. -----------------------------+------------------------------ Reporter: seriouslysenpai | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------------ Changes (by seriouslysenpai): * status: new => closed * resolution: => duplicate Comment: Duplicate of #56855. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 20:31:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 20:31:18 -0000 Subject: [wp-trac] [WordPress Trac] #56888: Thumbnails images stretched after 6.0.3 update In-Reply-To: <056.e029e59d25a3215cc9a352d88b42195d@wordpress.org> References: <056.e029e59d25a3215cc9a352d88b42195d@wordpress.org> Message-ID: <071.16c11a0517e558e475344265d085ad04@wordpress.org> #56888: Thumbnails images stretched after 6.0.3 update -----------------------------+------------------------ Reporter: ivanjeronimo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Post Thumbnails | Version: 6.0.3 Severity: minor | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Changes (by SergeyBiryukov): * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 20:31:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 20:31:51 -0000 Subject: [wp-trac] [WordPress Trac] #56890: Post Featured Image always using Fill scaling. In-Reply-To: <059.fa8b3d553cedd8effcaa8b80a5611c2f@wordpress.org> References: <059.fa8b3d553cedd8effcaa8b80a5611c2f@wordpress.org> Message-ID: <074.c94c49ebf9c8c745df7abc78c279d577@wordpress.org> #56890: Post Featured Image always using Fill scaling. -----------------------------+------------------------ Reporter: seriouslysenpai | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Media | Version: 6.0.3 Severity: normal | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Changes (by SergeyBiryukov): * component: General => Media * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 21:51:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 21:51:38 -0000 Subject: [wp-trac] [WordPress Trac] #56447: Enable shortlinks for custom post types for wordpress.org In-Reply-To: <054.345e0053b8cfba57d8bd406c18246b91@wordpress.org> References: <054.345e0053b8cfba57d8bd406c18246b91@wordpress.org> Message-ID: <069.0a73064ea63dd09d7edd84006f1dc503@wordpress.org> #56447: Enable shortlinks for custom post types for wordpress.org --------------------------------+-------------------------------- Reporter: dansoschin | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: WordPress.org Site | Version: Severity: minor | Resolution: reported-upstream Keywords: | Focuses: --------------------------------+-------------------------------- Changes (by sabernhardt): * keywords: reporter-feedback => * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: Thanks for moving the report! https://meta.trac.wordpress.org/ticket/6464 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 22:08:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 22:08:48 -0000 Subject: [wp-trac] [WordPress Trac] #56885: `wp-signup.php` throws deprecated notices in Twenty Twenty-Two and Twenty Twenty-Three In-Reply-To: <049.8e4fbdab6d19f4ced5908455184be403@wordpress.org> References: <049.8e4fbdab6d19f4ced5908455184be403@wordpress.org> Message-ID: <064.d16ec5ba69d197a36c6e2133bd38b4d0@wordpress.org> #56885: `wp-signup.php` throws deprecated notices in Twenty Twenty-Two and Twenty Twenty-Three --------------------------+------------------------ Reporter: imath | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Themes | Version: trunk Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Changes (by SergeyBiryukov): * keywords: needs-patch reporter-feedback => * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Hi there, thanks for the ticket. We're already tracking this issue in #55023. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 22:38:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 22:38:33 -0000 Subject: [wp-trac] [WordPress Trac] #56875: Need help to fix a translation bug! In-Reply-To: <052.6e148b05768e5e4dc00024bd5ca25a3b@wordpress.org> References: <052.6e148b05768e5e4dc00024bd5ca25a3b@wordpress.org> Message-ID: <067.6f34d52291995183bab6d5b445716221@wordpress.org> #56875: Need help to fix a translation bug! --------------------------+---------------------- Reporter: tajul707 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: I18N | Version: 6.0.3 Severity: critical | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by sabernhardt): * status: new => closed * focuses: javascript => * component: Text Changes => I18N * milestone: Awaiting Review => * keywords: needs-design-feedback => * resolution: => invalid Comment: Hi and welcome to WordPress Core Trac! The extra code appears in your French and German pages, too. A search on `#!trpst#/trp-gettext#!trpen#` gave several results in the TranslatePress plugin forum: https://wordpress.org/search/%23!trpst%23%2Ftrp-gettext%23!trpen%23/ If those posts do not help, you could open your own topic in the support forums. - [https://wordpress.org/plugins/translatepress-multilingual/ TranslatePress support] - [https://wordpress.org/support/forum/how-to-and-troubleshooting/ Fixing WordPress Forum (English)] - [https://nl.wordpress.org/support/ WordPress ondersteuning] Since this is not a core bug, I'll close the ticket as `invalid`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 22 23:36:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 22 Oct 2022 23:36:54 -0000 Subject: [wp-trac] [WordPress Trac] #56551: Don't internationalize (translate) messages in `_doing_it_wrong()` In-Reply-To: <049.2459173578c20303f9829217936c1f9b@wordpress.org> References: <049.2459173578c20303f9829217936c1f9b@wordpress.org> Message-ID: <064.730200d6ccd72e6b3a9b92f811e2a29f@wordpress.org> #56551: Don't internationalize (translate) messages in `_doing_it_wrong()` -------------------------+------------------------------ Reporter: helen | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: I18N | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Changes (by sabernhardt): * component: Text Changes => I18N -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 02:13:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 02:13:31 -0000 Subject: [wp-trac] [WordPress Trac] #56891: add_theme_support 'appearance-tools' or not available Message-ID: <052.c0cbb7cfc2eb078bfa627dee458abad3@wordpress.org> #56891: add_theme_support 'appearance-tools' or not available -----------------------------+----------------------------- Reporter: nendeb55 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- Gutenberg 14.0 new feature Appearance tools is not reflected in the core, has this been dropped? [https://make.wordpress.org/core/2022/09/01/whats-new-in- gutenberg-14-0-31-august/] [https://developer.wordpress.org/block-editor/how-to-guides/themes/theme- support/#appearance-tools] [https://github.com/WordPress/gutenberg/blob/trunk/lib/experimental/class- wp-theme-json-resolver-gutenberg.php#L104-L107] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 06:59:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 06:59:06 -0000 Subject: [wp-trac] [WordPress Trac] #56891: add_theme_support 'appearance-tools' or not available In-Reply-To: <052.c0cbb7cfc2eb078bfa627dee458abad3@wordpress.org> References: <052.c0cbb7cfc2eb078bfa627dee458abad3@wordpress.org> Message-ID: <067.a7ed33a129f6ec04423fd9dbb9af3717@wordpress.org> #56891: add_theme_support 'appearance-tools' or not available -----------------------------+------------------------------ Reporter: nendeb55 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Comment (by wildworks): It has not been dropped and appears to have been moved to 6.2. https://core.trac.wordpress.org/ticket/56487 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 09:51:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 09:51:18 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.b6d5851a57776cf5e0741c0746ea5a0b@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by jrf): I've opened PR [https://github.com/WordPress/wordpress-develop/pull/3516 GH#3516] with a follow-up on [https://github.com/WordPress/wordpress- develop/pull/3368 GH#3368] which was merged to WP 6.1. Not sure if this PR should still go into 6.1 or 6.2, but 6.2 would be absolutely fine IMO. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 10:14:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 10:14:01 -0000 Subject: [wp-trac] [WordPress Trac] #56891: add_theme_support 'appearance-tools' or not available In-Reply-To: <052.c0cbb7cfc2eb078bfa627dee458abad3@wordpress.org> References: <052.c0cbb7cfc2eb078bfa627dee458abad3@wordpress.org> Message-ID: <067.9760f9408a5818f7b91e20a515d89ecc@wordpress.org> #56891: add_theme_support 'appearance-tools' or not available -----------------------------+------------------------------ Reporter: nendeb55 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Comment (by nendeb55): Understood. Thank you very much. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 10:15:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 10:15:35 -0000 Subject: [wp-trac] [WordPress Trac] #56892: wp_xx_categories() doesn't pad counts correctly when a sub-category exists Message-ID: <053.c8258214c514e411559241e6cf6095e1@wordpress.org> #56892: wp_xx_categories() doesn't pad counts correctly when a sub-category exists --------------------------+----------------------------- Reporter: wildworks | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I fond this issue while researching gutenberg [#37319](https://github.com/WordPress/gutenberg/issues/37319). If I set the `hierarchical` and `show_count` of `wp_list_categories` or `wp_dropdown_categories` to `true`, the counts for some categories aren't displayed correctly when there are posts that have grandchild categories. Example: ---- {{{ wp_list_categories( array( 'show_count' => true, 'hierarchical' => true ) ); }}} * Parent (4) * Child 1 (3) * Grandchild 1 (1) * Child 2 (1) ---- {{{ wp_list_categories( array( 'show_count' => true, 'hierarchical' => false ) ); }}} * Child 1 (2) * Child 2 (1) * Grandchild 1 (1) ---- "Child 1" category counts are different, but the second data (`hierarchical` is `false`) is correct in my test data. For some reason, I think the number of grandchild categories is counted as well. This problem is the same when I output with `wp_dropdown_categories`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 10:22:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 10:22:36 -0000 Subject: [wp-trac] [WordPress Trac] #56893: Unnecessary line breaks added by the code editor that breaks JavaScript Message-ID: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> #56893: Unnecessary line breaks added by the code editor that breaks JavaScript --------------------------+----------------------------- Reporter: sweetheatmn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: critical | Keywords: Focuses: | --------------------------+----------------------------- adding a simple JavaScript to the code editor and hitting the publish button just adds unnecessary {{{
}}} inside the Javascript which is a sufficient reason to break any JavaScript How to reproduce, simply add a new post, paste/write any JavaScript and click the publish button to see the black magic [[Image(https://i.imgur.com/fyrAwtI.png)]] Regards, Atef -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 11:17:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 11:17:12 -0000 Subject: [wp-trac] [WordPress Trac] #56893: Unnecessary line breaks added by the code editor that breaks JavaScript In-Reply-To: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> References: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> Message-ID: <070.ddade8e5627a945c8df85a133995928e@wordpress.org> #56893: Unnecessary line breaks added by the code editor that breaks JavaScript --------------------------+------------------------------ Reporter: sweetheatmn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by sweetheatmn): + if we add JS to the Classic Editor to bypass this issue, it still filter the content to add unnecessary {{{

}}} and {{{
}}} tags on the front-end -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 12:09:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 12:09:11 -0000 Subject: [wp-trac] [WordPress Trac] #56891: add_theme_support 'appearance-tools' or not available In-Reply-To: <052.c0cbb7cfc2eb078bfa627dee458abad3@wordpress.org> References: <052.c0cbb7cfc2eb078bfa627dee458abad3@wordpress.org> Message-ID: <067.9ba7b8d1bb1e9458dc53d9578c63a231@wordpress.org> #56891: add_theme_support 'appearance-tools' or not available -----------------------------+------------------------ Reporter: nendeb55 | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: Themes | Version: trunk Severity: normal | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * component: General => Themes * milestone: Awaiting Review => Comment: Duplicate of #56487. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 12:12:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 12:12:16 -0000 Subject: [wp-trac] [WordPress Trac] #56893: Unnecessary line breaks added by the code editor that breaks JavaScript In-Reply-To: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> References: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> Message-ID: <070.923712d0b115fe4c2ca7b71c7ab03f6e@wordpress.org> #56893: Unnecessary line breaks added by the code editor that breaks JavaScript --------------------------+------------------------------ Reporter: sweetheatmn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by SergeyBiryukov): * component: General => Editor -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 12:12:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 12:12:54 -0000 Subject: [wp-trac] [WordPress Trac] #56892: wp_xx_categories() doesn't pad counts correctly when a sub-category exists In-Reply-To: <053.c8258214c514e411559241e6cf6095e1@wordpress.org> References: <053.c8258214c514e411559241e6cf6095e1@wordpress.org> Message-ID: <068.3d9b35b12db3c6c04050bbd1c807f648@wordpress.org> #56892: wp_xx_categories() doesn't pad counts correctly when a sub-category exists --------------------------+------------------------------ Reporter: wildworks | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by SergeyBiryukov): * component: General => Taxonomy -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 12:37:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 12:37:13 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.f0caac22f9b213a401ab02bf46256522@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54668" 54668]: {{{ #!CommitTicketReference repository="" revision="54668" Tests: Make the message for skipping some tests with an external object cache more consistent. Follow-up to [33702], [34767], [49857], [53821]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 12:47:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 12:47:03 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.a2668a8dcf686f5f855229dc4f06cd4f@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by gregbenz): Here's an example page with several HDR AVIF images. It's a WordPress page, but I had to manually upload all files to my server outside the WordPress media library and link each image as a URL external to WordPress. It's worth doing for a big tutorial page like this, but is definitely a deterrent to using AVIF broadly on a WordPress site because it's much more time consuming than a simple upload to the media library. [https://gregbenzphotography.com/hdr] Note that the images here are HDR, which means that none of the formats in the WordPress media library are suitable (JPG, PNG, etc). And the file savings here are substantial. I've seen anywhere from 30-80% file size reductions going from JPG to AVIF. Having native support for AVIF (including keeping the 10-12bit depth and CICP data to render properly as HDR for any derivative media) would be incredibly useful. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 12:57:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 12:57:25 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.5e74e2ade0e3547ee495b5a52a6c8a91@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by gregbenz): @adamsilverstein Any major concerns with PHP v8.1 (vs something probably more common like v7.4)? Is there some significant component, plugin, etc that likely isn't supported? Do you believe that would be a difficult upgrade at this time for many WordPress sites (at least for those motivated enough to adopt AVIF)? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 13:00:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 13:00:58 -0000 Subject: [wp-trac] [WordPress Trac] #56742: Cannot upload JXL images to media library In-Reply-To: <052.71ff9086a24e300cb157376b2a1d1572@wordpress.org> References: <052.71ff9086a24e300cb157376b2a1d1572@wordpress.org> Message-ID: <067.a62a518c1686e36b00ec0c57517bfa36@wordpress.org> #56742: Cannot upload JXL images to media library -----------------------------+------------------------ Reporter: gregbenz | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: Media | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Comment (by gregbenz): Adobe Camera RAW now natively supports export of JXL images. See the 9:20 point of this video: https://gregbenzphotography.com /photography-tips/acr-15-adds-high-dynamic-range-output/ This is currently set as a "technology preview", so you'll need to enable HDRO on MacOS as shown in the first minute of the video to have access to JXL export if you want to test yourself. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 13:49:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 13:49:26 -0000 Subject: [wp-trac] [WordPress Trac] #56850: PHP 8.1 deprecation notices from wp_signon() with default parameters In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.12af70797034d390a6cd237a706c0e0c@wordpress.org> #56850: PHP 8.1 deprecation notices from wp_signon() with default parameters --------------------------------------------+--------------------- Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch php81 has-unit-tests | Focuses: --------------------------------------------+--------------------- Changes (by ocean90): * version: 6.1 => Comment: Another fix is in https://github.com/WordPress/wordpress- develop/pull/2804. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 14:08:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 14:08:34 -0000 Subject: [wp-trac] [WordPress Trac] #21537: Email address sanitisation mangles valid email addresses In-Reply-To: <049.8266ddc7ee646dfb3cacbfd1ad4f8180@wordpress.org> References: <049.8266ddc7ee646dfb3cacbfd1ad4f8180@wordpress.org> Message-ID: <064.c5c558dc1b3490904c6f7e1bdcea21e9@wordpress.org> #21537: Email address sanitisation mangles valid email addresses --------------------------------------------+--------------------- Reporter: westi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Component: Formatting | Version: 3.4.1 Severity: normal | Resolution: Keywords: 2nd-opinion has-patch is-email | Focuses: --------------------------------------------+--------------------- Comment (by joysons): Hi Please I send this screenshot here https://opensitemarkella.cf/wp- content/uploads/2022/10/Email-address-sanitisation-mangles-valid.jpg .How this problem resolve? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 14:35:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 14:35:47 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.8b1d3b0f35cd333cf13bf56b812707f9@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by adamsilverstein): > https://gregbenzphotography.com/hdr Thanks for sharing the link - those images are incredible and this is such a good demonstration of the power of AVIF. Plus the file size is smaller, amazing! Quick Safari update - support has now landed in WebKit which I believe means Safari will soon support AVIF even on older iOS and MacOS versions that lack OS support. See https://github.com/WebKit/WebKit/pull/5669. The lack of Edge support unfortunately probably still remains a blocker since we generally only adopt features that all the major browsers support (unless the lack of the feature doesn't negatively impact users). Anything we can do to encourage Edge to add support would be helpful. > Any major concerns with PHP v8.1 Primarily that WordPress isn't fully compatible yet as far as I know (see https://make.wordpress.org/core/2022/01/10/wordpress-5-9-and-php-8-0-8-1/ & [https://core.trac.wordpress.org/query?status=accepted&status=assigned&status=new&status=reopened&status=reviewing&keywords=~php8&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=milestone&order=priority open tickets]). That said, I believe it is possible to use AVIF on older PHP with a more recent Imagick library. Server support is less critical here and it would be fine to only support AVIF when the underlying system (server) supports it - we do the same already for WebP. We are also exploring browser based encoding as a possible path forward, since we can now run the full liibavif via WASM. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 14:48:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 14:48:02 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.c7018b6581082797d79384e52e94dd18@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by jb510): The fundamental flaw with the WebP proposal was wanting to convert all existing images/thumbnails by default. Here the approach should simply be supporting AVIF uploads and generating AVIF thumbnails of those uploads. The only big hurdle is AVIF that PHP < 8.1 doesn’t support it and WP is still handcuffed to supporting ancient EOL versions of PHP. The philosophical decision that needs to be made is, is it acceptable to add AVIF support conditionally on installs running PHP 8.1+ or do we need to try to support AVIF on old versions, or worse wait until 8.1 is the minimum support version for WP. Per above, I vote for progressive enhancement now, where AVIF support is in core but only available when running PHP 8.1+ and those GD/imageavif() functions are available. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 14:53:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 14:53:56 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.07a57a3a35d2712b9e236b723d107e1f@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by gregbenz): @adamsilverstein I have not tested MacOS 13, but the AVIF support in iOS16 unfortunately does not include HDR AVIF images. Viewing my site on an iPhone / iPad will show the HDR content clipped. Having HDR AVIF in WebKit ultimately is critical, because it is required for iOS Chrome, etc. Given Apple has shipped hundreds of millions of HDR screens (they are way ahead of the game), I would assume they could flip the switch for HDR image support at any time. Once they do, most Apple devices bought in the last 4 years would support it and I expect that could be something of an inflection point for this to start really taking off. But, WebKit support for standard AVIF allows significant reduction in file size, which is huge and beneficial for any site. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 14:55:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 14:55:28 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.2727e1ca1a404df025beaeb1b814f5dd@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by gregbenz): Replying to [comment:16 jb510]: > Per above, I vote for progressive enhancement now, where AVIF support is in core but only available when running PHP 8.1+ and those GD/imageavif() functions are available. Agreed, just enable support for those who can migrate to PHP 8.1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 15:37:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 15:37:30 -0000 Subject: [wp-trac] [WordPress Trac] #30130: Normalize characters with combining marks to precomposed characters In-Reply-To: <054.fc465983c6835d0b96d753e633ae0d5d@wordpress.org> References: <054.fc465983c6835d0b96d753e633ae0d5d@wordpress.org> Message-ID: <069.f6e2e732b09cc97d36656f9563584ce9@wordpress.org> #30130: Normalize characters with combining marks to precomposed characters -------------------------+----------------------------- Reporter: zodiac1978 | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.1 Component: Formatting | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: -------------------------+----------------------------- Comment (by datverse): Hi @gitlost , Thank for your plugin helpful in many years (UNFC Nörmalize: https://wordpress.org/plugins/unfc-normalize/). Can you check the new WordPress 6.1 update and your plugin? Does we need your plugin anymore? Thanks -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 19:33:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 19:33:08 -0000 Subject: [wp-trac] [WordPress Trac] #56850: PHP 8.1 deprecation notices from wp_signon() with default parameters In-Reply-To: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> References: <053.882c5fd8519b68482448d1f84e38e767@wordpress.org> Message-ID: <068.c07e260cadec16a7c51f4c5d75997cf4@wordpress.org> #56850: PHP 8.1 deprecation notices from wp_signon() with default parameters --------------------------------------------+----------------------------- Reporter: lenasterg | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.2 Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch php81 has-unit-tests | Focuses: --------------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => accepted -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 20:10:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 20:10:41 -0000 Subject: [wp-trac] [WordPress Trac] #56221: Add download URL to plugins REST create (install) endpoint In-Reply-To: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> References: <056.68205e9fd4c4c598381602d005813ae4@wordpress.org> Message-ID: <071.aeb8c83412413b11be3ea94e9a5b8c81@wordpress.org> #56221: Add download URL to plugins REST create (install) endpoint -------------------------------------+------------------------------------- Reporter: brianhenryie | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.5 Severity: normal | Resolution: Keywords: needs-testing has-unit- | Focuses: administration, rest- tests has-patch dev-feedback | api -------------------------------------+------------------------------------- Comment (by brianhenryie): I added the validate_callback, and made it such that one of slug or url are required, and if both are present, the url must be a wordpress.org download URL. Then during the actual install function, it will pull the language pack as specified in the slug, and install the plugin from the URL, which would possibly be an older version of the plugin. There's definitely room for people to do weird stuff like mismatching a slug and plugin. And arguing in the other direction, it would be valid for me to modify a .org plugin, host it somewhere else, and want the .org language pack while installing it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 20:33:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 20:33:08 -0000 Subject: [wp-trac] [WordPress Trac] #56893: Unnecessary line breaks added by the code editor that breaks JavaScript In-Reply-To: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> References: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> Message-ID: <070.7b1159bf5e7ffe5cbf5b238be3a57de3@wordpress.org> #56893: Unnecessary line breaks added by the code editor that breaks JavaScript --------------------------+------------------------------ Reporter: sweetheatmn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by sajjad67): Thank You for noticing it @sweetheatmn. But the editor is not the best place to put Inline JS Code, and that's why it was not designed to escape the inline JS!! But it should escape!! I agree. @SergeyBiryukov What is your thought? Do we add an escape for the editors if it's wrapped around `` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 20:43:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 20:43:45 -0000 Subject: [wp-trac] [WordPress Trac] #56893: Unnecessary line breaks added by the code editor that breaks JavaScript In-Reply-To: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> References: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> Message-ID: <070.928e4520ab7234c3fb7608169e250b6e@wordpress.org> #56893: Unnecessary line breaks added by the code editor that breaks JavaScript --------------------------+------------------------------ Reporter: sweetheatmn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by sweetheatmn): Replying to [comment:3 sajjad67]: > Thank You for noticing it @sweetheatmn. But the editor is not the best place to put Inline JS Code, and that's why it was not designed to escape the inline JS!! But it should escape!! I agree. @SergeyBiryukov What is your thought? Do we add an escape for the editors if it's wrapped around `` You are welcome, This is a glitch and has to be sorted asap, JS is everywhere in embed codes and there is no logic in breaking an existing JS code This also has to be sorted on the function that filters the content and add unnecessary paragraph tags -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 23 20:55:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 23 Oct 2022 20:55:18 -0000 Subject: [wp-trac] [WordPress Trac] #56893: Unnecessary line breaks added by the code editor that breaks JavaScript In-Reply-To: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> References: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> Message-ID: <070.7a59d17692b2f879efa181ff51dec36e@wordpress.org> #56893: Unnecessary line breaks added by the code editor that breaks JavaScript --------------------------+------------------------------ Reporter: sweetheatmn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by sajjad67): Yes... Let's have one of other's opinion on it. I am working on the escaping to apply. Let's see!! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 00:51:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 00:51:11 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.88371b668caf9f488fa394bcb7718316@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: | davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note dev-feedback | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): Discussing this with @davidbaumwald, we think it's worth reverting [54213] and coming back to this in another major release. No patch as it's an SVN command for a reverse merge (revert): `svn merge -c -54213 '^/trunk'` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 01:16:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 01:16:08 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.72f4de427879675ed4c8417cfa3ced05@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: Keywords: has-unit-tests has-patch needs-dev- | Focuses: note commit | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-unit-tests has-patch needs-dev-note => has-unit-tests has- patch needs-dev-note commit Comment: The [https://github.com/WordPress/wordpress-develop/pull/3506 linked pull request] has approvals from two committers since the most recent `/src` change: @ocean90 @SergeyBiryukov. @flixos90 approved earlier. Marking for commit. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 02:11:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 02:11:09 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.416d1d3319ef357b80b6a21f28409488@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | spacedmonkey Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests needs-testing commit dev-reviewed => has-patch has-unit-tests needs-testing Comment: Updating the keywords to account for the follow up PR. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 06:23:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 06:23:11 -0000 Subject: [wp-trac] [WordPress Trac] #56893: Unnecessary line breaks added by the code editor that breaks JavaScript In-Reply-To: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> References: <055.866cf381f97fab839aa83a64785c39e1@wordpress.org> Message-ID: <070.a3c6ca14645d746b4536b52bff08a7be@wordpress.org> #56893: Unnecessary line breaks added by the code editor that breaks JavaScript --------------------------+------------------------------ Reporter: sweetheatmn | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.3 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Old description: > adding a simple JavaScript to the code editor and hitting the publish > button just adds unnecessary > {{{ >
> }}} > > inside the Javascript which is a sufficient reason to break any > JavaScript > > How to reproduce, simply add a new post, paste/write any JavaScript and > click the publish button to see the black magic > > [[Image(https://i.imgur.com/fyrAwtI.png)]] > > Regards, > Atef New description: adding a simple JavaScript to the code editor and hitting the publish button just adds unnecessary {{{
}}} inside the Javascript which is a sufficient reason to break any JavaScript How to reproduce: simply add a new post, paste/write any JavaScript and click the publish button to see the black magic [[Image(https://i.imgur.com/fyrAwtI.png)]] Regards, Atef -- Comment (by sabernhardt): The automated paragraph bug with scripts in Classic Editor is very old: #2833. In the block editor, `script` tags in a paragraph block would behave similarly. However, content within a ''Custom HTML'' block should not get the inappropriate tags. Creating that block is easier in Visual mode, but in Code view you could wrap scripts in the `wp:html` block comments: {{{ }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 06:28:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 06:28:33 -0000 Subject: [wp-trac] [WordPress Trac] #54542: Update link in grey section box in themes directory In-Reply-To: <054.d8199e3c994a8b1f8e2af27bd6326e1f@wordpress.org> References: <054.d8199e3c994a8b1f8e2af27bd6326e1f@wordpress.org> Message-ID: <069.deeae45a47ee407dc86380a8db7fbc34@wordpress.org> #54542: Update link in grey section box in themes directory --------------------------------+------------------------------ Reporter: dansoschin | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: WordPress.org Site | Version: Severity: trivial | Resolution: Keywords: | Focuses: --------------------------------+------------------------------ Comment (by sabernhardt): Could you move this ticket to [https://meta.trac.wordpress.org/newticket Meta Trac], too? (Component: Theme Directory) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 06:37:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 06:37:31 -0000 Subject: [wp-trac] [WordPress Trac] #55525: Clicking "Next" from last lesson in section within Learn courses results in 404 In-Reply-To: <053.274828c0daaed86a99f104ce96601f46@wordpress.org> References: <053.274828c0daaed86a99f104ce96601f46@wordpress.org> Message-ID: <068.12399bbed185287a20dd88488f07bcca@wordpress.org> #55525: Clicking "Next" from last lesson in section within Learn courses results in 404 --------------------------------+-------------------------------- Reporter: felsonm20 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: WordPress.org Site | Version: Severity: normal | Resolution: reported-upstream Keywords: | Focuses: docs --------------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: Thanks for the report! Apparently Learn WordPress has its own repository for reporting issues: https://github.com/WordPress/Learn/issues The navigation should be fixed now. See: - [https://github.com/Automattic/sensei/issues/5008 Sensei issue 5008] - [https://github.com/WordPress/Learn/issues/689 Learn WordPress issue 689] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 10:01:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 10:01:18 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.a6f8aa33ad7356195869a6663a301a92@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-unit-tests has-patch needs-dev- | Focuses: note commit | -------------------------------------------------+------------------------- Changes (by swissspidy): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54669" 54669]: {{{ #!CommitTicketReference repository="" revision="54669" I18N: Change how `WP_Textdomain_Registry` stores the default languages path. `WP_Textdomain_Registry` was introduced in [53874] to store text domains and their language directory paths, addressing issues with just-in-time loading of textdomains when using locale switching and when using`load_*_textdomain()` functions. Said change has inadvertently caused a performance regression exactly when using`load_*_textdomain()`, which still often is the case, where the cached information was not further used or even overridden. This change addresses that issue by storing the default languages paths in a separate way, while at the same time making `WP_Textdomain_Registry` easier to maintain and adding new tests to catch future regressions. Props flixos90, spacedmonkey, ocean90, SergeyBiryukov, costdev. Fixes #39210. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 10:22:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 10:22:46 -0000 Subject: [wp-trac] [WordPress Trac] #56894: Add new param for "register_taxonomy" for required taxonomy Message-ID: <052.65d5572097a139f3a8bb1bfd4da83753@wordpress.org> #56894: Add new param for "register_taxonomy" for required taxonomy -----------------------------+----------------------------- Reporter: Spidlace | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: trunk Severity: normal | Keywords: Focuses: administration | -----------------------------+----------------------------- Hi, It would be great if we have the possibility to set new param in "register_taxonomy" function to force user set term for post type. Currently, we did the trick with some Javascript but if this was the default setting, it would probably be cleaner My patch is coming ;-) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 13:10:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 13:10:23 -0000 Subject: [wp-trac] [WordPress Trac] #56388: Compiled block styles contain a lot of trash In-Reply-To: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> References: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> Message-ID: <067.322e206e13a2868f7b616c4b06ad5bf5@wordpress.org> #56388: Compiled block styles contain a lot of trash -------------------------------------+-------------------------- Reporter: aristath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Editor | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Changes (by cbravobernal): * version: => 6.1 Comment: Can we take a look at this ticket so we can land it in 6.1? Changes required in the editor will be backported on RC3. Thank you very much! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 13:14:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 13:14:49 -0000 Subject: [wp-trac] [WordPress Trac] #56388: Compiled block styles contain a lot of trash In-Reply-To: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> References: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> Message-ID: <067.16c971fce9fa7a16de140854f4d07351@wordpress.org> #56388: Compiled block styles contain a lot of trash -------------------------------------+-------------------------- Reporter: aristath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Changes (by SergeyBiryukov): * milestone: 6.1.1 => 6.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 13:15:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 13:15:18 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.9acb49ac264f3ccdbc64b364a4dbaf22@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: | davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note dev-feedback commit | -------------------------------------------------+------------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests needs-dev-note dev-feedback => has- patch has-unit-tests needs-dev-note dev-feedback commit Comment: Marking `commit` as this is ready for a committer to revert. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 13:20:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 13:20:23 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.d51a70464fc39974303894f0c8ab5bfa@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one ---------------------------------------------+---------------------------- Reporter: maksimkuzmin | Owner: davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+---------------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests needs-dev-note dev-feedback commit => has-patch has-unit-tests commit Comment: Also removing `needs-dev-note` since this will no longer be included in 6.1, and removing `dev-feedback` so that it can be re-added after revert for a review prior to backport. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 13:24:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 13:24:14 -0000 Subject: [wp-trac] [WordPress Trac] #55942: Add a "type" field to the meta and options tables In-Reply-To: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> References: <050.78971eaa2104bb1c35cd0f8725f473a8@wordpress.org> Message-ID: <065.0336692737264dcc6b8f7b046e3d1ba4@wordpress.org> #55942: Add a "type" field to the meta and options tables -------------------------------------------------+------------------------- Reporter: azaozz | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Comment (by petitphp): We already have a way to define the type of data when using `register_meta`/`register_term_meta`/`register_settings`. If i'm not mistaken, this is currently only used when preparing output for the REST API. We could leverage this to handle saving/retrieving data from the database ? This would ensure existing metas/options would keep the current behavior unless the dev has specified a type. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 13:46:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 13:46:30 -0000 Subject: [wp-trac] [WordPress Trac] #56388: Compiled block styles contain a lot of trash In-Reply-To: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> References: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> Message-ID: <067.7f13e48d59b6d7237f354fede4232948@wordpress.org> #56388: Compiled block styles contain a lot of trash -------------------------------------+-------------------------- Reporter: aristath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Comment (by SergeyBiryukov): I suppose this can be merged after the package updates for RC3, so that the affected files in `wp-includes/blocks.php` are no longer flagged as modified. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 13:53:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 13:53:25 -0000 Subject: [wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options In-Reply-To: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> References: <056.a9a12042e8bbc071a4a535ac583bce0b@wordpress.org> Message-ID: <071.3cf8034dab5b1b319a8432e06e160fad@wordpress.org> #37181: Use metadata api in *_network_options --------------------------------+------------------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: reopened Priority: normal | Milestone: 6.2 Component: Networks and Sites | Version: 4.4 Severity: normal | Resolution: Keywords: ms-roadmap | Focuses: multisite, performance --------------------------------+------------------------------------- Changes (by desrosj): * keywords: ms-roadmap revert => ms-roadmap * milestone: 6.1 => 6.2 Comment: The dev note has been updated to include a callout at the top. Since the 6.1 aspects of this have been addressed, I'm going to leave this open punt to 6.2. There was agreement that this could still be beneficial and deserves further exploration, but would need other related problems to be solved at the same time to be feasible. Just to bring some thoughts @johnjamesjacoby shared that summarize a great path forward over from Slack for easier reference: > Hello! I’m onboard with reverting for 6.1, and suggest: > - keeping it open > - moving to the 6.2 milestone > - landing it simultaneously with some future meta data cache key improvement to address the forever-old 1MB memcached issue > The major (future) benefit of getting network options using the meta data API is it inherits all improvements from it (in addition to removing the bespoke cache-key implementation of options) > > Would love to see (and participate in) a collaborative effort from cache, options, meta, multisite, & performance contributors (of which there is some overlap) to identify, document, and make progress on a roadmap. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:14:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:14:41 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.75902c190657e08ea1ee91f8a503ea7e@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: Bernhard | Reiter Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: normal | Resolution: fixed Keywords: needs-testing has-testing-info dev- | Focuses: feedback has-patch has-unit-tests | -------------------------------------------------+------------------------- Changes (by Bernhard Reiter): * owner: (none) => Bernhard Reiter * status: new => closed * resolution: => fixed Comment: In [changeset:"54670" 54670]: {{{ #!CommitTicketReference repository="" revision="54670" Blocks: Allow arrays for deprecated asset types in block registration. In `register_block_type`, continue to allow passing arrays as the `editor_script`, `script`, `view_script`, `editor_style`, and `style` arguments. Note that those fields were soft-deprecated in favor of their `_handles` counterparts in [54155], which would allow specifying multiple items. At the same time, the deprecated fields were limited to `string` or `null`. However, this broke existing code that passed an array as one of those arguments. For backwards compatibility, this change thus restores the previous behavior. It is implemented in `WP_Block_Type` as a pair of `__get()` and `__set()` methods that wrap around the corresponding `_handles` members, which are arrays of strings. It also affects the REST API endpoint for block types. The latter’s schema has never allowed for anything other than `string` or `null` for any of those fields. For this reason, it now returns the first element of the array stored in the corresponding `_handles` member in `WP_Block_Type`. Follow-up [54155]. Props nendeb55, costdev, gziolo, spacedmonkey, mukesh27, sergeybiryukov, audrasjb. Fixes #56707. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:26:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:26:34 -0000 Subject: [wp-trac] [WordPress Trac] #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding within the cells In-Reply-To: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> References: <048.a881c183a3b3dea06936d8fba259e0df@wordpress.org> Message-ID: <063.72dc307aa352fdb44c736eb5ea12e100@wordpress.org> #56818: Twenty Twenty-Three: 6.1 RC1 ignores padding within the cells ---------------------------+--------------------- Reporter: vtad | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+--------------------- Changes (by desrosj): * keywords: reporter-feedback => * milestone: 6.1 => 6.1.1 Comment: There is a PR upstream attempting to improve this. While this is not ideal, it's not a blocker or serious issue for 6.1 to be released. I'm punting to 6.1.1 so we can follow up on it in the next minor release. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:30:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:30:10 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.7e0c1ffbcb959ea90f0fe89c75f6e706@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by adamsilverstein): > @adamsilverstein I have not tested MacOS 13, but the AVIF support in iOS16 unfortunately does not include HDR AVIF images. Viewing my site on an iPhone / iPad will show the HDR content clipped. Thats unfortunate! Can you use something like `picture` element to get Safari to fall back to another format? I'm curious if the recent merge to WebKit will fix that issue and plan to test once the new code lands in Safari Technology Preview. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:30:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:30:34 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.bd3619882cda99264a1bbfe96ce05b2c@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: Bernhard | Reiter Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: normal | Resolution: fixed Keywords: needs-testing has-testing-info dev- | Focuses: feedback has-patch has-unit-tests | -------------------------------------------------+------------------------- Comment (by Bernhard Reiter): In [changeset:"54671" 54671]: {{{ #!CommitTicketReference repository="" revision="54671" Blocks: Allow arrays for deprecated asset types in block registration. In `register_block_type`, continue to allow passing arrays as the `editor_script`, `script`, `view_script`, `editor_style`, and `style` arguments. Note that those fields were soft-deprecated in favor of their `_handles` counterparts in [54155], which would allow specifying multiple items. At the same time, the deprecated fields were limited to `string` or `null`. However, this broke existing code that passed an array as one of those arguments. For backwards compatibility, this change thus restores the previous behavior. It is implemented in `WP_Block_Type` as a pair of `__get()` and `__set()` methods that wrap around the corresponding `_handles` members, which are arrays of strings. It also affects the REST API endpoint for block types. The latter’s schema has never allowed for anything other than `string` or `null` for any of those fields. For this reason, it now returns the first element of the array stored in the corresponding `_handles` member in `WP_Block_Type`. Follow-up [54155]. Props nendeb55, costdev, gziolo, spacedmonkey, mukesh27, sergeybiryukov, audrasjb. Merges [54670] to the 6.1 branch. Fixes #56707. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:39:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:39:23 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.2b9b1eedf41ebbf773bcb619ba375151@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by adamsilverstein): > The fundamental flaw with the WebP proposal was wanting to convert all existing images/thumbnails by default. > Here the approach should simply be supporting AVIF uploads and generating AVIF thumbnails of those uploads. Thats exactly what we did for WebP in WordPress 5.8; the rejected proposal for "by default" was a follow up to that work. > The only big hurdle is AVIF that PHP < 8.1 doesn’t support it and WP is still handcuffed to supporting ancient EOL versions of PHP. Plus the lack of support in Edge. > The philosophical decision that needs to be made is, This decision was made long ago - WordPress image mime type support always depends on the underlying image processing supporting it; it is fine if this is a progressive enhancement. See this article for more info on core support for 8.1 (currently "beta support") - https://make.wordpress.org/core/2022/01/10/wordpress-5-9-and- php-8-0-8-1/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:39:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:39:49 -0000 Subject: [wp-trac] [WordPress Trac] #56388: Compiled block styles contain a lot of unnecessary comment blocks (was: Compiled block styles contain a lot of trash) In-Reply-To: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> References: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> Message-ID: <067.96e1498eee1406087c8ec3cbc6dc7383@wordpress.org> #56388: Compiled block styles contain a lot of unnecessary comment blocks -------------------------------------+-------------------------- Reporter: aristath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:46:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:46:02 -0000 Subject: [wp-trac] [WordPress Trac] #56707: `register_block_type`'s `editor_script` handle fails if it is an array. In-Reply-To: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> References: <052.930cd547b5098cdbc120ac3736d0ff71@wordpress.org> Message-ID: <067.9acfe80e04276cd874a988120d829f03@wordpress.org> #56707: `register_block_type`'s `editor_script` handle fails if it is an array. -------------------------------------------------+------------------------- Reporter: nendeb55 | Owner: Bernhard | Reiter Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info has-patch has- | Focuses: unit-tests dev-reviewed | -------------------------------------------------+------------------------- Changes (by Bernhard Reiter): * keywords: needs-testing has-testing-info dev-feedback has-patch has- unit-tests => has-testing-info has-patch has-unit-tests dev-reviewed Comment: Noting that this had approval on the PR by multiple Core committers ([https://github.com/WordPress/wordpress- develop/pull/3487#pullrequestreview-1149235565 SergeyBiryukov] [https://github.com/WordPress/wordpress- develop/pull/3487#pullrequestreview-1151841566 audrasjb] [https://github.com/WordPress/wordpress- develop/pull/3487#pullrequestreview-1152869842 spacedmonkey]) and thus qualified for merging to the 6.1 release branch. Thanks all! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:47:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:47:26 -0000 Subject: [wp-trac] [WordPress Trac] #47357: $allowedentitynames could be null In-Reply-To: <053.8143056b74fdda82c993f7def2a436f0@wordpress.org> References: <053.8143056b74fdda82c993f7def2a436f0@wordpress.org> Message-ID: <068.719da0b4f667b26603c1bff9d79afc8f@wordpress.org> #47357: $allowedentitynames could be null -------------------------------------+----------------------------- Reporter: doctorlai | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: Formatting | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: -------------------------------------+----------------------------- Changes (by SergeyBiryukov): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"54672" 54672]: {{{ #!CommitTicketReference repository="" revision="54672" KSES: Display a notice if any of the required globals are not set. When using the `CUSTOM_TAGS` constant, these global variables should be set to arrays: * `$allowedposttags` * `$allowedtags` * `$allowedentitynames` * `$allowedxmlentitynames` This commit aims to improve developer experience by displaying a more helpful message to explain a PHP fatal error further in the code if any of these globals are either not set or not an array. Note Using `CUSTOM_TAGS` is not recommended and should be considered deprecated. The `wp_kses_allowed_html` filter is more powerful and supplies context. Follow-up to [832], [834], [2896], [13358], [21796], [28845], [43016], [48072]. Props doctorlai, pento, KnowingArt_com, bosconiandynamics, TJNowell, ironprogrammer, audrasjb, mukesh27, SergeyBiryukov. Fixes #47357. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:58:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:58:20 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.e95b23267d1161fbc5cbefe1bc6ba9f0@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: | davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-unit-tests commit => has-patch has-unit-tests commit dev-feedback Comment: Missed the ticket # in the revert, but here it is. In [changeset:"54673" 54673]: Role/Capability: Revert the newly added `update_role` function for 6.1. Based on feedback, this enhancement isn't quite ready. Reverting [54213] for now to continue the work in the next cycle. Follow-up to [54213]. Props manfcarlo, peterwilsoncc. Also tagging for a secondary review to revert from the 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 14:59:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 14:59:08 -0000 Subject: [wp-trac] [WordPress Trac] #56895: SEO tools can't differ from Tag and Categories Message-ID: <056.a40c7915524b4e28c5c3f3925d510b91@wordpress.org> #56895: SEO tools can't differ from Tag and Categories -----------------------------+----------------------------- Reporter: jakobkjoller | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: ui | -----------------------------+----------------------------- To avoid duplicate titles, we need to make it possible to differ between the tag archive and the category archive. Today we need a plugin like Yoast to fix it. If we change general-template.php line 1208-1217 From: {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:10:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:10:18 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.4f267a111b11033b23012511b161e909@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by gregbenz): Replying to [comment:19 adamsilverstein]: > Thats unfortunate! Can you use something like `picture` element to get Safari to fall back to another format? It's more complicated than just support for the file type. Safari and Firefox will load the image, but not render it properly. And even if they did, showing an SDR image (could also be AVIF) is more optimal than allowing the browser to tone map an HDR image. I'm working on a more nuanced test for my own site to load HDR images when both the display and browser will properly support it. A media query might eventually partially resolve this in combination with something like the picture element. That's probably a ways off based on my testing. And even if that worked, the HDR headroom on 400 nits displays goes to 0 when the screen is at full brightness, so you'd want to show SDR there. There's no great fix for that (but it isn't a big problem, I'm just talking about optimizing things from the perspective of a professional photographer). There is an experimental JS API to query HDR headroom (see test #8 at gregbenzphotography.com/hdr#tests). That would be the ultimate way to determine which images to show. However, that currently requires a developer flag on Chrome and then user permission. Hopefully user permission won't be required for this long-term, as the headroom data is very useful for optimizing display. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:12:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:12:40 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.df791b7e53e56082ba768cf2762172c0@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-reviewed commit | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-testing-info has-unit-tests dev-reviewed => has- patch has-testing-info has-unit-tests dev-reviewed commit * owner: (none) => davidbaumwald * status: new => assigned -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:17:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:17:37 -0000 Subject: [wp-trac] [WordPress Trac] #56896: Google positon drop on all websites with wordpress 6.0.3 installed Message-ID: <059.135605c50a68b2258b0f6d9b0f536696@wordpress.org> #56896: Google positon drop on all websites with wordpress 6.0.3 installed -----------------------------+----------------------------- Reporter: thomasrathbone1 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: blocker | Keywords: needs-testing Focuses: performance | -----------------------------+----------------------------- Google positon drop on all websites with wordpress 6.0.3 installed All my sites have dropped rank in google 100% since the new update. Some wesbites have vanished from google search engine and not showing with site:mydomain.com My sites that have not yet installed the new version have no postion drop of traffic drop. I use godaddy hosting and its auto updates to the new version of wordprss so every website i have hosted on godady is not showing not in google. You need fix this issue asasp -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:18:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:18:05 -0000 Subject: [wp-trac] [WordPress Trac] #56896: Google positon drop on all websites with wordpress 6.0.3 installed In-Reply-To: <059.135605c50a68b2258b0f6d9b0f536696@wordpress.org> References: <059.135605c50a68b2258b0f6d9b0f536696@wordpress.org> Message-ID: <074.ac9bed00524ae8d2ab3574b53c6ff3c6@wordpress.org> #56896: Google positon drop on all websites with wordpress 6.0.3 installed -----------------------------+------------------------------ Reporter: thomasrathbone1 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: blocker | Resolution: Keywords: needs-testing | Focuses: performance -----------------------------+------------------------------ Changes (by thomasrathbone1): * Attachment "Screenshot 2022-10-24 at 02-54-59 Performance.png" added. postion drop in google -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:18:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:18:53 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.f5c66739ba6d7fba3ae44e8d882b3a82@wordpress.org> #55652: Test tool and unit test improvements for 6.1 --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by desrosj): In [changeset:"54674" 54674]: {{{ #!CommitTicketReference repository="" revision="54674" Build/Test Tools: Hardcode the `ref` for the workflow dispatch on failure. This removes the dynamic aspect of the `createWorkflowDispatch()` call that dispatches a Failed Workflow run when another workflow encounters an issue. By hardcoding `trunk` as the `ref`, the version of the workflow used will always be the latest, most up to date. This ensures older branches receive the bug fixes and improvements made in `trunk` without having to backport them. See #55652. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:19:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:19:22 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.5dbe71d3ea29e1fdfabcca293964a37a@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: | davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-patch has-unit-tests commit dev-feedback => has-patch has- unit-tests commit dev-reviewed Comment: [54673] looks good to apply to the 6.1 branch. I'm not sure yet what the right solution would be here, but I think comment:29 does bring up a good point that existing methods can be used for this. Also, looking at the ticket description: > Say, I already have a role `picture_admin`. I might want to alter its display name, or capabilities as an array, or both at once. What I'm forced to do now is this (not taking peculiar ways of editing wp_options table in account): > > {{{#!php > > remove_role( 'picture_admin' ); > add_role( 'picture_admin', $display_name, $capabilities ); > }}} I might be missing something, but wouldn't `add_role()` work for updating the role without removing it first? Based on a brief reading of `WP_Roles::add_role()`, it seems like it should just overwrite the existing role definition. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:20:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:20:34 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.22c84e570cae5d9a0efa991eca30194c@wordpress.org> #55652: Test tool and unit test improvements for 6.1 -------------------------------------------------+------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback | -------------------------------------------------+------------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests => has-patch has-unit-tests commit dev-feedback * status: closed => reopened * resolution: fixed => Comment: Reopening so that [54674] can recieve a second sign off for backporting to the 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:27:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:27:33 -0000 Subject: [wp-trac] [WordPress Trac] #54228: In upgrading PHP recommends plugin that can cause issues (stuck plugin) In-Reply-To: <056.c1fff23bc383680cf74b65179718c352@wordpress.org> References: <056.c1fff23bc383680cf74b65179718c352@wordpress.org> Message-ID: <071.57062c4c2d4578cab272040a68f61051@wordpress.org> #54228: In upgrading PHP recommends plugin that can cause issues (stuck plugin) --------------------------------+-------------------------------- Reporter: bryanquigley | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: WordPress.org Site | Version: Severity: normal | Resolution: reported-upstream Keywords: | Focuses: --------------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: Thanks for the report! That page has several recommendations for updates, and you could join the discussion on #meta6516. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:34:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:34:57 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.86f1096b702eeb87b0b6c85f4dfae40a@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: fixed Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-reviewed commit | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"54675" 54675]: {{{ #!CommitTicketReference repository="" revision="54675" Media: Add `object-fit` to the allowed list of CSS properties. This resolves a bug in Featured Image blocks where `object-fit` was being removed during the `render_callback`. Props raduiason, pbiron, kebbet, SergeyBiryukov, bernhard-reiter, ironprogrammer, xknown, audrasjb, ckanderson22, ivanjeronimo, seriouslysenpai. Fixes #56855. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:35:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:35:57 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.c69ac2f786b8c0c13431773776b6131d@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-reviewed commit | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * status: closed => reopened * resolution: fixed => Comment: Reopening for backport to the 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:37:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:37:11 -0000 Subject: [wp-trac] [WordPress Trac] #56795: Backport GitHub Action updates In-Reply-To: <051.f8b4ac35a029f5899642e8482cc39a48@wordpress.org> References: <051.f8b4ac35a029f5899642e8482cc39a48@wordpress.org> Message-ID: <066.94cb1e663d6f7f02e56cd8d96b458193@wordpress.org> #56795: Backport GitHub Action updates ------------------------------+------------------------ Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Build/Test Tools | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: ------------------------------+------------------------ Changes (by desrosj): * status: assigned => closed * resolution: => duplicate * milestone: 6.2 => Comment: Closing this out in favor of #56882. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:37:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:37:35 -0000 Subject: [wp-trac] [WordPress Trac] #56820: Remove use of save-state and set-output in GitHub Actions In-Reply-To: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> References: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> Message-ID: <066.dae17523f26417ee3dafe6cf371ee190@wordpress.org> #56820: Remove use of save-state and set-output in GitHub Actions -------------------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch commit dev-feedback | Focuses: -------------------------------------------+----------------------- Changes (by desrosj): * keywords: has-patch => has-patch commit dev-feedback Comment: It's going to take a bit more time for third-party actions to update and remove these. All of the instances of this have been removed from the Core workflow code, so I think this can be closed out after [54649] is backported and those can be taken care of as they become available. Marking for a second committer to review. Also, #56882 can handle any further backporting. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:39:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:39:05 -0000 Subject: [wp-trac] [WordPress Trac] #56895: SEO tools can't differ from Tag and Categories In-Reply-To: <056.a40c7915524b4e28c5c3f3925d510b91@wordpress.org> References: <056.a40c7915524b4e28c5c3f3925d510b91@wordpress.org> Message-ID: <071.d566fb8d7a009006a08748f626237efe@wordpress.org> #56895: SEO tools can't differ from Tag and Categories -----------------------------+------------------------------ Reporter: jakobkjoller | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: | Focuses: ui -----------------------------+------------------------------ Changes (by sabernhardt): * component: General => Taxonomy -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:48:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:48:51 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.766547bb1f278d3be7746cf7c46af68d@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-reviewed commit | -------------------------------------------------+------------------------- Comment (by pbiron): Replying to [comment:26 davidbaumwald]: > Reopening for backport to the 6.1 branch. I think this should also be backported to 6.0 and all other previous branches that [54543] was backported to. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:55:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:55:47 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.217903275f2e7d2ce921277628c452e6@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-reviewed commit | -------------------------------------------------+------------------------- Comment (by davidbaumwald): @pbiron Agree. I think this would happen during the next minor cycle. @SergeyBiryukov How do you think we should handle backporting this fix to the other branches affected by the addition of `safecss_filter_attr()` during the most recent minor release? Should a dedicated ticket be opened for tracking that, or could we just tag this ticket for 6.1.1? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:56:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:56:20 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.d92f04899560624d72530d7fdb111ad6@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: fixed Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-reviewed commit | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54676" 54676]: {{{ #!CommitTicketReference repository="" revision="54676" Media: Add `object-fit` to the allowed list of CSS properties. This resolves a bug in Featured Image blocks where `object-fit` was being removed during the `render_callback`. Props raduiason, pbiron, kebbet, SergeyBiryukov, bernhard-reiter, ironprogrammer, xknown, audrasjb, ckanderson22, ivanjeronimo, seriouslysenpai. Reviewed by SergeyBiryukov. Merges [54675] to the 6.1 branch. Fixes #56855. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 15:57:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 15:57:09 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.7d36ded58b45385b56f3d341dfba76bf@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: fixed Keywords: has-patch has-testing-info has- | Focuses: unit-tests | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-testing-info has-unit-tests dev-reviewed commit => has-patch has-testing-info has-unit-tests Comment: Resetting the keywords after the backport. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:01:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:01:30 -0000 Subject: [wp-trac] [WordPress Trac] #56897: First time contributor welcome message improvements Message-ID: <051.be1d389deee99327419596b68abac611@wordpress.org> #56897: First time contributor welcome message improvements -------------------------+----------------------- Reporter: desrosj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Keywords: has-patch Focuses: | -------------------------+----------------------- When a contributor opens a pull request to `WordPress/wordpress-develop` on GitHub and has not done so before, a comment is left on the PR with some helpful information. Here's an [https://github.com/WordPress /wordpress-develop/pull/3515#issuecomment-1287645259 example of the comment's current contents]. {{{ Hi @USERNAME! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out! No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed: - PHP Coding Standards - CSS Coding Standards - HTML Coding Standards - JavaScript Coding Standards - Accessibility Coding Standards - Inline Documentation Standards Thank you, The WordPress Project }}} There are a few things missing that should be added: - The project's Responsible Disclosure policy for security vulnerabilities should be detailed. This would also be good to add to the `pull_request_template.md` file to make sure contributors are aware of the policy before publishing the PR. - The contributor should be informed that they need to link their WordPress.org account to their GitHub account to receive proper credit for their contribution. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:03:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:03:51 -0000 Subject: [wp-trac] [WordPress Trac] #56897: First time contributor welcome message improvements In-Reply-To: <051.be1d389deee99327419596b68abac611@wordpress.org> References: <051.be1d389deee99327419596b68abac611@wordpress.org> Message-ID: <066.9e3628ff3ef008565d33b2d8fc4d19fc@wordpress.org> #56897: First time contributor welcome message improvements -------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+--------------------- Comment (by desrosj): Another improvement to make: There's no link back to the Core Handbook page about using GH PRs for code reviews: https://make.wordpress.org/core/handbook/contribute/git/github-pull- requests-for-code-review/. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:20:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:20:40 -0000 Subject: [wp-trac] [WordPress Trac] #36208: Comment queries should ignore comments associated with non-active custom post types In-Reply-To: <051.40c646292f7109a17c6736a73c2a7e0d@wordpress.org> References: <051.40c646292f7109a17c6736a73c2a7e0d@wordpress.org> Message-ID: <066.82ef72abda7ae945e10c096fc38739fb@wordpress.org> #36208: Comment queries should ignore comments associated with non-active custom post types -------------------------------------------------+------------------------- Reporter: Clorith | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Component: Comments | Version: 4.4 Severity: normal | Resolution: Keywords: needs-unit-tests bulk-reopened has- | Focuses: patch | administration -------------------------------------------------+------------------------- Comment (by helgatheviking): What can we do to finally get this fixed? @techjewel's [PR](https://github.com/WordPress/wordpress-develop/pull/3045) looks promising to me, though it could also be argued that the issue traces back to `get_comments()` which should perhaps only return comments attached to active post types. However, easy to see how that would have much broader implications than the suggested PR. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:26:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:26:26 -0000 Subject: [wp-trac] [WordPress Trac] #56820: Remove use of save-state and set-output in GitHub Actions In-Reply-To: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> References: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> Message-ID: <066.f66a6f4ce0d615aa4d67f302ee38d631@wordpress.org> #56820: Remove use of save-state and set-output in GitHub Actions -------------------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch commit dev-feedback | Focuses: -------------------------------------------+----------------------- Comment (by jrf): > If you want my advise on how to improve that What needs to be reviewed ? Commit [54649] ? If so, I'm good with it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:28:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:28:54 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.e6489f8f72166e71ce060f7e9541a9f0@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs- | Focuses: ui, accessibility, docs, design-feedback | administration, ui-copy -------------------------+------------------------------------------------- Comment (by ryelle): In [changeset:"54677" 54677]: {{{ #!CommitTicketReference repository="" revision="54677" Help/About: Update the About header image. When used inline, the SVG needs the aria-hidden, focusable, and viewBox properties for accessibility. Additionally, this optimizes the SVG by using circle elements in place of path, and removing clipPath. There is no visible change, but the file is now one-third the size. Props sabernhardt. Reviewed by SergeyBiryukov, ryelle. Merges [54662] to the 6.1 branch. Fixes #56703. See #56357. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:28:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:28:54 -0000 Subject: [wp-trac] [WordPress Trac] #56703: Update the Dashboard welcome banner for 6.1 In-Reply-To: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> References: <050.c8cda9e9934f1548a1ef1d0fa92714cc@wordpress.org> Message-ID: <065.94f044f8f07d193ecb19ef09a224f8fd@wordpress.org> #56703: Update the Dashboard welcome banner for 6.1 -------------------------------------------+---------------------------- Reporter: ryelle | Owner: davidbaumwald Type: task (blessed) | Status: closed Priority: high | Milestone: 6.1 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit dev-reviewed | Focuses: accessibility -------------------------------------------+---------------------------- Changes (by ryelle): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54677" 54677]: {{{ #!CommitTicketReference repository="" revision="54677" Help/About: Update the About header image. When used inline, the SVG needs the aria-hidden, focusable, and viewBox properties for accessibility. Additionally, this optimizes the SVG by using circle elements in place of path, and removing clipPath. There is no visible change, but the file is now one-third the size. Props sabernhardt. Reviewed by SergeyBiryukov, ryelle. Merges [54662] to the 6.1 branch. Fixes #56703. See #56357. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:30:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:30:37 -0000 Subject: [wp-trac] [WordPress Trac] #36208: Comment queries should ignore comments associated with non-active custom post types In-Reply-To: <051.40c646292f7109a17c6736a73c2a7e0d@wordpress.org> References: <051.40c646292f7109a17c6736a73c2a7e0d@wordpress.org> Message-ID: <066.05c7d23a3efd00647232bf69d80671ba@wordpress.org> #36208: Comment queries should ignore comments associated with non-active custom post types -------------------------------------------------+------------------------- Reporter: Clorith | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Component: Comments | Version: 4.4 Severity: normal | Resolution: Keywords: needs-unit-tests bulk-reopened has- | Focuses: patch | administration -------------------------------------------------+------------------------- Comment (by techjewel): Yes, It's really frustrating bug. As a plugin developer I installs lots of plugins and those plugin create different posts (cpts) and once I deactivate any I get PHP warning all the time and my debug log file get messy. If anyone have any better idea, we should implement that or a reviewer can review my pull request and merge. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:47:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:47:30 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.3e89d2186e98cbff08b26d3dbb2f4289@wordpress.org> #55652: Test tool and unit test improvements for 6.1 -------------------------------------------------+------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback | -------------------------------------------------+------------------------- Comment (by desrosj): In [changeset:"54678" 54678]: {{{ #!CommitTicketReference repository="" revision="54678" Build/Test Tools: Ensure PHPCS related workflows are properly marked as failed. When a ruleset error is encountered during a PHPCodeSniffer scan, an XML report is not generated and `cs2pr` will exit with a `0`. In this situation, a workflow run will be marked as passing (even though a failure has occurred) due to the presence of `continue-on-error`. This adjusts the logic in the Coding Standards and PHP Compatibility workflows to remove the need for the `continue-on-error` option and ensures all failures are accurately reflected within the GitHub Actions UI. Follow up to [54371]. Props jrf, TobiasBg. See #55652. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:49:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:49:14 -0000 Subject: [wp-trac] [WordPress Trac] #56820: Remove use of save-state and set-output in GitHub Actions In-Reply-To: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> References: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> Message-ID: <066.e0ad1574cf499d9472c3d8924cd5a549@wordpress.org> #56820: Remove use of save-state and set-output in GitHub Actions -------------------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch commit dev-reviewed | Focuses: -------------------------------------------+----------------------- Changes (by desrosj): * keywords: has-patch commit dev-feedback => has-patch commit dev-reviewed Comment: Replying to [comment:10 jrf]: > What needs to be reviewed ? Commit [54649] for backport ? If so, I'm good with it. Correct! Thanks for confirming. Marking as reviewed and will backport shortly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:51:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:51:28 -0000 Subject: [wp-trac] [WordPress Trac] #56820: Remove use of save-state and set-output in GitHub Actions In-Reply-To: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> References: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> Message-ID: <066.c5c737ad6ba7a8e2ad7adaf03cf3b1f3@wordpress.org> #56820: Remove use of save-state and set-output in GitHub Actions -------------------------------------------+----------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch commit dev-reviewed | Focuses: -------------------------------------------+----------------------- Comment (by desrosj): In [changeset:"54679" 54679]: {{{ #!CommitTicketReference repository="" revision="54679" Build/Test Tools: Remove use of `set-output` in Action workflows. The `save-state` and `set-output` commands have been deprecated in GitHub Actions. This removes all occurrences of the command within workflow steps. This will not remove all deprecated notices from workflow summaries (some third-party actions still contain instances of these commands and need to be fixed upstream), but it will fix the notices caused by custom workflow code. Merges [54649] to the 6.1 branch. Props jrf. See #56820. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:51:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:51:44 -0000 Subject: [wp-trac] [WordPress Trac] #56820: Remove use of save-state and set-output in GitHub Actions In-Reply-To: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> References: <051.54cd18832575db3835b971b213b1ca89@wordpress.org> Message-ID: <066.ee3b425f28664657e1a0d69b6c021bb9@wordpress.org> #56820: Remove use of save-state and set-output in GitHub Actions -------------------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit dev-reviewed | Focuses: -------------------------------------------+---------------------- Changes (by desrosj): * status: assigned => closed * resolution: => fixed Comment: This can be considered fixed. Further backporting will be handled in #56882. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 16:53:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 16:53:08 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.d9fbca48049160e58fad993cea4bd7c0@wordpress.org> #55652: Test tool and unit test improvements for 6.1 -------------------------------------------------+------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback | -------------------------------------------------+------------------------- Comment (by desrosj): Both [54674] and [54678] need a second committer sign off to backport. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 17:02:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 17:02:25 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.a690b252defe96dc0db7a795e67dcf72@wordpress.org> #55652: Test tool and unit test improvements for 6.1 -------------------------------------------------+------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback | -------------------------------------------------+------------------------- Comment (by azaozz): Replying to [comment:220 desrosj]: > Both [54674] and [54678] need a second committer sign off to backport. As far as I see these changes are only to build/test functionality, not to "production" files. They will not affect how WP works, so don't think they need a second committer sign-off for backporting. At the same time I don';t seer how the changes can be tested (locally). The only way seems to be to leave them in trunk for coupe days and see how they work. Perhaps can be backported after? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 17:10:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 17:10:09 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.2f7dc606d21a3502dc1534a7380baadf@wordpress.org> #55652: Test tool and unit test improvements for 6.1 ---------------------------------------------+----------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests commit dev-feedback => has-patch has- unit-tests commit Comment: Replying to [comment:221 azaozz]: > As far as I see these changes are only to build/test functionality, not to "production" files. They will not affect how WP works, so don't think they need a second committer sign-off for backporting. Ah, thanks. I honestly couldn't recall if build/test tool, tests, and docs were allowed without a double sign off. So wanted to follow the process to be safe. > At the same time I don't see how the changes can be tested (locally). The only way seems to be to leave them in trunk for coupe days and see how they work. Perhaps can be backported after? Correct, these are GHA platform specific changes. I'm pretty confident in them, so I'll backport now. If follow up adjustments are needed, they can be included as part of #56882, which will backport a handful of other GHA related changes to older branches to ensure our workflows continue to run without issue going forward. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 17:11:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 17:11:52 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.eb018c38cde83e21723b76af5d682797@wordpress.org> #55652: Test tool and unit test improvements for 6.1 ---------------------------------------------+----------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------- Comment (by desrosj): In [changeset:"54680" 54680]: {{{ #!CommitTicketReference repository="" revision="54680" Build/Test Tools: Hardcode the `ref` for the workflow dispatch on failure. This removes the dynamic aspect of the `createWorkflowDispatch()` call that dispatches a Failed Workflow run when another workflow encounters an issue. By hardcoding `trunk` as the `ref`, the version of the workflow used will always be the latest, most up to date. This ensures older branches receive the bug fixes and improvements made in `trunk` without having to backport them. Merges [54674] to the 6.1 branch. See #55652. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 17:14:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 17:14:57 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.73b1ac67aca5d679832f398bbd879f0c@wordpress.org> #55652: Test tool and unit test improvements for 6.1 ---------------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+--------------------- Changes (by desrosj): * status: reopened => closed * resolution: => fixed -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 17:14:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 17:14:58 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.77cba3b9eaeea8f03c4aba2bb43bb7a0@wordpress.org> #55652: Test tool and unit test improvements for 6.1 ---------------------------------------------+----------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------- Comment (by desrosj): In [changeset:"54681" 54681]: {{{ #!CommitTicketReference repository="" revision="54681" Build/Test Tools: Ensure PHPCS related workflows are properly marked as failed. When a ruleset error is encountered during a PHPCodeSniffer scan, an XML report is not generated and `cs2pr` will exit with a `0`. In this situation, a workflow run will be marked as passing (even though a failure has occurred) due to the presence of `continue-on-error`. This adjusts the logic in the Coding Standards and PHP Compatibility workflows to remove the need for the `continue-on-error` option and ensures all failures are accurately reflected within the GitHub Actions UI. Follow up to [54371]. Props jrf, TobiasBg. Merges [54678] to the 6.1 branch. See #55652. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 17:16:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 17:16:50 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.95def3c7b19faec90827db63cbbdf0a3@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: fixed Keywords: has-patch has-testing-info has- | Focuses: unit-tests | -------------------------------------------------+------------------------- Comment (by desrosj): I think this ticket should remain in the current milestone because there are associated changes being released with 6.1. This scenario is often one that's an in between. Unless there's a ticket in a milestone representing the change, it's likely it will be forgotten during a release when writing out release posts, updating About pages, etc.. Personally, I think that we could just backport this to any affected branches now (or shortly after 6.1 is released) and attach the commits to this ticket. It's possible the older branches won't be released in coordination with 6.1.1, so a new ticket in that milestone may not be correct either. I don't think there's a hard rule, but I feel recently we've been using the "backport and just let it sit waiting for a future security release". -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 17:34:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 17:34:05 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.51084f4ed31234007ae0a6f516e1e9af@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: | davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed | -------------------------------------------------+------------------------- Comment (by knutsp): Replying to [comment:47 SergeyBiryukov]: > I might be missing something, but wouldn't `add_role()` work for updating the role without removing it first? Based on a brief reading of `WP_Roles::add_role()`, it seems like it should just overwrite the existing role definition. Fine. Just wanting to change the name of an existing role should have an inutitive name and be simple, like `update_role_name( $role )`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 17:36:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 17:36:42 -0000 Subject: [wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1 In-Reply-To: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> References: <058.7cbfdbf7b77d4dd83ca96567c26f24df@wordpress.org> Message-ID: <073.e662a2e1c9d65e756024ebcbbe12a066@wordpress.org> #55652: Test tool and unit test improvements for 6.1 ---------------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+--------------------- Comment (by azaozz): Replying to [comment:222 desrosj]: > I honestly couldn't recall if build/test tool, tests, and docs were allowed without a double sign off. Yep, that part of the docs/handbook needs to be updated to make this clearer. As far as I know changes to tests, build/test tools, and inline comments (docblocks, etc.) do not require double sign-off. The reason is that these don't affect (directly) how the new release works in production. A special case that does not require double sign-off are changes to the translatable strings. It is quite undesirable to change them as strings should be in string-freeze, but it's still possible. Usually these changes are mostly to fix a typo, etc. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 17:42:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 17:42:59 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.19e493a4ae554d2b95dd053a96fad58b@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-design-feedback | Focuses: ui, accessibility, has-patch | docs, administration, ui-copy -------------------------------------+------------------------------------- Comment (by richtabor): About page Images are confirmed ✅ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 18:35:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 18:35:44 -0000 Subject: [wp-trac] [WordPress Trac] #39210: switch_to_locale() unloads all plugin and theme translations In-Reply-To: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> References: <049.b3260168584777fbc4ddb08d813e7b3e@wordpress.org> Message-ID: <064.e3e60d36729a84b9aaf5e266bba66d3f@wordpress.org> #39210: switch_to_locale() unloads all plugin and theme translations -------------------------------------------------+------------------------- Reporter: gchtr | Owner: ocean90 Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: I18N | Version: 4.7 Severity: normal | Resolution: fixed Keywords: has-unit-tests has-patch needs-dev- | Focuses: note commit | -------------------------------------------------+------------------------- Comment (by ocean90): In [changeset:"54682" 54682]: {{{ #!CommitTicketReference repository="" revision="54682" I18N: Change how `WP_Textdomain_Registry` stores the default languages path. `WP_Textdomain_Registry` was introduced in [53874] to store text domains and their language directory paths, addressing issues with just-in-time loading of textdomains when using locale switching and when using`load_*_textdomain()` functions. Said change has inadvertently caused a performance regression exactly when using`load_*_textdomain()`, which still often is the case, where the cached information was not further used or even overridden. This change addresses that issue by storing the default languages paths in a separate way, while at the same time making `WP_Textdomain_Registry` easier to maintain and adding new tests to catch future regressions. Props flixos90, spacedmonkey, ocean90, SergeyBiryukov, costdev. Merges [54669] to the 6.1 branch. See #39210. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 19:12:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 19:12:26 -0000 Subject: [wp-trac] [WordPress Trac] #56898: Create a GitHub Action workflow that prepares bundled themes for release Message-ID: <051.d5def9a17245633636473ef6a761dc41@wordpress.org> #56898: Create a GitHub Action workflow that prepares bundled themes for release ------------------------------+----------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Keywords: has-patch Focuses: | ------------------------------+----------------------- Releasing new versions of bundled themes is a very manual process. A contributor must: - verify that the `readme.txt` file has been updated properly - ensure versions are bumped properly in appropriate locations - create a new ZIP file for each theme - A Core SVN committer must upload each theme to the directory on release day. Some of this can be automated to make this process easier. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 19:14:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 19:14:25 -0000 Subject: [wp-trac] [WordPress Trac] #56898: Create a GitHub Action workflow that prepares bundled themes for release In-Reply-To: <051.d5def9a17245633636473ef6a761dc41@wordpress.org> References: <051.d5def9a17245633636473ef6a761dc41@wordpress.org> Message-ID: <066.f53642e6ffe09b17d6b1613432201165@wordpress.org> #56898: Create a GitHub Action workflow that prepares bundled themes for release ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by desrosj): I've created a workflow that: - Confirms no file modifications after running theme build scripts (where appropriate). - Allows any organization member to trigger the workflow to generate ZIP files. This seems like a great starting point. In the future, there could be more release related checks and confirmations. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 19:23:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 19:23:32 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.8283b0d13e7750d7b2acbf7d8897a15f@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one -------------------------------------------------+------------------------- Reporter: maksimkuzmin | Owner: | davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed | -------------------------------------------------+------------------------- Comment (by davidbaumwald): In [changeset:"54683" 54683]: {{{ #!CommitTicketReference repository="" revision="54683" Role/Capability: Revert the newly added `update_role` function for 6.1. Based on feedback, this enhancement isn't quite ready. Reverting [54213] for now to continue the work in the next cycle. Follow-up to [54213]. Props manfcarlo, peterwilsoncc, SergeyBiryukov. Reviewed by SergeyBiryukov. Reverts [54213] in the 6.1 branch. See #54572. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 19:25:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 19:25:13 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.536c6ad35f1e81a874c191df6814a84b@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one --------------------------------------+---------------------------- Reporter: maksimkuzmin | Owner: davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.1 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+---------------------------- Changes (by davidbaumwald): * keywords: has-patch has-unit-tests commit dev-reviewed => has-patch has- unit-tests Comment: Cleaning up the keywords after the revert in the 6.1 branch. Thanks everyone who's contributed to this so far. We'll take some more time in the next cycle to refine this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 19:27:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 19:27:35 -0000 Subject: [wp-trac] [WordPress Trac] #54572: Add a function for updating the existing role instead of removing, then adding one In-Reply-To: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> References: <056.b2c66fa027339f31f120bd3712e73851@wordpress.org> Message-ID: <071.b9b57ae0de91808476d2d7fc4e0da281@wordpress.org> #54572: Add a function for updating the existing role instead of removing, then adding one --------------------------------------+---------------------------- Reporter: maksimkuzmin | Owner: davidbaumwald Type: enhancement | Status: reopened Priority: normal | Milestone: 6.2 Component: Role/Capability | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+---------------------------- Changes (by hellofromTonya): * milestone: 6.1 => 6.2 Comment: With the work being reverted/removed from 6.1, moving this ticket to the next major release cycle. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 19:49:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 19:49:50 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.7bfe9009644c80da92f7d759c45d8ae7@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------------------+------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: ui, accessibility, commit dev-reviewed | css, administration -------------------------------------+------------------------------------- Changes (by sabernhardt): * status: closed => reopened * resolution: fixed => Comment: Reopening for backport consideration -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 20:13:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 20:13:26 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.ea798a6405fe84bf57d618446c29f74e@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: fixed Keywords: has-patch has-testing-info has- | Focuses: unit-tests | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): Replying to [comment:31 desrosj]: > Personally, I think that we could just backport this to any affected branches now (or shortly after 6.1 is released) and attach the commits to this ticket. That would be my suggestion too, the fix will then ship with the next security release for those branches. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 21:14:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 21:14:22 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.ab709f5eae7d23abc03e533cf7447b9c@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | spacedmonkey Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Comment (by audrasjb): As per today's bug scrub: let's keep it in the milestone as the proposed PR is under active review from various committers. This should be backported in the next few hours. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 21:40:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 21:40:28 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.4aa48ac480aef77f79a07464e84bb9a4@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------------------+------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: ui, accessibility, commit dev-reviewed | css, administration -------------------------------------+------------------------------------- Comment (by audrasjb): Double committer sign-off: ✅ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 21:41:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 21:41:41 -0000 Subject: [wp-trac] [WordPress Trac] #53174: notice in link-popup of WYSIWYG overlapping search field In-Reply-To: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> References: <051.2b5ad60ad9da99b94b1e29a41f0a6239@wordpress.org> Message-ID: <066.0c4008c96642ecc8d67957412b7c9cd0@wordpress.org> #53174: notice in link-popup of WYSIWYG overlapping search field -------------------------------------+------------------------------------- Reporter: jonny-s | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: 5.7.1 Severity: minor | Resolution: fixed Keywords: has-patch needs-testing | Focuses: ui, accessibility, commit dev-reviewed | css, administration -------------------------------------+------------------------------------- Changes (by audrasjb): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54684" 54684]: {{{ #!CommitTicketReference repository="" revision="54684" Editor: Fix modal height responsiveness on link popup editor. Fix the responsive breakpoint styles for short vertical viewports on the link popup modal. Follow-up to [54216]. Props sabernhardt, joedolson. Fixes #53174. Merges [54660] to the 6.1 branch. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 22:00:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 22:00:01 -0000 Subject: [wp-trac] [WordPress Trac] #56899: Twenty Twenty Three theme > Quote Block> Citation styling cannot be changed Message-ID: <057.0c59d600ceeb392e198699de0a835a2e@wordpress.org> #56899: Twenty Twenty Three theme > Quote Block> Citation styling cannot be changed ---------------------------+----------------------------- Reporter: severinepozzo | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: normal | Keywords: Focuses: ui, template | ---------------------------+----------------------------- **Summary** In the Quote block the citation has less flexibility to be styled than the quote. Used WP 6.1 RC2 to test. **Steps to reproduce** 1. Add a Quote block in a Post editor 2. Try to change the Citation's font size, appearance and background **Expected results** The background, font size and appearance can be changed the same way the quote styling can be changed. **Actual Results** The citation styling stays the same while the quote styling changes. https://www.screencast.com/t/ciwoJmlowm -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 22:02:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 22:02:56 -0000 Subject: [wp-trac] [WordPress Trac] #56900: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles call to WP_Query incorrect. Message-ID: <057.9b97203b23844a6f5245fd9d3ca2cb08@wordpress.org> #56900: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles call to WP_Query incorrect. ---------------------------+----------------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.1 Severity: minor | Keywords: needs-patch Focuses: | ---------------------------+----------------------------- `WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles` includes a call to `WP_Query` which is ordered by `post_date`. The correct value is `date`. As `WP_Query` orders by date by default, this is a minor bug as it doesn't have any affect on the database query generated. If needs be, it can probably wait until 6.1.1. Introduced in [54186]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 22:03:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 22:03:42 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency In-Reply-To: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> References: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> Message-ID: <072.ff2521b0cab4de8a3c3f5ed3302cd403@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ---------------------------+------------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: minor | Resolution: Keywords: | Focuses: coding-standards ---------------------------+------------------------------- Comment (by ironprogrammer): +1 on consistency with `Wp`. If there is a wider objective for consistency beyond this specific prefix, consider that most test classes ''do'' adhere to the documented `Tests_Path_TitleCase` practice, so I feel those offer the largest sampling to work from. An important aspect of this policy is to make naming decisions ''easier'' by following a simple pattern, which works well in most cases. There are certainly awkward applications of the policy, for instance if classname `Tests_oEmbed_HTTP_Headers` in `tests/oembed/headers.php` were to be revised, since it strays from the policy in multiple ways. Acronym usage in names also isn't covered in the unit test docs, though [https://developer.wordpress.org/coding-standards/wordpress-coding- standards/php/#naming-conventions it is in WPCS]. If there are to be exceptions to the current docs, it would help to touch on this as well. `Tests_XMLRPC_*` is a good example. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 24 23:57:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 24 Oct 2022 23:57:41 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.99c8105eb108cfe02dbe78a65ad33e13@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: assigned Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing commit dev-feedback | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests needs-testing => has-patch has-unit- tests needs-testing commit dev-feedback * owner: spacedmonkey => peterwilsoncc * status: reopened => assigned Comment: @desrosj has given me the OK via Slack to put the [https://github.com/WordPress/wordpress-develop/pull/3507 linked follow up PR] in to trunk. I shall do so shortly. Marking for dev-feedback for backport consideration. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 00:35:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 00:35:45 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.bc21b97fc73248c660eb376743f48e93@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs- | Focuses: testing commit dev-feedback | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"54685" 54685]: {{{ #!CommitTicketReference repository="" revision="54685" Query: Move cache key generation to its own method. Introduce `WP_Query::generate_cache_key()` for generating the cache key used by the main database query. This removes the need for a filter to test that cache keys do not include the WPDB placeholder causing unreachable cache keys. The tests now call `WP_Query::generate_cache_key()` directly. The filter `wp_query_cache_key` is removed as a hard deprecation. The filter was not included in a stable release. Follow up to [54634]. Props spacedmonkey, jorbin, azaozz, hellofromtonya, mukesh27, peterwilsoncc, desrosj, audrasjb, adamsilverstein, flixos90, davidbaumwald, joedolson, sergeybiryukov. Fixes #56802. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 00:37:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 00:37:34 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.e85c3d94f4d4f65e44f73d454375b7f6@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing commit dev-feedback fixed-major | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests needs-testing commit dev-feedback => has-patch has-unit-tests needs-testing commit dev-feedback fixed-major * status: closed => reopened * resolution: fixed => Comment: Reopening for backport to the 6.1 branch pending a second committers approval. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 00:52:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 00:52:52 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. Message-ID: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. ---------------------------+----------------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- This ticket is for tacking the WordPress-Develop changes required for [https://github.com/WordPress/gutenberg/issues/44946 WordPress/gutenberg#44946]. From the original report: > When importing demo content using WP 6.1 styles are not imported correctly although the same works fine in WP 6.0.2. > > Imported content displays the theme's default colors and styling instead of the styling set for that particular demo. However, in the "Site Editor" styles are correctly displayed. Sometimes when I exit the Site Editor the styles are then correctly displayed in the front end as well, but sometimes it takes a few tries. > > This issue happens with the WordPress default importer as well as our theme's built-in import system. Please see the Gutenberg repo's ticket for further details and discussion. During investigation, it was discovered to be a cache invalidation issue. The caching within the `get_user_data_from_wp_global_styles()` method was not cleared when new custom styles posts were created. The [https://github.com/WordPress/wordpress-develop/pull/3517 linked pull request] switches the caching to use the lower-level caching provided by `WP_Query`. This provides two advantages: * removes duplicate caching of the same data * cache invalidation is managed at the lower level **Committers** Please review [https://github.com/WordPress/gutenberg/issues/44946 WordPress/gutenberg#44946] when generating the props list for this ticket. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 01:10:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 01:10:42 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.17f26ef704efc308eb3b257cc2815ed7@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. ---------------------------+------------------------------ Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Description changed by peterwilsoncc: Old description: > This ticket is for tacking the WordPress-Develop changes required for > [https://github.com/WordPress/gutenberg/issues/44946 > WordPress/gutenberg#44946]. > > From the original report: > > > When importing demo content using WP 6.1 styles are not imported > correctly although the same works fine in WP 6.0.2. > > > > Imported content displays the theme's default colors and styling > instead of the styling set for that particular demo. However, in the > "Site Editor" styles are correctly displayed. Sometimes when I exit the > Site Editor the styles are then correctly displayed in the front end as > well, but sometimes it takes a few tries. > > > > This issue happens with the WordPress default importer as well as our > theme's built-in import system. > > Please see the Gutenberg repo's ticket for further details and > discussion. > > During investigation, it was discovered to be a cache invalidation issue. > The caching within the `get_user_data_from_wp_global_styles()` method was > not cleared when new custom styles posts were created. > > The [https://github.com/WordPress/wordpress-develop/pull/3517 linked pull > request] switches the caching to use the lower-level caching provided by > `WP_Query`. This provides two advantages: > > * removes duplicate caching of the same data > * cache invalidation is managed at the lower level > > **Committers** Please review > [https://github.com/WordPress/gutenberg/issues/44946 > WordPress/gutenberg#44946] when generating the props list for this > ticket. New description: This ticket is for tacking the WordPress-Develop changes required for [https://github.com/WordPress/gutenberg/issues/44946 WordPress/gutenberg#44946]. From the original report: > When importing demo content using WP 6.1 styles are not imported correctly although the same works fine in WP 6.0.2. > > Imported content displays the theme's default colors and styling instead of the styling set for that particular demo. However, in the "Site Editor" styles are correctly displayed. Sometimes when I exit the Site Editor the styles are then correctly displayed in the front end as well, but sometimes it takes a few tries. > > This issue happens with the WordPress default importer as well as our theme's built-in import system. Please see the Gutenberg repo's ticket for further details and discussion. During investigation, it was discovered to be a cache invalidation issue. The caching within the `get_user_data_from_wp_global_styles()` method was not cleared when new custom styles posts were created. The [https://github.com/WordPress/wordpress-develop/pull/3517 linked pull request] switches the caching to use the lower-level caching provided by `WP_Query`. This provides two advantages: * removes duplicate caching of the same data * cache invalidation is managed at the lower level As noted by @spacedmonkey on the ticket: this issue has been around since the method was introduced but the switch from object caching to a transient in 6.1 means that it will affect all sites in 6.1 rather than only those with a persistent object cache. **Committers** Please review [https://github.com/WordPress/gutenberg/issues/44946 WordPress/gutenberg#44946] when generating the props list for this ticket. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 01:14:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 01:14:15 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.fc9e6a333bd366c412abef4efcc6d83a@wordpress.org> #56383: Import Twenty Twenty-Three ---------------------------------------------+----------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests commit dev-reviewed => has-patch has- unit-tests commit * status: closed => reopened * resolution: fixed => Comment: Reopening to include the latest PR. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 01:23:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 01:23:40 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.21439b16a09d527632490591d95c1dc7@wordpress.org> #56383: Import Twenty Twenty-Three ---------------------------------------------+----------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------- Comment (by desrosj): In [changeset:"54686" 54686]: {{{ #!CommitTicketReference repository="" revision="54686" Twenty Twenty-Three: Merge the latest changes from GitHub. For a full list of changes included, see the `twentytwentythree` repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/0f273d787481b391d428de671659533642b3aa3c...e2005b0272b8480a8fa9155e5802e22659d84674. Props kafleg, poena, mikachan, tobifjellner, aristath. See #56383. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 01:23:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 01:23:50 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.91ca97205345073d6fa835b89f66757e@wordpress.org> #56383: Import Twenty Twenty-Three -------------------------------------------------+------------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback | -------------------------------------------------+------------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests commit => has-patch has-unit-tests commit dev-feedback Comment: Marking for a second committer sign off to backport to the 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 01:26:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 01:26:22 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.3bdd7394545225867b985f67ff1526ff@wordpress.org> #56383: Import Twenty Twenty-Three -------------------------------------------------+------------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback i18n-change | -------------------------------------------------+------------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests commit dev-feedback => has-patch has- unit-tests commit dev-feedback i18n-change Comment: Since this is a string change, marking `i18n-change`. I will ping #polyglots in Core Slack after backporting. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 02:29:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 02:29:20 -0000 Subject: [wp-trac] [WordPress Trac] #56899: Twenty Twenty Three theme > Quote Block> Citation styling cannot be changed In-Reply-To: <057.0c59d600ceeb392e198699de0a835a2e@wordpress.org> References: <057.0c59d600ceeb392e198699de0a835a2e@wordpress.org> Message-ID: <072.04712208cbd97cb9cd9f4cf7542f15d1@wordpress.org> #56899: Twenty Twenty Three theme > Quote Block> Citation styling cannot be changed ---------------------------+------------------------------ Reporter: severinepozzo | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: ui, template ---------------------------+------------------------------ Comment (by JeffPaul): @ndiego @annezazu assuming this is accurate, should this get opened upstream in GitHub? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 02:40:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 02:40:21 -0000 Subject: [wp-trac] [WordPress Trac] #56899: Twenty Twenty-Three: Quote block's citation styling cannot be changed (was: Twenty Twenty Three theme > Quote Block> Citation styling cannot be changed) In-Reply-To: <057.0c59d600ceeb392e198699de0a835a2e@wordpress.org> References: <057.0c59d600ceeb392e198699de0a835a2e@wordpress.org> Message-ID: <072.6ea8330cd1087c031fe29bbe8f6ae69b@wordpress.org> #56899: Twenty Twenty-Three: Quote block's citation styling cannot be changed ---------------------------+------------------------------ Reporter: severinepozzo | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+------------------------------ Changes (by sabernhardt): * focuses: ui, template => css * component: General => Bundled Theme Comment: Thanks for the report! It comes from the [https://core.trac.wordpress.org/browser/trunk/src/wp- content/themes/twentytwentythree/theme.json#L545 theme.json]: {{{ "cite": { "typography": { "fontSize": "var(--wp--preset--font-size--small)", "fontStyle": "normal" } } }}} That was added in [https://github.com/WordPress/twentytwentythree/pull/267 PR 267]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 03:16:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 03:16:32 -0000 Subject: [wp-trac] [WordPress Trac] #50629: Problem with the "Site Address (URL)" field in the General Settings Screen In-Reply-To: <051.5e4c884f368ba2ca79ea729e0fb4dae7@wordpress.org> References: <051.5e4c884f368ba2ca79ea729e0fb4dae7@wordpress.org> Message-ID: <066.d05af89e1ef3cb3aa12d756a749d208f@wordpress.org> #50629: Problem with the "Site Address (URL)" field in the General Settings Screen ----------------------------+--------------------------------- Reporter: digical | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 5.4.2 Severity: normal | Resolution: Keywords: | Focuses: ui, administration ----------------------------+--------------------------------- Changes (by sabernhardt): * Attachment "50629.diff" added. small edit to description text -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 03:21:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 03:21:02 -0000 Subject: [wp-trac] [WordPress Trac] #56902: Twenty Twenty Three: Tag and category template creation for specific items are wrongly displayed as not found despite being successfully created Message-ID: <051.d0c4ccd6b48f2f8dd687ff738650e791@wordpress.org> #56902: Twenty Twenty Three: Tag and category template creation for specific items are wrongly displayed as not found despite being successfully created ---------------------------+------------------------------------------- Reporter: franz00 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Keywords: has-screenshots needs-testing Focuses: | ---------------------------+------------------------------------------- **Summary** Tag and category template creation for specific item are wrongly displayed as not found despite being successfully created. This doesn't happen to all items tag/category templates creation or other template options. **Steps to reproduce** 1. Activate Twenty Twenty-Three theme. 2. Create a new tag or category template for specific item. 3. Observe the success notification at the bottom and Not Found: (template_name) at the top toolbar or at the template list. **Expected result** The successfully created templates should not be reported as not found. **Accompanying images** Template editor https://i.imgur.com/SkXaUm8.png Template list https://i.imgur.com/A7tYqsj.png -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 05:46:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 05:46:25 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.959fd9d46bbce912ac3746c12f256b94@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-design-feedback | Focuses: ui, accessibility, has-patch | docs, administration, ui-copy -------------------------------------+------------------------------------- Comment (by kebbet): - The new SVG's for freedom/privacy-pages might need accessibility-tags, like `aria-hidden="true" focusable="false"` or similar. The new `about- header-about.svg` had it. - Can the `path`-tags be converted to `circle` for smaller file sizes, just like `about-header-about.svg`? @sabernhardt Can you have a look at the new files in the linked PR (since you added your feedback for the about header) -> https://github.com/WordPress/wordpress-develop/pull/3519/files -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 06:20:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 06:20:26 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.d253903eaf5ccc90a49ce4bb23678682@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing commit dev-feedback fixed-major | performance -------------------------------------------------+------------------------- Comment (by chaion07): Thanks @dlh for reporting this. We reviewed this ticket during a recent bug-scrub session. Based on the feedback received we are expecting a second reviewer or a core committer to have a look at the ticket so that we can land it in 6.1. Cheers! Props to @kebbet & @robinwpdeveloper -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 08:54:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 08:54:41 -0000 Subject: [wp-trac] [WordPress Trac] #56903: Backport bugfix on separator block and theme.json #44943 Message-ID: <056.ee924d7b9b7ac55f9cc91fe0b292e360@wordpress.org> #56903: Backport bugfix on separator block and theme.json #44943 --------------------------+----------------------------- Reporter: cbravobernal | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- PHP Backport for https://github.com/WordPress/gutenberg/pull/44943 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 09:28:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 09:28:27 -0000 Subject: [wp-trac] [WordPress Trac] #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work Message-ID: <055.debb1425d8ea6348bb4d85a24ce94e15@wordpress.org> #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work ---------------------------+----------------------------- Reporter: mrfoxtalbot | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- The "decoration" option in the Navigation Block has an option NOT to underline links in the menu (decoration:none). This option works correctly on some themes (Twenty Twenty-Three, Sparkle FSE) but not in Twenty Twenty-Two: https://cloudup.com/cwGQKTvnyzF Upstreamed from this original report: https://github.com/WordPress/gutenberg/issues/42766 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 09:29:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 09:29:30 -0000 Subject: [wp-trac] [WordPress Trac] #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work In-Reply-To: <055.debb1425d8ea6348bb4d85a24ce94e15@wordpress.org> References: <055.debb1425d8ea6348bb4d85a24ce94e15@wordpress.org> Message-ID: <070.214199038bf963e5802440f5cf022d2a@wordpress.org> #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work ---------------------------+------------------------------ Reporter: mrfoxtalbot | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Changes (by mrfoxtalbot): * Attachment "Screen Shot on 2022-10-25 at 10:51:01.png" added. TT2 "no decoration" does not work -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 09:29:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 09:29:43 -0000 Subject: [wp-trac] [WordPress Trac] #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work In-Reply-To: <055.debb1425d8ea6348bb4d85a24ce94e15@wordpress.org> References: <055.debb1425d8ea6348bb4d85a24ce94e15@wordpress.org> Message-ID: <070.6ac2e63192199f5408fbe894dc0d2ed4@wordpress.org> #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work ---------------------------+------------------------------ Reporter: mrfoxtalbot | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Changes (by mrfoxtalbot): * Attachment "Screen Shot on 2022-10-25 at 11:29:12.png" added. TT3 "no decoration" does work -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 10:53:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 10:53:02 -0000 Subject: [wp-trac] [WordPress Trac] #50629: Problem with the "Site Address (URL)" field in the General Settings Screen In-Reply-To: <051.5e4c884f368ba2ca79ea729e0fb4dae7@wordpress.org> References: <051.5e4c884f368ba2ca79ea729e0fb4dae7@wordpress.org> Message-ID: <066.40f002614115734db924202c0635526e@wordpress.org> #50629: Problem with the "Site Address (URL)" field in the General Settings Screen ----------------------------+------------------------------------------ Reporter: digical | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, administration, ui-copy ----------------------------+------------------------------------------ Changes (by sabernhardt): * keywords: => has-patch * focuses: ui, administration => ui, administration, ui-copy * version: 5.4.2 => * milestone: Awaiting Review => 6.2 Comment: Suggested revision for description text: > Enter the ''same'' address here ''unless'' you want your site home page to be different from your WordPress installation directory. The text has had a few changes over the years, but "if" has been part of that since changeset:1203. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 10:59:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 10:59:22 -0000 Subject: [wp-trac] [WordPress Trac] #33052: Widgets section in customize late to show up In-Reply-To: <053.4f7ac76b10d25c7ba532dd1f113866dd@wordpress.org> References: <053.4f7ac76b10d25c7ba532dd1f113866dd@wordpress.org> Message-ID: <068.6349007112b9b9d806ef6ef3c877e304@wordpress.org> #33052: Widgets section in customize late to show up -------------------------------------+-------------------------- Reporter: kidsguide | Owner: westonruter Type: defect (bug) | Status: closed Priority: normal | Milestone: 4.4 Component: Customize | Version: 3.9 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: javascript -------------------------------------+-------------------------- Comment (by kashmirtourpackages): Gujarat Expert attempt at giving you a glimpse of authentic Gujarat. A holiday in Gujarat may introduce you to some very rare and time-honored traditions and culture. [https://www.gujaratexpert.com/ Gujarat Tourism] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 11:24:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 11:24:01 -0000 Subject: [wp-trac] [WordPress Trac] #50629: Problem with the "Site Address (URL)" field in the General Settings Screen In-Reply-To: <051.5e4c884f368ba2ca79ea729e0fb4dae7@wordpress.org> References: <051.5e4c884f368ba2ca79ea729e0fb4dae7@wordpress.org> Message-ID: <066.49f537f11821d8890ebe1cf73d8cb5cc@wordpress.org> #50629: Problem with the "Site Address (URL)" field in the General Settings Screen ----------------------------+------------------------------------------ Reporter: digical | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, administration, ui-copy ----------------------------+------------------------------------------ Comment (by SergeyBiryukov): [attachment:"50629.diff"] seems like a nice improvement to avoid confusion. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 11:56:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 11:56:54 -0000 Subject: [wp-trac] [WordPress Trac] #27851: Underscored text overflow on hover In-Reply-To: <055.8f2e31e7b4a09bd4b078ad69651f87bd@wordpress.org> References: <055.8f2e31e7b4a09bd4b078ad69651f87bd@wordpress.org> Message-ID: <070.662d0fa6e44c9a2f5daced3a1f249656@wordpress.org> #27851: Underscored text overflow on hover ----------------------------+--------------------- Reporter: burakkaptan | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.6 Component: Administration | Version: 3.9 Severity: normal | Resolution: fixed Keywords: | Focuses: css ----------------------------+--------------------- Changes (by sabernhardt): * keywords: 2nd-opinion => * status: new => closed * focuses: => css * resolution: => fixed * milestone: => 5.6 Comment: The `.wp-menu-name` text in those links has wrapped since r49149. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 12:18:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 12:18:11 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.cecc0c524cc3d13edc9b9970192651ad@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+------------------------------ Reporter: Bernhard Reiter | Owner: Bernhard Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by Bernhard Reiter): In [changeset:"54687" 54687]: {{{ #!CommitTicketReference repository="" revision="54687" Editor: Correctly apply Button block styles for classic themes In [54358], styling for Button blocks that had been removed from classic themes was reintroduced. However, it was added with a global scope, whereas editor styles are usually added with a `.editor-styles-wrapper` selector, which makes them more specific. This change modifies the way that classic theme styles are added so that they also get wrapped in an `.editor-styles-wrapper` selector to match specificity. Furthermore, adjust specificity for some Button block related styling in the editor for the Twenty Twelve and Twenty Twenty themes. Merges [https://github.com/WordPress/gutenberg/pull/44731 Gutenberg PR 44731] into trunk. Follow-up to [54358]. Props scruffian, cbravobernal, sabernhardt, audrasjb. See #56467. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 12:24:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 12:24:44 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.e725252943a06d17a400e80bb9206440@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-feedback | -------------------------------------------------+------------------------- Changes (by Bernhard Reiter): * keywords: has-patch has-unit-tests => has-patch has-unit-tests commit dev-feedback Comment: Can I get a second review for backporting [54358] to the 6.1 branch please? :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 12:30:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 12:30:09 -0000 Subject: [wp-trac] [WordPress Trac] #56638: Twenty Twenty-One: submit button colors inside a block with background color (was: front side post comments button design break in the post comments form block.) In-Reply-To: <056.e022f767d67893ca53e6145afc920003@wordpress.org> References: <056.e022f767d67893ca53e6145afc920003@wordpress.org> Message-ID: <071.306eee7258aa5c80cecec5f3efd2e36f@wordpress.org> #56638: Twenty Twenty-One: submit button colors inside a block with background color ---------------------------+------------------------------ Reporter: upadalavipul | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.0.2 Severity: normal | Resolution: Keywords: has-patch | Focuses: css ---------------------------+------------------------------ Changes (by sabernhardt): * keywords: has-patch reporter-feedback => has-patch * component: Editor => Bundled Theme Comment: Using the Post Comments Form block with Twenty Twenty-One or any other 'classic' theme can create duplicate copies of the form, so I do not recommend that (GB45257). However, there might be another situation where a submit button inside a block with a background color should not have the current styling. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 13:18:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 13:18:10 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.6511c3e4130f2146cf68017028a22829@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-patch has-unit-tests commit dev-feedback => has-patch has- unit-tests commit dev-reviewed Comment: [54687] looks good to backport to the 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 13:24:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 13:24:23 -0000 Subject: [wp-trac] [WordPress Trac] #56905: css media query issue Message-ID: <054.03a9e4ca0db3a8b475783469c93d4a41@wordpress.org> #56905: css media query issue --------------------------+----------------------------- Reporter: damien4444 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: trivial | Keywords: needs-patch Focuses: ui, css | --------------------------+----------------------------- The media queries used for the responsivness for mobile use a max-width of 767px and the min-width for the tablet one is 768px. However max-width is exclusiv so when the screen is exactly 767px you are neither in mobile or tablet mode. Unfortunately, when i put a window in half screen mode it is precisely 767px so this number is not that odd and other user could experience the same issue. (Tested on wordpress 6.0.3 and google chrome) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 13:44:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 13:44:05 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.9a3a7ccdf47f1ad856722335b5f8e590@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed | -------------------------------------------------+------------------------- Comment (by Bernhard Reiter): In [changeset:"54688" 54688]: {{{ #!CommitTicketReference repository="" revision="54688" Editor: Correctly apply Button block styles for classic themes In [54358], styling for Button blocks that had been removed from classic themes was reintroduced. However, it was added with a global scope, whereas editor styles are usually added with a `.editor-styles-wrapper` selector, which makes them more specific. This change modifies the way that classic theme styles are added so that they also get wrapped in an `.editor-styles-wrapper` selector to match specificity. Furthermore, adjust specificity for some Button block related styling in the editor for the Twenty Twelve and Twenty Twenty themes. Merges [https://github.com/WordPress/gutenberg/pull/44731 Gutenberg PR 44731] into trunk. Follow-up to [54358]. Props scruffian, cbravobernal, sabernhardt, audrasjb. Merges [54687] to the 6.1 branch. See #56467. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 14:00:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 14:00:41 -0000 Subject: [wp-trac] [WordPress Trac] #42592: Twenty Fifteen: Broken footer width when looking at individual post In-Reply-To: <054.7c16e6cfb0b7a00e19eeaf546ace1dc2@wordpress.org> References: <054.7c16e6cfb0b7a00e19eeaf546ace1dc2@wordpress.org> Message-ID: <069.e7112a1bff2b48a5b12651923706cee9@wordpress.org> #42592: Twenty Fifteen: Broken footer width when looking at individual post ---------------------------+---------------------- Reporter: listalegal | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: 4.9 Severity: normal | Resolution: invalid Keywords: close | Focuses: ---------------------------+---------------------- Changes (by JeffPaul): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Closing this as it appears the issue is caused by a plugin and not core. If we've misunderstood things or additional information can be shared, then please comment/re-open... thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 14:03:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 14:03:27 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.ff67133091af16f8e7d4fbc93445938f@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+------------------------------ Reporter: Bernhard Reiter | Owner: Bernhard Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Changes (by desrosj): * keywords: has-patch has-unit-tests commit dev-reviewed => has-patch has- unit-tests Comment: Resetting the action-based keywords. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 14:17:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 14:17:53 -0000 Subject: [wp-trac] [WordPress Trac] #56905: css media query issue In-Reply-To: <054.03a9e4ca0db3a8b475783469c93d4a41@wordpress.org> References: <054.03a9e4ca0db3a8b475783469c93d4a41@wordpress.org> Message-ID: <069.440a56a93368fbdc4262acde82345cfe@wordpress.org> #56905: css media query issue --------------------------+------------------------------ Reporter: damien4444 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: trivial | Resolution: Keywords: needs-patch | Focuses: ui, css --------------------------+------------------------------ Comment (by miguelaxcar): Great @damien4444. Could you please provide more details about what it's objectively affecting, possibly including screenshots? I tested on instawp, and saw that major break-point is set to `width >= 783px` for tablet and `width < 600px` for small screens. Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 14:21:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 14:21:05 -0000 Subject: [wp-trac] [WordPress Trac] #50629: Problem with the "Site Address (URL)" field in the General Settings Screen In-Reply-To: <051.5e4c884f368ba2ca79ea729e0fb4dae7@wordpress.org> References: <051.5e4c884f368ba2ca79ea729e0fb4dae7@wordpress.org> Message-ID: <066.574e4da3d443db893e47106e06add34e@wordpress.org> #50629: Problem with the "Site Address (URL)" field in the General Settings Screen ----------------------------+------------------------------------------ Reporter: digical | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.2 Component: Administration | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ui, administration, ui-copy ----------------------------+------------------------------------------ Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"54689" 54689]: {{{ #!CommitTicketReference repository="" revision="54689" Administration: Improve the wording of "Site Address" field description. This aims to clarify that "Site Address (URL)" is a required field that should not be left blank, whether or not the site home page is intended to be different from the WordPress installation directory. Follow-up to [1203], [3058], [5093], [5141], [13750], [41986]. Props digical, sabernhardt. Fixes #50629. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 14:27:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 14:27:26 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.9236d2721e26eb41d79c11006dc67632@wordpress.org> #56383: Import Twenty Twenty-Three -------------------------------------------------+------------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: reopened Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed i18n-change | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-patch has-unit-tests commit dev-feedback i18n-change => has-patch has-unit-tests commit dev-reviewed i18n-change Comment: [54686] looks good to backport to the 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 14:54:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 14:54:58 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.47b3ce4013424779a7be48b3e1b078c4@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-design-feedback | Focuses: ui, accessibility, has-patch | docs, administration, ui-copy -------------------------------------+------------------------------------- Comment (by ryelle): In [changeset:"54690" 54690]: {{{ #!CommitTicketReference repository="" revision="54690" Help/About: Update About section images. Switch to the CDN URLs for the images on the About page. Update the images used on Freedoms & Privacy to match the 6.1 design style. Props richtabor, audrasjb, kebbet. See #56357. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 14:56:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 14:56:48 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.c450e83721a71c86058f6710f9eef7e7@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch commit dev- | Focuses: ui, accessibility, feedback | docs, administration, ui-copy -------------------------------------+------------------------------------- Changes (by ryelle): * keywords: needs-design-feedback has-patch => has-patch commit dev- feedback Comment: Marking [54690] for backport to 6.1 pending 2nd committer approval. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 15:00:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 15:00:41 -0000 Subject: [wp-trac] [WordPress Trac] #56383: Import Twenty Twenty-Three In-Reply-To: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> References: <052.4a4852755ddf73336461feca9d687cc6@wordpress.org> Message-ID: <067.a5e18f65ba93d355147443d820cf5da8@wordpress.org> #56383: Import Twenty Twenty-Three -------------------------------------------------+------------------------- Reporter: audrasjb | Owner: desrosj Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Bundled Theme | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: dev-reviewed i18n-change | -------------------------------------------------+------------------------- Changes (by ocean90): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54691" 54691]: {{{ #!CommitTicketReference repository="" revision="54691" Twenty Twenty-Three: Merge the latest changes from GitHub. For a full list of changes included, see the `twentytwentythree` repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/0f273d787481b391d428de671659533642b3aa3c...e2005b0272b8480a8fa9155e5802e22659d84674. Props kafleg, poena, mikachan, tobifjellner, aristath. Merges [54686] to the 6.1 branch. Fixes #56383. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 15:18:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 15:18:21 -0000 Subject: [wp-trac] [WordPress Trac] #56900: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles call to WP_Query incorrect. In-Reply-To: <057.9b97203b23844a6f5245fd9d3ca2cb08@wordpress.org> References: <057.9b97203b23844a6f5245fd9d3ca2cb08@wordpress.org> Message-ID: <072.2cd3ed318169dafc3ca05eddfaa7f847@wordpress.org> #56900: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles call to WP_Query incorrect. ---------------------------+------------------------------ Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 6.1 Severity: minor | Resolution: Keywords: needs-patch | Focuses: ---------------------------+------------------------------ Changes (by miguelaxcar): * Attachment "56900.diff" added. diff against origin/6.1 branch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 15:39:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 15:39:34 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.40d32e45fa74cebe725b5e8171f82f8d@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing commit fixed-major dev-reviewed | performance -------------------------------------------------+------------------------- Changes (by mikeschroder): * keywords: has-patch has-unit-tests needs-testing commit dev-feedback fixed-major => has-patch has-unit-tests needs-testing commit fixed- major dev-reviewed Comment: Thanks so much for everyone's work here! Love the teamwork + communication in finding a better solution. +1 for landing this in the 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 16:29:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 16:29:28 -0000 Subject: [wp-trac] [WordPress Trac] #56905: css media query issue In-Reply-To: <054.03a9e4ca0db3a8b475783469c93d4a41@wordpress.org> References: <054.03a9e4ca0db3a8b475783469c93d4a41@wordpress.org> Message-ID: <069.f138232a6448d6b5cec7cd43e52add08@wordpress.org> #56905: css media query issue -------------------------------+------------------------------ Reporter: damien4444 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: trivial | Resolution: Keywords: reporter-feedback | Focuses: ui, css -------------------------------+------------------------------ Changes (by sabernhardt): * keywords: needs-patch => reporter-feedback Comment: Please also mention any browser extension you use to split the window in half. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 17:24:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 17:24:43 -0000 Subject: [wp-trac] [WordPress Trac] #44441: Remove the settings for image dimensions from Settings => Media In-Reply-To: <050.34fd22b977e14ced77201b12bfc3dcdd@wordpress.org> References: <050.34fd22b977e14ced77201b12bfc3dcdd@wordpress.org> Message-ID: <065.182c2e76f2a7c455736de02aa89506e9@wordpress.org> #44441: Remove the settings for image dimensions from Settings => Media -------------------------+----------------------------- Reporter: azaozz | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+----------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 18:31:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 18:31:52 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.cafc1313dfbc8ae89ab1407ea03e7bb6@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs- | Focuses: testing commit fixed-major dev-reviewed | performance -------------------------------------------------+------------------------- Changes (by davidbaumwald): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54692" 54692]: {{{ #!CommitTicketReference repository="" revision="54692" Query: Move cache key generation to its own method. Introduce `WP_Query::generate_cache_key()` for generating the cache key used by the main database query. This removes the need for a filter to test that cache keys do not include the WPDB placeholder causing unreachable cache keys. The tests now call `WP_Query::generate_cache_key()` directly. The filter `wp_query_cache_key` is removed as a hard deprecation. The filter was not included in a stable release. Follow up to [54685]. Props spacedmonkey, jorbin, azaozz, hellofromtonya, mukesh27, peterwilsoncc, desrosj, audrasjb, adamsilverstein, flixos90, davidbaumwald, joedolson, sergeybiryukov. Reviewed by mikeschroder. Merges [54685] to the 6.1 branch. Fixes #56802. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 18:32:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 18:32:19 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.3af24b76ce79e1a6c114f31b1e30c808@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs- | Focuses: testing fixed-major | performance -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-unit-tests needs-testing commit fixed-major dev- reviewed => has-patch has-unit-tests needs-testing fixed-major Comment: Resetting the keywords after the 6.1 merge. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:06:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:06:20 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.487d8c7af463be499307463d939a77e7@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core --------------------------------------+------------------------------ Reporter: Bernhard Reiter | Owner: Bernhard Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by Bernhard Reiter): In [changeset:"54693" 54693]: {{{ #!CommitTicketReference repository="" revision="54693" Editor: Update packages for 6.1 Release Candidate 3. Package updates for bug and regression fixes: - @wordpress/block-directory: 3.15.10 - @wordpress/block-editor: 10.0.9 - @wordpress/block-library: 7.14.10 - @wordpress/customize-widgets: 3.14.10 - @wordpress/edit-post: 6.14.10 - @wordpress/edit-site: 4.14.12 - @wordpress/edit-widgets: 4.14.10 - @wordpress/editor: 12.16.9 - @wordpress/format-library: 3.15.9 - @wordpress/reusable-blocks: 3.15.9 - @wordpress/widgets: 2.15.9 Original PRs from Gutenberg repository: * [WordPress/gutenberg#45189 Gutenberg PR 45189] - Fix resizeable editor scrolling * [WordPress/gutenberg#45234 Gutenberg PR 45234] - Reset background-image property for outline button style * [WordPress/gutenberg#45161 Gutenberg PR 45161] - Table Block: Add a deprecation for the figcaption element class name * [WordPress/gutenberg#45159 Gutenberg PR 45159] - File Block: Add a deprecation for the button element class name * [WordPress/gutenberg#45169 Gutenberg PR 45169] - Video: Add a deprecation for the caption element * [WordPress/gutenberg#45166 Gutenberg PR 45166] - Embed: Add deprecation for the caption element * [WordPress/gutenberg#45173 Gutenberg PR 45173] - Gallery: Add a deprecation for captions in the gallery block * [WordPress/gutenberg#44854 Gutenberg PR 44854] - Embed Block: Add support for Tumblr Dashboard URLs * [WordPress/gutenberg#45074 Gutenberg PR 45074] - Post editor: Rename view to Preview * [WordPress/gutenberg#45163 Gutenberg PR 45163] - Featured Image Block: Add missing output escaping * [WordPress/gutenberg#45118 Gutenberg PR 45118] - [WP6.1] Site editor clips body background style Follow-up to [54257], [54335], [54383], [54483], [54486], [54490], and [54632]. Props czapla, cbravobernal, ndiego, annezazu, davidbaumwald, desrosj, mikeschroder, hellofromtonya, ocean90. See #56467. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:09:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:09:49 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.f9645fe0660e89738dcdeb2f00c3da7a@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests fixed- | Focuses: major commit dev-feedback | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-unit-tests => has-patch has-unit-tests fixed- major commit dev-feedback Comment: Tagging for a second committer review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:11:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:11:52 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.7a3f4ad27102dc528c61de01bf63ce4f@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests fixed- | Focuses: major commit dev-reviewed | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: has-patch has-unit-tests fixed-major commit dev-feedback => has-patch has-unit-tests fixed-major commit dev-reviewed Comment: [54693] LGTM for backport to 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:14:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:14:38 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.e11680a754f797353cb09eae99253077@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests fixed- | Focuses: major commit dev-reviewed | -------------------------------------------------+------------------------- Comment (by desrosj): [54693] looks good to me as well! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:16:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:16:57 -0000 Subject: [wp-trac] [WordPress Trac] #56776: form label missing in profile page In-Reply-To: <050.c489ec5b544d3afe09fe0bce3c208d53@wordpress.org> References: <050.c489ec5b544d3afe09fe0bce3c208d53@wordpress.org> Message-ID: <065.1da2e80e11d2d6c75999881ceb9ca319@wordpress.org> #56776: form label missing in profile page -------------------------------------+------------------------------------- Reporter: smit08 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Users | Version: Severity: normal | Resolution: Keywords: has-screenshot has- | Focuses: accessibility, patch needs-testing | administration -------------------------------------+------------------------------------- Comment (by sabernhardt): Maybe we can't remove it - see ticket:9883#comment:39 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:17:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:17:50 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.0c053f76e9750845044a68f973e33f8d@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests fixed- | Focuses: major commit dev-reviewed | -------------------------------------------------+------------------------- Comment (by davidbaumwald): In [changeset:"54694" 54694]: {{{ #!CommitTicketReference repository="" revision="54694" Editor: Update packages for 6.1 Release Candidate 3. Package updates for bug and regression fixes since 6.1 RC 2: - @wordpress/block-directory: 3.15.10 - @wordpress/block-editor: 10.0.9 - @wordpress/block-library: 7.14.10 - @wordpress/customize-widgets: 3.14.10 - @wordpress/edit-post: 6.14.10 - @wordpress/edit-site: 4.14.12 - @wordpress/edit-widgets: 4.14.10 - @wordpress/editor: 12.16.9 - @wordpress/format-library: 3.15.9 - @wordpress/reusable-blocks: 3.15.9 - @wordpress/widgets: 2.15.9 Original PRs from Gutenberg repository: * [WordPress/gutenberg#45189 Gutenberg PR 45189] - Fix resizeable editor scrolling * [WordPress/gutenberg#45234 Gutenberg PR 45234] - Reset background-image property for outline button style * [WordPress/gutenberg#45161 Gutenberg PR 45161] - Table Block: Add a deprecation for the figcaption element class name * [WordPress/gutenberg#45159 Gutenberg PR 45159] - File Block: Add a deprecation for the button element class name * [WordPress/gutenberg#45169 Gutenberg PR 45169] - Video: Add a deprecation for the caption element * [WordPress/gutenberg#45166 Gutenberg PR 45166] - Embed: Add deprecation for the caption element * [WordPress/gutenberg#45173 Gutenberg PR 45173] - Gallery: Add a deprecation for captions in the gallery block * [WordPress/gutenberg#44854 Gutenberg PR 44854] - Embed Block: Add support for Tumblr Dashboard URLs * [WordPress/gutenberg#45074 Gutenberg PR 45074] - Post editor: Rename view to Preview * [WordPress/gutenberg#45163 Gutenberg PR 45163] - Featured Image Block: Add missing output escaping * [WordPress/gutenberg#45118 Gutenberg PR 45118] - [WP6.1] Site editor clips body background style Follow-up to [54257], [54335], [54383], [54483], [54486], [54490], and [54632]. Props czapla, cbravobernal, ndiego, annezazu, davidbaumwald, desrosj, mikeschroder, hellofromtonya, ocean90. Reviewed by desrosj, hellofromTonya, SergeyBiryukov. Merges [54693] to the 6.1 branch. See #56467. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:20:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:20:43 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.1116c2f5e7da79c0c45584f0e9710982@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests fixed- | Focuses: major | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: has-patch has-unit-tests fixed-major commit dev-reviewed => has-patch has-unit-tests fixed-major Comment: Resetting keywords as all approved work as been committed and backported. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:27:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:27:26 -0000 Subject: [wp-trac] [WordPress Trac] #56388: Compiled block styles contain a lot of unnecessary comment blocks In-Reply-To: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> References: <052.b91abbe8d1560c2bd841dca5f1b23bb8@wordpress.org> Message-ID: <067.33134e82d468bc6af4603de430abfff7@wordpress.org> #56388: Compiled block styles contain a lot of unnecessary comment blocks -------------------------------------+-------------------------- Reporter: aristath | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Editor | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Changes (by hellofromTonya): * milestone: 6.1 => 6.2 Comment: After discussing with other Core Committers (see [https://wordpress.slack.com/archives/core/p1666725741449329 here in Slack] and [https://github.com/WordPress/gutenberg/pull/43177#issuecomment-1289945321 here in the GB comment]), consensus is: It's too late in the 6.1 cycle with RC3 happening in a few minutes and final release next week. Moving this ticket to 6.2 cycle. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:36:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:36:37 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.f5ea1f4efca5c04d7b616e432ba41d80@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch commit dev- | Focuses: ui, accessibility, reviewed | docs, administration, ui-copy -------------------------------------+------------------------------------- Changes (by desrosj): * keywords: has-patch commit dev-feedback => has-patch commit dev-reviewed Comment: [54690] looks good for backporting. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:36:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:36:52 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.851e07520eb57de258c83ca0eb5907f4@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests fixed- | Focuses: major | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * status: assigned => closed * resolution: => fixed Comment: Closing this ticket. Why? All work is now committed and backported. 6.1 RC3 is happening in a few minutes and is the last scheduled RC before the final release next week. If additional updates are needed between RC3 and Dry Run, this ticket can be reopened. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:47:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:47:17 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.fefd06073d46fd08ab374d0baa2da346@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch commit dev- | Focuses: ui, accessibility, reviewed | docs, administration, ui-copy -------------------------------------+------------------------------------- Comment (by davidbaumwald): In [changeset:"54695" 54695]: {{{ #!CommitTicketReference repository="" revision="54695" Help/About: Update About section images. Switch to the CDN URLs for the images on the About page. Update the images used on Freedoms & Privacy to match the 6.1 design style. Props richtabor, audrasjb, kebbet. Reviewed by desrosj. Merges [54690] to the 6.1 branch. See #56357. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 19:51:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 19:51:22 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.d87ef40b83bf235018c738e33bfbc048@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, accessibility, docs, | administration, ui-copy -------------------------+------------------------------------------------- Changes (by davidbaumwald): * keywords: has-patch commit dev-reviewed => has-patch Comment: Resetting the keywords after the latest backport. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 20:57:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 20:57:07 -0000 Subject: [wp-trac] [WordPress Trac] #56906: Media Library Grid mode no media items shown if debug true Message-ID: <050.59e58d91d0ee138a3eae636a0923695e@wordpress.org> #56906: Media Library Grid mode no media items shown if debug true --------------------------+----------------------------- Reporter: ipajen | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.0.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- If WP_DEBUG is set to true in wp-config then Media Library Grid mode in wp-admin is not showing any media items (works fine in list mode), if disabling debug all media is shown in grid mode. Note: Some deprecated warnings are shown, don't know if that is part of the problem that no media is shown Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /public_html/wp-includes/functions.php on line 7028 Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /public_html/wp-includes/functions.php on line 2168 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 20:58:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 20:58:11 -0000 Subject: [wp-trac] [WordPress Trac] #56906: Media Library Grid mode no media items shown if debug true In-Reply-To: <050.59e58d91d0ee138a3eae636a0923695e@wordpress.org> References: <050.59e58d91d0ee138a3eae636a0923695e@wordpress.org> Message-ID: <065.a8deea1356e383e3095aadc650a1b99f@wordpress.org> #56906: Media Library Grid mode no media items shown if debug true --------------------------+------------------------------ Reporter: ipajen | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.0.3 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by ipajen): * Attachment "media.JPG" added. No media files shown in debug mode in grid -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 20:59:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 20:59:49 -0000 Subject: [wp-trac] [WordPress Trac] #56906: Media Library Grid mode no media items shown if debug true In-Reply-To: <050.59e58d91d0ee138a3eae636a0923695e@wordpress.org> References: <050.59e58d91d0ee138a3eae636a0923695e@wordpress.org> Message-ID: <065.b08eb1ae6289c5a469b2f9dbb66e0523@wordpress.org> #56906: Media Library Grid mode no media items shown if debug true --------------------------+------------------------------ Reporter: ipajen | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.0.3 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Description changed by sabernhardt: Old description: > If WP_DEBUG is set to true in wp-config then Media Library Grid mode in > wp-admin is not showing any media items (works fine in list mode), if > disabling debug all media is shown in grid mode. > > Note: Some deprecated warnings are shown, don't know if that is part of > the problem that no media is shown > > Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type > string is deprecated in /public_html/wp-includes/functions.php on line > 7028 > > Deprecated: str_replace(): Passing null to parameter #3 ($subject) of > type array|string is deprecated in /public_html/wp-includes/functions.php > on line 2168 New description: If `WP_DEBUG` is set to true in wp-config then Media Library Grid mode in wp-admin is not showing any media items (works fine in list mode), if disabling debug all media is shown in grid mode. Note: Some deprecated warnings are shown, don't know if that is part of the problem that no media is shown {{{ Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /public_html/wp-includes/functions.php on line 7028 Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /public_html/wp-includes/functions.php on line 2168 }}} -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 21:49:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 21:49:03 -0000 Subject: [wp-trac] [WordPress Trac] #56906: Media Library Grid mode no media items shown if debug true In-Reply-To: <050.59e58d91d0ee138a3eae636a0923695e@wordpress.org> References: <050.59e58d91d0ee138a3eae636a0923695e@wordpress.org> Message-ID: <065.9649e49e51a995cc0615b900a8341881@wordpress.org> #56906: Media Library Grid mode no media items shown if debug true --------------------------+------------------------------ Reporter: ipajen | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.0.3 Severity: normal | Resolution: Keywords: php81 | Focuses: --------------------------+------------------------------ Changes (by SergeyBiryukov): * keywords: => php81 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 22:42:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 22:42:30 -0000 Subject: [wp-trac] [WordPress Trac] #56899: Twenty Twenty-Three: Quote block's citation styling cannot be changed In-Reply-To: <057.0c59d600ceeb392e198699de0a835a2e@wordpress.org> References: <057.0c59d600ceeb392e198699de0a835a2e@wordpress.org> Message-ID: <072.86ba2917cc380e72a5c8599ac9408e41@wordpress.org> #56899: Twenty Twenty-Three: Quote block's citation styling cannot be changed ---------------------------+------------------------------ Reporter: severinepozzo | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+------------------------------ Comment (by annezazu): Just to follow up here, this is a theme.json only setting, meaning citations can't currently be customized in the UI: https://github.com/WordPress/gutenberg/issues/35735 This is part of overall work to improve customization and consistency of "elements": https://github.com/WordPress/gutenberg/issues/40966 The UI and controls for an end user are coming later on after theme.json support is ensured. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 22:42:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 22:42:50 -0000 Subject: [wp-trac] [WordPress Trac] #56907: Export Child theme produces corrupt zip file Message-ID: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> #56907: Export Child theme produces corrupt zip file --------------------------+------------------------------------------- Reporter: meushar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Export | Version: 6.0.3 Severity: normal | Keywords: reporter-feedback needs-patch Focuses: | --------------------------+------------------------------------------- Export of a theme from the Site Editor with any year theme from WordPress including twentytwentytwo, produces a working zip file. However if you have a child theme of any year theme from WordPress including twentytwentytwo, produces a corrupt zip file. The error reported by ZipRepair.net is: Your .zip file had the following issue: End of Central Directory record could not be found. All files were recovered from the corrupt zip by ZipRepair.net This corrupt zip file occurs without any changes to the child theme from the parent theme and without any plugins active. Only the child functions.php and style.css exist. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 22:45:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 22:45:28 -0000 Subject: [wp-trac] [WordPress Trac] #56907: Export Child theme produces corrupt zip file In-Reply-To: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> References: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> Message-ID: <066.fb7dd67609be857e7dfe30a6b67e6505@wordpress.org> #56907: Export Child theme produces corrupt zip file -------------------------------------------+------------------------------ Reporter: meushar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Export | Version: 6.0.3 Severity: normal | Resolution: Keywords: reporter-feedback needs-patch | Focuses: -------------------------------------------+------------------------------ Changes (by meushar): * Attachment "Repaired_twentytwentytwo-child (2).zip" added. Repaired child.zip file -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 22:45:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 22:45:57 -0000 Subject: [wp-trac] [WordPress Trac] #56907: Export Child theme produces corrupt zip file In-Reply-To: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> References: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> Message-ID: <066.139b3548c104a08fd85ca41161117780@wordpress.org> #56907: Export Child theme produces corrupt zip file -------------------------------------------+------------------------------ Reporter: meushar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Export | Version: 6.0.3 Severity: normal | Resolution: Keywords: reporter-feedback needs-patch | Focuses: -------------------------------------------+------------------------------ Changes (by meushar): * Attachment "twentytwentytwo-child.zip" added. corrupt child.zip file -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 22:46:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 22:46:38 -0000 Subject: [wp-trac] [WordPress Trac] #56907: Export Child theme produces corrupt zip file In-Reply-To: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> References: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> Message-ID: <066.2bddda945c89099384a30ae90c861159@wordpress.org> #56907: Export Child theme produces corrupt zip file -------------------------------------------+------------------------------ Reporter: meushar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Export | Version: 6.0.3 Severity: normal | Resolution: Keywords: reporter-feedback needs-patch | Focuses: -------------------------------------------+------------------------------ Changes (by meushar): * Attachment "twentytwentytwo-child (2).zip" added. corrupt child.zip file -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Oct 25 23:33:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 25 Oct 2022 23:33:16 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.27f74c43a02bd54def65e679ff10d022@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests fixed- | Focuses: major | -------------------------------------------------+------------------------- Comment (by flixos90): @bernhard-reiter @oandregal @andraganescu @audrasjb Apologies for commenting on this already closed ticket, but I am reaching out here since I wanted to follow up on one of the (many) changes committed as part of this ticket. I'm happy to have the conversation in another place, just let me know. My question concretely is in regards to a change in [54408], also see https://github.com/WordPress/gutenberg/pull/42005: Why was the condition from https://github.com/WordPress/gutenberg/pull/42005/files#diff- b1ef1993e7cfe79d570605ca1ac4abf130500170bc33ae7361a16833aec461bcL91 removed? As far as I can tell, the logic within the condition used to only run for sites using FSE themes (or any theme that has a `theme.json`), however now this logic runs unconditionally. To be completely transparent, I am not very familiar with this part of the codebase, but I would think this logic is pointless to run for classic themes without a `theme.json`? I don't see any discussion on the PR about this change either, so I would like to understand why it was made and whether it is really needed. The original reason why I am even looking at this is that I recently conducted a comprehensive performance analysis for WordPress 6.1 (planning to publish a summary soon, some time after 6.1 launch), and this particular change is causing a notable slowdown in the `wp_head` action for classic themes. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 01:46:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 01:46:07 -0000 Subject: [wp-trac] [WordPress Trac] #35690: WordPress permalink redirect error In-Reply-To: <055.94d61e34fe4ec58b96d1e6b2a3b37436@wordpress.org> References: <055.94d61e34fe4ec58b96d1e6b2a3b37436@wordpress.org> Message-ID: <070.b427c6366c17c6ca1eda382cf92ed97f@wordpress.org> #35690: WordPress permalink redirect error --------------------------+------------------------ Reporter: Niresh12495 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Canonical | Version: 4.4.1 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Comment (by janet555): This is a very interesting article. I love the way relevant information was perfectly provided in every piece I learnt a lot. However, you can also check interesting articles on mine. https://www.myinsuranceai.com.ng/tiwa-savage-trend-video/ Tiwa Savage Trend Video https://www.myinsuranceai.com.ng/20-abaya-dress-style-ideas-in-2022/ Abaya dress styles https://www.myinsuranceai.com.ng/10-white-lace-dress-styles-in- ghana-2022/ white lace dress https://www.pawnerspaper.com/2022/05/literary-appreciation-what-is- literary.html Literary Appreciation https://www.myinsuranceai.com.ng/ InsuranceAI y https://www.pawnerspaper.com Pawners Paper https://www.pawnerspaper.com/2022/06/lexis-and-structure-meaning- categories.html Pawners Paper https://www.myinsuranceai.com.ng/access-bank-code-what-is-access-bank- transfer-code/ Pawners Paper This is a very interesting article. I love the way relevant information was perfectly provided in every piece I learnt a lot. However, you can also check interesting articles on mine. https://www.myinsuranceai.com.ng/20-baby-ankara-dress-styles-2022/ baby Ankara dress https://www.myinsuranceai.com.ng/30-sexy-night-dress-for-women-in-2022/ sexy night dress -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 01:47:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 01:47:00 -0000 Subject: [wp-trac] [WordPress Trac] #35690: WordPress permalink redirect error In-Reply-To: <055.94d61e34fe4ec58b96d1e6b2a3b37436@wordpress.org> References: <055.94d61e34fe4ec58b96d1e6b2a3b37436@wordpress.org> Message-ID: <070.58d7be6cee1ea4fc43ec311e5441c963@wordpress.org> #35690: WordPress permalink redirect error --------------------------+------------------------ Reporter: Niresh12495 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Canonical | Version: 4.4.1 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Comment (by janet555): Replying to [comment:2 SergeyBiryukov]: https://www.myinsuranceai.com.ng/15-magenta-color-dress-styles-in-2022/ magenta color dress https://www.myinsuranceai.com.ng/20-corset-dress-ideas-in-2022/ Lcorset dress ideas https://www.pawnerspaper.com/2022/05/best-application-letter-format- in.html application letter format https://www.pawnerspaper.com/2022/05/how-to-write-application-letter- in.html Lhow to write application letter in Nigeria https://www.myinsuranceai.com.ng/ InsuranceAI y https://www.pawnerspaper.com Pawners Paper This is a very interesting article. I love the way relevant information was perfectly provided in every piece I learnt a lot. However, you can also check interesting articles on mine. https://www.pawnerspaper.com/2022/05/30-best-literary-festivals-in- world-2022.html Literary Festival https://www.pawnerspaper.com/2022/05/literary-agents-meaning-of- literary.html Literary agents https://www.pawnerspaper.com/2022/05/where-to-get-online-literature- class-in.html Literature Classy https://www.pawnerspaper.com/2022/05/how-to-make-payment-on-aliexpress- from.html how to make payment on AliExpress from Nigeria https://www.pawnerspaper.com/2022/05/how-to-protect-your-poetry-on- instagram.html how to protect your poetry on Instagram https://www.pawnerspaper.com/2022/05/how-to-write-poems-on-instagram- as.html how to write poems on Instagram https://www.pawnerspaper.com/2022/05/how-to-order-on-aliexpress-from- nigeria.html how to make payment on AliExpress from Nigeriay -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 02:03:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 02:03:16 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.1f1d40d7a33083bc44065f3758deff05@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: fixed Keywords: has-patch has-testing-info has- | Focuses: unit-tests | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * Attachment "56855-docs.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 02:04:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 02:04:14 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.13fc35ee55bc4005a4e91ccee79ba2a4@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: fixed Keywords: has-patch has-testing-info has- | Focuses: unit-tests | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): In [attachment:"56855-docs.diff"] I've noted the introduction of object- fit in the 6.1.0 section of the docblock. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 03:21:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 03:21:29 -0000 Subject: [wp-trac] [WordPress Trac] #56908: The result of locate_block_template function might be wrong Message-ID: <056.a00b2ef7b123d861647d650f7d399737@wordpress.org> #56908: The result of locate_block_template function might be wrong --------------------------+----------------------------- Reporter: arthur791004 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Referring to [https://github.com/WordPress/wordpress- develop/blob/trunk/src/wp-includes/block-template.php#L66 locate_block_template], if the `$template` found by [https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp- includes/template.php#L699 locate_template] is given, this function will call `array_slice` to shorten the list of candidate templates. However, the `array_search` might not find a located template from candidate templates, and it leads to the return value, `$index`, becoming `false`. Therefore, when we run the following codes, we will always get the incorrect result. {{{#!php $templates = array_slice( $templates, 0, $index + 1 ); }}} **Why we might not be able to find the located template from candidate templates?** The reason is the [https://github.com/WordPress/wordpress- develop/blob/trunk/src/wp-includes/template.php#L699 locate_template] function tries to use `STYLESHEETPATH` and `TEMPLATEPATH` to make the path and those two are defined by [https://github.com/WordPress/wordpress- develop/blob/trunk/src/wp-includes/default-constants.php#L392 wp_templating_constants] but the [https://github.com/WordPress/wordpress- develop/blob/trunk/src/wp-includes/block-template.php#L66 locate_block_template] function uses `get_stylesheet_directory` and `get_template_directory` to make the relative template path. As we're able to hook the returned value of both `get_stylesheet_directory` and `get_template_directory`, the result might be different from `STYLESHEETPATH` and `TEMPLATEPATH` respectively if the developer adds the hook after the [https://github.com/WordPress/wordpress- develop/blob/trunk/src/wp-includes/default-constants.php#L392 wp_templating_constants] calls. **Possible Solutions** One way is to check the `$index` before doing `array_slice` as followed to ensure the `array_slice` works expected. {{{#!diff + if ( false !== $index ) { $templates = array_slice( $templates, 0, $index + 1 ); + } }}} The other way is to avoid using different variables. We have to use "`STYLESHEETPATH` and `TEMPLATEPATH`" or "`get_stylesheet_directory` and `get_template_directory`" in both places For example {{{#!diff function locate_template( $template_names, $load = false, $require_once = true, $args = array() ) { ... - if ( file_exists( STYLESHEETPATH . '/' . $template_name ) ) { + if ( file_exists( get_stylesheet_directory() . '/' . $template_name ) ) { ... } }}} What do you think? --- BTW, there is something weird in [https://github.com/WordPress/wordpress- develop/blob/trunk/src/wp-includes/block-template.php#L66 locate_block_template]. At the end of the function, it says "**This file will be included instead of the theme's template file.**". However, it will return the template file immediately on [https://github.com/WordPress /wordpress-develop/blob/ec91ec56be44d8cdbc611758b9721860aae60491/src/wp- includes/block-template.php#L96 L96] if we have a located template. Is it the correct behavior? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 04:01:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 04:01:43 -0000 Subject: [wp-trac] [WordPress Trac] #51373: Include Site ID In WP_Post In-Reply-To: <057.d3a9e3a868f032ba853fc98c0a4485b4@wordpress.org> References: <057.d3a9e3a868f032ba853fc98c0a4485b4@wordpress.org> Message-ID: <072.9d2b7e1e839fc86c0dcd80987b22b59c@wordpress.org> #51373: Include Site ID In WP_Post -------------------------------+------------------------------ Reporter: xedin.unknown | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: Severity: normal | Resolution: duplicate Keywords: 2nd-opinion | Focuses: multisite -------------------------------+------------------------------ Changes (by manfcarlo): * status: new => closed * resolution: => duplicate Comment: Duplicate of #46641. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 06:09:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 06:09:30 -0000 Subject: [wp-trac] [WordPress Trac] #56909: pre_recurse_dirsize filter cannot be used to fill up dirsize_cache and thus breaks performance Message-ID: <052.98c7a4cdc7708077cc9ba94f457a94c6@wordpress.org> #56909: pre_recurse_dirsize filter cannot be used to fill up dirsize_cache and thus breaks performance -------------------------+------------------------------------------------- Reporter: janthiel | Owner: (none) Type: defect | Status: new (bug) | Priority: normal | Milestone: Awaiting Review Component: Networks | Version: 5.6 and Sites | Keywords: 2nd-opinion dev-feedback needs- Severity: normal | patch Focuses: multisite, | performance | -------------------------+------------------------------------------------- In 5.6.0 a new filter was introduced to the dirsize calculation `pre_recurse_dirsize`. After that filter was introduced the dirsize cache was modified to store each folders size separately for a massive performance increase ( part of https://core.trac.wordpress.org/ticket/19879 ). https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp- includes/functions.php#L8287 This second change lead to a state where the `pre_recurse_dirsize` filter is kind of useless. One cannot access or modify the dirsize cache within the filter as the `$dirsize_cache` variable is passed by reference to the recursive calls of `recurse_dirsize()`. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp- includes/functions.php#L8300 Thus using the `pre_recurse_dirsize` filter renders it impossible to use the new, much more efficient dirsize cache based on single folders. I can only fill up the total for the top level folder. If `pre_recurse_dirsize` is used the code would skip these recursive calls to `recurse_dirsize()`. And thus the reference passing of the `$dirsize_cache` and filling it with the subfolder sizes. One would consider that the filter code could set the `$dirsize_cache` or the transient value on its own. This doesn't work as well, as the original code works on an in memory version of the `$dirsize_cache` and will overwrite any changes done within the filter at the end of its code. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp- includes/functions.php#L8323-L8328 This state leads to the bad situation that using the `pre_recurse_dirsize` filter will always lead to worse performance. Although the idea behind introducing it was to open up for performance improvements. I am currently unsure how to fix this in a smart way and am open for any thoughts and suggestions. (Maybe bad) Ideas I had: - Pass the `$dirsize_cache` by the reference to the filter (technically impossible as far as I know) - Add another filter to disable the dirsize cache saving in `recurse_dirsize` to handle everything on our own (would allow full backward compat) - Move the `pre_recurse_dirsize` to another position (don't really know where...) - Make `recurse_dirsize` a pluggable function to replace it completely Thanks a lot! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 07:47:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 07:47:44 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.0eb7b172babef97e7c0dc739f9231ee7@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests fixed- | Focuses: major | -------------------------------------------------+------------------------- Comment (by oandregal): Felix, https://github.com/WordPress/wordpress-develop/pull/3319 bundles a couple of things, and it's not clean by the commit message what it does. I can't speak about the code you mention, but in case it helps, the original PR is at https://github.com/WordPress/gutenberg/pull/42005 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 08:11:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 08:11:12 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.e1a936cc4c9600cc18ccb64324ecd9ec@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. --------------------------------------+------------------------------ Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by spacedmonkey): It is also worth noting that `wp_get_global_stylesheet` and `wp_get_global_styles_svg_filters` also appear to cache global style data in a transient. These too, do not seems to have correct cache invalidation. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 08:29:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 08:29:37 -0000 Subject: [wp-trac] [WordPress Trac] #56910: Improve caching in `wp_get_global_stylesheet` and `wp_get_global_styles_svg_filters` functions Message-ID: <056.2bc091533cd89689da3a30b7911692e4@wordpress.org> #56910: Improve caching in `wp_get_global_stylesheet` and `wp_get_global_styles_svg_filters` functions --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9 Severity: normal | Keywords: needs-patch Focuses: performance | --------------------------+----------------------------- The `wp_get_global_stylesheet` and `wp_get_global_styles_svg_filters` functions cache data in transient for 1 minute. This means that one high traffic sites, the cache will be warmed and performance improved. But for sites with lower traffic or CDN caching ( where less traffic hits the origin ) this cache will not be warned and performance will suffer. Global styles only change if the owner of the site, makes a change or a theme is changed. These caches should be set forever and correctly invalidated. This will improve performance and mean that front end users who hit a page will not suffer poor performance. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 08:30:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 08:30:26 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.78ff97984ca8f6f564f8adfadb1c3edb@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. --------------------------------------+------------------------------ Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by spacedmonkey): Created a breakout ticket. #56910 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 08:54:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 08:54:20 -0000 Subject: [wp-trac] [WordPress Trac] #56911: Login email alert includes administrator username?! Message-ID: <052.572193467066fd133dbf962f686da281@wordpress.org> #56911: Login email alert includes administrator username?! -------------------------------------------+----------------------------- Reporter: jrpmedia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Mail | Version: 6.1 Severity: major | Keywords: needs-testing Focuses: accessibility, administration | -------------------------------------------+----------------------------- I have my site set to email me when an Administrator logs in. This email includes the Administrators username :-O Surely that username in an 'open' email could be intercepted and used to assist in a hack? I have tried changing/adding the username as a shortname but this does not affect the email. Hers is an example of the email: ---------------------------------------------------------- A user with username "O8xxx0ozqxxxxxxx" who has administrator access signed in to your WordPress site. User IP: 81.xxx.7.51 User hostname: host81-148-7-51.range81-148.btcentralplus.com User location: Blackpool, United Kingdom ---------------------------------------------------------- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 09:00:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 09:00:58 -0000 Subject: [wp-trac] [WordPress Trac] #56908: The result of locate_block_template function might be wrong In-Reply-To: <056.a00b2ef7b123d861647d650f7d399737@wordpress.org> References: <056.a00b2ef7b123d861647d650f7d399737@wordpress.org> Message-ID: <071.32267b82be5b99925862c33e3bf7b255@wordpress.org> #56908: The result of locate_block_template function might be wrong --------------------------+------------------------------ Reporter: arthur791004 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 5.8 Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+------------------------------ Changes (by spacedmonkey): * keywords: => needs-patch * version: => 5.8 * component: General => Themes -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 09:02:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 09:02:02 -0000 Subject: [wp-trac] [WordPress Trac] #56911: Login email alert includes administrator username?! In-Reply-To: <052.572193467066fd133dbf962f686da281@wordpress.org> References: <052.572193467066fd133dbf962f686da281@wordpress.org> Message-ID: <067.050d596a1a4c7bbd28e0c637b4b236c5@wordpress.org> #56911: Login email alert includes administrator username?! ---------------------------+-------------------------------------------- Reporter: jrpmedia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Mail | Version: 6.1 Severity: normal | Resolution: Keywords: needs-testing | Focuses: accessibility, administration ---------------------------+-------------------------------------------- Changes (by audrasjb): * severity: major => normal Comment: Hello, welcome to WordPress Core Trac and thank you for opening this ticket, Could you please explain what is the exact issue about mentioning the username in this notification? If it an issue for security reasons, please note that WordPress Core Security Policy doesn't consider usernames disclosing as a security issue :) Related: #3708, #5301, #5388, #14644, #20235. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 09:06:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 09:06:11 -0000 Subject: [wp-trac] [WordPress Trac] #56911: Login email alert includes administrator username?! In-Reply-To: <052.572193467066fd133dbf962f686da281@wordpress.org> References: <052.572193467066fd133dbf962f686da281@wordpress.org> Message-ID: <067.bec874ea41f25e07edda898e9b6cfd51@wordpress.org> #56911: Login email alert includes administrator username?! ---------------------------+-------------------------------------------- Reporter: jrpmedia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Mail | Version: 6.1 Severity: normal | Resolution: Keywords: needs-testing | Focuses: accessibility, administration ---------------------------+-------------------------------------------- Comment (by swissspidy): I don't think WordPress itself sends such emails, at least I can't find such wording in the source code. This might be coming from a plugin or your hosting provider. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 09:13:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 09:13:45 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.0a3ed831fd7fb82049a9ca2229f8d68c@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * status: closed => reopened * resolution: fixed => Comment: Reopening for [attachment:"56855-docs.diff"]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 09:14:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 09:14:17 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.cab807a76597d4f00fd585ed53714a2e@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests fixed- | Focuses: major | -------------------------------------------------+------------------------- Comment (by scruffian): > I would think this logic is pointless to run for classic themes without a theme.json One of the changes introduced in 6.1 is that some blocks now load their styles using the __experimentalStyles property in their block.json, as well as from their CSS file. Given that blocks and their styles are loaded for both classic and block themes, it is necessary for us to output these rules into CSS in both types of themes. Hope that makes sense! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 09:33:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 09:33:49 -0000 Subject: [wp-trac] [WordPress Trac] #56911: Login email alert includes administrator username?! In-Reply-To: <052.572193467066fd133dbf962f686da281@wordpress.org> References: <052.572193467066fd133dbf962f686da281@wordpress.org> Message-ID: <067.36294490c6c92edd3147a5898d96a7cb@wordpress.org> #56911: Login email alert includes administrator username?! ---------------------------+-------------------------------------------- Reporter: jrpmedia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Mail | Version: 6.1 Severity: normal | Resolution: Keywords: needs-testing | Focuses: accessibility, administration ---------------------------+-------------------------------------------- Comment (by jrpmedia): Apologises, I may be in error and it may be WORDFENCE that is doing this. I thought it important enough to report, even if I looked a fool. Thank you for your direction and consideration. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 09:38:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 09:38:33 -0000 Subject: [wp-trac] [WordPress Trac] #56911: Login email alert includes administrator username?! In-Reply-To: <052.572193467066fd133dbf962f686da281@wordpress.org> References: <052.572193467066fd133dbf962f686da281@wordpress.org> Message-ID: <067.881425727746193d999c7b39c285957c@wordpress.org> #56911: Login email alert includes administrator username?! ---------------------------+-------------------------------------------- Reporter: jrpmedia | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Mail | Version: 6.1 Severity: normal | Resolution: worksforme Keywords: needs-testing | Focuses: accessibility, administration ---------------------------+-------------------------------------------- Changes (by audrasjb): * status: new => closed * resolution: => worksforme * milestone: Awaiting Review => Comment: Hello @jrpmedia, No, no, don't apologize! Thank you for opening this ticket :) I'm closing it as `worksforme`. Feel free to reopen it if you find anything else worth to be considered on WordPress Core's side. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 11:12:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 11:12:09 -0000 Subject: [wp-trac] [WordPress Trac] #56912: Improve autoloaded options Message-ID: <056.486941fa7087010fed03105ef940e6ab@wordpress.org> #56912: Improve autoloaded options --------------------------------+---------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Options, Meta APIs | Version: Severity: normal | Keywords: needs-patch Focuses: performance | --------------------------------+---------------------------- Many options are autoloaded when WordPress is bootstrapped. However, there are a number of options that are not automatically loaded. These include. - can_compress_scripts - medium_crop - medium_large_crop - large_crop - site_logo These options should be updated to be automatically loaded. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 11:13:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 11:13:14 -0000 Subject: [wp-trac] [WordPress Trac] #56912: Improve autoloaded options In-Reply-To: <056.486941fa7087010fed03105ef940e6ab@wordpress.org> References: <056.486941fa7087010fed03105ef940e6ab@wordpress.org> Message-ID: <071.a3cb0ac21e13d81501f2f74c0156e1f2@wordpress.org> #56912: Improve autoloaded options --------------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Options, Meta APIs | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance --------------------------------+----------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-10-26 at 12.12.29.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 11:19:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 11:19:10 -0000 Subject: [wp-trac] [WordPress Trac] #56913: Improve autoloaded network options Message-ID: <056.a6a5e637ff794e29d0da28cd32036c9f@wordpress.org> #56913: Improve autoloaded network options --------------------------------+---------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Options, Meta APIs | Version: 3.0 Severity: normal | Keywords: Focuses: performance | --------------------------------+---------------------------- When `wp_load_core_site_options` is called, network options are primed in a single database query. However there are a number of network options that are loaded on every single request. However the a number of options that are needed for every request and are not loaded. These include and are not limited too. - fileupload_maxk - upload_space_check_disabled - upload_filetypes Related [#56912] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 11:49:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 11:49:21 -0000 Subject: [wp-trac] [WordPress Trac] #56912: Improve autoloaded options In-Reply-To: <056.486941fa7087010fed03105ef940e6ab@wordpress.org> References: <056.486941fa7087010fed03105ef940e6ab@wordpress.org> Message-ID: <071.489695886701cd7f06c20ae75cabd466@wordpress.org> #56912: Improve autoloaded options --------------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Options, Meta APIs | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance --------------------------------+----------------------------- Comment (by spacedmonkey): Maybe also think about `WPLANG` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 12:11:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 12:11:27 -0000 Subject: [wp-trac] [WordPress Trac] #56914: Better guide users when deleting other users Message-ID: <059.cc145488d090e2c906d8ebc7dacdeef1@wordpress.org> #56914: Better guide users when deleting other users -----------------------------+----------------------------- Reporter: stefan.velthuys | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: trunk Severity: normal | Keywords: Focuses: ui | -----------------------------+----------------------------- When deleting a user, you have to decide, if their content should be assigned to another person, or if that content should be deleted. The option to delete the content is quite drastic, compared to assigning it. Since this option is not reversible, it should be made clearer, what impact this has. I see multiple ways to warn the users, what they're about to do: - Mark the option to delete bold and use a different color (e.g. red) - Users have to confirm in a second step, if the delete option is selected - By default, pre-select the option to assign the content to another user - Use a kind of "Danger Zone" like GitHub does for deleting repositories But maybe, something as simple as showing the amount of content could suffice: - **Delete** all content (19 posts, 2 pages, 31 images) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 12:12:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 12:12:15 -0000 Subject: [wp-trac] [WordPress Trac] #54797: Allow languages path in register_block_type In-Reply-To: <048.f5bb43c174b0d4ce1f07dd1ece559279@wordpress.org> References: <048.f5bb43c174b0d4ce1f07dd1ece559279@wordpress.org> Message-ID: <063.fb238a57848988c39cebc0de2cf6d9d2@wordpress.org> #54797: Allow languages path in register_block_type --------------------------------------+----------------------- Reporter: Rahe | Owner: gziolo Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.2 Component: I18N | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------- Comment (by felipeelia): Hi there! What I'm sharing here is the result of some time debugging a problem that although not strictly the same as outlined in the ticket seems to be so related that doesn't worth a new ticket IMHO. Let me know if you all prefer it in a new ticket and I can create that. I also want to ask you to excuse me if I missed something obvious here :) I got here trying to translate a JS file added via `block.json`'s editorScript. In my case, it has a long relative path, like {{{ file:/../../../../../dist/js/facets-meta-block-script.js }}} That seems to be generating a discrepancy between the md5 value while creating the .json file and the md5 value actually expected when loading translations. Here is some code to (hopefully) clarify it a bit: **File creation** It seems to use the "real" file name [https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html /wp-content/plugins/wporg-gp-customizations/inc/cli/class-language- pack.php#L458 here]. In this case, `dist/js/facets-meta-block-script.js`. **File detection** Due to the way we are generating the src value [https://github.com/WordPress/wordpress- develop/blob/49da4afcf03f6eea5aba20b42abc0130fc9e2749/src/wp- includes/blocks.php#L143 here], it becomes `https:///wp- content/plugins/elasticpress/assets/js/blocks/facets/taxonomy/../../../../../dist/js /facets-block-script.js`. That `assets/js/blocks/facets/taxonomy` is where the block.json is located. Then in load_script_textdomain, the value used to get an md5 hash [https://github.com/WordPress/wordpress- develop/blob/49da4afcf03f6eea5aba20b42abc0130fc9e2749/src/wp- includes/l10n.php#L1162 here] is actually `assets/js/blocks/facets/meta/../../../../../dist/js/facets-meta-block- script.js` and not `dist/js/facets-meta-block-script.js` as used during the generation step. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 12:33:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 12:33:21 -0000 Subject: [wp-trac] [WordPress Trac] #56914: Better guide users when deleting other users In-Reply-To: <059.cc145488d090e2c906d8ebc7dacdeef1@wordpress.org> References: <059.cc145488d090e2c906d8ebc7dacdeef1@wordpress.org> Message-ID: <074.415742f1d2e57b7cb3e817415bbb1704@wordpress.org> #56914: Better guide users when deleting other users -----------------------------+------------------------------ Reporter: stefan.velthuys | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: ui -----------------------------+------------------------------ Comment (by ocean90): Related: #20045, #23361 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 13:19:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 13:19:24 -0000 Subject: [wp-trac] [WordPress Trac] #56915: Global Styles: Not working for third-party blocks Message-ID: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> #56915: Global Styles: Not working for third-party blocks -----------------------------+----------------------------- Reporter: Bernhard Reiter | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.1 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- First reported in https://github.com/WordPress/gutenberg/issues/40808. Quoting that issue's instructions to reproduce the issue: - Install WooCommerce. - Open the FSE Editor. - Add a WC Blocks (e.g: Feature Product Block). - Customize the global styles related to the block. - Save. - Notice that the Global Styles is not saved. ---- Note that the [https://github.com/WordPress/gutenberg/pull/44018 Gutenberg PR] that fixed this was [https://github.com/WordPress/gutenberg/pull/44018#issuecomment-1251331220 flagged for inclusion in WP 6.1] a month ago, but we missed that these are PHP changes, which thus require a manual backport 😞 This was [https://github.com/WordPress/gutenberg/pull/44018#issuecomment-1291974109 recently brought up] by @oandregal to us. [https://github.com/WordPress/gutenberg/issues/40808#issuecomment-1240881153 First impressions] indicate that this is a regression that was introduced during the 6.1 cycle. I'll try to ascertain. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 13:39:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 13:39:16 -0000 Subject: [wp-trac] [WordPress Trac] #51373: Include Site ID In WP_Post In-Reply-To: <057.d3a9e3a868f032ba853fc98c0a4485b4@wordpress.org> References: <057.d3a9e3a868f032ba853fc98c0a4485b4@wordpress.org> Message-ID: <072.65cfc951c4fba562219b7e7363bece82@wordpress.org> #51373: Include Site ID In WP_Post -------------------------------+------------------------ Reporter: xedin.unknown | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Posts, Post Types | Version: Severity: normal | Resolution: duplicate Keywords: 2nd-opinion | Focuses: multisite -------------------------------+------------------------ Changes (by desrosj): * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 13:43:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 13:43:10 -0000 Subject: [wp-trac] [WordPress Trac] #56242: Problem with Core CSS In-Reply-To: <056.2f60fd69e7093f79c4ea7125e2775cd1@wordpress.org> References: <056.2f60fd69e7093f79c4ea7125e2775cd1@wordpress.org> Message-ID: <071.068aadd8b35da7497fb02a45cf3acc91@wordpress.org> #56242: Problem with Core CSS --------------------------+---------------------------------------- Reporter: mrsoheilsani | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 6.0 Severity: normal | Resolution: wontfix Keywords: | Focuses: ui, css, coding-standards --------------------------+---------------------------------------- Changes (by desrosj): * keywords: move-to-github close => * status: new => closed * resolution: => wontfix * milestone: Awaiting Review => Comment: It's been 3 months without any activity. I'm going to close this one out. @mrsoheilsani if you are experiencing a specific issue as a result of this and still feel this is something that should be addressed, please open an issue upstream as requested by @sabernhardt. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 13:47:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 13:47:09 -0000 Subject: [wp-trac] [WordPress Trac] #50997: Block Editor showing blank in WordPress 5.5 In-Reply-To: <056.b731661352751b6c9d7c7e45ebbd2b78@wordpress.org> References: <056.b731661352751b6c9d7c7e45ebbd2b78@wordpress.org> Message-ID: <071.803165e856ae79863ee63acfbfa19913@wordpress.org> #50997: Block Editor showing blank in WordPress 5.5 --------------------------+-------------------------------- Reporter: david-woakes | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 5.5 Severity: normal | Resolution: reported-upstream Keywords: | Focuses: --------------------------+-------------------------------- Changes (by desrosj): * keywords: reporter-feedback close => * status: reopened => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: > However, since WordPress contains the problematic code of Gutenberg, I recommend to keep this open until it is fixed there and integrated in WordPress While this is true, there are no actions that can be taken on the Core SVN side until changes are made upstream in the Gutenberg repository and the related npm packages are updated. Any changes made upstream will be merged into WordPress Core itself when those dependency versions are bumped. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 13:49:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 13:49:07 -0000 Subject: [wp-trac] [WordPress Trac] #56253: Custom fields list is limited to 30 items only In-Reply-To: <051.0dfcf6ee20f82c0f03b702a52a2fb59f@wordpress.org> References: <051.0dfcf6ee20f82c0f03b702a52a2fb59f@wordpress.org> Message-ID: <066.97cbc15072e46af2f55999f8f1d4777e@wordpress.org> #56253: Custom fields list is limited to 30 items only --------------------------+---------------------- Reporter: publikk | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 6.0 Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by desrosj): * keywords: close => * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Going to close this one out. If the filter noted above by @sabernhardt does not accomplish what you'd like @publikk, please reopen with more details. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 13:50:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 13:50:49 -0000 Subject: [wp-trac] [WordPress Trac] #46641: Add site_id to WP_Post object (was: Add blog_id to post object) In-Reply-To: <052.6a9971358184c1f809e1230c0d4cad54@wordpress.org> References: <052.6a9971358184c1f809e1230c0d4cad54@wordpress.org> Message-ID: <067.9f7fbda679d8cfd0d0a6e6c069bb9cdd@wordpress.org> #46641: Add site_id to WP_Post object --------------------------------+------------------------------ Reporter: Spidlace | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Networks and Sites | Version: 5.1 Severity: normal | Resolution: Keywords: | Focuses: multisite --------------------------------+------------------------------ Old description: > Hi, > > I work on a multisite, where each website can get all posts (from one > post type or not). > It seem interesting to add new line in object response (get_post() for > example) : "blog_id" (where blog_id is an int) > > - blog_id is 1 per default (if no multisite) > > {{{ > WP_Post Object > ( > [ID] => > [post_author] => > [post_date] => > [post_date_gmt] => > [post_content] => > [post_title] => > [post_excerpt] => > [post_status] => > [comment_status] => > [ping_status] => > [post_password] => > [post_name] => > [to_ping] => > [pinged] => > [post_modified] => > [post_modified_gmt] => > [post_content_filtered] => > [post_parent] => > [guid] => > [menu_order] => > [post_type] => > [post_mime_type] => > [comment_count] => > [filter] => > [blog_id] => > ) > }}} > > If this feature is good for some people, I can make this change and > submit here New description: Hi, I work on a multisite, where each website can get all posts (from one post type or not). It seem interesting to add new line in object response (get_post() for example) : "site_id" (where site_id is an int) - site_id is 1 per default (if no multisite) {{{ WP_Post Object ( [ID] => [post_author] => [post_date] => [post_date_gmt] => [post_content] => [post_title] => [post_excerpt] => [post_status] => [comment_status] => [ping_status] => [post_password] => [post_name] => [to_ping] => [pinged] => [post_modified] => [post_modified_gmt] => [post_content_filtered] => [post_parent] => [guid] => [menu_order] => [post_type] => [post_mime_type] => [comment_count] => [filter] => [site_id] => ) }}} If this feature is good for some people, I can make this change and submit here -- Comment (by SergeyBiryukov): Renaming the ticket per comment:3. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 13:54:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 13:54:54 -0000 Subject: [wp-trac] [WordPress Trac] #54651: Twenty Twenty-Two: Site Title heading levels do not change size In-Reply-To: <059.d9c89c4070bad056f40b586938450f21@wordpress.org> References: <059.d9c89c4070bad056f40b586938450f21@wordpress.org> Message-ID: <074.99c01ac258d09d73eeffef85053a70c6@wordpress.org> #54651: Twenty Twenty-Two: Site Title heading levels do not change size -----------------------------+---------------------- Reporter: alanjacobmathew | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: 5.9 Severity: normal | Resolution: invalid Keywords: | Focuses: css -----------------------------+---------------------- Changes (by desrosj): * keywords: close 2nd-opinion => * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Closing this out, as it appears to be an intentional decision. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 13:56:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 13:56:10 -0000 Subject: [wp-trac] [WordPress Trac] #50086: Twenty Fifteen: Correct extra border around the editor in Gutenberg 7.8.1 and above. In-Reply-To: <050.76490f83514e61e6b263887e2285d7f6@wordpress.org> References: <050.76490f83514e61e6b263887e2285d7f6@wordpress.org> Message-ID: <065.0860e7af7ebd319f490907ec6a8a4df1@wordpress.org> #50086: Twenty Fifteen: Correct extra border around the editor in Gutenberg 7.8.1 and above. ---------------------------+---------------------- Reporter: kjellr | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: Severity: normal | Resolution: invalid Keywords: has-patch | Focuses: css ---------------------------+---------------------- Changes (by desrosj): * keywords: has-patch close => has-patch * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Fixed by way of [55338]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 14:21:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 14:21:02 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.ad9556b5bf3e346ca19a544051b9ed45@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54698" 54698]: {{{ #!CommitTicketReference repository="" revision="54698" Docs: Add a `@since` note for `object-fit` support in `safecss_filter_attr()`. Follow-up to [54675]. Props peterwilsoncc. See #56855. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 14:23:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 14:23:01 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.fcf4686c01f5083647754cc04a98c0d0@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests dev-feedback | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-patch has-testing-info has-unit-tests => has-patch has- testing-info has-unit-tests dev-feedback Comment: Marking [54698] for backporting to the 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 14:49:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 14:49:49 -0000 Subject: [wp-trac] [WordPress Trac] #56659: Test the build process for default themes In-Reply-To: <051.b37b396e633428d00993f16a5d48b8d6@wordpress.org> References: <051.b37b396e633428d00993f16a5d48b8d6@wordpress.org> Message-ID: <066.87fb2a6aa0f4897a6a69b7a2504ed7e4@wordpress.org> #56659: Test the build process for default themes ------------------------------+------------------------ Reporter: desrosj | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: Build/Test Tools | Version: Severity: normal | Resolution: duplicate Keywords: good-first-bug | Focuses: ------------------------------+------------------------ Changes (by desrosj): * status: new => closed * resolution: => duplicate * milestone: Future Release => Comment: This will be solved as part of #56898. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:06:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:06:35 -0000 Subject: [wp-trac] [WordPress Trac] #56898: Create a GitHub Action workflow that prepares bundled themes for release In-Reply-To: <051.d5def9a17245633636473ef6a761dc41@wordpress.org> References: <051.d5def9a17245633636473ef6a761dc41@wordpress.org> Message-ID: <066.a94661d7f1914784874724f628821117@wordpress.org> #56898: Create a GitHub Action workflow that prepares bundled themes for release ------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ------------------------------+---------------------- Changes (by desrosj): * owner: (none) => desrosj * status: new => closed * resolution: => fixed Comment: In [changeset:"54699" 54699]: {{{ #!CommitTicketReference repository="" revision="54699" Build/Test Tools: Introduce a workflow for testing and building default themes. This introduces a GitHub Action workflow that performs the following steps for default themes: - Test installing npm dependencies and running the build script (for relevant themes). - Create ZIP files for the .org Theme directory and uploads them as workflow artifacts. The workflow will only run on limited occasions, one of those being when Twenty Nineteen, Twenty Twenty, or Twenty Twenty-One is edited. These are the themes with build scripts that need to be tested for issues. It can also be manually run through the GitHub Actions UI for occasions when the ZIP files are needed for a release. Props peterwilsoncc, desrosj Fixes #56898. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:14:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:14:02 -0000 Subject: [wp-trac] [WordPress Trac] #56906: Media Library Grid mode no media items shown if debug true In-Reply-To: <050.59e58d91d0ee138a3eae636a0923695e@wordpress.org> References: <050.59e58d91d0ee138a3eae636a0923695e@wordpress.org> Message-ID: <065.b358b233851ab09873a6bf74a9e714a8@wordpress.org> #56906: Media Library Grid mode no media items shown if debug true --------------------------+--------------------- Reporter: ipajen | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Media | Version: 6.0.3 Severity: normal | Resolution: Keywords: php81 | Focuses: --------------------------+--------------------- Changes (by antpb): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:18:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:18:00 -0000 Subject: [wp-trac] [WordPress Trac] #56898: Create a GitHub Action workflow that prepares bundled themes for release In-Reply-To: <051.d5def9a17245633636473ef6a761dc41@wordpress.org> References: <051.d5def9a17245633636473ef6a761dc41@wordpress.org> Message-ID: <066.802f8a5f2dae906d72e9099aa8758640@wordpress.org> #56898: Create a GitHub Action workflow that prepares bundled themes for release ------------------------------+---------------------- Reporter: desrosj | Owner: desrosj Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ------------------------------+---------------------- Comment (by desrosj): This does not need to be backported. The workflow can be manually triggered in the the GitHub Actions UI and accepts a `branch`, which will allow the themes to be bundled for the 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:26:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:26:37 -0000 Subject: [wp-trac] [WordPress Trac] #56761: When editing a thumbnail, wordpress creates a black bottom 1px line on the thumbnail In-Reply-To: <052.4c99281b92fa3a098033fe24982191cf@wordpress.org> References: <052.4c99281b92fa3a098033fe24982191cf@wordpress.org> Message-ID: <067.f4f5f7e93a9bf6e49c58655e760ac9e9@wordpress.org> #56761: When editing a thumbnail, wordpress creates a black bottom 1px line on the thumbnail -------------------------------+------------------------------ Reporter: stratboy | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by antpb): * keywords: => reporter-feedback Comment: Hi @stratboy ! Would it be possible to share the original image that you were using when you noticed this? It would help a lot knowing we're working off of the same image to reproduce the bug. Also helpful would be sharing the dimensions of the crop you are attempting when the line is added. If you also know if your environment is using GD or Imagick that would be bonus points. :) Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:33:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:33:03 -0000 Subject: [wp-trac] [WordPress Trac] #56588: WordPress puts "loading=lazy" on first image on archive page - wp_get_loading_attr_default bug In-Reply-To: <058.9f927cad5e70007d9454f4ee88305f1e@wordpress.org> References: <058.9f927cad5e70007d9454f4ee88305f1e@wordpress.org> Message-ID: <073.9bad46ff76e1c680c913e180a02789a4@wordpress.org> #56588: WordPress puts "loading=lazy" on first image on archive page - wp_get_loading_attr_default bug ----------------------------+--------------------- Reporter: salvoaranzulla | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Media | Version: 6.0.2 Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+--------------------- Changes (by antpb): * milestone: Awaiting Review => 6.2 Comment: Thanks for the ticket @salvoaranzulla ! It looks like some work toward fixing this was landed in 5.9: https://core.trac.wordpress.org/ticket/53675 It is possible this edge case was not identified in the scope of that ticket. Moving to 6.2 to investigate. cc @flixos90 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:36:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:36:31 -0000 Subject: [wp-trac] [WordPress Trac] #56344: Filters for Sharpening Images In-Reply-To: <056.c97e74b8724a3e4e202b26789d5c211d@wordpress.org> References: <056.c97e74b8724a3e4e202b26789d5c211d@wordpress.org> Message-ID: <071.cde573f1e79a14b651093b35722d7862@wordpress.org> #56344: Filters for Sharpening Images -----------------------------+--------------------- Reporter: unsalkorkmaz | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 6.2 Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+--------------------- Changes (by antpb): * milestone: Awaiting Review => 6.2 Comment: Moving to 6.2. This change seems minimally impacting so it should be no problem to let those values be adjusted. @joedolson mentioned in the recent Media meeting that we should investigate having an array of all values like compression level, filter, strategy, unsharp settings, etc. that can be filtered. If any values are missing, just use defaults. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:43:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:43:29 -0000 Subject: [wp-trac] [WordPress Trac] #56260: In case of missing primary key on wp_posts, Media uploader gives false feedback indicating folder permissions are missing, where in fact database structure is malformed. In-Reply-To: <053.6c432f1daa68071a08e3e4233c27bac2@wordpress.org> References: <053.6c432f1daa68071a08e3e4233c27bac2@wordpress.org> Message-ID: <068.93dc588c502dbafd7a1783c9e68d6a81@wordpress.org> #56260: In case of missing primary key on wp_posts, Media uploader gives false feedback indicating folder permissions are missing, where in fact database structure is malformed. --------------------------+------------------------------ Reporter: harryfear | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Database | Version: Severity: minor | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by antpb): * component: Media => Database Comment: It seems this has bigger problems outside of media if the database is broken in this way. It may be an issue with the repair logic not catching the missing primary key. Moving this to Database to ensure the right folks to verify can have visibility. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:44:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:44:59 -0000 Subject: [wp-trac] [WordPress Trac] #56170: Bulk delete media attachments doesn't pass integer values to wp_delete_attachment In-Reply-To: <053.f77d7898a44212a7888f3433150d46ac@wordpress.org> References: <053.f77d7898a44212a7888f3433150d46ac@wordpress.org> Message-ID: <068.61ce7c0fb177ffe7a4829a8ed2e8500b@wordpress.org> #56170: Bulk delete media attachments doesn't pass integer values to wp_delete_attachment -----------------------------------+----------------------------- Reporter: eherman24 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch 2nd-opinion | Focuses: administration -----------------------------------+----------------------------- Changes (by antpb): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:51:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:51:50 -0000 Subject: [wp-trac] [WordPress Trac] #55150: `_wp_attachment_backup_sizes` meta is not deleted when image is restored and IMAGE_EDIT_OVERWRITE is defined In-Reply-To: <050.4ca5475821e7c06002a62aeed3b8a188@wordpress.org> References: <050.4ca5475821e7c06002a62aeed3b8a188@wordpress.org> Message-ID: <065.4e504b2004e1c4b481e029c8ba657288@wordpress.org> #55150: `_wp_attachment_backup_sizes` meta is not deleted when image is restored and IMAGE_EDIT_OVERWRITE is defined -------------------------+-------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: performance -------------------------+-------------------------- Changes (by antpb): * milestone: Awaiting Review => 6.2 Comment: Moving to 6.2 to investigate. Thank you for the clear reproduction steps! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 15:53:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 15:53:01 -0000 Subject: [wp-trac] [WordPress Trac] #55150: `_wp_attachment_backup_sizes` meta is not deleted when image is restored and IMAGE_EDIT_OVERWRITE is defined In-Reply-To: <050.4ca5475821e7c06002a62aeed3b8a188@wordpress.org> References: <050.4ca5475821e7c06002a62aeed3b8a188@wordpress.org> Message-ID: <065.bb9460b2ee064fae63bd3c1854d6ae71@wordpress.org> #55150: `_wp_attachment_backup_sizes` meta is not deleted when image is restored and IMAGE_EDIT_OVERWRITE is defined -------------------------+-------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: performance -------------------------+-------------------------- Comment (by antpb): Possibly related: #32171 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 16:07:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 16:07:52 -0000 Subject: [wp-trac] [WordPress Trac] #56915: Global Styles: Not working for third-party blocks In-Reply-To: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> References: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> Message-ID: <074.5303536481b1873166d0644b5ce8114f@wordpress.org> #56915: Global Styles: Not working for third-party blocks -----------------------------+--------------------- Reporter: Bernhard Reiter | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: major | Resolution: Keywords: has-patch | Focuses: css -----------------------------+--------------------- Changes (by davidbaumwald): * priority: normal => high * focuses: => css * severity: normal => major * milestone: Awaiting Review => 6.1 Comment: Moving into the milestone for visibility. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 16:09:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 16:09:33 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.a9029af7d44d6c26800c6488e2341377@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests commit dev-reviewed | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-testing-info has-unit-tests dev-feedback => has- patch has-testing-info has-unit-tests commit dev-reviewed Comment: Looks good! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 17:25:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 17:25:41 -0000 Subject: [wp-trac] [WordPress Trac] #56907: Export Child theme produces corrupt zip file In-Reply-To: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> References: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> Message-ID: <066.a5188222e41032489cec4ed49c8492ad@wordpress.org> #56907: Export Child theme produces corrupt zip file -------------------------------+------------------------------ Reporter: meushar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Export | Version: 6.0.3 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by desrosj): * keywords: reporter-feedback needs-patch => reporter-feedback Comment: Hi @meushar, Could you provide the exact steps you are using to export your child theme that another contributor could use to reproduce? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 18:33:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 18:33:26 -0000 Subject: [wp-trac] [WordPress Trac] #51228: Include support for the AVIF image format In-Reply-To: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> References: <056.1cc1a2af7490e5ea3d580c3bc1ff47ba@wordpress.org> Message-ID: <071.1a1ae1cefa2482bb4a5605b733db5d90@wordpress.org> #51228: Include support for the AVIF image format --------------------------+------------------------------ Reporter: lukefiretoss | Owner: adamsilverstein Type: enhancement | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by adamsilverstein): Thanks for all the additional details @gregbenz - fascinating! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 18:44:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 18:44:11 -0000 Subject: [wp-trac] [WordPress Trac] #56916: Look to the current request to get the URL settings. Message-ID: <050.a93ceaf30c559270b03b7166c618d7d8@wordpress.org> #56916: Look to the current request to get the URL settings. -----------------------------+----------------------------- Reporter: billpg | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- I recently raised a bug stating that it was unclear what the two URL settings were for, suggesting the text be clarified. On reflection, that wasn't really what I wanted. What I really want is for those settings to be unnecessary. When the PHP is invoked, it knows what the current request URL is. If the request is "https://example.com/Rutabaga/TheBestVegetable", then the WordPress URL is "https://example.com/Rutabaga/" and the permalinks and links to comment POST actions can be based on that. If the next day I wire-in a different domain into the same folder of PHP files, then suddenly this new URL is the WordPress URL and all the permalinks are based on that instead. This would have an impact on Multisite. Rather than selecting sub-folders or sub-domains, you'd instead configure a list of URL prefixes for each site. (For example, "a.example" and "www.a.example" goes to site A. "example.com/b" goes to site B.) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 19:15:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 19:15:59 -0000 Subject: [wp-trac] [WordPress Trac] #40822: Addressing Proximity in the admin area In-Reply-To: <055.2cbb90d91bec8cae72f284b36c188e37@wordpress.org> References: <055.2cbb90d91bec8cae72f284b36c188e37@wordpress.org> Message-ID: <070.a3ed644f60361c0bec12bc370cef0b4e@wordpress.org> #40822: Addressing Proximity in the admin area -------------------------------------------------+------------------------- Reporter: trishasalas | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: Future | Release Component: Administration | Version: Severity: normal | Resolution: Keywords: a11y-task has-screenshots a11y- | Focuses: ui, proximity good-first-bug has-patch | accessibility -------------------------------------------------+------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 19:31:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 19:31:15 -0000 Subject: [wp-trac] [WordPress Trac] #44441: Remove the settings for image dimensions from Settings => Media In-Reply-To: <050.34fd22b977e14ced77201b12bfc3dcdd@wordpress.org> References: <050.34fd22b977e14ced77201b12bfc3dcdd@wordpress.org> Message-ID: <065.31a7145a532c113d2663a7f744b22d26@wordpress.org> #44441: Remove the settings for image dimensions from Settings => Media -------------------------+----------------------------- Reporter: azaozz | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+----------------------------- Comment (by azaozz): @johnregan3 Thanks for the patch! It is a good start but I imagined the UI to remove/reset the custom image sub-sizes to be a bit more. Thinking the "Reset the custom image sizes" UI should start with a nice, longer explanation why these sizes are not useful any more. Mention that: - All browsers now use `srcset` and determine the appropriate image size automatically for the device and screen size of the website visitor. - Themes and plugins will work better on different devices with the default image sizes, not unexpected sizes. Probably expand a little on these points, etc. Then it should list only the sizes that have been changed (and maybe show the defaults?). Perhaps something like: {{{ Thumbnail: default size 150x150 pixels, current size: 238x462 pixels. Medium: default size 300x200 pixels, current size: 1280x720 pixels. [Reset to default sizes] }}} Also, a bit on-the-fence whether this settings screen should include a way for the user to set a custom image size (only one is enough imho). This can be treated as UI back-compat, and may be useful in some cases, but perhaps would be better to be added by a simple canonical plugin (see https://make.wordpress.org/core/2022/09/11/canonical-plugins-revisited/). Such plugin can also list all currently defined sizes (just list, not allow editing). More opinions/use cases/ideas welcome :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 20:06:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 20:06:32 -0000 Subject: [wp-trac] [WordPress Trac] #55955: Setting a 'NOT EXISTS' tax query in 'pre_get_posts' action triggers a fatal error in wp-includes/canonical.php In-Reply-To: <052.b0f0bb15f7afd7aea0adbfdd9681d505@wordpress.org> References: <052.b0f0bb15f7afd7aea0adbfdd9681d505@wordpress.org> Message-ID: <067.be91f3fc02c44adfa3608677905a02aa@wordpress.org> #55955: Setting a 'NOT EXISTS' tax query in 'pre_get_posts' action triggers a fatal error in wp-includes/canonical.php -------------------------------------------+------------------------------ Reporter: codesdnc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Canonical | Version: 6.0 Severity: normal | Resolution: Keywords: php8 has-patch has-unit-tests | Focuses: -------------------------------------------+------------------------------ Comment (by kadamwhite): We ran into this one while upgrading a site to PHP 8 today, thank you @codesdnc for the clear ticket! It saved us a lot of time understanding why the feeds were failing. I paired up with @miguelaxcar to debug this and create the linked PR. I'm not certain whether there's a better way to set up the global `$wp_query` than in the unit test I added, but when we tried manipulating the global query directly the change didn't seem to trigger the error. We validated locally by setting `LOCAL_PHP=8.0-fpm` in our `.env` file when running unit tests. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 20:38:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 20:38:49 -0000 Subject: [wp-trac] [WordPress Trac] #53532: Twenty Twenty-One: Dark Mode causes flicker (light to dark) when reloading (was: Twenty Twenty-One: On 5.8-beta4-51244 Dark Mode causing colour to flicker (light-mode to darkmode) when reloading) In-Reply-To: <059.c29fed3e90b8f926fd0136037c50b829@wordpress.org> References: <059.c29fed3e90b8f926fd0136037c50b829@wordpress.org> Message-ID: <074.8468ec095758c610de94d3d4fb7d34f7@wordpress.org> #53532: Twenty Twenty-One: Dark Mode causes flicker (light to dark) when reloading -----------------------------+----------------------------- Reporter: alanjacobmathew | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: -----------------------------+----------------------------- Changes (by sabernhardt): * milestone: Awaiting Review => Future Release -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Oct 26 20:59:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 26 Oct 2022 20:59:22 -0000 Subject: [wp-trac] [WordPress Trac] #47925: Twenty Nineteen: Size of style.css seems excessively large (225% as large as the next largest theme's CSS) In-Reply-To: <055.c7cb8d6c019e9c9fc011552cdb8049e5@wordpress.org> References: <055.c7cb8d6c019e9c9fc011552cdb8049e5@wordpress.org> Message-ID: <070.e420a0645b506676bdbee00084d1301d@wordpress.org> #47925: Twenty Nineteen: Size of style.css seems excessively large (225% as large as the next largest theme's CSS) ---------------------------+------------------------------- Reporter: westonruter | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Bundled Theme | Version: 5.0 Severity: normal | Resolution: Keywords: needs-patch | Focuses: css, performance ---------------------------+------------------------------- Changes (by sabernhardt): * keywords: => needs-patch * focuses: performance => css, performance * type: defect (bug) => enhancement * milestone: Awaiting Review => Future Release -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 02:59:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 02:59:49 -0000 Subject: [wp-trac] [WordPress Trac] #56907: Export Child theme produces corrupt zip file In-Reply-To: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> References: <051.90c79936c8d326423d91d1515519d09a@wordpress.org> Message-ID: <066.2280471be05a485e76d8f627db44caf4@wordpress.org> #56907: Export Child theme produces corrupt zip file -------------------------------+------------------------------ Reporter: meushar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Export | Version: 6.0.3 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by meushar): Thanks for the reply. I have theme twentytwentytwo-child active. I use menu appearance->editor->site then click on the 3 dots on the right- hand side of the page and select 'export'. The zip file gets produced, which is corrupted. I also tried menu appearance->editor->template->home then click on the 3 dots on the right-hand side of the page and select 'export'. The zip file gets produced, which is corrupted. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 05:44:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 05:44:22 -0000 Subject: [wp-trac] [WordPress Trac] #56902: Twenty Twenty Three: Tag and category template creation for specific items are wrongly displayed as not found despite being successfully created In-Reply-To: <051.d0c4ccd6b48f2f8dd687ff738650e791@wordpress.org> References: <051.d0c4ccd6b48f2f8dd687ff738650e791@wordpress.org> Message-ID: <066.161844e7e4b312c6b63eedf33b867004@wordpress.org> #56902: Twenty Twenty Three: Tag and category template creation for specific items are wrongly displayed as not found despite being successfully created -------------------------------------------+------------------------------ Reporter: franz00 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: has-screenshots needs-testing | Focuses: -------------------------------------------+------------------------------ Comment (by franz00): Update: the problem still persist on the 6.1 rc3. Here's the reference gif image. [https://imgur.com/a/bcgRIkS] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 06:42:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 06:42:41 -0000 Subject: [wp-trac] [WordPress Trac] #56917: Block menu editor Message-ID: <053.3f459a6e70acdca7afbb42db0787eedd@wordpress.org> #56917: Block menu editor -------------------------+----------------------------- Reporter: capbussat | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.1 Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- I would suggest an enhancement in the post editor while editing link menus some context help should appear when you hover the mouse on the links. Also, I would like to have a way to revert to the classic menu editor. For the moment it seems a lot more faster and functional to work with it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 07:25:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 07:25:03 -0000 Subject: [wp-trac] [WordPress Trac] #56917: Block menu editor In-Reply-To: <053.3f459a6e70acdca7afbb42db0787eedd@wordpress.org> References: <053.3f459a6e70acdca7afbb42db0787eedd@wordpress.org> Message-ID: <068.580e7b81e61aefafbe9d25466b5281ec@wordpress.org> #56917: Block menu editor -------------------------------+------------------------------ Reporter: capbussat | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by costdev): * keywords: => reporter-feedback * version: 6.1 => Comment: Hi @capbussat, welcome to Trac! Editor enhancements are handled in the Gutenberg GitHub repository. Take a look at [https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+block+label%3A%22%5BBlock%5D+Navigation%22+label%3A%22%5BBlock%5D+Navigation+Link%22+ open issues for the Navigation/Navigation Link blocks]. You can also [https://github.com/WordPress/gutenberg/issues/new?assignees=&labels=&template=Feature_request.md open a new feature request] if none of these address your suggestion. If you find any existing issue(s), or create a new issue, please drop links into a comment here to help others join the discussion! 🙂 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 08:42:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 08:42:47 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working Message-ID: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> #56918: more tag not working --------------------------+----------------------------- Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hi I tried all default themes and some commercial themes but when a more tag is added to the content of a post or page in the default editor it is not showing the readmore link anymore. Did something change? Her is the html i am using. This content is before the more tag. Right after this sentence should be a "continue reading" button of some sort on list pages of themes that show full content. It won't show on single pages or on themes showing excerpts. And this content is after the more tag. (which should be the anchor link for when the button is clicked) Please advice. Thank you -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 08:48:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 08:48:24 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working In-Reply-To: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> References: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> Message-ID: <066.7c6e8a6c5e0f2c8efec2bb989e2090a2@wordpress.org> #56918: more tag not working --------------------------+------------------------------ Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by BackuPs): Also tried it in gutenberg with default 20-22 theme but is also does not work. What am i missing here? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 10:30:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 10:30:13 -0000 Subject: [wp-trac] [WordPress Trac] #56919: REST API term embed 401 - not allowed to view terms for this post Message-ID: <052.fd158ab8189e776eedb85f16aca5c94d@wordpress.org> #56919: REST API term embed 401 - not allowed to view terms for this post --------------------------+----------------------------- Reporter: prionkor | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: blocker | Keywords: Focuses: | --------------------------+----------------------------- Setup 1. WP 6.0.3 2. CPT attached with multiple taxonomies all of them registered as `show_in_rest` `true` When calling `GET` at CPT rest endpoint with `&embed=1` the path `_embedded.wp:term` returns 401 json object with error message `Sorry, you are not allowed to view terms for this post`. This issue is breaking my applications and I had to rollback to `6.0.2` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 12:11:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 12:11:04 -0000 Subject: [wp-trac] [WordPress Trac] #56920: Illogical placement link to shortcuts in comments help section. Message-ID: <053.e3526365d40ac787c1579dd102595751@wordpress.org> #56920: Illogical placement link to shortcuts in comments help section. --------------------------------------+----------------------------- Reporter: NekoJonez | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: ui, docs, administration | --------------------------------------+----------------------------- At the moment, there is a shortcut to the help section in the comments that leads to this page: https://wordpress.org/support/article/keyboard- shortcuts/ When you read this, it starts with explanation about other shortcuts that are also handy in the editor and such. This might be confusing since it even says "editor shortcuts". That leads me to do a quick thinking exercise where I think we should split this page into two somewhat... Where the usual shortcuts of the editor are also mentioned and those can maybe added to the help section of posts/pages? Or make it a bit more clear...? Or am I overthinking things here? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 12:11:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 12:11:32 -0000 Subject: [wp-trac] [WordPress Trac] #56920: Illogical placement link to shortcuts in comments help section. In-Reply-To: <053.e3526365d40ac787c1579dd102595751@wordpress.org> References: <053.e3526365d40ac787c1579dd102595751@wordpress.org> Message-ID: <068.14e9fdb207ac70798e369100d553e46b@wordpress.org> #56920: Illogical placement link to shortcuts in comments help section. -------------------------+--------------------------------------- Reporter: NekoJonez | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, docs, administration -------------------------+--------------------------------------- Changes (by NekoJonez): * component: General => Help/About -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 12:33:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 12:33:41 -0000 Subject: [wp-trac] [WordPress Trac] #56921: Inconsistency in help tab & small typo Message-ID: <053.205e549175043cd8235274e7ed31b210@wordpress.org> #56921: Inconsistency in help tab & small typo --------------------------------------+----------------------------- Reporter: NekoJonez | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Text Changes | Version: Severity: normal | Keywords: Focuses: ui, docs, administration | --------------------------------------+----------------------------- Some texts in the help tab are a bit inconsistent. In the post help tab, in one sentence we use two different things for "post list". I also found a string where I felt that in an automatic mail sent when deleting your website/account, a word was missing. Also, I find it a bit strange that for auto updates we use "Learn more:" in front of the link while all other things in the help tab don't have that. So, I want to make that a bit more consistent. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 13:25:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 13:25:54 -0000 Subject: [wp-trac] [WordPress Trac] #56921: Inconsistency in help tab & small typo In-Reply-To: <053.205e549175043cd8235274e7ed31b210@wordpress.org> References: <053.205e549175043cd8235274e7ed31b210@wordpress.org> Message-ID: <068.f3b7d98d02dfa388378da15b244534ac@wordpress.org> #56921: Inconsistency in help tab & small typo --------------------------+--------------------------------------- Reporter: NekoJonez | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Text Changes | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, docs, administration --------------------------+--------------------------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 13:33:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 13:33:31 -0000 Subject: [wp-trac] [WordPress Trac] #56920: Illogical placement link to shortcuts in comments help section. In-Reply-To: <053.e3526365d40ac787c1579dd102595751@wordpress.org> References: <053.e3526365d40ac787c1579dd102595751@wordpress.org> Message-ID: <068.5a1944a25df329f2c3444c1e1bcdbb3b@wordpress.org> #56920: Illogical placement link to shortcuts in comments help section. -------------------------+--------------------------------------- Reporter: NekoJonez | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, docs, administration -------------------------+--------------------------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.2 Comment: Thanks for the ticket! Maybe linking directly to the [https://wordpress.org/support/article /keyboard-shortcuts/#keyboard-shortcuts-for-comments Keyboard Shortcuts for Comments] section would help? Just noting that the same link also exists on Edit User screen, next to the "Enable keyboard shortcuts for comment moderation" option, and would need to be updated there as well. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 13:38:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 13:38:08 -0000 Subject: [wp-trac] [WordPress Trac] #56920: Illogical placement link to shortcuts in comments help section. In-Reply-To: <053.e3526365d40ac787c1579dd102595751@wordpress.org> References: <053.e3526365d40ac787c1579dd102595751@wordpress.org> Message-ID: <068.d8f884a4149ce488e9a6b9ae3b61e5b5@wordpress.org> #56920: Illogical placement link to shortcuts in comments help section. -------------------------+--------------------------------------- Reporter: NekoJonez | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Help/About | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, docs, administration -------------------------+--------------------------------------- Comment (by NekoJonez): Replying to [comment:2 SergeyBiryukov]: > Thanks for the ticket! > > Maybe linking directly to the [https://wordpress.org/support/article /keyboard-shortcuts/#keyboard-shortcuts-for-comments Keyboard Shortcuts for Comments] section would help? > > Just noting that the same link also exists on Edit User screen, next to the "Enable keyboard shortcuts for comment moderation" option, and would need to be updated there as well. That's an excellent idea I think! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 13:45:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 13:45:17 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.0d47ad832de82b9c4fd0c06aaf4d650e@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests commit dev-reviewed | -------------------------------------------------+------------------------- Comment (by desrosj): In [changeset:"54700" 54700]: {{{ #!CommitTicketReference repository="" revision="54700" Docs: Add a `@since` note for `object-fit` support in `safecss_filter_attr()`. Follow-up to [54675]. Props peterwilsoncc, SergeyBiryukov, davidbaumwald. Merges [54698] to the 6.1 branch. See #56855. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 13:45:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 13:45:40 -0000 Subject: [wp-trac] [WordPress Trac] #56855: Featured Image bug in 6.0.3 In-Reply-To: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> References: <053.1e8eae15cc6b2913b91a99af03fa86e5@wordpress.org> Message-ID: <068.6aab0fbc478fef89693157be8083c3c3@wordpress.org> #56855: Featured Image bug in 6.0.3 -------------------------------------------------+------------------------- Reporter: raduiason | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Media | Version: 6.0.3 Severity: minor | Resolution: Keywords: has-patch has-testing-info has- | Focuses: unit-tests fixed-major | -------------------------------------------------+------------------------- Changes (by desrosj): * keywords: has-patch has-testing-info has-unit-tests commit dev-reviewed => has-patch has-testing-info has-unit-tests fixed-major Comment: Resetting action-based keywords, and adding `fixed-major` to indicate this needs further backporting. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 14:33:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 14:33:54 -0000 Subject: [wp-trac] [WordPress Trac] #56915: Global Styles: Not working for third-party blocks In-Reply-To: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> References: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> Message-ID: <074.2929d2e48df833fa86eea6c56f90c5db@wordpress.org> #56915: Global Styles: Not working for third-party blocks -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: major | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: css testing-instructions commit | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: has-patch => has-patch has-unit-tests has-testing-instructions commit Comment: * Integration tests added to the PR ✅ * Expected tests fail without the bugfix patch ✅ * Tests pass with the bugfix patch ✅ * PR code LGTM 👍 Given that this bugfix was already released in Gutenberg, there are multiple manual test reports, integration tests are working as expected, and the PR's code is approved, marking for `commit` to `trunk`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 14:38:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 14:38:32 -0000 Subject: [wp-trac] [WordPress Trac] #56900: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles call to WP_Query incorrect. In-Reply-To: <057.9b97203b23844a6f5245fd9d3ca2cb08@wordpress.org> References: <057.9b97203b23844a6f5245fd9d3ca2cb08@wordpress.org> Message-ID: <072.af284501f292877ace725c9e885e795b@wordpress.org> #56900: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles call to WP_Query incorrect. ---------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Themes | Version: 6.1 Severity: minor | Resolution: Keywords: has-patch | Focuses: ---------------------------+--------------------- Changes (by johnbillion): * keywords: needs-patch => has-patch * milestone: Awaiting Review => 6.1.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 14:54:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 14:54:32 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.7cb67c18355fb1e5a96dd5d3f95b4d0b@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. --------------------------------------+--------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by hellofromTonya): * milestone: Awaiting Review => 6.1 Comment: For historical context, the caching logic was added in [52275] and improvements in [54186]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:01:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:01:46 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.c7d484577e3c836b21ec233b99aa6f3b@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54701" 54701]: {{{ #!CommitTicketReference repository="" revision="54701" Tests: Move `wp_handle_comment_submission()` tests to the `comment` directory. This aims to bring some consistency with other comment function tests. Includes moving the `@covers` tags from individual test methods to the class DocBlock. Follow-up to [34799], [34801], [53863]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:03:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:03:36 -0000 Subject: [wp-trac] [WordPress Trac] #55955: Setting a 'NOT EXISTS' tax query in 'pre_get_posts' action triggers a fatal error in wp-includes/canonical.php In-Reply-To: <052.b0f0bb15f7afd7aea0adbfdd9681d505@wordpress.org> References: <052.b0f0bb15f7afd7aea0adbfdd9681d505@wordpress.org> Message-ID: <067.c1f6807afd48cef90c88ce7d0a8406c7@wordpress.org> #55955: Setting a 'NOT EXISTS' tax query in 'pre_get_posts' action triggers a fatal error in wp-includes/canonical.php -------------------------------------------+--------------------- Reporter: codesdnc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Canonical | Version: 6.0 Severity: normal | Resolution: Keywords: php8 has-patch has-unit-tests | Focuses: -------------------------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.1.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:22:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:22:01 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.496c0d9a809663ed877784bad8a1923f@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54702" 54702]: {{{ #!CommitTicketReference repository="" revision="54702" Tests: Move `wp_mail()` tests to the `pluggable` directory. This aims to bring some consistency with other pluggable function tests. Includes moving the `@covers` tag from a single test method to the class DocBlock. Follow-up to [221/tests], [909/tests], [54529]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:26:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:26:24 -0000 Subject: [wp-trac] [WordPress Trac] #55955: Setting a 'NOT EXISTS' tax query in 'pre_get_posts' action triggers a fatal error in wp-includes/canonical.php In-Reply-To: <052.b0f0bb15f7afd7aea0adbfdd9681d505@wordpress.org> References: <052.b0f0bb15f7afd7aea0adbfdd9681d505@wordpress.org> Message-ID: <067.bbe586a1b0881381aefd288737b21727@wordpress.org> #55955: Setting a 'NOT EXISTS' tax query in 'pre_get_posts' action triggers a fatal error in wp-includes/canonical.php -------------------------------------------+--------------------- Reporter: codesdnc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Canonical | Version: 6.0 Severity: normal | Resolution: Keywords: php8 has-patch has-unit-tests | Focuses: -------------------------------------------+--------------------- Comment (by kadamwhite): For anybody running into this between now and when the patch goes live, we've worked around it in our application by passing {{{#!php array( 0 ), }}} within the tax_query array. Looking at how NOT EXISTS queries get parsed, it seems like this terms parameter is not used at all, so it seems to mitigate the PHP8 fatal without compromising application logic... -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:30:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:30:12 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.077f9986cc493d2c233ae30909e11c71@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: testing-info | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: has-patch has-unit-tests => has-patch has-unit-tests has- testing-info Comment: == Testing Instructions === Steps to Reproduce * Use Twenty Twenty Two (TT2) theme * Use WordPress 6.0.3 * Log into the admin area * Go to Appearance > Editor * Open the Global Styles UI * Select "Browse Styles" * Select the red styling * Select "Save" to save the new global styles * Go back to the Dashboard * Go to Tools > Export * Click on "Download Export File" using "All content" * Using another local site, upgrade to WordPress 6.1-RC3 * Log into the admin area * Go to Tools > Import * Select "Install Now" for the "WordPress" importer * Select "Run Importer" * Select the XML file using "Choose File" * Click on the "Upload file and import" button * View site in the frontend The 🐞 bug occurs when viewing on the frontend as the site does not use the red styling. === Expected behavior: When viewing the site in the frontend, the site should use the red styling, i.e meaning the imported global styles are used. === Expected Results When testing a patch to validate it works as expected: - ✅ What should happen when running the test When reproducing a bug: - ❌ Error condition occurs. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:34:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:34:13 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.3adf1c8c4513260f360fa63e42149260@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: testing-info | -------------------------------------------------+------------------------- Comment (by hellofromTonya): = Test Report == Environment * Server: nginx * WordPress: 6.0.3 for generating xml and then 6.1-RC3 for testing import * Localhost: WP Local * OS: macOS * Browser: Chrome and Firefox * Theme: TT2 * Plugins: WordPress Importer == Steps to Reproduce See the [#comment:9 Testing Instructions]. == Results Patch: https://github.com/WordPress/wordpress-develop/pull/3517 Without the patch, can reproduce the issue ✅ With the patch, the issue is resolved ✅ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:39:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:39:34 -0000 Subject: [wp-trac] [WordPress Trac] #56915: Global Styles: Not working for third-party blocks In-Reply-To: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> References: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> Message-ID: <074.6f01b3d64d78b2eff3c789ae704007e9@wordpress.org> #56915: Global Styles: Not working for third-party blocks -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: high | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: major | Resolution: fixed Keywords: has-patch has-unit-tests has- | Focuses: css testing-instructions commit | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * owner: (none) => davidbaumwald * status: new => closed * resolution: => fixed Comment: In [changeset:"54703" 54703]: {{{ #!CommitTicketReference repository="" revision="54703" Editor: Ensure global styles are rendered for third-party blocks. This change ensures custom styles for all third-party blocks are rendered on the front end if assets are set to be loaded on a per-block basis. Additionally, this change includes new unit tests to help prevent a similar bug in the future. Props scruffian, aristath, poena, wildworks, ajlende, andraganescu, ndiego, gigitux, cbravobernal, ramonopoly, andrewserong, oandregal, hellofromTonya, bernhard-reiter. Fixes #56915. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:40:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:40:40 -0000 Subject: [wp-trac] [WordPress Trac] #56915: Global Styles: Not working for third-party blocks In-Reply-To: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> References: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> Message-ID: <074.28fdb337492ceb82d2d15e8546e2da10@wordpress.org> #56915: Global Styles: Not working for third-party blocks -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: major | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: css testing-instructions commit dev-feedback | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-unit-tests has-testing-instructions commit => has-patch has-unit-tests has-testing-instructions commit dev-feedback * status: closed => reopened * resolution: fixed => Comment: Reopening for backport to the 6.1 branch pending a second committer's review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:42:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:42:14 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.ec03eee736beebc85165159bfb56bf9c@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: testing-info | -------------------------------------------------+------------------------- Comment (by hellofromTonya): = Follow-up Test Report Does it happen on WP 6.0.3? == Environment * Server: nginx * WordPress: 6.0.3 * Localhost: WP Local * OS: macOS * Browser: Chrome and Firefox * Theme: TT2 * Plugins: WordPress Importer == Steps to Reproduce See the [#comment:9 Testing Instructions] expect the importer site is using WP 6.0.3 instead of 6.1-RC3. == Results No, the bug does not happen on 6.0.3. == Conclusion This regression was introduced in the WP 6.1 cycle. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:52:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:52:18 -0000 Subject: [wp-trac] [WordPress Trac] #56915: Global Styles: Not working for third-party blocks In-Reply-To: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> References: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> Message-ID: <074.e68d7044105e2b6c11bff13adb14c1ac@wordpress.org> #56915: Global Styles: Not working for third-party blocks -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: major | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: css testing-instructions commit dev-reviewed | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: has-patch has-unit-tests has-testing-instructions commit dev- feedback => has-patch has-unit-tests has-testing-instructions commit dev-reviewed Comment: [54703] is ready for backport to 6.1 branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:53:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:53:23 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.9f3b1281c74617a8a9c708fc13660903@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54704" 54704]: {{{ #!CommitTicketReference repository="" revision="54704" Tests: Rename classes in `phpunit/tests/comment/` per the naming conventions. https://make.wordpress.org/core/handbook/testing/automated-testing /writing-phpunit-tests/#naming-and-organization Follow-up to [47780], [48911], [49327], [50291], [50292], [50342], [50452], [50453], [50456], [50967], [50968], [50969], [51491], [51492], [51493], [51623], [51639], [51646], [51650], [51651], [51860], [52264], [52265], [53489], [53863]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:56:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:56:27 -0000 Subject: [wp-trac] [WordPress Trac] #56915: Global Styles: Not working for third-party blocks In-Reply-To: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> References: <059.209353a3284ed0560ba89d663fefc1a3@wordpress.org> Message-ID: <074.1eccdb9bd0842e681292d7e5f601b3b6@wordpress.org> #56915: Global Styles: Not working for third-party blocks -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: high | Milestone: 6.1 Component: Editor | Version: 6.1 Severity: major | Resolution: fixed Keywords: has-patch has-unit-tests has- | Focuses: css testing-instructions commit dev-reviewed | -------------------------------------------------+------------------------- Changes (by Bernhard Reiter): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54705" 54705]: {{{ #!CommitTicketReference repository="" revision="54705" Editor: Ensure global styles are rendered for third-party blocks. This change ensures custom styles for all third-party blocks are rendered on the front end if assets are set to be loaded on a per-block basis. Additionally, this change includes new unit tests to help prevent a similar bug in the future. Props scruffian, aristath, poena, wildworks, ajlende, andraganescu, ndiego, gigitux, cbravobernal, ramonopoly, andrewserong, oandregal, hellofromTonya, davidbaumwald. Merges [54703] to the 6.1 branch. Fixes #56915. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 15:56:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 15:56:43 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.a7c6612471a7b23b0402adb8853b3126@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: testing-info commit | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: has-patch has-unit-tests has-testing-info => has-patch has- unit-tests has-testing-info commit Comment: Status: * Confirmed this is a regression introduced in the WP 6.1 cycle ✅ * Able to reproduce ✅ *[https://github.com/WordPress/wordpress-develop/pull/3517 PR 3517] resolves the issue ✅ * PR approved ✅ Marking for `commit`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 16:13:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 16:13:37 -0000 Subject: [wp-trac] [WordPress Trac] #54542: Update link in grey section box in themes directory In-Reply-To: <054.d8199e3c994a8b1f8e2af27bd6326e1f@wordpress.org> References: <054.d8199e3c994a8b1f8e2af27bd6326e1f@wordpress.org> Message-ID: <069.17b2c6317d6235725683f9d34eee6800@wordpress.org> #54542: Update link in grey section box in themes directory --------------------------------+-------------------------------- Reporter: dansoschin | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: WordPress.org Site | Version: Severity: trivial | Resolution: reported-upstream Keywords: | Focuses: --------------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: I moved it :) https://meta.trac.wordpress.org/ticket/6552 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 16:15:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 16:15:21 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working In-Reply-To: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> References: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> Message-ID: <066.9f974042664b64591a547d2c3ac81735@wordpress.org> #56918: more tag not working --------------------------+------------------------------ Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by joyously): ''I wrote the clarification on that classic test content.'' Are you saying that your theme is showing full content on the archive page, and you are not seeing the `More` link? (It never shows on themes showing excerpts.) Or are you saying you don't see the `More` indicator in the editor? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 16:32:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 16:32:57 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.7b6498d22c7124b81398f618c412104f@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests has- | Focuses: testing-info commit | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * owner: (none) => davidbaumwald * status: new => closed * resolution: => fixed Comment: In [changeset:"54706" 54706]: {{{ #!CommitTicketReference repository="" revision="54706" Themes: Ensure custom global styles are imported properly. This change removes caching of global styles for logged in users, allowing "wp_global_styles" custom post type to be imported completely, regardless of any previously cached data. This change now relies on the lower-level native `WP_Query` cache invalidation methods for the global styles post type. Follow-up to [52275], [54186]. Props anariel-design, bernhard-reiter, andrewserong, spacedmonkey, andraganescu, peterwilsoncc, oandregal, hellofromTonya. Fixes #56901. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 16:34:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 16:34:06 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.ee44cded16708886409c14579f730183@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: testing-info commit dev-feedback | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-unit-tests has-testing-info commit => has-patch has-unit-tests has-testing-info commit dev-feedback * status: closed => reopened * resolution: fixed => Comment: Reopening for backport to the 6.1 branch pending a second committer's review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 16:36:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 16:36:04 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.88031d2aa7fd4e80768265139481b4e7@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests has- | Focuses: testing-info commit dev-reviewed | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: has-patch has-unit-tests has-testing-info commit dev-feedback => has-patch has-unit-tests has-testing-info commit dev-reviewed Comment: [54706] looks good for backport to the 6.1-branch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 16:38:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 16:38:11 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.9d79cbf95ddcf7a29da539c8de2353ab@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests has- | Focuses: testing-info commit dev-reviewed | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54707" 54707]: {{{ #!CommitTicketReference repository="" revision="54707" Themes: Ensure custom global styles are imported properly. This change removes caching of global styles for logged in users, allowing "wp_global_styles" custom post type to be imported completely, regardless of any previously cached data. This change now relies on the lower-level native WP_Query cache invalidation methods for the global styles post type. Follow-up to [52275], [54186]. Props anariel-design, bernhard-reiter, andrewserong, spacedmonkey, andraganescu, peterwilsoncc, oandregal, hellofromTonya. Reviewed by hellofromTonya. Merges [54706] to the 6.1 branch. Fixes #56901. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 16:39:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 16:39:22 -0000 Subject: [wp-trac] [WordPress Trac] #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. In-Reply-To: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> References: <057.60ec51ac566b5114ec24811cea1952ee@wordpress.org> Message-ID: <072.43d64ca20842efdd6e8c286d2b5d5f76@wordpress.org> #56901: WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles is incorrectly cached. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests has- | Focuses: testing-info fixed-major | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch has-unit-tests has-testing-info commit dev-reviewed => has-patch has-unit-tests has-testing-info fixed-major Comment: Resetting the keywords after the backport. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 16:39:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 16:39:36 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working In-Reply-To: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> References: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> Message-ID: <066.d1d0ff926bd1443c80c7b1a0b562cdc1@wordpress.org> #56918: more tag not working --------------------------+------------------------------ Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by BackuPs): it shows the complete text and not the more link. We are not using excerpts. Try any of the default wordpress themes with the more tag. It will not work. I see the <-more-> indicator in the editor but in the front (preview) it shows me the complete text and not the read more link to click. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 16:54:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 16:54:26 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working In-Reply-To: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> References: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> Message-ID: <066.a968e2fd200fd8ee1c62f93a3b145eca@wordpress.org> #56918: more tag not working --------------------------+------------------------------ Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by joyously): > Ps in the wordpress reading settings it is set to full text and pot to excerpt. Btw it does not matter what that setting is. It never works. Ah, this is the problem. That setting is for the RSS feed, not the pages you see in the browser. I just tested 6.1 RC3 with a theme that shows full content on archive pages, and the more tag works just fine. A bunch of the themes you mentioned do not show full content on archive pages, so you cannot test the more tag with them. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 17:14:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 17:14:48 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working In-Reply-To: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> References: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> Message-ID: <066.3b7317fc0f8a987fa7f7707bb2c420e7@wordpress.org> #56918: more tag not working --------------------------+------------------------------ Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Old description: > Hi > > I tried all default themes and some commercial themes but when a more tag > is added to the content of a post or page in the default editor it is > not showing the readmore link anymore. > > Did something change? Her is the html i am using. > > This content is before the href="https://en.support.wordpress.com/splitting-content/more-tag/" > target="_blank" rel="noopener">more tag. > > Right after this sentence should be a "continue reading" > button of some sort on list pages of themes that show full content. It > won't show on single pages or on themes showing excerpts. > > > > And this content is after the more tag. (which should be > the anchor link for when the button is clicked) > > Please advice. > > Thank you New description: Hi I tried all default themes and some commercial themes but when a more tag is added to the content of a post or page in the default editor it is not showing the readmore link anymore. Did something change? Her is the html i am using. {{{ This content is before the more tag. Right after this sentence should be a "continue reading" button of some sort on list pages of themes that show full content. It won't show on single pages or on themes showing excerpts. And this content is after the more tag. (which should be the anchor link for when the button is clicked) }}} Please advice. Thank you -- Comment (by SergeyBiryukov): Replying to [comment:4 joyously]: > > Ps in the wordpress reading settings it is set to full text and pot to excerpt. Btw it does not matter what that setting is. It never works. > > Ah, this is the problem. That setting is for the RSS feed, not the pages you see in the browser. Right, the option in Reading Settings only applies to RSS feeds, not to archive pages. This was previously discussed in #22049, #39519, #45752, and some other tickets. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 17:22:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 17:22:08 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working In-Reply-To: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> References: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> Message-ID: <066.7c3f44e5e48a5cf86ea2c796708a41d4@wordpress.org> #56918: more tag not working --------------------------+------------------------------ Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by BackuPs): when i add the given text in my initial comment into a page or post in f.e. the 20-22 theme and view the page or post in the frontend of my website the complete text shows and it shows no more link to click. Did you try this with the 20-22 (20-21,20-20, 20-19) theme? The more tag does not work in any of these themes in normal pages or posts. Please advice. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 17:31:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 17:31:30 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working In-Reply-To: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> References: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> Message-ID: <066.f079c713be2f399208316dc8febb56ae@wordpress.org> #56918: more tag not working --------------------------+------------------------------ Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by joyously): The more tag is only "visible" (as a link to the post) on archive pages of themes that show full content on archive pages. There is nothing visible for the more tag to do in a normal post (pages are unaffected since there is no archive page for pages). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 17:56:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 17:56:31 -0000 Subject: [wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core In-Reply-To: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> References: <059.ed8d8ca142d6493bd9651402f1af6e1c@wordpress.org> Message-ID: <074.d3c61027aa49fb6046863ef0a5ab46ca@wordpress.org> #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core -------------------------------------------------+------------------------- Reporter: Bernhard Reiter | Owner: Bernhard | Reiter Type: task (blessed) | Status: closed Priority: normal | Milestone: 6.1 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests fixed- | Focuses: major | -------------------------------------------------+------------------------- Comment (by flixos90): Replying to [comment:411 scruffian]: > > I would think this logic is pointless to run for classic themes without a theme.json > > One of the changes introduced in 6.1 is that some blocks now load their styles using the __experimentalStyles property in their block.json, as well as from their CSS file. Given that blocks and their styles are loaded for both classic and block themes, it is necessary for us to output these rules into CSS in both types of themes. Hope that makes sense! Thanks for clarifying, that makes sense. However, if for classic themes this is only needed to add those block styles, why are we running all the other logic that is invoked by `wp_add_global_styles_for_blocks()`? I took a bit of time to dive into the `WP_Theme_JSON_Resolver` code, and it does a whole lot of things that appear to only relate to FSE themes without any checks for `theme_has_support()`. For example: * `wp_add_global_styles_for_blocks()` calls `WP_Theme_JSON_Resolver::get_merged_data()`. * From there, it calls `get_core_data()`, `get_block_data()`, `get_theme_data()`, and `get_user_data()`. Based on what you're saying, for a classic theme it would make more sense to only call `get_block_data()`, not the other 3. * By doing that, we would avoid several expensive actions which seem unnecessary for classic themes: * Read, parse, and translate, WP core's own `theme.json` * Load the translation schema even though the theme has no `theme.json` * Run a database query to get global styles Of the above points, the only thing that changes anything in the relevant data is not parsing core's `theme.json`. However, the data in that is not really used for classic themes anyways, so that should also be fine. I've done a first test, and it appears that removing these calls does not result in any missing functionality for classic themes. You can see this issue first-hand in action with Twenty Twenty-One: 1. Set up a site with Twenty Twenty-One. 2. Modify `WP_Theme_JSON_Resolver::get_core_data()` to just set `$config` to an empty array instead of parsing core's `theme.json`. 3. Modify `WP_Theme_JSON::set_spacing_sizes()` to include an `! isset( $spacing_scale['steps'] )` check, since that key may not be present now, to avoid a PHP warning. 4. Inspect the frontend of the site before and after the change. There is no change in any of the CSS included, except that a single CSS rule `:where(.wp-block-columns.is-layout-flex){gap: 2em;}` is now gone. To be fair, I'm a bit unclear why that was there in the first place, since the `is-layout-flex` class is not used anywhere on the page. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 17:58:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 17:58:21 -0000 Subject: [wp-trac] [WordPress Trac] #56922: Template / Template parts revision / autosave REST API are broken Message-ID: <056.7c930ec09aecb25976c71a298bd5a15d@wordpress.org> #56922: Template / Template parts revision / autosave REST API are broken --------------------------+---------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: REST API | Version: Severity: normal | Keywords: Focuses: rest-api | --------------------------+---------------------------- The REST API endpoints for autosave and revisions the template and template part are broken. The URL structure for template and template part are different from other post controllers. Standard post controller. {{{#!php '/' . $this->rest_base . '/(?P[\d]+)', }}} Template / template parts. {{{#!php '/%s/(?P%s%s)', $this->rest_base, // Matches theme's directory: `/themes///` or `/themes//`. // Excludes invalid directory name characters: `/:<>*?"|`. '([^\/:<>\*\?"\|]+(?:\/[^\/:<>\*\?"\|]+)?)', // Matches the template name. '[\/\w-]+' }}} Revision / autosave endpoints expects {{{#!php '/' . $this->parent_base . '/(?P[\d]+)/' . $this->rest_base, }}} Autosave endpoint expects. When doing a request like this. `wp/v2/template-parts/1480/revisions` Results in {{{#!php code : "rest_template_not_found" data : {status: 404} message : "No templates exist with that id." }}} As this post type needs a different url structure, a custom revision / autosave will need to be registered. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 18:09:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 18:09:37 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working In-Reply-To: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> References: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> Message-ID: <066.cd2316677b815c9c46c1edd168c2b019@wordpress.org> #56918: more tag not working --------------------------+------------------------------ Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Changes (by BackuPs): * status: new => closed * resolution: => invalid Comment: i thought it also worked on single posts or pages as a reveal for the text below that point. at least i saw that in one theme. Thank you & Please close. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 18:13:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 18:13:34 -0000 Subject: [wp-trac] [WordPress Trac] #56922: Template / Template parts revision / autosave REST API are broken In-Reply-To: <056.7c930ec09aecb25976c71a298bd5a15d@wordpress.org> References: <056.7c930ec09aecb25976c71a298bd5a15d@wordpress.org> Message-ID: <071.215b7d203d533fe457584063b3635820@wordpress.org> #56922: Template / Template parts revision / autosave REST API are broken --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: REST API | Version: 4.7 Severity: normal | Resolution: Keywords: | Focuses: rest-api --------------------------+----------------------------- Changes (by spacedmonkey): * keywords: has-patch => * version: => 4.7 Comment: I have made a start on a solution that implements custom autosave / revision endpoints. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 20:32:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 20:32:55 -0000 Subject: [wp-trac] [WordPress Trac] #56923: register_block_core_template_part does WP_Query even on themes that do not support it Message-ID: <056.94f7a989274c2b1ea326788efc3823e7@wordpress.org> #56923: register_block_core_template_part does WP_Query even on themes that do not support it --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: trunk Severity: normal | Keywords: Focuses: performance | --------------------------+----------------------------- register_block_core_template_part functions calls, build_template_part_block_variations -> build_template_part_block_instance_variations -> get_block_templates. This calls WP_Query and gets ALL posts of post type `wp_template_part`. This happens on classic themes that do not even support theme parts. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 20:33:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 20:33:42 -0000 Subject: [wp-trac] [WordPress Trac] #56923: register_block_core_template_part does WP_Query even on themes that do not support it In-Reply-To: <056.94f7a989274c2b1ea326788efc3823e7@wordpress.org> References: <056.94f7a989274c2b1ea326788efc3823e7@wordpress.org> Message-ID: <071.5d31db256f9048a9784516915078870f@wordpress.org> #56923: register_block_core_template_part does WP_Query even on themes that do not support it --------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: performance --------------------------+------------------------------ Changes (by spacedmonkey): * Attachment "Screenshot 2022-10-27 at 21.33.20.png" added. Screenshot from 2017 theme. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 21:11:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 21:11:26 -0000 Subject: [wp-trac] [WordPress Trac] #56923: register_block_core_template_part does WP_Query even on themes that do not support it In-Reply-To: <056.94f7a989274c2b1ea326788efc3823e7@wordpress.org> References: <056.94f7a989274c2b1ea326788efc3823e7@wordpress.org> Message-ID: <071.2811b16c99c46188fcbc0b99f213d91e@wordpress.org> #56923: register_block_core_template_part does WP_Query even on themes that do not support it --------------------------+------------------------------ Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: performance --------------------------+------------------------------ Comment (by spacedmonkey): PR here https://github.com/WordPress/gutenberg/pull/45362 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 21:31:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 21:31:36 -0000 Subject: [wp-trac] [WordPress Trac] #56923: register_block_core_template_part does WP_Query even on themes that do not support it In-Reply-To: <056.94f7a989274c2b1ea326788efc3823e7@wordpress.org> References: <056.94f7a989274c2b1ea326788efc3823e7@wordpress.org> Message-ID: <071.0095be42bc77bc0129faa8cccd5cb385@wordpress.org> #56923: register_block_core_template_part does WP_Query even on themes that do not support it --------------------------+-------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: high | Milestone: 6.1.1 Component: Themes | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: performance --------------------------+-------------------------- Changes (by sabernhardt): * keywords: => has-patch * priority: normal => high * milestone: Awaiting Review => 6.1.1 Old description: > register_block_core_template_part functions calls, > build_template_part_block_variations -> > build_template_part_block_instance_variations -> > get_block_templates. > > This calls WP_Query and gets ALL posts of post type `wp_template_part`. > This happens on classic themes that do not even support theme parts. New description: `register_block_core_template_part` functions calls, `build_template_part_block_variations` -> `build_template_part_block_instance_variations` -> `get_block_templates`. This calls `WP_Query` and gets ALL posts of post type `wp_template_part`. This happens on classic themes that do not even support theme parts. -- Comment: Someone from the release squad could move this to the 6.1 milestone, but I can put in the minor. Adding that condition removes the extra query from Twenty Seventeen. The `build_template_part_block_instance_variations()` function was introduced in r54257. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 22:04:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 22:04:53 -0000 Subject: [wp-trac] [WordPress Trac] #55105: Introduce a polyfill for `array_is_list()`. In-Reply-To: <051.b8ae2c08f5ad2c8bbe71037bcf23450d@wordpress.org> References: <051.b8ae2c08f5ad2c8bbe71037bcf23450d@wordpress.org> Message-ID: <066.b0103a2bec3ef912644944198a06e3bb@wordpress.org> #55105: Introduce a polyfill for `array_is_list()`. --------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: minor | Resolution: maybelater Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------- Comment (by johnjamesjacoby): Some random related thoughts... ---- See also: `wp_is_numeric_array()` & `rest_is_array()` for similar but different examples of functions in WordPress that are documented to imply their intention ''may have been'' to mimic the behavior of `array_is_list()` but perhaps a consult from @rmccue would be helpful? The above helper function(s) `@return bool Whether the variable is a list` but do not enforce @costdev's first point: > A **list ''must''** start from an offset of 0 ''(emphasis, mine... but I think I agree?)'' While a bunch of other programming languages explicitly define & strictly enforce "List" and "Array" as different things (C, Java, Python, etc...) neither PHP nor WordPress do currently. ''I think'' that means it is ''safe to suggest'' that WordPress functions named like `wp_parse_list()` and `wp_list_*()` – and the `WP_List_Util()` class – ''largely imply'' that they are ''intended'' to work with either arrays or objects. Similarly, only the REST API (and later the Meta API via default values in `get_metadata_default()`) have experienced a need for identifying whether a variable value was a numerically indexed array that starts with 0 and does not omit any subsequent integers as keys until the final key. ---- Without speculating too deeply, PHP core is trending towards becoming more strict (hence more static), so perhaps someday a "List" could be a more explicitly defined thing, and it may behoove WordPress core contributors to have a plan for that and decide whether to: * Keep down the path of generalized "lists" as arrays or objects * Add to the global namespace `list` functions & classes that mean what `array_is_list()` means -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 22:15:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 22:15:53 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems Message-ID: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems --------------------------+----------------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- In changeset https://core.trac.wordpress.org/changeset/53934/ , this change was made to get_attached_file(): {{{#!diff - $file = $uploads['basedir'] . "/$file"; + $file = path_join( $uploads['basedir'], $file ); }}} Each call to path_join() calls path_is_absolute(), which calls realpath(). Most of the time this is not a problem, as realpath runs very fast, on the order of 0.003 milliseconds. However, if your uploads directory is on an NFS fileshare, I'm seeing calls to realpath() be 1000-2000x slower, or on the order of 2ms-4ms. One call to a 4ms realpath() is not an issue, but get_attached_file() can run on each post in a list in some APIs, causing significant slowdowns. Additionally, the path_join() file can be called on the same file several times in a row, each creating a new call to realpath() without caching or memoizing the results. Rough debugging code: {{{#!diff diff --git a/src/wp-includes/post.php b/src/wp-includes/post.php index a67d7a79a1..f728e80a7a 100644 --- a/src/wp-includes/post.php +++ b/src/wp-includes/post.php @@ -728,7 +728,20 @@ function get_attached_file( $attachment_id, $unfiltered = false ) { $uploads = wp_get_upload_dir(); if ( false === $uploads['error'] ) { + + $url = "http://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]"; + error_log("path join: Called from $url"); + $t1 = microtime( true ); + $file = path_join( $uploads['basedir'], $file ); + + $t2 = microtime( true ); + $e = ( $t2 - $t1 ) * 1000; + error_log("Elasped $e"); + error_log( print_r( [ + $uploads['basedir'], + $file, + ], true ) ); } } }}} Have a site with some posts and some images in those posts. Browse around and look for the calls, for example, while visiting media library. Note that the speeds will appear fast unless there are network-mounted filesystems using NFS being queried. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 22:26:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 22:26:00 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems In-Reply-To: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> References: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> Message-ID: <067.4fcb61269846e99850276b89353082c4@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems --------------------------+--------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by desrosj): * milestone: Awaiting Review => 6.1 Comment: Thanks for the report @mreishus. Moving to the 6.1 milestone to investigate. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Oct 27 23:28:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 27 Oct 2022 23:28:40 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems In-Reply-To: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> References: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> Message-ID: <067.894a1be1ebe4b0777a810c0bf80e28a8@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems --------------------------+--------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Description changed by SergeyBiryukov: Old description: > In changeset https://core.trac.wordpress.org/changeset/53934/ , this > change was made to get_attached_file(): > > {{{#!diff > - $file = $uploads['basedir'] . "/$file"; > + $file = path_join( $uploads['basedir'], $file ); > }}} > > Each call to path_join() calls path_is_absolute(), which calls > realpath(). Most of the time this is not a problem, as realpath runs > very fast, on the order of 0.003 milliseconds. However, if your uploads > directory is on an NFS fileshare, I'm seeing calls to realpath() be > 1000-2000x slower, or on the order of 2ms-4ms. > > One call to a 4ms realpath() is not an issue, but get_attached_file() can > run on each post in a list in some APIs, causing significant slowdowns. > Additionally, the path_join() file can be called on the same file several > times in a row, each creating a new call to realpath() without caching or > memoizing the results. > > Rough debugging code: > > {{{#!diff > diff --git a/src/wp-includes/post.php b/src/wp-includes/post.php > index a67d7a79a1..f728e80a7a 100644 > --- a/src/wp-includes/post.php > +++ b/src/wp-includes/post.php > @@ -728,7 +728,20 @@ function get_attached_file( $attachment_id, > $unfiltered = false ) { > $uploads = wp_get_upload_dir(); > > if ( false === $uploads['error'] ) { > + > + $url = > "http://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]"; > + error_log("path join: Called from $url"); > + $t1 = microtime( true ); > + > $file = path_join( $uploads['basedir'], $file ); > + > + $t2 = microtime( true ); > + $e = ( $t2 - $t1 ) * 1000; > + error_log("Elasped $e"); > + error_log( print_r( [ > + $uploads['basedir'], > + $file, > + ], true ) ); > } > } > }}} > > Have a site with some posts and some images in those posts. Browse around > and look for the calls, for example, while visiting media library. Note > that the speeds will appear fast unless there are network-mounted > filesystems using NFS being queried. New description: In changeset [53934], this change was made to get_attached_file(): {{{#!diff - $file = $uploads['basedir'] . "/$file"; + $file = path_join( $uploads['basedir'], $file ); }}} Each call to path_join() calls path_is_absolute(), which calls realpath(). Most of the time this is not a problem, as realpath runs very fast, on the order of 0.003 milliseconds. However, if your uploads directory is on an NFS fileshare, I'm seeing calls to realpath() be 1000-2000x slower, or on the order of 2ms-4ms. One call to a 4ms realpath() is not an issue, but get_attached_file() can run on each post in a list in some APIs, causing significant slowdowns. Additionally, the path_join() file can be called on the same file several times in a row, each creating a new call to realpath() without caching or memoizing the results. Rough debugging code: {{{#!diff diff --git a/src/wp-includes/post.php b/src/wp-includes/post.php index a67d7a79a1..f728e80a7a 100644 --- a/src/wp-includes/post.php +++ b/src/wp-includes/post.php @@ -728,7 +728,20 @@ function get_attached_file( $attachment_id, $unfiltered = false ) { $uploads = wp_get_upload_dir(); if ( false === $uploads['error'] ) { + + $url = "http://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]"; + error_log("path join: Called from $url"); + $t1 = microtime( true ); + $file = path_join( $uploads['basedir'], $file ); + + $t2 = microtime( true ); + $e = ( $t2 - $t1 ) * 1000; + error_log("Elasped $e"); + error_log( print_r( [ + $uploads['basedir'], + $file, + ], true ) ); } } }}} Have a site with some posts and some images in those posts. Browse around and look for the calls, for example, while visiting media library. Note that the speeds will appear fast unless there are network-mounted filesystems using NFS being queried. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 01:24:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 01:24:44 -0000 Subject: [wp-trac] [WordPress Trac] #53268: Twenty Twenty: WooCommerce Styles on Product Page are Inconsistent In-Reply-To: <053.15d93635964717b829ee85bbd10b69b4@wordpress.org> References: <053.15d93635964717b829ee85bbd10b69b4@wordpress.org> Message-ID: <068.fda06f29b12aa82a817fb0199ccd6289@wordpress.org> #53268: Twenty Twenty: WooCommerce Styles on Product Page are Inconsistent ---------------------------+------------------------------ Reporter: deborah86 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.7.2 Severity: normal | Resolution: Keywords: close | Focuses: css ---------------------------+------------------------------ Changes (by sabernhardt): * keywords: => close Comment: The WooCommerce styles reset the `max-width` to 100% but only on the `h2` and `p` elements, so those need updating (not the theme). The plugin also needs to update the unordered list margin/padding. I did not find an existing issue about these elements on the WooCommerce repository. Would you like to open an issue (or one for each theme)? https://github.com/woocommerce/woocommerce/issues If you would prefer that I open the issue(s), I could do that soon. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 08:44:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 08:44:44 -0000 Subject: [wp-trac] [WordPress Trac] #56925: 6.0.3 Featured Image Block Message-ID: <055.322cd6ba5388b01ce854ecc2fec5e4ac@wordpress.org> #56925: 6.0.3 Featured Image Block --------------------------+----------------------------- Reporter: nicholasyeo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Dear Sir/Mdm, I'd like to report a bug that I am facing with featured images. All my featured images across various sites are being stretched when the browser window / viewport is resized. I believe this is due to an error in the following block, which has been updated in 6.0.3: src/wp-includes/blocks/post-featured-image.php as when I revert to 6.0.2, the issue disappears. There are three methods to display featured images: Cover, Contain and Fill. I have selected "Contain" which should scale the image to fill the space without clipping nor distorting. However, this feature seems to not be working. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 09:46:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 09:46:50 -0000 Subject: [wp-trac] [WordPress Trac] #56925: 6.0.3 Featured Image Block In-Reply-To: <055.322cd6ba5388b01ce854ecc2fec5e4ac@wordpress.org> References: <055.322cd6ba5388b01ce854ecc2fec5e4ac@wordpress.org> Message-ID: <070.b00b3d9e87c53f91f37af427d6a76ee2@wordpress.org> #56925: 6.0.3 Featured Image Block --------------------------+------------------------------ Reporter: nicholasyeo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: duplicate Keywords: close | Focuses: --------------------------+------------------------------ Changes (by kebbet): * keywords: => close * status: new => closed * resolution: => duplicate Comment: Welcome to trac, and thanks for your ticket! This issue has already been reported, please follow the development there and continue any discussion in that ticket. The first report: #56855 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 10:00:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 10:00:06 -0000 Subject: [wp-trac] [WordPress Trac] #56926: Infinite loop in wp_nav_menu Message-ID: <055.459971de3aa13ba3422d46cf1791db63@wordpress.org> #56926: Infinite loop in wp_nav_menu --------------------------+----------------------------- Reporter: david.binda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Menus | Version: 6.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Testing the r54478 on WordPress.com, I have noticed an infinite loop on some sites. On certain sites, there are nav_menu_items which have the `_menu_item_menu_item_parent` meta set to their own ID. Eg.: nav_menu_item with ID `281` has the `_menu_item_menu_item_parent` meta value set to `281`, which breaks the `while` loop in https://core.trac.wordpress.org/browser/trunk/src/wp-includes/nav-menu- template.php?rev=54478#L211 as the `$menu_item_parent` variable is getting set to the same, `281` value over and over. The ultimate root cause for the infinite loop is the data corruption (of some kind), which happened at some point in the past on the sites where the infinite loop happens. While I haven't been able to figure out how the value of the `_menu_item_menu_item_parent` had been set to the same value as is it's parent nav_menu_item ID, perhaps it would still be beneficial adding a safe guard to the newly introduced logic agains the infinite loop, since it's been observed on multiple sites? I was thinking something like: {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 10:50:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 10:50:18 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Issue on media page In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.96f08331265e89e56999bd718f663798@wordpress.org> #56863: Issue on media page -----------------------------+-------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Comment (by sumitsingh): Hi @costdev , Yes that's fine. We can continue the discussion as you wish, here or there where is best for our community :) Thank you. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 10:55:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 10:55:39 -0000 Subject: [wp-trac] [WordPress Trac] #56789: Toolbar: screen-reader-shortcut does not have background color until focused In-Reply-To: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> References: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> Message-ID: <070.0722019ece847a91887e650a1071a619@wordpress.org> #56789: Toolbar: screen-reader-shortcut does not have background color until focused -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Toolbar | Version: Severity: minor | Resolution: Keywords: has-patch needs-testing has- | Focuses: screenshots needs-testing-info | accessibility, css -------------------------------------------------+------------------------- Comment (by afercia): This isn't a real problem for users, as when the element is visible the contrast is OK. WAVE reports a false positive because it isn't aware the element is positioned off screen and thus isn't actually visible. Note that all automated accessibility checkers often report false positives related to contrast as in some cases they can't understand what the actual background color is (think for example at an element with no explicit background color set). That said, it would be cleaner to change on focus only the CSS properties that bring the element into view, if that doesn't break anything. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 11:46:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 11:46:35 -0000 Subject: [wp-trac] [WordPress Trac] #56902: Twenty Twenty Three: Tag and category template creation for specific items are wrongly displayed as not found despite being successfully created In-Reply-To: <051.d0c4ccd6b48f2f8dd687ff738650e791@wordpress.org> References: <051.d0c4ccd6b48f2f8dd687ff738650e791@wordpress.org> Message-ID: <066.7119dac24822f8b15ec69fee167f43a9@wordpress.org> #56902: Twenty Twenty Three: Tag and category template creation for specific items are wrongly displayed as not found despite being successfully created -------------------------------------------+------------------------------ Reporter: franz00 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: has-screenshots needs-testing | Focuses: -------------------------------------------+------------------------------ Comment (by mikachan): Thanks for reporting this. I've opened an issue upstream: https://github.com/WordPress/gutenberg/issues/45374 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 12:39:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 12:39:41 -0000 Subject: [wp-trac] [WordPress Trac] #56604: Dark blue closing cross over the black background in plugins page In-Reply-To: <052.2813d4a82fc4525f86bdcfb457e8728b@wordpress.org> References: <052.2813d4a82fc4525f86bdcfb457e8728b@wordpress.org> Message-ID: <067.d2a449c1e530cee5105464a1d2b24ac2@wordpress.org> #56604: Dark blue closing cross over the black background in plugins page -------------------------------------+------------------------------------- Reporter: dperonne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Plugins | Version: Severity: normal | Resolution: Keywords: good-first-bug has- | Focuses: ui, accessibility, patch changes-requested | css, administration -------------------------------------+------------------------------------- Comment (by afercia): Additionally: the focus style can't be based only on color change. It needs to use a shape that can be perceived regardless of color perception impairments. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 12:48:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 12:48:29 -0000 Subject: [wp-trac] [WordPress Trac] #50086: Twenty Fifteen: Correct extra border around the editor in Gutenberg 7.8.1 and above. In-Reply-To: <050.76490f83514e61e6b263887e2285d7f6@wordpress.org> References: <050.76490f83514e61e6b263887e2285d7f6@wordpress.org> Message-ID: <065.d5417c1dc2fb251d4173912a6d3ed143@wordpress.org> #50086: Twenty Fifteen: Correct extra border around the editor in Gutenberg 7.8.1 and above. ---------------------------+---------------------- Reporter: kjellr | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: Severity: normal | Resolution: invalid Keywords: has-patch | Focuses: css ---------------------------+---------------------- Comment (by desrosj): Sorry, I had the wrong changeset above. This was fixed by way of [50465]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 13:08:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 13:08:14 -0000 Subject: [wp-trac] [WordPress Trac] #54260: Add accessible labels to pagination links In-Reply-To: <057.81beb38df1b9a04c09828f7017a8ba0b@wordpress.org> References: <057.81beb38df1b9a04c09828f7017a8ba0b@wordpress.org> Message-ID: <072.236449b4be4a6d0f2df255627b587761@wordpress.org> #54260: Add accessible labels to pagination links ---------------------------+----------------------------- Reporter: michaelbourne | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Future Release Component: General | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: accessibility ---------------------------+----------------------------- Comment (by afercia): Worth reminding that providing an accessible name (via the aria-label) that is different and, in a way, unexpected compared to the visible text does impact speech recognition users. For example: - As a sighted speech recognition user, I see a link with text `2`. - Based on that, I'd try to issue a voice command like `Click 2`. - The command would likely fail because the link accessible name (the name the speech recognition software perceives) would be `Page 2`. In general, hidden labels/text (whether it's an aria-label or visually hidden text) may help blind screen reader users but they may be misleading or even an actual barrier for sighted users. It's always best to show visible text. If more context is needed, we should just add ''visible'' text. Reference: **Success Criterion 2.5.3 Label in Name** https://www.w3.org/TR/WCAG21/#label-in-name -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 13:16:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 13:16:42 -0000 Subject: [wp-trac] [WordPress Trac] #56925: 6.0.3 Featured Image Block In-Reply-To: <055.322cd6ba5388b01ce854ecc2fec5e4ac@wordpress.org> References: <055.322cd6ba5388b01ce854ecc2fec5e4ac@wordpress.org> Message-ID: <070.1350bd676bf36987faecda38bf9904b7@wordpress.org> #56925: 6.0.3 Featured Image Block --------------------------+------------------------------ Reporter: nicholasyeo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.0.3 Severity: normal | Resolution: duplicate Keywords: close | Focuses: --------------------------+------------------------------ Changes (by SergeyBiryukov): * component: General => Media -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 14:03:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 14:03:41 -0000 Subject: [wp-trac] [WordPress Trac] #56782: PHPUnit tests: Add/improvement @covers annotations for WP 6.2 In-Reply-To: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> References: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> Message-ID: <066.6d0074eef001d82e73bc2cfb0cba3f5f@wordpress.org> #56782: PHPUnit tests: Add/improvement @covers annotations for WP 6.2 ------------------------------+------------------------------- Reporter: pbearne | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch php8 | Focuses: coding-standards ------------------------------+------------------------------- Description changed by SergeyBiryukov: Old description: > Previously: > > * #390265 (up to 6.1) > > Continuation of ongoing work to add and/or improve the PHPUnit tests > `@covers` annotations for more accurate coverage reporting. New description: Previously: * #39265 (up to 6.1) Continuation of ongoing work to add and/or improve the PHPUnit tests `@covers` annotations for more accurate coverage reporting. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 14:08:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 14:08:35 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.0fef49d7ad3198ae137365dab5c182cd@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54710" 54710]: {{{ #!CommitTicketReference repository="" revision="54710" Tests: Move the tests for `WP` class methods to the `wp` directory. This aims to bring some consistency to the location of the tests for this class. Includes adding the missing `@covers` tags. Follow-up to [36177], [51622], [54250]. Props pbearne, SergeyBiryukov. See #56793, #56782. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 14:08:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 14:08:35 -0000 Subject: [wp-trac] [WordPress Trac] #56782: PHPUnit tests: Add/improvement @covers annotations for WP 6.2 In-Reply-To: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> References: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> Message-ID: <066.f5b527df9711bb0b24b1184c8712792f@wordpress.org> #56782: PHPUnit tests: Add/improvement @covers annotations for WP 6.2 ------------------------------+------------------------------- Reporter: pbearne | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch php8 | Focuses: coding-standards ------------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"54710" 54710]: {{{ #!CommitTicketReference repository="" revision="54710" Tests: Move the tests for `WP` class methods to the `wp` directory. This aims to bring some consistency to the location of the tests for this class. Includes adding the missing `@covers` tags. Follow-up to [36177], [51622], [54250]. Props pbearne, SergeyBiryukov. See #56793, #56782. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 14:12:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 14:12:24 -0000 Subject: [wp-trac] [WordPress Trac] #56782: PHPUnit tests: Add/improve @covers annotations for WP 6.2 (was: PHPUnit tests: Add/improvement @covers annotations for WP 6.2) In-Reply-To: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> References: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> Message-ID: <066.2702e670817e6613e6ba2111eca7799b@wordpress.org> #56782: PHPUnit tests: Add/improve @covers annotations for WP 6.2 ------------------------------+------------------------------- Reporter: pbearne | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch php8 | Focuses: coding-standards ------------------------------+------------------------------- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 14:47:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 14:47:28 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.14652b3548d9353fa02c29b46c64f386@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54711" 54711]: {{{ #!CommitTicketReference repository="" revision="54711" Tests: Move `dbDelta()` tests to the `db` directory. This aims to bring some consistency with other database-related tests. Includes adding a missing `@covers` tag to the class DocBlock. Follow-up to [30345], [32108], [32770], [51798]. Props pbearne, SergeyBiryukov. See #56793, #56782. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 14:47:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 14:47:28 -0000 Subject: [wp-trac] [WordPress Trac] #56782: PHPUnit tests: Add/improve @covers annotations for WP 6.2 In-Reply-To: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> References: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> Message-ID: <066.6a0750642be6794c23932297e400d547@wordpress.org> #56782: PHPUnit tests: Add/improve @covers annotations for WP 6.2 ------------------------------+------------------------------- Reporter: pbearne | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch php8 | Focuses: coding-standards ------------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"54711" 54711]: {{{ #!CommitTicketReference repository="" revision="54711" Tests: Move `dbDelta()` tests to the `db` directory. This aims to bring some consistency with other database-related tests. Includes adding a missing `@covers` tag to the class DocBlock. Follow-up to [30345], [32108], [32770], [51798]. Props pbearne, SergeyBiryukov. See #56793, #56782. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 14:54:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 14:54:34 -0000 Subject: [wp-trac] [WordPress Trac] #43241: Twenty Seventeen: Menu stays expanded after clicking on links In-Reply-To: <056.9a803c71067b0feb6894a7f60d95e09b@wordpress.org> References: <056.9a803c71067b0feb6894a7f60d95e09b@wordpress.org> Message-ID: <071.437f5c5756d11e9af8a820184a71d460@wordpress.org> #43241: Twenty Seventeen: Menu stays expanded after clicking on links -----------------------------------------+------------------------------ Reporter: nilamacharya | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 4.7 Severity: normal | Resolution: Keywords: has-screenshots 2nd-opinion | Focuses: ui, javascript -----------------------------------------+------------------------------ Changes (by sabernhardt): * Attachment "twenty-seventeen-menu-mobile-expanded.png" added. mobile menu, expanded -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 14:54:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 14:54:54 -0000 Subject: [wp-trac] [WordPress Trac] #51019: convert_smilies() fails on large tags In-Reply-To: <053.0be6aca7ce4eb7f20a95a215c9be96da@wordpress.org> References: <053.0be6aca7ce4eb7f20a95a215c9be96da@wordpress.org> Message-ID: <068.8344b7a66d1038d65b84452ba9216002@wordpress.org> #51019: convert_smilies() fails on large tags --------------------------+------------------------------ Reporter: podpirate | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+------------------------------ Comment (by rupw): FWIW I'd probably just check $textarr === false rather than preg_last_error(), but looks good to me. Another report on WPSE: https://wordpress.stackexchange.com/q/409084 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 14:57:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 14:57:31 -0000 Subject: [wp-trac] [WordPress Trac] #56927: Post Featured Image always lazy loaded in T22 and T23 Single template Message-ID: <050.91899407a5827ff774c100b54d5d8b38@wordpress.org> #56927: Post Featured Image always lazy loaded in T22 and T23 Single template -----------------------------+----------------------------- Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Post Thumbnails | Version: 6.1 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- To my surprise, in Twenty Twenty-Two and Twenty-Three the featured post images are always lazy loaded. This, in spite of the fact that the featured image is the frist image on the screen, so ignoring the `wp_omit_loading_attr_threshold` of 1. I tried returning false on the `wp_lazy_loading_enabled` filter but that did not have any effect either. It appears that the Post Featured Image block, using get_the_post_thumbnail ignores both `wp_lazy_loading_enabled` filter and `wp_omit_loading_attr_threshold`. The lines in question, starting at line 191 in wp-includes/post-thumbnail- template.php: {{{ // Get the 'loading' attribute value to use as default, taking precedence over the default from // `wp_get_attachment_image()`. $loading = wp_get_loading_attr_default( 'the_post_thumbnail' ); // Add the default to the given attributes unless they already include a 'loading' directive. if ( empty( $attr ) ) { $attr = array( 'loading' => $loading ); } elseif ( is_array( $attr ) && ! array_key_exists( 'loading', $attr ) ) { $attr['loading'] = $loading; } elseif ( is_string( $attr ) && ! preg_match( '/(^|&)loading=/', $attr ) ) { $attr .= '&loading=' . $loading; } $html = wp_get_attachment_image( $post_thumbnail_id, $size, false, $attr ); }}} Here, `wp_get_loading_attr_default( 'the_post_thumbnail' )` apparently returns 'lazy' even if it is the first image on the page, which causes the loading attribute to be set and passed to `wp_get_attachment_image` which then ignores the usual `wp_lazy_loading_enabled` validation. Why does `wp_get_loading_attr_default( 'the_post_thumbnail' )` return true in this case? Does `in_the_loop()` return false at this point? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:00:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:00:58 -0000 Subject: [wp-trac] [WordPress Trac] #43241: Twenty Seventeen: Menu stays expanded after clicking on links In-Reply-To: <056.9a803c71067b0feb6894a7f60d95e09b@wordpress.org> References: <056.9a803c71067b0feb6894a7f60d95e09b@wordpress.org> Message-ID: <071.acba245c5bcd89ac84a8ac784df30dd8@wordpress.org> #43241: Twenty Seventeen: Menu stays expanded after clicking on links -----------------------------------------------+--------------------------- Reporter: nilamacharya | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Bundled Theme | Version: 4.7 Severity: normal | Resolution: Keywords: has-screenshots 2nd-opinion close | Focuses: ui, | javascript -----------------------------------------------+--------------------------- Changes (by sabernhardt): * keywords: has-screenshots 2nd-opinion => has-screenshots 2nd-opinion close Comment: I recommend moving this discussion to the test theme repository: https://github.com/WPTT/theme-test-data/issues/50 The menu items need meaningful links for people on smaller devices and for basically anyone who does not use a mouse. I would rather not edit the script for this special case that sites hopefully do not use. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:08:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:08:00 -0000 Subject: [wp-trac] [WordPress Trac] #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color Message-ID: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color ---------------------------+----------------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- When both the visited and hover states are active on a button, the visited text color overrides the hover text color, which means the two colors are not contrasting in the default style variation. [[Image(https://cldup.com/i8uPleQS_3.png)]] The second image has both a :visited and :hover state. Video example: https://user- images.githubusercontent.com/2207451/198293193-958030d2-5817-4313-bb2d- be65bfdb8f36.mov We may be able to fix this by adding an `!important` tag to the hover text color property, although this isn't ideal. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:12:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:12:18 -0000 Subject: [wp-trac] [WordPress Trac] #56922: Template / Template parts revision / autosave REST API are broken In-Reply-To: <056.7c930ec09aecb25976c71a298bd5a15d@wordpress.org> References: <056.7c930ec09aecb25976c71a298bd5a15d@wordpress.org> Message-ID: <071.52665520e9a7ca03c3a5561828ee25b2@wordpress.org> #56922: Template / Template parts revision / autosave REST API are broken --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: REST API | Version: 4.7 Severity: normal | Resolution: Keywords: | Focuses: rest-api --------------------------+----------------------------- Comment (by revgeorge): I think that the path `wp/v2/template-parts/1480/revisions` is pretty easy to fix, by adding `(?([^\/:<>\*\?"\|]+(?:\/[^\/:<>\*\?"\|]+)?)'[\/\w-]+',)` which would match on `\d+/revisions$` or `\d+/revisions/d+$` but, since they don't have a capture group, the updated router would treat them as non-matches. Existing routes without capture groups (e.g. `/templates`) would have to be updated though. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:16:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:16:44 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems In-Reply-To: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> References: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> Message-ID: <067.80f577dd2e179685e0b02afbf1520e10@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems --------------------------+--------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by antpb): In [changeset:"54712" 54712]: {{{ #!CommitTicketReference repository="" revision="54712" Media: Reverts `get_attached_file()` changes for normalized Windows paths. Based on feedback from network storage configurations there was a noticed slowdown due to the usage of the `path_join()` function. This needs more time to find a workaround. Follow-up to [53934]. Props mreishus, SergeyBiryukov, desrosj, mikeschroder. Reverts [53934]. See #56924. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:22:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:22:38 -0000 Subject: [wp-trac] [WordPress Trac] #56922: Template / Template parts revision / autosave REST API are broken In-Reply-To: <056.7c930ec09aecb25976c71a298bd5a15d@wordpress.org> References: <056.7c930ec09aecb25976c71a298bd5a15d@wordpress.org> Message-ID: <071.3131d6acd5322576cd3f46d8743cae84@wordpress.org> #56922: Template / Template parts revision / autosave REST API are broken --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: REST API | Version: 4.7 Severity: normal | Resolution: Keywords: | Focuses: rest-api --------------------------+----------------------------- Comment (by spacedmonkey): @TimothyBlynJacobs Love your thoughts on this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:25:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:25:36 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems In-Reply-To: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> References: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> Message-ID: <067.8ce49c77847b257373e71df5627ace38@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems ---------------------------------+--------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: 6.1 Severity: normal | Resolution: Keywords: commit dev-feedback | Focuses: ---------------------------------+--------------------- Changes (by davidbaumwald): * keywords: => commit dev-feedback Comment: Flagging for a revert in the 6.1 branch as well, pending a second committer's review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:27:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:27:45 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems In-Reply-To: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> References: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> Message-ID: <067.36bc7839fcb7d5baaadc8e2b46fe76e4@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems ---------------------------------+--------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: 6.1 Severity: normal | Resolution: Keywords: commit dev-reviewed | Focuses: ---------------------------------+--------------------- Changes (by mikeschroder): * keywords: commit dev-feedback => commit dev-reviewed Comment: I left a note to [https://wordpress.slack.com/archives/C03LZ88NX6G/p1666968275436109 this extent in Slack], but +1 for reverting / backporting for 6.1. This will give time for folks to investigate / benchmark without time pressure, and hopefully find a better performing solution for the original issue in #36308. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:29:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:29:16 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems In-Reply-To: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> References: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> Message-ID: <067.5b281b8b02ef87d51583b305ca18f17d@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems ---------------------------------+--------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: General | Version: 6.1 Severity: normal | Resolution: Keywords: commit dev-reviewed | Focuses: ---------------------------------+--------------------- Comment (by antpb): In [changeset:"54713" 54713]: {{{ #!CommitTicketReference repository="" revision="54713" Media: Reverts `get_attached_file()` changes for normalized Windows paths. Based on feedback from network storage configurations there was a noticed slowdown due to the usage of the `path_join()` function. This needs more time to find a workaround. Follow-up to [53934]. Props mreishus, SergeyBiryukov, desrosj, mikeschroder. Reverts [53934] in the 6.1 Branch. See #56924. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:44:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:44:41 -0000 Subject: [wp-trac] [WordPress Trac] #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color In-Reply-To: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> References: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> Message-ID: <067.04547d39ad025720651ce55c94401c27@wordpress.org> #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color ---------------------------+------------------------------ Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+------------------------------ Changes (by sabernhardt): * focuses: => css Comment: Moving `:visited` before the `:hover` and `:focus` styles in theme.json should be simpler. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:47:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:47:54 -0000 Subject: [wp-trac] [WordPress Trac] #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color In-Reply-To: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> References: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> Message-ID: <067.749d9d40ea4456a981e4625b56c409d1@wordpress.org> #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color ---------------------------+--------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+--------------------- Changes (by davidbaumwald): * milestone: Awaiting Review => 6.1.1 Comment: This would be good to address in 6.1.1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:57:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:57:48 -0000 Subject: [wp-trac] [WordPress Trac] #36308: get_attached_file() destroys file paths on Windows In-Reply-To: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> References: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> Message-ID: <065.60ea6752f32b1b9b5b6f0c121f37bba3@wordpress.org> #36308: get_attached_file() destroys file paths on Windows ---------------------------------------------+----------------------- Reporter: Whissi | Owner: antpb Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.2 Component: Media | Version: 4.4.2 Severity: normal | Resolution: Keywords: has-unit-tests has-testing-info | Focuses: ---------------------------------------------+----------------------- Changes (by desrosj): * status: closed => reopened * resolution: fixed => * milestone: 6.1 => 6.2 Comment: #56924 raised performance concerns on certain filesystem set ups. After some discussion, it was decided that [53934] should be reverted and removed from 6.1 so more testing could be done. Reopening to try again in 6.2. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:58:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:58:21 -0000 Subject: [wp-trac] [WordPress Trac] #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color In-Reply-To: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> References: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> Message-ID: <067.8eae184cd943b209953a2d97c8d628eb@wordpress.org> #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color ---------------------------+--------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+--------------------- Comment (by mikachan): > Moving :visited before the :hover and :focus styles in global styles should be simpler. Yes, I thought so too, but this doesn't seem to work in my testing... Perhaps this ordering should be addressed in Gutenberg. > This would be good to address in 6.1.1. Ok! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:59:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:59:15 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems In-Reply-To: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> References: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> Message-ID: <067.e9cf480d5fae82ba406b68644037c596@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems ---------------------------------+--------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: General | Version: 6.1 Severity: normal | Resolution: fixed Keywords: commit dev-reviewed | Focuses: ---------------------------------+--------------------- Changes (by desrosj): * status: new => closed * resolution: => fixed Comment: I've reopened #36308 to continue working on a better solution for this. Since this ticket is specifically about the regression in 6.1, I'm going to close this out. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 15:59:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 15:59:23 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems In-Reply-To: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> References: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> Message-ID: <067.e533781365da174d47cb628381b324ba@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems ---------------------------------+--------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 6.1 Severity: normal | Resolution: fixed Keywords: commit dev-reviewed | Focuses: ---------------------------------+--------------------- Changes (by desrosj): * component: General => Media -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 16:16:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 16:16:17 -0000 Subject: [wp-trac] [WordPress Trac] #56927: Post Featured Image always lazy loaded in T22 and T23 Single template In-Reply-To: <050.91899407a5827ff774c100b54d5d8b38@wordpress.org> References: <050.91899407a5827ff774c100b54d5d8b38@wordpress.org> Message-ID: <065.06fdde60a63dc1f40081802484a4c6a1@wordpress.org> #56927: Post Featured Image always lazy loaded in T22 and T23 Single template -----------------------------+------------------------------ Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Post Thumbnails | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Comment (by RavanH): I do not see a way to prevent this from happening to a Post Featured Image block used in a theme template, outside of the Loop like in the Single and Page templates in T22 and T23. Maybe the `core/post-featured-image` block needs a "loading" attribute with matching "Loading" options "Default","Disabled","Lazy" and "Eager"? This value can then be passed to `get_the_post_thumbnail()` overriding the current loading attribute. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 16:20:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 16:20:56 -0000 Subject: [wp-trac] [WordPress Trac] #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color In-Reply-To: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> References: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> Message-ID: <067.c644a643ff8a1bc33c9edebdc5e17d11@wordpress.org> #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color ---------------------------+--------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+--------------------- Changes (by sabernhardt): * Attachment "56928.patch" added. moves `:visited` to the beginning of the array -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 16:21:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 16:21:22 -0000 Subject: [wp-trac] [WordPress Trac] #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color In-Reply-To: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> References: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> Message-ID: <067.b46c5e91909301822ccb69ebf05f7051@wordpress.org> #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color ---------------------------+--------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: css ---------------------------+--------------------- Changes (by sabernhardt): * keywords: => has-patch Comment: GB34448 seems to be the same issue. For Twenty Twenty-Three, I was able to fix it by changing the order of pseudo-classes in the `VALID_ELEMENT_PSEUDO_SELECTORS` array. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 16:26:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 16:26:37 -0000 Subject: [wp-trac] [WordPress Trac] #36308: get_attached_file() destroys file paths on Windows In-Reply-To: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> References: <050.92eb671f89732a16ad562052bc684b6b@wordpress.org> Message-ID: <065.8409836006d9087cce0c79d1dad14218@wordpress.org> #36308: get_attached_file() destroys file paths on Windows ---------------------------------------------+----------------------- Reporter: Whissi | Owner: antpb Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.2 Component: Media | Version: 4.4.2 Severity: normal | Resolution: Keywords: has-unit-tests has-testing-info | Focuses: ---------------------------------------------+----------------------- Comment (by azaozz): Replying to [comment:61 desrosj]: May I also suggest that this problem (and perhaps a link to https://core.trac.wordpress.org/ticket/56924) is mentioned on the docblock of `path_is_absolute()`, and perhaps `path_join()`. Seems the latter is used quite often and this slowdown may be causing other problems too. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 16:27:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 16:27:06 -0000 Subject: [wp-trac] [WordPress Trac] #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color In-Reply-To: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> References: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> Message-ID: <067.19d67ba518adc2907969e90683a737d6@wordpress.org> #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color ---------------------------+--------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: css ---------------------------+--------------------- Comment (by mikachan): > For Twenty Twenty-Three, I was able to fix it by changing the order of pseudo-classes in the VALID_ELEMENT_PSEUDO_SELECTORS array. Nice, thank you! This patch looks good. Sorry, in your earlier comment I thought you meant the ordering in the theme's theme.json file (which is what I had tried). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 16:31:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 16:31:22 -0000 Subject: [wp-trac] [WordPress Trac] #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color In-Reply-To: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> References: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> Message-ID: <067.6107b94b74ea526e1ec17f2de302706d@wordpress.org> #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color ---------------------------+--------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: css ---------------------------+--------------------- Comment (by sabernhardt): I had said theme.json in that comment and then discovered my mistake :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 17:14:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 17:14:13 -0000 Subject: [wp-trac] [WordPress Trac] #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts Message-ID: <052.cf83c1a6d1d164a51ef84cd3f5110260@wordpress.org> #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts --------------------------+----------------------------- Reporter: bgturner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- When a sticky post exists, it isn't styled differently than other posts. The TT3 theme correctly: - Puts a sticky post as first in the blog roll - Applies the `sticky` class - Also shows the post in the original position, without the `sticky` class This was found when doing QA of the 6.1 release candidate: - https://make.wordpress.org/test/2022/09/21/help-test-wordpress-6-1/ == Replication - Install 6.1 and be sure that TT3 is active - Import the theme unit test data: - https://github.com/WPTT/theme-test-data - Navigate to the posts homepage and note that the sticky post doesn't look visually different than other posts but it does have the correct `sticky` class - Navigate to older posts until you find the sticky post where it should be. Note that it correctly does not have the `sticky` class Here's a screenshot to help visualize: https://i.getf.ly/wbuQpJqn -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 17:15:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 17:15:01 -0000 Subject: [wp-trac] [WordPress Trac] #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts In-Reply-To: <052.cf83c1a6d1d164a51ef84cd3f5110260@wordpress.org> References: <052.cf83c1a6d1d164a51ef84cd3f5110260@wordpress.org> Message-ID: <067.39270dd79588a8451dcfc71f48593b1f@wordpress.org> #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts --------------------------+------------------------------ Reporter: bgturner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by bgturner): * Attachment "wp6-1-qa-sticky-posts.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 17:24:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 17:24:07 -0000 Subject: [wp-trac] [WordPress Trac] #56621: Twenty Twenty-Three: Pullquote block Letter case issue In-Reply-To: <053.215d39367ef6f892c0521105176fae7b@wordpress.org> References: <053.215d39367ef6f892c0521105176fae7b@wordpress.org> Message-ID: <068.938b336ff6193e553c38b1d438f76f38@wordpress.org> #56621: Twenty Twenty-Three: Pullquote block Letter case issue ---------------------------+------------------------------ Reporter: nithins53 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: worksforme Keywords: | Focuses: ---------------------------+------------------------------ Changes (by nithins53): * status: reopened => closed * resolution: => worksforme -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 17:30:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 17:30:16 -0000 Subject: [wp-trac] [WordPress Trac] #56930: Block themes: improve omitting lazy-loading attribute on first content image/iframe Message-ID: <059.a200819e4e9b6054a50d25f5d2465caa@wordpress.org> #56930: Block themes: improve omitting lazy-loading attribute on first content image/iframe -----------------------------+----------------------------- Reporter: adamsilverstein | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9 Severity: normal | Keywords: Focuses: performance | -----------------------------+----------------------------- In #53675 we improved core's auto application of the `loading="lazy"` attribute for content images (and iframes). The behavior was adjusted to avoid adding the `lazy` loading attribute to the first content image, because that can actually slow down the speed/priority of that image being loaded. Additional details are on [https://make.wordpress.org/core/2021/07/15/refining-wordpress-cores-lazy- loading-implementation/ this post]. Subsequent testing of the feature revealed that block theme images still aren't handled correctly: all content images receive the `lazy` loading attribute, including the first one. This is caused by the block theme "double" pass at the `the_content` (which can actually help performance ). To fix this we need to avoid "counting" images (which we do to skip adding the lazy attribute to the first image) the first pass by block themes where the $context is false . During the actual content pass, the context value is `the_content`. Testing instructions: - Enable the twentytwentythree theme - Create a post with two different images and view the post - Note that currently both images have the loading="lazy" attribute patch incoming, after this patch, the first image does not have the loading="lazy"attribute - test with a classic theme (eg twentyninetween) to verify the same expected behavior -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 17:32:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 17:32:08 -0000 Subject: [wp-trac] [WordPress Trac] #56930: Block themes: improve omitting lazy-loading attribute on first content image/iframe In-Reply-To: <059.a200819e4e9b6054a50d25f5d2465caa@wordpress.org> References: <059.a200819e4e9b6054a50d25f5d2465caa@wordpress.org> Message-ID: <074.8db8369521840a0cdadf86652264927f@wordpress.org> #56930: Block themes: improve omitting lazy-loading attribute on first content image/iframe -----------------------------+------------------------------ Reporter: adamsilverstein | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -----------------------------+------------------------------ Changes (by adamsilverstein): * Attachment "56930.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 17:38:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 17:38:03 -0000 Subject: [wp-trac] [WordPress Trac] #56930: Block themes: improve omitting lazy-loading attribute on first content image/iframe In-Reply-To: <059.a200819e4e9b6054a50d25f5d2465caa@wordpress.org> References: <059.a200819e4e9b6054a50d25f5d2465caa@wordpress.org> Message-ID: <074.33b99b3dadac4a608aafa70ad0b98cd8@wordpress.org> #56930: Block themes: improve omitting lazy-loading attribute on first content image/iframe -----------------------------+------------------------------ Reporter: adamsilverstein | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -----------------------------+------------------------------ Comment (by ocean90): Duplicate/related: #56927, #55996 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 17:41:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 17:41:16 -0000 Subject: [wp-trac] [WordPress Trac] #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts In-Reply-To: <052.cf83c1a6d1d164a51ef84cd3f5110260@wordpress.org> References: <052.cf83c1a6d1d164a51ef84cd3f5110260@wordpress.org> Message-ID: <067.847303b4358f9cb760008dcd56cf7d35@wordpress.org> #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts ---------------------------+------------------------------ Reporter: bgturner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Changes (by sabernhardt): * component: General => Bundled Theme -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 17:49:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 17:49:46 -0000 Subject: [wp-trac] [WordPress Trac] #56930: Block themes: improve omitting lazy-loading attribute on first content image/iframe In-Reply-To: <059.a200819e4e9b6054a50d25f5d2465caa@wordpress.org> References: <059.a200819e4e9b6054a50d25f5d2465caa@wordpress.org> Message-ID: <074.314adb0666263a641d2385821df9c12b@wordpress.org> #56930: Block themes: improve omitting lazy-loading attribute on first content image/iframe -----------------------------+------------------------------ Reporter: adamsilverstein | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance -----------------------------+------------------------------ Comment (by adamsilverstein): Thanks @ocean90 - I didn't see those. #56927 in particular would be fixed by this and could be considered a duplicate. The other one deals more broadly with the underlying change in behavior. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 20:08:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 20:08:54 -0000 Subject: [wp-trac] [WordPress Trac] #56824: SVGs missing title and description in WordPress dashboard (was: Accessibility image alt text empty & SVG missing title and description on wordpress dashboard) In-Reply-To: <055.74ee180519091325d8907050de21947b@wordpress.org> References: <055.74ee180519091325d8907050de21947b@wordpress.org> Message-ID: <070.69805988b2f8802907e58965780a3248@wordpress.org> #56824: SVGs missing title and description in WordPress dashboard ----------------------------------------+---------------------------- Reporter: viralsampat | Owner: (none) Type: defect (bug) | Status: new Priority: low | Milestone: 6.2 Component: Administration | Version: 6.0 Severity: normal | Resolution: Keywords: needs-patch good-first-bug | Focuses: accessibility ----------------------------------------+---------------------------- Changes (by ryokuhi): * keywords: close reporter-feedback => needs-patch good-first-bug * priority: normal => low * version: => 6.0 * milestone: Awaiting Review => 6.2 Comment: We reviewed this ticket today during the Accessibility Team's weekly bug scrub. Regarding the alternative text for Gravatars in the Recent Comments widget, I agree with @audrasjb that it should stay empty. From the point of view of accessibility, as he said, the alt text in these cases wouldn't add much value, since users normally use their pictures for Gravatars. From the technical point of view, I'm not sure it makes sense to implement a mechanism to add in WordPress the alternative text of an image hosted on an external website. Regarding the two SVGs, some automated tools mark such elements with errors because these SVGs have the `role="img"` attribute: despite being hidden to assistive technologies using `aria-hidden="true"`, automated tools still understand them as images and expect alternative texts. While this is not a priority, removing `role="img"` would solve the issue, and would be a very nice opportunity for someone new to start contributing to WordPress. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 20:36:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 20:36:33 -0000 Subject: [wp-trac] [WordPress Trac] #56921: Inconsistency in help tab & small typo In-Reply-To: <053.205e549175043cd8235274e7ed31b210@wordpress.org> References: <053.205e549175043cd8235274e7ed31b210@wordpress.org> Message-ID: <068.6ecf547d6b21f95920becd6f580bda6d@wordpress.org> #56921: Inconsistency in help tab & small typo -------------------------+--------------------------------------- Reporter: NekoJonez | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, docs, administration -------------------------+--------------------------------------- Changes (by sabernhardt): * component: Text Changes => Help/About -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 22:19:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 22:19:35 -0000 Subject: [wp-trac] [WordPress Trac] #56843: Comments in wp-login.php start with an "*" too few. In-Reply-To: <053.f8d1861b222585819d8466ca519ff1db@wordpress.org> References: <053.f8d1861b222585819d8466ca519ff1db@wordpress.org> Message-ID: <068.474c8605534f8d6a69c80dcdc201a2ed@wordpress.org> #56843: Comments in wp-login.php start with an "*" too few. ------------------------------------+------------------------------ Reporter: NekoJonez | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: minor | Resolution: Keywords: has-patch | Focuses: docs ------------------------------------+------------------------------ Changes (by sabernhardt): * focuses: => docs * component: Comments => Login and Registration Old description: > On line 98, 427, 537 the comment block starts with "/*" while all others > start with "/**". New description: On line 98, 427, 537 the comment block starts with `/*` while all others start with `/**`. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 22:40:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 22:40:08 -0000 Subject: [wp-trac] [WordPress Trac] #56863: Adjust SVG image thumbnail size on media listing page (was: Issue on media page) In-Reply-To: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> References: <054.9510d317c025475326f6fedd0bdc60de@wordpress.org> Message-ID: <069.d81a8959940cfef0a89616201bc21e9a@wordpress.org> #56863: Adjust SVG image thumbnail size on media listing page -----------------------------------+-------------------------------------- Reporter: sumitsingh | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.0.3 Severity: normal | Resolution: Keywords: has-screenshots close | Focuses: ui, css, administration -----------------------------------+-------------------------------------- Changes (by sabernhardt): * keywords: has-screenshots => has-screenshots close * component: General => Media Comment: Instead of closing as a duplicate, would 'maybe later' make more sense? Then this could be reopened as a next step when #24251 is ready. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Oct 28 23:08:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 28 Oct 2022 23:08:45 -0000 Subject: [wp-trac] [WordPress Trac] #56827: Alignment issue with Generate Password and Save Password buttons on Reset Password page (was: Alignment issue with Generate Password and Save Password buttons due to l10n on Reset Password page) In-Reply-To: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> References: <049.9d598c0f8c0bdcc1e20f5928999b144f@wordpress.org> Message-ID: <064.e11aec39b089763b4404fd15095ba75f@wordpress.org> #56827: Alignment issue with Generate Password and Save Password buttons on Reset Password page ----------------------------------------------+---------------------------- Reporter: nlpro | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Login and Registration | Version: 6.0.2 Severity: normal | Resolution: Keywords: has-testing-info has-screenshots | Focuses: ui, ui-copy ----------------------------------------------+---------------------------- Changes (by sabernhardt): * keywords: has-testing-info has-screenshots needs-testing => has-testing- info has-screenshots * focuses: ui => ui, ui-copy * component: I18N => Login and Registration Old description: > Prerequisites: > > - The initial language used is “English (United States)”. > - Make sure to have other language(s) pre installed (like Nederlands > (=Dutch)). > > To reproduce the issue follow the steps below (**first scenario**): > > 1. Navigate to the site admin login page (wp-login.php or wp-admin). > > 2. Click on the “Lost your password?” link. > > 3. Enter an existing username or it’s associated email address and click > on the “Get New Password” button. > > 4. Now log into the email account of that user, open the “Password Reset” > email received and click on the confirmation link. > > 5. Notice the “Generate Password” and “Save Password” buttons which are > correctly aligned horizontally. > > 6. Select a different language, like “Nederlands” at the bottom of the > page and click on the Change button. > > 7. Notice the 2 earlier mentioned buttons are now stacked or aligned > vertically. Yuk, makes me want to puke! > > (This ticket is not finished yet. Wait for the **2nd scenario**…) New description: Prerequisites: - The initial language used is “English (United States)”. - Make sure to have other language(s) pre installed (like Nederlands (=Dutch)). To reproduce the issue follow the steps below (**first scenario**): 1. Navigate to the site admin login page (wp-login.php or wp-admin). 2. Click on the “Lost your password?” link. 3. Enter an existing username or its associated email address and click on the “Get New Password” button. 4. Now log into the email account of that user, open the “Password Reset” email received and click on the confirmation link. 5. Notice the “Generate Password” and “Save Password” buttons which are correctly aligned horizontally. 6. Select a different language, like “Nederlands” at the bottom of the page and click on the Change button. 7. Notice the 2 earlier mentioned buttons are now stacked or aligned vertically. Yuk, makes me want to puke! **Second scenario:** Simply making use of the browser zoom in/out functionality will very quickly result in the same vertically aligned buttons. This reproduces even in language “English (United States)”. -- Comment: For the English scenario, I needed to change the font from Segoe UI to Roboto, but then the buttons stacked at 175% zoom. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 03:37:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 03:37:49 -0000 Subject: [wp-trac] [WordPress Trac] #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems In-Reply-To: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> References: <052.b5cb1e7271a7a8c67fde214d5f0bedcb@wordpress.org> Message-ID: <067.eb1e548b4dbde276e7be22f8bf1e2785@wordpress.org> #56924: get_attached_file(): New call to path_join() can have poor performance on NFS file systems ---------------------------------+--------------------- Reporter: mreishus | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Media | Version: 6.1 Severity: normal | Resolution: fixed Keywords: commit dev-reviewed | Focuses: ---------------------------------+--------------------- Comment (by mikeschroder): Additional props to @juberstine @desmith for quick last-minute feedback on this ticket. Thank you!! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 10:19:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 10:19:09 -0000 Subject: [wp-trac] [WordPress Trac] #56931: Introduce action hook `manage_terms_extra_tablenav` Message-ID: <053.6aa2b17e910fa0645f580b144f161845@wordpress.org> #56931: Introduce action hook `manage_terms_extra_tablenav` -----------------------------+----------------------------- Reporter: podpirate | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: trunk Severity: normal | Keywords: Focuses: administration | -----------------------------+----------------------------- Both `WP_Posts_List_Table` and `WP_Users_List_Table` provide an action hook allowing plugin authors add their own filter options, display logic, status messages or whatever. However `WP_Terms_List_Table` does not. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 10:21:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 10:21:55 -0000 Subject: [wp-trac] [WordPress Trac] #56931: Introduce action hook `manage_terms_extra_tablenav` In-Reply-To: <053.6aa2b17e910fa0645f580b144f161845@wordpress.org> References: <053.6aa2b17e910fa0645f580b144f161845@wordpress.org> Message-ID: <068.e8db4ff6627b93d7b901278efe0533fe@wordpress.org> #56931: Introduce action hook `manage_terms_extra_tablenav` -----------------------------+------------------------------ Reporter: podpirate | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: administration -----------------------------+------------------------------ Changes (by podpirate): * Attachment "class-wp-terms-list-table.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 13:39:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 13:39:21 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.e0b2245abf91bd0d1896e71a9953f178@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54716" 54716]: {{{ #!CommitTicketReference repository="" revision="54716" Tests: Move the tests for pluggable function signatures to the `pluggable` directory. This aims to bring some consistency to the location of pluggable function tests. Includes: * Renaming the test class to better reflect the intention of the tests. * Adding a `@coversNothing` tag to the class DocBlock. Follow-up to [34126], [53478], [54702]. Props pbearne, SergeyBiryukov. See #56793, #56782. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 13:39:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 13:39:21 -0000 Subject: [wp-trac] [WordPress Trac] #56782: PHPUnit tests: Add/improve @covers annotations for WP 6.2 In-Reply-To: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> References: <051.e98e1c2d09ac27ea860d65c1cb76ad04@wordpress.org> Message-ID: <066.55d3310ea923c42278f170f96c311d28@wordpress.org> #56782: PHPUnit tests: Add/improve @covers annotations for WP 6.2 ------------------------------+------------------------------- Reporter: pbearne | Owner: hellofromTonya Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: 4.8 Severity: normal | Resolution: Keywords: has-patch php8 | Focuses: coding-standards ------------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"54716" 54716]: {{{ #!CommitTicketReference repository="" revision="54716" Tests: Move the tests for pluggable function signatures to the `pluggable` directory. This aims to bring some consistency to the location of pluggable function tests. Includes: * Renaming the test class to better reflect the intention of the tests. * Adding a `@coversNothing` tag to the class DocBlock. Follow-up to [34126], [53478], [54702]. Props pbearne, SergeyBiryukov. See #56793, #56782. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 14:38:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 14:38:32 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.a96035a4118c3200c37f8832b2ab7065@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54717" 54717]: {{{ #!CommitTicketReference repository="" revision="54717" Tests: Split the tests from `category.php` into individual test classes. This aims to bring some consistency to the location of category function tests, as well as to make the tests more discoverable and easier to expand. Follow-up to [28438], [28566], [31006], [31025], [37464], [28438], [31299], [36988], [42364], [42367], [42368], [46413], [53684]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 15:14:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 15:14:05 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.978a6d7d4bda5527dc9b8f50c581361c@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54718" 54718]: {{{ #!CommitTicketReference repository="" revision="54718" Tests: Remove `skipWithMultisite()` from an Ajax test for attachments. This was previously removed in [51870] and appears to be accidentally readded in [53561]. As the test belongs to the `ms-excluded` group, the skipping is unnecessary and does not affect anything in practice. Follow-up to [46693], [49835], [51870], [53561]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 15:42:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 15:42:41 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.74ae32f96ac79d41cc444128dfbfbdeb@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54719" 54719]: {{{ #!CommitTicketReference repository="" revision="54719" Tests: Remove `skipWithMultisite()` and `skipWithoutMultisite()` from `get_user_count()` tests. As the tests belong to either the `ms-excluded` or the `ms-required` group, the skipping should not be necessary. While these methods were initially intended to be used in conjunction with the respective group, the PHPUnit configuration files for single site and multisite exclude these groups as appropriate, so calling these methods explicitly is no longer required. Follow-up to [40520], [40543], [40564], [43005], [46683], [53011]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 15:58:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 15:58:02 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.d84c0d47638d2e7bb9242bfedd75696d@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54720" 54720]: {{{ #!CommitTicketReference repository="" revision="54720" Tests: Remove unused `$user_ids` property in `Tests_Ajax_Autosave` class. This was previously used to delete the users created during `wpSetUpBeforeClass()`, however that now happens automatically in `WP_UnitTestCase_Base::tear_down_after_class()` via `_delete_all_data()`. Follow-up to [35311], [37404], [38398]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 17:10:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 17:10:43 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.08b4a0d23e9835607c771abe370623f7@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54721" 54721]: {{{ #!CommitTicketReference repository="" revision="54721" Coding Standards: Correct alignment in `Tests_Ajax_Autosave::wpSetUpBeforeClass()`. This fixes an `Equals sign not aligned with surrounding assignments` WPCS warning. Follow-up to [54720]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 18:41:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 18:41:10 -0000 Subject: [wp-trac] [WordPress Trac] #56932: Using color for desabled plugins Message-ID: <052.39aa799b11181dda4fdcbfe91943db88@wordpress.org> #56932: Using color for desabled plugins -----------------------------+----------------------------- Reporter: zhelev81 | Owner: (none) Type: feature request | Status: assigned Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.1 Severity: normal | Keywords: Focuses: css | -----------------------------+----------------------------- Hello i suggest using a colored line for disabled plugins in “plugins”. This will make them more visible the the admin. For example the active plugins are with blue so we can do the inactive with pink for example. Attaching a screenshot https://i.ibb.co/Jm5S2Rw/Screenshot-7.jpg it will be nice to see this update … it will be useful for people that testing plugins all the time 🙂 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 20:48:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 20:48:20 -0000 Subject: [wp-trac] [WordPress Trac] #56932: Using color for desabled plugins In-Reply-To: <052.39aa799b11181dda4fdcbfe91943db88@wordpress.org> References: <052.39aa799b11181dda4fdcbfe91943db88@wordpress.org> Message-ID: <067.77c281e6d2eddeb9096cd165dca644dd@wordpress.org> #56932: Using color for desabled plugins -----------------------------+-------------------------------------- Reporter: zhelev81 | Owner: (none) Type: feature request | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: ui, css, administration -----------------------------+-------------------------------------- Changes (by SergeyBiryukov): * focuses: css => ui, css, administration * component: General => Plugins -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 21:47:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 21:47:07 -0000 Subject: [wp-trac] [WordPress Trac] #54221: _transient_dirsize_cache is set to autoload=yes and kills db performance if it grows (20MB in our case) In-Reply-To: <053.d27a46c8406cf993ec31d81b89154480@wordpress.org> References: <053.d27a46c8406cf993ec31d81b89154480@wordpress.org> Message-ID: <068.14eb48f36b76a9bf90826e05e06a1ccb@wordpress.org> #54221: _transient_dirsize_cache is set to autoload=yes and kills db performance if it grows (20MB in our case) --------------------------+------------------------------------------ Reporter: archon810 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Database | Version: 2.8 Severity: major | Resolution: Keywords: needs-patch | Focuses: administration, performance --------------------------+------------------------------------------ Comment (by giuse): Hello, I wonder why we need to store all the sizes of all directories. Why don't we store just the total size? It would be a number, not a so huge array. I don't see anywhere in the core the need to know all the sizes, but only the global size. When you upload or delete a file you can update that single number, and that's it. Maybe you can calculate again the total size every time you upload or delete a file, but I would never save all the details in a transient. For what reason? Probably, I missing something. Where do you need so much detailed information? As I see in the core files the function get_dirsize() is used only wp- includes/ms-functions.php. Here are the lines of code where it is used: {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Oct 29 22:24:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 29 Oct 2022 22:24:46 -0000 Subject: [wp-trac] [WordPress Trac] #55543: `add_menu_page` incorrectly requires SVG icon data URIs be base64 encoded In-Reply-To: <057.ef9086b00d57fc426cef3fa1b3fd9146@wordpress.org> References: <057.ef9086b00d57fc426cef3fa1b3fd9146@wordpress.org> Message-ID: <072.f76b4078a0a84609c01b1c43afd1b721@wordpress.org> #55543: `add_menu_page` incorrectly requires SVG icon data URIs be base64 encoded ----------------------------+----------------------------- Reporter: peterwilsoncc | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Administration | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: ----------------------------+----------------------------- Changes (by sabernhardt): * keywords: => needs-patch * milestone: Awaiting Review => Future Release -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 01:05:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 01:05:21 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.9462164f4333659358532ef81b51c8fd@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54722" 54722]: {{{ #!CommitTicketReference repository="" revision="54722" Tests: Rename classes in `phpunit/tests/ajax/` per the naming conventions. This updates the test classes to match the names of the functions being tested. Includes moving the `@covers` tags from individual test methods to the class DocBlocks. Reference: [https://make.wordpress.org/core/handbook/testing/automated- testing/writing-phpunit-tests/#naming-and-organization Writing PHP Tests: Naming and Organization]. Follow-up to [47780], [48911], [49327], [50291], [50292], [50342], [50452], [50453], [50456], [50967], [50968], [50969], [51491], [51492], [51493], [51623], [51639], [51646], [51650], [51651], [51860], [52264], [52265], [53489], [53561], [54704]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 02:52:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 02:52:18 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.7bd463b236264ce988a708dcd25f99cf@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54723" 54723]: {{{ #!CommitTicketReference repository="" revision="54723" Tests: Correctly restore the `wp_installing()` status in Ajax tests. In the tests for updating a plugin or theme via Ajax, `wp_installing( true )` was called to prevent `wp_update_plugins()` or `wp_update_themes()` from running. Since the subsequent `wp_installing( false )` call was in the same `try { ... }` block, it could not be executed if an exception was thrown, affecting other tests. In this case, after rearranging the Ajax tests in [54722], this started affecting the `get_site_option()` calls in the tests for `wp_ajax_wp_compression_test()`. By moving both `wp_installing()` calls out of the `try`/`catch` block, we can ensure the status is correctly restored. Follow-up to [734/tests], [37150], [38168], [38710], [54722]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 02:55:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 02:55:51 -0000 Subject: [wp-trac] [WordPress Trac] #56932: Using color for disabled plugins (was: Using color for desabled plugins) In-Reply-To: <052.39aa799b11181dda4fdcbfe91943db88@wordpress.org> References: <052.39aa799b11181dda4fdcbfe91943db88@wordpress.org> Message-ID: <067.e96de6b61d94c049bc9edf96ea620025@wordpress.org> #56932: Using color for disabled plugins -----------------------------+-------------------------------------- Reporter: zhelev81 | Owner: (none) Type: feature request | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: ui, css, administration -----------------------------+-------------------------------------- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 03:26:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 03:26:54 -0000 Subject: [wp-trac] [WordPress Trac] #56817: Investigate new test failure in PHP 8.2 In-Reply-To: <051.f418ad7f782dc369af9113951f836d9b@wordpress.org> References: <051.f418ad7f782dc369af9113951f836d9b@wordpress.org> Message-ID: <066.f333d342e22a70e99c26e0f9de023b34@wordpress.org> #56817: Investigate new test failure in PHP 8.2 -------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: needs-patch php82 | Focuses: -------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54724" 54724]: {{{ #!CommitTicketReference repository="" revision="54724" Tests: Temporarily skip WOFF file test on PHP 8.1. A recent change to how WOFF files are processed in PHP 8.2 RC3 has caused a new test failure. The tests was previously skipped on PHP 8.2, however, apparently after a `fileinfo` extension update, it started failing on PHP 8.1 too. This commit adjusts the skipping condition to include PHP 8.1. Follow-up to [54508], [54509]. See #56817. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 03:49:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 03:49:09 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.c6361c81a53a714d1936dff94965c291@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54725" 54725]: {{{ #!CommitTicketReference repository="" revision="54725" Tests: Prevent `wp_update_themes()` from running in `wp_ajax_update_theme()` tests. In the tests for updating a theme via Ajax, `wp_installing( true )` is called to prevent `wp_update_themes()` from running. This worked as expected in `test_update_theme()`, however, it was missed in `test_uppercase_theme_slug()`, which was accidentally relying on the `wp_installing()` status not being properly restored in the previous test. Now that the `wp_installing()` status was corrected in [54723], the latter test started throwing an error on PHP 8.2: {{{ 1) Tests_Ajax_wpAjaxUpdateTheme::test_uppercase_theme_slug http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated /var/www/src/wp-includes/Requests/Transport/cURL.php:345 /var/www/src/wp-includes/Requests/Transport/cURL.php:135 /var/www/src/wp-includes/class-requests.php:381 /var/www/src/wp-includes/class-wp-http.php:395 /var/www/src/wp-includes/class-wp-http.php:615 /var/www/src/wp-includes/http.php:179 /var/www/src/wp-includes/update.php:719 /var/www/src/wp-admin/includes/ajax-actions.php:4292 /var/www/src/wp-includes/class-wp-hook.php:308 /var/www/src/wp-includes/class-wp-hook.php:332 /var/www/src/wp-includes/plugin.php:517 /var/www/tests/phpunit/includes/testcase-ajax.php:265 /var/www/tests/phpunit/tests/ajax/wpAjaxUpdateTheme.php:157 }}} Replicating the `wp_installing()` status changes in this test too resolves the error. Follow-up to [38168], [38710], [54722], [54723]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 04:50:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 04:50:03 -0000 Subject: [wp-trac] [WordPress Trac] #56921: Inconsistency in help tab & small typo In-Reply-To: <053.205e549175043cd8235274e7ed31b210@wordpress.org> References: <053.205e549175043cd8235274e7ed31b210@wordpress.org> Message-ID: <068.b04977374c5443605db304c23de4f056@wordpress.org> #56921: Inconsistency in help tab & small typo -------------------------+--------------------------------------- Reporter: NekoJonez | Owner: SergeyBiryukov Type: enhancement | Status: assigned Priority: normal | Milestone: 6.2 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, docs, administration -------------------------+--------------------------------------- Changes (by mukesh27): * owner: (none) => SergeyBiryukov * status: new => assigned Comment: Thanks @NekoJonez for ticket and PR. PR LGTM and approved. Assign to @SergeyBiryukov for final review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 10:15:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 10:15:59 -0000 Subject: [wp-trac] [WordPress Trac] #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color In-Reply-To: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> References: <052.620f63790ab5b79be51862e829f2a681@wordpress.org> Message-ID: <067.33d5c6cd5742df95e07f5dc85b8ba3cf@wordpress.org> #56928: Twenty Twenty-Three: visited state of button links use the incorrect text color ------------------------------+--------------------- Reporter: mikachan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: css ------------------------------+--------------------- Changes (by mukesh27): * keywords: has-patch => has-patch commit Comment: Thanks @mikachan for the ticket and @sabernhardt for the patch. [attachment:"56928.patch"] LGTM and ready for commit. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 12:25:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 12:25:20 -0000 Subject: [wp-trac] [WordPress Trac] #54042: Extending wpdb::prepare() to support IN() operator (was: Extending wpdb::prepare() to support table/field names, and IN() operator) In-Reply-To: <056.f04485e63ca681f362f38671080f1fa1@wordpress.org> References: <056.f04485e63ca681f362f38671080f1fa1@wordpress.org> Message-ID: <071.c6fec1009c2e98f034f7c8f0a3dc38fe@wordpress.org> #54042: Extending wpdb::prepare() to support IN() operator -------------------------------------------------+------------------------- Reporter: craigfrancis | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing early has-unit-tests | -------------------------------------------------+------------------------- Description changed by craigfrancis: Old description: > wpdb::prepare() has really helped avoid SQL Injection vulnerabilities, > ensuring most variables are escaped correctly. > > But it does not support table/field names, so developers need to > implement their own escaping, which is not always done safely. > [https://github.com/WordPress/WordPress/blob/988c8be693e0d12aeacae30f1d4bebfb98f7e5a0 > /wp-includes/wp-db.php#L2778 If this example was copied], with no other > checks, there could be an issue if `$table` included backtick or other > invalid characters: > > {{{#!php > $table_parts = explode( '.', $table ); > $table = '`' . implode( '`.`', $table_parts ) . '`'; // INSECURE? > }}} > > Likewise, it's also fairly common to make a mistake when including values > with the `IN ()` operator, for example: > > {{{#!php > $where = 'WHERE id IN (' . implode( ',', $ids ) . ')'; // INSECURE? > }}} > > Developers need to be sure that `$ids` has come from a trusted source, or > use something like `wp_parse_id_list()` or `array_map('intval', $ids)`. > > ---- > > Considering the `wpdb::prepare()` documentation says it "Uses > sprintf()-like syntax", could we add a couple of placeholders to safely > include these values? e.g. > > {{{#!php > $wpdb->prepare('SELECT * FROM %i WHERE ID IN (%...d)', $table, $ids); > }}} > > Where `%i` would be used for Identifiers (e.g. table/field names), where > the value would be quoted with backticks, and invalid characters removed. > > And `%...d` or `%...s` would safely (and easily) include a comma > separated array of integers or strings - taking the idea of using '...' > for variadics in PHP. > > https://dev.mysql.com/doc/refman/8.0/en/identifiers.html > https://dev.mysql.com/doc/refman/8.0/en/comparison- > operators.html#operator_in New description: wpdb::prepare() helps avoid SQL Injection vulnerabilities, by escaping most variables correctly. WP 6.1 added support for Identifiers (table/field names) with `%i`, in #52506. But it's also fairly common to make a mistake to include values with the `IN()` operator, for example: {{{#!php prepare('WHERE id IN (%...d)', $ids); }}} Where `%...d` or `%...s` would safely (and easily) include a comma separated array of integers or strings - taking the idea of using '...' for variadics in PHP. https://wiki.php.net/rfc/variadics https://www.php.net/manual/en/functions.arguments.php#functions.variable- arg-list https://dev.mysql.com/doc/refman/8.0/en/comparison- operators.html#operator_in -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 12:46:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 12:46:36 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.c40883db96c7aaea43f1db2726bbf452@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing fixed-major | performance -------------------------------------------------+------------------------- Changes (by AlanP57): * status: closed => reopened * resolution: fixed => Comment: I'm experiencing a similar issue and have just tested a like query with RC5. The result is an SQL error and the output from the prepare function is like '%'my search text'%'. There is an extra set of quote marks around the search text. For more info, see https://wordpress.org/support/topic/prepare-function- removes-percent-signs-from-like-sql-statement/. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 13:51:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 13:51:27 -0000 Subject: [wp-trac] [WordPress Trac] #56217: Add video rotation info in wp_read_video_metadata() In-Reply-To: <051.692fb5cebe7fff5d9daa1cea4293fab8@wordpress.org> References: <051.692fb5cebe7fff5d9daa1cea4293fab8@wordpress.org> Message-ID: <066.151fa78310f1ebea7c89ae654829b43d@wordpress.org> #56217: Add video rotation info in wp_read_video_metadata() --------------------------------------+------------------------------ Reporter: opajaap | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.0 Severity: normal | Resolution: Keywords: has-unit-tests has-patch | Focuses: --------------------------------------+------------------------------ Comment (by opajaap): Still not fixed in 6.1-RC5 Does it take over three months to add this simple harmless foolproof code?: {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 18:45:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 18:45:20 -0000 Subject: [wp-trac] [WordPress Trac] #56824: SVGs missing title and description in WordPress dashboard In-Reply-To: <055.74ee180519091325d8907050de21947b@wordpress.org> References: <055.74ee180519091325d8907050de21947b@wordpress.org> Message-ID: <070.e3094c1b4933439cb58e9245bb2ca951@wordpress.org> #56824: SVGs missing title and description in WordPress dashboard ----------------------------------------+---------------------------- Reporter: viralsampat | Owner: (none) Type: defect (bug) | Status: new Priority: low | Milestone: 6.2 Component: Administration | Version: 6.0 Severity: normal | Resolution: Keywords: needs-patch good-first-bug | Focuses: accessibility ----------------------------------------+---------------------------- Changes (by elifvish): * Attachment "56824.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 18:46:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 18:46:03 -0000 Subject: [wp-trac] [WordPress Trac] #56824: SVGs missing title and description in WordPress dashboard In-Reply-To: <055.74ee180519091325d8907050de21947b@wordpress.org> References: <055.74ee180519091325d8907050de21947b@wordpress.org> Message-ID: <070.0f5c2989b67703c6014bb04a961efa2f@wordpress.org> #56824: SVGs missing title and description in WordPress dashboard --------------------------------------+---------------------------- Reporter: viralsampat | Owner: (none) Type: defect (bug) | Status: new Priority: low | Milestone: 6.2 Component: Administration | Version: 6.0.2 Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: accessibility --------------------------------------+---------------------------- Changes (by elifvish): * keywords: needs-patch good-first-bug => good-first-bug has-patch * version: 6.0 => 6.0.2 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Oct 30 18:46:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 30 Oct 2022 18:46:37 -0000 Subject: [wp-trac] [WordPress Trac] #56824: SVGs missing title and description in WordPress dashboard In-Reply-To: <055.74ee180519091325d8907050de21947b@wordpress.org> References: <055.74ee180519091325d8907050de21947b@wordpress.org> Message-ID: <070.1d62c792716dfed885ff28d793db79a9@wordpress.org> #56824: SVGs missing title and description in WordPress dashboard --------------------------------------+---------------------------- Reporter: viralsampat | Owner: (none) Type: defect (bug) | Status: new Priority: low | Milestone: 6.2 Component: Administration | Version: 6.0 Severity: normal | Resolution: Keywords: good-first-bug has-patch | Focuses: accessibility --------------------------------------+---------------------------- Changes (by elifvish): * version: 6.0.2 => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 04:27:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 04:27:08 -0000 Subject: [wp-trac] [WordPress Trac] #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts In-Reply-To: <052.cf83c1a6d1d164a51ef84cd3f5110260@wordpress.org> References: <052.cf83c1a6d1d164a51ef84cd3f5110260@wordpress.org> Message-ID: <067.4bd626d2e9f0f0f21c29b234bbedd753@wordpress.org> #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts ---------------------------+------------------------------ Reporter: bgturner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Comment (by poena): I did not understand in what way this is a bug? I believe it is a design decision. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 04:38:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 04:38:52 -0000 Subject: [wp-trac] [WordPress Trac] #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work In-Reply-To: <055.debb1425d8ea6348bb4d85a24ce94e15@wordpress.org> References: <055.debb1425d8ea6348bb4d85a24ce94e15@wordpress.org> Message-ID: <070.0d189abeb96de80c48413050154b7d74@wordpress.org> #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work ---------------------------+------------------------------ Reporter: mrfoxtalbot | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Comment (by poena): This issue is not theme specific. It affects any theme that has styled the block with CSS. The control is not aware of underlines or other textdecorations that are not added through the control itself or theme.json. Because this theme supports WordPress versions that are older than this textdecoration setting, it might not be easy to solve. I'll do some testing. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 05:14:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 05:14:15 -0000 Subject: [wp-trac] [WordPress Trac] #36335: Next generation: core autoloader proposal In-Reply-To: <053.bd468778dbcfa46d2ec2c3268165c76f@wordpress.org> References: <053.bd468778dbcfa46d2ec2c3268165c76f@wordpress.org> Message-ID: <068.26cbe32d46301585c80324a1d1bc9c9c@wordpress.org> #36335: Next generation: core autoloader proposal -----------------------------+------------------------------ Reporter: dnaber-de | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: -----------------------------+------------------------------ Comment (by omaeyusuke): It is my understanding that the main reason this ticket has not been baby- stepped, even in a simplified implementation, is due to a conflict between the following two things - Minimize reinvention of the wheel regarding class map generation - Minimize the number of files generated by third-party projects (Composer) Both are correct, and I think it was inevitable at the time that the discussion stopped. However, in June 2022, the class map generation implementation of Composer was released as a separate package. https://github.com/composer/class-map-generator This package is much lighter than using Composer itself as a tool, since there are only two dependency packages (except for development only). Therefore, in my opinion, most of the discussions of 6 years ago can be solved by using only this package. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 07:34:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 07:34:57 -0000 Subject: [wp-trac] [WordPress Trac] #56919: REST API term embed 401 - not allowed to view terms for this post In-Reply-To: <052.fd158ab8189e776eedb85f16aca5c94d@wordpress.org> References: <052.fd158ab8189e776eedb85f16aca5c94d@wordpress.org> Message-ID: <067.1621c4698e8dca03d7d01c8d86368dfc@wordpress.org> #56919: REST API term embed 401 - not allowed to view terms for this post --------------------------+------------------------------ Reporter: prionkor | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.0.3 Severity: blocker | Resolution: Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Changes (by prionkor): * keywords: => dev-feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 09:35:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 09:35:03 -0000 Subject: [wp-trac] [WordPress Trac] #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work In-Reply-To: <055.debb1425d8ea6348bb4d85a24ce94e15@wordpress.org> References: <055.debb1425d8ea6348bb4d85a24ce94e15@wordpress.org> Message-ID: <070.0b8c8cba46c35ed01f75ddcd2d4b3502@wordpress.org> #56904: Twenty Twenty-Two: Block Navigation "no decoration" does not work ---------------------------+------------------------------ Reporter: mrfoxtalbot | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Comment (by poena): First, I confirmed that the original design has no underline on the default state of the link: https://www.figma.com/file/J9Nr1Xi63Y3dqeWwPLMKa3/Twenty-Twenty-Two-(Copy )?node-id=729%3A4819 == TT2 with WP 6.1 RC5 without Gutenberg: The link's default state has no underline. Enabling the text decoration none setting actually *adds* an underline to the link default state in the editor and front. The link underline comes from: {{{ .editor-styles-wrapper a { color: var(--wp--preset--color--foreground); text-decoration: underline; } }}} and {{{ a:where(:not(.wp-element-button)) { color: var(--wp--preset--color--foreground); text-decoration: underline; } }}} If we want to fix this in the theme, adding the following to style.css works in **6.1**: {{{ .wp-block-navigation.has-text-decoration-none .wp-block-navigation-item a { text-decoration: none; } }}} == TT2 with WP 6.1 RC5 with Gutenberg 14.4.0 active. The link's default state has an underline in the editor (incorrect) but not on the front (correct). The link underline comes from: {{{ .editor-styles-wrapper a { color: var(--wp--preset--color--foreground); text-decoration: underline; } }}} On the front, the link underline is removed by: {{{ .wp-block-navigation:where(:not([class*=has-text-decoration])) a { text-decoration: none; } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 10:30:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 10:30:31 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.4fbfc851873b4f6d69f876cd51d2be06@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing fixed-major | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): @AlanP57 Can you provide more detail. I can't replicate this. Is there some code I can look at? Is there a reason why you are doing a raw SQL query over using WP_Query. There are going to other issues if you do this... -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 11:34:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 11:34:10 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.2031a5419c4a12e7d5548064ba6132ec@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: reopened Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing fixed-major | performance -------------------------------------------------+------------------------- Comment (by AlanP57): In some cases, I prefer not to use WP_Query when display data. This is the code from the plugin: {{{#!php prepare("(select $wpdb->posts.ID, post_title, {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from $wpdb->posts LEFT JOIN {$wpdb->prefix}mgmlp_folders ON($wpdb->posts.ID = {$wpdb->prefix}mgmlp_folders.post_id) LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') union all (select $wpdb->posts.ID, post_title, {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from $wpdb->posts LEFT JOIN {$wpdb->prefix}mgmlp_folders ON( $wpdb->posts.ID = {$wpdb->prefix}mgmlp_folders.post_id) LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') order by attached_file", $search_string, $search_string); }}} And here is an example of the SQL: (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON(wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my search text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') union all (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON( wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my search text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') order by attached_file This use to work in versions before 6.1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 12:53:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 12:53:58 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries Message-ID: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------+-------------------------------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Keywords: needs-testing needs-unit-tests Focuses: | --------------------------+-------------------------------------------- I'm experiencing a similar issue and have just tested a like query with RC5. The result is an SQL error and the output from the prepare function is like '%'my search text'%'. There is an extra set of quote marks around the search text. In some cases, I prefer not to use WP_Query when displaying data. This is the code from the plugin: {{{#!php prepare("(select $wpdb->posts.ID, post_title, {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from $wpdb->posts LEFT JOIN {$wpdb->prefix}mgmlp_folders ON($wpdb->posts.ID = {$wpdb->prefix}mgmlp_folders.post_id) LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') union all (select $wpdb->posts.ID, post_title, {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from $wpdb->posts LEFT JOIN {$wpdb->prefix}mgmlp_folders ON( $wpdb->posts.ID = {$wpdb->prefix}mgmlp_folders.post_id) LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') order by attached_file", $search_string, $search_string); }}} And here is an example of the SQL: (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON(wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my search text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') union all (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON( wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my search text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') order by attached_file This use to work in versions before 6.1. Original support topic: https://wordpress.org/support/topic/prepare- function-removes-percent-signs-from-like-sql-statement/. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 12:55:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 12:55:34 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.5c05931d9ad8fdfd0d2399a28948e096@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54726" 54726]: {{{ #!CommitTicketReference repository="" revision="54726" Tests: Split the tests from `multisite.php` into individual test classes. This aims to bring some consistency to the location of multisite function tests, as well as to make the tests more discoverable and easier to expand. Follow-up to [29916], [32638], [46251], [54717]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 12:56:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 12:56:44 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.f340d6cbffca5e7854b8edd765a83cd6@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: needs-testing needs-unit-tests | Focuses: --------------------------------------------+--------------------- Comment (by desrosj): Some notes, I have gone and made this ticket on behalf of @AlanP57 for the following reasons: - It's not completely clear if this is being caused by #56802 (Post IDs cached for search and other 'LIKE' queries are unreachable) or #52506 (Add escaping method for table names in SQL queries). - 6.1 is due out in ~24 hours. - The other tickets are closed and completed on the 6.1 milestone and they should remain there if those changes ship in the release. - This separate ticket allows it to be milestoned and triaged appropriately as more information is discovered. - This seems to be an edge case from custom code and not one from using `WP_Query` directly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 12:58:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 12:58:51 -0000 Subject: [wp-trac] [WordPress Trac] #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable In-Reply-To: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> References: <047.437d5048faef7ab854dd65b02e52cc6d@wordpress.org> Message-ID: <062.6e3855e890d30ca0e5b2464bc95860de@wordpress.org> #56802: Query: Post IDs cached for search and other 'LIKE' queries are unreachable -------------------------------------------------+------------------------- Reporter: dlh | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: high | Milestone: 6.1 Component: Query | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs- | Focuses: testing | performance -------------------------------------------------+------------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests needs-testing fixed-major => has- patch has-unit-tests needs-testing * status: reopened => closed * resolution: => fixed Comment: I hope you don't mind, @AlanP57, but I've gone and created #56933 on your behalf. I detailed some reasons why in a comment on that ticket. I'm going to close this out as fixed again. If you were a participant on this ticket, please see how you can help push #56933 along and rule out the changesets related to this bug (especially with 6.1 due out in a ~24 hours). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 13:00:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 13:00:54 -0000 Subject: [wp-trac] [WordPress Trac] #52506: Add escaping method for table names in SQL queries In-Reply-To: <054.a6f157534378801d055b15fc9931024f@wordpress.org> References: <054.a6f157534378801d055b15fc9931024f@wordpress.org> Message-ID: <069.a1034f6c3cf6c090624b0c7ab813cf9d@wordpress.org> #52506: Add escaping method for table names in SQL queries -------------------------------------------------+------------------------- Reporter: tellyworth | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests early | Focuses: commit needs-docs has-dev-note | performance -------------------------------------------------+------------------------- Comment (by desrosj): There's been an issue raised that seems potentially related to the changes on this ticket. I've gone and opened #56933 to explore that. It's not yet clear if the changes related to this enhancement or the ones associated with #56802 are to blame. If you were a participant on this ticket, please see how you can help push #56933 along and rule out the changesets related to this enhancement (especially with 6.1 due out in a ~24 hours). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 13:17:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 13:17:34 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.a96e9d4b00316c572c2f77a0a9b2dd38@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, accessibility, docs, | administration, ui-copy -------------------------+------------------------------------------------- Comment (by laurlittle): @ryelle Here is the YouTube link for the 6.1 highlight video: https://youtu.be/1w9oywSa6Hw It's private right now, but will be make public just ahead of the release (likely during the release party on Nov 1). Let me know if there's anything else you need. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 13:22:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 13:22:36 -0000 Subject: [wp-trac] [WordPress Trac] #56792: Docblock improvements for 6.2 In-Reply-To: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> References: <051.3eb586c80ad0d99c1f004a88230732a5@wordpress.org> Message-ID: <066.e4dd29dab19907daf01bb2da71900e9c@wordpress.org> #56792: Docblock improvements for 6.2 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: docs --------------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54727" 54727]: {{{ #!CommitTicketReference repository="" revision="54727" Docs: Update a link to the Custom Elements spec in `unsupported_valid_tag_names()` unit test docblock. This changeset replaces a link to the outdated W3C specs on Custom Elements with a link to the corresponding WhatWG specification. Previously committed in [53205], this appears to be accidentally reverted in [53562]. Follow-up to [53204], [53205], [53562]. Props audrasjb. See #56792. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 13:54:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 13:54:17 -0000 Subject: [wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2 In-Reply-To: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> References: <051.57669a92d7872a79340235cadb00a5c1@wordpress.org> Message-ID: <066.80b9f615ad65fdd2ee7d1fbc88305bd9@wordpress.org> #56793: Test tool and unit test improvements for 6.2 ------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.2 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54728" 54728]: {{{ #!CommitTicketReference repository="" revision="54728" Tests: Move some `@covers` tags in the `formatting` group to the class DocBlock. This aims to bring more consistency, as these test classes typically cover a single function, unless noted otherwise. Follow-up to [53562], [53571], [54051]. See #56793. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:04:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:04:05 -0000 Subject: [wp-trac] [WordPress Trac] #56932: Using color for disabled plugins In-Reply-To: <052.39aa799b11181dda4fdcbfe91943db88@wordpress.org> References: <052.39aa799b11181dda4fdcbfe91943db88@wordpress.org> Message-ID: <067.83fd9444803220aa93378b26fead1030@wordpress.org> #56932: Using color for disabled plugins -----------------------------+-------------------------------------- Reporter: zhelev81 | Owner: (none) Type: feature request | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, css, administration -----------------------------+-------------------------------------- Changes (by desrosj): * version: 6.1 => Comment: Version indicates the first version of WordPress affected by a problem. Since this is not new to 6.1, going to clear that field. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:05:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:05:02 -0000 Subject: [wp-trac] [WordPress Trac] #56931: Introduce action hook `manage_terms_extra_tablenav` In-Reply-To: <053.6aa2b17e910fa0645f580b144f161845@wordpress.org> References: <053.6aa2b17e910fa0645f580b144f161845@wordpress.org> Message-ID: <068.09011812c0b385c15ccbe63a8d87944f@wordpress.org> #56931: Introduce action hook `manage_terms_extra_tablenav` -----------------------------+----------------------------- Reporter: podpirate | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Future Release Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration -----------------------------+----------------------------- Changes (by desrosj): * keywords: => has-patch * version: trunk => * milestone: Awaiting Review => Future Release Comment: Version indicates the first version of WordPress affected by a problem. Since this is not new to 6.1, going to clear that field. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:06:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:06:33 -0000 Subject: [wp-trac] [WordPress Trac] #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts In-Reply-To: <052.cf83c1a6d1d164a51ef84cd3f5110260@wordpress.org> References: <052.cf83c1a6d1d164a51ef84cd3f5110260@wordpress.org> Message-ID: <067.fbab2de791cc01961c37f7977e72c8b0@wordpress.org> #56929: Twenty Twenty-Three: Sticky posts not visually different than regular posts -------------------------------+------------------------------ Reporter: bgturner | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by desrosj): * keywords: => reporter-feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:09:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:09:55 -0000 Subject: [wp-trac] [WordPress Trac] #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 In-Reply-To: <057.a18be0ce4742f66dcfcddb410d1d9456@wordpress.org> References: <057.a18be0ce4742f66dcfcddb410d1d9456@wordpress.org> Message-ID: <072.b77312e85f56869c49290b103f5c0f51@wordpress.org> #56876: WP_List_Table should prevent using dynamic properties as they are not allowed in PHP 8.2 --------------------------------------------+--------------------- Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests php82 | Focuses: --------------------------------------------+--------------------- Changes (by desrosj): * keywords: has-patch has-unit-tests => has-patch has-unit-tests php82 * version: trunk => * milestone: Awaiting Review => 6.1.1 Comment: Though 8.2 aims to bring WordPress to a more compatible state with PHP 8.2, this is not a new issue in `6.1`/`trunk`, so unsetting the Version field. Let's take a look at this for 6.1.1 or 6.2, whichever the committers familiar with these efforts are more comfortable with. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:14:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:14:15 -0000 Subject: [wp-trac] [WordPress Trac] #56918: more tag not working In-Reply-To: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> References: <051.2d955036bdb06170b2326dacecde5927@wordpress.org> Message-ID: <066.825e82338b840e289668e6c539480e56@wordpress.org> #56918: more tag not working --------------------------+---------------------- Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by desrosj): * version: trunk => * component: General => Editor * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:15:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:15:34 -0000 Subject: [wp-trac] [WordPress Trac] #56851: link_updated not recording a timestamp In-Reply-To: <053.46d089337f169c10cdeef5a921f72a31@wordpress.org> References: <053.46d089337f169c10cdeef5a921f72a31@wordpress.org> Message-ID: <068.d620cec6e618dcaf91b1a1f491b0e532@wordpress.org> #56851: link_updated not recording a timestamp ----------------------------+------------------------------ Reporter: lenasterg | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+------------------------------ Changes (by desrosj): * version: trunk => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:27:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:27:21 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.683e6d4ddeb651034050c62e8d3b7711@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, accessibility, docs, | administration, ui-copy -------------------------+------------------------------------------------- Changes (by ryelle): * Attachment "56357-video-link.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:28:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:28:05 -0000 Subject: [wp-trac] [WordPress Trac] #56902: Twenty Twenty Three: Tag and category template creation for specific items are wrongly displayed as not found despite being successfully created In-Reply-To: <051.d0c4ccd6b48f2f8dd687ff738650e791@wordpress.org> References: <051.d0c4ccd6b48f2f8dd687ff738650e791@wordpress.org> Message-ID: <066.192940abd9378d4298a93da8a27efbd7@wordpress.org> #56902: Twenty Twenty Three: Tag and category template creation for specific items are wrongly displayed as not found despite being successfully created -------------------------------------------+------------------------------- Reporter: franz00 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: reported- | upstream Keywords: has-screenshots needs-testing | Focuses: -------------------------------------------+------------------------------- Changes (by desrosj): * status: new => closed * resolution: => reported-upstream * milestone: Awaiting Review => Comment: Going to close this out as `reported-upstream`. This likely can only be solved through changes to the block editor itself and not within themes. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:37:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:37:22 -0000 Subject: [wp-trac] [WordPress Trac] #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp-includes/blocks/avatar.php' In-Reply-To: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> References: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> Message-ID: <067.d56f52a758153a9d3b4d8bbecc3bd1ec@wordpress.org> #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp- includes/blocks/avatar.php' -----------------------------------------------+--------------------------- Reporter: hztyfoon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Editor | Version: 6.0 Severity: normal | Resolution: Keywords: has-patch reporter-feedback close | Focuses: coding- | standards -----------------------------------------------+--------------------------- Changes (by desrosj): * keywords: has-patch => has-patch reporter-feedback close * version: 6.1 => 6.0 Comment: Seems this was introduced in [53157] as part of 6.0. @hztyfoon can you confirm you've opened a ticket to address upstream? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:41:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:41:29 -0000 Subject: [wp-trac] [WordPress Trac] #56701: Sanitize HTML Classes added to single row columns in WP_List_Table In-Reply-To: <059.121c60e8cf1741f4c66fdbb7a1a48c1d@wordpress.org> References: <059.121c60e8cf1741f4c66fdbb7a1a48c1d@wordpress.org> Message-ID: <074.33a4251e0251cf4b01a8ce5a96da80f9@wordpress.org> #56701: Sanitize HTML Classes added to single row columns in WP_List_Table -----------------------------+----------------------------- Reporter: bananastalktome | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: administration -----------------------------+----------------------------- Changes (by desrosj): * focuses: => administration * version: 6.1 => * milestone: Awaiting Review => 6.1.1 Comment: Thanks @bananastalktome. Version is used to note the first version of WordPress affected by an issue. That's going to be quite a bit earlier than 6.1 for this, so I've reset that value. Moving to 6.1.1 for further investigation. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:43:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:43:35 -0000 Subject: [wp-trac] [WordPress Trac] #56846: All test classes that use the "wp" prefix should be renamed for consistency In-Reply-To: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> References: <057.6fb849cfde954d9581bf92a7b67629d0@wordpress.org> Message-ID: <072.e8d2931d38d38aa47ff9806be684881f@wordpress.org> #56846: All test classes that use the "wp" prefix should be renamed for consistency ---------------------------+------------------------------- Reporter: antonvlasenko | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: minor | Resolution: Keywords: | Focuses: coding-standards ---------------------------+------------------------------- Changes (by desrosj): * version: 6.1 => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:45:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:45:53 -0000 Subject: [wp-trac] [WordPress Trac] #56655: add_menu_page - escaping $page_title, $menu_title In-Reply-To: <052.fbff2d44b31dd5f908c7be679d439dc5@wordpress.org> References: <052.fbff2d44b31dd5f908c7be679d439dc5@wordpress.org> Message-ID: <067.22a5ea2cee3e72bc83bd864fc0beeb32@wordpress.org> #56655: add_menu_page - escaping $page_title, $menu_title ---------------------------------------+----------------------------- Reporter: soupia18 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1.1 Component: Menus | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: administration ---------------------------------------+----------------------------- Changes (by desrosj): * version: 6.1 => * severity: critical => normal * milestone: Awaiting Review => 6.1.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:47:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:47:06 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 Message-ID: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -----------------------------+--------------------------- Reporter: davidbaumwald | Owner: davidbaumwald Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Keywords: needs-patch Focuses: | -----------------------------+--------------------------- The `$_old_files` array needs to be updated for 6.1. Running the check command from the Handbook in the Dry Run for 6.1 produced this: {{{ $ svn diff --summarize https://core.svn.wordpress.org/tags/6.0 https://core.svn.wordpress.org/trunk | grep '^D' D https://core.svn.wordpress.org/tags/6.0/wp- content/themes/twentytwentyone/assets/sass/05-blocks/spacer/_style.scss D https://core.svn.wordpress.org/tags/6.0/wp- content/themes/twentytwentyone/assets/sass/05-blocks/spacer D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments.php D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments/style.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments/style-rtl.min.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments/style.min.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments/editor-rtl.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments/editor.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments/editor-rtl.min.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments/editor.min.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments/block.json D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments/style-rtl.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks/post- comments D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks /comments-query-loop/editor.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks /comments-query-loop/editor.min.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks /comments-query-loop/block.json D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks /comments-query-loop/editor-rtl.css D https://core.svn.wordpress.org/tags/6.0/wp-includes/blocks /comments-query-loop/editor-rtl.min.css }}} This seems to be accurate, but it should be confirmed. The TT1 spacer block styles were removed in [54103]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:49:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:49:51 -0000 Subject: [wp-trac] [WordPress Trac] #56926: Infinite loop in wp_nav_menu In-Reply-To: <055.459971de3aa13ba3422d46cf1791db63@wordpress.org> References: <055.459971de3aa13ba3422d46cf1791db63@wordpress.org> Message-ID: <070.42d19c58c3a6f21d165b5de1bc3e77df@wordpress.org> #56926: Infinite loop in wp_nav_menu -------------------------------+------------------------------ Reporter: david.binda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Menus | Version: 6.1 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by desrosj): * keywords: => reporter-feedback Comment: @davidbinda were you able to determine any more specifics here? This ticket was scrubbed today during the dry run for 6.1 and this was determined non-blocking since the root cause of the issue is unclear. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:54:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:54:07 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 In-Reply-To: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> References: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> Message-ID: <072.38b5838b7f32a88cc0b2f3ee35ae5abd@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -----------------------------+---------------------------- Reporter: davidbaumwald | Owner: davidbaumwald Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: -----------------------------+---------------------------- Changes (by davidbaumwald): * Attachment "56934.diff" added. Patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 14:58:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 14:58:38 -0000 Subject: [wp-trac] [WordPress Trac] #55968: xss string to be treated as simple string In-Reply-To: <057.5e57c2ead8a34bdd9497ff0c16f23a6f@wordpress.org> References: <057.5e57c2ead8a34bdd9497ff0c16f23a6f@wordpress.org> Message-ID: <072.6e31f8e1c0976c9d8435df968a1bb6b9@wordpress.org> #55968: xss string to be treated as simple string --------------------------------------+------------------------------ Reporter: vibhanshujain | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Changes (by desrosj): * version: 6.1 => * component: Posts, Post Types => Editor -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:00:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:00:04 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.f1d93e13e118228b169e194d7a6655c4@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, accessibility, docs, commit | administration, ui-copy -------------------------+------------------------------------------------- Changes (by ryelle): * keywords: has-patch => has-patch commit Comment: Got confirmation via DM: > It will say "private" until it goes live. The link will remain the same when made public. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:01:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:01:50 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.e1305ac6a1ff4ed58a59cccda00411ab@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: assigned (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, accessibility, docs, commit | administration, ui-copy -------------------------+------------------------------------------------- Comment (by ryelle): In [changeset:"54729" 54729]: {{{ #!CommitTicketReference repository="" revision="54729" Help/About: Add link to the 6.1 release video Link the image and text to the new 6.1 release video on youtube. The video is currently private, but will be made public during the release party. Props admwgn, critterverse, joen, annezazu, jpantani, laurlittle, cbringmann, kellychoffman, pablohoney, EidolonNight. See #56357. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:02:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:02:53 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.8655f16ee94e374e710f7cc2178b5b68@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: needs-testing needs-unit-tests | Focuses: --------------------------------------------+--------------------- Description changed by hellofromTonya: Old description: > I'm experiencing a similar issue and have just tested a like query with > RC5. The result is an SQL error and the output from the prepare function > is > like '%'my search text'%'. There is an extra set of quote marks around > the search text. > > In some cases, I prefer not to use WP_Query when displaying data. This is > the code from the plugin: > > {{{#!php > $sql = $wpdb->prepare("(select $wpdb->posts.ID, post_title, > {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, > 'a' as item_type > from $wpdb->posts > LEFT JOIN {$wpdb->prefix}mgmlp_folders ON($wpdb->posts.ID = > {$wpdb->prefix}mgmlp_folders.post_id) > LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) > LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) > where post_type = 'mgmlp_media_folder' and pm.meta_key = > '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like > '%%%s%%') > union all > (select $wpdb->posts.ID, post_title, > {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, > 'b' as item_type > from $wpdb->posts > LEFT JOIN {$wpdb->prefix}mgmlp_folders ON( $wpdb->posts.ID = > {$wpdb->prefix}mgmlp_folders.post_id) > LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) > LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) > where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and > SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') order by > attached_file", $search_string, $search_string); > > }}} > > And here is an example of the SQL: > (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, > pm.meta_value as attached_file, 'a' as item_type > from wp_posts > LEFT JOIN wp_mgmlp_folders ON(wp_posts.ID = wp_mgmlp_folders.post_id) > LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) > LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) > where post_type = 'mgmlp_media_folder' and pm.meta_key = > '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like > '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my > search > text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') > union all > (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, > pm.meta_value as attached_file, 'b' as item_type > from wp_posts > LEFT JOIN wp_mgmlp_folders ON( wp_posts.ID = wp_mgmlp_folders.post_id) > LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) > LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) > where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and > SUBSTRING_INDEX(pm.meta_value, '/', -1) like > '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my > search > text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') > order by attached_file > > This use to work in versions before 6.1. > > Original support topic: https://wordpress.org/support/topic/prepare- > function-removes-percent-signs-from-like-sql-statement/. New description: I'm experiencing a similar issue and have just tested a like query with WP 6.1-RC5. The result is an SQL error and the output from the prepare function is like `'%'my search text'%'`. Notice, there is an extra set of quote marks around the search text. In some cases, I prefer not to use `WP_Query` when displaying data. This is the code from the plugin: {{{#!php prepare("(select $wpdb->posts.ID, post_title, {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from $wpdb->posts LEFT JOIN {$wpdb->prefix}mgmlp_folders ON($wpdb->posts.ID = {$wpdb->prefix}mgmlp_folders.post_id) LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') union all (select $wpdb->posts.ID, post_title, {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from $wpdb->posts LEFT JOIN {$wpdb->prefix}mgmlp_folders ON( $wpdb->posts.ID = {$wpdb->prefix}mgmlp_folders.post_id) LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') order by attached_file", $search_string, $search_string); }}} And here is an example of the SQL: {{{#!sql (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON(wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my search text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') union all (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON( wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my search text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') order by attached_file }}} This use to work in versions before 6.1. Original support topic: https://wordpress.org/support/topic/prepare- function-removes-percent-signs-from-like-sql-statement/. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:02:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:02:54 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.10908db7ea28e9096a7ce4dfba76a8d6@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch commit dev- | Focuses: ui, accessibility, feedback | docs, administration, ui-copy -------------------------------------+------------------------------------- Changes (by ryelle): * keywords: has-patch commit => has-patch commit dev-feedback Comment: Marking [54729] for backport to the 6.1 branch pending 2nd committer review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:07:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:07:01 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.c3ac604b7a13676b662f451de645eab0@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by hellofromTonya): * keywords: needs-testing needs-unit-tests => Old description: > I'm experiencing a similar issue and have just tested a like query with > WP 6.1-RC5. The result is an SQL error and the output from the prepare > function is like `'%'my search text'%'`. Notice, there is an extra set of > quote marks around the search text. > > In some cases, I prefer not to use `WP_Query` when displaying data. This > is the code from the plugin: > > {{{#!php > $sql = $wpdb->prepare("(select $wpdb->posts.ID, post_title, > {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, > 'a' as item_type > from $wpdb->posts > LEFT JOIN {$wpdb->prefix}mgmlp_folders ON($wpdb->posts.ID = > {$wpdb->prefix}mgmlp_folders.post_id) > LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) > LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) > where post_type = 'mgmlp_media_folder' and pm.meta_key = > '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like > '%%%s%%') > union all > (select $wpdb->posts.ID, post_title, > {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, > 'b' as item_type > from $wpdb->posts > LEFT JOIN {$wpdb->prefix}mgmlp_folders ON( $wpdb->posts.ID = > {$wpdb->prefix}mgmlp_folders.post_id) > LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) > LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) > where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and > SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') order by > attached_file", $search_string, $search_string); > > }}} > > And here is an example of the SQL: > {{{#!sql > (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, > pm.meta_value as attached_file, 'a' as item_type > from wp_posts > LEFT JOIN wp_mgmlp_folders ON(wp_posts.ID = wp_mgmlp_folders.post_id) > LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) > LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) > where post_type = 'mgmlp_media_folder' and pm.meta_key = > '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like > '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my > search > text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') > union all > (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, > pm.meta_value as attached_file, 'b' as item_type > from wp_posts > LEFT JOIN wp_mgmlp_folders ON( wp_posts.ID = wp_mgmlp_folders.post_id) > LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) > LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) > where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and > SUBSTRING_INDEX(pm.meta_value, '/', -1) like > '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my > search > text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') > order by attached_file > }}} > > This use to work in versions before 6.1. > > Original support topic: https://wordpress.org/support/topic/prepare- > function-removes-percent-signs-from-like-sql-statement/. New description: I'm experiencing a similar issue and have just tested a like query with WP 6.1-RC5. The result is an SQL error and the output from the prepare function is like `'%'my search text'%'`. Notice, there is an extra set of quote marks around the search text. In some cases, I prefer not to use `WP_Query` when displaying data. This is the code from the plugin: {{{#!php prepare("(select $wpdb->posts.ID, post_title, {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from $wpdb->posts LEFT JOIN {$wpdb->prefix}mgmlp_folders ON($wpdb->posts.ID = {$wpdb->prefix}mgmlp_folders.post_id) LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') union all (select $wpdb->posts.ID, post_title, {$wpdb->prefix}mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from $wpdb->posts LEFT JOIN {$wpdb->prefix}mgmlp_folders ON( $wpdb->posts.ID = {$wpdb->prefix}mgmlp_folders.post_id) LEFT JOIN $wpdb->postmeta AS pm ON (pm.post_id = $wpdb->posts.ID) LEFT JOIN $wpdb->users AS us ON ($wpdb->posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '%%%s%%') order by attached_file", $search_string, $search_string); }}} And here is an example of the SQL: {{{#!sql (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON(wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my search text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') union all (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON( wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}'my search text'{48bf6209debff2ee81208ffaee83c0ccfe32af6953d915a72a2fd46f1d0be2e1}') order by attached_file }}} >In WordPress 6.0.3 my SQL query works This worked on WP 6.0.3, but doesn't on 6.1-RC5. Original support topic: https://wordpress.org/support/topic/prepare- function-removes-percent-signs-from-like-sql-statement/. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:07:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:07:19 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.ab5dd813ff846b55c8839fb8df6e88e0@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch commit dev- | Focuses: ui, accessibility, reviewed | docs, administration, ui-copy -------------------------------------+------------------------------------- Changes (by davidbaumwald): * keywords: has-patch commit dev-feedback => has-patch commit dev-reviewed Comment: Looks good! Thanks @ryelle for wrangling this! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:11:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:11:19 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 In-Reply-To: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> References: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> Message-ID: <072.eb37c6994b4facec02ef4866ee40532e@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -----------------------------+---------------------------- Reporter: davidbaumwald | Owner: davidbaumwald Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: -----------------------------+---------------------------- Changes (by SergeyBiryukov): * Attachment "56934.2.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:12:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:12:29 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 In-Reply-To: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> References: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> Message-ID: <072.db819e2c5df89f3275edbec70a6f316b@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -----------------------------+---------------------------- Reporter: davidbaumwald | Owner: davidbaumwald Type: task (blessed) | Status: assigned Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: -----------------------------+---------------------------- Changes (by SergeyBiryukov): * keywords: needs-patch => has-patch Comment: Thanks for the ticket! I get the same list, but I think the directories should also be included in the patch. See [attachment:"56934.2.diff"], which also reorders the files alphabetically for consistency with previous entries. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:16:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:16:52 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 In-Reply-To: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> References: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> Message-ID: <072.a1d58e1c60c3dbc5f05d60593e515868@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -----------------------------+---------------------------- Reporter: davidbaumwald | Owner: davidbaumwald Type: task (blessed) | Status: closed Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: -----------------------------+---------------------------- Changes (by davidbaumwald): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"54730" 54730]: {{{ #!CommitTicketReference repository="" revision="54730" Upgrade/Install: Update `$_old_files` for 6.1. Props davidbaumwald, SergeyBiryukov. Fixes #56934. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:17:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:17:42 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 In-Reply-To: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> References: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> Message-ID: <072.00468deb92d02a908866ce2658cb5231@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -------------------------------------------------+------------------------- Reporter: davidbaumwald | Owner: | davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: Keywords: has-patch commit dev-feedback | Focuses: fixed-major | -------------------------------------------------+------------------------- Changes (by davidbaumwald): * keywords: has-patch => has-patch commit dev-feedback fixed-major * status: closed => reopened * resolution: fixed => Comment: Reopening for backport to the 6.1 branch, pending a second committer's review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:17:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:17:59 -0000 Subject: [wp-trac] [WordPress Trac] #56927: Post Featured Image always lazy loaded in T22 and T23 Single template In-Reply-To: <050.91899407a5827ff774c100b54d5d8b38@wordpress.org> References: <050.91899407a5827ff774c100b54d5d8b38@wordpress.org> Message-ID: <065.8c611f373e108aac3eeced4cb724488d@wordpress.org> #56927: Post Featured Image always lazy loaded in T22 and T23 Single template --------------------------+--------------------- Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Editor | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by Bernhard Reiter): * version: 6.1 => * component: Post Thumbnails => Editor * milestone: Awaiting Review => 6.2 Comment: This issue seems to predate the 6.1 cycle, and at this point, we can only fix regressions introduced during that cycle. I'm thus setting the milestone to 6.2. Also setting the component to Editor, since the issue needs fixing in the Post Featured Image block, which is part of Gutenberg. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:18:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:18:00 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.b3ef0a98989d783575706450791060ac@wordpress.org> #56357: About Page for 6.1 release -------------------------------------+------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: Keywords: has-patch commit dev- | Focuses: ui, accessibility, reviewed | docs, administration, ui-copy -------------------------------------+------------------------------------- Comment (by ryelle): In [changeset:"54731" 54731]: {{{ #!CommitTicketReference repository="" revision="54731" Help/About: Add link to the 6.1 release video Link the image and text to the new 6.1 release video on youtube. The video is currently private, but will be made public during the release party. Props admwgn, critterverse, joen, annezazu, jpantani, laurlittle, cbringmann, kellychoffman, pablohoney, EidolonNight. Reviewed by davidbaumwald. Merges [54729] to the 6.1 branch. See #56357. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:21:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:21:17 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.2fd3222337fd18c6ea86b282a46e0ade@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: closed (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: fixed Keywords: | Focuses: ui, accessibility, docs, | administration, ui-copy -------------------------+------------------------------------------------- Changes (by ryelle): * keywords: has-patch commit dev-reviewed => * status: assigned => closed * resolution: => fixed Comment: And with [54731], the About page is complete 🙂 Thanks to everyone who worked on it! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:23:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:23:05 -0000 Subject: [wp-trac] [WordPress Trac] #56927: Post Featured Image always lazy loaded in T22 and T23 Single template In-Reply-To: <050.91899407a5827ff774c100b54d5d8b38@wordpress.org> References: <050.91899407a5827ff774c100b54d5d8b38@wordpress.org> Message-ID: <065.47c5d0c68a8135d240fb552255a381dd@wordpress.org> #56927: Post Featured Image always lazy loaded in T22 and T23 Single template --------------------------+------------------------ Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Changes (by Bernhard Reiter): * status: new => closed * resolution: => duplicate * milestone: 6.2 => Comment: @mikeschroder kindly pointed me to #56930. Closing this ticket as a duplicate, per [https://core.trac.wordpress.org/ticket/56930#comment:3 this comment]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:46:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:46:38 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.bf8d819141ed1d93b0e32156563b4219@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by hellofromTonya): Using a fresh install of WP 6.1-RC5 with the sample code hooked into `'loop_start'`, I can reproduce the reported results. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:46:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:46:39 -0000 Subject: [wp-trac] [WordPress Trac] #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp-includes/blocks/avatar.php' In-Reply-To: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> References: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> Message-ID: <067.fb0aa9e1f9d2cea718327b5542885641@wordpress.org> #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp- includes/blocks/avatar.php' --------------------------+-------------------------------- Reporter: hztyfoon | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0 Severity: normal | Resolution: reported-upstream Keywords: close | Focuses: coding-standards --------------------------+-------------------------------- Changes (by hztyfoon): * keywords: has-patch reporter-feedback close => close * status: new => closed * resolution: => reported-upstream Comment: Sorry, was little busy & almost forgot about it. Thanks @SergeyBiryukov for the tip. Thanks @desrosj @robinwpdeveloper for the reminder. I just reported upstream here: https://github.com/WordPress/gutenberg/issues/45426 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:48:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:48:10 -0000 Subject: [wp-trac] [WordPress Trac] #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp-includes/blocks/avatar.php' In-Reply-To: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> References: <052.93c2de451fb31ae67e5058b16f30b3ad@wordpress.org> Message-ID: <067.b4b1ab18af5a2f6e94f9f5dc7b4e8117@wordpress.org> #56829: use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp- includes/blocks/avatar.php' --------------------------+-------------------------------- Reporter: hztyfoon | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 6.0 Severity: normal | Resolution: reported-upstream Keywords: | Focuses: coding-standards --------------------------+-------------------------------- Changes (by desrosj): * keywords: close => * milestone: Awaiting Review => Comment: No worries! Thanks for following up. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 15:56:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 15:56:17 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 In-Reply-To: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> References: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> Message-ID: <072.47d631dc7b663de9080f01f032b711d7@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -------------------------------------------------+------------------------- Reporter: davidbaumwald | Owner: | davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: Keywords: has-patch commit dev-feedback | Focuses: fixed-major | -------------------------------------------------+------------------------- Comment (by desrosj): I'm wondering about including the deleted theme files here. Except 6.0, I don't see any additional `wp-content/themes/*` entries in the list. As far as I know, themes are not included with update packages unless it's the first release being included (and they are not intentionally skipped with the `CORE_UPGRADE_SKIP_NEW_BUNDLED` constant). The rest of [54730] looks good to me, though. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 16:02:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 16:02:19 -0000 Subject: [wp-trac] [WordPress Trac] #56357: About Page for 6.1 release In-Reply-To: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> References: <054.e11f83d48662a2e074c6796fb8fa4284@wordpress.org> Message-ID: <069.08ddf6a0a3478d126ef5b87cc03f52c9@wordpress.org> #56357: About Page for 6.1 release -------------------------+------------------------------------------------- Reporter: webcommsat | Owner: jpantani Type: task | Status: closed (blessed) | Priority: normal | Milestone: 6.1 Component: Help/About | Version: Severity: normal | Resolution: fixed Keywords: | Focuses: ui, accessibility, docs, | administration, ui-copy -------------------------+------------------------------------------------- Comment (by flixos90): Hey @ryelle @davidbaumwald, I know it's extremely late, but I still wanted to share my suggestion just in case: Given that the only part of https://make.wordpress.org/core/2022/10/10/multisite-improvements-in- wordpress-6-1/ that was performance-related was reverted prior to 6.1 release, I wonder whether we should remove that concrete link from the About page's performance section. Is that still feasible before the release? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 16:04:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 16:04:17 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 In-Reply-To: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> References: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> Message-ID: <072.deadf2f5feecca4ccf763da2b7ef4807@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -------------------------------------------------+------------------------- Reporter: davidbaumwald | Owner: | davidbaumwald Type: task (blessed) | Status: reopened Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: Keywords: has-patch commit dev-feedback | Focuses: fixed-major | -------------------------------------------------+------------------------- Comment (by desrosj): Updating from 6.0.3 to RC5, I get the following output: {{{ Updating to version 6.1-RC5 (en_US)... Downloading update from https://wordpress.org/wordpress-6.1-RC5.zip... Unpacking the update... Cleaning up files... File removed: wp-includes/blocks/post-comments.php File removed: wp-includes/blocks/post-comments/editor.min.css File removed: wp-includes/blocks/post-comments/style-rtl.min.css File removed: wp-includes/blocks/post-comments/block.json File removed: wp-includes/blocks/post-comments/editor.css File removed: wp-includes/blocks/post-comments/style.min.css File removed: wp-includes/blocks/post-comments/editor-rtl.css File removed: wp-includes/blocks/post-comments/editor-rtl.min.css File removed: wp-includes/blocks/post-comments/style-rtl.css File removed: wp-includes/blocks/post-comments/style.css File removed: wp-includes/blocks/comments-query-loop/editor.min.css File removed: wp-includes/blocks/comments-query-loop/block.json File removed: wp-includes/blocks/comments-query-loop/editor.css File removed: wp-includes/blocks/comments-query-loop/editor-rtl.css File removed: wp-includes/blocks/comments-query-loop/editor-rtl.min.css 15 files cleaned up. Success: WordPress updated successfully. }}} In my testing, it seems that files within `wp-content/themes/*` are not flagged during Core upgrades and can probably be left out from this list. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 16:08:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 16:08:14 -0000 Subject: [wp-trac] [WordPress Trac] #56217: Add video rotation info in wp_read_video_metadata() In-Reply-To: <051.692fb5cebe7fff5d9daa1cea4293fab8@wordpress.org> References: <051.692fb5cebe7fff5d9daa1cea4293fab8@wordpress.org> Message-ID: <066.a72664c8dda9fda1fafe01b7110322bf@wordpress.org> #56217: Add video rotation info in wp_read_video_metadata() --------------------------------------+------------------------------ Reporter: opajaap | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.0 Severity: normal | Resolution: Keywords: has-unit-tests has-patch | Focuses: --------------------------------------+------------------------------ Comment (by opajaap): Correction: only rquired: {{{#!php if ( ! empty( $data['video']['rotate'] ) ) { $metadata['rotate'] = $data['video']['rotate']; } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 16:21:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 16:21:30 -0000 Subject: [wp-trac] [WordPress Trac] #56429: Gutenberg author box missing In-Reply-To: <052.c99517d8ac2a29619567946035964902@wordpress.org> References: <052.c99517d8ac2a29619567946035964902@wordpress.org> Message-ID: <067.477e325817ef94d95311a92e6784d008@wordpress.org> #56429: Gutenberg author box missing -------------------------------------+------------------------------------- Reporter: lgadzhev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.0.1 Severity: normal | Resolution: Keywords: needs-patch needs- | Focuses: javascript, testing-info | administration, rest-api -------------------------------------+------------------------------------- Comment (by vabrashev): Will try to add the missing info: == Testing Instructions These steps define how to reproduce the issue, and indicate the expected behavior. === Steps to Reproduce 1. Log in to your local WP installation and create 100 "dummy" users with role Editor. If you have wp CLI enabled you can use this command `for i in {1..100}; do wp user create editor${i} editor${i}@editor${i}.com --user_pass=editor${i} --role=editor; done`. This will create 100 users with equal combination of username and password like "usernameN"/"passwordN", e.g. editor1/editor1, editor2/editor2, editor3/editor3, etc. 2. Log in with user "editor1", create a new "Test Post" and set the Author to "editor99" (by searching in the input field) - https://i.imgur.com/Lxw1ybe.png 3. 🐞 Log in in incognito mode or with a different browser with user "editor2" and open the very same post. You will notice that the Author post is not visible and you cannot change the Author - https://i.imgur.com/vG9QrTf.png === Expected Results When testing a patch to validate it works as expected: - ✅ The Author box should always be visible whether it's in the first 50 users in the dropdown ordered alphabetically or not. Every editor should have the ability to see who's the author of the post and have the ability to change it. When reproducing a bug: - ❌ The bug happens when inside a WP installation there are more than around 50 users. When a user enters the Block Editor, the author dropdown shows around 60 users max - https://nimb.ws/EtcaeH. You can freely use the dropdown search, even for editors but still, the initial load shows only around 50 users in the dropdown. Normally this is fetching the first users in alphabetical order. If the user is among the first 50 users, it's going to be shown as the author of the post and everything will be fine but if it's not, the Block Editor will make an additional call to fetch that specific user. Unlike the call that is used for the dropdown's search, this call returns more information about the user and requires some additional capabilities, which Editors as user role don't have and it's breaking the author box -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 16:25:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 16:25:31 -0000 Subject: [wp-trac] [WordPress Trac] #56899: Twenty Twenty-Three: Quote block's citation styling cannot be changed In-Reply-To: <057.0c59d600ceeb392e198699de0a835a2e@wordpress.org> References: <057.0c59d600ceeb392e198699de0a835a2e@wordpress.org> Message-ID: <072.8ab0f8ce2b292721e10de32586466b1b@wordpress.org> #56899: Twenty Twenty-Three: Quote block's citation styling cannot be changed ---------------------------+------------------------------ Reporter: severinepozzo | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: css ---------------------------+------------------------------ Comment (by ndiego): I have updated this issue upstream with additional details from the Trac ticket: https://github.com/WordPress/gutenberg/issues/40922 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 17:49:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 17:49:34 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.1e7d7c1748a117586b875a0f22736fec@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by sethta): We are also getting the same issue on our plugin in the WP repo (mediavine-create). Because we didn't discover/confirm the issue until Friday, and this affects most of our SQL queries for the plugin, we know we can't QA a release to go out before WP 6.1 is released. The update to 6.1 breaks the ability to add or edit any custom content as we are using custom tables and have some `LIKE` queries that take place before we save to the database. Our solution is less than ideal as we have to adjust the prepare placeholder so it's just a string placeholder without any added `%%`, and then change the value to be `%%$value%%`. We have our QA team checking functionality right now so we can release soon, but we are currently advising publishers using Create to ''not'' update to 6.1 until after we have pushed out a release. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 18:04:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 18:04:11 -0000 Subject: [wp-trac] [WordPress Trac] #56935: Various deprecated warnings with WP 6.0.3 and PHP 8.1 Message-ID: <054.19deb927f07bd79101d85766443b2bec@wordpress.org> #56935: Various deprecated warnings with WP 6.0.3 and PHP 8.1 -----------------------------+----------------------------- Reporter: applemango | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 6.0.3 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- I recently tried updating a WP 6.0.3 install to use PHP 8.1 but I immediately get various deprecated warnings from core code. For example here's a selection: Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /home/applhpqm/public_html/wp- includes/formatting.php on line 5385 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/applhpqm/public_html/wp-includes/pluggable.php on line 599 Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/applhpqm/public_html/wp-includes/formatting.php on line 2772 Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/applhpqm/public_html/wp- includes/Requests/Cookie/Jar.php on line 63 Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/applhpqm/public_html/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/applhpqm/public_html/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /home/applhpqm/public_html/wp-includes/Requests/Transport/cURL.php on line 345 Downgrading to 8.0 suppresses the errors. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 18:23:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 18:23:44 -0000 Subject: [wp-trac] [WordPress Trac] #56935: Various deprecated warnings with WP 6.0.3 and PHP 8.1 In-Reply-To: <054.19deb927f07bd79101d85766443b2bec@wordpress.org> References: <054.19deb927f07bd79101d85766443b2bec@wordpress.org> Message-ID: <069.a6ad4b668ea17b19655b2f567fff771f@wordpress.org> #56935: Various deprecated warnings with WP 6.0.3 and PHP 8.1 -----------------------------+------------------------------ Reporter: applemango | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 6.0.3 Severity: normal | Resolution: Keywords: php81 | Focuses: -----------------------------+------------------------------ Changes (by SergeyBiryukov): * keywords: => php81 Old description: > I recently tried updating a WP 6.0.3 install to use PHP 8.1 but I > immediately get various deprecated warnings from core code. > > For example here's a selection: > > Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of > type array|string is deprecated in /home/applhpqm/public_html/wp- > includes/formatting.php on line 5385 > > Deprecated: trim(): Passing null to parameter #1 ($string) of type string > is deprecated in /home/applhpqm/public_html/wp-includes/pluggable.php on > line 599 > > Deprecated: rtrim(): Passing null to parameter #1 ($string) of type > string is deprecated in /home/applhpqm/public_html/wp- > includes/formatting.php on line 2772 > > Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should > either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, > or the #[\ReturnTypeWillChange] attribute should be used to temporarily > suppress the notice in /home/applhpqm/public_html/wp- > includes/Requests/Cookie/Jar.php on line 63 > > Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should > either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, > or the #[\ReturnTypeWillChange] attribute should be used to temporarily > suppress the notice in /home/applhpqm/public_html/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 > > Deprecated: Return type of > Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) > should either be compatible with ArrayAccess::offsetSet(mixed $offset, > mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be > used to temporarily suppress the notice in /home/applhpqm/public_html/wp- > includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 > > Deprecated: http_build_query(): Passing null to parameter #2 > ($numeric_prefix) of type string is deprecated in > /home/applhpqm/public_html/wp-includes/Requests/Transport/cURL.php on > line 345 > > Downgrading to 8.0 suppresses the errors. New description: I recently tried updating a WP 6.0.3 install to use PHP 8.1 but I immediately get various deprecated warnings from core code. For example here's a selection: {{{ Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /home/applhpqm/public_html/wp- includes/formatting.php on line 5385 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/applhpqm/public_html/wp-includes/pluggable.php on line 599 Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/applhpqm/public_html/wp-includes/formatting.php on line 2772 Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/applhpqm/public_html/wp- includes/Requests/Cookie/Jar.php on line 63 Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/applhpqm/public_html/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 40 Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/applhpqm/public_html/wp- includes/Requests/Utility/CaseInsensitiveDictionary.php on line 68 Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /home/applhpqm/public_html/wp-includes/Requests/Transport/cURL.php on line 345 }}} Downgrading to 8.0 suppresses the errors. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 18:26:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 18:26:26 -0000 Subject: [wp-trac] [WordPress Trac] #28983: Admin bar length or Admin bar on two line In-Reply-To: <055.1cc2ce9927c5d66810d9ff533a0d820d@wordpress.org> References: <055.1cc2ce9927c5d66810d9ff533a0d820d@wordpress.org> Message-ID: <070.626fab37fd1f32881678ce6e8ae25cf9@wordpress.org> #28983: Admin bar length or Admin bar on two line -------------------------------------------------+------------------------- Reporter: korobochkin | Owner: KZeni Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future | Release Component: Toolbar | Version: 4.3 Severity: normal | Resolution: Keywords: has-patch needs-testing needs- | Focuses: ui, css design-feedback | -------------------------------------------------+------------------------- Comment (by KZeni): *Just in case it isn't obvious, my GitHub comment just now (see above) was saying it's been more than a year since the last message about this topic. Meanwhile, the fact of the matter is that this has been a shortcoming in WordPress that was reported about 8 years ago according to this ticket. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 18:30:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 18:30:11 -0000 Subject: [wp-trac] [WordPress Trac] #43936: Settings: Warn when open registration and new user default is privileged In-Reply-To: <051.6cb6d8867fe37496c3fb9d274b59f535@wordpress.org> References: <051.6cb6d8867fe37496c3fb9d274b59f535@wordpress.org> Message-ID: <066.1400d05e2b4ea0f3519e65eacd59f88c@wordpress.org> #43936: Settings: Warn when open registration and new user default is privileged -------------------------------------+----------------------------- Reporter: kraftbj | Owner: SergeyBiryukov Type: feature request | Status: reviewing Priority: normal | Milestone: Future Release Component: Security | Version: Severity: major | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Changes (by generosus): * component: Users => Security * severity: normal => major Comment: Any plans to revive this topic? I support the following: 1. Issue a Site Health warning when the **New User Default Role** selected is **Administrator**. 2. Add a new settings checkbox titled: {{{Allow New User Default Role: Administrator}}} Checkbox to be located next to (or below) the **New User Default Role** setting. When the checkbox is checked, the Site Health warning disappears. Update appreciated. You guys rock! Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 18:47:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 18:47:11 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.9f036d41a13a2709f10c0baed8b84902@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by desrosj): As an update here. It was decided that the changes from #52506 will be reverted and an RC6 will be made available at some point in the next 6-8 hours. This should address all of the problems described here, but testing and confirmation would be greatly appreciated. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 18:51:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 18:51:02 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.5678c74663202daa36fcc7a6941b7c00@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by AlanP57): If is noted here when the RC is released, then I will download and test it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 18:52:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 18:52:30 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.4664534bd2c4c9222391d73552c2d26d@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * Attachment "56933.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 19:00:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 19:00:32 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * Attachment "56933.diff" removed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 19:00:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 19:00:32 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.8770fbfff1f9198bfc1808715215f4e2@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries --------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * Attachment "56933.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 19:16:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 19:16:46 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.badc668f033ab5fa5de9dabc72eba78e@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries ------------------------------+--------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: has-testing-info | Focuses: ------------------------------+--------------------- Changes (by hellofromTonya): * keywords: => has-testing-info Comment: [https://github.com/WordPress/wordpress-develop/pull/3541 PR 3541] is the revert and added test from [https://core.trac.wordpress.org/attachment/ticket/56933/56933.diff 56933.diff]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:03:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:03:00 -0000 Subject: [wp-trac] [WordPress Trac] #44610: Allow Youtube-Player to use youtube-nocookie.com URLS to avoid setting cookies. In-Reply-To: <053.a4bc4e0b7193bee7e68ef8aed576a707@wordpress.org> References: <053.a4bc4e0b7193bee7e68ef8aed576a707@wordpress.org> Message-ID: <068.3b2899eec2666d6fb548873343eceb01@wordpress.org> #44610: Allow Youtube-Player to use youtube-nocookie.com URLS to avoid setting cookies. -------------------------------------------------+------------------------- Reporter: jepperask | Owner: | williampatton Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Embeds | Version: 4.9.7 Severity: normal | Resolution: Keywords: needs-testing has-patch needs-dev- | Focuses: privacy note close | -------------------------------------------------+------------------------- Comment (by didierjm): My 2cts Was sent to this thread, after posting a "non-support" comment [https://wordpress.org/support/topic/youtube-oembed- cookies/#post-16150588] on the Performance Lab plugin page, as IMHO, this would be the "best" place to add such a feature, without modifying the core. The site owner could decide from there to activate (Yes/No) the change globally (with a purge of oEmbed cache to recreate URLs). Even if it's an imperfect solution for privacy, it would be available for those who'd be interested. PS: I have a blog with 2000+ posts containing YT videos. A manual change would be quite a problem for me... -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:15:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:15:37 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.8c19e5e3b599df09b29e317679fbe258@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: has-testing-info => has-testing-info commit has-patch has- unit-tests Comment: [https://github.com/WordPress/wordpress-develop/pull/3541 PR 3541] is now ready for commit. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:20:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:20:39 -0000 Subject: [wp-trac] [WordPress Trac] #56789: Toolbar: screen-reader-shortcut does not have background color until focused In-Reply-To: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> References: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> Message-ID: <070.458d6fd4932ae5caddd1b82eb3babe58@wordpress.org> #56789: Toolbar: screen-reader-shortcut does not have background color until focused -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Toolbar | Version: Severity: minor | Resolution: Keywords: has-patch needs-testing has- | Focuses: screenshots needs-testing-info | accessibility, css -------------------------------------------------+------------------------- Changes (by sabernhardt): * Attachment "56789.reorganizing.patch" added. moving some CSS properties from `:focus` state to unfocused link selector -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:25:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:25:16 -0000 Subject: [wp-trac] [WordPress Trac] #56789: Toolbar: screen-reader-shortcut does not have background color until focused In-Reply-To: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> References: <055.c83decff62001be1a80d72b8c687157d@wordpress.org> Message-ID: <070.9e81153b9b6ae04ac1b453866936a86a@wordpress.org> #56789: Toolbar: screen-reader-shortcut does not have background color until focused -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: Toolbar | Version: Severity: trivial | Resolution: Keywords: has-patch needs-testing has- | Focuses: screenshots needs-testing-info | accessibility, css -------------------------------------------------+------------------------- Changes (by sabernhardt): * severity: minor => trivial Comment: Unfortunately, moving everything but the `top` property to the unfocused selector could break a little. [attachment:"56789.reorganizing.patch"] attempts to move most, with a few duplicated properties. The `:focus` style needs to override these properties for admin (back-end) pages: {{{ a:focus { color: #043959; box-shadow: 0 0 0 1px #4f94d4, 0 0 2px 1px rgba(79, 148, 212, 0.8); outline: 1px solid transparent; } }}} The toolbar link also would need to override these (and possibly other styles from themes) on the front end: {{{ #wpadminbar a:focus { box-shadow: none; } #wpadminbar a:hover { background: none; } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:27:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:27:01 -0000 Subject: [wp-trac] [WordPress Trac] #56817: Investigate new test failure in PHP 8.2 In-Reply-To: <051.f418ad7f782dc369af9113951f836d9b@wordpress.org> References: <051.f418ad7f782dc369af9113951f836d9b@wordpress.org> Message-ID: <066.70f6c13b0f4ef1a8b0d949f0ca56cab4@wordpress.org> #56817: Investigate new test failure in PHP 8.2 -------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.2 Component: General | Version: Severity: normal | Resolution: Keywords: needs-patch php82 | Focuses: -------------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"54732" 54732]: {{{ #!CommitTicketReference repository="" revision="54732" Tests: Temporarily skip WOFF file test on PHP 8.1. A recent change to how WOFF files are processed in PHP 8.2 RC3 has caused a new test failure. The tests was previously skipped on PHP 8.2, however, apparently after a `fileinfo` extension update, it started failing on PHP 8.1 too. This commit adjusts the skipping condition to include PHP 8.1. Follow-up to [54508], [54509]. Reviewed by desrosj, SergeyBiryukov. Merges [54724] to the 6.1 branch. See #56817. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:38:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:38:35 -0000 Subject: [wp-trac] [WordPress Trac] #52506: Add escaping method for table names in SQL queries In-Reply-To: <054.a6f157534378801d055b15fc9931024f@wordpress.org> References: <054.a6f157534378801d055b15fc9931024f@wordpress.org> Message-ID: <069.fd4238da1fc5c20e5bf49caf56e3233f@wordpress.org> #52506: Add escaping method for table names in SQL queries -------------------------------------------------+------------------------- Reporter: tellyworth | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests early | Focuses: commit needs-docs has-dev-note | performance -------------------------------------------------+------------------------- Comment (by hellofromTonya): In [changeset:"54733" 54733]: {{{ #!CommitTicketReference repository="" revision="54733" Database: Revert [53575]. When using `'%%%s%%'` pattern with `$wpdb->prepare()`, it works on 6.0.3 but does not on 6.1-RC. Why? The inserted value is wrapped in quotes on 6.1-RC5 whereas it is not on <= 6.0.3. With 6.1 final release tomorrow, more time is needed to further investigate and test. Reverting this changeset to restore the previous behavior. This commit also adds a dataset for testing the `'%%%s%%'` pattern. Props SergeyBiryukov, hellofromTonya, bernhard-reiter, desrosj, davidbaumwald, jorbin. Fixes #56933. See #52506. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:38:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:38:35 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.4f16b525ea9b3dc2e9ce7c4d85c0e210@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * owner: (none) => hellofromTonya * status: new => closed * resolution: => fixed Comment: In [changeset:"54733" 54733]: {{{ #!CommitTicketReference repository="" revision="54733" Database: Revert [53575]. When using `'%%%s%%'` pattern with `$wpdb->prepare()`, it works on 6.0.3 but does not on 6.1-RC. Why? The inserted value is wrapped in quotes on 6.1-RC5 whereas it is not on <= 6.0.3. With 6.1 final release tomorrow, more time is needed to further investigate and test. Reverting this changeset to restore the previous behavior. This commit also adds a dataset for testing the `'%%%s%%'` pattern. Props SergeyBiryukov, hellofromTonya, bernhard-reiter, desrosj, davidbaumwald, jorbin. Fixes #56933. See #52506. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:40:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:40:01 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.e0f14c39fffd09fdd4ef78e0e1b641b3@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-feedback | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: has-testing-info commit has-patch has-unit-tests => has- testing-info commit has-patch has-unit-tests dev-feedback * status: closed => reopened * resolution: fixed => Comment: Re-opening for backport to 6.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:41:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:41:28 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.6720702b06898949a9e5e2edc7371bba@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-commit | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-testing-info commit has-patch has-unit-tests dev-feedback => has-testing-info commit has-patch has-unit-tests dev-commit Comment: [54733] looks good to backport. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:42:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:42:01 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.1bb37bb82348dd83b2e42abe0070e10d@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-testing-info commit has-patch has-unit-tests dev-feedback => has-testing-info commit has-patch has-unit-tests dev-reviewed Comment: [54733] looks good to backport. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:44:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:44:12 -0000 Subject: [wp-trac] [WordPress Trac] #52506: Add escaping method for table names in SQL queries In-Reply-To: <054.a6f157534378801d055b15fc9931024f@wordpress.org> References: <054.a6f157534378801d055b15fc9931024f@wordpress.org> Message-ID: <069.16af6a5a53e91a9735caf16d655d84ca@wordpress.org> #52506: Add escaping method for table names in SQL queries -------------------------------------------------+------------------------- Reporter: tellyworth | Owner: | davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests early | Focuses: commit needs-docs has-dev-note | performance -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"54734" 54734]: {{{ #!CommitTicketReference repository="" revision="54734" Database: Revert [53575]. When using `'%%%s%%'` pattern with `$wpdb->prepare()`, it works on 6.0.3 but does not on 6.1-RC. Why? The inserted value is wrapped in quotes on 6.1-RC5 whereas it is not on <= 6.0.3. With 6.1 final release tomorrow, more time is needed to further investigate and test. Reverting this changeset to restore the previous behavior. This commit also adds a dataset for testing the `'%%%s%%'` pattern. Props SergeyBiryukov, hellofromTonya, bernhard-reiter, desrosj, davidbaumwald, jorbin. Reviewed by hellofromTonya, SergeyBiryukov. Merges [54733] to the 6.1 branch. Fixes #56933. See #52506. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:44:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:44:13 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.611f2ef5f794e75ab27ae17082c44fb9@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54734" 54734]: {{{ #!CommitTicketReference repository="" revision="54734" Database: Revert [53575]. When using `'%%%s%%'` pattern with `$wpdb->prepare()`, it works on 6.0.3 but does not on 6.1-RC. Why? The inserted value is wrapped in quotes on 6.1-RC5 whereas it is not on <= 6.0.3. With 6.1 final release tomorrow, more time is needed to further investigate and test. Reverting this changeset to restore the previous behavior. This commit also adds a dataset for testing the `'%%%s%%'` pattern. Props SergeyBiryukov, hellofromTonya, bernhard-reiter, desrosj, davidbaumwald, jorbin. Reviewed by hellofromTonya, SergeyBiryukov. Merges [54733] to the 6.1 branch. Fixes #56933. See #52506. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:51:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:51:28 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.a1e3372187d88fadaa6d6d26f726d4c2@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * Attachment "56933-props.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:54:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:54:33 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * Attachment "56933-props.png" removed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:54:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:54:33 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.4c29dc66e8930b5facd7ae3882e01eea@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * Attachment "56933-props.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:54:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:54:47 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.34094eb66dcb4d40ef8c8f9977931f74@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Comment (by hellofromTonya): @AlanP57 Thank you for reporting this issue. The changeset has been reverted on `trunk` and the 6.1 branch and will be bundled 6.1-RC6 for testing. I manually tested and the previous behavior is restored (test report coming). In prepping the commit message, I overlooked including you in the props list as I was focused on the conversations that happened today in Slack. I apologize for not including you in the commit message. However, @SergeyBiryukov has ensured you do get a prop (see [https://core.trac.wordpress.org/attachment/ticket/56933/56933-props.png props pic). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:57:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:57:10 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.49f187208a1d566916b39fa7893f13d0@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): It looks like some props were missed in the commits here. Sorry for that! I have updated the props list for [54733] in the Core Props tool on make/core to include the props for @AlanP57 and @sethta, as well as @threadi for pointing to a relevant ticket on support forums: [attachment:"56933-props.png​"]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:58:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:58:49 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * Attachment "56933-props.png" removed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 20:58:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 20:58:49 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.f5a1dd6c67ff55b08091f68375d548fb@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * Attachment "56933-props.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 21:12:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 21:12:56 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.c688c48da27fb8afbac457efb6de0366@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Comment (by hellofromTonya): = Test Report == Env * Plugins: none active * Must-use plugin: https://gist.github.com/hellofromtonya/de5d59a9c42820f3395667883fac3f19 * Theme: TT2 * WP: 6.0.3 and current 6.1-branch * OS: macOS * localhost: WP Local and wp-env == Test Instructions Note: The hex codes will be different in your testing. * In your test site, create a `mu-plugins` folder inside of `wp-content`. * Copy and paste [https://gist.github.com/hellofromtonya/de5d59a9c42820f3395667883fac3f19 this file] into that new folder. This code is the sample code provided in the ticket's description but made into a must-use plugin for testing purposes. * Using WordPress 6.0.3, open the site in the front-end and note what is rendered on the screen: {{{#!php (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON(wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{ec3ef6eec1ef785abece889c0e9046e9297b06b512e407f3f726977705f81079}hello{ec3ef6eec1ef785abece889c0e9046e9297b06b512e407f3f726977705f81079}') union all (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON( wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{ec3ef6eec1ef785abece889c0e9046e9297b06b512e407f3f726977705f81079}hello{ec3ef6eec1ef785abece889c0e9046e9297b06b512e407f3f726977705f81079}') order by attached_file }}} The hex codes will be different. Note that the `hello` inserted between the hex codes is not wrapped in single quotation marks `}hello{`. * Switch to 6.1-RC5. * Refresh the home page on the front-end. Note that the `hello` string is wrapped in single quotation marks `}'hello'{` 🐞 {{{#!php (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON(wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{b11657509e9e1a989804104976342f19d25c708d637da20f8beca38a8de081be}'hello'{b11657509e9e1a989804104976342f19d25c708d637da20f8beca38a8de081be}') union all (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON( wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{b11657509e9e1a989804104976342f19d25c708d637da20f8beca38a8de081be}'hello'{b11657509e9e1a989804104976342f19d25c708d637da20f8beca38a8de081be}') order by attached_file }}} * Switch to the current 6.1 branch (which has the revert). * Refresh the home page on the front-end. Note the `hello` is no longer wrapped in single quotation marks (`}hello{`) which is the same behavior in 6.0.3. {{{#!php (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'a' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON(wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'mgmlp_media_folder' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{5322ec299a9c19e0eef425bd8c57a795cdf1cde3421a119c904b36219a4d6651}hello{5322ec299a9c19e0eef425bd8c57a795cdf1cde3421a119c904b36219a4d6651}') union all (select wp_posts.ID, post_title, wp_mgmlp_folders.folder_id, pm.meta_value as attached_file, 'b' as item_type from wp_posts LEFT JOIN wp_mgmlp_folders ON( wp_posts.ID = wp_mgmlp_folders.post_id) LEFT JOIN wp_postmeta AS pm ON (pm.post_id = wp_posts.ID) LEFT JOIN wp_users AS us ON (wp_posts.post_author = us.ID) where post_type = 'attachment' and pm.meta_key = '_wp_attached_file' and SUBSTRING_INDEX(pm.meta_value, '/', -1) like '{5322ec299a9c19e0eef425bd8c57a795cdf1cde3421a119c904b36219a4d6651}hello{5322ec299a9c19e0eef425bd8c57a795cdf1cde3421a119c904b36219a4d6651}') order by attached_file }}} == Test Results * Able to reproduce the reported issue 🐞 ✅ * Confirmed the current version of 6.1-branch with the revert PR restores the previous behavior ✅ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 21:18:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 21:18:24 -0000 Subject: [wp-trac] [WordPress Trac] #52506: Add escaping method for table names in SQL queries In-Reply-To: <054.a6f157534378801d055b15fc9931024f@wordpress.org> References: <054.a6f157534378801d055b15fc9931024f@wordpress.org> Message-ID: <069.4d7cae4d667d18fab7f7563b2f591c61@wordpress.org> #52506: Add escaping method for table names in SQL queries -------------------------------------------------+------------------------- Reporter: tellyworth | Owner: | davidbaumwald Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.2 Component: Database | Version: Severity: normal | Resolution: Keywords: has-unit-tests early needs-docs | Focuses: needs-patch | performance -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-patch has-unit-tests early commit needs-docs has-dev-note => has-unit-tests early needs-docs needs-patch * status: closed => reopened * resolution: fixed => * milestone: 6.1 => 6.2 Comment: As noted above, the changes were reverted for 6.1 due to an issue raised in #56933. Reopening to revisit this during the next release cycle. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 21:21:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 21:21:23 -0000 Subject: [wp-trac] [WordPress Trac] #40493: On the Edit User Profile page, prevent losing data when clicking links (was: On the Edit User Profile, open the "You can change your profile picture on Gravatar." link in a new window) In-Reply-To: <053.f4fa2ef129d234ad3a1a75266f8b59be@wordpress.org> References: <053.f4fa2ef129d234ad3a1a75266f8b59be@wordpress.org> Message-ID: <068.ce51d55f1fea2fa626a03ef1bbeaf7dc@wordpress.org> #40493: On the Edit User Profile page, prevent losing data when clicking links -------------------------------------+------------------------------------- Reporter: ashokrane | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Users | Version: Severity: normal | Resolution: Keywords: target-blank has-patch | Focuses: accessibility, needs-refresh | javascript -------------------------------------+------------------------------------- Changes (by sabernhardt): * keywords: target-blank has-patch => target-blank has-patch needs-refresh * focuses: accessibility => accessibility, javascript -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 21:22:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 21:22:50 -0000 Subject: [wp-trac] [WordPress Trac] #56920: Illogical placement link to shortcuts in comments help section. In-Reply-To: <053.e3526365d40ac787c1579dd102595751@wordpress.org> References: <053.e3526365d40ac787c1579dd102595751@wordpress.org> Message-ID: <068.d11d81a7146a97f5788eed2f9af50547@wordpress.org> #56920: Illogical placement link to shortcuts in comments help section. -------------------------------------+------------------------------------- Reporter: NekoJonez | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Help/About | Version: Severity: normal | Resolution: Keywords: needs-patch good-first- | Focuses: ui, accessibility, bug | docs, administration -------------------------------------+------------------------------------- Changes (by sabernhardt): * keywords: => needs-patch good-first-bug * focuses: ui, docs, administration => ui, accessibility, docs, administration Comment: I would like to use exactly the same translatable string for both links. "Documentation on Keyboard Shortcuts" explains the link better than "More information" does, and the user profile link could open in the same tab. We already need a different way to prevent data loss when clicking any other link on the page (#40493). History of the `target` attribute: - r16448 started opening the "More information" link in a new tab. - r38718 removed `target="_blank"` from the help link, yet it's still on the profile page. - @juhise opened #33303 and then moved the patch to ticket:23432#comment:20. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 22:08:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 22:08:46 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.3e6bc9b4b8a578ac7ba531ba9a3b7f21@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Comment (by AlanP57): I can verify that the like query works now in 6.1 RC6. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 22:10:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 22:10:25 -0000 Subject: [wp-trac] [WordPress Trac] #56933: Unexpected quotes around search text in custom LIKE queries In-Reply-To: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> References: <051.32a0330ea0ce6c4bced0d0a808286a18@wordpress.org> Message-ID: <066.ac8ac7292f2904cdc54687c1004c791c@wordpress.org> #56933: Unexpected quotes around search text in custom LIKE queries -------------------------------------------------+------------------------- Reporter: AlanP57 | Owner: | hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.1 Component: Database | Version: 6.1 Severity: normal | Resolution: fixed Keywords: has-testing-info commit has-patch | Focuses: has-unit-tests dev-reviewed | -------------------------------------------------+------------------------- Comment (by hellofromTonya): Replying to [comment:20 AlanP57]: > I can verify that the like query works now in 6.1 RC6. That's very good news. Thank you @AlanP57 for retesting -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 22:56:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 22:56:41 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 In-Reply-To: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> References: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> Message-ID: <072.238388609afda9d3778bce84a8f64dbf@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -------------------------------------------------+------------------------- Reporter: davidbaumwald | Owner: | davidbaumwald Type: task (blessed) | Status: closed Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch commit dev-feedback | Focuses: fixed-major | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"54737" 54737]: {{{ #!CommitTicketReference repository="" revision="54737" Upgrade/Install: Update `$_old_files` for 6.1. Props davidbaumwald, SergeyBiryukov. Reviewed by desrosj, SergeyBiryukov. Merges [54730] to the 6.1 branch. Fixes #56934. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 23:39:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 23:39:35 -0000 Subject: [wp-trac] [WordPress Trac] #56936: Remove bundled theme files from $_old_files Message-ID: <058.54e5f1bdf2e4f44a25972b68950f9e04@wordpress.org> #56936: Remove bundled theme files from $_old_files -----------------------------+-------------------- Reporter: SergeyBiryukov | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.2 Component: Upgrade/Install | Version: Severity: normal | Keywords: Focuses: | -----------------------------+-------------------- Per @desrosj in comment:4:ticket:56934: > I'm wondering about including the deleted theme files here. Except 6.0, I don't see any additional `wp-content/themes/*` entries in the list. > > As far as I know, themes are not included with update packages unless it's the first release being included (and they are not intentionally skipped with the `CORE_UPGRADE_SKIP_NEW_BUNDLED` constant). > > ... > > In my testing, it seems that files within `wp-content/themes/*` are not flagged during Core upgrades and can probably be left out from this list. Based on the above, it looks like bundled theme files should be removed from the list and a note should be added to clarify that for future updates. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Oct 31 23:40:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 31 Oct 2022 23:40:50 -0000 Subject: [wp-trac] [WordPress Trac] #56934: Update `$_old_files` array for version 6.1 In-Reply-To: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> References: <057.e1a742e2067f6c40716251ff117260ef@wordpress.org> Message-ID: <072.bc3a44c41e3d32196823ad22e79e1d62@wordpress.org> #56934: Update `$_old_files` array for version 6.1 -------------------------------------------------+------------------------- Reporter: davidbaumwald | Owner: | davidbaumwald Type: task (blessed) | Status: closed Priority: high | Milestone: 6.1 Component: Upgrade/Install | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch commit dev-feedback | Focuses: fixed-major | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): Replying to [comment:5 desrosj]: > In my testing, it seems that files within `wp-content/themes/*` are not flagged during Core upgrades and can probably be left out from this list. Thanks! In that case, it looks like bundled theme files should be removed from the list and a note should be added to clarify that for future updates. I have created #56936 for that. -- Ticket URL: WordPress Trac WordPress publishing platform