[wp-trac] [WordPress Trac] #56057: Add conditional to WP_Upgrader::install_package() for Rollback testing

WordPress Trac noreply at wordpress.org
Thu Dec 22 00:23:05 UTC 2022


#56057: Add conditional to WP_Upgrader::install_package() for Rollback testing
-----------------------------+-----------------------------
 Reporter:  afragen          |       Owner:  SergeyBiryukov
     Type:  task (blessed)   |      Status:  reopened
 Priority:  normal           |   Milestone:  6.2
Component:  Upgrade/Install  |     Version:  6.1
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+-----------------------------

Comment (by peterwilsoncc):

 As discussed in the
 [https://wordpress.slack.com/archives/CULBN711P/p1671590223585289?thread_ts=1671556005.777899&cid=CULBN711P
 slack thread] yesterday (requires login via
 [https://make.wordpress.org/chat/ make.wordpress.org/chat]) I think the
 preferable approach it to use the `update-custom_{$action}` and `update-
 core-custom_{$action}` hooks to customize the upgrade process for the
 rollback plugin.

 Changing the action on the form submission on either the plugin or core
 upgrade screen will bypass Core's existing update code and allow you to
 replace it wholesale.

 This will offer greater flexibility than the filter proposed
 above/checking for a particular callable.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56057#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list